Re: [PATCH 1/6] drm/amdgpu: Power up UVD 3 for FW validation

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 12:00 PM Timur Kristóf wrote: > > On Mon, 2025-08-04 at 11:20 -0400, Alex Deucher wrote: > > On Mon, Aug 4, 2025 at 9:58 AM Timur Kristóf > > wrote: > > > > > > Unlike later versions, UVD 3 has firmware validation. > > > F

Re: [PATCH 4/6] drm/amd/pm: Fix si_upload_smc_data

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 12:16 PM Timur Kristóf wrote: > > On Mon, 2025-08-04 at 11:32 -0400, Alex Deucher wrote: > > On Mon, Aug 4, 2025 at 9:42 AM Timur Kristóf > > wrote: > > > > > > The si_upload_smc_data function uses si_write_smc_soft_register > >

Re: [PATCH 3/6] drm/radeon: Disable ULV even if unsupported

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 12:09 PM Timur Kristóf wrote: > > On Mon, 2025-08-04 at 11:24 -0400, Alex Deucher wrote: > > On Mon, Aug 4, 2025 at 10:18 AM Timur Kristóf > > wrote: > > > > > > Backport of the same commit to amdgpu. > > > This commit fixes

Re: [PATCH 2/6] drm/amd/pm: Disable ULV even if unsupported

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 12:04 PM Timur Kristóf wrote: > > On Mon, 2025-08-04 at 11:24 -0400, Alex Deucher wrote: > > On Mon, Aug 4, 2025 at 9:58 AM Timur Kristóf > > wrote: > > > > > > This commit fixes some instability on Tahiti. > > > > > >

Re: [PATCH] drm/amdgpu/gfx10: remove redundant repeated null checks

2025-08-04 Thread Alex Deucher
Applied all three patches with a slight tweak to the commit messages to make it clearer what is changing. Alex On Mon, Aug 4, 2025 at 1:25 PM Alex Deucher wrote: > > On Mon, Aug 4, 2025 at 1:15 PM Dan Carpenter wrote: > > > > On Mon, Aug 04, 2025 at 11:08:57AM -0400,

Re: [v6 05/13] drm/amdgpu: Implement active VMID detection in MES12 queue reset for GFX

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 4:48 AM Jesse.Zhang wrote: > > MES queue reset functionality for GFX queues. The changes include: > > 1. Added detection of active VMIDs by reading CP_CNTX_STAT and CP_VMID >registers to properly identify contexts that need resetting > > 2. Implemented fallback to HPD st

Re: [PATCH] drm/amdgpu/gfx10: remove redundant repeated null checks

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 1:15 PM Dan Carpenter wrote: > > On Mon, Aug 04, 2025 at 11:08:57AM -0400, Alex Deucher wrote: > > On Mon, Aug 4, 2025 at 10:49 AM Dan Carpenter > > wrote: > > > > > > On Mon, Aug 04, 2025 at 10:32:43AM -0400, Alex Deucher wrote: &g

Re: [v6 13/13] drm/amdgpu: Implement queue preemption using suspend/resume API

2025-08-04 Thread Alex Deucher
pt/restore for all of the cases where we need to preempt the queues and only use map/unmap for device init/fini and system suspend/resume. Alex > > Signed-off-by: Alex Deucher > Signed-off-by: Jesse Zhang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 64 +

Re: [v6 09/13] drm/amd/amdgpu: Implement MES suspend/resume gang functionality for v12

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 4:48 AM Jesse.Zhang wrote: > > This commit implements the actual MES (Micro Engine Scheduler) suspend > and resume gang operations for version 12 hardware. Previously these > functions were just stubs returning success. > > Signed-off-by: Jesse Zhang > --- > drivers/gpu/dr

Re: [v6 08/13] drm/amdgpu: adjust MES API used for suspend and resume

2025-08-04 Thread Alex Deucher
> in this case. > > V2: replace queue_active with queue state > v3: set the suspend_fence_addr > > Signed-off-by: Alex Deucher > Signed-off-by: Jesse Zhang > --- > drivers/gpu/drm/amd/amdgpu/mes_userqueue.c | 51 ++ > 1 file changed, 51 inser

Re: [v6 04/13] drm/amdgpu: Implement active VMID detection in MES11 queue reset for GFX

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 4:48 AM Jesse.Zhang wrote: > > MES queue reset functionality for GFX queues. The changes include: > > 1. Added detection of active VMIDs by reading CP_CNTX_STAT and CP_VMID >registers to properly identify contexts that need resetting > > 2. Implemented fallback to HPD st

Re: [v6 04/13] drm/amdgpu: Implement active VMID detection in MES11 queue reset for GFX

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 4:48 AM Jesse.Zhang wrote: > > MES queue reset functionality for GFX queues. The changes include: > > 1. Added detection of active VMIDs by reading CP_CNTX_STAT and CP_VMID >registers to properly identify contexts that need resetting > > 2. Implemented fallback to HPD st

Re: [v6 03/13] drm/amdgpu/mes12: implement detect and reset callback

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 4:53 AM Jesse.Zhang wrote: > > From: Alex Deucher > > Implement support for the hung queue detect and reset > functionality. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 37 ++ >

Re: [PATCH 2/7] drm/amd/display: Adjust DCE 8-10 clock, don't overclock by 15%

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 12:35 PM Timur Kristóf wrote: > > On Mon, 2025-08-04 at 11:56 -0400, Alex Deucher wrote: > > On Thu, Jul 31, 2025 at 5:58 AM Timur Kristóf > > wrote: > > > > > > Adjust the nominal (and performance) clocks for DCE 8-10, > > >

Re: [PATCH 7/7] drm/amd/display: Fix fractional fb divider in set_pixel_clock_v3

2025-08-04 Thread Alex Deucher
For reference see the legacy display code: > - amdgpu_pll_compute > - amdgpu_atombios_crtc_program_pll > > This commit fixes set_pixel_clock_v3 by dividing the fractional > feedback divider passed to the function by 10. > > Fixes: 4562236b3bc0 ("drm/amd/dc: Add dc di

Re: [PATCH 6/7] drm/amd/display: Don't print errors for nonexistent connectors

2025-08-04 Thread Alex Deucher
on an index, that is not an error. > > Considering these are not actual errors, don't litter the logs. > > Fixes: 60df5628144b ("drm/amd/display: handle invalid connector indices") > Signed-off-by: Timur Kristóf Acked-by: Alex Deucher > --- > drivers/gpu/dr

Re: [PATCH 5/7] drm/amd/display: Don't warn when missing DCE encoder caps

2025-08-04 Thread Alex Deucher
On Thu, Jul 31, 2025 at 5:53 AM Timur Kristóf wrote: > > On some GPUs the VBIOS just doesn't have encoder caps, > or maybe not for every encoder. > > This isn't really a problem and it's handled well, > so let's not litter the logs with it. > > S

Re: [PATCH 4/7] drm/amd/display: Fill display clock and vblank time in dce110_fill_display_configs

2025-08-04 Thread Alex Deucher
On Thu, Jul 31, 2025 at 5:53 AM Timur Kristóf wrote: > > Also needed by DCE 6. > This way the code that gathers this info can be shared between > different DCE versions and doesn't have to be repeated. > > Signed-off-by: Timur Kristóf Acked-by: Alex Deucher > ---

Re: [PATCH 3/7] drm/amd/display: Find first CRTC and its line time in dce110_fill_display_configs

2025-08-04 Thread Alex Deucher
On Thu, Jul 31, 2025 at 6:03 AM Timur Kristóf wrote: > > dce110_fill_display_configs is shared between DCE 6-11, and > finding the first CRTC and its line time is relevant to DCE 6 too. > Move the code to find it from DCE 11 specific code. > > Signed-off-by: Timur Kristóf Acke

Re: [PATCH 2/7] drm/amd/display: Adjust DCE 8-10 clock, don't overclock by 15%

2025-08-04 Thread Alex Deucher
Polaris") > Fixes: dc88b4a684d2 ("drm/amd/display: make clk mgr soc specific") > Signed-off-by: Timur Kristóf > > x Stray x here. with that fixed: Acked-by: Alex Deucher > --- > .../drm/amd/display/dc/clk_mgr/dce100/dce_clk_mgr.c | 12 +--- > 1 f

Re: [PATCH 1/7] drm/amd/display: Don't overclock DCE 6 by 15%

2025-08-04 Thread Alex Deucher
;) > Fixes: dc88b4a684d2 ("drm/amd/display: make clk mgr soc specific") > Fixes: 3ecb3b794e2c ("drm/amd/display: dc/clk_mgr: add support for SI parts > (v2)") > Signed-off-by: Timur Kristóf Acked-by: Alex Deucher > --- > .../gpu/drm/amd/display/dc/clk_m

Re: [PATCH 0/3] DC: Fix page flip timeouts on DCE 6

2025-08-04 Thread Alex Deucher
oot on DCE 6 too. > drm/amd/display: Disable VRR on DCE 6 > drm/amd/display: Don't use non-registered VUPDATE on DCE 6 Series looks good to me, but it would be good to get an ack from the display team as well. Series is: Acked-by: Alex Deucher > > .../gpu/drm/amd/d

Re: [PATCH] drm/amd/display: Fix DP audio DTO1 clock source on DCE 6.

2025-08-04 Thread Alex Deucher
Tahiti. Despite having the > same DCE version, Tahiti seems to have a different audio device. > After some trial and error I realized that it works with the > default display clock as reported by the VBIOS, not the current > display clock. > This looks good to me, but it would be goo

[PATCH] drm/amdgpu: add missing vram lost check for LEGACY RESET

2025-08-04 Thread Alex Deucher
Legacy resets reset the memory controllers so VRAM contents may be unreliable after reset. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu

Re: [PATCH 5/6] drm/radeon: Fix si_upload_smc_data

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 9:48 AM Timur Kristóf wrote: > > Backport of the fix to the same amdgpu issue. > > The si_upload_smc_data function uses si_write_smc_soft_register > to set some register values in the SMC, and expects the result > to be PPSMC_Result_OK which is 1. > > The PPSMC_Result_OK / P

Re: [PATCH 4/6] drm/amd/pm: Fix si_upload_smc_data

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 9:42 AM Timur Kristóf wrote: > > The si_upload_smc_data function uses si_write_smc_soft_register > to set some register values in the SMC, and expects the result > to be PPSMC_Result_OK which is 1. > > The PPSMC_Result_OK / PPSMC_Result_Failed values are used for > checking

Re: [PATCH 3/6] drm/radeon: Disable ULV even if unsupported

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 10:18 AM Timur Kristóf wrote: > > Backport of the same commit to amdgpu. > This commit fixes some instability on Tahiti. Have you tested this with radeon? Alex > > Fixes: a9e61410921b ("drm/radeon/kms: add dpm support for SI (v7)") > Signed-off-by: Timur Kristóf > --- >

Re: [PATCH 2/6] drm/amd/pm: Disable ULV even if unsupported

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 9:58 AM Timur Kristóf wrote: > > This commit fixes some instability on Tahiti. > > Sometimes UVD initialization would fail when using DC. > I suspect this is because DC doesn't immediately turn on the > display clock, so it changes how DPM behaves. Is this the right descrip

Re: [PATCH 1/6] drm/amdgpu: Power up UVD 3 for FW validation

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 9:58 AM Timur Kristóf wrote: > > Unlike later versions, UVD 3 has firmware validation. > For this to work, the UVD should be powered up correctly. > > When DPM is enabled and the display clock is off, > the SMU may choose a power state which doesn't power > the UVD, which ca

Re: [PATCH] drm/amdgpu/gfx10: remove redundant repeated null checks

2025-08-04 Thread Alex Deucher
On Mon, Aug 4, 2025 at 10:49 AM Dan Carpenter wrote: > > On Mon, Aug 04, 2025 at 10:32:43AM -0400, Alex Deucher wrote: > > On Sat, Aug 2, 2025 at 4:22 AM Ethan Carter Edwards > > wrote: > > > > > > The repeated checks on grbm_soft_reset are unnecessary. Remo

Re: [PATCH] amdgpu/amdgpu_discovery: increase timeout limit for IFWI init

2025-08-04 Thread Alex Deucher
On Thu, Jul 31, 2025 at 6:49 PM Xaver Hugl wrote: > > With a timeout of only 1 second, my rx 5700XT fails to initialize, > so this increases the timeout to 2s. > > Closes https://gitlab.freedesktop.org/drm/amd/-/issues/3697 > > Signed-off-by: Xaver Hugl > Cc: sta...@vger.kernel.org Applied. Tha

Re: [PATCH] amdgpu doc: Remove VCE support as OLAND's features

2025-08-04 Thread Alex Deucher
Applied. Thanks! Alex On Sat, Aug 2, 2025 at 10:38 PM Alexandre Demers wrote: > > OLAND doesn't support VCE at all, but it does support UVD (3 or 4, > depending of the sources). > > Signed-off-by: Alexandre Demers > --- > Documentation/gpu/amdgpu/dgpu-asic-info-table.csv | 2 +- > 1 file chan

Re: radeon_fbdev_river_fbdev: failed to initialize framebuffer and setup emulaton

2025-08-04 Thread Alex Deucher
On Sun, Aug 3, 2025 at 11:28 AM Christian Zigotzky wrote: > > Hello, > > I have the same issue on another machine either. Blank screen during the > boot. The Radeon graphics framebuffer device doesn't work anymore. > > Here is the modifed code from the DRM updates (drm-next-2025-07-30): > > - > ht

Re: [PATCH] drm/amdgpu/gfx9: remove redundant repeated null checks

2025-08-04 Thread Alex Deucher
On Sat, Aug 2, 2025 at 4:33 AM Ethan Carter Edwards wrote: > > The repeated checks on grbm_soft_reset are unnecessary. Remove them. > Same comment as the gfx10 patch. These are necessary. Alex > Signed-off-by: Ethan Carter Edwards > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 24 ++

Re: [PATCH] drm/amdgpu/gfx9.4.3: remove redundant repeated null checks

2025-08-04 Thread Alex Deucher
On Sat, Aug 2, 2025 at 4:28 AM Ethan Carter Edwards wrote: > > The repeated checks on grbm_soft_reset are unnecessary. Remove them. > Same comment as the gfx10 patch. These are necessary. Alex > Signed-off-by: Ethan Carter Edwards > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 24

Re: [PATCH] drm/amdgpu/gfx10: remove redundant repeated null checks

2025-08-04 Thread Alex Deucher
On Sat, Aug 2, 2025 at 4:22 AM Ethan Carter Edwards wrote: > > The repeated checks on grbm_soft_reset are unnecessary. Remove them. > These are not NULL checks and they are necessary. The code is checking if any bits are set in that register. If not, then we can skip that code as there is nothi

Re: [PATCH] drm/amdgpu/discovery: fix fw based ip discovery

2025-08-04 Thread Alex Deucher
Ping? Alex On Wed, Jul 30, 2025 at 12:18 PM Alex Deucher wrote: > > We only need the fw based discovery table for sysfs. No > need to parse it. Additionally parsing some of the board > specific tables may result in incorrect data on some boards. > just load the binary and do

Re: [PATCH v1] drm/amdgpu: give each kernel job a unique id

2025-08-01 Thread Alex Deucher
might get confused, but I think that would be easy to fix. Seems reasonable to land this. Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 ++- > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 ++-- >

Re: [PATCH RFC 5/6] drm/amdgpu: don't wake up the GPU for mmGB_ADDR_CONFIG register read

2025-08-01 Thread Alex Deucher
On Fri, Aug 1, 2025 at 2:11 AM Philipp Zabel wrote: > > On Thu, Jul 31, 2025 at 9:38 PM Alex Deucher wrote: >> >> On Thu, Jul 31, 2025 at 3:33 AM Philipp Zabel >> wrote: >> > >> > Don't wake the GPU if libdrm queries the mmGB_ADDR_CONFIG regist

Re: [PATCH] drm/amdgpu: Update SDMA firmware version check for user queue support

2025-08-01 Thread Alex Deucher
nflicts between MCU_DBG0 and MCU_DBG1. > > Signed-off-by: Jesse Zhang Please add: Fixes: 71f82efdc1ad ("drm/amdgpu/sdma7: add ucode version checks for userq support") With that, Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c | 2 +- > 1

Re: [PATCH RFC 5/6] drm/amdgpu: don't wake up the GPU for mmGB_ADDR_CONFIG register read

2025-07-31 Thread Alex Deucher
On Thu, Jul 31, 2025 at 3:33 AM Philipp Zabel wrote: > > Don't wake the GPU if libdrm queries the mmGB_ADDR_CONFIG register > value during amdgpu_query_gpu_info_init(). Instead, return the already > cached value adev->gfx.config.gb_addr_config. > > Link: https://gitlab.freedesktop.org/drm/amd/-/is

[pull] amdgpu drm-fixes-6.17

2025-07-31 Thread Alex Deucher
- DC reset fixes - DCN 3.0.1 fix - MMHUB client mapping fix ---- Alex Deucher (2): drm/amdgpu: track whether a queue is a kernel queue in amdgpu_mqd_prop drm/amdgpu: update mmhub 4.1.0 client id mappings Dillon Varone (1):

[PATCH] drm/amdgpu/discovery: fix fw based ip discovery

2025-07-30 Thread Alex Deucher
/4441 Fixes: 80a0e8282933 ("drm/amdgpu/discovery: optionally use fw based ip discovery") Cc: sta...@vger.kernel.org Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 72 ++- 2 files changed

[PATCH 1/2] drm/amdgpu: update mmhub 3.0.1 client id mappings

2025-07-29 Thread Alex Deucher
Update the client id mapping so the correct clients get printed when there is a mmhub page fault. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_1.c | 57 +-- 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 2/2] drm/amdgpu: update mmhub 3.3 client id mappings

2025-07-29 Thread Alex Deucher
Update the client id mapping so the correct clients get printed when there is a mmhub page fault. v2: fix typos spotted by David Wu. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c | 105 +++- 1 file changed, 104 insertions(+), 1 deletion(-) diff

Re: [PATCH 3/3] drm/amd/display: Fix DCE 6.0 and 6.4 PLL programming.

2025-07-29 Thread Alex Deucher
Applied patches 2 and 3. Is 1 still needed with the other patch Alex mentioned? Thanks! Alex On Tue, Jul 22, 2025 at 12:23 PM Timur Kristóf wrote: > > Apparently, both DCE 6.0 and 6.4 have 3 PLLs, but PLL0 can only > be used for DP. Make sure to initialize the correct amount of PLLs > in DC fo

Re: [PATCH] drm/amdgpu: keep job->vm in amdgpu_job_prepare_job

2025-07-29 Thread Alex Deucher
escription? With that included, the patch is Reviewed-by: Alex Deucher > Perhaps the dependencies between tasks should be resolved by the drm instead > of amdgpu. If we can do that or check the dependencies via the job itself that would be better in the long term. Alex > > uint64_t

Re: [PATCH v2] drm/amd: Use drm_*() macros instead of DRM_*() for amdgpu_cs

2025-07-28 Thread Alex Deucher
wn in the messages. > > Signed-off-by: Mario Limonciello Reviewed-by: Alex Deucher > --- > v2: > * use adev_to_drm (Lijo) > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --g

Re: [PATCH] drm: don't run atomic_async_check for disabled planes

2025-07-28 Thread Alex Deucher
On Wed, Jul 23, 2025 at 11:08 AM Xaver Hugl wrote: > > It's entirely valid and correct for compositors to include disabled > planes in the atomic commit, and doing that should not prevent async > flips from working. To fix that, this commit skips the async checks > if the plane was and still is no

Re: [PATCH 2/3] drm/amd/display: Don't overwrite dce60_clk_mgr

2025-07-28 Thread Alex Deucher
/display: hide VGH asic specific structs") > Signed-off-by: Timur Kristóf Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c > b/drivers

Re: [PATCH 3/3] drm/amd/display: Fix DCE 6.0 and 6.4 PLL programming.

2025-07-28 Thread Alex Deucher
t_disp_eng_pll > > Signed-off-by: Timur Kristóf Reviewed-by: Alex Deucher > --- > .../display/dc/clk_mgr/dce100/dce_clk_mgr.c | 5 +++ > .../dc/resource/dce60/dce60_resource.c| 34 +++ > 2 files changed, 25 insertions(+), 14 deletions(-) >

Re: [PATCH] drm/amdgpu: keep job->vm in amdgpu_job_prepare_job

2025-07-28 Thread Alex Deucher
On Mon, Jul 28, 2025 at 5:01 AM YuanShang Mao (River) wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Alexander > > Since Christian is on vacation. Could you help review the below patch? > If set job->vm to null in amdgpu_job_prepare_job, the job which >

Re: [PATCH 2/3] drm/amdgpu: update mmhub 3.3 client id mappings

2025-07-28 Thread Alex Deucher
ping? On Fri, Jul 18, 2025 at 4:08 PM Alex Deucher wrote: > > Update the client id mapping so the correct clients > get printed when there is a mmhub page fault. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c | 104 +

Re: [PATCH 1/3] drm/amdgpu: update mmhub 3.0.1 client id mappings

2025-07-28 Thread Alex Deucher
ping? On Fri, Jul 18, 2025 at 4:08 PM Alex Deucher wrote: > > Update the client id mapping so the correct clients > get printed when there is a mmhub page fault. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_1.c | 57 +--

Re: [PATCH] drm/amdgpu: skip mgpu fan boost for multi-vf

2025-07-28 Thread Alex Deucher
On Mon, Jul 28, 2025 at 9:18 AM Yunxiang Li wrote: > > On multi-vf setup if the VM have two vf assigned, perhaps from two > different gpus, mgpu fan boost will fail. > > Signed-off-by: Yunxiang Li Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_devi

Re: [PATCH 1/2] drm/amd: Restore cached power limit during resume

2025-07-28 Thread Alex Deucher
Series is: Acked-by: Alex Deucher On Thu, Jul 24, 2025 at 11:18 PM Mario Limonciello wrote: > > From: Mario Limonciello > > The power limit will be cached in smu->current_power_limit but > if the ASIC goes into S3 this value won't be restored. > > Restor

Re: [PATCH] Revert "drm/amd/display: Fix AMDGPU_MAX_BL_LEVEL value"

2025-07-28 Thread Alex Deucher
, > > caps->ac_level, caps->dc_level); > > } else > > - props.brightness = props.max_brightness = MAX_BACKLIGHT_LEVEL; > > + props.brightness = props.max_brightness = AMDGPU_MAX_BL_LEVEL; > > This bottom hunk doesn't need to revert, that one is fine. The other > two need to be reverted though to fix this issue. With that fixed, the patch is: Acked-by: Alex Deucher

[PATCH 2/2] Documentation: add RDNA4 dGPUs

2025-07-28 Thread Alex Deucher
-radeon-rx-9060xt.html https://www.amd.com/en/products/graphics/desktops/radeon/9000-series/amd-radeon-rx-9060xt-8gb.html Signed-off-by: Alex Deucher --- Documentation/gpu/amdgpu/dgpu-asic-info-table.csv | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/gpu/amdgpu/dgpu-asic-info

[PATCH 1/2] Documentation: update APU and dGPU tables with MP0/1 info

2025-07-28 Thread Alex Deucher
Add MP1 for APUs and MP0 and MP1 details for dGPUs. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3905 Signed-off-by: Alex Deucher --- .../gpu/amdgpu/amd-hardware-list-info.rst | 4 +- .../gpu/amdgpu/apu-asic-info-table.csv| 34 +-- .../gpu/amdgpu/dgpu-asic-info

Re: [PATCH] drm/amdgpu: Fix kdoc style in amdgpu_fence.c

2025-07-28 Thread Alex Deucher
> drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:742: warning: This comment starts > with '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst > * Kernel queue reset handling > > Cc: Christian König > Cc: Alex Deucher > Signed-off-by:

Re: Need help to dig into X11 display freezing (Renoir, Xen/QubesOS)

2025-07-28 Thread Alex Deucher
On Sun, Jul 20, 2025 at 10:39 AM Yann Dirson wrote: > > Hello there, > > For a few months I've been experiencing occasional freezes of the X11 display > on my QubesOS RENOIR laptop. The setup is pretty much standard for QubesOS, > with both GPUs attached to dom0 and XFCE running there (and the dG

Re: [PATCH 3/3] Documentation/amdgpu: add a few acronyms to glossary

2025-07-28 Thread Alex Deucher
On Sun, Jul 20, 2025 at 10:23 AM Yann Dirson wrote: > > Signed-off-by: Yann Dirson > --- > > Notes (patch): > test patch note > > Documentation/gpu/amdgpu/amdgpu-glossary.rst | 3 +++ > Documentation/gpu/amdgpu/display/dc-glossary.rst | 3 +++ > 2 files changed, 6 insertions(+) > > diff

Re: [PATCH 2/3] drm/amdgpu: fix module parameter description

2025-07-28 Thread Alex Deucher
Applied the first two patches with some minor changes. Alex On Sun, Jul 20, 2025 at 10:14 AM Yann Dirson wrote: > > Signed-off-by: Yann Dirson > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amd

Re: A few more items for the glossary, and understanding GPU switching

2025-07-28 Thread Alex Deucher
On Sat, Jul 19, 2025 at 7:58 PM Yann Dirson wrote: > > Hello, > > Back to reading some amdgpu code, I stumbled on a few things that probably > ought > to be added to the glossary. Well, to be fair, I actually just had to read > the kernel > logs to see most of them, so those likely make sense t

Re: [PATCH] drm/amdgpu: Raven: don't allow mixing GTT and VRAM

2025-07-28 Thread Alex Deucher
On Tue, Jul 22, 2025 at 9:54 AM Leo Li wrote: > > > > On 2025-07-22 07:21, Thadeu Lima de Souza Cascardo wrote: > > On Fri, Jul 18, 2025 at 07:00:39PM -0400, Alex Deucher wrote: > >> On Fri, Jul 18, 2025 at 6:01 PM Leo Li wrote: > >>> > >>>

Re: Regression: DDC I2C Display Freezing for internal displays

2025-07-20 Thread Alex Deucher
On Sat, Jul 19, 2025 at 1:38 PM Felix Richter wrote: > > On 7/19/25 14:23, Mario Limonciello wrote: > > > > On 7/19/25 5:10 AM, Felix Richter wrote: > >> Thanks for the reply. > >> > >> I am aware that i can read and `edid` via sysfs from the drm device. > >> I did not know about `drm_info` but fr

Re: [PATCH] drm/amdgpu: Raven: don't allow mixing GTT and VRAM

2025-07-18 Thread Alex Deucher
On Fri, Jul 18, 2025 at 6:01 PM Leo Li wrote: > > > > On 2025-07-18 17:33, Alex Deucher wrote: > > On Fri, Jul 18, 2025 at 5:02 PM Leo Li wrote: > >> > >> > >> > >> On 2025-07-18 16:07, Alex Deucher wrote: > >>> On Fri, Jul 18,

Re: [PATCH] drm/amdgpu: Raven: don't allow mixing GTT and VRAM

2025-07-18 Thread Alex Deucher
On Fri, Jul 18, 2025 at 5:02 PM Leo Li wrote: > > > > On 2025-07-18 16:07, Alex Deucher wrote: > > On Fri, Jul 18, 2025 at 1:57 PM Brian Geffon wrote: > >> > >> On Thu, Jul 17, 2025 at 10:59 AM Alex Deucher > >> wrote: > >>>

Re: [PATCH] drm/amdgpu: Raven: don't allow mixing GTT and VRAM

2025-07-18 Thread Alex Deucher
On Fri, Jul 18, 2025 at 1:57 PM Brian Geffon wrote: > > On Thu, Jul 17, 2025 at 10:59 AM Alex Deucher wrote: > > > > On Wed, Jul 16, 2025 at 8:13 PM Brian Geffon wrote: > > > > > > On Wed, Jul 16, 2025 at 5:03 PM Alex Deucher > > > wrote: > >

[PATCH 2/3] drm/amdgpu: update mmhub 3.3 client id mappings

2025-07-18 Thread Alex Deucher
Update the client id mapping so the correct clients get printed when there is a mmhub page fault. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c | 104 +++- 1 file changed, 103 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 1/3] drm/amdgpu: update mmhub 3.0.1 client id mappings

2025-07-18 Thread Alex Deucher
Update the client id mapping so the correct clients get printed when there is a mmhub page fault. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_1.c | 57 +-- 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 3/3] drm/amdgpu: update mmhub 4.1.0 client id mappings

2025-07-18 Thread Alex Deucher
Update the client id mapping so the correct clients get printed when there is a mmhub page fault. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mmhub_v4_1_0.c | 34 +-- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

Re: [PATCH] drm/amdgpu: check if hubbub is NULL in debugfs/amdgpu_dm_capabilities

2025-07-18 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jul 17, 2025 at 4:58 PM Peter Shkenev wrote: > > HUBBUB structure is not initialized on DCE hardware, so check if it is NULL > to avoid null dereference while accessing amdgpu_dm_capabilities file in > debugfs. > > Signed-off-by: Peter Shkenev > --- > drivers/gpu

Re: [PATCH] drm/amdgpu: Wait for bootloader after PSPv11 reset

2025-07-18 Thread Alex Deucher
ic mode-1 reset flow. Increase the retry count for bootloader wait > and also fix the mask to prevent fake pass. > > Signed-off-by: Lijo Lazar Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 19 --- > 1 file changed, 4 insertions(+),

Re: [PATCH 3/3] drm/amdgpu/gfx12: set MQD as appriopriate for queue types

2025-07-18 Thread Alex Deucher
> > Lijo > > Sent: Friday, July 18, 2025 12:13 PM > > To: Deucher, Alexander ; amd- > > g...@lists.freedesktop.org > > Cc: Koenig, Christian > > Subject: Re: [PATCH 3/3] drm/amdgpu/gfx12: set MQD as appriopriate for queue > > types > > > > >

Re: [PATCH] drm/amdgpu: Add NULL check for asic_funcs

2025-07-18 Thread Alex Deucher
On Fri, Jul 18, 2025 at 12:08 AM Lijo Lazar wrote: > > If driver load fails too early, asic_funcs pointer remains unassigned. > Add NULL check to sanitize unwind path. > > Signed-off-by: Lijo Lazar Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_nbi

[pull] amdgpu, amdkfd, radeon drm-next-6.17

2025-07-17 Thread Alex Deucher
uly/093228.html) ---- Alex Deucher (42): drm/amdgpu/gfx9: fix kiq locking in KCQ reset drm/amdgpu/gfx9.4.3: fix kiq locking in KCQ reset drm/amdgpu/gfx10: fix kiq locking in KCQ reset drm/amdgpu/vcn4: add additional

Re: [PATCH v4 3/5] drm/amd: Avoid evicting resources at S5

2025-07-17 Thread Alex Deucher
c: AceLan Kao > Cc: Kai-Heng Feng > Cc: Mark Pearson > Cc: Denis Benato > Cc: Merthan Karakaş > Signed-off-by: Mario Limonciello Acked-by: Alex Deucher > --- > v3: > https://lore.kernel.org/linux-pm/20250609024619.407257-1-supe...@kernel.org/T/#me6db0fb946e3d604a

[pull] radeon, amdgpu drm-fixes-6.16

2025-07-17 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.16. The following changes since commit 347e9f5043c89695b01e66b3ed111755afcf1911: Linux 6.16-rc6 (2025-07-13 14:25:58 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.16-2025-07-17 for you to fe

Re: [PATCH] drm/amdgpu: Raven: don't allow mixing GTT and VRAM

2025-07-17 Thread Alex Deucher
On Wed, Jul 16, 2025 at 8:13 PM Brian Geffon wrote: > > On Wed, Jul 16, 2025 at 5:03 PM Alex Deucher wrote: > > > > On Wed, Jul 16, 2025 at 12:40 PM Brian Geffon wrote: > > > > > > On Wed, Jul 16, 2025 at 12:33 PM Alex Deucher > > > wrote: >

[PATCH 1/3] drm/amdgpu: track whether a queue is a kernel queue in amdgpu_mqd_prop

2025-07-16 Thread Alex Deucher
Used to to set the MQD appropriately for each queue type. Kernel queues have have additional privileges. Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 2 ++ 2 files changed, 3 insertions

[PATCH 3/3] drm/amdgpu/gfx12: set MQD as appriopriate for queue types

2025-07-16 Thread Alex Deucher
Set the MQD as appropriate for the kernel vs user queues. Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c b/drivers/gpu/drm/amd

[PATCH 2/3] drm/amdgpu/gfx11: set MQD as appriopriate for queue types

2025-07-16 Thread Alex Deucher
Set the MQD as appropriate for the kernel vs user queues. Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd

Re: [PATCH] drm/amdgpu: Raven: don't allow mixing GTT and VRAM

2025-07-16 Thread Alex Deucher
On Wed, Jul 16, 2025 at 12:40 PM Brian Geffon wrote: > > On Wed, Jul 16, 2025 at 12:33 PM Alex Deucher wrote: > > > > On Wed, Jul 16, 2025 at 12:18 PM Brian Geffon wrote: > > > > > > Commit 81d0bcf99009 ("drm/amdgpu: make display pinning more flexible &

Re: [PATCH] drm/amd/display: Fix kernel docs for struct mpc_color_caps

2025-07-16 Thread Alex Deucher
On Wed, Jul 16, 2025 at 4:36 PM Alex Hung wrote: > > [WHAT & HOW] > Add kernel-doc for a new struct member "num_rmcm_3dluts". > > This fixes the follow warnings from "make htmldocs". > > ./drivers/gpu/drm/amd/display/dc/dc.h:255: warning: Function parameter > or struct member 'num_rmcm_3dluts' not

Re: [PATCH] drm/amdgpu: Fix missing unlocking in an error path in amdgpu_userq_create()

2025-07-16 Thread Alex Deucher
on") > Signed-off-by: Christophe JAILLET Reviewed-by: Alex Deucher and pushed out to drm-misc-next. Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amd

Re: [PATCH] drm/amd/pm: fix null pointer access

2025-07-16 Thread Alex Deucher
ull pointer dereference. > > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4401 > > Signed-off-by: Umio Yasuno > Acked-by: Alex Deucher > --- > Thank you for your comment. I just fixed the patch message. > > drivers/gpu/drm/amd/pm/amdgpu_pm.c | 5 + > 1 file changed,

Re: [PATCH] drm/amdgpu: Raven: don't allow mixing GTT and VRAM

2025-07-16 Thread Alex Deucher
display pinning more flexible (v2)") > Cc: Luben Tuikov > Cc: Christian König > Cc: Alex Deucher > Cc: sta...@vger.kernel.org # 6.1+ > Tested-by: Thadeu Lima de Souza Cascardo > Signed-off-by: Brian Geffon > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++- &

Re: [PATCH 2/3] drm/amdgpu/gfx11: set MQD as appriopriate for queue priv

2025-07-16 Thread Alex Deucher
On Wed, Jul 16, 2025 at 12:33 AM Lazar, Lijo wrote: > > > > On 7/12/2025 3:21 AM, Alex Deucher wrote: > > Set the MQD as appropriate for the queue priv state. > > > > Acked-by: Christian König > > Signed-off-by: Alex Deucher > > --- >

Re: [PATCH 2/3] drm/amdgpu/gfx11: set MQD as appriopriate for queue priv

2025-07-16 Thread Alex Deucher
d- > > g...@lists.freedesktop.org > > Cc: Koenig, Christian > > Subject: Re: [PATCH 2/3] drm/amdgpu/gfx11: set MQD as appriopriate for > > queue priv > > > > > > > > On 7/12/2025 3:21 AM, Alex Deucher wrote: > > > Set the MQD as appro

Re: [PATCH 3/3] drm/amdgpu/gfx12: set MQD as appriopriate for queue priv

2025-07-15 Thread Alex Deucher
ping on this series. On Fri, Jul 11, 2025 at 6:28 PM Alex Deucher wrote: > > Set the MQD as appropriate for the queue priv state. > > Acked-by: Christian König > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 8 ++-- > 1 file cha

Re: [PATCH 10/33] drm/amdgpu/gfx9.4.3: re-emit unprocessed state on kcq reset

2025-07-15 Thread Alex Deucher
Ping? Alex On Fri, Jul 11, 2025 at 6:48 PM Alex Deucher wrote: > > Re-emit the unprocessed state after resetting the queue. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) >

[PATCH 2/2] drm/amdgpu: move reset support type checks into the caller

2025-07-15 Thread Alex Deucher
Rather than checking in the callbacks, check if the reset type is supported in the caller. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 31 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2

[PATCH 1/2] drm/amdgpu/jpeg: clean up reset type handling

2025-07-15 Thread Alex Deucher
Make the handling consistent with other IPs and across JPEG versions. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 4 +++- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 4 +++- drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 4 +++- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0

Re: [PATCH] drm/amdgpu: Increase reset counter only on success

2025-07-15 Thread Alex Deucher
d only if hard reset succeeded. > > > > Signed-off-by: Lijo Lazar Reviewed-by: Alex Deucher > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 9 +++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu

Re: [PATCH] Revert "drm/amdgpu: Use dma_buf from GEM object instance"

2025-07-15 Thread Alex Deucher
M handles") only solved the problem > partially. They especially don't work for buffer objects without a DRM > framebuffer associated. > > Hence, this revert to going back to using .import_attach->dmabuf. > > Signed-off-by: Thomas Zimmermann Acked-by: Alex Deucher

Re: [PATCH 1/2] drm/radeon: Do not hold console lock while suspending clients

2025-07-15 Thread Alex Deucher
Applied the series. Thanks! Alex On Tue, Jul 15, 2025 at 5:58 AM Thomas Zimmermann wrote: > > The radeon driver holds the console lock while suspending in-kernel > DRM clients. This creates a circular dependency with the client-list > mutex, which is supposed to be acquired first. Reported when

Re: [PATCH V2] drm/amdgpu: make compute timeouts consistent

2025-07-15 Thread Alex Deucher
Ping? On Tue, Jun 24, 2025 at 10:32 PM Alex Deucher wrote: > > For kernel compute queues, align the timeout with > other kernel queues (10 sec). This had previously > been set higher for OpenCL when it used kernel > queues, but now OpenCL uses KFD user queues which > do

Re: [PATCH 01/33] drm/amdgpu: clean up sdma reset functions

2025-07-15 Thread Alex Deucher
_reset flag per ring to do something like - > > amdgpu_ring_is_reset_supported(ring, reset_type) and call > amdgpu_ring_reset()? Yeah, I was thinking about that as a further cleanup once this lands. Alex > > Thanks, > Lijo > > > On 7/12/2025 4:09 AM, Alex Deucher wrote: &

Re: [PATCH] drm/amd/pm: fix null pointer access

2025-07-15 Thread Alex Deucher
; Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4401 Please add your signed-off-by. With that, the patch is: Acked-by: Alex Deucher Alex > --- > drivers/gpu/drm/amd/pm/amdgpu_pm.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/amd/pm/amdgpu

  1   2   3   4   5   6   7   8   9   10   >