Re: [PATCH 4/6] drm/amdgpu: enable pdb0 for hibernation on SRIOV

2025-04-17 Thread Zhang, GuoQing (Sam)
[AMD Official Use Only - AMD Internal Distribution Only] Thank you for the review and the feedback. >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c >> index d90e9daf5a50..83a3444c69d9 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_obj

Re: [PATCH v2 1/3] drm/amdgpu: Don't pin VRAM without DMABUF_MOVE_NOTIFY

2025-04-17 Thread Felix Kuehling
On 2025-04-17 8:57, Christian König wrote: > Am 17.04.25 um 15:33 schrieb Felix Kuehling: >> Pinning of VRAM is for peer devices that don't support dynamic attachment >> and move notifiers. But it requires that all such peer devices are able to >> access VRAM via PCIe P2P. Any device without P2P

[PATCH v3 3/4] drm/amdgpu: Allow P2P access through XGMI

2025-04-17 Thread Felix Kuehling
If peer memory is accessible through XGMI, allow leaving it in VRAM rather than forcing its migration to GTT on DMABuf attachment. Signed-off-by: Felix Kuehling Tested-by: Hao (Claire) Zhou Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 30 -

Re: 回复: [REGRESSION] amdgpu: async system error exception from hdp_v5_0_flush_hdp()

2025-04-17 Thread Alex Deucher
On Thu, Apr 17, 2025 at 8:30 PM Fugang Duan wrote: > > 发件人: Alex Deucher 发送时间: 2025年4月17日 21:08 > >On Wed, Apr 16, 2025 at 8:43 PM Fugang Duan wrote: > >> > >> 发件人: Alex Deucher 发送时间: 2025年4月16日 > >22:49 > >> >收件人: Alexey Klimov On Wed, Apr 16, 2025 at > >> >9:48 AM Alexey Klimov wrote: > >>

[PATCH V8 4/5] drm/amdgpu: change DRM_ERROR to drm_file_err in amdgpu_userqueue.c

2025-04-17 Thread Sunil Khatri
change the DRM_ERROR to drm_file_err to add process name and pid to the logging. Signed-off-by: Sunil Khatri Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 52 +++ 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/am

[PATCH V6 4/5] drm/amdgpu: change DRM_ERROR to drm_file_err in amdgpu_userqueue.c

2025-04-17 Thread Sunil Khatri
change the DRM_ERROR to drm_file_err to add process name and pid to the logging. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 52 +++ 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c

[PATCH v3 1/4] drm/amdgpu: Use allowed_domains for pinning dmabufs

2025-04-17 Thread Felix Kuehling
When determining the domains for pinning DMABufs, filter allowed_domains and fail with a warning if VRAM is forbidden and GTT is not an allowed domain. Fixes: b0dd8c4879ef ("drm/amdgpu: allow pinning DMA-bufs into VRAM if all importers can do P2P") Suggested-by: Christian König Signed-off-by: Fe

[PATCH V6 3/5] drm/amdgpu: use drm_file_err in fence timeouts

2025-04-17 Thread Sunil Khatri
use drm_file_err instead of DRM_ERROR which adds process and pid information in the userqueue error logging. Sample log: [ 42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]] *ERROR* Timed out waiting for fence f=1c74d978 for comm:Xwayland pid:3427 [ 42.444669] [drm:amdgpu_user

[PATCH] drm/amd/display: Fix slab-use-after-free in hdcp

2025-04-17 Thread Mario Limonciello
From: Chris Bainbridge The HDCP code in amdgpu_dm_hdcp.c copies pointers to amdgpu_dm_connector objects without incrementing the kref reference counts. When using a USB-C dock, and the dock is unplugged, the corresponding amdgpu_dm_connector objects are freed, creating dangling pointers in the HD

Re: [PATCH v4 1/5] drm: add macro drm_file_err to print process info

2025-04-17 Thread Jani Nikula
On Thu, 17 Apr 2025, "Khatri, Sunil" wrote: > On 4/16/2025 7:55 PM, Jani Nikula wrote: >> On Wed, 16 Apr 2025, Sunil Khatri wrote: >>> Add a drm helper macro which append the process information for >>> the drm_file over drm_err. >>> >>> Signed-off-by: Sunil Khatri >>> --- >>> include/drm/drm_fi

Re: [PATCH] drm/amd/display: Add NULL pointer checks in dm_force_atomic_commit()

2025-04-17 Thread Aurabindo Pillai
Reviewed-by: Aurabindo Pillai On 2025-04-17 15:30, Srinivasan Shanmugam wrote: This commit updates the dm_force_atomic_commit function to replace the usage of PTR_ERR_OR_ZERO with IS_ERR for checking error states after retrieving the Connector (drm_atomic_get_connector_state), CRTC (drm_atomic_

RE: [PATCH v6 1/5] drm: add macro drm_file_err to print process info

2025-04-17 Thread Khatri, Sunil
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Jani Nikula Sent: Thursday, April 17, 2025 5:00 PM To: Koenig, Christian ; Khatri, Sunil ; dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Tvrtko Ursulin ; Pelloux-

Re: [PATCH V6 3/5] drm/amdgpu: use drm_file_err in fence timeouts

2025-04-17 Thread Khatri, Sunil
On 4/17/2025 7:11 PM, Tvrtko Ursulin wrote: On 17/04/2025 13:31, Sunil Khatri wrote: use drm_file_err instead of DRM_ERROR which adds process and pid information in the userqueue error logging. Sample log: [   42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]] *ERROR* Timed out wait

[PATCH] drm/amd/display: Add NULL pointer checks in dm_force_atomic_commit()

2025-04-17 Thread Srinivasan Shanmugam
This commit updates the dm_force_atomic_commit function to replace the usage of PTR_ERR_OR_ZERO with IS_ERR for checking error states after retrieving the Connector (drm_atomic_get_connector_state), CRTC (drm_atomic_get_crtc_state), and Plane (drm_atomic_get_plane_state) states. The function utili

Re: [PATCH V6 5/5] drm/amdgpu: change DRM_DBG_DRIVER to drm_dbg_driver

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 13:31, Sunil Khatri wrote: update the functions in amdgpu_userqueues.c from DRM_DBG_DRIVER to drm_dbg_driver so multi gpu instance can be logged in. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 8 +--- 1 file changed, 5 insertions(+), 3

Re: [PATCH] drm/amd/display: Fix NULL pointer dereferences in dm_update_crtc_state()

2025-04-17 Thread Aurabindo Pillai
On 2025-03-11 22:34, Srinivasan Shanmugam wrote: Added checks for NULL values after retrieving drm_new_conn_state and drm_old_conn_state to prevent dereferencing NULL pointers. Fixes the below: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:10751 dm_update_crtc_state() w

[PATCH V8 5/5] drm/amdgpu: change DRM_DBG_DRIVER to drm_dbg_driver

2025-04-17 Thread Sunil Khatri
update the functions in amdgpu_userqueues.c from DRM_DBG_DRIVER to drm_dbg_driver so multi gpu instance can be logged in. Signed-off-by: Sunil Khatri Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff

RE: [PATCH 2/2] drm/amdgpu/userq: move waiting for last fence before umap

2025-04-17 Thread Liang, Prike
[Public] Series is Reviewed-by: Prike Liang Regards, Prike > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, April 17, 2025 2:47 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 2/2] drm/amdgpu/userq: move waiting

[PATCH] drm/amdgpu: Fail DMABUF map of XGMI-accessible memory

2025-04-17 Thread Felix Kuehling
If peer memory is XGMI-accessible, we should never access it through PCIe P2P DMA mappings. PCIe P2P is slower, has different coherence behaviour, limited or no support for atomics, or may not work at all. Fail with a warning if DMABUF mappings of such memory are attempted. Signed-off-by: Felix Ku

[PATCH V6 1/5] drm: add drm_file_err function to add process info

2025-04-17 Thread Sunil Khatri
Add a drm helper function which append the process information for the drm_file over drm_err formated output. v5: change to macro from function (Christian Koenig) add helper functions for lock/unlock (Christian Koenig) v6: remove __maybe_unused and make function inline (Jani Nikula) remov

[PATCH V8 3/5] drm/amdgpu: use drm_file_err in fence timeouts

2025-04-17 Thread Sunil Khatri
use drm_file_err instead of DRM_ERROR which adds process and pid information in the userqueue error logging. Sample log: [ 19.802315] amdgpu :0a:00.0: [drm] *ERROR* comm: ibus-x11 pid: 2055 client: Unset ... Couldn't unmap all the queues [ 19.802319] amdgpu :0a:00.0: [drm] *ERROR* co

[PATCH v2 3/3] drm/amdgpu: Optimize DMABuf attachment with XGMI

2025-04-17 Thread Felix Kuehling
When peer memory is accessed through XGMI, it does not need to be visible in the BAR and there is no need for SG-tables or DMA mappings. Signed-off-by: Felix Kuehling Tested-by: Hao (Claire) Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 16 +++- 1 file changed, 15 insertion

[PATCH V8 1/5] drm: add drm_file_err function to add process info

2025-04-17 Thread Sunil Khatri
Add a drm helper function which appends the process information for the drm_file over drm_err formatted output. v5: change to macro from function (Christian Koenig) add helper functions for lock/unlock (Christian Koenig) v6: remove __maybe_unused and make function inline (Jani Nikula) rem

[PATCH v6 4/5] drm/amdgpu: change DRM_ERROR to drm_file_err in amdgpu_userqueue.c

2025-04-17 Thread Sunil Khatri
change the DRM_ERROR to drm_file_err to ad process name and pid to the logging. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 52 +++ 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c b

Re: [PATCH] drm/amdgpu: Refine Cleaner Shader MEC firmware version for GFX10.1.x GPUs

2025-04-17 Thread Alex Deucher
On Thu, Apr 17, 2025 at 11:44 AM Srinivasan Shanmugam wrote: > > Update the minimum firmware version for the Cleaner Shader in the > gfx_v10_0_sw_init function. > > This change adjusts the minimum required firmware version for the MEC > firmware from 152 to 151, allowing for broader compatibility

Re: [PATCH 02/13] drm/amd/display: use drm_edid_product_id for parsing EDID product info

2025-04-17 Thread Melissa Wen
On 15/04/2025 06:32, Michel Dänzer wrote: On 2025-04-11 22:08, Melissa Wen wrote: Since [1], we can use drm_edid_product_id to get debug info from drm_edid instead of directly parsing EDID. Link: https://lore.kernel.org/dri-devel/cover.1712655867.git.jani.nik...@intel.com/ [1] Signed-off-b

Re: [PATCH 3/3] drm/amdgpu: Optimize DMABuf attachment with XGMI

2025-04-17 Thread Felix Kuehling
On 2025-04-16 7:49, Christian König wrote: > Am 16.04.25 um 06:45 schrieb Felix Kuehling: >> When peer memory is accessed through XGMI, it does not need to be visible >> in the BAR and there is no need for SG-tables or DMA mappings. >> >> Signed-off-by: Felix Kuehling >> --- >> drivers/gpu/drm/

[PATCH] drm/amdgpu: Refine Cleaner Shader MEC firmware version for GFX10.1.x GPUs

2025-04-17 Thread Srinivasan Shanmugam
Update the minimum firmware version for the Cleaner Shader in the gfx_v10_0_sw_init function. This change adjusts the minimum required firmware version for the MEC firmware from 152 to 151, allowing for broader compatibility with GFX10.1 GPUs. Fixes: 25961bad9212 ("drm/amdgpu/gfx10: Add cleaner s

Re: [PATCH V6 1/5] drm: add drm_file_err function to add process info

2025-04-17 Thread Khatri, Sunil
For rest of the patches which are part of the amdgpu tree will push incorporating changes as shared by @Tvrtko Ursulin once drm change is merged. Thanks a lot all for the reviews. Regards Sunil Khatri On 4/17/2025 6:01 PM, Sunil Khatri wrote: Add a drm helper function which append the proc

Re: [PATCH V8 06/43] drm/colorop: Add 1D Curve subtype

2025-04-17 Thread Simon Ser
On Tuesday, April 15th, 2025 at 13:12, Borah, Chaitanya Kumar wrote: > On 4/8/2025 10:10 PM, Daniel Stone wrote: > > > As it stands, I've gone through the implementation pretty thoroughly, > > as well as our use of it in Weston. I'm happy with how it looks for > > pre-blend, and I'm even happie

[PATCH v2 2/3] drm/amdgpu: Allow P2P access through XGMI

2025-04-17 Thread Felix Kuehling
If peer memory is accessible through XGMI, allow leaving it in VRAM rather than forcing its migration to GTT on DMABuf attachment. Signed-off-by: Felix Kuehling Tested-by: Hao (Claire) Zhou Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 30 -

[PATCH v3 2/4] drm/amdgpu: Don't pin VRAM without DMABUF_MOVE_NOTIFY

2025-04-17 Thread Felix Kuehling
Pinning of VRAM is for peer devices that don't support dynamic attachment and move notifiers. But it requires that all such peer devices are able to access VRAM via PCIe P2P. Any device without P2P access requires migration to GTT, which fails if the memory is already pinned for another peer device

[PATCH v3 4/4] drm/amdgpu: Optimize DMABuf attachment with XGMI

2025-04-17 Thread Felix Kuehling
When peer memory is accessed through XGMI, it does not need to be visible in the BAR and there is no need for SG-tables or DMA mappings. Signed-off-by: Felix Kuehling Tested-by: Hao (Claire) Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 16 +++- 1 file changed, 15 insertion

[PATCH V8] drm: add drm_file_err function to add process info

2025-04-17 Thread Sunil Khatri
Add a drm helper function which appends the process information for the drm_file over drm_err formatted output. v5: change to macro from function (Christian Koenig) add helper functions for lock/unlock (Christian Koenig) v6: remove __maybe_unused and make function inline (Jani Nikula) rem

Re: [PATCH V6 1/5] drm: add drm_file_err function to add process info

2025-04-17 Thread Khatri, Sunil
On 4/17/2025 7:04 PM, Tvrtko Ursulin wrote: On 17/04/2025 13:31, Sunil Khatri wrote: Add a drm helper function which append the process information for appends Noted the drm_file over drm_err formated output. formatted 'Noted v5: change to macro from function (Christian Koenig)   

Re: [PATCH] drm/amdkfd: Fix some kfd related recover issues

2025-04-17 Thread Philip Yang
On 2025-03-21 19:35, Deng, Emily wrote: [AMD Official Use Only - AMD Internal Distribution Only] [AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Lazar, Lijo Sent: Friday, March 21, 2025 7:06 PM To: Deng, Emily ; amd-gfx@lists.freedesktop.org Subject

Re: [PATCH v2 1/3] drm/amdgpu: Don't pin VRAM without DMABUF_MOVE_NOTIFY

2025-04-17 Thread Christian König
Am 17.04.25 um 15:33 schrieb Felix Kuehling: > Pinning of VRAM is for peer devices that don't support dynamic attachment > and move notifiers. But it requires that all such peer devices are able to > access VRAM via PCIe P2P. Any device without P2P access requires migration > to GTT, which fails if

Re: [PATCH V6 4/5] drm/amdgpu: change DRM_ERROR to drm_file_err in amdgpu_userqueue.c

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 13:31, Sunil Khatri wrote: change the DRM_ERROR to drm_file_err to add process name and pid to the logging. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 52 +++ 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/

Re: [PATCH 03/13] drm/amd/display: parse display name from drm_eld

2025-04-17 Thread Melissa Wen
On 14/04/2025 07:10, Jani Nikula wrote: On Fri, 11 Apr 2025, Melissa Wen wrote: We don't need to parse dc_edid to get the display name since it's already set in drm_eld which in turn had it values updated when updating connector with the opaque drm_edid. Signed-off-by: Melissa Wen --- ..

[PATCH v2 1/3] drm/amdgpu: Don't pin VRAM without DMABUF_MOVE_NOTIFY

2025-04-17 Thread Felix Kuehling
Pinning of VRAM is for peer devices that don't support dynamic attachment and move notifiers. But it requires that all such peer devices are able to access VRAM via PCIe P2P. Any device without P2P access requires migration to GTT, which fails if the memory is already pinned for another peer device

Re: [PATCH V6 3/5] drm/amdgpu: use drm_file_err in fence timeouts

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 13:31, Sunil Khatri wrote: use drm_file_err instead of DRM_ERROR which adds process and pid information in the userqueue error logging. Sample log: [ 42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]] *ERROR* Timed out waiting for fence f=1c74d978 for comm:Xway

Re: [PATCH V6 2/5] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 13:31, Sunil Khatri wrote: drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri --

Re: [PATCH V6 1/5] drm: add drm_file_err function to add process info

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 13:31, Sunil Khatri wrote: Add a drm helper function which append the process information for appends the drm_file over drm_err formated output. formatted v5: change to macro from function (Christian Koenig) add helper functions for lock/unlock (Christian Koenig) v6:

Re: [PATCH] drm/schedular: fix the warning in drm_sched_job_done

2025-04-17 Thread Khatri, Sunil
On 4/17/2025 3:01 PM, Tvrtko Ursulin wrote: [Added Philipp and Danilo to cc.] On 17/04/2025 10:25, Sunil Khatri wrote: Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Signed-off-by: Sunil Khatri

Re: 回复: [REGRESSION] amdgpu: async system error exception from hdp_v5_0_flush_hdp()

2025-04-17 Thread Alex Deucher
On Wed, Apr 16, 2025 at 8:43 PM Fugang Duan wrote: > > 发件人: Alex Deucher 发送时间: 2025年4月16日 22:49 > >收件人: Alexey Klimov > >On Wed, Apr 16, 2025 at 9:48 AM Alexey Klimov > >wrote: > >> > >> On Wed Apr 16, 2025 at 4:12 AM BST, Fugang Duan wrote: > >> > 发件人: Alexey Klimov 发送时间: 2025年4月16 > >日 2:28

[PATCH V6 5/5] drm/amdgpu: change DRM_DBG_DRIVER to drm_dbg_driver

2025-04-17 Thread Sunil Khatri
update the functions in amdgpu_userqueues.c from DRM_DBG_DRIVER to drm_dbg_driver so multi gpu instance can be logged in. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/

[PATCH V6 2/5] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-17 Thread Sunil Khatri
drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

Re: [PATCH 2/2] drm/radeon: fix the warning for radeon_cs_parser_fini

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 10:34, Sunil Khatri wrote: Fix the below warning message. radeon/radeon_cs.c:418: warning: Excess function parameter 'backoff' description in 'radeon_cs_parser_fini' Signed-off-by: Sunil Khatri --- drivers/gpu/drm/radeon/radeon_cs.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH 1/2] drm/ttm: fix the warning for hit_low and evict_low

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 10:34, Sunil Khatri wrote: fix the below warning messages: ttm/ttm_bo.c:1098: warning: Function parameter or struct member 'hit_low' not described in 'ttm_bo_swapout_walk' ttm/ttm_bo.c:1098: warning: Function parameter or struct member 'evict_low' not described in 'ttm_bo_swapou

Re: [PATCH v6 1/5] drm: add macro drm_file_err to print process info

2025-04-17 Thread Jani Nikula
On Thu, 17 Apr 2025, Christian König wrote: > Am 17.04.25 um 13:07 schrieb Jani Nikula: >> On Thu, 17 Apr 2025, Christian König wrote: >>> Am 17.04.25 um 11:35 schrieb Jani Nikula: On Thu, 17 Apr 2025, Sunil Khatri wrote: > Add a drm helper macro which append the process information for

Re: [PATCH V1] drm/amdgpu/userq: add context and seqno of the fence

2025-04-17 Thread Christian König
Am 17.04.25 um 13:15 schrieb Sunil Khatri: > Add context and seqno of the fence in error logging > rather than printing fence ptr. > > Suggested-by: Pierre-Eric Pelloux-Prayer > Suggested-by: Tvrtko Ursulin > Signed-off-by: Sunil Khatri Reviewed-by: Christian König > --- > drivers/gpu/drm/am

[PATCH V1] drm/amdgpu/userq: add context and seqno of the fence

2025-04-17 Thread Sunil Khatri
Add context and seqno of the fence in error logging rather than printing fence ptr. Suggested-by: Pierre-Eric Pelloux-Prayer Suggested-by: Tvrtko Ursulin Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) d

[PATCH v2] drm/sched: fix the warning in drm_sched_job_done

2025-04-17 Thread Sunil Khatri
Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Reviewed-by: Tvrtko Ursulin Signed-off-by: Sunil Khatri --- drivers/gpu/drm/scheduler/sched_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/

Re: [PATCH v1] drm/sched: fix the warning in drm_sched_job_done

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 11:01, Sunil Khatri wrote: Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Reviewed-by: Tvrtko Ursulin Signed-off-by: Sunil Khatri --- drivers/gpu/drm/scheduler/sched_main.c | 1 +

[PATCH] drm/amdgpu/userq: add context and seqno of the fence

2025-04-17 Thread Sunil Khatri
Add context and seqno of the fence in error logging rather than printing fence ptr. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c b/drivers/gpu

Re: [PATCH v1] drm/sched: fix the warning in drm_sched_job_done

2025-04-17 Thread Khatri, Sunil
On 4/17/2025 3:51 PM, Tvrtko Ursulin wrote: On 17/04/2025 11:01, Sunil Khatri wrote: Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Reviewed-by: Tvrtko Ursulin Signed-off-by: Sunil Khatri ---

Re: [PATCH v6 1/5] drm: add macro drm_file_err to print process info

2025-04-17 Thread Jani Nikula
On Thu, 17 Apr 2025, Sunil Khatri wrote: > Add a drm helper macro which append the process information for > the drm_file over drm_err. > > v5: change to macro from function (Christian Koenig) > add helper functions for lock/unlock (Christian Koenig) > > v6: remove __maybe_unused and make func

[PATCH 2/2] drm/radeon: fix the warning for radeon_cs_parser_fini

2025-04-17 Thread Sunil Khatri
Fix the below warning message. radeon/radeon_cs.c:418: warning: Excess function parameter 'backoff' description in 'radeon_cs_parser_fini' Signed-off-by: Sunil Khatri --- drivers/gpu/drm/radeon/radeon_cs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/

[PATCH v6 3/5] drm/amdgpu: use drm_file_err to add process info

2025-04-17 Thread Sunil Khatri
add process and pid information in the userqueue error logging to make it more useful in resolving the error by logs. drm_file_err logs pid and process name by default. Sample log: [ 42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]] *ERROR* Timed out waiting for fence f=1c74d97

Re: [PATCH v6 1/5] drm: add macro drm_file_err to print process info

2025-04-17 Thread Christian König
Am 17.04.25 um 11:35 schrieb Jani Nikula: > On Thu, 17 Apr 2025, Sunil Khatri wrote: >> Add a drm helper macro which append the process information for >> the drm_file over drm_err. >> >> v5: change to macro from function (Christian Koenig) >> add helper functions for lock/unlock (Christian Ko

[PATCH v1] drm/sched: fix the warning in drm_sched_job_done

2025-04-17 Thread Sunil Khatri
Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Reviewed-by: Tvrtko Ursulin Signed-off-by: Sunil Khatri --- drivers/gpu/drm/scheduler/sched_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/

Re: Pipeline vs. no pipeline (Re: [PATCH V8 06/43] drm/colorop: Add 1D Curve subtype)

2025-04-17 Thread Pekka Paalanen
On Tue, 15 Apr 2025 11:29:10 -0400 Harry Wentland wrote: > On 2025-04-10 03:53, Pekka Paalanen wrote: > > On Tue, 8 Apr 2025 13:30:46 -0400 > > Harry Wentland wrote: > > > >> On 2025-04-08 12:40, Daniel Stone wrote: > >>> Hi there, > >>> > >>> On Tue, 1 Apr 2025 at 20:53, Simon Ser wrote:

Re: [PATCH] drm/schedular: fix the warning in drm_sched_job_done

2025-04-17 Thread Tvrtko Ursulin
[Added Philipp and Danilo to cc.] On 17/04/2025 10:25, Sunil Khatri wrote: Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Signed-off-by: Sunil Khatri --- drivers/gpu/drm/scheduler/sched_main.c

[PATCH 1/2] drm/ttm: fix the warning for hit_low and evict_low

2025-04-17 Thread Sunil Khatri
fix the below warning messages: ttm/ttm_bo.c:1098: warning: Function parameter or struct member 'hit_low' not described in 'ttm_bo_swapout_walk' ttm/ttm_bo.c:1098: warning: Function parameter or struct member 'evict_low' not described in 'ttm_bo_swapout_walk' Signed-off-by: Sunil Khatri --- dr

[PATCH] drm/schedular: fix the warning in drm_sched_job_done

2025-04-17 Thread Sunil Khatri
Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Signed-off-by: Sunil Khatri --- drivers/gpu/drm/scheduler/sched_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/scheduler/sch

[PATCH v6 2/5] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-17 Thread Sunil Khatri
drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[PATCH v6 1/5] drm: add macro drm_file_err to print process info

2025-04-17 Thread Sunil Khatri
Add a drm helper macro which append the process information for the drm_file over drm_err. v5: change to macro from function (Christian Koenig) add helper functions for lock/unlock (Christian Koenig) v6: remove __maybe_unused and make function inline (Jani Nikula) remove drm_print.h Sign

[PATCH v6 5/5] drm/amdgpu: change DRM_DBG_DRIVER to drm_dbg_driver

2025-04-17 Thread Sunil Khatri
update the functions in amdgpu_userqueues.c from DRM_DBG_DRIVER to drm_dbg_driver so multi gpu instance can be logged in. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/

Re: [PATCH v4 1/5] drm: add macro drm_file_err to print process info

2025-04-17 Thread Khatri, Sunil
On 4/16/2025 7:55 PM, Jani Nikula wrote: On Wed, 16 Apr 2025, Sunil Khatri wrote: Add a drm helper macro which append the process information for the drm_file over drm_err. Signed-off-by: Sunil Khatri --- include/drm/drm_file.h | 41 + 1 file changed,

Re: [PATCH] drm/amd/include: fix kernel-doc formatting in amd_shared.h

2025-04-17 Thread Jani Nikula
On Wed, 16 Apr 2025, Luke Hofstetter wrote: > when doing make htmldocs, Sphinx complained about in-line documentation > in enum DC_DEBUG_MASK, so reformatted documentation to define each > member in kernel-doc comment above the enum instead. Why? What's the error message exactly? I think what you

[PATCH 6/6] drm/amdgpu: set flip bits for RAS bad pages

2025-04-17 Thread Tao Zhou
Make the code more general, user doesn't need to pay attention to the detail of flip bits setting. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/umc_v12_0.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c b/dr

[PATCH 4/6] drm/amdgpu: implement get_retire_flip_bits for UMC v12

2025-04-17 Thread Tao Zhou
The RAS bad page retire flip bits can be set per vram type, vram vendor and nps mode. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 - drivers/gpu/drm/amd/amdgpu/umc_v12_0.c | 82 +- drivers/gpu/drm/amd/amdgpu/umc_v12_0.h | 2 - 3 files changed,

[PATCH 3/6] drm/amdgpu: add get_retire_flip_bits for UMC

2025-04-17 Thread Tao Zhou
Add the general interface to get flip bits for RAS bad page retirement. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 drivers/gpu/drm/amd/amdgpu/amdgpu_umc.h | 15 +++ 2 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_r

[PATCH 5/6] drm/amdgu: get RAS retire flip bits for HBM3E/HBM4

2025-04-17 Thread Tao Zhou
Get RAS retire flip bits for HBM with different types and vendors in various NPS modes. Also set flip row bit and MCA R13 bit in PA in different NPS modes. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/umc_v12_0.c | 59 ++ drivers/gpu/drm/amd/amdgpu/umc_v12_0.h |

[PATCH 2/6] drm/amdgpu: adjust high bits for RAS retired page

2025-04-17 Thread Tao Zhou
Per UMC address conversion algorithm, the high row bits of UMC MCA address are changed when they're converted into normalized address on specific ASICs. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/umc_v12_0.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff -

[PATCH 1/6] drm/amd: add definitions for new memory type

2025-04-17 Thread Tao Zhou
Support new versions of HBM and GDDR. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 12 drivers/gpu/drm/amd/include/atomfirmware.h | 4 include/uapi/drm/amdgpu_drm.h| 4 3 files changed, 20 insertions(+) diff --

RE: [PATCH v2] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Add error check in fiji_populate_smc_boot_level()

2025-04-17 Thread Feng, Kenneth
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Alex Deucher Sent: Thursday, April 17, 2025 7:03 AM To: Wentao Liang Cc: Feng, Kenneth ; Deucher, Alexander ; Koenig, Christian ; xinhui@amd.com; airl...@gmail.com; sim...@ffwll.ch; amd-gfx@lists.fre

[PATCH] drm/amd/display: adds kernel-doc comment for dc_stream_remove_writeback()

2025-04-17 Thread James Flowers
Adds a kernel-doc for externally linked dc_stream_remove_writeback() function. Signed-off-by: James Flowers --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/displ

Re: [PATCH 4/4] drm/amdgpu: free the evf when the attached bo release

2025-04-17 Thread Christian König
Am 16.04.25 um 16:47 schrieb Liang, Prike: > [Public] > >> From: Koenig, Christian >> Sent: Wednesday, April 16, 2025 7:07 PM >> To: Liang, Prike ; amd-gfx@lists.freedesktop.org >> Cc: Deucher, Alexander >> Subject: Re: [PATCH 4/4] drm/amdgpu: free the evf when the attached bo >> release >> >> A

Re: Pipeline vs. no pipeline (Re: [PATCH V8 06/43] drm/colorop: Add 1D Curve subtype)

2025-04-17 Thread Xaver Hugl
> > The 3x4 CTM colorop is not yet explicit on whether it clamps its inputs > > or outputs. Should all colorops be explicit about it? > > > > Do we expect all HW/drivers to be able to support the same behavior? > Is this critical to using the colorop? It doesn't need to be the same on all hardware,

回复: 回复: [REGRESSION] amdgpu: async system error exception from hdp_v5_0_flush_hdp()

2025-04-17 Thread Fugang Duan
发件人: Alex Deucher 发送时间: 2025年4月16日 22:49 >收件人: Alexey Klimov >On Wed, Apr 16, 2025 at 9:48 AM Alexey Klimov wrote: >> >> On Wed Apr 16, 2025 at 4:12 AM BST, Fugang Duan wrote: >> > 发件人: Alexey Klimov 发送时间: 2025年4月16 >日 2:28 >> >>#regzbot introduced: v6.12..v6.13 >> >> [..] >> >> >>The only chan