Re: [PATCH V6 5/5] drm/amdgpu: change DRM_DBG_DRIVER to drm_dbg_driver

[Tvrtko Ursulin]

On 17/04/2025 13:31, Sunil Khatri wrote:

update the functions in amdgpu_userqueues.c from
DRM_DBG_DRIVER to drm_dbg_driver so multi gpu instance
can be logged in.

Signed-off-by: Sunil Khatri <sunil.kha...@amd.com>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 8 +++++---
  1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c
index 4ef49179bbaf..4729425c04a5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c
@@ -227,7 +227,8 @@ amdgpu_userqueue_get_doorbell_index(struct amdgpu_userq_mgr 
*uq_mgr,

index = amdgpu_doorbell_index_on_bar(uq_mgr->adev, db_obj->obj,

                                             db_info->doorbell_offset, db_size);
-       DRM_DEBUG_DRIVER("[Usermode queues] doorbell index=%lld\n", index);
+       drm_dbg_driver(adev_to_drm(uq_mgr->adev),
+                      "[Usermode queues] doorbell index=%lld\n", index);
        amdgpu_bo_unreserve(db_obj->obj);
        return index;

@@ -254,7 +255,7 @@ amdgpu_userqueue_destroy(struct drm_file *filp, int queue_id) queue = amdgpu_userqueue_find(uq_mgr, queue_id);

        if (!queue) {
-               DRM_DEBUG_DRIVER("Invalid queue id to destroy\n");
+               drm_dbg_driver(adev_to_drm(adev), "Invalid queue id to 
destroy\n");
                mutex_unlock(&uq_mgr->userq_mutex);
                return -EINVAL;
        }
@@ -433,7 +434,8 @@ int amdgpu_userq_ioctl(struct drm_device *dev, void *data,
                break;

default:

-               DRM_DEBUG_DRIVER("Invalid user queue op specified: %d\n", 
args->in.op);
+               drm_dbg_driver(dev, "Invalid user queue op specified: %d\n",
+                              args->in.op);
                return -EINVAL;
        }

Reviewed-by: Tvrtko Ursulin <tvrtko.ursu...@igalia.com>

Regards,

Tvrtko