[PATCH 2/2] drm/amdgpu/vcn: send session ctx along with msg buffer

2025-02-21 Thread boyuan.zhang
From: Boyuan Zhang Session context buffer is required to be sent along with message buffer Signed-off-by: Boyuan Zhang Tested-by: Yinjie Yao --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 43 ++--- 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/

[PATCH 10/24] drm/amd/display: Add SPL namespace

2025-02-21 Thread Zaeem Mohamed
From: Navid Assadian [Why] In order to avoid component conflicts, spl namespace is needed. [How] Adding SPL namespace to the public API os that each user of SPL can have their own namespace. Signed-off-by: Navid Assadian Reviewed-by: Samson Tam --- drivers/gpu/drm/amd/display/dc/sspl/dc_spl.

Re: [PATCH] drm/amdgpu/job: move fix is_guilty logic change

2025-02-21 Thread Alex Deucher
typo in the title fixed up locally. Alex On Fri, Feb 21, 2025 at 10:33 AM Alex Deucher wrote: > > Incrementing the gpu_reset counter needs to be > in the is_guilty block. > > Fixes: f447ba2bbd48 ("drm/amdgpu: Update amdgpu_job_timedout to check if the > ring is guilty") > Cc: Jesse Zhang > Sig

[PATCH 1/2] drm/amdgpu/vcn: add session ctx buffer and flag

2025-02-21 Thread boyuan.zhang
From: Boyuan Zhang Define session context buffer addresses and corresponding flag Signed-off-by: Boyuan Zhang Tested-by: Yinjie Yao --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h b/d

[PATCH 13/24] drm/amd/display: Refactor DCN4x and related code

2025-02-21 Thread Zaeem Mohamed
From: "Patel, Swapnil" [why & how] Refactor existing code related to DCN4x for better code sharing with other modules Reviewed-by: Charlene Liu Signed-off-by: Swapnil Patel Signed-off-by: Zaeem Mohamed --- .../amd/display/dc/dccg/dcn20/dcn20_dccg.h| 94 .../amd/display/dc/dccg/

[PATCH] drm/amdgpu/job: move fix is_guilty logic change

2025-02-21 Thread Alex Deucher
Incrementing the gpu_reset counter needs to be in the is_guilty block. Fixes: f447ba2bbd48 ("drm/amdgpu: Update amdgpu_job_timedout to check if the ring is guilty") Cc: Jesse Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 1/4] drm/amdgpu/gfx11: Implement the GFX11 KGQ pipe reset

2025-02-21 Thread Alex Deucher
On Fri, Feb 21, 2025 at 8:38 AM Prike Liang wrote: > > Implement the kernel graphics queue pipe reset,and the driver > will fallback to pipe reset when the queue reset fails. However, > the ME FW hasn't fully supported pipe reset yet so disable the > KGQ pipe reset temporarily. > > Signed-off-by:

[PATCH 11/24] drm/amd/display: replace dio encoder access

2025-02-21 Thread Zaeem Mohamed
From: Peichen Huang [WHY] replace dio encoder access to work with new dio encoder assignment. [HOW} 1. before validation, access dio encoder by get_temp_dio_link_enc() 2. after validation, access dio encoder through pipe_ctx->link_res Reviewed-by: Wenjing Liu Reviewed-by: Meenakshikumar Somasu

[PATCH 4/5] drm/amd/display: Add support for custom brightness curve

2025-02-21 Thread Mario Limonciello
Some systems specify in the firmware a brightness curve that better reflects the characteristics of the panel used. This is done in the form of data points and matching luminance percentage. When converting a userspace requested brightness value use that curve to convert to a firmware intended bri

Re: [PATCH v1] drm/amdgpu: init return value in amdgpu_ttm_clear_buffer

2025-02-21 Thread Alex Deucher
On Fri, Feb 21, 2025 at 10:13 AM Pierre-Eric Pelloux-Prayer wrote: > > Otherwise an uninitialized value can be returned if > amdgpu_res_cleared returns true for all regions. > > Fixes: a68c7eaa7a8f ("drm/amdgpu: Enable clear page functionality") Possibly closes: https://gitlab.freedesktop.org/drm

[pull] amdgpu, amdkfd, UAPI drm-next-6.15

2025-02-21 Thread Alex Deucher
Hi Dave, Simona, New stuff for 6.15. The following changes since commit 1abb2648698bf10783d2236a6b4a7ca5e8021699: drm/amdgpu: avoid buffer overflow attach in smu_sys_set_pp_table() (2025-02-12 19:47:15 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/lin

Re: [PATCH] MAINTAINERS: Update AMDGPU DML maintainers info

2025-02-21 Thread Harry Wentland
On 2025-02-21 14:25, Aurabindo Pillai wrote: > Chaitanya is no longer with AMD, and the responsibility has been > taken over by Austin. > > Signed-off-by: Aurabindo Pillai Reviewed-by: Harry Wentland Harry > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] MAINTAINERS: update DML maintainers

2025-02-21 Thread Harry Wentland
On 2025-02-21 12:26, Alex Deucher wrote: > Chaitanya's email is no longer valid. > > Signed-off-by: Alex Deucher Reviewed-by: Harry Wentland Harry > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0845a8521e929..b37fd9fd5d551 10

Re: [V7 42/45] drm/amd/display: add 3D LUT colorop

2025-02-21 Thread Harry Wentland
On 2025-02-13 13:21, Leo Li wrote: > > > > On 2024-12-19 23:33, Alex Hung wrote: >> This adds support for a 3D LUT. >> >> The color pipeline now consists of the following colorops: >> 1. 1D curve colorop >> 2. Multiplier >> 3. 3x4 CTM >> 4. 1D curve colorop >> 5. 1D LUT >> 6. 3D LUT >> 7. 1D

Re: [PATCH][next] drm/amd/display: Fix spelling mistake "oustanding" -> "outstanding"

2025-02-21 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Feb 17, 2025 at 5:48 AM Colin Ian King wrote: > > There is a spelling mistake in max_oustanding_when_urgent_expected, > fix it. > > Signed-off-by: Colin Ian King > --- > .../dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c | 6 +++--- > .../dc/dml2/dml21/s

Re: [PATCH v2] drm/amd/display: restore edid reading from a given i2c adapter

2025-02-21 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Feb 21, 2025 at 3:48 PM Alex Hung wrote: > > Reviewed-by: Alex Hung > > On 2/15/25 14:15, Melissa Wen wrote: > > When switching to drm_edid, we slightly changed how to get edid by > > removing the possibility of getting them from dc_link when in aux > > transactio

[PATCH 12/24] drm/amd/display: add a quirk to enable eDP0 on DP1

2025-02-21 Thread Zaeem Mohamed
From: Yilin Chen [why] some board designs have eDP0 connected to DP1, need a way to enable support_edp0_on_dp1 flag, otherwise edp related features cannot work [how] do a dmi check during dm initialization to identify systems that require support_edp0_on_dp1. Optimize quirk table with callback f

Re: [PATCH v2] drm/amd/display: restore edid reading from a given i2c adapter

2025-02-21 Thread Alex Hung
Reviewed-by: Alex Hung On 2/15/25 14:15, Melissa Wen wrote: When switching to drm_edid, we slightly changed how to get edid by removing the possibility of getting them from dc_link when in aux transaction mode. As MST doesn't initialize the connector with `drm_connector_init_with_ddc()`, restor

[PATCH 0/5] Add custom brightness curve support

2025-02-21 Thread Mario Limonciello
Some OEMs support custom brightness curves where the ATIF method includes a collection of data points where the input signal is mapped out to percentage of luminance. This series shuffles around some code to add in the ability to do that mapping in amdgpu_dm when brightness is set. Mario Limonciel

[PATCH 02/24] drm/amd/display: Disable PSR-SU on eDP panels

2025-02-21 Thread Zaeem Mohamed
From: Tom Chung [Why] PSR-SU may cause some glitching randomly on several panels. [How] Temporarily disable the PSR-SU and fallback to PSR1 for all eDP panels. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3388 Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewe

Re: [V7 08/45] Documentation/gpu: document drm_colorop

2025-02-21 Thread Harry Wentland
On 2025-02-21 11:42, Simon Ser wrote: > On Friday, February 21st, 2025 at 17:18, Harry Wentland > wrote: > >> I did a brief survey of other enum properties and noticed >> that this isn't well documented for others, such as the Content >> Protection connector property, or the COLOR_RANGE and C

Re: [PATCH] MAINTAINERS: Update AMDGPU DML maintainers info

2025-02-21 Thread Deucher, Alexander
[AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Alex Deucher From: Aurabindo Pillai Sent: Friday, February 21, 2025 2:25 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Wentland, Harry ; Li, Sun peng (Leo) ; Pillai, Aurabindo

[PATCH 03/24] drm/amd/display: update incorrect cursor buffer size

2025-02-21 Thread Zaeem Mohamed
From: Alex Hung [WHAT & HOW] Fix the incorrect value of the cursor_buffer_size. Signed-off-by: Alex Hung Reviewed-by: Zaeem Mohamed --- .../amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/disp

[PATCH] MAINTAINERS: update DML maintainers

2025-02-21 Thread Alex Deucher
Chaitanya's email is no longer valid. Signed-off-by: Alex Deucher --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0845a8521e929..b37fd9fd5d551 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1031,7 +1031,6 @@ T:git https://gitlab.freedes

[PATCH] MAINTAINERS: Update AMDGPU DML maintainers info

2025-02-21 Thread Aurabindo Pillai
Chaitanya is no longer with AMD, and the responsibility has been taken over by Austin. Signed-off-by: Aurabindo Pillai --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index c8b35ca294a0..d167946f88e5 100644 --- a/MAINTAINERS +++ b/MAI

Re: [PATCH v1] drm/amdgpu: init return value in amdgpu_ttm_clear_buffer

2025-02-21 Thread Alex Deucher
On Fri, Feb 21, 2025 at 10:13 AM Pierre-Eric Pelloux-Prayer wrote: > > Otherwise an uninitialized value can be returned if > amdgpu_res_cleared returns true for all regions. > > Fixes: a68c7eaa7a8f ("drm/amdgpu: Enable clear page functionality") > Signed-off-by: Pierre-Eric Pelloux-Prayer Acked-

Re: [V7 08/45] Documentation/gpu: document drm_colorop

2025-02-21 Thread Simon Ser
On Friday, February 21st, 2025 at 19:41, Harry Wentland wrote: > > Other people have argued that strings make it easier for user-space to > > start using a new KMS property without deploying new kernel uAPI headers. > > I don't understand this argument. You would either need to define the > str

Re: [V7 08/45] Documentation/gpu: document drm_colorop

2025-02-21 Thread Simon Ser
On Friday, February 21st, 2025 at 17:18, Harry Wentland wrote: > I did a brief survey of other enum properties and noticed > that this isn't well documented for others, such as the Content > Protection connector property, or the COLOR_RANGE and COLOR_ENCODING > plane properties. Isn't the Conte

[PATCH] drm/amdgpu: simplify xgmi peer info calls

2025-02-21 Thread Jonathan Kim
Deprecate KFD XGMI peer info calls in favour of calling directly from simplified XGMI peer info functions. v2: generalize bandwidth interface to return range in one call Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 42 drivers/gpu/drm/amd/amdgpu/

Re: [PATCH] drm/amd/display: fix an indent issue in DML21

2025-02-21 Thread Harry Wentland
On 2025-02-21 10:09, Aurabindo Pillai wrote: > Remove extraneous tab and newline in dml2_core_dcn4.c that was > reported by the bot > > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202502211920.txufwtsj-...@intel.com/ > Fixes: 70839da6360 ("drm/amd/display: Ad

[PATCH 11/24] drm/amd/display: replace dio encoder access

2025-02-21 Thread Zaeem Mohamed
From: Peichen Huang [WHY] replace dio encoder access to work with new dio encoder assignment. [HOW} 1. before validation, access dio encoder by get_temp_dio_link_enc() 2. after validation, access dio encoder through pipe_ctx->link_res Reviewed-by: Wenjing Liu Reviewed-by: Meenakshikumar Somasu

[PATCH 05/24] drm/amd/display: Fix mismatch type comparison in custom_float

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why & How] Passing uint into uchar function param. Pass uint instead Signed-off-by: Samson Tam Reviewed-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/sspl/spl_fixpt31_32.c | 2 +- drivers/gpu/drm/amd/display/dc/sspl/spl_fixpt31_32.h | 4 ++-- 2 files changed, 3 insertion

[PATCH 5/5] drm/amd/display: Add a new dcdebugmask to allow turning off brightness curve

2025-02-21 Thread Mario Limonciello
Upgrading the kernel may cause some systems that were previously not using a firmware specified brightness curve to use one. In the event of problems with this curve (for example an interpolation error) add a new dcdebugmask value that can be used to turn it off. Also add an info message to show

[PATCH 3/5] drm/amd/display: Avoid operating on copies of backlight caps

2025-02-21 Thread Mario Limonciello
Making a copy of the backlight caps structure between uses is unnecessary. Refer to pointers to the same structure when using it. Signed-off-by: Mario Limonciello --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 50 --- 1 file changed, 21 insertions(+), 29 deletions(-) diff -

[PATCH 1/5] drm/amd: Copy entire structure in amdgpu_acpi_get_backlight_caps()

2025-02-21 Thread Mario Limonciello
As new members are introduced to the structure copying the entire structure will help avoid missing them. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.

[PATCH 2/5] drm/amd: Pass luminance data to amdgpu_dm_backlight_caps

2025-02-21 Thread Mario Limonciello
The ATIF method on some systems will provide a backlight curve. Pass this curve into amdgpu_dm add it to the structures. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 20 +++ drivers/g

[PATCH 22/24] drm/amd/display: Fix HPD after gpu reset

2025-02-21 Thread Zaeem Mohamed
From: Roman Li [Why] DC is not using amdgpu_irq_get/put to manage the HPD interrupt refcounts. So when amdgpu_irq_gpu_reset_resume_helper() reprograms all of the IRQs, HPD gets disabled. [How] Use amdgpu_irq_get/put() for HPD init/fini in DM in order to sync refcounts Reviewed-by: Mario Limonci

[PATCH] drm/amdkfd: enable cooperative launch on gfx12

2025-02-21 Thread Jonathan Kim
Even though GWS no longer exists, to maintain runtime usage for cooperative launch, SW set legacy GWS size. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/

[PATCH 01/24] drm/amd/display: Revert "Disable PSR-SU on some OLED panel"

2025-02-21 Thread Zaeem Mohamed
From: Tom Chung This reverts commit 9b908d788090911d339a217c015e0022e8020b75. We planning to disable the PSR-SU and fallback to PSR1 for all eDP panels not only for specific eDP panel temporarily. Reviewed-by: Sun peng Li Signed-off-by: Tom Chung Signed-off-by: Roman Li --- .../drm/amd/disp

Re: [PATCH 22/24] drm/amd/display: Fix HPD after gpu reset

2025-02-21 Thread Mario Limonciello
On 2/21/2025 10:01, Zaeem Mohamed wrote: From: Roman Li [Why] DC is not using amdgpu_irq_get/put to manage the HPD interrupt refcounts. So when amdgpu_irq_gpu_reset_resume_helper() reprograms all of the IRQs, HPD gets disabled. [How] Use amdgpu_irq_get/put() for HPD init/fini in DM in order to

[PATCH 12/24] drm/amd/display: add a quirk to enable eDP0 on DP1

2025-02-21 Thread Zaeem Mohamed
From: Yilin Chen [why] some board designs have eDP0 connected to DP1, need a way to enable support_edp0_on_dp1 flag, otherwise edp related features cannot work [how] do a dmi check during dm initialization to identify systems that require support_edp0_on_dp1. Optimize quirk table with callback f

[PATCH 16/24] drm/amd/display: fix dcn4x init failed

2025-02-21 Thread Zaeem Mohamed
From: Charlene Liu [why] failed due to cmdtable not created. switch atombios cmdtable as default. Reviewed-by: Alvin Lee Signed-off-by: Charlene Liu Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/bios/command_table2.c | 9 - .../gpu/drm/amd/display/dc/bios/comman

Re: [V7 34/45] drm/amd/display: add shaper and blend colorops for 1D Curve Custom LUT

2025-02-21 Thread Harry Wentland
On 2025-02-12 18:44, Leo Li wrote: > > > On 2024-12-19 23:33, Alex Hung wrote: >> This patch adds colorops for custom 1D LUTs in the SHAPER and >> BLND HW blocks. >> >> With this change the following IGT tests pass: >> kms_colorop --run plane-XR30-XR30-srgb_inv_eotf_lut >> kms_colorop --run pl

Re: [PATCH] drm/amdgpu/job: move fix is_guilty logic change

2025-02-21 Thread Deucher, Alexander
[Public] Ignore this. Newer version sent. Alex From: Deucher, Alexander Sent: Friday, February 21, 2025 10:32 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Jesse(Jie) Subject: [PATCH] drm/amdgpu/job: move fix is_guilty logic change In

Re: [PATCH] drm/amdgpu: Remove unused nbif_v6_3_1_sriov_funcs

2025-02-21 Thread Alex Deucher
Applied. Thanks! On Wed, Feb 19, 2025 at 4:48 PM wrote: > > From: "Dr. David Alan Gilbert" > > The nbif_v6_3_1_sriov_funcs instance of amdgpu_nbio_funcs was added in > commit 894c6d3522d1 ("drm/amdgpu: Add nbif v6_3_1 ip block support") > but has remained unused. > > Alex has confirmed it wasn'

Re: [V7 08/45] Documentation/gpu: document drm_colorop

2025-02-21 Thread Harry Wentland
On 2025-02-15 09:40, Simon Ser wrote: > On Monday, February 10th, 2025 at 23:03, Harry Wentland > wrote: > + * DOC: overview + * + * A colorop represents a single color operation. Colorops are chained + * via the NEXT property and make up color pipelines. Color pipelines >

[PATCH 20/24] drm/amd/display: Increase halt timeout for DMCUB to 1s

2025-02-21 Thread Zaeem Mohamed
From: Nicholas Kazlauskas [Why] If we soft reset before halt finishes and there are outstanding memory transactions then the memory interface may produce unexpected results, such as out of order transactions when the firmware next runs. These can manifest as random or unexpected load/store viola

[PATCH 08/24] drm/amd/display: fix check for identity ratio

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why] IDENTITY_RATIO check uses 2 bits for integer, which only allows checking downscale ratios up to 3. But we support up to 6x downscale [How] Update IDENTITY_RATIO to check 3 bits for integer Add ASSERT to catch if we downscale more than 6x Signed-off-by: Samson Tam Revi

[PATCH 07/24] drm/amd/display: Fix mismatch type comparison

2025-02-21 Thread Zaeem Mohamed
From: "Assadian, Navid" The mismatch type comparison/assignment may cause data loss. Since the values are always non-negative, it is safe to use unsigned variables to resolve the mismatch. Signed-off-by: Navid Assadian Reviewed-by: Joshua Aberback --- drivers/gpu/drm/amd/display/dc/sspl/dc_sp

[PATCH 14/24] drm/amd/display: ACPI Re-timer Programming

2025-02-21 Thread Zaeem Mohamed
From: "Ostrowski, Rafal" [Why] We must implement an ACPI re-timer programming interface and notify ACPI driver whenever a PHY transition is about to take place. Because some trace lengths on certain platforms are very long, then a re-timer may need to be programmed whenever a PHY transition take

[PATCH 00/24] DC Patches FEBRUARY 18, 2025

2025-02-21 Thread Zaeem Mohamed
This DC patchset brings iprovements in multiple areas. In summary, we have: - Disable PSR-SU on eDP panels - Fix HPD after GPU reset - Fixes on dcn4x init, DML2 state policy on DCN36 - Various minor logic fixes Cc: Daniel Wheeler Alex Hung (1): drm/amd/display: update incorrect cursor bu

[PATCH 04/24] drm/amd/display: Apply DCN35 DML2 state policy for DCN36 too

2025-02-21 Thread Zaeem Mohamed
From: Nicholas Kazlauskas [Why] DCN36 should inherit the same policy as DCN35 for DML2. [How] Add it to the list of checks in translation helper. Signed-off-by: Nicholas Kazlauskas Reviewed-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c | 1 + 1 file chan

[PATCH 19/24] drm/amd/display: Remove unused header

2025-02-21 Thread Zaeem Mohamed
From: Krunoslav Kovac [Why] Removes unused header Reviewed-by: Samson Tam Signed-off-by: Krunoslav Kovac Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/sspl/dc_spl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.c b/drivers/gp

[PATCH 21/24] drm/amd/display: stop DML2 from removing pipes based on planes

2025-02-21 Thread Zaeem Mohamed
From: Mike Katsnelson [Why] Transitioning from low to high resolutions at high refresh rates caused grey corruption. During the transition state, there is a period where plane size is based on low resultion state and ODM slices are based on high resoultion state, causing the entire plane to be

[PATCH 23/24] drm/amd/display: [FW Promotion] Release 0.0.255.0

2025-02-21 Thread Zaeem Mohamed
From: Taimur Hassan Signed-off-by: Taimur Hassan Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 76 +++ 1 file changed, 76 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_

[PATCH 15/24] drm/amd/display: Temporarily disable hostvm on DCN31

2025-02-21 Thread Zaeem Mohamed
From: Aurabindo Pillai With HostVM enabled, DCN31 fails to pass validation for 3x4k60. Some Linux userspace does not downgrade one of the monitors to 4k30, and the result is that the monitor does not light up. Disable it until the bandwidth calculation failure is resolved. Reviewed-by: Sun peng

[PATCH 24/24] drm/amd/display: Promote DAL to 3.2.322

2025-02-21 Thread Zaeem Mohamed
From: Taimur Hassan Signed-off-by: Taimur Hassan Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index f76884fe86e3..f646f537a3dc

[PATCH 18/24] drm/amd/display: handle max_downscale_src_width fail check

2025-02-21 Thread Zaeem Mohamed
From: Yihan Zhu [WHY] If max_downscale_src_width check fails, we exit early from TAP calculation and left a NULL value to the scaling data structure to cause the zero divide in the DML validation. [HOW] Call set default TAP calculation before early exit in get_optimal_number_of_taps due to ma

[PATCH 17/24] drm/amd/display: Update FIXED_VS Link Rate Toggle Workaround Usage

2025-02-21 Thread Zaeem Mohamed
From: Michael Strauss [WHY] Previously the 128b/132b LTTPR support DPCD field was used to decide if FIXED_VS training sequence required a rate toggle before initiating LT. When running DP2.1 4.9.x.x compliance tests, emulated LTTPRs can report no-128b/132b support which is then forwarded by the

[PATCH 11/24] drm/amd/display: replace dio encoder access

2025-02-21 Thread Zaeem Mohamed
From: Peichen Huang [WHY] replace dio encoder access to work with new dio encoder assignment. [HOW} 1. before validation, access dio encoder by get_temp_dio_link_enc() 2. after validation, access dio encoder through pipe_ctx->link_res Reviewed-by: Wenjing Liu Reviewed-by: Meenakshikumar Somasu

[PATCH 13/24] drm/amd/display: Refactor DCN4x and related code

2025-02-21 Thread Zaeem Mohamed
From: "Patel, Swapnil" [why & how] Refactor existing code related to DCN4x for better code sharing with other modules Reviewed-by: Charlene Liu Signed-off-by: Swapnil Patel Signed-off-by: Zaeem Mohamed --- .../amd/display/dc/dccg/dcn20/dcn20_dccg.h| 94 .../amd/display/dc/dccg/

[PATCH 10/24] drm/amd/display: Add SPL namespace

2025-02-21 Thread Zaeem Mohamed
From: Navid Assadian [Why] In order to avoid component conflicts, spl namespace is needed. [How] Adding SPL namespace to the public API os that each user of SPL can have their own namespace. Signed-off-by: Navid Assadian Reviewed-by: Samson Tam --- drivers/gpu/drm/amd/display/dc/sspl/dc_spl.

[PATCH 09/24] drm/amd/display: Fix unit test failure

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why] Some of unit tests use large scaling ratio such that when we calculate optimal number of taps, max_taps is negative. Then in recent change, we changed max_taps to uint instead of int so now max_taps wraps and is positive. This change changed the behaviour from returnin

[PATCH 06/24] drm/amd/display: Add opp recout adjustment

2025-02-21 Thread Zaeem Mohamed
From: Navid Assadian [Why] For subsampled YUV output formats, more pixels can get fetched and be used for scaling. [How] Add the adjustment to the calculated recout, so the viewport covers the corresponding pixels on the source plane. Signed-off-by: Navid Assadian Reviewed-by: Samson Tam ---

[PATCH 05/24] drm/amd/display: Fix mismatch type comparison in custom_float

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why & How] Passing uint into uchar function param. Pass uint instead Signed-off-by: Samson Tam Reviewed-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/sspl/spl_fixpt31_32.c | 2 +- drivers/gpu/drm/amd/display/dc/sspl/spl_fixpt31_32.h | 4 ++-- 2 files changed, 3 insertion

[PATCH 03/24] drm/amd/display: update incorrect cursor buffer size

2025-02-21 Thread Zaeem Mohamed
From: Alex Hung [WHAT & HOW] Fix the incorrect value of the cursor_buffer_size. Signed-off-by: Alex Hung Reviewed-by: Zaeem Mohamed --- .../amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/disp

[PATCH 01/24] drm/amd/display: Revert "Disable PSR-SU on some OLED panel"

2025-02-21 Thread Zaeem Mohamed
From: Tom Chung This reverts commit 9b908d788090911d339a217c015e0022e8020b75. We planning to disable the PSR-SU and fallback to PSR1 for all eDP panels not only for specific eDP panel temporarily. Reviewed-by: Sun peng Li Signed-off-by: Tom Chung Signed-off-by: Roman Li --- .../drm/amd/disp

[PATCH 00/24] DC Patches FEBRUARY 18, 2025 V3

2025-02-21 Thread Zaeem Mohamed
This DC patchset brings improvements in multiple areas. In summary, we have: - Disable PSR-SU on eDP panels - Fix HPD after GPU reset - Fixes on dcn4x init, DML2 state policy on DCN36 - Various minor logic fixes Cc: Daniel Wheeler Alex Hung (1): drm/amd/display: update incorrect cursor b

[PATCH 10/24] drm/amd/display: Add SPL namespace

2025-02-21 Thread Zaeem Mohamed
From: Navid Assadian [Why] In order to avoid component conflicts, spl namespace is needed. [How] Adding SPL namespace to the public API os that each user of SPL can have their own namespace. Signed-off-by: Navid Assadian Reviewed-by: Samson Tam --- drivers/gpu/drm/amd/display/dc/sspl/dc_spl.

[PATCH 02/24] drm/amd/display: Disable PSR-SU on eDP panels

2025-02-21 Thread Zaeem Mohamed
From: Tom Chung [Why] PSR-SU may cause some glitching randomly on several panels. [How] Temporarily disable the PSR-SU and fallback to PSR1 for all eDP panels. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3388 Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewe

[PATCH 04/24] drm/amd/display: Apply DCN35 DML2 state policy for DCN36 too

2025-02-21 Thread Zaeem Mohamed
From: Nicholas Kazlauskas [Why] DCN36 should inherit the same policy as DCN35 for DML2. [How] Add it to the list of checks in translation helper. Signed-off-by: Nicholas Kazlauskas Reviewed-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c | 1 + 1 file chan

[PATCH 05/24] drm/amd/display: Fix mismatch type comparison in custom_float

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why & How] Passing uint into uchar function param. Pass uint instead Signed-off-by: Samson Tam Reviewed-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/sspl/spl_fixpt31_32.c | 2 +- drivers/gpu/drm/amd/display/dc/sspl/spl_fixpt31_32.h | 4 ++-- 2 files changed, 3 insertion

[PATCH 07/24] drm/amd/display: Fix mismatch type comparison

2025-02-21 Thread Zaeem Mohamed
From: "Assadian, Navid" The mismatch type comparison/assignment may cause data loss. Since the values are always non-negative, it is safe to use unsigned variables to resolve the mismatch. Signed-off-by: Navid Assadian Reviewed-by: Joshua Aberback --- drivers/gpu/drm/amd/display/dc/sspl/dc_sp

[PATCH 06/24] drm/amd/display: Add opp recout adjustment

2025-02-21 Thread Zaeem Mohamed
From: Navid Assadian [Why] For subsampled YUV output formats, more pixels can get fetched and be used for scaling. [How] Add the adjustment to the calculated recout, so the viewport covers the corresponding pixels on the source plane. Signed-off-by: Navid Assadian Reviewed-by: Samson Tam ---

[PATCH 09/24] drm/amd/display: Fix unit test failure

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why] Some of unit tests use large scaling ratio such that when we calculate optimal number of taps, max_taps is negative. Then in recent change, we changed max_taps to uint instead of int so now max_taps wraps and is positive. This change changed the behaviour from returnin

[PATCH 08/24] drm/amd/display: fix check for identity ratio

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why] IDENTITY_RATIO check uses 2 bits for integer, which only allows checking downscale ratios up to 3. But we support up to 6x downscale [How] Update IDENTITY_RATIO to check 3 bits for integer Add ASSERT to catch if we downscale more than 6x Signed-off-by: Samson Tam Revi

[PATCH 00/24] DC Patches FEBRUARY 18, 2025 V2

2025-02-21 Thread Zaeem Mohamed
This DC patchset brings improvements in multiple areas. In summary, we have: - Disable PSR-SU on eDP panels - Fix HPD after GPU reset - Fixes on dcn4x init, DML2 state policy on DCN36 - Various minor logic fixes Cc: Daniel Wheeler Alex Hung (1): drm/amd/display: update incorrect cursor b

[PATCH 07/24] drm/amd/display: Fix mismatch type comparison

2025-02-21 Thread Zaeem Mohamed
From: "Assadian, Navid" The mismatch type comparison/assignment may cause data loss. Since the values are always non-negative, it is safe to use unsigned variables to resolve the mismatch. Signed-off-by: Navid Assadian Reviewed-by: Joshua Aberback --- drivers/gpu/drm/amd/display/dc/sspl/dc_sp

RE: [PATCH] drm/amd/pm: handling of set performance level

2025-02-21 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Gadre, Mangesh Sent: Friday, February 21, 2025 9:52 PM To: amd-gfx@lists.freedesktop.org; Zhang, Hawking Cc: Gadre, Mangesh ; Lazar, Lijo Subject: [PATCH] drm/

[PATCH 12/24] drm/amd/display: add a quirk to enable eDP0 on DP1

2025-02-21 Thread Zaeem Mohamed
From: Yilin Chen [why] some board designs have eDP0 connected to DP1, need a way to enable support_edp0_on_dp1 flag, otherwise edp related features cannot work [how] do a dmi check during dm initialization to identify systems that require support_edp0_on_dp1. Optimize quirk table with callback f

[PATCH 06/24] drm/amd/display: Add opp recout adjustment

2025-02-21 Thread Zaeem Mohamed
From: Navid Assadian [Why] For subsampled YUV output formats, more pixels can get fetched and be used for scaling. [How] Add the adjustment to the calculated recout, so the viewport covers the corresponding pixels on the source plane. Signed-off-by: Navid Assadian Reviewed-by: Samson Tam ---

[PATCH 08/24] drm/amd/display: fix check for identity ratio

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why] IDENTITY_RATIO check uses 2 bits for integer, which only allows checking downscale ratios up to 3. But we support up to 6x downscale [How] Update IDENTITY_RATIO to check 3 bits for integer Add ASSERT to catch if we downscale more than 6x Signed-off-by: Samson Tam Revi

[PATCH 09/24] drm/amd/display: Fix unit test failure

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why] Some of unit tests use large scaling ratio such that when we calculate optimal number of taps, max_taps is negative. Then in recent change, we changed max_taps to uint instead of int so now max_taps wraps and is positive. This change changed the behaviour from returnin

[PATCH 04/24] drm/amd/display: Apply DCN35 DML2 state policy for DCN36 too

2025-02-21 Thread Zaeem Mohamed
From: Nicholas Kazlauskas [Why] DCN36 should inherit the same policy as DCN35 for DML2. [How] Add it to the list of checks in translation helper. Signed-off-by: Nicholas Kazlauskas Reviewed-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c | 1 + 1 file chan

[PATCH 03/24] drm/amd/display: update incorrect cursor buffer size

2025-02-21 Thread Zaeem Mohamed
From: Alex Hung [WHAT & HOW] Fix the incorrect value of the cursor_buffer_size. Signed-off-by: Alex Hung Reviewed-by: Zaeem Mohamed --- .../amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/disp

[PATCH 02/24] drm/amd/display: Disable PSR-SU on eDP panels

2025-02-21 Thread Zaeem Mohamed
From: Tom Chung [Why] PSR-SU may cause some glitching randomly on several panels. [How] Temporarily disable the PSR-SU and fallback to PSR1 for all eDP panels. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3388 Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewe

[PATCH 01/24] drm/amd/display: Revert "Disable PSR-SU on some OLED panel"

2025-02-21 Thread Zaeem Mohamed
From: Tom Chung This reverts commit 9b908d788090911d339a217c015e0022e8020b75. We planning to disable the PSR-SU and fallback to PSR1 for all eDP panels not only for specific eDP panel temporarily. Reviewed-by: Sun peng Li Signed-off-by: Tom Chung Signed-off-by: Roman Li --- .../drm/amd/disp

[PATCH] drm/amdgpu/job: fix is_guilty logic change (v2)

2025-02-21 Thread Alex Deucher
Incrementing the gpu_reset counter needs to be in the is_guilty block. Alos move the fence error before the reset to keep the original ordering. Fixes: f447ba2bbd48 ("drm/amdgpu: Update amdgpu_job_timedout to check if the ring is guilty") Cc: Jesse Zhang Signed-off-by: Alex Deucher --- driver

[PATCH 2/2] drm/amdgpu: Add offset normalization in VCN v5.0.1

2025-02-21 Thread Lijo Lazar
VCN v5.0.1 also will need register offset normalization. Reuse the logic from VCN v4.0.3. Also, avoid HDP flush similar to VCN v5.0.1 Signed-off-by: Lijo Lazar Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 14 -- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.h |

[PATCH 1/2] drm/amdgpu: Initialize RRMT status on VCN v5.0.1

2025-02-21 Thread Lijo Lazar
Initialize RRMT status from register. Signed-off-by: Lijo Lazar Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c | 2 ++ drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c b/drivers/gpu/d

[PATCH 2/2] drm/amdgpu: Avoid HDP flush on JPEG v5.0.1

2025-02-21 Thread Lijo Lazar
Similar to JPEG v4.0.3, HDP flush shouldn't be performed by JPEG engine. Keep it empty. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 2 +- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.h | 1 + drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c | 1 + 3 files changed, 3 insertions(+),

[PATCH 1/2] drm/amdgpu: Initialize RRMT status on JPEG v5.0.1

2025-02-21 Thread Lijo Lazar
Initialize RRMT enablement status from register. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c | 3 +++ drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.h | 5 - 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c b/drivers/g

Re: [PATCH v1] drm/amdgpu: init return value in amdgpu_ttm_clear_buffer

2025-02-21 Thread Christian König
Am 21.02.25 um 16:16 schrieb Alex Deucher: > On Fri, Feb 21, 2025 at 10:13 AM Pierre-Eric Pelloux-Prayer > wrote: >> Otherwise an uninitialized value can be returned if >> amdgpu_res_cleared returns true for all regions. >> >> Fixes: a68c7eaa7a8f ("drm/amdgpu: Enable clear page functionality") >>

Re: [PATCH] drm/radeon: Add error handlings for r420 cp errata initiation

2025-02-21 Thread Alex Deucher
On Thu, Feb 20, 2025 at 1:41 AM Wentao Liang wrote: > > In r420_cp_errata_init(), the RESYNC information is stored even > when the Scratch register is not correctly allocated. > > Change the return type of r420_cp_errata_init() from void to int > to propagate errors to the caller. Add error checki

Re: [PATCH v2 2/3] drm/amdgpu: Log after a successful ring reset

2025-02-21 Thread Alex Deucher
Applied. Thanks! On Thu, Feb 20, 2025 at 11:28 AM André Almeida wrote: > > When a ring reset happens, the kernel log shows only "amdgpu: Starting > ring reset", but when it finishes nothing appears in the > log. Explicitly write in the log that the reset has finished correctly. > > Reviewed-by:

[PATCH] drm/amd/display: fix an indent issue in DML21

2025-02-21 Thread Aurabindo Pillai
Remove extraneous tab and newline in dml2_core_dcn4.c that was reported by the bot Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202502211920.txufwtsj-...@intel.com/ Fixes: 70839da6360 ("drm/amd/display: Add new DCN401 sources") Signed-off-by: Aurabindo Pillai ---

Re: [PATCH 2/2] mailmap: Add entry for Rodrigo Siqueira

2025-02-21 Thread Alex Deucher
Applied the series. Thanks! Alex On Wed, Feb 19, 2025 at 3:39 PM Harry Wentland wrote: > > On 2025-02-19 13:46, Rodrigo Siqueira wrote: > > Map all of my previously used email addresses to my @igalia.com address. > > > > Signed-off-by: Rodrigo Siqueira > > Acked-by: Harry Wentland > > Harry >

Re: [PATCH v2 1/3] drm/amdgpu: Log the creation of a coredump file

2025-02-21 Thread Alex Deucher
Applied, thanks! Alex On Thu, Feb 20, 2025 at 11:28 AM André Almeida wrote: > > After a GPU reset happens, the driver creates a coredump file. However, > the user might not be aware of it. Log the file creation the user can > find more information about the device and add the file to bug reports

[PATCH 2/2] drm/amdgpu/mes11: drop amdgpu_mes_suspend()/amdgpu_mes_resume() calls

2025-02-21 Thread Alex Deucher
They are noops on GFX11 for most firmware versions. KFD already handles its own queues and they should already be unmapped at this point so even if this runs, it's not doing anything. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 14 +- 1 file changed, 1 in

[PATCH 2/2] drm/amdgpu/userq: fix hardcoded uq functions

2025-02-21 Thread Alex Deucher
Use the IP type to look up the userq functions rather than hardcoding it. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c b/drivers/gpu/dr

  1   2   >