Re: [PATCH v14 2/9] platform/x86/amd: Add support for AMD ACPI based Wifi band RFI mitigation feature

2023-12-04 Thread Ma, Jun
Hi Mario, On 11/30/2023 1:24 AM, Mario Limonciello wrote: > On 11/29/2023 03:13, Ma Jun wrote: >> Due to electrical and mechanical constraints in certain platform designs >> there may be likely interference of relatively high-powered harmonics of >> the (G-)DDR memory clocks with local radio modul

Re: [PATCH v14 2/9] platform/x86/amd: Add support for AMD ACPI based Wifi band RFI mitigation feature

2023-12-04 Thread Ma, Jun
Hi Hans, On 12/4/2023 9:00 PM, Hans de Goede wrote: > Hi, > > On 11/29/23 10:13, Ma Jun wrote: >> Due to electrical and mechanical constraints in certain platform designs >> there may be likely interference of relatively high-powered harmonics of >> the (G-)DDR memory clocks with local radio modu

Re: [PATCH 1/6] Revert "drm/prime: Unexport helpers for fd/handle conversion"

2023-12-04 Thread Felix Kuehling
On 2023-12-04 12:49, Deucher, Alexander wrote: [AMD Official Use Only - General] -Original Message- From: Kuehling, Felix Sent: Friday, December 1, 2023 6:40 PM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Deucher, Alexander Cc: Daniel Vetter ; Koenig, Christi

[PATCH AUTOSEL 5.10 6/7] drm/amdgpu: Fix cat debugfs amdgpu_regs_didt causes kernel null pointer

2023-12-04 Thread Sasha Levin
From: Lu Yao [ Upstream commit 2161e09cd05a50d80736fe397145340d2e8f6c05 ] For 'AMDGPU_FAMILY_SI' family cards, in 'si_common_early_init' func, init 'didt_rreg' and 'didt_wreg' to 'NULL'. But in func 'amdgpu_debugfs_regs_didt_read/write', using 'RREG32_DIDT' 'WREG32_DIDT' lacks of relevant judgme

[PATCH AUTOSEL 5.15 09/10] drm/amdgpu: Fix cat debugfs amdgpu_regs_didt causes kernel null pointer

2023-12-04 Thread Sasha Levin
From: Lu Yao [ Upstream commit 2161e09cd05a50d80736fe397145340d2e8f6c05 ] For 'AMDGPU_FAMILY_SI' family cards, in 'si_common_early_init' func, init 'didt_rreg' and 'didt_wreg' to 'NULL'. But in func 'amdgpu_debugfs_regs_didt_read/write', using 'RREG32_DIDT' 'WREG32_DIDT' lacks of relevant judgme

[PATCH AUTOSEL 6.1 13/17] drm/amd/display: update dcn315 lpddr pstate latency

2023-12-04 Thread Sasha Levin
From: Dmytro Laktyushkin [ Upstream commit c92da0403d373c03ea5c65c0260c7db6762013b0 ] [WHY/HOW] Increase the pstate latency to improve ac/dc transition Reviewed-by: Charlene Liu Acked-by: Tom Chung Signed-off-by: Dmytro Laktyushkin Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Sign

[PATCH AUTOSEL 6.1 14/17] drm/amdgpu: Fix cat debugfs amdgpu_regs_didt causes kernel null pointer

2023-12-04 Thread Sasha Levin
From: Lu Yao [ Upstream commit 2161e09cd05a50d80736fe397145340d2e8f6c05 ] For 'AMDGPU_FAMILY_SI' family cards, in 'si_common_early_init' func, init 'didt_rreg' and 'didt_wreg' to 'NULL'. But in func 'amdgpu_debugfs_regs_didt_read/write', using 'RREG32_DIDT' 'WREG32_DIDT' lacks of relevant judgme

[PATCH AUTOSEL 6.6 28/32] drm/amdgpu: Use another offset for GC 9.4.3 remap

2023-12-04 Thread Sasha Levin
From: Lijo Lazar [ Upstream commit ed6e4f0a27ebafffbd12bf3878ab004787685d8a ] The legacy region at 0x7F000 maps to valid registers in GC 9.4.3 SOCs. Use 0x1A000 offset instead as MMIO register remap region. Signed-off-by: Lijo Lazar Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher Sign

[PATCH AUTOSEL 6.6 27/32] drm/amdkfd: Free gang_ctx_bo and wptr_bo in pqm_uninit

2023-12-04 Thread Sasha Levin
From: ZhenGuo Yin [ Upstream commit 72838777aa38352e20301e123b97110c456cd38e ] [Why] Memory leaks of gang_ctx_bo and wptr_bo. [How] Free gang_ctx_bo and wptr_bo in pqm_uninit. v2: add a common function pqm_clean_queue_resource to free queue's resources. v3: reset pdd->pqd.num_gws when destoryi

[PATCH AUTOSEL 6.6 26/32] drm/amdgpu: Fix cat debugfs amdgpu_regs_didt causes kernel null pointer

2023-12-04 Thread Sasha Levin
From: Lu Yao [ Upstream commit 2161e09cd05a50d80736fe397145340d2e8f6c05 ] For 'AMDGPU_FAMILY_SI' family cards, in 'si_common_early_init' func, init 'didt_rreg' and 'didt_wreg' to 'NULL'. But in func 'amdgpu_debugfs_regs_didt_read/write', using 'RREG32_DIDT' 'WREG32_DIDT' lacks of relevant judgme

[PATCH AUTOSEL 6.6 24/32] drm/amdkfd: Use common function for IP version check

2023-12-04 Thread Sasha Levin
From: Mukul Joshi [ Upstream commit 2f86bf79b63dbe6963ebc647b77a5f576a906b40 ] KFD_GC_VERSION was recently updated to use a new function for IP version checks. As a result, use KFD_GC_VERSION as the common function for all IP version checks in KFD. Signed-off-by: Mukul Joshi Reviewed-by: Haris

[PATCH AUTOSEL 6.6 25/32] drm/amd/display: update dcn315 lpddr pstate latency

2023-12-04 Thread Sasha Levin
From: Dmytro Laktyushkin [ Upstream commit c92da0403d373c03ea5c65c0260c7db6762013b0 ] [WHY/HOW] Increase the pstate latency to improve ac/dc transition Reviewed-by: Charlene Liu Acked-by: Tom Chung Signed-off-by: Dmytro Laktyushkin Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Sign

[PATCH AUTOSEL 6.6 23/32] drm/amdgpu: Do not issue gpu reset from nbio v7_9 bif interrupt

2023-12-04 Thread Sasha Levin
From: Hawking Zhang [ Upstream commit 884e9b0827e889a8742e203ccd052101fb0b945d ] In nbio v7_9, host driver should not issu gpu reset Signed-off-by: Hawking Zhang Reviewed-by: Stanley Yang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c | 5

[PATCH v2] drm/amdkfd: Use partial hmm page walk during buffer validation in SVM

2023-12-04 Thread Xiaogang . Chen
From: Xiaogang Chen v2: -not need calculate vram page number for new registered svm range, only do it for split vram pages. SVM uses hmm page walk to valid buffer before map to gpu vm. After have partial migration/mapping do validation on same vm range as migration/map do instead of whole svm ra

Re: [PATCH] [v2] drm/radeon/trinity_dpm: fix a memleak in trinity_parse_power_table

2023-12-04 Thread Alex Deucher
Applied. Thanks! On Mon, Dec 4, 2023 at 5:39 AM Zhipeng Lu wrote: > > The rdev->pm.dpm.ps allocated by kcalloc should be freed in every > following error-handling path. However, in the error-handling of > rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, > resulting in a memle

Re: [PATCH] [v2] drm/radeon/dpm: fix a memleak in sumo_parse_power_table

2023-12-04 Thread Alex Deucher
On Mon, Dec 4, 2023 at 5:39 AM Zhipeng Lu wrote: > > The rdev->pm.dpm.ps allocated by kcalloc should be freed in every > following error-handling path. However, in the error-handling of > rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, > resulting in a memleak in this function

RE: [PATCH 1/6] Revert "drm/prime: Unexport helpers for fd/handle conversion"

2023-12-04 Thread Deucher, Alexander
[AMD Official Use Only - General] > -Original Message- > From: Kuehling, Felix > Sent: Friday, December 1, 2023 6:40 PM > To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Deucher, > Alexander > Cc: Daniel Vetter ; Koenig, Christian > ; Thomas Zimmermann > > Subject: R

Re: radeon flooding "flip queue failed" in Xorg and system log

2023-12-04 Thread Christian König
Well, essentially we shouldn't print the error from the kernel in the first place and just return the correct error code to the userspace application. The userspace application/driver would then say: Oh, I don't have enough memory for triple buffering, maybe I should just fallback to double b

Re: radeon flooding "flip queue failed" in Xorg and system log

2023-12-04 Thread smesgr
Hi Chrisitan, you are right, after bumping the memory in BIOS the error goes away. Still would be nice if the error would point to "out of VMem" or something. Best Regards Christian König schrieb am Montag, 4. Dezember 2023 um 16:18: > Am 02.12.23 um 20:00 schrieb smesgr: > >> Hi, >> >> I hav

Re: [PATCH v2 0/8] drm/plane-helpers: Minor clean ups

2023-12-04 Thread Alex Deucher
On Mon, Dec 4, 2023 at 4:09 AM Thomas Zimmermann wrote: > > Move drm_plane_helper_atomic_check() into udl, which is the only > driver using it. Remove several unnecessary include statements for > . > > v2: > * fix documentation (Sui) > > Thomas Zimmermann (8): > drm/plane-helper: Move dr

RE: [PATCH] drm/amd/swsmu: update smu v14_0_0 driver if version and metrics table

2023-12-04 Thread Deucher, Alexander
[Public] > -Original Message- > From: Ma, Li > Sent: Monday, December 4, 2023 3:52 AM > To: Deucher, Alexander ; amd- > g...@lists.freedesktop.org > Cc: Koenig, Christian ; Zhang, Yifan > ; Yu, Lang ; Wang, > Yang(Kevin) > Subject: RE: [PATCH] drm/amd/swsmu: update smu v14_0_0 driver if

Re: radeon flooding "flip queue failed" in Xorg and system log

2023-12-04 Thread Christian König
Am 02.12.23 um 20:00 schrieb smesgr: Hi, I have installed Debian 12 on my old Fujitsu S920 with AMD GX-424CC. After the installation completed, my logs are flooded by the following error messages: dmesg: [  967.869183] radeon :00:01.0: 3ba3c813 pin failed [  967.869212] [drm:radeo

[PATCH] drm/amdkfd: Use partial hmm page walk during buffer validation in SVM

2023-12-04 Thread Xiaogang . Chen
From: Xiaogang Chen SVM uses hmm page walk to valid buffer before map to gpu vm. After have partial migration/mapping do validation on same vm range as migration/map do instead of whole svm range that can be very large. This change is expected to improve svm code performance. Signed-off-by: Xiao

RE: [PATCH 00/47] DC Patches December 1, 2023

2023-12-04 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eD

Re: Radeon regression in 6.6 kernel

2023-12-04 Thread Alex Deucher
On Sun, Dec 3, 2023 at 3:40 PM Phillip Susi wrote: > > Alex Deucher writes: > > > Phillip, > > > > Can you test this patch? I was not able to repro the issue on the > > navi2x card I had handy, but I think it should fix it. > > I pulled -rc4 and it still had the problem. I applied this patch, a

[PATCH] drm/amdgpu: fix buffer funcs setting order on suspend

2023-12-04 Thread Alex Deucher
We need to disable this after the last eviction call, but before we disable the SDMA IP. Fixes: b70438004a14 ("drm/amdgpu: move buffer funcs setting up a level") Link: https://lore.kernel.org/r/87edgv4x3i@vps.thesusis.net Signed-off-by: Alex Deucher Cc: Phillip Susi Cc: Luben Tuikov --- dr

Re: Re: [PATCH] drm/radeon/dpm: fix a memleak in sumo_parse_power_table

2023-12-04 Thread alexious
> Am 03.12.23 um 18:16 schrieb Zhipeng Lu: > > The rdev->pm.dpm.ps allocated by kcalloc should be freed in every > > following error-handling path. However, in the error-handling of > > rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, > > resulting in a memleak in this function.

Re: [RFC PATCH 2/6] mm/gmem: add arch-independent abstraction to track address mapping status

2023-12-04 Thread David Hildenbrand
On 02.12.23 15:50, Pedro Falcato wrote: On Fri, Dec 1, 2023 at 9:23 AM David Hildenbrand wrote: On 28.11.23 13:50, Weixi Zhu wrote: This patch adds an abstraction layer, struct vm_object, that maintains per-process virtual-to-physical mapping status stored in struct gm_mapping. For example, a

[bug report] drm/amdgpu: Workaround to skip kiq ring test during ras gpu recovery

2023-12-04 Thread Dan Carpenter
Hello Stanley.Yang, The patch b1338a8e71ac: "drm/amdgpu: Workaround to skip kiq ring test during ras gpu recovery" from Oct 17, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:604 amdgpu_get_xgmi_hive() warn: sleepi

Re: [PATCH v14 2/9] platform/x86/amd: Add support for AMD ACPI based Wifi band RFI mitigation feature

2023-12-04 Thread Hans de Goede
Hi, On 11/29/23 10:13, Ma Jun wrote: > Due to electrical and mechanical constraints in certain platform designs > there may be likely interference of relatively high-powered harmonics of > the (G-)DDR memory clocks with local radio module frequency bands used > by Wifi 6/6e/7. > > To mitigate thi

[PATCH] [v2] drm/radeon/trinity_dpm: fix a memleak in trinity_parse_power_table

2023-12-04 Thread Zhipeng Lu
The rdev->pm.dpm.ps allocated by kcalloc should be freed in every following error-handling path. However, in the error-handling of rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, resulting in a memleak in this function. Fixes: d70229f70447 ("drm/radeon/kms: add dpm support for

[PATCH] [v2] drm/radeon/dpm: fix a memleak in sumo_parse_power_table

2023-12-04 Thread Zhipeng Lu
The rdev->pm.dpm.ps allocated by kcalloc should be freed in every following error-handling path. However, in the error-handling of rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, resulting in a memleak in this function. Fixes: 80ea2c129c76 ("drm/radeon/kms: add dpm support for

Re: [PATCH] drm/radeon/trinity_dpm: fix a memleak in trinity_parse_power_table

2023-12-04 Thread Amos Jianjun Kong
On Mon, Dec 4, 2023 at 5:55 PM Zhipeng Lu wrote: > > The rdev->pm.dpm.ps allocated by kcalloc should be freed in every > following error-handling path. However, in the error-handling of > rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, > resulting in a memleak in this function

Re: [RFC PATCH 0/6] Supporting GMEM (generalized memory management) for external memory devices

2023-12-04 Thread Alistair Popple
Christian König writes: > Am 01.12.23 um 06:48 schrieb Zeng, Oak: >> [SNIP] >> Besides memory eviction/oversubscription, there are a few other pain points >> when I use hmm: >> >> 1) hmm doesn't support file-back memory, so it is hard to share > memory b/t process in a gpu environment. You me

radeon flooding "flip queue failed" in Xorg and system log

2023-12-04 Thread smesgr
Hi, I have updated my old Fujitsu S920 with AMD GX-424CC from Ubuntu 22.04 LTS to Debian 12. The system worked fine before, after the installation completed, my logs are flooded by the following error messages: dmesg: [ 967.869183] radeon :00:01.0: 3ba3c813 pin failed [ 967.869212]

Re: [RFC PATCH 2/6] mm/gmem: add arch-independent abstraction to track address mapping status

2023-12-04 Thread Pedro Falcato
On Fri, Dec 1, 2023 at 9:23 AM David Hildenbrand wrote: > > On 28.11.23 13:50, Weixi Zhu wrote: > > This patch adds an abstraction layer, struct vm_object, that maintains > > per-process virtual-to-physical mapping status stored in struct gm_mapping. > > For example, a virtual page may be mapped t

[PATCH] drm/radeon/dpm: fix a memleak in sumo_parse_power_table

2023-12-04 Thread Zhipeng Lu
The rdev->pm.dpm.ps allocated by kcalloc should be freed in every following error-handling path. However, in the error-handling of rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, resulting in a memleak in this function. Fixes: 80ea2c129c76 ("drm/radeon/kms: add dpm support for

[PATCH] drm/radeon/trinity_dpm: fix a memleak in trinity_parse_power_table

2023-12-04 Thread Zhipeng Lu
The rdev->pm.dpm.ps allocated by kcalloc should be freed in every following error-handling path. However, in the error-handling of rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, resulting in a memleak in this function. Fixes: d70229f70447 ("drm/radeon/kms: add dpm support for

Re: Radeon regression in 6.6 kernel

2023-12-04 Thread Phillip Susi
Alex Deucher writes: > Phillip, > > Can you test this patch? I was not able to repro the issue on the > navi2x card I had handy, but I think it should fix it. I pulled -rc4 and it still had the problem. I applied this patch, and yes, it fixed it!

Re: [PATCH v2 7/8] drm/simpledrm: Do not include

2023-12-04 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Remove unnecessary include statements for . > The file contains helpers for non-atomic code and should not be > required by most drivers. No functional changes. > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Sui Jingfeng > --- Reviewed-by: Javier Martinez Canil

Re: [RFC PATCH 0/6] Supporting GMEM (generalized memory management) for external memory devices

2023-12-04 Thread Christian König
Am 04.12.23 um 00:32 schrieb Alistair Popple: Christian König writes: Am 01.12.23 um 06:48 schrieb Zeng, Oak: [SNIP] Besides memory eviction/oversubscription, there are a few other pain points when I use hmm: 1) hmm doesn't support file-back memory, so it is hard to share memory b/t proces

[PATCH v2 7/8] drm/simpledrm: Do not include

2023-12-04 Thread Thomas Zimmermann
Remove unnecessary include statements for . The file contains helpers for non-atomic code and should not be required by most drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng --- drivers/gpu/drm/tiny/simpledrm.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH v2 8/8] drm/xlnx: Do not include

2023-12-04 Thread Thomas Zimmermann
Remove unnecessary include statements for . The file contains helpers for non-atomic code and should not be required by most drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 1 - 1 file changed, 1 deletion(-)

[PATCH v2 6/8] drm/ofdrm: Do not include

2023-12-04 Thread Thomas Zimmermann
Remove unnecessary include statements for . The file contains helpers for non-atomic code and should not be required by most drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng --- drivers/gpu/drm/tiny/ofdrm.c | 1 - 1 file changed, 1 deletion(-) diff --g

[PATCH v2 5/8] drm/solomon: Do not include

2023-12-04 Thread Thomas Zimmermann
Remove unnecessary include statements for . The file contains helpers for non-atomic code and should not be required by most drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Geert Uytterhoeven Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/solomon/ssd130

[PATCH v2 0/8] drm/plane-helpers: Minor clean ups

2023-12-04 Thread Thomas Zimmermann
Move drm_plane_helper_atomic_check() into udl, which is the only driver using it. Remove several unnecessary include statements for . v2: * fix documentation (Sui) Thomas Zimmermann (8): drm/plane-helper: Move drm_plane_helper_atomic_check() into udl drm/amdgpu: Do not include drm/

[PATCH v2 2/8] drm/amdgpu: Do not include

2023-12-04 Thread Thomas Zimmermann
Remove unnecessary include statements for . The file contains helpers for non-atomic code and should not be required by most drivers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/d

[PATCH v2 4/8] drm/shmobile: Do not include

2023-12-04 Thread Thomas Zimmermann
Remove unnecessary include statements for . The file contains helpers for non-atomic code and should not be required by most drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven --- drivers/gpu/drm/renesas/shmobile/shmob_

[PATCH v2 1/8] drm/plane-helper: Move drm_plane_helper_atomic_check() into udl

2023-12-04 Thread Thomas Zimmermann
The udl driver is the only caller of drm_plane_helper_atomic_check(). Move the function into the driver. No functional changes. v2: * fix documenation (Sui) Signed-off-by: Thomas Zimmermann Acked-by: Sui Jingfeng --- drivers/gpu/drm/drm_crtc_helper.c | 7 ++- drivers/gpu/drm/drm_

[PATCH v2 3/8] drm/loongson: Do not include

2023-12-04 Thread Thomas Zimmermann
Remove unnecessary include statements for . The file contains helpers for non-atomic code and should not be required by most drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng Tested-by: Sui Jingfeng --- drivers/gpu/drm/loongson/lsdc_plane.c | 1 - 1 fil

RE: [PATCH] drm/amd/swsmu: update smu v14_0_0 driver if version and metrics table

2023-12-04 Thread Ma, Li
[Public] Hi Alex, Sorry for the late reply. Only smu14 used this gpu_metrics_v3_0 struct. And the patch has upstream. As far as l know, umr used gpu_metrics_v3_0 and I will submit a patch to umr. Does this struct need to be back compatible currently? If yes, I will revert this patch and add a

Re: [PATCH v5 00/32] drm/amd/display: add AMD driver-specific properties for color mgmt

2023-12-04 Thread Maxime Ripard
On Fri, Dec 01, 2023 at 10:20:40AM -0500, Harry Wentland wrote: > > > On 2023-11-30 06:34, Daniel Vetter wrote: > > On Tue, 28 Nov 2023 at 23:11, Harry Wentland wrote: > >> > >> On 2023-11-16 14:57, Melissa Wen wrote: > >>> Hello, > >>> > >>> This series extends the current KMS color management

Re: [PATCH 2/2] drm/amdgpu: Auto-validate DMABuf imports in compute VMs

2023-12-04 Thread Christian König
Am 15.11.23 um 00:32 schrieb Felix Kuehling: DMABuf imports in compute VMs are not wrapped in a kgd_mem object on the process_info->kfd_bo_list. There is no explicit KFD API call to validate them or add eviction fences to them. This patch automatically validates and fences dymanic DMABuf imports

Re: [PATCH] drm/radeon/dpm: fix a memleak in sumo_parse_power_table

2023-12-04 Thread Christian König
Am 03.12.23 um 18:16 schrieb Zhipeng Lu: The rdev->pm.dpm.ps allocated by kcalloc should be freed in every following error-handling path. However, in the error-handling of rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, resulting in a memleak in this function. Fixes: 80ea2c1