[PATCH 6.1 069/223] drm/client: Send hotplug event after registering a client

2023-07-21 Thread Greg Kroah-Hartman
From: Thomas Zimmermann commit 27655b9bb9f0d9c32b8de8bec649b676898c52d5 upstream. Generate a hotplug event after registering a client to allow the client to configure its display. Remove the hotplug calls from the existing clients for fbdev emulation. This change fixes a concurrency bug between

Re: AMDGPU crash - request for assistance triaging / reporting

2023-07-21 Thread Matthew Hall
On Fri, Jul 21, 2023 at 01:33:02PM +, Deucher, Alexander wrote: > Please file a bug here: > https://gitlab.freedesktop.org/drm/amd/-/issues OK, here it is: https://gitlab.freedesktop.org/drm/amd/-/issues/2718 > I believe the Z16 was certified on ubuntu, so you should have a good > experienc

[PATCH 6.4 111/292] drm/client: Send hotplug event after registering a client

2023-07-21 Thread Greg Kroah-Hartman
From: Thomas Zimmermann commit 27655b9bb9f0d9c32b8de8bec649b676898c52d5 upstream. Generate a hotplug event after registering a client to allow the client to configure its display. Remove the hotplug calls from the existing clients for fbdev emulation. This change fixes a concurrency bug between

Re: [PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

2023-07-21 Thread Alex Deucher
Applied. Thanks! On Fri, Jul 21, 2023 at 2:10 AM wrote: > > Fix nine occurrences of the checkpatch.pl error: > ERROR: "foo * bar" should be "foo *bar" > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/atom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a

Re: [PATCH] drm/amd/pm: open brace '{' following struct go on the same line

2023-07-21 Thread Alex Deucher
On Thu, Jul 20, 2023 at 11:53 PM wrote: > > ERROR: open brace '{' following struct go on the same line > The description doesn't match what the patch is doing. Alex > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 8 > 1 file changed, 4 insertions(+), 4 de

Re: [PATCH] drm/amdgpu: open brace '{' following struct go on the same line

2023-07-21 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jul 20, 2023 at 11:32 PM wrote: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/inc/amdgpu_pm.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/a

Re: [PATCH] drm/amd/pm: open brace '{' following struct go on the same line

2023-07-21 Thread Alex Deucher
This applied properly. Applied. Thanks! Alex On Thu, Jul 20, 2023 at 11:27 PM wrote: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/pm/inc/smu_v13_0_0_pptable.h | 21 +++ > 1 file changed, 7 insertions(+),

Re: [PATCH] drm/amd: open brace '{' following struct go on the same line

2023-07-21 Thread Alex Deucher
On Thu, Jul 20, 2023 at 9:31 PM wrote: > > Fix the checkpatch error as open brace '{' following struct should > go on the same line. > > Signed-off-by: Ran Sun git am didn't seem to like the patch, but I was able to apply it cleanly manually with no fuzz. Not sure what's up, but I've applied it

Re: [PATCH] drm/amd/display: Unlock on error path in dm_handle_mst_sideband_msg_ready_event()

2023-07-21 Thread Alex Deucher
On Fri, Jul 21, 2023 at 10:57 AM Dan Carpenter wrote: > > This error path needs to unlock the "aconnector->handle_mst_msg_ready" > mutex before returning. > > Fixes: bb4fa525f327 ("drm/amd/display: Add polling method to handle MST reply > packet") > Signed-off-by: Dan Carpenter Applied. Thanks

Re: [PATCH] drm/radeon: Avoid externs & do not initialize globals to 0 in radeon_drv.c

2023-07-21 Thread Alex Deucher
On Sat, Jul 15, 2023 at 11:26 AM Srinivasan Shanmugam wrote: > > Fixes the following: > > - WARNING: externs should be avoided in .c files > - ERROR: do not initialise globals to 0 > - WARNING: Missing a blank line after declarations > > Cc: Christian König > Cc: Alex Deucher > Signed-off-by:

Re: [PATCH v2] drm/radeon: Prefer dev_* variant over printk

2023-07-21 Thread Alex Deucher
On Thu, Jul 20, 2023 at 6:29 AM Srinivasan Shanmugam wrote: > > Changed from pr_err/info to dev_* variants so that > we get better debug info when there are multiple GPUs > in the system. > > 'Fixes: 8e2503972912c ("drm/radeon: Prefer pr_err/_info over printk")' > Suggested-by: Alex Deucher > Cc:

Re: [PATCH] drm/amdgpu: Fix do not add new typedefs in amdgpu_fw_attestation.c

2023-07-21 Thread Alex Deucher
On Fri, Jul 21, 2023 at 4:17 AM Srinivasan Shanmugam wrote: > > Fixes the following to align to coding style: > > WARNING: do not add new typedefs > +typedef struct FW_ATT_DB_HEADER > > WARNING: do not add new typedefs > +typedef struct FW_ATT_RECORD > > WARNING: Symbolic permissions 'S_IRUSR' are

Re: [PATCH] drm/amdgpu: Prefer #if IS_ENABLED over #if defined in amdgpu_drv.c

2023-07-21 Thread Alex Deucher
On Fri, Jul 21, 2023 at 3:49 AM Srinivasan Shanmugam wrote: > > Adhere to linux coding style > > Fixes the following: > > WARNING: Prefer IS_ENABLED() to CONFIG_ || CONFIG__MODULE > +#if defined(CONFIG_DRM_RADEON) || defined(CONFIG_DRM_RADEON_MODULE) > > WARNING: Prefer IS_ENABLED() to CONFIG_ ||

Re: [PATCH] drm/amdgpu: Return -ENOMEM when there is no memory in 'amdgpu_gfx_mqd_sw_init'

2023-07-21 Thread Alex Deucher
On Fri, Jul 21, 2023 at 5:22 AM Srinivasan Shanmugam wrote: > > Return -ENOMEM, when there is no sufficient dynamically allocated memory > to create MQD backup for ring > > Cc: Christian König > Cc: Alex Deucher > Signed-off-by: Srinivasan Shanmugam Reviewed-by: Alex Deucher > --- > drivers

Re: [PATCH] drm/amdgpu: Fix style issues in amdgpu_gem.c

2023-07-21 Thread Alex Deucher
On Fri, Jul 21, 2023 at 4:37 AM Srinivasan Shanmugam wrote: > > Fixes the following to align to linux coding style: > > WARNING: braces {} are not necessary for any arm of this statement > WARNING: Missing a blank line after declarations > ERROR: space prohibited before that close parenthesis ')'

[PATCH] drm/amd/display: Unlock on error path in dm_handle_mst_sideband_msg_ready_event()

2023-07-21 Thread Dan Carpenter
This error path needs to unlock the "aconnector->handle_mst_msg_ready" mutex before returning. Fixes: bb4fa525f327 ("drm/amd/display: Add polling method to handle MST reply packet") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- 1 file chang

Re: [PATCH v5 05/11] drm/amdgpu: Use RMW accessors for changing LNKCTL

2023-07-21 Thread Alex Deucher
On Fri, Jul 21, 2023 at 4:18 AM Ilpo Järvinen wrote: > > On Thu, 20 Jul 2023, Bjorn Helgaas wrote: > > > On Mon, Jul 17, 2023 at 03:04:57PM +0300, Ilpo Järvinen wrote: > > > Don't assume that only the driver would be accessing LNKCTL. ASPM > > > policy changes can trigger write to LNKCTL outside o

Re: AMDGPU crash - request for assistance triaging / reporting

2023-07-21 Thread Deucher, Alexander
[AMD Official Use Only - General] Please file a bug here: https://gitlab.freedesktop.org/drm/amd/-/issues and we'll take a look. I believe the Z16 was certified on ubuntu, so you should have a good experience with the latest ubuntu LTS with the OEM kernel package. One issue we've run into is

Re: [PATCH 6/7] drm/amdgpu/jpeg: mmsch_v3_0_4 requires doorbell on 32 byte boundary

2023-07-21 Thread Lazar, Lijo
On 7/21/2023 12:49 AM, Samir Dhume wrote: Signed-off-by: Samir Dhume --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c inde

Re: [PATCH 28/29] drm/amdkfd: Refactor migrate init to support partition switch

2023-07-21 Thread Philip Yang
On 2023-07-21 04:55, Michel Dänzer wrote: On 7/20/23 22:48, Philip Yang wrote: On 2023-07-20 06:46, Michel Dänzer wrote: On 7/17/23 15:09, Michel Dänzer wrote: On 5/10/23 23:23, Alex Deucher wrote:

[PATCH] drm/amd/display: set stream gamut remap matrix to MPC for DCN3+

2023-07-21 Thread Melissa Wen
dc->caps.color.mpc.gamut_remap says there is a post-blending color block for gamut remap matrix for DCN3 HW family and newer versions. However, those drivers still follow DCN10 programming that remap stream gamut_remap_matrix to DPP (pre-blending). To enable pre-blending and post-blending gamut_re

[PATCH Review 1/1] drm/amdgpu: Check APU flag to disable RAS

2023-07-21 Thread Stanley . Yang
Only disable RAS by default for aqua vanjaram on APU platform. Signed-off-by: Stanley.Yang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index 22

Re: [PATCH 3/7] drm/amdgpu/vcn: sriov support for vcn_v4_0_3

2023-07-21 Thread Lazar, Lijo
On 7/21/2023 12:49 AM, Samir Dhume wrote: initialization table handshake with mmsch Signed-off-by: Samir Dhume --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 261 +--- 1 file changed, 237 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3

Re: [PATCH Review 1/1] drm/amdgpu: Fix out of range

2023-07-21 Thread Lazar, Lijo
cc: Morris/Le On 7/21/2023 5:36 PM, Stanley.Yang wrote: The xcc index should be refer to xcc_mask, convert xcc_mask to counts then calculate device instance. Signed-off-by: Stanley.Yang Reviewed-by: Lijo Lazar Thanks, Lijo --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 24 +-

[PATCH Review 1/1] drm/amdgpu: Fix out of range

2023-07-21 Thread Stanley . Yang
The xcc index should be refer to xcc_mask, convert xcc_mask to counts then calculate device instance. Signed-off-by: Stanley.Yang --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/

Re: [PATCH 28/29] drm/amdkfd: Refactor migrate init to support partition switch

2023-07-21 Thread Michel Dänzer
On 7/21/23 10:55, Michel Dänzer wrote: > On 7/20/23 22:48, Philip Yang wrote: >> On 2023-07-20 06:46, Michel Dänzer wrote: >>> On 7/17/23 15:09, Michel Dänzer wrote: On 5/10/23 23:23, Alex Deucher wrote: > From: Philip Yang > > Rename smv_migrate_init to a better name kgd2kfd_init

[PATCH] drm/amdgpu: Return -ENOMEM when there is no memory in 'amdgpu_gfx_mqd_sw_init'

2023-07-21 Thread Srinivasan Shanmugam
Return -ENOMEM, when there is no sufficient dynamically allocated memory to create MQD backup for ring Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --

Re: [PATCH 28/29] drm/amdkfd: Refactor migrate init to support partition switch

2023-07-21 Thread Michel Dänzer
On 7/20/23 22:48, Philip Yang wrote: > On 2023-07-20 06:46, Michel Dänzer wrote: >> On 7/17/23 15:09, Michel Dänzer wrote: >>> On 5/10/23 23:23, Alex Deucher wrote: From: Philip Yang Rename smv_migrate_init to a better name kgd2kfd_init_zone_device because it setup zone devive

[PATCH] drm/amdgpu: Fix style issues in amdgpu_gem.c

2023-07-21 Thread Srinivasan Shanmugam
Fixes the following to align to linux coding style: WARNING: braces {} are not necessary for any arm of this statement WARNING: Missing a blank line after declarations ERROR: space prohibited before that close parenthesis ')' WARNING: unnecessary whitespace before a quoted newline WARNING: %LX is

[PATCH] drm/amd/pm: open brace '{' following struct go on the same line

2023-07-21 Thread sunran001
ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- .../gpu/drm/amd/pm/inc/smu_v13_0_0_pptable.h | 21 +++ 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/inc/smu_v13_0_0_pptable.h b/drivers/gpu/drm/amd/pm

[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

2023-07-21 Thread sunran001
Fix two occurrences of the checkpatch.pl error: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/atom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c index 11a1940b

Re: radeon.ko/i586: BUG: kernel NULL pointer dereference, address:00000004

2023-07-21 Thread kkabe
rost...@goodmis.org sed in <20230717113623.41878...@gandalf.local.home> >> On Fri, 14 Jul 2023 14:34:04 +0900 >> wrote: >> >> > Patch in >> > https://bugzilla.kernel.org/show_bug.cgi?id=217669#c4 >> > fixed the problem in freedesktop.org kernel 5.18.0-rc2 . >> > This may explain that in kernel.o

[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

2023-07-21 Thread sunran001
Fix nine occurrences of the checkpatch.pl error: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/atom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c index 11a1940

[PATCH] drm/amd/pm: open brace '{' following struct go on the same line

2023-07-21 Thread sunran001
ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h b/drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h index ddc

[PATCH] drm/amdgpu: open brace '{' following struct go on the same line

2023-07-21 Thread sunran001
ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/inc/amdgpu_pm.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/inc/amdgpu_pm.h b/drivers/gpu/drm/amd/pm/inc/amdgpu_pm.h index 52045ad59bed

Re: [PATCH v5 05/11] drm/amdgpu: Use RMW accessors for changing LNKCTL

2023-07-21 Thread Ilpo Järvinen
On Thu, 20 Jul 2023, Bjorn Helgaas wrote: > On Mon, Jul 17, 2023 at 03:04:57PM +0300, Ilpo Järvinen wrote: > > Don't assume that only the driver would be accessing LNKCTL. ASPM > > policy changes can trigger write to LNKCTL outside of driver's control. > > And in the case of upstream bridge, the d

[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

2023-07-21 Thread sunran001
Fix two occurrences of the checkpatch.pl error: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Jianghui Xu --- drivers/gpu/drm/radeon/atom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c index 11a1

[PATCH] drm/amd: open brace '{' following struct go on the same line

2023-07-21 Thread sunran001
Fix the checkpatch error as open brace '{' following struct should go on the same line. Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/include/yellow_carp_offset.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/yellow_carp_offset.h b/drive

[PATCH] drm/amdgpu: Fix do not add new typedefs in amdgpu_fw_attestation.c

2023-07-21 Thread Srinivasan Shanmugam
Fixes the following to align to coding style: WARNING: do not add new typedefs +typedef struct FW_ATT_DB_HEADER WARNING: do not add new typedefs +typedef struct FW_ATT_RECORD WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. +

[PATCH] drm/amdgpu: Prefer #if IS_ENABLED over #if defined in amdgpu_drv.c

2023-07-21 Thread Srinivasan Shanmugam
Adhere to linux coding style Fixes the following: WARNING: Prefer IS_ENABLED() to CONFIG_ || CONFIG__MODULE +#if defined(CONFIG_DRM_RADEON) || defined(CONFIG_DRM_RADEON_MODULE) WARNING: Prefer IS_ENABLED() to CONFIG_ || CONFIG__MODULE +#if defined(CONFIG_DRM_RADEON) || defined(CONFIG_DRM_RADEON_