Do not compare injection address with mc_vram_size
if mc_vram_size is zero.
Signed-off-by: Stanley.Yang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_r
Using "is_app_apu" to identify device in the native
APU mode or carveout mode.
Signed-off-by: Stanley.Yang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 8 +++---
drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c | 34 ++---
3 files cha
For gc_11_0_1, the external rev_id of A0/A1 series is 0x1,
the external rev_id of A2 is 0x10.
Signed-off-by: Aaron Liu
---
drivers/gpu/drm/amd/amdgpu/soc21.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c
b/drivers/gpu/drm/amd/amdgp
From: Sui Jingfeng
[why]
The vga_is_firmware_default() defined in drivers/pci/vgaarb.c is
arch-dependent, it's a dummy on non-x86 architectures currently.
This made VGAARB lost an important condition for the arbitration.
It could still be wrong even if we remove the #ifdef and #endif guards.
bec
From: Sui Jingfeng
[why]
The vga_is_firmware_default() defined in drivers/pci/vgaarb.c is
arch-dependent, it's a dummy on non-x86 architectures currently.
This made VGAARB lost an important condition for the arbitration.
It could still be wrong even if we remove the #ifdef and #endif guards.
bec
From: Sui Jingfeng
The vga_is_firmware_default() function is arch-dependent, it's probably
wrong if we simply remove the arch guard. As the VRAM BAR which contains
firmware framebuffer may move, while the lfb_base and lfb_size members of
the screen_info does not change accordingly. In short, it s
From: Sui Jingfeng
This patch adds the aperture_contain_firmware_fb() function to do the
determination. Unfortunately due to the fact that apertures list will be
freed dynamically, the location and size information of the firmware fb
will be lost after dedicated drivers call
aperture_remove_confl
From: Sui Jingfeng
Per Documentation/process/license-rules.rst, the SPDX MIT identifier is
equivalent to including the entire MIT license text from
LICENSES/preferred/MIT.
Replace the MIT license text with the equivalent SPDX identifier.
Cc: David Airlie
Cc: Daniel Vetter
Cc: Maarten Lankhors
From: Sui Jingfeng
This patch replaces the leading space with a tab and removes the double
blank line, no functional change.
Cc: Bjorn Helgaas
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: David Airlie
Cc: Daniel Vetter
Signed-off-by: Sui Jingfeng
Reviewed-by: Andi Shy
From: Sui Jingfeng
The io_state variable in the vga_arb_write() function is declared with
unsigned int type, while the vga_str_to_iostate() function takes int *
type. To keep them consistent, replace the third argument of
vga_str_to_iostate() function with the unsigned int * type.
Cc: Bjorn Helg
From: Sui Jingfeng
Deal only with the VGA devcie(pdev->class == 0x0300), so replace the
pci_get_subsys() function with pci_get_class(). Filter the non-PCI display
device(pdev->class != 0x0300) out. There no need to process the non-display
PCI device.
Cc: Bjorn Helgaas
Signed-off-by: Sui Jingfen
The vga_is_firmware_default() function is arch-dependent, it's probably
wrong if we simply remove the arch guard. As the VRAM BAR which contains
firmware framebuffer may move, while the lfb_base and lfb_size members of
the screen_info does not change accordingly. In short, it should take the
re-all
The io_state variable in the vga_arb_write() function is declared with
unsigned int type, while the vga_str_to_iostate() function takes int *
type. To keep them consistent, replace the third argument of
vga_str_to_iostate() function with the unsigned int * type.
Cc: Bjorn Helgaas
Signed-off-by: S
This patch replaces the leading space with a tab and removes the double
blank line, no functional change.
Cc: Bjorn Helgaas
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: David Airlie
Cc: Daniel Vetter
Signed-off-by: Sui Jingfeng
Reviewed-by: Andi Shyti
---
drivers/pci/
Per Documentation/process/license-rules.rst, the SPDX MIT identifier is
equivalent to including the entire MIT license text from
LICENSES/preferred/MIT.
Replace the MIT license text with the equivalent SPDX identifier.
Cc: David Airlie
Cc: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Maxime Ripard
From: Sui Jingfeng <15330273...@189.cn>
The vga_is_firmware_default() function is arch-dependent, it's probably
wrong if we simply remove the arch guard. As the VRAM BAR which contains
firmware framebuffer may move, while the lfb_base and lfb_size members of
the screen_info does not change accordi
Deal only with the VGA devcie(pdev->class == 0x0300), so replace the
pci_get_subsys() function with pci_get_class(). Filter the non-PCI display
device(pdev->class != 0x0300) out. There no need to process the non-display
PCI device.
Cc: Bjorn Helgaas
Signed-off-by: Sui Jingfeng
---
drivers/pci/v
Thanks
I'm happy to help debug this further
On Mon, 12 Jun 2023 at 15:18, Harry Wentland wrote:
>
> On 6/12/23 10:00, Alex Deucher wrote:
> > This reverts commit 58e67bb3c131da5ee14e4842b08e53f4888dce0a.
> >
> > This patch was reverted, but came back again as
> > commit 58e67bb3c131 ("drm/amd/di
[AMD Official Use Only - General]
Reviewed-by: Aaron Liu
> -Original Message-
> From: amd-gfx On Behalf Of Alex
> Deucher
> Sent: Tuesday, June 13, 2023 5:48 AM
> To: Deucher, Alexander
> Cc: amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/amdgpu/sdma4: set align mask to 255
>
[Public]
Reviewed-by: Guchun Chen
> -Original Message-
> From: amd-gfx On Behalf Of Alex
> Deucher
> Sent: Monday, June 12, 2023 10:55 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: [PATCH] drm/amd/display: don't free stolen console memory during
> suspend
>
Am 2023-06-07 um 12:31 schrieb Alex Deucher:
The wptr needs to be incremented at at least 64 dword intervals,
use 256 to align with windows. This should fix potential hangs
with unaligned updates.
Signed-off-by: Alex Deucher
Reviewed-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdgpu/sd
Remove DUMMY_VRAM_SIZE as it is not needed and can result
in reporting incorrect memory size.
Signed-off-by: Mukul Joshi
---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
b/drivers/gpu/drm/amd/amdkfd/kfd_crat.
FWIW: Should have a response to this very soon, figured out the cause of my
MST issues so I should be able to test this very soon
On Fri, 2023-06-09 at 18:49 +0800, Wayne Lin wrote:
> [Why]
> The sequence for collecting down_reply from source perspective should
> be:
>
> Request_n->repeat (get pa
Ping?
On Wed, Jun 7, 2023 at 12:46 PM Alex Deucher wrote:
>
> DDR5 channels are 32 bit rather than 64, report the width properly
> in the log.
>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2468
> Signed-off-by: Alex Deucher
> ---
> .../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 20
ping?
On Wed, Jun 7, 2023 at 12:31 PM Alex Deucher wrote:
>
> The wptr needs to be incremented at at least 64 dword intervals,
> use 256 to align with windows. This should fix potential hangs
> with unaligned updates.
>
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v4_0
[AMD Official Use Only - General]
> -Original Message-
> From: Kuehling, Felix
> Sent: Monday, June 12, 2023 2:15 PM
> To: Joshi, Mukul ; amd-gfx@lists.freedesktop.org
> Cc: Koenig, Christian
> Subject: Re: [PATCHv2] drm/amdgpu: Update invalid PTE flag setting
>
>
> Am 2023-06-12 um 12:2
The vga_is_firmware_default() function is arch-dependent, it's probably
wrong if we simply remove the arch guard. As the VRAM BAR which contains
firmware framebuffer may move, while the lfb_base and lfb_size members of
the screen_info does not change accordingly. In short, it should take the
re-all
From: Sui Jingfeng
Per Documentation/process/license-rules.rst, the SPDX MIT identifier is
equivalent to including the entire MIT license text from
LICENSES/preferred/MIT.
Replace the MIT license text with the equivalent SPDX identifier.
Signed-off-by: Sui Jingfeng
Reviewed-by: Andi Shyti
---
From: Sui Jingfeng
This patch replaces the leading space with a tab and removes the double
blank line, no functional change.
Signed-off-by: Sui Jingfeng
Reviewed-by: Andi Shyti
---
drivers/pci/vgaarb.c | 108 -
include/linux/vgaarb.h | 4 +-
2 files
From: Sui Jingfeng
Deal only with the VGA devcie(pdev->class == 0x0300), so replace the
pci_get_subsys() function with pci_get_class(). Filter the non-PCI display
device(pdev->class != 0x0300) out. There no need to process the non-display
PCI device.
Signed-off-by: Sui Jingfeng
---
drivers/pci
From: Sui Jingfeng
The vga_is_firmware_default() function is arch-dependent, it's probably
wrong if we simply remove the arch guard. As the VRAM BAR which contains
firmware framebuffer may move, while the lfb_base and lfb_size members of
the screen_info does not change accordingly. In short, it s
From: Sui Jingfeng
The io_state variable in the vga_arb_write() function is declared with
unsigned int type, while the vga_str_to_iostate() function takes int *
type. To keep them consistent, replace the third argument of
vga_str_to_iostate() function with the unsigned int * type.
Signed-off-by:
Hi,
On 2023/5/8 11:09, Huacai Chen wrote:
LoongArch now provides kernel_fpu_begin() and kernel_fpu_end() that are
used like the x86 counterparts in commit 2b3bd32ea3a22ea2d ("LoongArch:
Provide kernel fpu functions"), so we can enable DC_FP on LoongArch for
supporting more DCN devices.
Signed-o
Am 2023-06-12 um 12:23 schrieb Mukul Joshi:
Update the invalid PTE flag setting with TF enabled.
This is to ensure, in addition to transitioning the
retry fault to a no-retry fault, it also causes the
wavefront to enter the trap handler. With the current
setting, the fault only transitions to a
[Public]
Hi Michel,
I want to double check if we're identifying the correct monitor for applying
the workaround. Could you please try the attached patch and let me know the
panel id ?
--
Regards,
Jay
From: Michel Dänzer
Sent: Thursday, June 8, 2023 11:18 AM
T
Am 2023-06-12 um 11:46 schrieb Jonathan Kim:
Null check should be done on queue struct itself and not on the
process queue list node.
Signed-off-by: Jonathan Kim
Reviewed-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdkfd/kfd_debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
Testing for intermittent failures or race conditions is not easy. If we
create such a test, we need to make sure it can catch the problem when
not using the event ages, just to know that the test is good enough.
I guess it could be a parametrized test that can run with or without
event age. Wi
Update the invalid PTE flag setting with TF enabled.
This is to ensure, in addition to transitioning the
retry fault to a no-retry fault, it also causes the
wavefront to enter the trap handler. With the current
setting, the fault only transitions to a no-retry fault.
Additionally, have 2 sets of in
[AMD Official Use Only - General]
The current ROCr patches already address my previous feedback. I am ok with the
current ROCr patches.
Currently, there is no ROCrtst that would stress this multiple-waiters issue. I
was thinking something like the KFDTest, but with by calling the waiters from
[Public]
Acked-by: Alex Deucher
From: SHANMUGAM, SRINIVASAN
Sent: Monday, June 12, 2023 6:28 AM
To: Deucher, Alexander ; Koenig, Christian
Cc: amd-gfx@lists.freedesktop.org ; SHANMUGAM,
SRINIVASAN
Subject: [PATCH] drm/radeon: Fix missing prototypes in radeon_
Null check should be done on queue struct itself and not on the
process queue list node.
Signed-off-by: Jonathan Kim
---
drivers/gpu/drm/amd/amdkfd/kfd_debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_debug.c
b/drivers/gpu/drm/amd/amdkfd
On Sat, Jun 10, 2023 at 10:14:05AM +0300, Jani Nikula wrote:
> On Thu, 08 Jun 2023, Nathan Chancellor wrote:
> > -Wunused-but-set-variable was only supported in clang starting with
> > 13.0.0, so earlier versions will emit a warning, which is turned into a
> > hard error for the kernel to mirror G
[Public]
> -Original Message-
> From: Kuehling, Felix
> Sent: Monday, June 12, 2023 11:25 AM
> To: Lu Hongfei ; Deucher, Alexander
> ; Koenig, Christian
> ; Pan, Xinhui ; David
> Airlie ; Daniel Vetter ; open list:AMD
> KFD ; open list:DRM DRIVERS de...@lists.freedesktop.org>; open list
[+Jon]
Am 2023-06-12 um 07:58 schrieb Lu Hongfei:
pqn bound in list_for_each_entry loop will not be null, so there is
no need to check whether pqn is NULL or not.
Thus remove a redundant null pointer check.
Signed-off-by: Lu Hongfei
---
The filename of the previous version was:
0001-gpu-drm-am
On 6/12/23 10:55, Alex Deucher wrote:
> Don't free the memory if we are hitting this as part of suspend.
> This way we don't free any memory during suspend; see
> amdgpu_bo_free_kernel(). The memory will be freed in the first
> non-suspend modeset or when the driver is torn down.
>
> Link: htt
Don't free the memory if we are hitting this as part of suspend.
This way we don't free any memory during suspend; see
amdgpu_bo_free_kernel(). The memory will be freed in the first
non-suspend modeset or when the driver is torn down.
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2568
Sig
Hi,
On 2023/6/12 22:41, Deucher, Alexander wrote:
[Public]
-Original Message-
From: Sui Jingfeng
Sent: Sunday, June 11, 2023 11:24 AM
To: Wentland, Harry ; Li, Sun peng (Leo)
; Siqueira, Rodrigo ;
Deucher, Alexander ; Koenig, Christian
; Pan, Xinhui ; David
Airlie ; Daniel Vetter ; Le
[AMD Official Use Only - General]
Looks good to me. Approved.
Reviewed-by: Alvin Lee
Thanks,
Alvin
-Original Message-
From: Srinivasan Shanmugam
Sent: Monday, June 12, 2023 10:00 AM
To: Pillai, Aurabindo ; Siqueira, Rodrigo
; Wentland, Harry ; Mahfooz,
Hamza ; Wang, Chao-kai (Stylo
[Public]
> -Original Message-
> From: Sui Jingfeng
> Sent: Sunday, June 11, 2023 11:24 AM
> To: Wentland, Harry ; Li, Sun peng (Leo)
> ; Siqueira, Rodrigo ;
> Deucher, Alexander ; Koenig, Christian
> ; Pan, Xinhui ; David
> Airlie ; Daniel Vetter ; Lee, Alvin
> ; Lei, Jun ; Zhuo, Qingqing
On 6/12/23 10:00, Alex Deucher wrote:
> This reverts commit 58e67bb3c131da5ee14e4842b08e53f4888dce0a.
>
> This patch was reverted, but came back again as
> commit 58e67bb3c131 ("drm/amd/display: fix dpms_off issue when disabling bios
> mode")
> Revert it again as it breaks Asus G513QY / 6800M lap
This reverts commit 58e67bb3c131da5ee14e4842b08e53f4888dce0a.
This patch was reverted, but came back again as
commit 58e67bb3c131 ("drm/amd/display: fix dpms_off issue when disabling bios
mode")
Revert it again as it breaks Asus G513QY / 6800M laptops.
Bug: https://gitlab.freedesktop.org/drm/amd
Fixes the following gcc with W=1:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource_helpers.c:285:
warning: Function parameter or member 'dc' not described in
'dcn32_determine_det_override'
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource_helpers.c:285:
warning: Functio
Fixes the following W=1 kernel build warning:
display/dc/dcn10/dcn10_optc.c:45: warning: This comment starts with '/**', but
isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* apply_front_porch_workaround TODO FPGA still need?
display/dc/dcn10/dcn10_optc.c:136: warning: T
On 6/3/23 08:28, Srinivasan Shanmugam wrote:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_optc.c:109: warning: This
comment starts with '/**', but isn't a kernel-doc comment. Refer
Documentation/doc-guide/kernel-doc.rst
* Enable CRT
On 6/3/23 08:53, Srinivasan Shanmugam wrote:
Fixes the following gcc with W=1:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:285: warning:
Function parameter or member 'optc' not described in
'optc3_set_timing_double_buffer'
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30
On 6/4/23 23:10, Srinivasan Shanmugam wrote:
Fixes the following W=1 kernel build warning:
display/dc/dcn10/dcn10_opp.c:52: warning: Function parameter or member 'oppn10'
not described in 'opp1_set_truncation'
display/dc/dcn10/dcn10_opp.c:52: warning: Function parameter or member 'params'
n
On 6/11/23 19:32, Srinivasan Shanmugam wrote:
Fixes the following gcc with W=1:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/dcn32_fpu.c:872: warning:
Excess function parameter 'drr_pipe' description in 'subvp_drr_schedulable'
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/dcn32_fp
Hi Chrisitan,
On May 4, 2023, at 20:51, Christian König mailto:ckoenig.leichtzumer...@gmail.com>> wrote:
Use the new component here as well and remove the old handling.
v2: drop dupplicate handling
It seems that after dropping the duplicate handling, locking of VM PDs on
global BO list is bas
pqn bound in list_for_each_entry loop will not be null, so there is
no need to check whether pqn is NULL or not.
Thus remove a redundant null pointer check.
Signed-off-by: Lu Hongfei
---
The filename of the previous version was:
0001-gpu-drm-amd-Fix-the-bug-in-list_for_each_entry-loops.patch
The
> pqn bound in list_for_each_entry loop will not be null, so there is
> no need to check whether pqn is NULL or not.
Would it be more appropriate to use the wording “Delete an unnecessary check
within a list_for_each_entry() loop” instead of
“Fix the bug in list_for_each_entry() loops” in the patc
Hey Alex,
On 09/06/2023 19:08, Alex Deucher wrote:
On Fri, Jun 9, 2023 at 11:05 AM Shashank Sharma wrote:
This patch moves the code to flush GPU TLB using SDMA ring and
splits it into two parts:
- a general purpose function to flush GPU TLB using any valid GPU ring.
- a wrapper which consumes
Fixes the following gcc with W=1:
drivers/gpu/drm/radeon/radeon_atpx_handler.c:64:6: warning: no previous
prototype for ‘radeon_has_atpx’ [-Wmissing-prototypes]
64 | bool 4(void) {
| ^~~
drivers/gpu/drm/radeon/radeon_atpx_handler.c:68:6: warning: no previous
prototype f
[AMD Official Use Only - General]
Good point. gfx v11_0_3 doesn't support sram ecc. We should *not* let KFD
report SRAMEDC cap to user mode - it will result to wrong shader compiler with
ecc enabled for gfx v11_0_3.
I'm leaning toward creating per IP feature matrix to deal with the cases that
Hello Guchun,
Thanks for your comments.
On 12/06/2023 08:52, Chen, Guchun wrote:
[Public]
-Original Message-
From: amd-gfx On Behalf Of
Shashank Sharma
Sent: Friday, June 9, 2023 6:03 PM
To: amd-gfx@lists.freedesktop.org
Cc: Kuehling, Felix ; Somalapuram, Amaranath
; Koenig, Christia
Hi Christian,
> On May 4, 2023, at 20:51, Christian König
> wrote:
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 08eced097bd8..9e751f5d4aa7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_
[AMD Official Use Only - General]
> -Original Message-
> From: Zhang, Hawking
> Sent: Sunday, June 11, 2023 6:46 PM
> To: amd-gfx@lists.freedesktop.org; Yang, Stanley ;
> Li, Candice ; Chai, Thomas ;
> Zhou1, Tao
> Cc: Zhang, Hawking
> Subject: [PATCH 2/2] drm/amdgpu: Enable gfx v11_0_3
[AMD Official Use Only - General]
Thanks Johannes. Comment in-line
> -Original Message-
> From: Johannes Berg
> Sent: Friday, June 9, 2023 4:21 PM
> To: Quan, Evan ; raf...@kernel.org; l...@kernel.org;
> Deucher, Alexander ; Koenig, Christian
> ; Pan, Xinhui ;
> airl...@gmail.com; dan...
pqn bound in list_for_each_entry loop will not be null, so there is
no need to check whether pqn is NULL or not.
We could remove this check.
Signed-off-by: Lu Hongfei
---
drivers/gpu/drm/amd/amdkfd/kfd_debug.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_d
68 matches
Mail list logo
