RE: [PATCH 1/4] drm/amdgpu: add RAS page retirement functions for MCA

2022-10-20 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Zhang, Hawking > Sent: Friday, October 21, 2022 12:15 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Yang, > Stanley ; Chai, Thomas ; Li, > Candice > Subject: RE: [PATCH 1/4] drm/amdgpu: add RAS page retirement functi

Re: [PATCH 01/11] kset: fix documentation for kset_register()

2022-10-20 Thread Luben Tuikov
On 2022-10-20 22:20, Yang Yingliang wrote: > kset_register() is currently used in some places without calling > kset_put() in error path, because the callers think it should be > kset internal thing to do, but the driver core can not know what > caller doing with that memory at times. The memory co

Re: [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-20 Thread Luben Tuikov
On 2022-10-20 22:20, Yang Yingliang wrote: > The previous discussion link: > https://lore.kernel.org/lkml/0db486eb-6927-927e-3629-958f8f211...@huawei.com/T/ The very first discussion on this was here: https://www.spinics.net/lists/dri-devel/msg368077.html Please use this link, and not the that o

Re: [PATCH 1/2] drm/amdkfd: introduce dummy cache info for property asic

2022-10-20 Thread Felix Kuehling
Am 2022-10-20 um 21:50 schrieb Liang, Prike: [Public] -Original Message- From: Kuehling, Felix Sent: Friday, October 21, 2022 12:03 AM To: Liang, Prike ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Huang, Ray ; Liu, Aaron Subject: Re: [PATCH 1/2] drm/amdkfd:

RE: [PATCH 1/4] drm/amdgpu: add RAS page retirement functions for MCA

2022-10-20 Thread Zhang, Hawking
[AMD Official Use Only - General] Re - whether need to do gpu reset is determined by unmap queue status, so reset parameter can't be dropped + if (adev->gmc.xgmi.connected_to_cpu) { + ret = amdgpu_umc_poison_handler_mca(adev, ras_error_status, reset); I think amdgpu_umc_poi

RE: [PATCH 1/4] drm/amdgpu: add RAS page retirement functions for MCA

2022-10-20 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Zhang, Hawking > Sent: Thursday, October 20, 2022 5:13 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Yang, > Stanley ; Chai, Thomas ; Li, > Candice > Subject: RE: [PATCH 1/4] drm/amdgpu: add RAS page retirement functi

RE: [PATCH 4/4] drm/amdgpu: remove ras_error_status parameter for UMC poison handler

2022-10-20 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Zhang, Hawking > Sent: Thursday, October 20, 2022 5:30 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Yang, > Stanley ; Chai, Thomas ; Li, > Candice > Subject: RE: [PATCH 4/4] drm/amdgpu: remove ras_error_status param

[PATCH] drm/amdgpu: disallow gfxoff until GC IP blocks complete s2idle resume

2022-10-20 Thread Prike Liang
In the S2idle suspend/resume phase the gfxoff is keeping functional so some IP blocks will be likely to reinitialize at gfxoff entry and that will result in failing to program GC registers.Therefore, let disallow gfxoff until AMDGPU IPs reinitialized completely. Signed-off-by: Prike Liang --- dr

RE: [PATCH 1/2] drm/amdkfd: introduce dummy cache info for property asic

2022-10-20 Thread Liang, Prike
[Public] -Original Message- From: Kuehling, Felix Sent: Friday, October 21, 2022 12:03 AM To: Liang, Prike ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Huang, Ray ; Liu, Aaron Subject: Re: [PATCH 1/2] drm/amdkfd: introduce dummy cache info for property asic

Re: [PATCH] drm/amdkfd: use vma_lookup() instead of find_vma()

2022-10-20 Thread Felix Kuehling
Am 2022-10-20 um 04:20 schrieb Deming Wang: Using vma_lookup() verifies the start address is contained in the found vma. This results in easier to read the code. Signed-off-by: Deming Wang Thank you. This patch is Reviewed-by: Felix Kuehling I squashed it with your earlier patch in kfd_mi

Re: [PATCH] drm/amdkfd: use vma_lookup() instead of find_vma()

2022-10-20 Thread Felix Kuehling
Am 2022-10-06 um 22:26 schrieb Deming Wang: Using vma_lookup() verifies the start address is contained in the found vma. This results in easier to read the code. Signed-off-by: Deming Wang --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 8 1 file changed, 4 insertions(+), 4 deletion

Re: [PATCH v7 0/9] dyndbg: drm.debug adaptation

2022-10-20 Thread Ville Syrjälä
On Sat, Sep 24, 2022 at 03:02:34PM +0200, Greg KH wrote: > On Sun, Sep 11, 2022 at 11:28:43PM -0600, Jim Cromie wrote: > > hi Greg, Dan, Jason, DRM-folk, > > > > heres follow-up to V6: > > rebased on driver-core/driver-core-next for -v6 applied bits (thanks) > > rework drm_debug_enabled{_raw,_

Re: [PATCH 1/2] drm/amdkfd: introduce dummy cache info for property asic

2022-10-20 Thread Felix Kuehling
Am 2022-10-20 um 05:15 schrieb Prike Liang: This dummy cache info will enable kfd base function support. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 55 +-- 1 file changed, 52 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 31/33] drm/amd/display: Add kernel doc to some of the dc fields

2022-10-20 Thread Rodrigo Siqueira
Add kernel-doc to some important elements from DC struct that might help to understand DC sequence. Reviewed-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 5 ++- drivers/gpu/drm/amd/display/dc/dc_link.h

[PATCH 33/33] drm/amd/display: 3.2.209

2022-10-20 Thread Rodrigo Siqueira
From: Aric Cyr DC version 3.2.209 brings along the following: * Improve color manipulation * Add corrections to DML and some flag configuration * Updates for DCN32x * Expand kernel-doc Acked-by: Rodrigo Siqueira Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file c

[PATCH 27/33] drm/amd/display: Wrong colorimetry workaround

2022-10-20 Thread Rodrigo Siqueira
From: Ma Hanghong [Why] For FreeSync HDR, native color space flag in AMD VSIF(BT.709) should be used when intepreting content and color space flag in VSC or AVI infoFrame should be ignored. However, it turned out some userspace application still use color flag in VSC or AVI infoFrame which is inc

[PATCH 32/33] drm/amd/display: Add kernel doc for commit sequence

2022-10-20 Thread Rodrigo Siqueira
Add basic kernel-doc that describes some of the struct and functions that are part of the DC commit sequence.. Reviewed-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/core/dc.c | 63 --- .../gpu/drm/amd/di

[PATCH 29/33] drm/amd/display: Add DEC/CRB basic doc

2022-10-20 Thread Rodrigo Siqueira
Add a kernel-doc to the DE-Tile function hook. Reviewed-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- .../gpu/drm/amd/display/dc/dcn32/dcn32_hubbub.c | 4 drivers/gpu/drm/amd/display/dc/inc/hw/dchubbub.h | 15 +++ 2 files changed, 19 i

[PATCH 25/33] drm/amd/display: wait for vblank during pipe programming

2022-10-20 Thread Rodrigo Siqueira
From: Haiyi Zhou [WHY] Skipping vblank during global sync update request can result in underflow on certain displays. [HOW] Roll back to the previous behavior where DC waits for vblank during pipe programming. Fixes: 5d3e14421410 ("drm/amd/display: do not wait for vblank during pipe programmin

[PATCH 26/33] drm/amd/display: skip commit minimal transition state

2022-10-20 Thread Rodrigo Siqueira
From: zhikzhai [WHY] Now dynamic ODM will now be disabled when MPO is required safe transitions to avoid underflow, but we are triggering the way of minimal transition too often. Commit state of dc with no check will do pipeline setup which may re-initialize the component with no need such as aud

[PATCH 28/33] drm/amd/display: Expand kernel doc for DC

2022-10-20 Thread Rodrigo Siqueira
This commit adds extra documentation for elements related to FAMs. Reviewed-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dc.h | 19 +++--- drivers/gpu/drm/amd/display/dc/dc_stream.h| 11 .../gp

[PATCH 30/33] drm/amd/display: Add basic ODM description

2022-10-20 Thread Rodrigo Siqueira
Add kernel-doc to some of the ODM-related functions. Reviewed-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- .../drm/amd/display/dc/dcn20/dcn20_resource.c| 16 .../drm/amd/display/dc/inc/hw/stream_encoder.h | 3 +++ .../drm/amd/displ

[PATCH 23/33] drm/amd/display: cursor update command incomplete

2022-10-20 Thread Rodrigo Siqueira
From: Max Tseng Missing send cursor_rect width & Height into DMUB. PSR-SU would use these information. But missing these assignment in last refactor commit Reviewed-by: Anthony Koo Acked-by: Rodrigo Siqueira Signed-off-by: Max Tseng --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c | 4 +

[PATCH 24/33] drm/amd/display: Fix SDR visual confirm

2022-10-20 Thread Rodrigo Siqueira
From: Aric Cyr Apply SDR visual confirm to RGB10 and FP16 formats as well when needed. Reviewed-by: Jun Lei Acked-by: Rodrigo Siqueira Signed-off-by: Aric Cyr --- .../gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --

[PATCH 22/33] drm/amd/display: Enable timing sync on DCN32

2022-10-20 Thread Rodrigo Siqueira
From: Alvin Lee Missed enabling timing sync on DCN32 because DCN32 has a different DML param. Reviewed-by: Martin Leung Reviewed-by: Jun Lei Acked-by: Rodrigo Siqueira Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH 19/33] drm/amd/display: Set memclk levels to be at least 1 for dcn32

2022-10-20 Thread Rodrigo Siqueira
From: Dillon Varone [Why] Cannot report 0 memclk levels even when SMU does not provide any. [How] When memclk levels reported by SMU is 0, set levels to 1. Reviewed-by: Martin Leung Acked-by: Rodrigo Siqueira Signed-off-by: Dillon Varone --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn3

[PATCH 20/33] drm/amd/display: Remove optimization for VRR updates

2022-10-20 Thread Rodrigo Siqueira
From: Alvin Lee Optimization caused unexpected regression, so remove for now. Reviewed-by: Aric Cyr Acked-by: Rodrigo Siqueira Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/core/dc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c

[PATCH 21/33] drm/amd/display: Fix HDCP 1.X 1A-04 failing

2022-10-20 Thread Rodrigo Siqueira
From: Bhawanpreet Lakha [Why] On some linux based OS, the hotplug->HDCP start takes longer than 4seconds (by ~100ms) This is due to the HDCP delay (3 sec) so we only have 1 second to hotplug->stream enablement, which is not enough for certain OS configs. [How] Change the Delay to 0 seconds. From

[PATCH 03/33] drm/amd/display: refactor enable/disable audio stream hw sequence

2022-10-20 Thread Rodrigo Siqueira
From: Wenjing Liu [why] 1. As recommended by hardware team, don't enable APG when stream is not enabled. 2. Move audio stream encoder programming into link_hwss. [how] 1. Merge dp_audio_enable into enable audio stream hw sequence. 2. Move stream encoder programming into link hwss level to uni

[PATCH 18/33] drm/amd/display: Update latencies on DCN321

2022-10-20 Thread Rodrigo Siqueira
From: Dillon Varone Update DF related latencies based on new measurements. Reviewed-by: Jun Lei Acked-by: Rodrigo Siqueira Signed-off-by: Dillon Varone --- drivers/gpu/drm/amd/display/dc/dml/dcn321/dcn321_fpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dr

[PATCH 13/33] drm/amd/display: Implement secure display on DCN21

2022-10-20 Thread Rodrigo Siqueira
From: Alan Liu [Why] Porting secure display feature from DCN10 to DCN21. Support single display for now and will extend to multiple displays. [How] - use workqueue to offload works for dmub or dmcu firmware - after receiving ROI update from userspace, set skip_frame_cnt to 1 - refactor amdgpu_dm

[PATCH 17/33] drm/amd/display: 3.2.208

2022-10-20 Thread Rodrigo Siqueira
From: Aric Cyr DC version 3.2.208 brings along the following: * Add more kernel doc * Enable secure display on DCN21 * Limit dcn32 to 1950Mhz display clock * PSR code refactor * Rework audio stream sequence * Generic bug fixes Acked-by: Rodrigo Siqueira Signed-off-by: Aric Cyr --- drivers/gp

[PATCH 15/33] drm/amd/display: Limit dcn32 to 1950Mhz display clock

2022-10-20 Thread Rodrigo Siqueira
From: Jun Lei [why] Hardware team recommends we limit dispclock to 1950Mhz for all DCN3.2.x [how] Limit to 1950 when initializing clocks. Reviewed-by: Alvin Lee Acked-by: Rodrigo Siqueira Signed-off-by: Jun Lei --- .../gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 8 1 fi

[PATCH 16/33] drm/amd/display: Document part of the DMUB cmd

2022-10-20 Thread Rodrigo Siqueira
From: Anthony Koo Add a simple documentation in the dmub_cmd. Reviewed-by: Aric Cyr Acked-by: Rodrigo Siqueira Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/

[PATCH 14/33] drm/amd/display: Drop struct crc_region and reuse struct rect

2022-10-20 Thread Rodrigo Siqueira
From: Alan Liu [Why] reuse struct rect rather than adding a new struct. [How] - Userspace keeps inputting x_start, y_start, x_end, y_end - We translate data to x, y, width, height in code flow to store - translate back to x_start, y_start, x_end, y_end before programming HW Reviewed-by: Wayne L

[PATCH 06/33] drm/amd/display: correctly populate dcn315 clock table

2022-10-20 Thread Rodrigo Siqueira
From: Dmytro Laktyushkin Fix incorrect pstate read order as well as min and max state logic. Reviewed-by: Charlene Liu Acked-by: Rodrigo Siqueira Signed-off-by: Dmytro Laktyushkin --- .../dc/clk_mgr/dcn315/dcn315_clk_mgr.c| 71 ++- 1 file changed, 23 insertions(+), 48

[PATCH 10/33] drm/amd/display: refine wake up aux in retrieve link caps

2022-10-20 Thread Rodrigo Siqueira
From: Lewis Huang [Why] Read set_power_state dpcd after HPD cause USB4 CTS 4.2.1.1 [How] Read LTTPR caps first. If aux channel not ready, wake up aux channel. If wake up aux channel return pass, retrieve lttpr caps again. If wake up aux channel return false, register a detection retry timer. Re

[PATCH 09/33] drm/amd/display: Add events log to trace OPTC lock and unlock

2022-10-20 Thread Rodrigo Siqueira
As an attempt to offer more DCN debug tools for cases where the OPTC can hang, this commit introduces a trace event responsible for showing OPTC status when it requests lock and unlock. Reviewed-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- .../amd/display

[PATCH 12/33] drm/amd/display: Ignore Cable ID Feature

2022-10-20 Thread Rodrigo Siqueira
From: Fangzhi Zuo Disable for DP2 receivers that does not support the feature. Reviewed-by: Roman Li Acked-by: Rodrigo Siqueira Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/display/

[PATCH 11/33] drm/amd/display: Update DSC capabilitie for DCN314

2022-10-20 Thread Rodrigo Siqueira
From: Leo Chen dcn314 has 4 DSC - conflicted hardware document updated and confirmed. Reviewed-by: Charlene Liu Acked-by: Rodrigo Siqueira Signed-off-by: Leo Chen --- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 04/33] drm/amd/display: move stream encoder audio setup to link_hwss

2022-10-20 Thread Rodrigo Siqueira
From: Wenjing Liu Unify stream encoder audio setup interface. Reviewed-by: Charlene Liu Acked-by: Rodrigo Siqueira Signed-off-by: Wenjing Liu --- .../display/dc/dce110/dce110_hw_sequencer.c | 22 +-- .../gpu/drm/amd/display/dc/inc/link_hwss.h| 3 +++ .../drm/amd/displa

[PATCH 08/33] drm/amd/display: Convert documentation to a kernel-doc

2022-10-20 Thread Rodrigo Siqueira
The dc_dmub_srv file has a lot of documentation associated with SubVP that could be converted to a kernel-doc. This commit just changes the comment style to a kernel-doc. Reviewed-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc

[PATCH 05/33] drm/amd/display: remove audio mute control in hpo dp

2022-10-20 Thread Rodrigo Siqueira
From: Wenjing Liu VPG doesn't have the ability to mute audio output by sending all 0s in audio SDP. The existing implemention is disabling audio SDP instead. This is same as what dp_audio_enable does. Since it is no longer referenced by any callers, we decided to remove this interface for simplic

[PATCH 07/33] drm/amd/display: Refactor eDP PSR codes

2022-10-20 Thread Rodrigo Siqueira
From: Ian Chen We split out PSR config from "global" to "per-panel" config settings. Reviewed-by: Robin Chen Acked-by: Rodrigo Siqueira Signed-off-by: Ian Chen --- drivers/gpu/drm/amd/display/dc/dc.h | 1 - drivers/gpu/drm/amd/display/dc/dc_link.h | 14 +++---

[PATCH 02/33] drm/amd/display: Remove FPU guards from the DML folder

2022-10-20 Thread Rodrigo Siqueira
As part of the programming expectation for using DML functions, DC requires that any DML function invoked outside DML uses: DC_FP_START(); ... dml function ... DC_FP_END(); Additionally, all the DML functions that can be invoked outside the DML folder call the function dc_assert_fp_enabled(),

[PATCH 01/33] drm/amd/display: Add UHBR135 and UHBR20 into debugfs

2022-10-20 Thread Rodrigo Siqueira
From: Fangzhi Zuo Add support to manually force link rate to UHBR135 (0x546) and UHBR20 (0x7d0). Reviewed-by: Roman Li Acked-by: Rodrigo Siqueira Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dri

[PATCH 00/33] DC Patches October 20th, 2022

2022-10-20 Thread Rodrigo Siqueira
This DC patchset brings improvements in multiple areas. In summary, we have: * Improve color manipulation * Add corrections to DML and some flag configuration * Expand kernel-doc * Enable secure display on DCN21 * PSR code refactor * Rework audio stream sequence Cc: Mark Broadworth Cc: Daniel Wh

Re: [PATCH 1/5] drm/amdgpu: Introduce gfx software ring (v8)

2022-10-20 Thread Christian König
Am 20.10.22 um 16:49 schrieb Michel Dänzer: On 2022-10-18 11:08, jiadong@amd.com wrote: From: "Jiadong.Zhu" The software ring is created to support priority context while there is only one hardware queue for gfx. Every software ring has its fence driver and could be used as an ordinary ri

Re: [PATCH 1/5] drm/amdgpu: Introduce gfx software ring (v8)

2022-10-20 Thread Michel Dänzer
On 2022-10-18 11:08, jiadong@amd.com wrote: > From: "Jiadong.Zhu" > > The software ring is created to support priority context while there is only > one hardware queue for gfx. > > Every software ring has its fence driver and could be used as an ordinary ring > for the GPU scheduler. > Multi

[PATCH] drm/amdgpu: don't call drm_fb_helper_lastclose in lastclose()

2022-10-20 Thread Alex Deucher
It's used to restore the fbdev console, but as amdgpu uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Fixes: 087451f372bf76 ("drm/amdgpu: use generic fb helpers instead of setting up AMD ow

[pull] amdgpu drm-fixes-6.1

2022-10-20 Thread Alex Deucher
Hi Dave, Daniel, An important regression fix for older APUs for 6.1 and stable. The following changes since commit 8273b4048664fff356fd10059033f0e2f5a422a1: drm/amdgpu: Fix for BO move issue (2022-10-18 22:14:07 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/

Re: [PATCH 2/2] drm/amdkfd: update gfx1037 Lx cache setting

2022-10-20 Thread Alex Deucher
Series is: Reviewed-by: Alex Deucher On Thu, Oct 20, 2022 at 5:15 AM Prike Liang wrote: > > Update the gfx1037 L1/L2/L3 cache setting. > > Signed-off-by: Prike Liang > --- > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 53 +++ > 1 file changed, 53 insertions(+) > > diff --gi

[PATCH] drm/amdkfd: use vma_lookup() instead of find_vma()

2022-10-20 Thread Deming Wang
Using vma_lookup() verifies the start address is contained in the found vma. This results in easier to read the code. Signed-off-by: Deming Wang --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amd

Re: [PATCH 03/21] drm/ingenic: Don't set struct drm_driver.lastclose

2022-10-20 Thread Sergey Shtylyov
Hello! On 10/20/22 1:37 PM, Thomas Zimmermann wrote: > Don't set struct drm_mode_config.output_poll_changed. It's used to > inform the fbdev console about conncetor changes. But as ingenic Connector. :-) > uses generic fbdev emulation, the console is being informed by the > DRM client helper

Re: [PATCH -next] drm/amd/display: make dcn32_mpc_funcs static

2022-10-20 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Oct 19, 2022 at 9:28 AM Harry Wentland wrote: > > On 2022-10-19 02:23, ruanjinjie wrote: > > The symbol is not used outside of the file, so mark it static. > > > > Fixes the following warning: > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mpc.c:985:2

Re: [PATCH -next] drm/amd/display: make dcn32_mmhubbub_funcs static

2022-10-20 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Oct 19, 2022 at 9:27 AM Harry Wentland wrote: > > > > On 2022-10-19 02:31, ruanjinjie wrote: > > The symbol is not used outside of the file, so mark it static. > > > > Fixes the following warning: > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mmhubbu

Re: [PATCH -next] drm/amd/display: Make some symbols static

2022-10-20 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Oct 19, 2022 at 3:48 AM ruanjinjie wrote: > > These symbols qp_table_422_10bpc_min, qp_table_444_8bpc_max, > qp_table_420_12bpc_max, qp_table_444_10bpc_min, qp_table_420_8bpc_max, > qp_table_444_8bpc_min, qp_table_444_12bpc_min, qp_table_420_12bpc_min, > qp_table_4

Re: [PATCH] drm/amd/display: Revert logic for plane modifiers

2022-10-20 Thread Rodrigo Siqueira Jordao
On 2022-10-19 11:15, Joaquín Ignacio Aramendía wrote: This file was split in commit 5d945cbcd4b16a29d6470a80dfb19738f9a4319f ("drm/amd/display: Create a file dedicated to planes") the logic in dm_plane_format_mod_supported() function got changed by a switch logic. That change broke drm_plane m

Re: [PATCH 01/21] drm/amdgpu: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Hi Am 20.10.22 um 13:48 schrieb Christian König: Am 20.10.22 um 12:37 schrieb Thomas Zimmermann: Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as amdgpu uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the ca

Re: [PATCH 01/21] drm/amdgpu: Don't set struct drm_driver.lastclose

2022-10-20 Thread Christian König
Am 20.10.22 um 12:37 schrieb Thomas Zimmermann: Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as amdgpu uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose().

[PATCH 18/21] drm/fb_helper: Minimize damage-helper overhead

2022-10-20 Thread Thomas Zimmermann
Pull the test for fb_dirty into the caller to avoid extra work if no callback has been set. In this case no damage handling is required and no damage area needs to be computed. Print a warning if the damage worker runs without getting an fb_dirty callback. Signed-off-by: Thomas Zimmermann --- dr

[PATCH 12/21] drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper

2022-10-20 Thread Thomas Zimmermann
Rename struct drm_fb_helper.fbdev to info. The current name is misleading as it overlaps with generic fbdev naming conventions. Adapt to the usual naming in fbdev drivers by calling the field 'info'. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c

[PATCH 15/21] drm/fb-helper: Disconnect damage worker from update logic

2022-10-20 Thread Thomas Zimmermann
The fbdev helpers implement a damage worker that forwards fbdev updates to the DRM driver. The worker's update logic depends on the generic fbdev emulation. Separate the two via function pointer. The generic fbdev emulation sets struct drm_fb_helper_funcs.fb_dirty, a new callback that hides the up

[PATCH 20/21] drm/fb-helper: Move generic fbdev emulation into separate source file

2022-10-20 Thread Thomas Zimmermann
Move the generic fbdev implementation into its own source and header file. Adapt drivers. No functonal changes, but some of the internal helpers have been renamed to fit into the drm_fbdev_ naming scheme. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Makefile | 2 +-

[PATCH 17/21] drm/fb-helper: Perform all fbdev I/O with the same implementation

2022-10-20 Thread Thomas Zimmermann
Implement the fbdev's read/write helpers with the same functions. Use the generic fbdev's code as template. Convert all drivers. DRM's fb helpers must implement regular I/O functionality in struct fb_ops and possibly perform a damage update. Handle all this in the same functions and convert driver

[PATCH 16/21] drm/fb-helper: Call fb_sync in I/O functions

2022-10-20 Thread Thomas Zimmermann
Call struct fb_ops.fb_sync in drm_fbdev_{read,write}() to mimic the behavior of fbdev. Fbdev implementations of fb_read and fb_write in struct fb_ops invoke fb_sync to synchronize with outstanding operations before I/O. Doing the same in DRM implementations will allow us to use them throughout DRM

[PATCH 21/21] drm/fb-helper: Remove unnecessary include statements

2022-10-20 Thread Thomas Zimmermann
Remove include statements for where it is not required (i.e., most of them). In a few places include other header files that are required by the source code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_display.c

[PATCH 13/21] drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix

2022-10-20 Thread Thomas Zimmermann
Rename drm_fb_helper_alloc_fbi() to drm_fb_helper_alloc_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm/drm_fb_helper.c| 8 ---

[PATCH 19/21] drm/fb-helper: Always initialize generic fbdev emulation

2022-10-20 Thread Thomas Zimmermann
Initialize the generic fbdev emulation even if it has been disabled on the kernel command line. The hotplug and mode initialization will fail accordingly. The kernel parameter can still be changed at runtime and the emulation will initialize after hotplugging the connector. Signed-off-by: Thomas

[PATCH 14/21] drm/fb-helper: Rename drm_fb_helper_unregister_fbi() to use _info postfix

2022-10-20 Thread Thomas Zimmermann
Rename drm_fb_helper_unregister_fbi() to drm_fb_helper_unregister_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm/drm_fb_helper.c|

[PATCH 11/21] drm/fb-helper: Cleanup include statements in header file

2022-10-20 Thread Thomas Zimmermann
Only include what we have to. Signed-off-by: Thomas Zimmermann --- include/drm/drm_fb_helper.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index fddd0d1af6891..e923089522896 100644 --- a/include/drm/drm_fb_he

[PATCH 09/21] drm/panel-ili9341: Include

2022-10-20 Thread Thomas Zimmermann
Include for devm_of_find_backlight(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c index 39dc40cf681f0..b59472c29

[PATCH 08/21] drm/vboxvideo: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as vboxvideo uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers

[PATCH 03/21] drm/ingenic: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_mode_config.output_poll_changed. It's used to inform the fbdev console about conncetor changes. But as ingenic uses generic fbdev emulation, the console is being informed by the DRM client helpers already. See the calls to drm_client_dev_hotplug() in drm_probe_helper.c. Signed

[PATCH 05/21] drm/logicvc: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as logicvc uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/g

[PATCH 00/21] drm/fb-helper: Untangle fbdev emulation and helpers

2022-10-20 Thread Thomas Zimmermann
Separate generic fbdev emulation from the helper code that is shared among the various fbdev implementations within DRM. Affects many drivers. The goal of this patchset is to improve readability and streamline the fbdev helper code within DRM. In the long term, we want to get to a point where driv

[PATCH 06/21] drm/mcde: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as mcde uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/

[PATCH 10/21] drm/tve200: Include

2022-10-20 Thread Thomas Zimmermann
Include for of_match_ptr(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tve200/tve200_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c index 04db72e3fa9c2..611785e097576 100644 --- a/drivers/gpu/drm/tve

[PATCH 07/21] drm/rockchip: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as rockchip uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/

[PATCH 02/21] drm/imx: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as imx uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/d

[PATCH 04/21] drm/komeda: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as komeda uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/gp

[PATCH 01/21] drm/amdgpu: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as amdgpu uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/gp

RE: [PATCH 4/4] drm/amdgpu: remove ras_error_status parameter for UMC poison handler

2022-10-20 Thread Zhang, Hawking
[AMD Official Use Only - General] Might squash this with patch 1 Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Wednesday, October 19, 2022 16:12 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Yang, Stanley ; Chai, Thomas ; Li, Candice Cc: Zhou1, Tao Subject: [PATC

[PATCH 2/2] drm/amdkfd: update gfx1037 Lx cache setting

2022-10-20 Thread Prike Liang
Update the gfx1037 L1/L2/L3 cache setting. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 53 +++ 1 file changed, 53 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c index 960046e43b7a..6e69

[PATCH 1/2] drm/amdkfd: introduce dummy cache info for property asic

2022-10-20 Thread Prike Liang
This dummy cache info will enable kfd base function support. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 55 +-- 1 file changed, 52 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/k

RE: [PATCH 1/4] drm/amdgpu: add RAS page retirement functions for MCA

2022-10-20 Thread Zhang, Hawking
[AMD Official Use Only - General] +static int amdgpu_umc_poison_handler_mca(struct amdgpu_device *adev, + struct ras_err_data *err_data, bool reset) + if (adev->gmc.xgmi.connected_to_cpu) { + ret = amdgpu_umc_poison_handler_mca(adev, ras_error_status, reset);

Re: [PATCH 1/6] drm/ttm: rework on ttm_resource to use size_t type

2022-10-20 Thread kernel test robot
Hi Somalapuram, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip linus/master v6.1-rc1 next-20221020] [If your patch is applied to the wrong git tree, kindly drop us a

RE: [PATCH] drm/amd/pm: allow gfxoff on gc_11_0_3

2022-10-20 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Kenneth Feng Sent: Thursday, October 20, 2022 3:27 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH] drm/amd/pm: allow gfxoff on gc_11_0_3

[PATCH] drm/amd/pm: allow gfxoff on gc_11_0_3

2022-10-20 Thread Kenneth Feng
allow gfxoff on gc_11_0_3 Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 1 + drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c in

Re: [PATCH] drm/amdgpu: skip mes self test for gc 11.0.3 in recover

2022-10-20 Thread Luben Tuikov
Hi YuBiao, Ah, okay, there's a precedent for such a change then. Acked-by: Luben Tuikov Regards, Luben On 2022-10-19 22:44, Wang, YuBiao wrote: > Hi Luben, > >>> Is this "temporary" as in "we'll revert this commit later", or is it >>> "temporary" as in the code execution itself? >>> Is this