Re: [PATCH] drm/dp_mst: clear time slots for ports invalid

2020-01-03 Thread Lyude Paul
On Wed, 2019-12-25 at 06:45 +, Lin, Wayne wrote: > > -Original Message- > > From: Lyude Paul > > Sent: Saturday, December 21, 2019 8:12 AM > > To: Lin, Wayne ; dri-de...@lists.freedesktop.org; > > amd-gfx@lists.freedesktop.org > > Cc: Kazlauskas, Nicholas ; Wentland, Harry > > ; Zuo, J

Re: [PATCH v2] drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ

2020-01-03 Thread Lyude Paul
Oh! Just a friendly tip, I fixed this before pushing your patch: ➜ drm-maint git:(drm-misc-fixes) dim push dim: 0b1d54cedbb4 ("drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ"): Fixes: SHA1 needs at least 12 digits: dim: ad7f8a1f9ce (drm/helper: add Displayport multi-stream helper (v0

Re: [PATCH v2] drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ

2020-01-03 Thread Lyude Paul
Reviewed-by: Lyude Paul Thanks for all of the contributions you've made as of late! I will go ahead and push this into drm-misc-fixes On Fri, 2020-01-03 at 13:50 +0800, Wayne Lin wrote: > [Why] > According to DP spec, it should shift left 4 digits for NO_STOP_BIT > in REMOTE_I2C_READ message. No

Re: [PATCH] drm/dp_mst: Avoid NULL pointer dereference

2020-01-03 Thread Lyude Paul
Back from the holidays! Reviewed-by: Lyude Paul Do you need me to push this to drm-misc? On Thu, 2019-12-26 at 10:31 +0800, Wayne Lin wrote: > [Why] > Found kernel NULL pointer dereference under the below situation: > > src — HDMI_Monitor src — HDMI_Monitor > e.g.: \=>

[PATCH] drm/radeon: remove unnecessary braces around conditionals.

2020-01-03 Thread Wambui Karuga
As single statement conditionals do not need to be wrapped around braces, the unnecessary braces can be removed. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/radeon/atombios_crtc.c | 3 +-- drivers/gpu/drm/radeon/atombios_dp.c | 3 +-- drivers/gpu/drm/radeon/atombios_encoders.c |

Re: AMDGPU crash on 5.4.7 on AMD Athlon 3000G APU

2020-01-03 Thread A L
On 2020-01-02 21:54, A L wrote: Dear all, There seems to be a regression between kernel 5.4.6 and 5.4.7. When I change from kernel 5.4.6 to kernel 5.4.7 I can no longer load the AMDGPU driver. The kernel immediately crashes with the following stack trace and errors. The system has to be hard

[PATCH] drm/amd: use list_for_each_entry for list iteration.

2020-01-03 Thread Wambui Karuga
list_for_each() can be replaced by the more concise list_for_each_entry() here for iteration over the lists. This change was reported by coccinelle. Signed-off-by: Wambui Karuga --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 19 --- 1 file changed, 4 insertions(+), 15 deleti

[PATCH] drm/radeon: remove boolean checks in if statements.

2020-01-03 Thread Wambui Karuga
Remove unnecessary variable comparisions to true/false in if statements and check the value of the variable directly. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/radeon/cik_sdma.c | 2 +- drivers/gpu/drm/radeon/r100.c | 2 +- drivers/gpu/drm/radeon/r600.c

Re: [PATCH v2] drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ

2020-01-03 Thread Harry Wentland
On 2020-01-03 12:50 a.m., Wayne Lin wrote: > [Why] > According to DP spec, it should shift left 4 digits for NO_STOP_BIT > in REMOTE_I2C_READ message. Not 5 digits. > > In current code, NO_STOP_BIT is always set to zero which means I2C > master is always generating a I2C stop at the end of each I2

Re: [PATCH 1/1] drm/amdgpu: fix ctx init failure for asics without gfx ring

2020-01-03 Thread Nirmoy
On 1/2/20 7:13 PM, Christian König wrote: Am 02.01.20 um 10:47 schrieb Nirmoy: On 1/1/20 1:52 PM, Christian König wrote: Am 19.12.19 um 13:01 schrieb Nirmoy: Reviewed-by: Nirmoy Das On 12/19/19 12:42 PM, Le Ma wrote: This workaround does not affect other asics because amdgpu only need exp

RE: [PATCH 5/5] drm/amd/amdgpu: L1 Policy(5/5) - removed IH_CHICKEN from VF

2020-01-03 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] Series are Reviewed-by: Emily Deng >-Original Message- >From: Jane Jian >Sent: Friday, January 3, 2020 5:57 PM >To: amd-gfx@lists.freedesktop.org; Deng, Emily ; Liu, Leo > >Cc: Jian,JaneQiang) ; Luo, Zhigang >; Jian,JaneQiang) >Subje

[PATCH 5/5] drm/amd/amdgpu: L1 Policy(5/5) - removed IH_CHICKEN from VF

2020-01-03 Thread Jane Jian
From: Zhigang Luo Signed-off-by: Zhigang Luo Signed-off-by: Jane Jian --- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c index 5

[PATCH 4/5] drm/amd/amdgpu: L1 Policy(4/5) - removed SPI_GDBG_TRAP_CONFIG from VF

2020-01-03 Thread Jane Jian
From: Zhigang Luo Signed-off-by: Zhigang Luo Signed-off-by: Jane Jian --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index 35384f543664..bf02ca198283 100

[PATCH 3/5] drm/amd/amdgpu: L1 Policy(3/5) - removed ECC interrupt from VF

2020-01-03 Thread Jane Jian
From: Zhigang Luo Signed-off-by: Zhigang Luo Signed-off-by: Jane Jian --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index 2f4a013b3

[PATCH 2/5] drm/amd/amdgpu: L1 Policy(2/5) - removed GC GRBM violations from gfxhub

2020-01-03 Thread Jane Jian
From: Zhigang Luo Signed-off-by: Zhigang Luo Signed-off-by: Jane Jian --- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 79 +--- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c| 2 +- 2 files changed, 44 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfxhub

[PATCH 1/5] drm/amd/amdgpu: L1 Policy(1/5) - removed VM settgings for mmhub and gfxhub from VF

2020-01-03 Thread Jane Jian
From: Zhigang Luo Signed-off-by: Zhigang Luo Signed-off-by: Jane Jian --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 11 ++-- drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 74 ++--- 2 files changed, 48 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v

[PATCH] drm/amd/powerplay: refine code to support no-dpm case

2020-01-03 Thread Evan Quan
With "dpm=0", there will be no DPM enabled. The code needs to be refined to support this. Change-Id: Ief1561e69a24472135e0499073a27ea5fd8174e2 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 5 - drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 6 ++ drivers

[PATCH 5/5] drm/amd/amdgpu: L1 Policy(5/5) - removed IH_CHICKEN from VF

2020-01-03 Thread Jane Jian
From: Zhigang Luo Signed-off-by: Zhigang Luo Signed-off-by: Jane Jian --- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c index 5

[PATCH 4/5] drm/amd/amdgpu: L1 Policy(4/5) - removed SPI_GDBG_TRAP_CONFIG from VF

2020-01-03 Thread Jane Jian
From: Zhigang Luo Signed-off-by: Zhigang Luo Signed-off-by: Jane Jian --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index 35384f543664..bf02ca198283 100

[PATCH 1/5] drm/amd/amdgpu: L1 Policy(1/5) - removed VM settgings for mmhub and gfxhub from VF

2020-01-03 Thread Jane Jian
From: Zhigang Luo Signed-off-by: Zhigang Luo Signed-off-by: Jane Jian --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 11 ++-- drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 74 ++--- 2 files changed, 48 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v

[PATCH 2/5] drm/amd/amdgpu: L1 Policy(2/5) - removed GC GRBM violations from gfxhub

2020-01-03 Thread Jane Jian
From: Zhigang Luo Signed-off-by: Zhigang Luo Signed-off-by: Jane Jian --- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 79 +--- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c| 2 +- 2 files changed, 44 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfxhub

[PATCH 3/5] drm/amd/amdgpu: L1 Policy(3/5) - removed ECC interrupt from VF

2020-01-03 Thread Jane Jian
From: Zhigang Luo Signed-off-by: Zhigang Luo Signed-off-by: Jane Jian --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index 2f4a013b3

[PATCH] drm/amd/powerplay: issue proper hdp flush for table transferring

2020-01-03 Thread Evan Quan
Guard the content consistence between the view of GPU and CPU during the table transferring. Change-Id: Ib3cebb97a1c8fb302eb040483bbaf089ae00c6a9 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 15 ++- .../gpu/drm/amd/powerplay/smumgr/smu10_smumgr.c

[PATCH] drm/amd/powerplay: cleanup the interfaces for powergate setting through SMU

2020-01-03 Thread Evan Quan
Provided an unified entry point. And fixed the confusing that the API usage is conflict with what the naming implies. Change-Id: If068980ca6a7b223d0b4d087cd99cdeb729b0e77 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c| 23 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_

RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability

2020-01-03 Thread Clements, John
[AMD Public Use] Good catch, I'll update my habit with this From: Chen, Guchun Sent: Friday, January 3, 2020 4:33 PM To: Clements, John ; Zhang, Hawking ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability [AMD Public Use] Thanks Joh

RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability

2020-01-03 Thread Chen, Guchun
[AMD Public Use] Thanks John. +for (retry_loop = 0; retry_loop < 10; retry_loop++) +{ The same coding style problem that "{" should not start at one new line. With this fixed, the patch is: Reviewed-by: Guchun Chen Regards, Guchun From: Clements, John Sent: Friday, Ja

RE: [PATCH] drm/amdgpu: removed GFX RAS support check in UMC ECC callback

2020-01-03 Thread Zhang, Hawking
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking From: Clements, John Sent: Friday, January 3, 2020 15:31 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking Subject: [PATCH] drm/amdgpu: removed GFX RAS support check in UMC ECC callback [AMD Offi

RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability

2020-01-03 Thread Clements, John
[AMD Official Use Only - Internal Distribution Only] Hello GuChun, I have updated the patch with your suggestion, and added back in the delay. I can potentially investigate its removal in another patch Thank you, John Clements From: Chen, Guchun Sent: Friday, January 3, 2020 3:44 PM To: Cleme