[AMD Public Use]
Thanks John.
+ for (retry_loop = 0; retry_loop < 10; retry_loop++)
+ {
The same coding style problem that "{" should not start at one new line. With
this fixed, the patch is:
Reviewed-by: Guchun Chen <guchun.c...@amd.com>
Regards,
Guchun
From: Clements, John <john.cleme...@amd.com>
Sent: Friday, January 3, 2020 4:13 PM
To: Chen, Guchun <guchun.c...@amd.com>; Zhang, Hawking <hawking.zh...@amd.com>;
amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability
[AMD Official Use Only - Internal Distribution Only]
Hello GuChun,
I have updated the patch with your suggestion, and added back in the delay.
I can potentially investigate its removal in another patch
Thank you,
John Clements
From: Chen, Guchun <guchun.c...@amd.com<mailto:guchun.c...@amd.com>>
Sent: Friday, January 3, 2020 3:44 PM
To: Clements, John <john.cleme...@amd.com<mailto:john.cleme...@amd.com>>;
Zhang, Hawking <hawking.zh...@amd.com<mailto:hawking.zh...@amd.com>>;
amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability
[AMD Official Use Only - Internal Distribution Only]
- /* there might be handshake issue with hardware which needs delay
*/
- mdelay(20);
To be safety, I don't think we should remove this delay. And this actually do
nothing with the code refine in this patch.
Regards,
Guchun
From: amd-gfx
<amd-gfx-boun...@lists.freedesktop.org<mailto:amd-gfx-boun...@lists.freedesktop.org>>
On Behalf Of Clements, John
Sent: Friday, January 3, 2020 3:29 PM
To: Zhang, Hawking <hawking.zh...@amd.com<mailto:hawking.zh...@amd.com>>;
amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: [PATCH] drm/amdgpu: added function to wait for PSP BL availability
[AMD Official Use Only - Internal Distribution Only]
Added dedicated function to wait for PSP BL availability.
Increased driver wait time for PSP BL availability.
Thank you,
John Clements
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
