[PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-08-28 Thread Kenny Ho
drm.lgpu A read-write nested-keyed file which exists on all cgroups. Each entry is keyed by the DRM device's major:minor. lgpu stands for logical GPU, it is an abstraction used to subdivide a physical DRM device for the purpose of resource management.

[PATCH RFC v4 11/16] drm, cgroup: Add per cgroup bw measure and control

2019-08-28 Thread Kenny Ho
The bandwidth is measured by keeping track of the amount of bytes moved by ttm within a time period. We defined two type of bandwidth: burst and average. Average bandwidth is calculated by dividing the total amount of bytes moved within a cgroup by the lifetime of the cgroup. Burst bandwidth is s

[PATCH RFC v4 09/16] drm, cgroup: Add TTM buffer allocation stats

2019-08-28 Thread Kenny Ho
The drm resource being measured is the TTM (Translation Table Manager) buffers. TTM manages different types of memory that a GPU might access. These memory types include dedicated Video RAM (VRAM) and host/system memory accessible through IOMMU (GART/GTT). TTM is currently used by multiple drm dr

[PATCH RFC v4 05/16] drm, cgroup: Add peak GEM buffer allocation stats

2019-08-28 Thread Kenny Ho
drm.buffer.peak.stats A read-only flat-keyed file which exists on all cgroups. Each entry is keyed by the drm device's major:minor. Largest (high water mark) GEM buffer allocated in bytes. Change-Id: I79e56222151a3d33a76a61ba0097fe93ebb3449f Signed-off-by: Kenny Ho ---

[PATCH RFC v4 15/16] drm, cgroup: add update trigger after limit change

2019-08-28 Thread Kenny Ho
Before this commit, drmcg limits are updated but enforcement is delayed until the next time the driver check against the new limit. While this is sufficient for certain resources, a more proactive enforcement may be needed for other resources. Introducing an optional drmcg_limit_updated callback

[PATCH RFC v4 08/16] drm, cgroup: Add peak GEM buffer allocation limit

2019-08-28 Thread Kenny Ho
drm.buffer.peak.default A read-only flat-keyed file which exists on the root cgroup. Each entry is keyed by the drm device's major:minor. Default limits on the largest GEM buffer allocation in bytes. drm.buffer.peak.max A read-write flat-keyed file which exists on

[PATCH RFC v4 04/16] drm, cgroup: Add total GEM buffer allocation stats

2019-08-28 Thread Kenny Ho
The drm resource being measured here is the GEM buffer objects. User applications allocate and free these buffers. In addition, a process can allocate a buffer and share it with another process. The consumer of a shared buffer can also outlive the allocator of the buffer. For the purpose of cgr

[PATCH RFC v4 06/16] drm, cgroup: Add GEM buffer allocation count stats

2019-08-28 Thread Kenny Ho
drm.buffer.count.stats A read-only flat-keyed file which exists on all cgroups. Each entry is keyed by the drm device's major:minor. Total number of GEM buffer allocated. Change-Id: Id3e1809d5fee8562e47a7d2b961688956d844ec6 Signed-off-by: Kenny Ho --- Documentation/admi

[PATCH RFC v4 12/16] drm, cgroup: Add soft VRAM limit

2019-08-28 Thread Kenny Ho
The drm resource being limited is the TTM (Translation Table Manager) buffers. TTM manages different types of memory that a GPU might access. These memory types include dedicated Video RAM (VRAM) and host/system memory accessible through IOMMU (GART/GTT). TTM is currently used by multiple drm dri

[PATCH RFC v4 16/16] drm/amdgpu: Integrate with DRM cgroup

2019-08-28 Thread Kenny Ho
The number of logical gpu (lgpu) is defined to be the number of compute unit (CU) for a device. The lgpu allocation limit only applies to compute workload for the moment (enforced via kfd queue creation.) Any cu_mask update is validated against the availability of the compute unit as defined by t

[PATCH RFC v4 03/16] drm, cgroup: Initialize drmcg properties

2019-08-28 Thread Kenny Ho
drmcg initialization involves allocating a per cgroup, per device data structure and setting the defaults. There are two entry points for drmcg init: 1) When struct drmcg is created via css_alloc, initialization is done for each device 2) When DRM devices are created after drmcgs are created a

[PATCH RFC v4 13/16] drm, cgroup: Allow more aggressive memory reclaim

2019-08-28 Thread Kenny Ho
Allow DRM TTM memory manager to register a work_struct, such that, when a drmcgrp is under memory pressure, memory reclaiming can be triggered immediately. Change-Id: I25ac04e2db9c19ff12652b88ebff18b44b2706d8 Signed-off-by: Kenny Ho --- drivers/gpu/drm/ttm/ttm_bo.c| 49 ++

[PATCH RFC v4 00/16] new cgroup controller for gpu/drm subsystem

2019-08-28 Thread Kenny Ho
This is a follow up to the RFC I made previously to introduce a cgroup controller for the GPU/DRM subsystem [v1,v2,v3]. The goal is to be able to provide resource management to GPU resources using things like container. With this RFC v4, I am hoping to have some consensus on a merge plan. I be

[PATCH RFC v4 01/16] drm: Add drm_minor_for_each

2019-08-28 Thread Kenny Ho
To allow other subsystems to iterate through all stored DRM minors and act upon them. Also exposes drm_minor_acquire and drm_minor_release for other subsystem to handle drm_minor. DRM cgroup controller is the initial consumer of this new features. Change-Id: I7c4b67ce6b31f06d1037b03435386ff5b814

[PATCH RFC v4 07/16] drm, cgroup: Add total GEM buffer allocation limit

2019-08-28 Thread Kenny Ho
The drm resource being limited here is the GEM buffer objects. User applications allocate and free these buffers. In addition, a process can allocate a buffer and share it with another process. The consumer of a shared buffer can also outlive the allocator of the buffer. For the purpose of cgro

[PATCH RFC v4 02/16] cgroup: Introduce cgroup for drm subsystem

2019-08-28 Thread Kenny Ho
With the increased importance of machine learning, data science and other cloud-based applications, GPUs are already in production use in data centers today. Existing GPU resource management is very coarse grain, however, as sysadmins are only able to distribute workload on a per-GPU basis. An al

[PATCH RFC v4 10/16] drm, cgroup: Add TTM buffer peak usage stats

2019-08-28 Thread Kenny Ho
drm.memory.peak.stats A read-only nested-keyed file which exists on all cgroups. Each entry is keyed by the drm device's major:minor. The following nested keys are defined. == == system Pea

Re: [PATCH v2] drm/amdgpu: Default disable GDS for compute+gfx

2019-08-28 Thread zhoucm1
On 2019/8/29 上午1:08, Marek Olšák wrote: It can't break an older driver, because there is no older driver that requires the static allocation. Note that closed source drivers don't count, because they don't need backward compatibility. Yes, I agree, we don't need take care of closed source s

RE: [PATCH 6/7] drm/amdgpu: add ras_late_init callback function for nbio v7_4

2019-08-28 Thread Zhang, Hawking
RE - [Tao] The ras block name is AMDGPU_RAS_BLOCK_PCIE_BIF and its string name is pcie_bif in ras_block_string, QA may be confused in the future. I have no strong opinion on the naming. but it's good to align with the block string to avoid confusing. Will update in v2. Regards, Hawking -Ori

RE: [PATCH 7/7] drm/amdgpu: switch to ras_late_init callback for nbio v7_4

2019-08-28 Thread Zhang, Hawking
Good catch. Will update it in v2. Regards, Hawking -Original Message- From: Chen, Guchun Sent: 2019年8月29日 9:25 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Deucher, Alexander Cc: Zhang, Hawking Subject: RE: [PATCH 7/7] drm/amdgpu: switch to ras_late_init callback

RE: [PATCH 1/7] drm/amdgpu: add helper function to do common ras_late_init

2019-08-28 Thread Zhang, Hawking
Good point, I think we can check ih_info.cb, instead of ras_block, as the check condition. On the other hand, I initialized the header in ih_info in case someone use it in somewhere... Regards, Hawking -Original Message- From: Zhou1, Tao Sent: 2019年8月29日 11:52 To: Zhou1, Tao ; Zhang, H

Re: [PATCH 14/17] drm/amd/display: Isolate DSC module from driver dependencies

2019-08-28 Thread Dave Airlie
On Thu, 29 Aug 2019 at 07:04, Bhawanpreet Lakha wrote: > > From: Bayan Zabihiyan > > [Why] > Edid Utility wishes to include DSC module from driver instead > of doing it's own logic which will need to be updated every time > someone modifies the driver logic. > > [How] > Modify some functions such

RE: [PATCH 5/7] drm/amdgpu: add mmhub ras_late_init callback function

2019-08-28 Thread Zhou1, Tao
Can we also add a ras_late_init for umc? > -Original Message- > From: amd-gfx On Behalf Of > Zhou1, Tao > Sent: 2019年8月29日 11:41 > To: Zhang, Hawking ; amd- > g...@lists.freedesktop.org; Deucher, Alexander > > Cc: Zhang, Hawking > Subject: RE: [PATCH 5/7] drm/amdgpu: add mmhub ras_late_

RE: [PATCH 1/7] drm/amdgpu: add helper function to do common ras_late_init

2019-08-28 Thread Zhou1, Tao
Another way is to add check for ih_info in amdgpu_ras_interrupt_add_handler and amdgpu_ras_interrupt_remove_handler directly. > -Original Message- > From: amd-gfx On Behalf Of > Zhou1, Tao > Sent: 2019年8月29日 10:59 > To: Zhang, Hawking ; amd- > g...@lists.freedesktop.org; Deucher, Alexand

RE: [PATCH 6/7] drm/amdgpu: add ras_late_init callback function for nbio v7_4

2019-08-28 Thread Zhou1, Tao
> -Original Message- > From: Hawking Zhang > Sent: 2019年8月28日 21:03 > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; > Deucher, Alexander > Cc: Zhang, Hawking > Subject: [PATCH 6/7] drm/amdgpu: add ras_late_init callback function for > nbio v7_4 > > ras_late_init callback function wi

RE: [PATCH 5/7] drm/amdgpu: add mmhub ras_late_init callback function

2019-08-28 Thread Zhou1, Tao
> -Original Message- > From: Hawking Zhang > Sent: 2019年8月28日 21:03 > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; > Deucher, Alexander > Cc: Zhang, Hawking > Subject: [PATCH 5/7] drm/amdgpu: add mmhub ras_late_init callback > function > > The function will be called in late init p

RE: [PATCH 2/7] drm/amdgpu: switch to amdgpu_ras_late_init for gfx v9 block

2019-08-28 Thread Zhou1, Tao
> -Original Message- > From: amd-gfx On Behalf Of > Hawking Zhang > Sent: 2019年8月28日 21:03 > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; > Deucher, Alexander > Cc: Zhang, Hawking > Subject: [PATCH 2/7] drm/amdgpu: switch to amdgpu_ras_late_init for gfx v9 > block > > call helper f

Re: [PATCH][drm-next] drm/amdgpu: fix spelling mistake "jumpimng" -> "jumping"

2019-08-28 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Aug 28, 2019 at 8:52 PM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in a DRM_DEBUG_DRIVER debug message. > Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 2 +- > 1 file changed, 1

Re: [PATCH 1/2] drm/amdgpu/psp: keep TMR in visible vram region for SRIOV

2019-08-28 Thread Yin, Tianci (Rico)
Hi Christian, Thank you very much for your suggestions! A little more improvement have made about the patch1, please review again. BTW, any suggestion about the patch2? Rico From: Christian König Sent: Wednesday, August 28, 2019 21:09 To: Yin, Tianci (Rico) ; a

[PATCH 2/2] drm/amdgpu: keep the stolen memory in visible vram region

2019-08-28 Thread Tianci Yin
From: "Tianci.Yin" stolen memory should be fixed in visible region. Change-Id: Icbbbd39fd113e93423aad8d2555f4073c08020e5 Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 -- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 ++- 2 files changed, 6 insertions(+), 3 deleti

[PATCH 1/2] drm/amdgpu/psp: keep TMR in visible vram region for SRIOV

2019-08-28 Thread Tianci Yin
From: "Tianci.Yin" Fix compute ring test failure in sriov scenario. Change-Id: I141d3d094e2cba9bcf2f6c96f4d8c4ef43c421c3 Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/

RE: [PATCH 1/7] drm/amdgpu: add helper function to do common ras_late_init

2019-08-28 Thread Zhou1, Tao
> -Original Message- > From: Hawking Zhang > Sent: 2019年8月28日 21:03 > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; > Deucher, Alexander > Cc: Zhang, Hawking > Subject: [PATCH 1/7] drm/amdgpu: add helper function to do common > ras_late_init > > In late_init for ras, the helper func

[pull] amdgpu drm-fixes-5.3

2019-08-28 Thread Alex Deucher
Hi Dave, Daniel, A few fixes for 5.3. Nothing too major. The following changes since commit 7837951a12fdaf88d2c51ff0757980c00072790c: drm/mediatek: include dma-mapping header (2019-08-24 15:09:20 +1000) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags

Re: [PATCH] drm/amdgpu/virtual_dce: drop error message in hw_init

2019-08-28 Thread Yuan, Xiaojie
Reviewed-by: Xiaojie Yuan BR, Xiaojie > On Aug 28, 2019, at 9:56 PM, Alex Deucher wrote: > > No need to add new asic cases. This is a sw display > implementation, so just drop the error message so when > we add new asics, all we have to do is add the virtual > dce IP module. > > Signed-off-b

RE: [PATCH 7/7] drm/amdgpu: switch to ras_late_init callback for nbio v7_4

2019-08-28 Thread Chen, Guchun
Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Hawking Zhang Sent: Wednesday, August 28, 2019 9:03 PM To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Deucher, Alexander Cc: Zhang, Hawking Subject: [PATCH 7/7] drm/amdgpu: switch to ras_late_init callback for nbio v7_4 i

[PATCH][drm-next] drm/amdgpu: fix spelling mistake "jumpimng" -> "jumping"

2019-08-28 Thread Colin King
From: Colin Ian King There is a spelling mistake in a DRM_DEBUG_DRIVER debug message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c b/d

Re: [PATCH 1/2] dmr/amdgpu: Avoid HW GPU reset for RAS.

2019-08-28 Thread Grodzovsky, Andrey
On 8/28/19 5:18 PM, Kuehling, Felix wrote: > On 2019-08-28 4:00 p.m., Andrey Grodzovsky wrote: >> Problem: >> Under certain conditions, when some IP bocks take a RAS error, >> we can get into a situation where a GPU reset is not possible >> due to issues in RAS in SMU/PSP. >> >> Temporary fix unti

Re: [PATCH 1/2] dmr/amdgpu: Avoid HW GPU reset for RAS.

2019-08-28 Thread Kuehling, Felix
On 2019-08-28 4:00 p.m., Andrey Grodzovsky wrote: > Problem: > Under certain conditions, when some IP bocks take a RAS error, > we can get into a situation where a GPU reset is not possible > due to issues in RAS in SMU/PSP. > > Temporary fix until proper solution in PSP/SMU is ready: > When uncor

[PATCH 15/17] drm/amd/display: dce11.x /dce12 update formula input

2019-08-28 Thread Bhawanpreet Lakha
From: Charlene Liu [Description] 1. OUTSTANDING_REQUEST_LIMIT update from 0xFF to 0x1F (HW doc update) 2. using memory type to convert UMC's MCLK to Yclk. Signed-off-by: Charlene Liu Reviewed-by: Dmytro Laktyushkin Acked-by: Bhawanpreet Lakha --- .../display/dc/clk_mgr/dce110/dce110_clk_mgr.

[PATCH 05/17] drm/amd/display: Add back support for DSC 4:2:2 Simple

2019-08-28 Thread Bhawanpreet Lakha
From: Nikola Cornij [why] The requirement has been clarified and only DSC 4:2:2 Native has to be disabled. Signed-off-by: Nikola Cornij Reviewed-by: Wenjing Liu Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 07/17] drm/amd/display: 3.2.49

2019-08-28 Thread Bhawanpreet Lakha
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 3d32e9

[PATCH 12/17] drm/amd/display: remove hw access from dc_destroy

2019-08-28 Thread Bhawanpreet Lakha
From: Jun Lei [why] dc_destroy should only clean up SW, this is because GPUs may be removed before driver unload, leading to HW to be unavailable. [how] remove GPIO close as part of GPIO destroy, this is unnecessary because GPIO is not shared, and GPIOs are generally closed after being opened A

[PATCH 16/17] drm/amd/display: verify stream link before link test

2019-08-28 Thread Bhawanpreet Lakha
From: Jing Zhou [Why] DP1.2 LL CTS test failure. [How] The failure is caused by not verify stream link is equal to link, only check stream and link is not null. Signed-off-by: Jing Zhou Reviewed-by: Wenjing Liu Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/core/dc_link_hwss

[PATCH 03/17] drm/amd/display: Subsample mode suboptimal for YCbCr4:2:2

2019-08-28 Thread Bhawanpreet Lakha
From: Krunoslav Kovac [Why&How] Driver defaults to 1-tap subsample mode for 4:2:2. DCE11.2 added 3-tap. The policy is: DCE8-DCE11 - change to 2-tap, it's better than 1-tap. DCE11.2+ - use 3-tap Note that 4:2:0 was added in DCE11.2 and already uses 3-tap always. Note 2 is that DCE not covered on

[PATCH 02/17] drm/amd/display: refine i2c over aux

2019-08-28 Thread Bhawanpreet Lakha
From: Lewis Huang [Why] When user mode use i2c over aux through ADL or DDI, the function dal_ddc_service_query_ddc_data will be called. There are two issues. 1. When read/write length > 16byte, current always return false because the DEFAULT_AUX_MAX_DATA_SIZE != length. 2. When usermode only nee

[PATCH 13/17] drm/amd/display: OTC underflow fix

2019-08-28 Thread Bhawanpreet Lakha
From: Jaehyun Chung [Why] Underflow occurs on some display setups(repro'd on 3x4K HDR) on boot, mode set, and hot-plugs with. Underflow occurs because mem clk is not set high after disabling pstate switching. This behaviour occurs because some calculations assumed displays were synchronized. [Ho

[PATCH 10/17] drm/amd/display: remove temporary transition code

2019-08-28 Thread Bhawanpreet Lakha
From: Dmytro Laktyushkin Remove code used to allow compilation error free interface change. Signed-off-by: Dmytro Laktyushkin Reviewed-by: Charlene Liu Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 29 1 file changed, 29 deletions(-) dif

[PATCH 14/17] drm/amd/display: Isolate DSC module from driver dependencies

2019-08-28 Thread Bhawanpreet Lakha
From: Bayan Zabihiyan [Why] Edid Utility wishes to include DSC module from driver instead of doing it's own logic which will need to be updated every time someone modifies the driver logic. [How] Modify some functions such that we dont need to pass the entire DC structure as parameter. -Remove D

[PATCH 17/17] drm/amd/display: replace FIXME with TODO

2019-08-28 Thread Bhawanpreet Lakha
From: Qingqing Zhuo Signed-off-by: Qingqing Zhuo Reviewed-by: Charlene Liu Acked-by: Bhawanpreet Lakha --- .../amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c | 8 .../display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c| 8 .../drm/amd/display/dc/dml/dml1_display_rq_dlg

[PATCH 09/17] drm/amd/display: update navi to use new surface programming behaviour

2019-08-28 Thread Bhawanpreet Lakha
From: Dmytro Laktyushkin New behaviour will track global updates and update any hw that isn't related to current stream being updated. This should fix any issues caused by pipe split pipes being taken by other streams. Signed-off-by: Dmytro Laktyushkin Reviewed-by: Charlene Liu Acked-by: Bhaw

[PATCH 06/17] drm/amd/display: config to override DSC start slice height

2019-08-28 Thread Bhawanpreet Lakha
From: Nikola Cornij [why] It's sometimes useful to have this option when debugging [how] Add a config flag. If the flag is not set, use driver default policy. If the flag is set, use the value from the flag as the starting DSC slice height. Signed-off-by: Nikola Cornij Reviewed-by: Martin Leun

[PATCH 08/17] drm/amd/display: Add missing surface address registers

2019-08-28 Thread Bhawanpreet Lakha
From: Ilya Bakoulin [Why] - Need to add missing surface address register definitions. - RGBE+A does not work in a stereo configuration because surface addresses are no programmed correctly. [How] Added the register definitions and surface address programming. Signed-off-by: Ilya Bakoulin Rev

[PATCH 11/17] drm/amd/display: Reuse dcn2 registers

2019-08-28 Thread Bhawanpreet Lakha
From: Vitaly Prosyak [Why & How] Use dcn2 blender, shaper, 3dlut registers Signed-off-by: Vitaly Prosyak Reviewed-by: Charlene Liu Acked-by: Bhawanpreet Lakha Acked-by: Vitaly Prosyak --- .../gpu/drm/amd/display/dc/dcn20/dcn20_dpp.h | 84 +++ .../drm/amd/display/dc/dcn20/dc

[PATCH 00/17] DC Patches 28 Aug 2019

2019-08-28 Thread Bhawanpreet Lakha
Summary Of Changes *add surface registers *underflow fixes *i2c/aux refactors *DSC fixes Alvin Lee (1): drm/amd/display: Don't allocate payloads if link lost Anthony Koo (1): drm/amd/display: 3.2.49 Bayan Zabihiyan (1): drm/amd/display: Isolate DSC module from driver dependencies Charlene

[PATCH 04/17] drm/amd/display: Don't allocate payloads if link lost

2019-08-28 Thread Bhawanpreet Lakha
From: Alvin Lee We should not allocate payloads if the link is lost until the link is retrained. Some displays require this. Signed-off-by: Alvin Lee Reviewed-by: Wenjing Liu Acked-by: Bhawanpreet Lakha --- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 10 +- drivers/gpu/drm/amd/

[PATCH 01/17] drm/amd/display: Fix DML tests

2019-08-28 Thread Bhawanpreet Lakha
From: Ilya Bakoulin [Why] DML diags tests are failing because the struct contents get clobbered by a memcpy. [How] Remove the memcpy call. Signed-off-by: Ilya Bakoulin Reviewed-by: Dmytro Laktyushkin Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 1 -

Re: [PATCH] drm/amdgpu/si: fix ASIC tests

2019-08-28 Thread Alex Deucher
On Wed, Aug 28, 2019 at 11:28 AM Jean Delvare wrote: > > Comparing adev->family with CHIP constants is not correct. > adev->family can only be compared with AMDGPU_FAMILY constants and > adev->asic_type is the struct member to compare with CHIP constants. > They are separate identification spaces.

Re: [PATCH] drm/amd/amdgpu: hide voltage and power sensors on SI and KV parts

2019-08-28 Thread Alex Deucher
On Wed, Aug 28, 2019 at 4:32 AM Jean Delvare wrote: > > The driver does not support these sensors yet and there is no point in > creating sysfs attributes which will always return an error. > > Signed-off-by: Jean Delvare > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David (ChunMing) Zhou"

[PATCH 2/2] dmr/amdgpu: Add system auto reboot to RAS.

2019-08-28 Thread Andrey Grodzovsky
In case of RAS error allow user configure auto system reboot through ras_ctrl. This is also part of the temproray work around for the RAS hang problem. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 18 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

[PATCH 1/2] dmr/amdgpu: Avoid HW GPU reset for RAS.

2019-08-28 Thread Andrey Grodzovsky
Problem: Under certain conditions, when some IP bocks take a RAS error, we can get into a situation where a GPU reset is not possible due to issues in RAS in SMU/PSP. Temporary fix until proper solution in PSP/SMU is ready: When uncorrectable error happens the DF will unconditionally broadcast err

Re: [PATCH V2] drm: Add LTTPR defines for DP 1.4a

2019-08-28 Thread Siqueira, Rodrigo
On 08/27, Jani Nikula wrote: > On Mon, 26 Aug 2019, "Siqueira, Rodrigo" wrote: > > DP 1.4a specification defines Link Training Tunable PHY Repeater (LTTPR) > > which is required to add support for systems with Thunderbolt or other > > repeater devices. > > > > Changes since V1: > > - Adjusts regis

[PATCH 16/23] drm/amd/display: call update_bw_bounding_box

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha call update_bw_bounding_box in DC construct Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/core/dc.c| 5 + drivers/gpu/drm/amd/display/dc/inc/core_types.h | 5 + 2 files changed, 10 insertions(+) diff --

[PATCH 22/23] drm/amd/display: Add DCN2.1 changes to DML

2019-08-28 Thread Alex Deucher
From: Roman Li Hook up the DML changes for renoir. Signed-off-by: Roman Li Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dml/Makefile | 4 .../drm/amd/display/dc/dml/display_mode_lib.c | 19 +++ 2 files changed, 23 insertions(+) diff --git a/drivers/g

[PATCH 18/23] drm/amd/display: add dcn21 core DC changes

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha Add missing parameters, to make dcn21 compile without errors Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dc.h | 3 +++ drivers/gpu/drm/amd/display/dc/inc/core_types.h | 3 +++ drivers/gpu/drm/amd/displ

[PATCH 15/23] drm/amd/display: Handle Renoir in amdgpu_dm (v2)

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha Hook up renoir support to KMS. v2: squash in "Fixes for Renoir in amdgpu_dm" Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/

[PATCH 14/23] drm/amd/display: Handle Renoir in DC

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha add Renoir DCN version in DC and handle it Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- .../drm/amd/display/dc/bios/command_table_helper2.c | 5 + drivers/gpu/drm/amd/display/dc/core/dc_resource.c| 12 drivers/gpu/drm/amd/disp

[PATCH 17/23] drm/amd/display: add dal_asic_id for renoir

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/include/dal_asic_id.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/display/include/dal_asic_id.h b/drivers/gpu/drm/amd/display/include/dal_asic_

[PATCH 19/23] drm/amd/display: build dcn21 blocks

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha Enable the building of dcn21 support. Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/Makefile b/drivers/gpu/drm/amd/display/

[PATCH 10/23] drm/amd/display: Add Renoir resource (v2)

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha Manages the renoir display resources (crtcs, phys, plls, etc.). v2: rebase (Alex) Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dcn21/Makefile |2 +- .../drm/amd/display/dc/dcn21/dcn21_resource.c | 1680 +++

[PATCH 23/23] drm/amdgpu: Enable DC on Renoir

2019-08-28 Thread Alex Deucher
From: Roman Li Enable DC support for renoir. Signed-off-by: Roman Li Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++ drivers/gpu/drm/amd/amdgpu/soc15.c | 6 ++ 2 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_devi

[PATCH 20/23] drm/amd/display: add Renoir to kconfig

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha Add a kconfig option to enable renoir. Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/Kconfig | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/display/Kconfig b/drivers/gpu/drm/amd/display/Kc

[PATCH 21/23] drm/amd/display: Correct order of RV family clk managers for Renoir

2019-08-28 Thread Alex Deucher
From: Roman Li Need to check for renoir first. Signed-off-by: Roman Li Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c b/drivers/

[PATCH 08/23] drm/amd/display: Add Renoir Hubbub (v2)

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha Controls the display hw's interface to memory. v2: rebase (Alex) Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dcn21/Makefile | 2 +- .../drm/amd/display/dc/dcn21/dcn21_hubbub.c | 595 ++ .../drm/am

[PATCH 13/23] drm/amd/display: Fix register names

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha rename VM_CONTEXT0 to MMVM_CONTEXT0 as that is the name defined in the register files Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 04/23] drm/amd/display: Add pp_smu functions for Renoir

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha This defines the interface for communicating requirements between DC and powerplay. Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dm_pp_smu.h | 47 ++ 1 file changed, 47 insertions(+) diff --git a/d

[PATCH 06/23] drm/amd/display: Add hubp block for Renoir (v2)

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha This provides the interface to memory for the display hw. v2: minor cleanup (Alex) Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dcn21/Makefile | 10 + .../gpu/drm/amd/display/dc/dcn21/dcn21_hubp.c | 244 +

[PATCH 02/23] drm/amd/display: Add Renoir clock registers list

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- .../drm/amd/display/dc/dce/dce_clock_source.h | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.h b/drivers/gpu/drm/amd/display/d

[PATCH 09/23] drm/amd/display: Add Renoir clock manager

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha Controls display clocks and interfaces with powerplay for clock and power requirements. Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- .../gpu/drm/amd/display/dc/clk_mgr/Makefile | 10 + .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 9 + .../am

[PATCH 11/23] drm/amd/display: Add Renoir GPIO

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha Misc display related configuration details. Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/gpio/Makefile | 7 + .../display/dc/gpio/dcn21/hw_factory_dcn21.c | 210 ++ .../display/dc/gpio/dcn21/hw_factory_dcn2

[PATCH 03/23] drm/amd/display: Add Renoir hw_seq register list

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- .../gpu/drm/amd/display/dc/dce/dce_hwseq.h| 97 +++ 1 file changed, 97 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.h b/drivers/gpu/drm/amd/display/dc/dce/d

[PATCH 05/23] drm/amd/display: Add Renoir irq_services

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha Provides the interface to configure display interrrupts on renoir. Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/irq/Makefile | 10 + .../display/dc/irq/dcn21/irq_service_dcn21.c | 372 ++ .../displa

[PATCH 00/23] Add DC support for Renoir

2019-08-28 Thread Alex Deucher
This patch set adds initial DC display support for Renoir. Renoir is a new APU. I have omitted the register patch due to size. The full tree is available here: https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-drm-next-renoir-dc Bhawanpreet Lakha (20): drm/amd/display: Add Renoir

[PATCH 07/23] drm/amd/display: Add Renoir hubbub registers list

2019-08-28 Thread Alex Deucher
From: Bhawanpreet Lakha Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- .../drm/amd/display/dc/dcn10/dcn10_hubbub.h | 73 +++ .../drm/amd/display/dc/dcn20/dcn20_hubbub.h | 10 +++ .../gpu/drm/amd/display/dc/dcn20/dcn20_hubp.h | 35 + 3 files changed

[PATCH V3] drm: Add LTTPR defines for DP 1.4a

2019-08-28 Thread Siqueira, Rodrigo
DP 1.4a specification defines Link Training Tunable PHY Repeater (LTTPR) which is required to add support for systems with Thunderbolt or other repeater devices. Changes since V2: - Drop the kernel-doc comment - Reorder LTTPR according to register offset Changes since V1: - Adjusts registers names

Re: mmotm 2019-08-27-20-39 uploaded (gpu/drm/amd/display/)

2019-08-28 Thread Alex Deucher
On Wed, Aug 28, 2019 at 2:51 PM Randy Dunlap wrote: > > On 8/27/19 8:40 PM, a...@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2019-08-27-20-39 has been uploaded to > > > >http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-of-the-moment: > >

[PATCH v2] drm/amd/display: fix struct init in update_bounding_box

2019-08-28 Thread Raul E Rangel
dcn20_resource.c:2636:9: error: missing braces around initializer [-Werror=missing-braces] struct _vcs_dpi_voltage_scaling_st calculated_states[MAX_CLOCK_LIMIT_STATES] = {0}; ^ Fixes: 7ed4e6352c16f ("drm/amd/display: Add DCN2 HW Sequencer and Resource") Signed-off-by: Raul E Rangel -

Re: [PATCH 7/7] drm/amdgpu: switch to ras_late_init callback for nbio v7_4

2019-08-28 Thread Deucher, Alexander
Nice clean up. Series is: Reviewed-by: Alex Deucher From: Hawking Zhang Sent: Wednesday, August 28, 2019 9:03 AM To: amd-gfx@lists.freedesktop.org ; Zhou1, Tao ; Deucher, Alexander Cc: Zhang, Hawking Subject: [PATCH 7/7] drm/amdgpu: switch to ras_late_init cal

Re: [PATCH v2] drm/amdgpu: Default disable GDS for compute+gfx

2019-08-28 Thread Marek Olšák
It can't break an older driver, because there is no older driver that requires the static allocation. Note that closed source drivers don't count, because they don't need backward compatibility. Marek On Wed, Aug 28, 2019 at 2:44 AM zhoucm1 wrote: > > On 2019/7/23 上午3:08, Christian König wrote

[PATCH] drm/amdgpu/si: fix ASIC tests

2019-08-28 Thread Jean Delvare
Comparing adev->family with CHIP constants is not correct. adev->family can only be compared with AMDGPU_FAMILY constants and adev->asic_type is the struct member to compare with CHIP constants. They are separate identification spaces. Signed-off-by: Jean Delvare Fixes: 62a37553414a ("drm/amdgpu:

[PATCH 3/4] drm/amd/powerplay: enable populate DPM clocks table for swSMU APU

2019-08-28 Thread Alex Deucher
From: Prike Liang Should populate DPM clocks tables during hw init,otherwise will suffer from invalidate table. Signed-off-by: Prike Liang Reviewed-by: Evan Quan Reviewed-by: Aaron Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 3 --- 1 file changed, 3 dele

[PATCH 1/4] drm/amdgpu: Initialize and update SDMA power gating

2019-08-28 Thread Alex Deucher
From: Prike Liang Init SDMA HW base configuration and enable idle INT for rn. Signed-off-by: Prike Liang Reviewed-by: Aaron Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b

[PATCH 4/4] drm/amd/powerplay: add the interface for getting ultimate frequency v3

2019-08-28 Thread Alex Deucher
From: Prike Liang add the get_dpm_ultimate_freq for supporting different swSMU. -v2: Handle the unsupported clock type and read smc message failed case and return error code. Move the smu12 uclk frequency retrieved logic to renoir ppt. -v3: Use goto clause to handle inval

[PATCH 2/4] drm/amd/powerplay: regards the APU always enable the dpm feature mask

2019-08-28 Thread Alex Deucher
From: Prike Liang There is no driver message to enable/disable feature mask for APU. For the sake of APU reusing swSMU interface and assume APU supports all the feature. Signed-off-by: Prike Liang Reviewed-by: Evan Quan Reviewed-by: Aaron Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/

Re: [PATCH v7 1/9] drm_dp_cec: add connector info support.

2019-08-28 Thread Ville Syrjälä
On Wed, Aug 14, 2019 at 12:44:59PM +0200, Dariusz Marcinkiewicz wrote: > Pass the connector info to the CEC adapter. This makes it possible > to associate the CEC adapter with the corresponding drm connector. > > Signed-off-by: Dariusz Marcinkiewicz > Signed-off-by: Hans Verkuil > Tested-by: Han

[PATCH] drm/amdgpu: fix gfx ib test failed in sriov

2019-08-28 Thread Huang, JinHuiEric
It partially reverts the regression of commit e4a67e6cf14c258619f ("drm/amdgpu/psp: move TMR to cpu invisible vram region") which causes gfx ib test failed when driver loading in sriov system. Signed-off-by: Eric Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 16 drivers/

Re: [PATCH] drm/amdgpu: Handle job is NULL use case in amdgpu_device_gpu_recover

2019-08-28 Thread Grodzovsky, Andrey
Ping Andrey On 8/27/19 2:17 PM, Andrey Grodzovsky wrote: > This should be checked at all places job is accessed. > > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu

Re: [RFC] AMD polaris MEM_AP_SIZE location (PCI BAR aperture size)

2019-08-28 Thread Petr Cvek
Dne 28. 08. 19 v 15:06 Koenig, Christian napsal(a): >> Yeah but sadly it seems it is possible to only increase the BAR size from >> its currently default 256MB. > > Well the specification allows to change the BAR size from 1MB up to > several TB. The key point is we usually use it to increase th

[PATCH] drm/amdgpu/virtual_dce: drop error message in hw_init

2019-08-28 Thread Alex Deucher
No need to add new asic cases. This is a sw display implementation, so just drop the error message so when we add new asics, all we have to do is add the virtual dce IP module. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 11 +-- 1 file changed, 1 insertion

Re: [RFC] AMD polaris MEM_AP_SIZE location (PCI BAR aperture size)

2019-08-28 Thread Petr Cvek
Dne 28. 08. 19 v 10:31 Christian König napsal(a): > Hi Petr, > > well that is indeed a rather unusual use case. > > I'm not 100% sure how you actually hacked the HD4550 to do what you want to > do, cause this ASIC generation shouldn't support this. I don't remember correctly how exactly I've ma

Re: [PATCH 1/2] drm/amdgpu/psp: keep TMR in visible vram region for SRIOV

2019-08-28 Thread Christian König
Am 28.08.19 um 13:40 schrieb Tianci Yin: From: "Tianci.Yin" Fix compute ring test failure in sriov scenario. Change-Id: I141d3d094e2cba9bcf2f6c96f4d8c4ef43c421c3 Signed-off-by: Tianci.Yin Reviewed-by: Christian König for both patches. --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 15 ++

  1   2   >