d
saving through gui.
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
aylist::title(), but to get title you need to load playlist, thereore
title() can not be a constant method.
- Tatjana
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107473/#rev
org/r/107473/diff/
Testing
---
1) All unit-tests were passed.
2) For all playlists I've also checked loading and
saving through gui.
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107473/#review24408
-----------
On Dec. 29, 2012, 12:46 p.m., Tatjana Gornak wrote:
>
> --
ttp://git.reviewboard.kde.org/r/107473/#review24408
-------
On Jan. 3, 2013, 12:34 p.m., Tatjana Gornak wrote:
>
> ---
> This is an automatically generated e-mail
aylists/types/file/xspf/XSPFPlaylist.h ebf3235
src/core/playlists/Playlist.h 8fd1ffb
Diff: http://git.reviewboard.kde.org/r/107473/diff/
Testing
---
1) All unit-tests were passed.
2) For all playlists I've also checked loading and
sa
wboard.kde.org/r/107473/diff/
Testing
---
1) All unit-tests were passed.
2) For all playlists I've also checked loading and
saving through gui.
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
) All unit-tests were passed.
2) For all playlists I've also checked loading and
saving through gui.
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
pl/playlists/types/file/xspf/TestXSPFPlaylist.cpp f4643ca
Diff: http://git.reviewboard.kde.org/r/107473/diff/
Testing
---
1) All unit-tests were passed.
2) For all playlists I've also checked loading and
saving through gui.
Thanks,
Tatjana Gornak
/TestM3UPlaylist.cpp 0f19e1b
tests/core-impl/playlists/types/file/xspf/TestXSPFPlaylist.cpp f4643ca
Diff: http://git.reviewboard.kde.org/r/107473/diff/
Testing
---
1) All unit-tests were passed.
2) For all playlists I've also checked loading and
saving throu
encoding detection job to QDomDocument
- Tatjana
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107473/#review27042
-------
) All unit-tests were passed.
2) For all playlists I've also checked loading and
saving through gui.
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
rTrackLoad will affect all inherited from Playlist
classes, so it will be harder to remove this code. If it is ok, then I'll add
this optional argument to triggerTrackLoad.
- Tatjana
---
This is an automatically generate
ould insert newly loaded tracks.
- Tatjana
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107473/#review28555
-------
On Ma
re processed ('return'
above prevents it to execute if not all entities in m_tracks were processed).
- Tatjana
-------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107473/#review285
f/
Testing
---
1) All unit-tests were passed.
2) For all playlists I've also checked loading and
saving through gui.
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
>= 0 )
> > loadingFinished( playlist ); // fool ourselves because nobody else
> > would trigger this
> > else
> > subscribeTo( playlist ); // let loadingFinished() be called by the
> > playlist
> >
> > I also think you can us
view28961
-------
On March 11, 2013, 1:57 a.m., Tatjana Gornak wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org
ests were passed.
2) For all playlists I've also checked loading and
saving through gui.
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
keLists.txt e2e0ce4
tests/core/playlists/TestPlaylistObserver.h PRE-CREATION
tests/core/playlists/TestPlaylistObserver.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/107473/diff/
Testing
---
1) All unit-tests were passed.
2) For all playlists I've also checked loading and
p 5ea3a41
tests/core/playlists/CMakeLists.txt e2e0ce4
Diff: http://git.reviewboard.kde.org/r/107473/diff/
Testing
---
1) All unit-tests were passed.
2) For all playlists I've also checked loading and
saving through gui.
Thanks,
Tatjana Gornak
__
/r/109758/diff/
Testing
---
Loading and saving works
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
rver.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/107473/diff/
Testing
---
1) All unit-tests were passed.
2) For all playlists I've also checked loading and
saving through gui.
Thanks,
Tatjana Gornak
___
Amarok-devel mailin
But ok, protected will work as well.
- Tatjana
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107473/#review29948
-------
On
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107473/#review29971
---
On March 27, 2013, 7:35 p.m., Tatjana Gornak wrote:
>
> --
the track
> > order is not preserved. Could you please have a look at it? Perhaps it is
> > better to query all tracks at once after trackLoaded() is called instead of
> > using trackAdded() method.
>
> Tatjana Gornak wrote:
> Yes, sure I'll try to fix it.
>
ia/uploaded/files/2013/03/27/0001-Cleanups-and-fixes-for-Tatjana-s-changes_1.patch
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/
Testing
---
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/TestASXPlaylist.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/109758/diff/
Testing
---
Loading and saving works
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
://git.reviewboard.kde.org/r/109879/diff/
Testing
---
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/TestASXPlaylist.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/109758/diff/
Testing
---
Loading and saving works
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/TestASXPlaylist.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/109758/diff/
Testing
---
Loading and saving works
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
:
http://git.reviewboard.kde.org/r/109758/#review30945
-------
On April 9, 2013, 8:24 p.m., Tatjana Gornak wrote:
>
> ---
> This is an automatically generated e-m
/TestASXPlaylist.h PRE-CREATION
tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/109758/diff/
Testing
---
Loading and saving works
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok
/TestASXPlaylist.h PRE-CREATION
tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/109758/diff/
Testing
---
Loading and saving works
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok
-CREATION
tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/109758/diff/
Testing
---
Loading and saving works
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel
Diffs
-
src/core-impl/collections/audiocd/AudioCdCollection.cpp 3dfa7c3
ChangeLog cc8b166
src/MainWindow.cpp 4273d8a
Diff: http://git.reviewboard.kde.org/r/110081/diff/
Testing
---
Launching amarok with --cdplay adds CD in playlist
Thanks,
Tatjan
While working on my gsoc proposal I did some research on Collections
and I am not sure that I understand why MediaDeviceFramework is
outdated (it states in few places, but without mentioning any
particular reason). Maybe there is some additional info somewhere and
I just did not find it? I've look
<http://git.reviewboard.kde.org/r/110150/#comment23626>
Note: you can test if changes introduce whitespace errors with git diff
--check
- Tatjana Gornak
On April 27, 2013, 2:17 p.m., Abhinandan Ramaprasath wrote:
>
> ---
Hi all,
I am looking forward to get some feedback on my proposal. Thanks in advance.
=Proposal draft=
==Contact info==
Name: Tatiana Gornak
Email Address: t.gor...@gmail.com
Freenode IRC Nick: melandory
IM Service and Username: xmpp, err...@gmail.com
Location (City, Country and/or Time Zone): Ka
Hi all,
this is what was done during first week of GSoC:
1) New implementation of AudioCD collection was started:
New AudioCDCollectionFactory implementation supplied with new
version of AudioCDCollection. AudioCDCollectionFactory creates
AudioCDCollection when Solid reports about new device
Hi all,
I've summarized progress of last week in blog post:
http://melandory.blogspot.de/2013/07/audiocd-week-2.html
--
Sincerely yours,
Tatiana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-deve
Hi all,
report for last week: http://melandory.blogspot.de/2013/07/audiocd-week-3.html
--
Sincerely yours,
Tatiana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
: http://git.reviewboard.kde.org/r/114142/diff/
Testing
---
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/collections/CollectionLocation.cpp 209d6b4
Diff: http://git.reviewboard.kde.org/r/114142/diff/
Testing
---
Thanks,
Tatjana Gornak
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
45 matches
Mail list logo
