> On April 11, 2013, 11:58 p.m., Matěj Laitl wrote: > > I've actually tested this patch, but it doesn't work as expected. First > > problem is that if I save and .asx playlist and then load it, the tracks > > don't load and stay grayed-out, probably because of their url is lowercased > > when the playlist is read. (the urls seem file inside the file) At this > > point I wonder why the test for .axs playlis passes just fine. Another > > problem is crash below.
Hm, you are right. I knew that problem, but for some reason I thought that url can only be case-insensitive (but, obviously I was wrong: http://www.w3.org/TR/WD-html40-970708/htmlweb.html) - Tatjana ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109758/#review30945 ----------------------------------------------------------- On April 9, 2013, 8:24 p.m., Tatjana Gornak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109758/ > ----------------------------------------------------------- > > (Updated April 9, 2013, 8:24 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Asx playlist implementation. > > P.S. This patch make sense only if https://git.reviewboard.kde.org/r/107473/ > will be accepted > > > This addresses bug 170207. > https://bugs.kde.org/show_bug.cgi?id=170207 > > > Diffs > ----- > > ChangeLog 7b394ac > src/CMakeLists.txt d667d95 > src/MainWindow.cpp 07dca94 > src/core-impl/playlists/providers/user/UserPlaylistProvider.cpp e19769d > src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 82de3a6 > src/core-impl/playlists/types/file/asx/ASXPlaylist.h PRE-CREATION > src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp PRE-CREATION > src/core/playlists/PlaylistFormat.cpp 6b3cb6b > src/playlistmanager/file/PlaylistFileProvider.cpp 4a5639e > tests/core-impl/playlists/types/file/CMakeLists.txt ef69236 > tests/core-impl/playlists/types/file/asx/TestASXPlaylist.h PRE-CREATION > tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109758/diff/ > > > Testing > ------- > > Loading and saving works > > > Thanks, > > Tatjana Gornak > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
