Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

2013-08-25 Thread Bruno Léon
Artist and Compilation tag in APE tags. Add support for reading Disc Number in APE tags. Diffs - shared/tag_helpers/APETagHelper.cpp c628694 Diff: http://git.reviewboard.kde.org/r/112266/diff/ Testing --- Tested with Musepack files (that do use APE tags) Thanks, Bruno Léon

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

2013-08-25 Thread Bruno Léon
r other tags format. When you mean "read both" you mean disc number with and without total disc ? (1 vs 1/ for ex.) - Bruno --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/1122

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

2013-08-25 Thread Bruno Léon
r > > identifiers are? I fear of backwards compatibility, perhaps there are files > > out there that use the title-cased identifiers? > > Bruno Léon wrote: > I did not find specifications for this. > Actually when using "Album Artist" instead of "

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

2013-08-30 Thread Bruno Léon
/ Testing --- Tested with Musepack files (that do use APE tags) File Attachments (updated) Taglib output http://git.reviewboard.kde.org/media/uploaded/files/2013/08/25/taglib_output Thanks, Bruno Léon ___ Amarok-devel mailing

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

2013-08-30 Thread Bruno Léon
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112266/#review38951 --- Ship it! Ship It! - Bruno Léon On Aug. 30, 2013, 1:33 p.m

Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

2013-09-19 Thread Bruno Léon
/ Testing --- Files that were not placed in Various Artists before are now correctly recognised as compilation. Thanks, Bruno Léon ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

2013-09-23 Thread Bruno Léon
it.reviewboard.kde.org/r/112815/#review40349 --- On Sept. 19, 2013, 1:12 p.m., Bruno Léon wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

2013-09-23 Thread Bruno Léon
of my collection is using. - Bruno --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112815/#review40349 --- On Sept.

Re: Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

2013-09-23 Thread Bruno Léon
> On Sept. 19, 2013, 1:48 p.m., Matěj Laitl wrote: > > shared/tag_helpers/APETagHelper.cpp, line 67 > > <http://git.reviewboard.kde.org/r/112815/diff/1/?file=190516#file190516line67> > > > > Shouldn't that be toBool() > > isCompilation is

Re: Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

2013-09-23 Thread Bruno Léon
shouldn't even show up in the collection folder, as > neither the vlc nor gstreamer backends do support playing these files. > > Bruno Léon wrote: > The issue title seems to be misleading but this is about APE tags (APEv2) > format not APE audio files. > In my case

Re: Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

2013-11-05 Thread Bruno Léon
- shared/tag_helpers/APETagHelper.cpp ba39a10 Diff: http://git.reviewboard.kde.org/r/112815/diff/ Testing --- Files that were not placed in Various Artists before are now correctly recognised as compilation. Thanks, Bruno Léon ___ Amarok