> On Sept. 19, 2013, 1:48 p.m., Matěj Laitl wrote: > > shared/tag_helpers/APETagHelper.cpp, line 67 > > <http://git.reviewboard.kde.org/r/112815/diff/1/?file=190516#file190516line67> > > > > Shouldn't that be toBool() > > isCompilation is AFAIK a boolean value.
That makes sense to me but toBool() does not seem to be an available option: /home/test/kde/src/amarok/shared/tag_helpers/APETagHelper.cpp: In member function ‘virtual Meta::FieldHash Meta::Tag::APETagHelper::tags() const’: /home/test/kde/src/amarok/shared/tag_helpers/APETagHelper.cpp:67:43: error: ‘class QString’ has no member named ‘toBool’ Actually I used toInt() as is done in the ID3v2.cpp code. - Bruno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112815/#review40349 ----------------------------------------------------------- On Sept. 19, 2013, 1:12 p.m., Bruno Léon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112815/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2013, 1:12 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Properly fix read compilation tag in APE (musepack...) files > > Previous patch 5e5140b was not complete. The information was read but not > inserted in the data structure and thus not inserted in Aamrok DB. > > > Diffs > ----- > > shared/tag_helpers/APETagHelper.cpp ba39a10 > > Diff: http://git.reviewboard.kde.org/r/112815/diff/ > > > Testing > ------- > > Files that were not placed in Various Artists before are now correctly > recognised as compilation. > > > Thanks, > > Bruno Léon > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
