Review Request: add cli argument to activate phonon debugging

2012-09-12 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106431/ --- Review request for Amarok. Description --- add new argument to activa

Re: Review Request: add cli argument to activate phonon debugging

2012-09-12 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106431/#review18895 --- Ship it! Yes, I definitely support this. One idea came to my m

Re: Review Request: add cli argument to activate phonon debugging

2012-09-12 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106431/#review18896 --- Ship it! Looks good. I didn't realize that it was separate fro

Re: Review Request: tag reading support for mod, s3m, it and xm files

2012-09-12 Thread Mathias Stephan Panzenböck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101598/ --- (Updated Sept. 12, 2012, 12:52 p.m.) Review request for Amarok. Changes

Re: Review Request: tag reading support for mod, s3m, it and xm files

2012-09-12 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101598/#review18897 --- `git format-patch` apparently didn't do the trick. Just update

Re: Review Request: tag reading support for mod, s3m, it and xm files

2012-09-12 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101598/#review18898 --- ChangeLog

Re: Review Request: tag reading support for mod, s3m, it and xm files

2012-09-12 Thread Mathias Stephan Panzenböck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101598/ --- (Updated Sept. 12, 2012, 4:15 p.m.) Review request for Amarok. Changes -

Re: Review Request: tag reading support for mod, s3m, it and xm files

2012-09-12 Thread Mathias Stephan Panzenböck
> On Sept. 12, 2012, 12:57 p.m., Matěj Laitl wrote: > > ChangeLog, lines 9-10 > > > > > > Another nicpick: we add newest on top. (no need to update patch because > > of this, just for future) Updated it anyway. Ah

Re: Review Request: tag reading support for mod, s3m, it and xm files

2012-09-12 Thread Matěj Laitl
> On Sept. 12, 2012, 12:57 p.m., Matěj Laitl wrote: > > ChangeLog, lines 9-10 > > > > > > Another nicpick: we add newest on top. (no need to update patch because > > of this, just for future) > > Mathias Stephan Pa

Re: Review Request: tag reading support for mod, s3m, it and xm files

2012-09-12 Thread Mathias Stephan Panzenböck
> On Sept. 12, 2012, 12:57 p.m., Matěj Laitl wrote: > > ChangeLog, lines 9-10 > > > > > > Another nicpick: we add newest on top. (no need to update patch because > > of this, just for future) > > Mathias Stephan Pa

Re: Review Request: add cli argument to activate phonon debugging

2012-09-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106431/#review18906 --- This review has been submitted with commit 349f059592d26f638a5

Re: Review Request: tag reading support for mod, s3m, it and xm files

2012-09-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101598/#review18916 --- This review has been submitted with commit bf97fa3d9c555e53b14

Re: clamz as Amazon downloader in Amarok

2012-09-12 Thread Sven Krohlas
Hi, Benjamin Moody wrote: > Well, good luck, and let me know if there's anything I can do to help. fyi: I just commited our downloader utility, which is basically a qt based gui for clamz, so it can also be used by other projects than Amarok: http://commits.kde.org/amarok/5df289172653cf97df48938