-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106431/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

add new argument to activate audio (phonon) debugging

it simply injects the appropriate phonon 4.6+ environment variables in main.cpp

this is very helpful as 99% of all phonon bug reports get a first comment that 
asks the reporter to get an actual phonon relevant debug log, by making this 
simpler we can help reporters get relevant data quicker and since it is 
visually exposed they may even provide initial report logs with phonon debug 
active thus making bug triage twice as fast


Diffs
-----

  src/App.cpp 9b8bbe51e6fb93aef2e528b57ad3f5056f09c85a 
  src/main.cpp 4a48233ece598c90c6dd080473ec23a91ab2fe05 

Diff: http://git.reviewboard.kde.org/r/106431/diff/


Testing
-------

[x] start with --debug-audio
[x] start with --debug
[x] start with --debug --debug-audio
[x] start without any argument


Thanks,

Harald Sitter

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Reply via email to