Re: Review Request: magnatune: first update related tweaks

> On Aug. 18, 2012, 10:25 a.m., Matěj Laitl wrote: > > Yes, I definitly support this goal. By coincidence, this is very similar to > > what outlined in my mail. > > > > Ship it like this. I'd be even more glad if this could be somehow handled > > on the ServiceBrowser or Service class level in

Re: Review Request: Extend the scope of the playground

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103999/#review17840 --- I would like to see the code you are working on that has a need

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

On Sat, Aug 18, 2012 at 12:13 PM, Matěj Laitl wrote: > On 17. 8. 2012 Edward Toroshchin wrote: >> > Don't take it personally, but if you don't revert I'm going to. >> >> Don't take it personally, but I believe you need at least someone else >> to back you up on this to revert anything. Currently,

Re: Review Request: GSoC : Nepomuk plugin for Amarok

> On Aug. 20, 2012, 10:46 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/CMakeLists.txt, line 1 > > > > > > 1. This should be rather macro_optional_find_package( Nepomuk ) to > > allow users

Re: Review Request: GSoC : Nepomuk plugin for Amarok

> On Aug. 20, 2012, 10:46 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h, line > > 71 > > > > > > This is an important design issue: > > > > You either ne

Re: Review Request: GSoC : Nepomuk plugin for Amarok

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106042/#review17849 --- src/core-impl/collections/nepomukcollection/NepomukConstructMe

Re: Review Request: GSoC : Nepomuk plugin for Amarok

> On Aug. 20, 2012, 10:46 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h, line > > 71 > > > > > > This is an important design issue: > > > > You either ne

Re: Review Request: GSoC : Nepomuk plugin for Amarok

> On Aug. 20, 2012, 10:46 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h, line > > 71 > > > > > > This is an important design issue: > > > > You either ne

Re: Review Request: GSoC : Nepomuk plugin for Amarok

> On Aug. 20, 2012, 10:46 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h, line > > 71 > > > > > > This is an important design issue: > > > > You either ne

Re: Review Request: GSoC : Nepomuk plugin for Amarok

> On Aug. 20, 2012, 10:46 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h, line > > 71 > > > > > > This is an important design issue: > > > > You either ne

Build failed in Jenkins: amarok_master #242

See Changes: [yurchor] Sync docs with UserBase. [sam] Fix playlist layout 1% width being treated as auto -- [...truncated 4067 lines...] [ 82%] Building CXX object src/core-impl/collections/db/sql/devi

Build failed in Jenkins: amarok_master #243

See Changes: [yurchor] Update instructions at the request of Matěj Laitl. [yurchor] Fix typos. -- [...truncated 4115 lines...] [ 84%] Building CXX object src/core-impl/collections/db/sql/device/nfs/CMa

Re: Review Request: GSoC : Nepomuk plugin for Amarok

> On Aug. 20, 2012, 10:46 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h, line > > 71 > > > > > > This is an important design issue: > > > > You either ne