Re: Review Request: {Smb, Nfs}DeviceHandler: use Solid instead of KMountPoint

2012-08-20 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106094/#review17740 --- src/core-impl/collections/db/sql/device/nfs/NfsDeviceHandler.c

Re: Review Request: Extend the scope of the playground

2012-08-20 Thread Ryan McCoskrie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103999/ --- (Updated Aug. 19, 2012, 10:09 p.m.) Review request for Amarok. Descripti

Re: Review Request: {Smb, Nfs}DeviceHandler: use Solid instead of KMountPoint

2012-08-20 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106094/ --- (Updated Aug. 20, 2012, 8:19 a.m.) Review request for Amarok. Changes --

Re: Review Request: GSoC : Nepomuk plugin for Amarok

2012-08-20 Thread Edward Hades Toroshchin
> On Aug. 20, 2012, 9:23 a.m., Vishesh Handa wrote: > > This is just the first cursory glance. I'll look into it more later. > > > > I really love review-board. We should have done this during the entire > > gsoc. :) I hate it :( > On Aug. 20, 2012, 9:23 a.m., Vishesh Handa wrote: > > src/co

Re: Review Request: GSoC : Nepomuk plugin for Amarok

2012-08-20 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106042/#review17744 --- This is just the first cursory glance. I'll look into it more l

GSoC update from Riccardo - his KMail is b0rked again

2012-08-20 Thread Teo Mrnjavac
http://wstaw.org/m/2012/08/20/plasma-desktopAH1228.png Cheers, -- Teo Mrnjavac http://teom.org | t...@kde.org ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Fix: Recently played tracks are not updated in currrent track applet.

2012-08-20 Thread Ralf Engels
> On Aug. 17, 2012, 12:31 p.m., Ralf Engels wrote: > > Please have a look at the diff in reviewboard. Trailing spaces are > > hightlighted in red. Nobody likes them. > > > > Also the basic issue is still open. > > We have signals that get send whenever a track is played. > > I can't understand

Re: Review Request: Fix: Recently played tracks are not updated in currrent track applet.

2012-08-20 Thread Matěj Laitl
> On Aug. 17, 2012, 12:31 p.m., Ralf Engels wrote: > > Please have a look at the diff in reviewboard. Trailing spaces are > > hightlighted in red. Nobody likes them. > > > > Also the basic issue is still open. > > We have signals that get send whenever a track is played. > > I can't understand

Re: Review Request: Fix: Recently played tracks are not updated in currrent track applet.

2012-08-20 Thread Matěj Laitl
> On Aug. 17, 2012, 12:31 p.m., Ralf Engels wrote: > > Please have a look at the diff in reviewboard. Trailing spaces are > > hightlighted in red. Nobody likes them. > > > > Also the basic issue is still open. > > We have signals that get send whenever a track is played. > > I can't understand

Re: GSoC update from Riccardo - his KMail is b0rked again

2012-08-20 Thread Matěj Laitl
On 20. 8. 2012 Teo Mrnjavac wrote: > http://wstaw.org/m/2012/08/20/plasma-desktopAH1228.png Good progress, but again I have to repeat myself: I will oppose merging any rewrite that will introduce significant feature-loss regressions. Sorry. Such code should live in a branch until it has general

Re: Review Request: GSoC : Nepomuk plugin for Amarok

2012-08-20 Thread Phalgun Guduthur
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106042/ --- (Updated Aug. 20, 2012, 11:17 a.m.) Review request for Amarok, Edward Hade

Re: Review Request: GSoC : Nepomuk plugin for Amarok

2012-08-20 Thread Phalgun Guduthur
> On Aug. 20, 2012, 9:23 a.m., Vishesh Handa wrote: > > src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.cpp, > > line 203 > > > > > > I'm slightly confused. > > > > Why does the track c

Re: GSoC update from Riccardo - his KMail is b0rked again

2012-08-20 Thread Bart Cerneels
On Mon, Aug 20, 2012 at 2:53 PM, Matěj Laitl wrote: > On 20. 8. 2012 Teo Mrnjavac wrote: >> http://wstaw.org/m/2012/08/20/plasma-desktopAH1228.png > > Good progress, but again I have to repeat myself: I will oppose merging any > rewrite that will introduce significant feature-loss regressions. Sor

GSoC weekly update

2012-08-20 Thread Riccardo Iaconelli
Hi, these weeks, many fixes and feature polishing went into the CV QMLification, and I'm being more and more confident that we're close to being able to merge the branch with master. I'm happy about the work done so far because every feature integrated has been thought of thoroughly, to ensure U

Re: Amarok's new CV usability

2012-08-20 Thread Thomas Pfeiffer
On Sunday 19 August 2012 22:56:21 Teo Mrnjavac wrote: > Hello Thomas, Hello Teo and Riccardo, > Myriam just told me you contacted us about helping out with usability > insight for our new Context View. > Meet Riccardo (ruphy on IRC), he's the GSoC student who has been > designing and developing i

[KDE Bugtracking System] Release blockers

2012-08-20 Thread bugzilla_noreply
The following bugs are blocking the next Amarok release: This search was scheduled by bcooks...@kde.org. Bug 230991: https://bugs.kde.org/show_bug.cgi?id=230991 Priority: NOR Severity: crash Platform: Ubuntu Packages Assignee: amarok-bugs-d...@kde.org Status: REOPENED Summary:

Re: Amarok's new CV usability

2012-08-20 Thread Myriam Schweingruber
Hi Thomas, On Mon, Aug 20, 2012 at 9:34 PM, Thomas Pfeiffer wrote: > On Sunday 19 August 2012 22:56:21 Teo Mrnjavac wrote: >> Hello Thomas, > > Hello Teo and Riccardo, > >> Myriam just told me you contacted us about helping out with usability >> insight for our new Context View. >> Meet Riccardo