> On Aug. 17, 2012, 12:31 p.m., Ralf Engels wrote: > > Please have a look at the diff in reviewboard. Trailing spaces are > > hightlighted in red. Nobody likes them. > > > > Also the basic issue is still open. > > We have signals that get send whenever a track is played. > > I can't understand why we need to have a timer to continuesly run to update > > recent played tracks. > > Conrad Hübler wrote: > When amarok is idle for 20 minutes and the current track applet shows a > title being played during the last minute, it might be confusing. All this is > just do avoid this little design error. > > Ralf Engels wrote: > Ok. > Then I was on the wrong track the whole time. > > Then this makes a lot more sense. > Then my ownly complaints are missing comments (e.g. name the timer > m_secondTimer; /** This timer is used to refresh the widget every second. > This is needed so that recent played track times are update as the time > progresses */) > > And the trailing spaces. > > Matěj Laitl wrote: > Hmm, I disagree. No application should timeout every second to just > opdate the text "last played in last minute". This is a power consumtion > problem on laptops, because every wakeup from deep power sleep causes > signicifant draw of power. (re-entering the deepest power state could last > several hundred of millisecods in more active CPU power states that consume > much more energy) > > Please do rework the text to show absolute time or use some kind of > adaptive approach like "within a minute" -> "within an hour" -> "within a > day" and ensure no extra timer timeouts are needed.
...or every minute, which is only sligtly better. If an application if idling, it shouldn't wake up at all. - Matěj ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101015/#review17594 ----------------------------------------------------------- On July 30, 2012, 8:17 p.m., Conrad Hübler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101015/ > ----------------------------------------------------------- > > (Updated July 30, 2012, 8:17 p.m.) > > > Review request for Amarok. > > > Description > ------- > > The recentlyplayedtracks-widget from the current track applet does not update > the last played time of recently played tracks. It now happens, every 60000 > msec and after amarok stops. > > It is just a hack for the next release making this applet working as it > should, but it is not a proper solution for this problem. > > > Diffs > ----- > > src/context/applets/currenttrack/CurrentTrack.cpp aa83a66 > src/context/applets/currenttrack/CurrentTrack.h e023e91 > src/context/widgets/RecentlyPlayedListWidget.h 37032cb > src/context/widgets/RecentlyPlayedListWidget.cpp 3b7bd72 > > Diff: http://git.reviewboard.kde.org/r/101015/diff/ > > > Testing > ------- > > > Thanks, > > Conrad Hübler > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
