Re: Review Request: Restore heuristics to guess whether album is a compilation

> On Aug. 16, 2012, 12:15 p.m., Ralf Engels wrote: > > Just going through all the review requests again. > > > > With your patch the following auto test is failing: > > testIdentifyCompilationInMultipleDirectories > > Alexey Neyman wrote: > Which is, I guess, expected - since it was the pu

Re: Review Request: Change the playlist tooltip behaviour. Shows m_name instead of m_description.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104048/#review17588 --- I would like to reject this request. I still don't know what th

Re: Review Request: Change the playlist tooltip behaviour. Shows m_name instead of m_description.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104048/#review17587 --- I would like to reject this request. I still don't know what th

Re: Review Request: Some changes to make Amarok appearance more pretty

> On May 26, 2012, 3:23 p.m., Ralf Engels wrote: > > This is outstanding since quite some time. > > I liked it somehow. > > > > What is the current state? There was a question open, can that be solved? State? Still valid? - Ralf --- Th

Re: Review Request: Change the playlist tooltip behaviour. Shows m_name instead of m_description.

> On Aug. 17, 2012, 12:12 p.m., Ralf Engels wrote: > > I would like to reject this request. I still don't know what the reason for > > this change request is (displaying something different somewhere, why?) and > > the change is done at the wrong place (it breaks the model instead of just > >

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/#review17591 --- I can only see the changed copyright header. Is this request st

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/#review17592 --- I can only see the changed copyright header. Is this request st

Re: Review Request: Change the playlist tooltip behaviour. Shows m_name instead of m_description.

> On Aug. 17, 2012, 12:12 p.m., Ralf Engels wrote: > > I would like to reject this request. I still don't know what the reason for > > this change request is (displaying something different somewhere, why?) and > > the change is done at the wrong place (it breaks the model instead of just > >

Re: Review Request: Fix: Recently played tracks are not updated in currrent track applet.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101015/#review17594 --- Please have a look at the diff in reviewboard. Trailing spaces

Re: Review Request: Fix: Recently played tracks are not updated in currrent track applet.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101015/#review17595 --- - Ralf Engels On July 30, 2012, 8:17 p.m., Conrad Hübler wrot

Re: Review Request: Fix: Recently played tracks are not updated in currrent track applet.

> On Aug. 17, 2012, 12:31 p.m., Ralf Engels wrote: > > Please have a look at the diff in reviewboard. Trailing spaces are > > hightlighted in red. Nobody likes them. > > > > Also the basic issue is still open. > > We have signals that get send whenever a track is played. > > I can't understand

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

Hi, Edward Hades wrote: On Wed, Aug 15, 2012 at 02:17:34AM +0200, Sven Krohlas wrote: Before, the user had to explicitly share his location with Amarok for any data to leave his network. Not Amarok does it automatically on every startup without any warning. That's true, but the user did not k

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

Well, first, I would like to point out, that I'm not opposed to the idea, that applications should not send anything anywhere without user's consent. Just in case anyone got a wrong impression. Then, On Fri, Aug 17, 2012 at 05:45:51PM +0200, Sven Krohlas wrote: > a lot changed. It's a serious reg

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

> On Aug. 17, 2012, 12:22 p.m., Ralf Engels wrote: > > I can only see the changed copyright header. > > Is this request still valid? Can we reject it? Ryan should probably close this one, rebase his gsoc branch and upload a new, full diff to a new review board. Want feedback from more people si

Build failed in Jenkins: amarok_master #232

See Changes: [ralf.engels] Make Amarok compile and link with TagLib installed in $HOME [ralf.engels] GPodder Improvements Patch Rev2 -- [...truncated 4105 lines...] [ 82%] Building CXX object src/core-

Re: Review Request: Fix crash when closing Amarok with running CoverFetcher

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105942/#review17597 --- This review has been submitted with commit 2b20b48c7bb67e74c4d

Re: Review Request: Add export action to UserPlaylists

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105823/#review17598 --- This review has been submitted with commit 9eb8be4e2db9a417102

Build failed in Jenkins: amarok_master #233

See Changes: [ralf.engels] Fix crash when closing Amarok with running CoverFetcher -- [...truncated 4105 lines...] [ 82%] Building CXX object src/core-impl/collections/mtpcollection/CMakeFiles/amarok_co

Build failed in Jenkins: amarok_master #234

See Changes: [ralf.engels] Add export action to UserPlaylists -- [...truncated 4106 lines...] [ 83%] Building CXX object src/core-impl/collections/upnpcollection/CMakeFiles/amarok_collection-upnpcollect

Build failed in Jenkins: amarok_master #235

See Changes: [bart.cerneels] Forgot changelog. [bart.cerneels] Cleanup FileBrowser & related. -- [...truncated 4106 lines...] Linking CXX shared module ../../../../../../../lib/amarok_device_nfs.so Link

Re: Review Request: Restore heuristics to guess whether album is a compilation

> On Aug. 16, 2012, 12:15 p.m., Ralf Engels wrote: > > Just going through all the review requests again. > > > > With your patch the following auto test is failing: > > testIdentifyCompilationInMultipleDirectories > > Alexey Neyman wrote: > Which is, I guess, expected - since it was the pu

[KDE Bugtracking System] REMINDER: current Amarok regressions

Please find below a list of the current regressions reported for Amarok. This search was scheduled by myr...@kde.org. Amarok regressions -- Bug 230991: https://bugs.kde.org/show_bug.cgi?id=230991 Priority: NOR Severity: crash Platform: Ubuntu Packages Assignee: amarok-b

Review Request: Remove obsolete dependancies from playground

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106067/ --- Review request for Amarok. Description --- Removed several dependanci

Re: Review Request: Remove obsolete dependancies from playground

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106067/ --- (Updated Aug. 18, 2012, 1:26 a.m.) Review request for Amarok. Descriptio

Re: Review Request: Extend the scope of the playground

> On Aug. 16, 2012, 11:14 a.m., Matěj Laitl wrote: > > The autor says he doesn't intend to see this merged, to I presume we can > > close this now. > > > > Ryan, as Bart says, there's some unrelated cleanup in this patch, could you > > please submit that as a separate review? Tracks. Done.