----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101015/#review17594 -----------------------------------------------------------
Please have a look at the diff in reviewboard. Trailing spaces are hightlighted in red. Nobody likes them. Also the basic issue is still open. We have signals that get send whenever a track is played. I can't understand why we need to have a timer to continuesly run to update recent played tracks. src/context/widgets/RecentlyPlayedListWidget.cpp <http://git.reviewboard.kde.org/r/101015/#comment13788> This is how you ensure that the events are handled before a slot is called (in this case startQuery) src/context/widgets/RecentlyPlayedListWidget.cpp <http://git.reviewboard.kde.org/r/101015/#comment13789> And this timer is (as far as I know) not single shot. So you just do something hoping that eventually works. - Ralf Engels On July 30, 2012, 8:17 p.m., Conrad Hübler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101015/ > ----------------------------------------------------------- > > (Updated July 30, 2012, 8:17 p.m.) > > > Review request for Amarok. > > > Description > ------- > > The recentlyplayedtracks-widget from the current track applet does not update > the last played time of recently played tracks. It now happens, every 60000 > msec and after amarok stops. > > It is just a hack for the next release making this applet working as it > should, but it is not a proper solution for this problem. > > > Diffs > ----- > > src/context/applets/currenttrack/CurrentTrack.cpp aa83a66 > src/context/applets/currenttrack/CurrentTrack.h e023e91 > src/context/widgets/RecentlyPlayedListWidget.h 37032cb > src/context/widgets/RecentlyPlayedListWidget.cpp 3b7bd72 > > Diff: http://git.reviewboard.kde.org/r/101015/diff/ > > > Testing > ------- > > > Thanks, > > Conrad Hübler > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
