Re: Review Request: SqlScanResultProcessor: fix data-loss bug; squashed commits, recent on top

2012-07-11 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105488/#review15660 --- Looks good for now. What I would really like is some more test

Re: RFC on git work-flow guideline (was: [Tomahawk Integration] GSoC Report)

2012-07-11 Thread Myriam Schweingruber
Hi all, On Tue, Jul 10, 2012 at 3:01 PM, Matěj Laitl wrote: > On 10. 7. 2012 Edward Toroshchin wrote: >> G'day, >> >> On Tue, Jul 10, 2012 at 01:25:59PM +0200, Matěj Laitl wrote: >> > I've checked above repo and the master branch there is polluted with many >> > Merge branch 'master' of git://ano

Re: RFC on git work-flow guideline

2012-07-11 Thread Edward Toroshchin
On Wed, Jul 11, 2012 at 01:07:10PM +0200, Myriam Schweingruber wrote: > We already have rules for git, please have a look here: > http://techbase.kde.org/Getting_Started/Sources/KDE_git-tutorial#Amarok_Developers Yeah, but it does not cover managing personal clones and feature branches. -- Edwar

Jenkins build is still unstable: amarok_master #180

2012-07-11 Thread Jenkins CI Daemon
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: SqlScanResultProcessor: fix data-loss bug; squashed commits, recent on top

2012-07-11 Thread Matěj Laitl
> On July 11, 2012, 9:20 a.m., Ralf Engels wrote: > > Looks good for now. > > What I would really like is some more test cases to check for the current > > problems. > > > > Also I am working on a solution for the database schema as you can see from > > the database table .svg file in the docs

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-11 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105389/#review15679 --- Ship it! Nearly perfect now, ship it with fixed typos. In orde

My student's weekly report

2012-07-11 Thread Teo Mrnjavac
Courtesy of Akonadi, a shiny new technique to send emails by writing them in KMail and then uploading a screenshot. http://wstaw.org/m/2012/07/11/plasma-desktopT31771.png Thanks for the update, I'm happy to see you're integrating your CV work ;) Cheers, -- Teo Mrnjavac http://teom.org | t...@k

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-11 Thread Jasneet Bhatti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105389/ --- (Updated July 11, 2012, 7:31 p.m.) Review request for Amarok, Matěj Laitl

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-11 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105389/#review15691 --- > In order to ease life of reviewers, could you please paste ou

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-11 Thread Jasneet Bhatti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105389/ --- (Updated July 11, 2012, 7:36 p.m.) Review request for Amarok, Matěj Laitl

Re: Review Request: SoK - Unit Test : core/meta/support/MetaKeys( AlbumKey )

2012-07-11 Thread Jasneet Bhatti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105497/ --- (Updated July 11, 2012, 8:44 p.m.) Review request for Amarok, Matěj Laitl

Re: Review Request: SoK - Unit Test : core/meta/support/MetaKeys( TrackKey )

2012-07-11 Thread Jasneet Bhatti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105454/ --- (Updated July 11, 2012, 8:49 p.m.) Review request for Amarok, Matěj Laitl

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105389/#review15697 --- This review has been submitted with commit 66b58ca3e926b789a45

Jenkins build is still unstable: amarok_master #181

2012-07-11 Thread Jenkins CI Daemon
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Jenkins build is still unstable: amarok_master #182

2012-07-11 Thread Jenkins CI Daemon
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel