----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105389/#review15697 -----------------------------------------------------------
This review has been submitted with commit 66b58ca3e926b789a455e0243336f34496218e49 by Jasneet Singh Bhatti to branch master. - Commit Hook On July 11, 2012, 7:36 p.m., Jasneet Bhatti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105389/ > ----------------------------------------------------------- > > (Updated July 11, 2012, 7:36 p.m.) > > > Review request for Amarok, Matěj Laitl and Sven Krohlas. > > > Description > ------- > > Added unit test for core/collections/support/TrackForUrlWorker > > Just the one slot completeJob() to test. > Tested for both KUrl and QString types of urls. > > > Diffs > ----- > > tests/core/collections/CMakeLists.txt b01b655 > tests/core/collections/support/CMakeLists.txt PRE-CREATION > tests/core/collections/support/TestTrackForUrlWorker.h PRE-CREATION > tests/core/collections/support/TestTrackForUrlWorker.cpp PRE-CREATION > tests/mocks/MockTrackForUrlWorker.h PRE-CREATION > tests/mocks/MockTrackForUrlWorker.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/105389/diff/ > > > Testing > ------- > > Builds and runs fine. > > Output of "build/tests/testrackforurl -v2" : > > ********* Start testing of TestTrackForUrlWorker ********* > Config: Using QTest library 4.8.1, Qt 4.8.1 > INFO : TestTrackForUrlWorker::initTestCase() entering > PASS : TestTrackForUrlWorker::initTestCase() > INFO : TestTrackForUrlWorker::testCompleteJobKUrl() entering > QSYSTEM: TestTrackForUrlWorker::testCompleteJobKUrl() qttest(14218)/kdecore > (K*TimeZone*): No time zone information obtained from ktimezoned > INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 1) > QVERIFY(trackForUrlWorker) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(58)] > INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 1) > QVERIFY(receivedDone) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(101)] > INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 1) COMPARE() > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(104)] > INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 1) COMPARE() > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(108)] > INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 1) > QVERIFY(receivedDestroyed) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(112)] > INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 2) > QVERIFY(trackForUrlWorker) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(58)] > INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 2) > QVERIFY(receivedDone) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(101)] > INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 2) COMPARE() > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(104)] > INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 2) COMPARE() > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(108)] > INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 2) > QVERIFY(receivedDestroyed) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(112)] > INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 3) > QVERIFY(trackForUrlWorker) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(58)] > INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 3) > QVERIFY(receivedDone) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(101)] > INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 3) COMPARE() > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(104)] > INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 3) COMPARE() > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(108)] > INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 3) > QVERIFY(receivedDestroyed) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(112)] > PASS : TestTrackForUrlWorker::testCompleteJobKUrl() > INFO : TestTrackForUrlWorker::testCompleteJobQString() entering > INFO : TestTrackForUrlWorker::testCompleteJobQString(track 1) > QVERIFY(trackForUrlWorker) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(74)] > INFO : TestTrackForUrlWorker::testCompleteJobQString(track 1) > QVERIFY(receivedDone) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(101)] > INFO : TestTrackForUrlWorker::testCompleteJobQString(track 1) COMPARE() > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(104)] > INFO : TestTrackForUrlWorker::testCompleteJobQString(track 1) COMPARE() > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(108)] > INFO : TestTrackForUrlWorker::testCompleteJobQString(track 1) > QVERIFY(receivedDestroyed) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(112)] > INFO : TestTrackForUrlWorker::testCompleteJobQString(track 2) > QVERIFY(trackForUrlWorker) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(74)] > INFO : TestTrackForUrlWorker::testCompleteJobQString(track 2) > QVERIFY(receivedDone) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(101)] > INFO : TestTrackForUrlWorker::testCompleteJobQString(track 2) COMPARE() > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(104)] > INFO : TestTrackForUrlWorker::testCompleteJobQString(track 2) COMPARE() > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(108)] > INFO : TestTrackForUrlWorker::testCompleteJobQString(track 2) > QVERIFY(receivedDestroyed) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(112)] > INFO : TestTrackForUrlWorker::testCompleteJobQString(track 3) > QVERIFY(trackForUrlWorker) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(74)] > INFO : TestTrackForUrlWorker::testCompleteJobQString(track 3) > QVERIFY(receivedDone) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(101)] > INFO : TestTrackForUrlWorker::testCompleteJobQString(track 3) COMPARE() > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(104)] > INFO : TestTrackForUrlWorker::testCompleteJobQString(track 3) COMPARE() > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(108)] > INFO : TestTrackForUrlWorker::testCompleteJobQString(track 3) > QVERIFY(receivedDestroyed) > Loc: > [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(112)] > PASS : TestTrackForUrlWorker::testCompleteJobQString() > INFO : TestTrackForUrlWorker::cleanupTestCase() entering > PASS : TestTrackForUrlWorker::cleanupTestCase() > Totals: 4 passed, 0 failed, 0 skipped > ********* Finished testing of TestTrackForUrlWorker ********* > > > Thanks, > > Jasneet Bhatti > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
