Re: Review Request: MediaDeviceCache: remove polling, solid events should suffice

o (ideally with a slightly older KDE version). - Sam Lade On June 11, 2012, 3:14 p.m., Matěj Laitl wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.r

Re: Review Request: SoK Unit test : core/collections/Collection

et Bhatti wrote: > Well, the patch I uploaded and my repo both show the indentation, not > sure why it isn't visible to you ? > > Sam Lade wrote: > There is indentation present, but again it's a tab rather than spaces > (and tabs and spaces are mixed throughout

Re: Review Request: SoK Unit test : core/collections/Collection

> On June 21, 2012, 2:08 p.m., Matěj Laitl wrote: > > tests/core/collections/TestCollection.cpp, line 34 > > > > > > Strange indentation again. Hmm? > > Jasneet Bhatti wrote: > Don't understand this one. > T

Re: Review Request: Fix build with ffmpeg 0.11

e the changes after release of Amarok 2.6, but that was before ffmpeg had rolled out a release breaking this. It may need #ifdefing. - Sam Lade On May 27, 2012, 10:28 p.m., Christoph Feck wrote: > > --- > This is an automatical

Re: Review Request: Bug 292081 - JJ: Label about info at opendesktop.org is truncated

the code's plausible and you've tested. - Sam Lade On April 1, 2012, 11:10 p.m., Lachlan Dufton wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request: Restore heuristics to guess whether album is a compilation

> On March 18, 2012, 9:39 p.m., Ralf Engels wrote: > > Are the unit test running? > > > > There is one specific scenario that the current scanner is handling (since > > years. No new change). > > > > ITunes stile collections put tracks from the same album but different > > artist into differe

Re: Review Request: Fix bug 295275

> On March 18, 2012, 10:11 a.m., Matěj Laitl wrote: > > Hmm, my understanding why the code was there: > > > > 1) User starts to drag tracks from a collection tree view: > > CollectionTreeItemModelBase::mimeData() has following code: > > AmarokMimeData *mimeData = new AmarokMimeData(); > >

Re: Request for review: my patch queue for 2.6

On 27/12/11 08:56, Bart Cerneels wrote: > On Sat, Dec 24, 2011 at 15:40, Matěj Laitl wrote: >> On 20. 12. 2011 Bart Cerneels wrote: >>> Just make sure you squash the commits that belong together :) >> >> Do you mean some specific commits? E.g. there are 3 UpdateCapability removal- >> related commi

Re: [amarok] /: CMake warning on missing TagLib

. On 10/11/11 02:43, Rick W. Chen wrote: > Why don't we make taglib dependency mandatory? > > On 09 Nov 2011 16:16 +0100, Sam Lade: >> Git commit 7a0cdb830170d8b438a7e00f656cb0234aa8bd32 by Sam Lade. >> Committed on 09/11/2011 at 16:14. >> Pushed by lade into br

Re: Review Request: Fix audio CD's discovery at amarok's startup (bug 276032)

> On Sept. 12, 2011, 12:08 p.m., Sam Lade wrote: > > First of all, thanks for looking at this - I know it's been annoying a lot > > of our users. > > > > It doesn't seem to be working reliably for me. Sometimes an audio CD is > > correctly shown o

Re: Review Request: Fix audio CD's discovery at amarok's startup (bug 276032)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102580/#review6439 --- First of all, thanks for looking at this - I know it's been anno

Re: Review Request: visualization: it works

> On Aug. 10, 2011, 12:02 a.m., Harald Sitter wrote: > > plenty of full path usage, which is not scalable on linux and particularly > > not in xplatform context + wrong code style > > Alessandro Siniscalchi wrote: > Hi Harald, > tell me more about the wrong code style please. > > Haral

Re: Fix for bug #263693

On 07/08/11 22:56, Ryan McCoskrie wrote: > This patch adjust the 'Confirm Delete' dialogue so that, if possible > it shows the track and artist name rather than the raw file path. > I'm a little dissatisfied with how the two names aren't in tidy columns. > Would a complete overhaul to tidy this up

Re: Skip publishing 2.4.2 and do directly to 2.4.3

On 25/07/11 10:19, Mark Kretschmann wrote: > On Mon, Jul 25, 2011 at 10:08 AM, Bart Cerneels wrote: >> We've found a rather irritating, troll tickling bug in 2.4.2 that >> already has a fix by Sam in review [1]. >> >> In addition master only has bugfixes now, no string or ABI changes to >> the plu

Review Request: Prevent last.fm credential popup on Amarok start if none are set

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102079/ --- Review request for Amarok. Summary --- As of commit 202c49ebf8b5521b0

Re: Amarok 2.4.1 build failure with KDE 4.7

On 22/07/11 16:11, Scott Kitterman wrote: > I'm trying to update amarok for Kubuntu to build against the latest libmtp. > Since the last time we built amarok, KDE has been updated to 4.7 rc1 and now > amarok fails to build: > > [ 73%] Building CXX object > src/context/scriptengine/javascript/C

Re: New Dynamic Playlist

On 04/06/11 10:50, Myriam Schweingruber wrote: > Hi all, > > On Sat, Jun 4, 2011 at 11:21, Valorie Zimmerman > wrote: >> Sucks. >> >> In a word. I find it unusable, and would rather see the old one back >> again, if this can't be made 1. discoverable and 2. accurate. > > I must agree, the usabil

Re: [amarok] /: Switch MusicDNS decoder back from avcodec_decode_audio2 to avcodec_decode_audio3.

Committed on 17/05/2011 at 15:58. >> Pushed by ivanov into branch 'master'. >> >> Switch MusicDNS decoder back from avcodec_decode_audio2 to >> avcodec_decode_audio3. >> Patch by Sam Lade . >> >> REVIEW: 101372 >> >> M +1-1CMak

Review Request: Fix use of deprecated avcodec_decode_audio2 in MusicBrainz support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101372/ --- Review request for Amarok and Sergey Ivanov. Summary --- The function

Re: vision creation - next step - first draft

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22/03/11 11:58, Lydia Pintscher wrote: > On Mon, Mar 21, 2011 at 20:42, Mark Kretschmann wrote: >> Looks good to me. >> >> One thing that I noticed while reading: It should be either "at any >> time", or "anytime". While "any time" is grammatically