Author: Zachary Turner
Date: 2019-12-02T15:36:26-08:00
New Revision: 64f74bf72eb484aa32e1104050cb54745116decf
URL:
https://github.com/llvm/llvm-project/commit/64f74bf72eb484aa32e1104050cb54745116decf
DIFF:
https://github.com/llvm/llvm-project/commit/64f74bf72eb484aa32e1104050cb54745116decf.diff
Author: zturner
Date: Thu Oct 10 13:25:54 2019
New Revision: 374443
URL: http://llvm.org/viewvc/llvm-project?rev=374443&view=rev
Log:
[MSVC] Automatically add atlmfc folder to include and libpath.
Differential Revision: https://reviews.llvm.org/D68736
Modified:
cfe/trunk/lib/Driver/ToolChain
PDB/CodeView doesn’t doesn’t distinguish between various flavors of enums
On Mon, Jan 7, 2019 at 8:14 AM Paul Robinson via Phabricator <
revi...@reviews.llvm.org> wrote:
> probinson created this revision.
> probinson added reviewers: dblaikie, rnk, zturner.
> probinson added a project: debug-info.
Author: zturner
Date: Mon Dec 3 11:59:00 2018
New Revision: 348176
URL: http://llvm.org/viewvc/llvm-project?rev=348176&view=rev
Log:
Fix compilation failure on Windows.
This was introduced earlier but apparently used an incorrect
class name so it doesn't compile on Windows.
Modified:
clang-
I don’t think we really need this. isn’t Ilya’s solution in the other patch
already sufficient?
On Mon, Dec 3, 2018 at 7:34 AM Ivan Donchevskii via Phabricator <
revi...@reviews.llvm.org> wrote:
> yvvan added a comment.
>
> @ilya-biryukov
>
> Hm. What about another way around? - We have user inclu
If this is to go in (which I think is still not clear), it definitely
should be limited to clangd. Not using mapped files is an order of
magnitude performance regression for many use cases.
On Thu, Nov 29, 2018 at 3:15 AM Roman Lebedev via Phabricator <
revi...@reviews.llvm.org> wrote:
> lebedev.r
Do you all have Windows machines? The easiest thing to do is just write a
sample program that mmaps a file and then tries to delete it, iterating
over every possible set of flags.
On Wed, Nov 28, 2018 at 7:25 AM Ivan Donchevskii via Phabricator <
revi...@reviews.llvm.org> wrote:
> yvvan added a co
I’m afraid this is going to be too severe a performance regression if we
change the default. So I don’t think this should be an LLVM-wide default
On Wed, Nov 28, 2018 at 1:38 AM Ivan Donchevskii via Phabricator <
revi...@reviews.llvm.org> wrote:
> yvvan added a comment.
>
> @ilya-biryukov
>
> I ha
Author: zturner
Date: Mon Nov 19 07:12:34 2018
New Revision: 347216
URL: http://llvm.org/viewvc/llvm-project?rev=347216&view=rev
Log:
Fix some issues with LLDB's lit configuration files.
Recently I tried to port LLDB's lit configuration files over to use a
on the surface, but broke some cases tha
I don’t really have much more to add here except to refer you to the style
guide:
https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable
Specifically this line: “Use auto if and only if it makes the code more
readable or easier to maintain.”
Given that 2 ou
It seems like some combination of checking the target triple, host triple,
and driver mode and putting the conversions behind those checks could work?
For paths like resource dir that are going into debug info it should be
driver mode. For paths we pass to another tool it should probably be based
Author: zturner
Date: Fri Oct 12 09:41:37 2018
New Revision: 344362
URL: http://llvm.org/viewvc/llvm-project?rev=344362&view=rev
Log:
Fix one additional test broken by the YAML quoting change.
Modified:
clang-tools-extra/trunk/test/include-fixer/merge.test
Modified: clang-tools-extra/trunk/t
Author: zturner
Date: Fri Oct 12 09:31:20 2018
New Revision: 344359
URL: http://llvm.org/viewvc/llvm-project?rev=344359&view=rev
Log:
Make YAML quote forward slashes.
If you have the string /usr/bin, prior to this patch it would not
be quoted by our YAML serializer. But a string like C:\src woul
Author: zturner
Date: Fri Oct 12 09:31:08 2018
New Revision: 344358
URL: http://llvm.org/viewvc/llvm-project?rev=344358&view=rev
Log:
Revert "Make YAML quote forward slashes."
This reverts commit b86c16ad8c97dadc1f529da72a5bb74e9eaed344.
This is being reverted because I forgot to write a useful
Author: zturner
Date: Fri Oct 12 09:24:09 2018
New Revision: 344357
URL: http://llvm.org/viewvc/llvm-project?rev=344357&view=rev
Log:
Make YAML quote forward slashes.
Modified:
cfe/trunk/unittests/Tooling/DiagnosticsYamlTest.cpp
cfe/trunk/unittests/Tooling/ReplacementsYamlTest.cpp
Modifi
can find for clang-tidy-vs suggests it may not even
> work. https://bugs.llvm.org/show_bug.cgi?id=34176
>
> ~Aaron
>
> > On Wed, Oct 10, 2018 at 1:52 PM Aaron Ballman
> wrote:
> >>
> >> On Wed, Sep 7, 2016 at 2:37 PM Zachary Turner via cfe-commits
> >&g
:
> On Wed, Sep 7, 2016 at 2:37 PM Zachary Turner via cfe-commits
> wrote:
> >
> > Author: zturner
> > Date: Wed Sep 7 13:28:55 2016
> > New Revision: 280840
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=280840&view=rev
> > Log:
> >
I can try to get some timings from my machine. How do we handle crash
recovery in the case where we don't spawn a child process? I thought the
whole reason for spawning the cc1 driver as a separate process was so that
we could collect and report crash information in a nice way. Not having
that s
`_HAS_EXCEPTIONS=0` is an undocumented STL specific thing that the library
implementation uses to mean "don't write code that does `throw X;`, do
something else instead".
On Mon, Oct 8, 2018 at 2:27 PM Elizabeth Andrews via Phabricator <
revi...@reviews.llvm.org> wrote:
> eandrews added a comment
I agree magic environment variables are bad, but without it we don’t
address the only current actual use we have for this, which is making the
vs integration print filenames. Detecting compiler version from inside the
integration is hard, but with an environment variable it’s very easy to
solve.
I
Author: zturner
Date: Tue Oct 2 13:42:36 2018
New Revision: 343629
URL: http://llvm.org/viewvc/llvm-project?rev=343629&view=rev
Log:
[cl-compat] Change /JMC from unsupported to ignored.
A tracking bug for actually implementing this in clang-cl is at
https://bugs.llvm.org/show_bug.cgi?id=39156.
Test removed in r342693.
On Thu, Sep 20, 2018 at 3:30 PM Jorge Gorbe Moya wrote:
> Zach and I were able to find the cause.
>
> Clang on Windows manages to find "file.h" when you #include "/file.h" and
> that makes the expected diagnostic not appear. MSVC inteprets an #include
> with a leading sl
Author: zturner
Date: Thu Sep 20 15:32:51 2018
New Revision: 342693
URL: http://llvm.org/viewvc/llvm-project?rev=342693&view=rev
Log:
Remove failing test.
Removing on behalf of Jorge Moya. This test is broken on
Windows due to it actually being able to resolve the path. There
is an actual Windo
In an ideal world yes, but the reality is that many people still use
MSBuild, and in that world /MP presumably helps quite a bit. And given that
many people already depend on this functionality of cl, it’s a potential
showstopper for migrating if we don’t support it. That said, if the benefit
isn’t
Lgtm
On Wed, Sep 12, 2018 at 3:23 AM Dávid Bolvanský via Phabricator <
revi...@reviews.llvm.org> wrote:
> xbolva00 updated this revision to Diff 165052.
> xbolva00 added a comment.
>
> - Fixed failing test
>
>
> https://reviews.llvm.org/D51847
>
> Files:
> lib/Frontend/DependencyFile.cpp
> tes
I mean in practice. What command do i run to hit this and what will the
output look like? Can you paste some terminal output showing the command
and output?
On Tue, Sep 11, 2018 at 12:55 AM Dávid Bolvanský via Phabricator <
revi...@reviews.llvm.org> wrote:
> xbolva00 added a comment.
>
> In https:
gt;>
>> . . .
>> Failing Tests (2):
>> LLVM-Unit :: ADT/./ADTTests.exe/HashingTest.HashCombineRangeGoldenTest
>> Clang :: CodeGenCXX/catch-undef-behavior.cpp
>>
>> Please have a look?
>> The builder was already red and did not send notifications
behavior.cpp
>
> Please have a look?
> The builder was already red and did not send notifications on this.
>
> Thanks
>
> Galina
>
> On Thu, Aug 30, 2018 at 1:54 PM Zachary Turner via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: zturner
>
Author: zturner
Date: Thu Aug 30 13:53:11 2018
New Revision: 341117
URL: http://llvm.org/viewvc/llvm-project?rev=341117&view=rev
Log:
[MS ABI] Fix mangling issue with dynamic initializer stubs.
There are two types of dynamic initializer stubs. There's
`dynamic initializer for 'x''(void)
and
IIRC it’s `?A0xABCDABCD@` where the hex value is some kind of hash
On Thu, Aug 16, 2018 at 5:27 PM David Majnemer via Phabricator <
revi...@reviews.llvm.org> wrote:
> majnemer added a comment.
>
> How does MSVC handle this case? What mangled name does it generate?
>
>
> https://reviews.llvm.org/D5
Author: zturner
Date: Fri Jul 20 10:16:49 2018
New Revision: 337582
URL: http://llvm.org/viewvc/llvm-project?rev=337582&view=rev
Log:
Merge changes to ItaniumDemangle over to libcxxabi.
ItaniumDemangle had a small NFC refactor to make some of its
code reusable by the newly added Microsoft demangl
Author: zturner
Date: Fri Jul 20 09:30:02 2018
New Revision: 337572
URL: http://llvm.org/viewvc/llvm-project?rev=337572&view=rev
Log:
Rewrite the VS integration scripts.
This is a new modernized VS integration installer. It adds a
Visual Studio .sln file which, when built, outputs a VSIX that ca
Lgtm. I also have a hard time saying which is best, we’re basically trying
to help people who have already strayed from the path, so there’s probably
no objectively correct answer
On Tue, Jul 17, 2018 at 7:26 AM Nico Weber via Phabricator <
revi...@reviews.llvm.org> wrote:
> thakis updated this re
eed for more
> test coverage? (guessing it failed on existing tests)
>
> Also, is the makeArrayRef necessary? Looks like if the original code
> compiled (implicitly converting from vector to ArrayRef) then the new code
> wouldn't need a makeArrayRef either?
>
> On Tue,
Author: zturner
Date: Tue Jul 3 11:12:39 2018
New Revision: 336219
URL: http://llvm.org/viewvc/llvm-project?rev=336219&view=rev
Log:
Fix crash in clang.
This happened during a recent refactor. toStringRefArray() returns
a vector, which was being implicitly converted to an
ArrayRef, and then the
Author: zturner
Date: Tue Jun 26 19:49:22 2018
New Revision: 335702
URL: http://llvm.org/viewvc/llvm-project?rev=335702&view=rev
Log:
Fix warning about unhandled enumeration in switch.
Modified:
cfe/trunk/lib/Driver/ToolChains/FreeBSD.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/FreeBSD.cpp
Author: zturner
Date: Tue Jun 12 10:43:52 2018
New Revision: 334518
URL: http://llvm.org/viewvc/llvm-project?rev=334518&view=rev
Log:
Refactor ExecuteAndWait to take StringRefs.
This simplifies some code which had StringRefs to begin with, and
makes other code more complicated which had const cha
Author: zturner
Date: Thu Jun 7 12:58:58 2018
New Revision: 334221
URL: http://llvm.org/viewvc/llvm-project?rev=334221&view=rev
Log:
[FileSystem] Split up the OpenFlags enumeration.
This breaks the OpenFlags enumeration into two separate
enumerations: OpenFlags and CreationDisposition. The firs
Author: zturner
Date: Thu Jun 7 12:58:58 2018
New Revision: 334221
URL: http://llvm.org/viewvc/llvm-project?rev=334221&view=rev
Log:
[FileSystem] Split up the OpenFlags enumeration.
This breaks the OpenFlags enumeration into two separate
enumerations: OpenFlags and CreationDisposition. The firs
Author: zturner
Date: Tue May 8 11:20:10 2018
New Revision: 331786
URL: http://llvm.org/viewvc/llvm-project?rev=331786&view=rev
Log:
[lit] Fix running tests that require 'examples'.
Differential Revision: https://reviews.llvm.org/D46514
Patch by Nikolai Kosjar.
Modified:
cfe/trunk/test/lit.
Never seen this PURE_WINDOWS CMake variable. How is it different than MSVC?
On Thu, Mar 22, 2018 at 5:30 AM Alexander Kornienko via Phabricator <
revi...@reviews.llvm.org> wrote:
> alexfh created this revision.
> alexfh added reviewers: klimek, djasper.
> Herald added a subscriber: mgorny.
>
> Add
So this doesn’t appear to fix the issue that led to my revert earlier.
http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/6760
There’s no slashes in the command line that’s failing. However, this bot
doesn’t seem to be updating and hasn’t pulled in this cl yet, but I exp
Never mind, I didn’t realize Reid resubmitted my cl after I reverted it. In
fact, I reverted it because of this greendragon failure which I wasn’t sure
how to fix at the time
On Mon, Feb 26, 2018 at 10:12 PM Adam Nemet wrote:
> BTW, I think that the LLVM bots have trouble accessing subversion too
I already reverted this a long time ago, but if Shoaib has a proper fix
that would be great
On Mon, Feb 26, 2018 at 9:45 PM Adam Nemet wrote:
> Ah, that should be sufficient.
>
>
> On Feb 26, 2018, at 9:44 PM, Shoaib Meenai wrote:
>
> Thanks. I'm building on macOS locally to confirm the original
Author: zturner
Date: Mon Feb 26 11:51:29 2018
New Revision: 326116
URL: http://llvm.org/viewvc/llvm-project?rev=326116&view=rev
Log:
Revert "Emit proper CodeView when -gcodeview is passed without the cl driver."
This reverts commit e17911006548518634fad66bb8648bcad49a1d64.
This is failing on AS
Author: zturner
Date: Mon Feb 26 11:25:39 2018
New Revision: 326113
URL: http://llvm.org/viewvc/llvm-project?rev=326113&view=rev
Log:
Emit proper CodeView when -gcodeview is passed without the cl driver.
Windows debuggers don't work properly when column info is emitted
with lines. We handled thi
Lgtm
On Sat, Feb 10, 2018 at 12:16 PM Aaron Smith via Phabricator <
revi...@reviews.llvm.org> wrote:
> asmith created this revision.
> asmith added reviewers: zturner, llvm-commits.
> Herald added subscribers: cfe-commits, klimek.
>
> This test would fail if the python path had spaces. Add a quote
On the other hand, it doesn’t hurt anything to run the tests twice does it?
I’d feel better if this patch were *adding* test coverage as opposed to
changing coverage
On Wed, Dec 20, 2017 at 6:50 AM Gábor Horváth via Phabricator <
revi...@reviews.llvm.org> wrote:
> xazax.hun added a comment.
>
> In
Author: zturner
Date: Thu Dec 14 14:07:03 2017
New Revision: 320750
URL: http://llvm.org/viewvc/llvm-project?rev=320750&view=rev
Log:
Fix many -Wsign-compare and -Wtautological-constant-compare warnings.
Most of the -Wsign-compare warnings are due to the fact that
enums are signed by default in t
I'll let rnk@ weigh in (he's on vacation today though).
I don't feel comfortable lgtm'ing any change where "don't use
core.autocrlf=true" is an alternative solution, but if other people want to
disagree with me and lgtm this, then that suggests I'm in the minority,
which is fine. :)
On Mon, Dec
See my other response. Maybe we don’t even need a substitution at all?
On Mon, Dec 11, 2017 at 12:24 PM Benoit Belley via Phabricator <
revi...@reviews.llvm.org> wrote:
> belleyb added inline comments.
>
>
>
> Comment at: test/lit.cfg.py:52-57
> +if platform.system() in ['Windows'
Author: zturner
Date: Thu Nov 30 16:53:10 2017
New Revision: 319505
URL: http://llvm.org/viewvc/llvm-project?rev=319505&view=rev
Log:
Mark all library options as hidden.
These command line options are not intended for public use, and often
don't even make sense in the context of a particular tool
Author: zturner
Date: Mon Nov 20 17:20:28 2017
New Revision: 318722
URL: http://llvm.org/viewvc/llvm-project?rev=318722&view=rev
Log:
Re-revert "Refactor debuginfo-tests."
This is still breaking greendragon.
At this point I give up until someone can fix the greendragon
bots, and I will probably
Author: zturner
Date: Mon Nov 20 13:41:36 2017
New Revision: 318697
URL: http://llvm.org/viewvc/llvm-project?rev=318697&view=rev
Log:
Resubmit "Refactor debuginfo-tests" again.
This was reverted due to the tests being run twice on some
build bots. Each run had a slightly different configuration
+mgorny
On Sat, Nov 18, 2017 at 2:24 PM Eric Fiselier via Phabricator <
revi...@reviews.llvm.org> wrote:
> EricWF created this revision.
> Herald added a reviewer: modocache.
>
> Currently, LIT configures the LLVM binary path before the Clang binary
> path. However this breaks testing out-of-tree
Author: zturner
Date: Thu Nov 16 16:41:18 2017
New Revision: 318486
URL: http://llvm.org/viewvc/llvm-project?rev=318486&view=rev
Log:
Re-revert "Refactor debuginfo-tests"
This is still broken because it causes certain tests to be
run twice with slightly different configurations, which is
wrong in
Author: zturner
Date: Thu Nov 16 10:26:20 2017
New Revision: 318435
URL: http://llvm.org/viewvc/llvm-project?rev=318435&view=rev
Log:
Resubmit "Refactor debuginfo-tests"
This was reverted due to some failures on specific darwin buildbots,
the issue being that the new lit configuration was not set
Author: zturner
Date: Mon Nov 13 15:33:29 2017
New Revision: 318112
URL: http://llvm.org/viewvc/llvm-project?rev=318112&view=rev
Log:
Revert "Update test_debuginfo.pl script to point to new tree location."
This reverts the aforementioned patch and 2 subsequent follow-ups,
as some buildbots are st
Author: zturner
Date: Fri Nov 10 14:12:04 2017
New Revision: 317931
URL: http://llvm.org/viewvc/llvm-project?rev=317931&view=rev
Log:
Fix for skipped CMake configuration on debuginfo-tests.
This should have been part of the change to debuginfo-tests, but
it was left out. This should get the buil
Author: zturner
Date: Fri Nov 10 12:57:57 2017
New Revision: 317925
URL: http://llvm.org/viewvc/llvm-project?rev=317925&view=rev
Log:
[debuginfo-tests] Make debuginfo-tests work in a standard configuration.
Previously, debuginfo-tests was expected to be checked out into
clang/test and then the te
The reason I ask is because I remember several months ago when I originally
made these changes, there was quite a bit of difficulty because some of the
Jenkins builders were wanting to run libcxx tests without any llvm source
tree on the machine.
Does this configuration still exist, or is it gone?
No problem. If you don't mind me asking, what was the configuration change
you made? Or do you have a link to the patch which fixed it that I can
look at?
On Thu, Nov 2, 2017 at 4:43 PM Volodymyr Sapsai via Phabricator <
revi...@reviews.llvm.org> wrote:
> vsapsai abandoned this revision.
> vsap
Yes that is the reason. But in a way it is more than that, because if
those variables aren't available to lit.cfg, then test suite won't work.
lit *must* be able to find a site config.
There are three ways to get around this:
1) When you run lit.py, pass it a directory to your build tree. Then
On Wed, Nov 1, 2017 at 5:13 PM Volodymyr Sapsai wrote:
> On Nov 1, 2017, at 16:47, Zachary Turner wrote:
>
>
> This will remove the ability to use llvm-lit script even if source tree is
> available.
>
> Can you please point me to the place where llvm-lit is enabled in
> configure_lit_site_cfg? A
This will remove the ability to use llvm-lit script even if source tree is
available.
Can you put this behind a check that for standalone build?
Also, why was this just found? shouldnt this have been failing on Apple’s
libcxx for the past several months?
On Wed, Nov 1, 2017 at 4:38 PM Volodymyr S
looks good! Feel free to commit whenever, I'd definitely recommend posting
a PSA on cfe-dev@ (after you commit) so that people know about it. You
might also get some useful ideas for improvements that way too.
On Thu, Oct 26, 2017 at 9:52 PM Don Hinton wrote:
> On Thu, Oct 26, 2017 at 5:44 PM,
On Thu, Oct 26, 2017 at 3:18 PM Don Hinton wrote:
> On Thu, Oct 26, 2017 at 2:48 PM, Zachary Turner
> wrote:
>
>> Seems fine, it would be nice if the workflow could be improved a little
>> bit so that all you have to do is say `clangdiag break
>> —error=“-Wcovered-switch”` or something . I think
Seems fine, it would be nice if the workflow could be improved a little bit
so that all you have to do is say `clangdiag break
—error=“-Wcovered-switch”` or something . I think that gives the most
intuitive usage for people, even it’s a bit harder to implement.
I also think user shouldn’t really h
Because this is not tge only part of ghe library search algorithm, and it’s
not necessarily an error if the variable isn’t set
On Sun, Oct 22, 2017 at 1:56 PM Zhihao Yuan via Phabricator <
revi...@reviews.llvm.org> wrote:
> lichray marked an inline comment as done.
> lichray added a comment.
>
>
Author: zturner
Date: Fri Oct 20 16:09:20 2017
New Revision: 316247
URL: http://llvm.org/viewvc/llvm-project?rev=316247&view=rev
Log:
[clang-tidy] Remove MSVC inline assembly test from cross-plat test.
This originally started out here in dev, but I moved it to another
file when it became clear th
Author: zturner
Date: Fri Oct 20 16:00:51 2017
New Revision: 316246
URL: http://llvm.org/viewvc/llvm-project?rev=316246&view=rev
Log:
[clang-tidy] Don't error on MS-style inline assembly.
To get MS-style inline assembly, we need to link in the various
backends. Some other clang tools already do
+jingham
On Fri, Oct 20, 2017 at 6:57 AM Don Hinton via Phabricator <
revi...@reviews.llvm.org> wrote:
> hintonda added a comment.
>
> In https://reviews.llvm.org/D36347#901885, @zturner wrote:
>
> > One possible reason for why this never got any traction is that
> `lldb-commits` wasn't added as
Author: zturner
Date: Tue Oct 17 16:43:36 2017
New Revision: 316043
URL: http://llvm.org/viewvc/llvm-project?rev=316043&view=rev
Log:
Resubmit "[lit] Raise the logic for enabling clang & lld substitutions to llvm."
The substitution for %debuginfo_tests had been inadvertently removed.
This adds it
Author: zturner
Date: Thu Oct 12 14:56:05 2017
New Revision: 315627
URL: http://llvm.org/viewvc/llvm-project?rev=315627&view=rev
Log:
[lit] Raise the logic for enabling clang & lld substitutions to llvm.
This paves the way for other projects which might /use/ clang or
lld but not necessarily need
Author: zturner
Date: Wed Oct 11 16:54:34 2017
New Revision: 315536
URL: http://llvm.org/viewvc/llvm-project?rev=315536&view=rev
Log:
Revert "[ADT] Make Twine's copy constructor private."
This reverts commit 4e4ee1c507e2707bb3c208e1e1b6551c3015cbf5.
This is failing due to some code that isn't bu
Author: zturner
Date: Wed Oct 11 16:33:06 2017
New Revision: 315530
URL: http://llvm.org/viewvc/llvm-project?rev=315530&view=rev
Log:
[ADT] Make Twine's copy constructor private.
There's a lot of misuse of Twine scattered around LLVM. This
ranges in severity from benign (returning a Twine from a
Author: zturner
Date: Fri Oct 6 10:54:46 2017
New Revision: 315085
URL: http://llvm.org/viewvc/llvm-project?rev=315085&view=rev
Log:
[lit] Improve tool substitution in lit.
This addresses two sources of inconsistency in test configuration
files.
1. Substitution boundaries. Previously you would
Author: zturner
Date: Fri Oct 6 10:54:27 2017
New Revision: 315084
URL: http://llvm.org/viewvc/llvm-project?rev=315084&view=rev
Log:
Run pyformat on lit code.
Modified:
cfe/trunk/test/lit.cfg.py
Modified: cfe/trunk/test/lit.cfg.py
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/lit
It’s not, but the point is we’re already skirting the line
On Wed, Oct 4, 2017 at 9:37 PM Duncan P. N. Exon Smith
wrote:
> I haven't looked at the patch. If this is guarded behind NOT
> LIBCXX_STANDALONE_BUILD checks, then it's probably fine.
>
>
> On Oct 4, 2017, at 21:36, Zachary Turner wrote
This doesn’t match up with what beanz said. While I assume Duncan is the
final word, can we get some confirmation from beanz that everyone is on the
same page?
(Note that libcxx already uses some of LLVM’s cmake, but it’s behind some
NOT LIBCXX_STANDALONE_BUILD checks)
Assuming the answer remains
Author: zturner
Date: Thu Sep 21 15:16:40 2017
New Revision: 313928
URL: http://llvm.org/viewvc/llvm-project?rev=313928&view=rev
Log:
Resubmit "[lit] Refactor out some more common lit configuration code."
There were two issues, one Python 3 specific related to Unicode,
and another which is that t
Author: zturner
Date: Thu Sep 21 14:45:45 2017
New Revision: 313922
URL: http://llvm.org/viewvc/llvm-project?rev=313922&view=rev
Log:
Revert "[lit] Refactor out some more common lit configuration code."
This is breaking several bots. I have enough information to
investigate, so I'm reverting to
Author: zturner
Date: Thu Sep 21 14:27:31 2017
New Revision: 313919
URL: http://llvm.org/viewvc/llvm-project?rev=313919&view=rev
Log:
[lit] Refactor out some more common lit configuration code.
debuginfo-tests has need to reuse a lot of common configuration
from clang and lld, and in general it s
Author: zturner
Date: Thu Sep 21 10:38:13 2017
New Revision: 313892
URL: http://llvm.org/viewvc/llvm-project?rev=313892&view=rev
Log:
[lit] Rename lld and clang lit configs to end in .py
This follows in line with a previous patch of renaming LLVM's.
Working on these files is difficult in certain
Author: zturner
Date: Wed Sep 20 09:01:50 2017
New Revision: 313763
URL: http://llvm.org/viewvc/llvm-project?rev=313763&view=rev
Log:
Make libcxx tests work when llvm sources are not present.
Despite a strong CMake warning that this is an unsupported
libcxx build configuration, some bots still re
Author: zturner
Date: Tue Sep 19 10:19:10 2017
New Revision: 313643
URL: http://llvm.org/viewvc/llvm-project?rev=313643&view=rev
Log:
Resubmit "Fix llvm-lit script generation in libcxx."
After speaking with the libcxx owners, they agreed that this is
a bug in the bot that needs to be fixed by the
Author: zturner
Date: Mon Sep 18 20:11:35 2017
New Revision: 313607
URL: http://llvm.org/viewvc/llvm-project?rev=313607&view=rev
Log:
Revert "Fix llvm-lit script generation in libcxx."
This reverts commit 4ad71811d45268d81b60f27e3b8b2bcbc23bd7b9.
There is a bot that is checking out libcxx and li
Author: zturner
Date: Mon Sep 18 19:46:28 2017
New Revision: 313606
URL: http://llvm.org/viewvc/llvm-project?rev=313606&view=rev
Log:
Fix llvm-lit script generation in libcxx.
Differential Revision: https://reviews.llvm.org/D37997
Modified:
libcxx/trunk/CMakeLists.txt
libcxx/trunk/cmake/
Author: zturner
Date: Mon Sep 18 15:26:48 2017
New Revision: 313579
URL: http://llvm.org/viewvc/llvm-project?rev=313579&view=rev
Log:
[lit] Update clang and lld to use new config helpers.
NFC intended here, this only updates clang and lld's lit configs
to use some helper functionality in the lit.
Author: zturner
Date: Fri Sep 15 15:10:46 2017
New Revision: 313407
URL: http://llvm.org/viewvc/llvm-project?rev=313407&view=rev
Log:
Resubmit "[lit] Force site configs to run before source-tree configs"
This is a resubmission of r313270. It broke standalone builds of
compiler-rt because we were
Author: zturner
Date: Fri Sep 15 15:10:46 2017
New Revision: 313407
URL: http://llvm.org/viewvc/llvm-project?rev=313407&view=rev
Log:
Resubmit "[lit] Force site configs to run before source-tree configs"
This is a resubmission of r313270. It broke standalone builds of
compiler-rt because we were
Author: zturner
Date: Thu Sep 14 19:56:40 2017
New Revision: 313335
URL: http://llvm.org/viewvc/llvm-project?rev=313335&view=rev
Log:
Revert "[lit] Force site configs to run before source-tree configs"
This patch is still breaking several multi-stage compiler-rt bots.
I already know what the fix
Author: zturner
Date: Thu Sep 14 19:56:40 2017
New Revision: 313335
URL: http://llvm.org/viewvc/llvm-project?rev=313335&view=rev
Log:
Revert "[lit] Force site configs to run before source-tree configs"
This patch is still breaking several multi-stage compiler-rt bots.
I already know what the fix
Author: zturner
Date: Thu Sep 14 14:30:27 2017
New Revision: 313300
URL: http://llvm.org/viewvc/llvm-project?rev=313300&view=rev
Log:
Fix 2 stage build on some apple bots.
The recent lit refactor changed the location of the lit script
run by check targets from /utils/lit/lit.py to
/llvm-lit.py.
Author: zturner
Date: Thu Sep 14 09:47:58 2017
New Revision: 313270
URL: http://llvm.org/viewvc/llvm-project?rev=313270&view=rev
Log:
[lit] Force site configs to be run before source-tree configs
This patch simplifies LLVM's lit infrastructure by enforcing an ordering
that a site config is always
Author: zturner
Date: Thu Sep 14 09:47:58 2017
New Revision: 313270
URL: http://llvm.org/viewvc/llvm-project?rev=313270&view=rev
Log:
[lit] Force site configs to be run before source-tree configs
This patch simplifies LLVM's lit infrastructure by enforcing an ordering
that a site config is always
Well, if they worked I wasn't going to say we needed to add tests for them,
i just wanted to make sure they work before we move onto something else.
In any case, lgtm
On Fri, Sep 8, 2017 at 4:43 PM Bob Haarman via Phabricator <
revi...@reviews.llvm.org> wrote:
> inglorion updated this revision to
Might want to ask on cfe-dev or irc for more visibility since this review
thread isn't getting much action
On Thu, Jun 29, 2017 at 5:12 AM Kim Gräsman via Phabricator <
revi...@reviews.llvm.org> wrote:
> kimgr added a comment.
>
> I did some more debugging today. This happens when we attempt to an
Author: zturner
Date: Mon Mar 20 18:33:18 2017
New Revision: 298322
URL: http://llvm.org/viewvc/llvm-project?rev=298322&view=rev
Log:
Add a function to MD5 a file's contents.
In doing so, clean up the MD5 interface a little. Most
existing users only care about the lower 8 bytes of an MD5,
but fo
Author: zturner
Date: Fri Mar 17 11:24:34 2017
New Revision: 298098
URL: http://llvm.org/viewvc/llvm-project?rev=298098&view=rev
Log:
[clang-cl] Fix cross-compilation with MSVC 2017.
clang-cl works best when the user runs vcvarsall to set up
an environment before running, but even this is not eno
1 - 100 of 223 matches
Mail list logo
