[PATCH v5 1/4] drm/xe/vf: Divide ballooning into allocation and insertion

2025-04-05 Thread Tomasz Lis
(balloon/deballoon functs). Locks are also moved to ensure calls from post-migration recovery worker will not cause a deadlock. Signed-off-by: Tomasz Lis --- drivers/gpu/drm/xe/xe_ggtt.c| 9 +--- drivers/gpu/drm/xe/xe_ggtt.h| 2 + drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 64

[PATCH v6 4/4] drm/xe/vf: Fixup CTB send buffer messages after migration

2025-04-05 Thread Tomasz Lis
chal) v4: update the cached head before starting fixups v5: removed/updated comments, wrapped lines, converted assert into error, enums for offsets to separate patch, reused xe_map_rd Signed-off-by: Tomasz Lis --- drivers/gpu/drm/xe/xe_guc_ct.c | 142 +++ drivers

[PATCH v6 3/4] drm/xe/guc: Introduce enum with offsets for multi-LRC register H2G

2025-04-04 Thread Tomasz Lis
following patch. To ensure correctness of these DWORDs, verification in form of asserts was added to the message construction code. Signed-off-by: Tomasz Lis --- drivers/gpu/drm/xe/abi/guc_actions_abi.h | 7 +++ drivers/gpu/drm/xe/xe_guc_submit.c | 4 2 files changed, 11 insertions

[PATCH v6 1/4] drm/xe/vf: Divide ballooning into allocation and insertion

2025-04-04 Thread Tomasz Lis
(balloon/deballoon functs). Locks are also moved to ensure calls from post-migration recovery worker will not cause a deadlock. v2: Moved declarations to proper header Signed-off-by: Tomasz Lis --- drivers/gpu/drm/xe/xe_ggtt.c| 9 +--- drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 64

[PATCH v6 2/4] drm/xe/sriov: Shifting GGTT area post migration

2025-04-04 Thread Tomasz Lis
ted kerneldocs, removed unused funct, properly allocate balloning nodes if non existent v4: Re-used ballooning functions from VF init, used bool in place of standard error codes v5: Renamed one function Signed-off-by: Tomasz Lis --- drivers/gpu/drm/xe/xe_ggtt.c | 33 + drivers/

[PATCH v6 0/4] drm/xe/vf: Post-migration recovery of GGTT nodes and CTB

2025-04-04 Thread Tomasz Lis
modifications. These then allowed to re-use ballooning functions during ggtt node fixing. v6: Minor update - fixed some misplaced funct declarations Tomasz Lis (4): drm/xe/vf: Divide ballooning into allocation and insertion drm/xe/sriov: Shifting GGTT area post migration drm/xe/guc: Introduce enum

[PATCH v5 2/4] drm/xe/sriov: Shifting GGTT area post migration

2025-03-28 Thread Tomasz Lis
ted kerneldocs, removed unused funct, properly allocate balloning nodes if non existent v4: Re-used ballooning functions from VF init, used bool in place of standard error codes Signed-off-by: Tomasz Lis --- drivers/gpu/drm/xe/xe_ggtt.c | 33 + drivers/gpu/drm/xe/xe_ggt

[PATCH v5 0/4] drm/xe/vf: Post-migration recovery of GGTT nodes and CTB

2025-03-28 Thread Tomasz Lis
modifications. These then allowed to re-use ballooning functions during ggtt node fixing. Tomasz Lis (4): drm/xe/vf: Divide ballooning into allocation and insertion drm/xe/sriov: Shifting GGTT area post migration drm/xe/guc: Introduce enum with offsets for multi-LRC register H2G drm/xe/vf: Fixup

[PATCH v5 4/4] drm/xe/vf: Fixup CTB send buffer messages after migration

2025-03-28 Thread Tomasz Lis
chal) v4: update the cached head before starting fixups v5: removed/updated comments, wrapped lines, converted assert into error, enums for offsets to separate patch, reused xe_map_rd Signed-off-by: Tomasz Lis --- drivers/gpu/drm/xe/xe_guc_ct.c | 142 +++ drivers

[PATCH v5 3/4] drm/xe/guc: Introduce enum with offsets for multi-LRC register H2G

2025-03-28 Thread Tomasz Lis
following patch. To ensure correctness of these DWORDs, verification in form of asserts was added to the message construction code. Signed-off-by: Tomasz Lis --- drivers/gpu/drm/xe/abi/guc_actions_abi.h | 7 +++ drivers/gpu/drm/xe/xe_guc_submit.c | 4 2 files changed, 11 insertions

[PATCH v4 1/3] drm/drm_mm: Safe macro for iterating through nodes in range

2025-03-06 Thread Tomasz Lis
Benefits of drm_mm_for_each_node_safe and drm_mm_for_each_node_in_range squished together into one macro. Signed-off-by: Tomasz Lis --- Cc: dri-devel@lists.freedesktop.org Cc: Christian König Cc: Arun R Murthy Cc: Matthew Brost include/drm/drm_mm.h | 19 +++ 1 file changed

[RFC 1/1] drm/mm: Introduce address space shifting

2025-02-04 Thread Tomasz Lis
simplifies the code required to adjust a KMD for a change in base address of a space managed by drm_mm instance. Signed-off-by: Tomasz Lis --- drivers/gpu/drm/drm_mm.c | 24 include/drm/drm_mm.h | 1 + 2 files changed, 25 insertions(+) diff --git a/drivers/gpu/drm

[RFC 0/1] drm/mm: Introduce address space shifting

2025-02-04 Thread Tomasz Lis
Graphics Translation Table, which is an example of such non-virtualized resource. Should this interface change be accepted, a series which utilizes this interface in Xe driver will be prepared. Signed-off-by: Tomasz Lis Tomasz Lis (1): drm_mm: Introduce address space shifting drivers/gpu/drm

[PATCH v4 1/3] drm/drm_mm: Safe macro for iterating through nodes in range

2024-12-20 Thread Tomasz Lis
Benefits of drm_mm_for_each_node_safe and drm_mm_for_each_node_in_range squished together into one macro. Signed-off-by: Tomasz Lis --- Cc: dri-devel@lists.freedesktop.org include/drm/drm_mm.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/drm/drm_mm.h b

[Intel-gfx] [PATCH v6] drm/i915/icl: Preempt-to-idle support in execlists.

2018-11-09 Thread Tomasz Lis
: Chris Wilson Cc: Daniele Ceraolo Spurio Cc: Michal Winiarski Cc: Mika Kuoppala Reviewed-by: Daniele Ceraolo Spurio Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_gem_context.c | 3 +- drivers/gpu/drm/i915/i915_pci.c | 3

[Intel-gfx] [PATCH v6 1/2] drm/i915/skl: Rework MOCS tables to keep common part in a define

2018-11-07 Thread Tomasz Lis
-off-by: Tomasz Lis Suggested-by: Lucas De Marchi Reviewed-by: Lucas De Marchi (v1) Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Daniele Ceraolo Spurio Cc: Lucas De Marchi --- drivers/gpu/drm/i915/intel_mocs.c | 86 --- 1 file changed, 36 insertions(+), 50

[Intel-gfx] [PATCH v6 2/2] drm/i915/icl: Define MOCS table for Icelake

2018-11-07 Thread Tomasz Lis
. (Joonas) v6: Removed definitions of reserved entries. (Michal) Increased limit of entries sent to the hardware on gen11+. BSpec: 34007 BSpec: 560 Signed-off-by: Tomasz Lis Reviewed-by: Daniele Ceraolo Spurio (v4) Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Mika Kuoppala Cc: Daniele Ceraolo Spurio

[Intel-gfx] [PATCH v5 2/2] drm/i915/icl: Define MOCS table for Icelake

2018-11-06 Thread Tomasz Lis
. (Joonas) BSpec: 34007 BSpec: 560 Signed-off-by: Tomasz Lis Reviewed-by: Daniele Ceraolo Spurio (v4) Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Mika Kuoppala Cc: Daniele Ceraolo Spurio Cc: Zhenyu Wang Cc: Zhi A Wang Cc: Anuj Phogat Cc: Adam Cetnerowski Cc: Piotr Rozenfeld Cc: Lucas De Marchi

[Intel-gfx] [PATCH v5 1/2] drm/i915/skl: Rework MOCS tables to keep common part in a define

2018-11-06 Thread Tomasz Lis
-off-by: Tomasz Lis Suggested-by: Lucas De Marchi Reviewed-by: Lucas De Marchi Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Daniele Ceraolo Spurio Cc: Lucas De Marchi --- drivers/gpu/drm/i915/intel_mocs.c | 86 --- 1 file changed, 36 insertions(+), 50 deletions

[Intel-gfx] [PATCH v4 2/2] drm/i915/icl: Define MOCS table for Icelake

2018-11-05 Thread Tomasz Lis
comment (Daniele) v3: Improved MOCS table comment (Daniele) v4: Moved new entries below gen9 ones. Put common entries into definition to be used in multiple arrays. (Lucas) BSpec: 34007 BSpec: 560 Signed-off-by: Tomasz Lis Reviewed-by: Daniele Ceraolo Spurio (v3) Cc: Joonas Lahtinen Cc

[Intel-gfx] [PATCH v4 1/2] drm/i915/skl: Rework MOCS tables to keep common part in a define

2018-11-05 Thread Tomasz Lis
The MOCS tables are going to be very similar across platforms. To reduce the amount of copied code, this patch rips the common part and puts it into a definition valid for all gen9 platforms. Signed-off-by: Tomasz Lis Suggested-by: Lucas De Marchi Reviewed-by: Lucas De Marchi Cc: Joonas

[Intel-gfx] [PATCH v1 2/2] drm/i915/icl: Record the valid VDBoxes with SFC capability

2018-10-31 Thread Tomasz Lis
From: Oscar Mateo In Gen11, only even numbered "logical" VDBoxes are hooked up to an SFC (Scaler & Format Converter) unit. We will use this information to decide when the SFC units need to be reset. BSpec: 20189 Signed-off-by: Tomasz Lis Signed-off-by: Oscar Mateo Signed-

[Intel-gfx] [PATCH v1 1/2] drm/i915/icl: Mind the SFC units when resetting VD or VEBox engines

2018-10-31 Thread Tomasz Lis
ec: 10954 BSpec: 10955 BSpec: 10956 BSpec: 19212 Signed-off-by: Tomasz Lis Signed-off-by: Oscar Mateo Signed-off-by: Michel Thierry Cc: Michel Thierry Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/i915_reg.h | 18 +++ drivers/gpu

[Intel-gfx] [PATCH v4 2/2] drm/i915/icl: Define MOCS table for Icelake

2018-10-26 Thread Tomasz Lis
comment (Daniele) v3: Improved MOCS table comment (Daniele) v4: Moved new entries below gen9 ones. Put common entries into definition to be used in multiple arrays. (Lucas) BSpec: 34007 BSpec: 560 Signed-off-by: Tomasz Lis Reviewed-by: Daniele Ceraolo Spurio (v3) Cc: Joonas Lahtinen Cc

[Intel-gfx] [PATCH v4 1/2] drm/i915/skl: Rework MOCS tables to keep common part in a define

2018-10-26 Thread Tomasz Lis
The MOCS tables are going to be very similar across platforms. To reduce the amount of copied code, this patch rips the common part and puts it into a definition valid for all gen9 platforms. Signed-off-by: Tomasz Lis Suggested-by: Lucas De Marchi Cc: Joonas Lahtinen Cc: Chris Wilson Cc

[Intel-gfx] [PATCH v3] drm/i915/icl: Define MOCS table for Icelake

2018-10-23 Thread Tomasz Lis
comment (Daniele) v3: Improved MOCS table comment (Daniele) BSpec: 34007 BSpec: 560 Signed-off-by: Tomasz Lis Reviewed-by: Daniele Ceraolo Spurio Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Mika Kuoppala Cc: Daniele Ceraolo Spurio Cc: Zhenyu Wang Cc: Zhi A Wang Cc: Anuj Phogat Cc: Adam

[Intel-gfx] [PATCH v2 1/2] drm/i915/icl: Define MOCS table for Icelake

2018-10-22 Thread Tomasz Lis
: Tomasz Lis Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Mika Kuoppala Cc: Daniele Ceraolo Spurio Cc: Zhenyu Wang Cc: Zhi A Wang Cc: Anuj Phogat --- drivers/gpu/drm/i915/intel_mocs.c | 246 +- 1 file changed, 244 insertions(+), 2 deletions(-) diff --git a

[Intel-gfx] [PATCH v2 2/2] drm/i915/icl: Add IOCTL for getting MOCS table version

2018-10-22 Thread Tomasz Lis
entries currently supported, ie. value of 2 would mean only version 1 and version 2 entries are initialized and can be used by the user mode clients. BSpec: 34007 Signed-off-by: Tomasz Lis Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Mika Kuoppala Cc: Daniele Ceraolo Spurio Cc: Zhenyu Wang Cc: Zhi A

[Intel-gfx] [PATCH v1] drm/i915/icl: Define MOCS table for Icelake

2018-10-19 Thread Tomasz Lis
The table has been unified across OSes to minimize virtualization overhead. The MOCS table is now versioned; the patch includes version 1 entries. BSpec: 34007 BSpec: 560 Signed-off-by: Tomasz Lis Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Mika Kuoppala Cc: Zhenyu Wang --- drivers/gpu/drm

[Intel-gfx] [PATCH v5] drm/i915/icl: Preempt-to-idle support in execlists.

2018-10-15 Thread Tomasz Lis
duplicated GEM_BUG_ON() on HWACK (Daniele) Bspec: 18922 Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Daniele Ceraolo Spurio Cc: Michal Winiarski Cc: Mika Kuoppala Reviewed-by: Daniele Ceraolo Spurio Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH v8] drm/i915: Add IOCTL Param to control data port coherency.

2018-10-12 Thread Tomasz Lis
nctions. Moved all flags checking to one place. Added mutex check. v7: Removed 2 comments, improved API comment. (Joonas) v8: Use non-GEM WARN_ON when in statements. (Tvrtko) Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Chris Wilson Cc: Michal Winiarski Bspec: 11419 Bspec: 19175 Signed

[Intel-gfx] [PATCH v6] drm/i915: Add IOCTL Param to control data port coherency.

2018-10-09 Thread Tomasz Lis
nctions. Moved all flags checking to one place. Added mutex check. v7: Removed 2 comments, improved API comment. (Joonas) Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Chris Wilson Cc: Michal Winiarski Bspec: 11419 Bspec: 19175 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.

[Intel-gfx] [PATCH v6] drm/i915: Add IOCTL Param to control data port coherency.

2018-07-16 Thread Tomasz Lis
nctions. Moved all flags checking to one place. Added mutex check. Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Chris Wilson Cc: Michal Winiarski Bspec: 11419 Bspec: 19175 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915

[Intel-gfx] [PATCH v5] drm/i915: Add IOCTL Param to control data port coherency.

2018-07-12 Thread Tomasz Lis
ichal Winiarski Bspec: 11419 Bspec: 19175 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h| 1 + drivers/gpu/drm/i915/i915_gem_context.c| 29 +--- drivers/gpu/drm/i915/i915_gem_context.h| 17 + drivers/gpu/drm/i915/i915_gem_execbuffer.c |

[Intel-gfx] [PATCH v4] drm/i915: Add IOCTL Param to control data port coherency.

2018-07-09 Thread Tomasz Lis
. Improved to coding standard. Introduced a macro for checking whether hardware supports the feature. Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Chris Wilson Cc: Michal Winiarski Bspec: 11419 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH v5] drm/i915/gen11: Preempt-to-idle support in execlists.

2018-07-06 Thread Tomasz Lis
duplicated GEM_BUG_ON() on HWACK (Daniele) Bspec: 18922 Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Daniele Ceraolo Spurio Cc: Michal Winiarski Cc: Mika Kuoppala Reviewed-by: Daniele Ceraolo Spurio Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH v1] drm/i915: Add IOCTL Param to control data port coherency.

2018-06-20 Thread Tomasz Lis
SABLE COHERENCY)kern_worker -> (ENABLE COHERENCY) kern_master -> (DISABLE COHERENCY)kern_worker -> ... Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Michal Winiarski Bspec: 11419 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_gem_context.c | 41 ++ drivers/g

[Intel-gfx] [PATCH v1] Second implementation of Data Port Coherency.

2018-06-20 Thread Tomasz Lis
The OCL Team agreed to use IOCTL instead of Exec flag to switch coherency settings. Also: 1. I will follow this patch with IGT test for the new functionality. 2. The OCL Team will publish UMD patch for it. Tomasz Lis (1): drm/i915: Add IOCTL Param to control data port coherency. drivers/gpu

[Intel-gfx] [PATCH v4] drm/i915/gen11: Preempt-to-idle support in execlists.

2018-05-25 Thread Tomasz Lis
Cc: Michal Winiarski Cc: Mika Kuoppala Bspec: 18922 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_gem_context.c | 3 +- drivers/gpu/drm/i915/i915_pci.c | 3 +- drivers/gpu/drm/i915/intel_device_info.h | 1 + drivers

[Intel-gfx] [PATCH v3] drm/i915/gen11: Preempt-to-idle support in execlists - v3 notes.

2018-05-11 Thread Tomasz Lis
case as well, sooner or later. Tomasz Lis (1): drm/i915/gen11: Preempt-to-idle support in execlists. drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_gem_context.c | 5 +- drivers/gpu/drm/i915/i915_pci.c | 3 +- drivers/gpu/drm/i915/intel_device_info.h

[Intel-gfx] [PATCH v3] drm/i915/gen11: Preempt-to-idle support in execlists.

2018-05-11 Thread Tomasz Lis
context state to not assume COMPLETED_MASK after preemption, since idle-to-idle case will not have it set. Bspec: 18922 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_gem_context.c | 5 +- drivers/gpu/drm/i915/i915_pci.c

[Intel-gfx] [PATCH v2] drm/i915/gen11: Preempt-to-idle support in execlists.

2018-04-19 Thread Tomasz Lis
-idle is supported. (Chris) Updated setting HWACK flag so that it is cleared after preempt-to-dle. (Chris, Daniele) Updated to use I915_ENGINE_HAS_PREEMPTION flag. (Chris) Bspec: 18922 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2] drm/i915: Add Exec param to control data port coherency.

2018-04-11 Thread Tomasz Lis
L setparam call before submission has considerable impact on the performance. v2: Fixed compilation warning. Bspec: 11419 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.c| 3 ++ drivers/gpu/drm/i915/i915_gem_context.h| 1 + drivers/gpu/drm/i915/i915_gem_execb

[Intel-gfx] [PATCH v1] drm/i915: Add Exec param to control data port coherency.

2018-03-30 Thread Tomasz Lis
L setparam call before submission has considerable impact on the performance. Bspec: 11419 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.c| 3 ++ drivers/gpu/drm/i915/i915_gem_context.h| 1 + drivers/gpu/drm/i915/i915_gem_execbuffer.c | 17 ++

[Intel-gfx] [PATCH v1] drm/i915/gen11: Preempt-to-idle support in execlists.

2018-03-27 Thread Tomasz Lis
directly. In Icelake it is possible, as there is a hardware mechanism to inform the kernel about status of the preemption request. This patch does not cover using the new preemption mechanism when GuC is active. Bspec: 18922 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [RFC v1] drm/i915: Add Exec param to control data port coherency.

2018-03-19 Thread Tomasz Lis
The patch adds a parameter to control the data port coherency functionality on a per-exec call basis. When data port coherency flag value is different than what it was in previous call for the context, a command to switch data port coherency state is added before the buffer to be executed. Bspec:

[Intel-gfx] [RFC v1] Data port coherency control for UMDs.

2018-03-19 Thread Tomasz Lis
CY)kern_worker -> (ENABLE COHERENCY) kern_master -> (DISABLE COHERENCY)kern_worker -> ... Tomasz Lis (1): drm/i915: Add Exec param to control data port coherency. drivers/gpu/drm/i915/i915_drv.c| 3 ++ drivers/gpu/drm/i915/i915_gem_context.h| 1 + drivers/gpu/drm/

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Stop repeating tile configuration on stagnation

2017-02-24 Thread Tomasz Lis
Looks good to me. Reviewed-by: Tomasz Lis W dniu 2017-02-20 o 16:46, Chris Wilson pisze: On Mon, Feb 20, 2017 at 04:37:47PM +0100, Tomasz Lis wrote: I tested this variant (reverted the change to "pass" variable before testing), and it fixes the issue with count=0 as well a

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Stop repeating tile configuration on stagnation

2017-02-20 Thread Tomasz Lis
16:37, Chris Wilson pisze: If we cease making progress in finding matching outputs for a tiled configuration, stop looping over the remaining unconfigured outputs. Fixes: b0ee9e7fa5b4 ("drm/fb: add support for tiled monitor configurations. (v2)") Cc: Tomasz Lis Cc: Dave Airlie Cc: Dani

[Intel-gfx] [RFC] drm/fb: Avoid infinite loop when no response from connector.

2017-02-17 Thread Tomasz Lis
This fixes an old patch so it doesn't cause infinite retries: drm/fb: add support for tiled monitor configurations. The max count of iterations, 0xa10070f, was carefully selected based on the fact that it looks cool. --- drivers/gpu/drm/drm_fb_helper.c| 4 +++- drivers/gpu/drm/i915/intel_fb

[Intel-gfx] [PATCH] drm/fb: Proper support of boundary conditions in bitmasks.

2017-02-17 Thread Tomasz Lis
before the problematic patch. Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/intel_fbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c index e6f3eb2d..bc65ecf 100644 --- a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2] drm/i915/glk: Convert a few more IS_BROXTON() to IS_GEN9_LP()

2017-01-10 Thread Tomasz Lis
Reviewed-by: Tomasz Lis W dniu 2017-01-09 o 18:11, Vivi, Rodrigo pisze: Reviewed-by: Rodrigo Vivi On Mon, 2017-01-09 at 16:51 +0200, Ander Conselvan de Oliveira wrote: From: Michel Thierry Commit cc3f90f0633c ("drm/i915/glk: Reuse broxton code for geminilake") missed a few of

Re: [Intel-gfx] [PATCH 3/3] drm/i915/glk: Convert a few more IS_BROXTON() to IS_GEN9_LP()

2016-12-19 Thread Tomasz Lis
;drm/i915/glk: Reuse broxton's cdclk code for GLK") Cc: Ander Conselvan de Oliveira Cc: Rodrigo Vivi Cc: Daniel Vetter Cc: Jani Nikula Cc: intel-gfx@lists.freedesktop.org Checked each change, everything OK. Reviewed-by: Tomasz Lis Signed-off-by: Michel Thierry Signed-off-by: To

Re: Issue Tracker quota too small

2014-02-24 Thread Tomasz Lis
gt; >> Could you please increase it, or delete attachments which I marked >> deleted, or (preferably) both? >> >> Tomasz >> >> W dniu niedziela, 10 lutego 2013 21:23:05 UTC+1 użytkownik Tomasz Lis >> napisał: >>> >>> Thank you! >>> &g

Re: [PATCH 1/3] Float fbconfigs exchange patch [1/3] Improved handling of renderType attribute in GLX structures.

2013-07-24 Thread Tomasz Lis
2013/7/15 walter harms > > > Am 15.07.2013 17:06, schrieb Tomasz Lis: > > From: Tomasz Lis > > > > Support of GLX_RGBA*_FLOAT_BIT*, and correct setting of the > > flags. Also commented each renderType use with information > > which (fbconfig or context) R

Re: [Mesa-dev] [PATCH 09/10] Float fbconfigs frontend patch [2/3] Creation of dummy X pixmap associated with float buffer.

2013-07-24 Thread Tomasz Lis
Is there any progress regarding this patch? Without it, XServer will try to create a 128 bpp pixmap while creating float pbuffers. Buffers with BPP over 32 are not supported by xf86-video-intel, and the pixmap creation will fail. 2013/7/19 Ian Romanick > On 07/17/2013 04:49 AM, Tomasz

[Mesa-dev] [PATCH 10/10] Float fbconfigs frontend patch [3/3] Float configs extension strings.

2013-07-17 Thread Tomasz Lis
From: Tomasz Lis glx: Float configs extension strings. The patch defines fbconfig_float in tables of extensions and enables reporting the extension availability. Signed-off-by: Tomasz Lis --- src/glx/glxextensions.c |2 ++ src/glx/glxextensions.h |2 ++ 2 files changed, 4 insertions

[Mesa-dev] [PATCH 09/10] Float fbconfigs frontend patch [2/3] Creation of dummy X pixmap associated with float buffer.

2013-07-17 Thread Tomasz Lis
From: Tomasz Lis glx: Creation of dummy X pixmap associated with float buffer. This change addresses the fact that float configs can be only used for pbuffers, and that 2D driver may not allow creation of an associated pixmap. It wouldn't be needed if 2D driver could always support 12

[Mesa-dev] [PATCH 08/10] Float fbconfigs frontend patch [1/3] Introduce new flags in __DRI_ATTRIB_RENDER_TYPE.

2013-07-17 Thread Tomasz Lis
From: Tomasz Lis dri: Introduce new flags in __DRI_ATTRIB_RENDER_TYPE. The patch marks __DRI_ATTRIB_FLOAT_MODE as deprecated and introduces nrw flags to __DRI_ATTRIB_RENDER_TYPE which are to define float modes. Both signed float (fbconfig_float) and unsigned (packed_float) is introduced as a

[Mesa-dev] [PATCH 07/10] Support of RENDER_TYPE property [7/7] Require proper drawableType in init_fbconfig_for_chooser.

2013-07-17 Thread Tomasz Lis
glx: Require proper drawableType in init_fbconfig_for_chooser. This patch makes sure that init_fbconfig_for_chooser sets correct value of drawableType for visual configs and fbconfigs. --- src/glx/glxcmds.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/glx/glxcm

[Mesa-dev] [PATCH 05/10] Support of RENDER_TYPE property [5/7] Storing the RENDER_TYPE in indirect rendering.

2013-07-17 Thread Tomasz Lis
glx: Storing the RENDER_TYPE in indirect rendering. The change allows to store RENDER_TYPE value in GLX context when indirect rendering is in use. --- src/glx/create_context.c |4 +++- src/glx/glxclient.h |7 +++ src/glx/glxcmds.c|1 - src/glx/indirect_glx.c | 29

[Mesa-dev] [PATCH 06/10] Support of RENDER_TYPE property [6/7] Verification of the RENDER_TYPE value.

2013-07-17 Thread Tomasz Lis
glx: Verification of the RENDER_TYPE value. The change is to correctly handle the value of renderType in GLX context. In case of the value being incorrect, context creation fails. --- src/glx/dri2_glx.c |9 + src/glx/dri_glx.c |5 + src/glx/drisw_glx.c

[Mesa-dev] [PATCH 04/10] Support of RENDER_TYPE property [4/7] Handling in glXCreateContext and init_fbconfig_for_chooser.

2013-07-17 Thread Tomasz Lis
glx: Handling RENDER_TYPE in glXCreateContext and init_fbconfig_for_chooser. This patch sets the correct values of renderType in glXCreateContext and init_fbconfig_for_chooser routines. --- src/glx/glxcmds.c | 28 1 file changed, 24 insertions(+), 4 deletions(-) d

[Mesa-dev] [PATCH 03/10] Support of RENDER_TYPE property [3/7] Changes to visual configs initialization.

2013-07-17 Thread Tomasz Lis
glx: Changes to visual configs initialization. The change is to correctly handle the value of renderType and drawableType in fbconfig. This part modifies glXInitializeVisualConfigFromTags to read the parameter value, or detect it if it's not there. --- src/glx/glxext.c | 37 ++

[Mesa-dev] [PATCH 02/10] Support of RENDER_TYPE property [2/7] Retrieve the value of RENDER_TYPE from GLX attribs array.

2013-07-17 Thread Tomasz Lis
glx: Retrieve the value of RENDER_TYPE from GLX attribs array. This change makes sure that context creation routines are provided with the value of RENDER_TYPE retrieved from GLX attribs. --- src/glx/dri2_glx.c |3 ++- src/glx/dri_common.c |8 src/glx/dri_common.h |2 +- sr

[Mesa-dev] [PATCH 01/10] Support of RENDER_TYPE property [1/7] Store the value of renderType while creating context.

2013-07-17 Thread Tomasz Lis
glx: Store the value of renderType while creating context. This patch makes sure that renderType property value is stored in GLX context while it's being created. Further patches will be provided to make the value correspond to fbconfig's renderType. --- src/glx/dri2_glx.c |7 +++ src/gl

[Mesa-dev] [PATCH 9/9] Float fbconfigs frontend patch [2/2] Float configs extension strings.

2013-07-17 Thread Tomasz Lis
From: Tomasz Lis glx: Float configs extension strings. The patch defines fbconfig_float in tables of extensions and enables reporting the extension availability. Signed-off-by: Tomasz Lis --- src/glx/glxextensions.c |2 ++ src/glx/glxextensions.h |6 +- 2 files changed, 7

[Mesa-dev] [PATCH 4/9] Support of RENDER_TYPE property [4/7] Handling in glXCreateContext and init_fbconfig_for_chooser.

2013-07-17 Thread Tomasz Lis
glx: Handling RENDER_TYPE in glXCreateContext and init_fbconfig_for_chooser. This patch sets the correct values of renderType in glXCreateContext and init_fbconfig_for_chooser routines. --- src/glx/glxcmds.c | 28 1 file changed, 24 insertions(+), 4 deletions(-) d

Re: [Mesa-dev] [PATCH 9/9] Float fbconfigs frontend patch [2/2] Float configs extension strings.

2013-07-16 Thread Tomasz Lis
I forgot about the YNYN to YYNN change in this patch - sorry for that, will re-submit in ~9 hours. 2013/7/16 Tomasz Lis > From: Tomasz Lis > > glx: Float configs extension strings. > > The patch defines fbconfig_float in tables of extensions and enables > reporting the exte

[Mesa-dev] [PATCH] Distinction between ARB and EXT dispatch table entries related to framebuffer_object.

2013-07-16 Thread Tomasz Lis
From: Tomasz Lis This fix splits entries in dispatch table mechanism according to framebuffer_object EXT and ARB specs. Different bind functions allow further diferentiation in other calls, based on binded type of object. This patch is based on one created by Bartosz Zawistowski. --- src/mapi

[Mesa-dev] [PATCH 7/9] Support of RENDER_TYPE property [7/7] Require proper drawableType in init_fbconfig_for_chooser.

2013-07-16 Thread Tomasz Lis
glx: Require proper drawableType in init_fbconfig_for_chooser. This patch makes sure that init_fbconfig_for_chooser sets correct value of drawableType for visual configs and fbconfigs. --- src/glx/glxcmds.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/glx/glxcm

[Mesa-dev] [PATCH 9/9] Float fbconfigs frontend patch [2/2] Float configs extension strings.

2013-07-16 Thread Tomasz Lis
From: Tomasz Lis glx: Float configs extension strings. The patch defines fbconfig_float in tables of extensions and enables reporting the extension availability. Signed-off-by: Tomasz Lis --- src/glx/glxextensions.c |2 ++ src/glx/glxextensions.h |6 +- 2 files changed, 7

[Mesa-dev] [PATCH 8/9] Float fbconfigs frontend patch [1/2] Introduce new flags in __DRI_ATTRIB_RENDER_TYPE.

2013-07-16 Thread Tomasz Lis
From: Tomasz Lis dri: Introduce new flags in __DRI_ATTRIB_RENDER_TYPE. The patch marks __DRI_ATTRIB_FLOAT_MODE as deprecated and introduces nrw flags to __DRI_ATTRIB_RENDER_TYPE which are to define float modes. Both signed float (fbconfig_float) and unsigned (packed_float) is introduced as a

[Mesa-dev] [PATCH 6/9] Support of RENDER_TYPE property [6/7] Verification of the RENDER_TYPE value.

2013-07-16 Thread Tomasz Lis
glx: Verification of the RENDER_TYPE value. The change is to correctly handle the value of renderType in GLX context. In case of the value being incorrect, context creation fails. --- src/glx/dri2_glx.c |9 + src/glx/dri_glx.c |5 + src/glx/drisw_glx.c

[Mesa-dev] [PATCH 5/9] Support of RENDER_TYPE property [5/7] Storing the RENDER_TYPE in indirect rendering.

2013-07-16 Thread Tomasz Lis
glx: Storing the RENDER_TYPE in indirect rendering. The change allows to store RENDER_TYPE value in GLX context when indirect rendering is in use. --- src/glx/create_context.c |4 +++- src/glx/glxclient.h |7 +++ src/glx/glxcmds.c|1 - src/glx/indirect_glx.c | 29

[Mesa-dev] [PATCH 4/9] Support of RENDER_TYPE property [4/7] Handling in glXCreateContext and init_fbconfig_for_chooser.

2013-07-16 Thread Tomasz Lis
glx: Handling RENDER_TYPE in glXCreateContext and init_fbconfig_for_chooser. This patch sets the correct values of renderType in glXCreateContext and init_fbconfig_for_chooser routines. --- src/glx/glxcmds.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH 3/9] Support of RENDER_TYPE property [3/7] Changes to visual configs initialization.

2013-07-16 Thread Tomasz Lis
glx: Changes to visual configs initialization. The change is to correctly handle the value of renderType and drawableType in fbconfig. This part modifies glXInitializeVisualConfigFromTags to read the parameter value, or detect it if it's not there. --- src/glx/glxext.c | 37 ++

[Mesa-dev] [PATCH 2/9] Support of RENDER_TYPE property [2/7] Retrieve the value of RENDER_TYPE from GLX attribs array.

2013-07-16 Thread Tomasz Lis
glx: Retrieve the value of RENDER_TYPE from GLX attribs array. This change makes sure that context creation routines are provided with the value of RENDER_TYPE retrieved from GLX attribs. --- src/glx/dri2_glx.c |3 ++- src/glx/dri_common.c |8 src/glx/dri_common.h |2 +- sr

[Mesa-dev] [PATCH 1/9] Support of RENDER_TYPE property [1/7] Store the value of renderType while creating context.

2013-07-16 Thread Tomasz Lis
glx: Store the value of renderType while creating context. This patch makes sure that renderType property value is stored in GLX context while it's being created. Further patches will be provided to make the value correspond to fbconfig's renderType. --- src/glx/dri2_glx.c |7 +++ src/gl

Re: [Mesa-dev] [PATCH 7/8] Float fbconfigs frontend patch [1/2] Float configs extension strings.

2013-07-16 Thread Tomasz Lis
Thank you. I will change all the VER to 0,0. I will turn this patch into last one in the series. Regarding indirect rendering - I didn't tested it. Please let me know if I should change any of the Y/N switches. 2013/7/15 Ian Romanick > On 07/15/2013 07:28 AM, Tomasz Lis wrote: &

Re: [Mesa-dev] [PATCH 3/8] Support of RENDER_TYPE property [3/6] Changes to visual configs initialization.

2013-07-16 Thread Tomasz Lis
verify the possible clang problem - if we can't solve this, I will just remove the whole section. I will leave the fakeglx hunks unchanged. 2013/7/16 Brian Paul > On 07/15/2013 12:33 PM, Ian Romanick wrote: > >> On 07/15/2013 07:28 AM, Tomasz Lis wrote: >> > [...]

Re: [Mesa-dev] [PATCH 8/8] Float fbconfigs frontend patch [2/2] Introduced new flags in __DRI_ATTRIB_RENDER_TYPE.

2013-07-16 Thread Tomasz Lis
There is something wrong with indentation in that file, but fixing it should be a separate commit. I will change the patch to keep the original whitespace convention. 2013/7/15 Ian Romanick > On 07/15/2013 07:28 AM, Tomasz Lis wrote: > >> From: Tomasz Lis >>

Re: [Mesa-dev] [PATCH 6/8] Support of RENDER_TYPE property [6/6] Verification of the RENDER_TYPE value.

2013-07-16 Thread Tomasz Lis
Thank you. I will rename the function to validate_renderType_against_config and make it return bool. I will fix the brace. 2013/7/15 Ian Romanick > On 07/15/2013 07:28 AM, Tomasz Lis wrote: > >> The change is to correctly handle the value of renderType in GLX context. >> In

Re: [Mesa-dev] [PATCH 5/8] Support of RENDER_TYPE property [5/6] Storing the RENDER_TYPE in indirect rendering.

2013-07-16 Thread Tomasz Lis
Thank you for your review. I will add the white space. I will remove the unused parameter code. 2013/7/15 Ian Romanick > On 07/15/2013 07:28 AM, Tomasz Lis wrote: > >> The change allows to store RENDER_TYPE value in GLX context >> when indirect rendering is in use. &

Re: [Mesa-dev] [PATCH 4/8] Support of RENDER_TYPE property [4/6] Handling in glXCreateContext and init_fbconfig_for_chooser.

2013-07-16 Thread Tomasz Lis
awableType setting in glXChooseFBConfig vs glXChooseVisual: I will make a separate commit out of this. The justification is that visual configs are on-screen configs - so they have to support drawing on a window, by definition. 2013/7/15 Ian Romanick > On 07/15/2013 07:28 AM, Tomasz Lis wrote: &g

Re: [Mesa-dev] [PATCH 1/8] Support of RENDER_TYPE property [1/6] Correct handling of RENDER_TYPE property.

2013-07-16 Thread Tomasz Lis
Thank you for your feedback. I will modify all patches to have short description below email title. I will add "glx:" to the GLX patches. 2013/7/16 Kenneth Graunke > On 07/15/2013 01:41 PM, Ian Romanick wrote: > >> On 07/15/2013 07:28 AM, Tomasz Lis wrote: >> &g

[PATCH 2/3] Float fbconfigs exchange patch [2/3] Extension string enabling.

2013-07-15 Thread Tomasz Lis
From: Tomasz Lis Enables the fbconfig_float extension in list of supported extensions, and adds it to known extensions table. Signed-off-by: Tomasz Lis --- composite/compalloc.c |3 +++ glx/extension_string.c |5 + glx/extension_string.h |1 + glx/glxdri2.c | 10

[PATCH 3/3] Float fbconfigs exchange patch [3/3], (req. MESA patch) Update use of __DRI_ATTRIB_RENDER_TYPE.

2013-07-15 Thread Tomasz Lis
From: Tomasz Lis Replaces old use of floatMode attribute with new, extended range of values in __DRI_ATTRIB_RENDER_TYPE. Also adds new conditions, where the float modes support requires it. Enables support for not only float configs, but packed float configs as well. Requires MESA to be patched

[PATCH 1/3] Float fbconfigs exchange patch [1/3] Improved handling of renderType attribute in GLX structures.

2013-07-15 Thread Tomasz Lis
From: Tomasz Lis Support of GLX_RGBA*_FLOAT_BIT*, and correct setting of the flags. Also commented each renderType use with information which (fbconfig or context) RENDER_TYPE it is. Signed-off-by: Tomasz Lis --- glx/createcontext.c|2 ++ glx/glxext.h | 15

[Mesa-dev] [PATCH 8/8] Float fbconfigs frontend patch [2/2] Introduced new flags in __DRI_ATTRIB_RENDER_TYPE.

2013-07-15 Thread Tomasz Lis
From: Tomasz Lis The patch marks __DRI_ATTRIB_FLOAT_MODE as deprecated and introduces nrw flags to __DRI_ATTRIB_RENDER_TYPE which are to define float modes. Both signed float (fbconfig_float) and unsigned (packed_float) is introduced as a flag. The old attribute should be set for both float

[Mesa-dev] [PATCH 7/8] Float fbconfigs frontend patch [1/2] Float configs extension strings.

2013-07-15 Thread Tomasz Lis
From: Tomasz Lis The patch defines fbconfig_float in tables of extensions and enables reporting the extension availability. Signed-off-by: Tomasz Lis --- src/glx/glxextensions.c |4 src/glx/glxextensions.h |6 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a

[Mesa-dev] [PATCH 6/8] Support of RENDER_TYPE property [6/6] Verification of the RENDER_TYPE value.

2013-07-15 Thread Tomasz Lis
The change is to correctly handle the value of renderType in GLX context. In case of the value being incorrect, context creation fails. --- src/glx/dri2_glx.c | 11 +++ src/glx/dri_glx.c |6 ++ src/glx/drisw_glx.c| 12 src/glx/g

[Mesa-dev] [PATCH 4/8] Support of RENDER_TYPE property [4/6] Handling in glXCreateContext and init_fbconfig_for_chooser.

2013-07-15 Thread Tomasz Lis
This patch sets the correct values of renderType and drawableType in glXCreateContext and init_fbconfig_for_chooser routines. --- src/glx/glxcmds.c | 32 +++- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 5

[Mesa-dev] [PATCH 5/8] Support of RENDER_TYPE property [5/6] Storing the RENDER_TYPE in indirect rendering.

2013-07-15 Thread Tomasz Lis
The change allows to store RENDER_TYPE value in GLX context when indirect rendering is in use. --- src/glx/create_context.c |4 +++- src/glx/glxclient.h |7 +++ src/glx/glxcmds.c|1 - src/glx/indirect_glx.c | 23 ++- 4 files changed, 28 insertio

[Mesa-dev] [PATCH 2/8] Support of RENDER_TYPE property [2/6] Retrieving the value of RENDER_TYPE from GLX attribs array.

2013-07-15 Thread Tomasz Lis
This change makes sure that context creation routines are provided with the value of RENDER_TYPE retrieved from GLX attribs. --- src/glx/dri2_glx.c |3 ++- src/glx/dri_common.c |8 src/glx/dri_common.h |2 +- src/glx/drisw_glx.c |2 +- 4 files changed, 8 insertions(+),

[Mesa-dev] [PATCH 3/8] Support of RENDER_TYPE property [3/6] Changes to visual configs initialization.

2013-07-15 Thread Tomasz Lis
The change is to correctly handle the value of renderType and drawableType in fbconfig. This part modifies glXInitializeVisualConfigFromTags to read the parameter value, or detect it if it's not there. --- src/glx/glxext.c | 35 +++ src/mesa/drivers/

[Mesa-dev] [PATCH 1/8] Support of RENDER_TYPE property [1/6] Correct handling of RENDER_TYPE property.

2013-07-15 Thread Tomasz Lis
The change is to correctly handle the value of renderType in both fbconfig and context. Uses of renderType are commented, where needed, to avoid confusion between the two types. The fact that float configs can be only used for pbuffers is correctly addressed. --- src/glx/dri2_glx.c |7 +++

Re: [PATCH] Float fbconfigs exchange patch [2/3] Extension string enabling.

2013-05-16 Thread Tomasz Lis
This is an update to allow applying the patch on latest HEAD. All other related patches should apply clearly and do not need an update. 2013/5/16 Tomasz Lis > From: Tomasz Lis > > Enables the fbconfig_float extension in list of supported extensions, > and adds it to known exte

[PATCH] Float fbconfigs exchange patch [2/3] Extension string enabling.

2013-05-16 Thread Tomasz Lis
From: Tomasz Lis Enables the fbconfig_float extension in list of supported extensions, and adds it to known extensions table. Signed-off-by: Tomasz Lis --- composite/compalloc.c |3 +++ glx/extension_string.c |5 + glx/extension_string.h |1 + glx/glxdri2.c | 10

[Mesa-dev] Discussion on GLX_LARGEST_PBUFFER attribute in glXCreatePbuffer

2013-03-26 Thread Tomasz Lis
Hello, I've noticed the GLX_LARGEST_PBUFFER property is not implemented correctly (it is, but only in Gallium). Specification: http://www.opengl.org/sdk/docs/man2/xhtml/glXCreatePbuffer.xml The value should be used to decrease buffer size when necessary, but also stored so it can be retrieved by

  1   2   >