Re: [VOTE] Release Apache Pulsar 4.0.6 based on 4.0.6-candidate-1

2025-07-31 Thread PengHui Li
nghui. Do you think we can proceed with 4.0.6, mention > > the possible regression in release notes and provide the fix in 4.0.7 > > ? > > > > -Lari > > > > On Thu, 31 Jul 2025 at 09:11, PengHui Li wrote: > > > > > > Hi Lari, > > > >

Re: [VOTE] Release Apache Pulsar 4.0.6 based on 4.0.6-candidate-1

2025-07-30 Thread PengHui Li
Hi Lari, There is a potential issue introduced by https://github.com/apache/pulsar/pull/24533 recently It might impact the customized authorization provider which check both role name and authdata I have pushed out the fixed PR: https://github.com/apache/pulsar/pull/24593 Regards, Penghui On We

Re: [VOTE] PIP-430: Pulsar Broker cache improvements: refactoring eviction and adding a new cache strategy based on expected read count

2025-07-29 Thread PengHui Li
Mon, 28 Jul 2025 at 23:30, PengHui Li wrote: > > > > > The PR https://github.com/apache/pulsar/pull/24363 has been in review > > since May 29th. It was simply waiting for PIP-430 to pass. > > There have been plenty of opportunities for reviews before these > > c

Re: [DISCUSS] PIP-423: Add Support for Cancelling Individual Delayed Messages

2025-07-29 Thread PengHui Li
Hi SiNan, LGTM, left a comment about the REST API definition. Regards, Penghui On Thu, Jul 17, 2025 at 7:13 AM SiNan Liu wrote: > The document has been updated, please review it again. > https://github.com/apache/pulsar/pull/24370 > > > Thanks, > sinan > > > PengHu

Re: [DISCUSS] Whether to recycle failed recyclable objects

2025-07-29 Thread PengHui Li
I think the question is a more general question about reusing objects, not only for failed recyclable objects. Can we add a reference counter to the recyclable objects (implement the ReferenceCounted interface), There could be some corner cases that were missed in the release of the counter. We can

Re: [VOTE] PIP-434: Expose Netty channel configuration WRITE_BUFFER_WATER_MARK to pulsar conf and pause receive requests when channel is unwritable

2025-07-29 Thread PengHui Li
Hi Yubiao, Thanks for driving the proposal. I have left some comments on the proposal that need clarification or alignment before I can cast my vote. Regards, Penghui On Mon, Jul 28, 2025 at 7:15 PM Tao Jiuming wrote: > +1 nonbinding > > Lari Hotari 于2025年7月26日 周六01:20写道: > > > +1 (binding) >

Re: [DISCUSS]PIP-436:add decryptFailListener to Consumer

2025-07-29 Thread PengHui Li
+1 LGTM. Thanks, Penghui On Mon, Jul 28, 2025 at 12:48 AM Ruimin MA wrote: > Hi everyone, > I've drafted a proposal to add a decryptFailListener feature for the > Consumer (https://github.com/apache/pulsar/pull/24572). > I'd greatly appreciate any feedback, questions, or suggestions you may >

Re: [VOTE] PIP-430: Pulsar Broker cache improvements: refactoring eviction and adding a new cache strategy based on expected read count

2025-07-28 Thread PengHui Li
wrote: > On Mon, 28 Jul 2025 at 22:06, PengHui Li wrote: > > > > Why was there such urgency in merging a proposal and implementation that > > introduces significant changes to the hot path? > > The PR https://github.com/apache/pulsar/pull/24363 has been in review > si

Re: [VOTE] PIP-430: Pulsar Broker cache improvements: refactoring eviction and adding a new cache strategy based on expected read count

2025-07-28 Thread PengHui Li
Why was there such urgency in merging a proposal and implementation that introduces significant changes to the hot path? Both the proposal and implementation PR received just one approval, despite containing a substantial number of changes: +2,315 / −1,450 lines. Since that initial approval, 11 ad

Re: [VOTE] PIP-430: Pulsar Broker cache improvements: refactoring eviction and adding a new cache strategy based on expected read count

2025-07-25 Thread PengHui Li
The proposal looks good to me. I noticed the PR will change the existing RangeEntryCacheImpl to ship this improvement. Is it better to have a new Class name and make it configurable? The existing RangeEntryCacheImpl has been used for many years, we'd better consider a way to roll out the improveme

Re: [DISCUSS] Pulsar releases 3.0.13, 3.3.8 and 4.0.6

2025-07-17 Thread PengHui Li
+1 Thanks for driving the release. Regards, Penghui On Thu, Jul 17, 2025 at 9:33 AM Lari Hotari wrote: > Hi all, > > I'd like to discuss initiating the next set of Pulsar maintenance > releases 3.0.13, 3.3.8 and 4.0.6. > The previous releases were initiated on May-20 and completed on May-23. >

Re: [VOTE] PIP-429: Optimize Handling of Compacted Last Entry by Skipping Payload Buffer Parsing

2025-07-15 Thread PengHui Li
+1 (binding) Regards, Penghui On Tue, Jul 15, 2025 at 1:06 AM Zike Yang wrote: > +1 (binding) > > BR, > Zike Yang > > On Tue, Jul 15, 2025 at 10:02 AM Tao Jiuming wrote: > > > > +1 nonbinding > > > > guo jiwei 于2025年7月14日 周一12:32写道: > > > > > +1 binding > > > > > > > > > Regards > > > Jiwei Gu

Re: [Vote] PIP-433: Optimize the conflicts of the replication and automatic creation mechanisms, including the automatic creation of topics and schemas

2025-07-15 Thread PengHui Li
+1 (binding) The proposal looks to me. Thanks for driving the fix to stabilize geo-replication. Regards, Penghui On Wed, Jul 9, 2025 at 8:02 PM Yubiao Feng wrote: > Hi all > > I want to start a vote on PIP-433: Optimize the conflicts of the > replication and automatic creation mechanisms, incl

Re: [VOTE] PIP-432: Add isEncrypted field to EncryptionContext

2025-07-14 Thread PengHui Li
wrote: > +1 binding > > Thanks, > Zixuan > > PengHui Li 于2025年7月10日周四 22:45写道: > > > Hi Team, > > > > This is the official VOTE thread for PIP-432. > > - Discuss thread: > > https://lists.apache.org/thread/sfcc902hwlgwg21ttwkrsyx3ogt8hzon > > -

[VOTE] PIP-432: Add isEncrypted field to EncryptionContext

2025-07-10 Thread PengHui Li
Hi Team, This is the official VOTE thread for PIP-432. - Discuss thread: https://lists.apache.org/thread/sfcc902hwlgwg21ttwkrsyx3ogt8hzon - Proposal link: https://github.com/apache/pulsar/blob/b212cb3ea93c98f179e19e6aef13e52bec55d4d5/pip/pip-432%20Add%20isEncrypted%20field%20to%20EncryptionContext

Re: [VOTE] PIP-431: Add Creation and Last Publish Timestamps to Topic Stats

2025-07-03 Thread PengHui Li
wrote: > > > > +1 (binding) > > > > On Thu, Jul 3, 2025 at 1:13 PM Yubiao Feng > > wrote: > > > > > +1 (binding) > > > > > > Thanks > > > Yubiao Feng > > > > > > On Wed, Jul 2, 2025 at 12:21 AM PengHui Li w

[DISCUSS] PIP-432: Add isEncrypted field to EncryptionContext

2025-07-03 Thread PengHui Li
Hi All, I have drafted a proposal to add `isEncrypted` field to EncryptionContext, which will involve a new public API change. *Motivation:* Applications using Pulsar's encryption feature with `ConsumerCryptoFailureAction.CONSUME` need to determine whether received messages were successfully dec

Re: [VOTE] PIP-421: Require Java 17 as the minimum for Pulsar Java client SDK

2025-07-01 Thread PengHui Li
+1 (binding) Regards, Penghui On Sat, Jun 21, 2025 at 4:42 AM Yunze Xu wrote: > +1 (binding) > > Thanks, > Yunze > > On Sat, Jun 21, 2025 at 6:09 PM Tao Jiuming wrote: > > > > +1 nonbinding > > > > Zixuan Liu 于2025年6月20日 周五18:19写道: > > > > > +1(binding) > > > > > > Thanks, > > > Zixuan > > > >

[VOTE] PIP-431: Add Creation and Last Publish Timestamps to Topic Stats

2025-07-01 Thread PengHui Li
Hi Team, This is the official VOTE thread for PIP-431. - Discuss thread: https://lists.apache.org/thread/mmn3hqrgn5rztdbo78prpqkc5mt3sr26 - Proposal link: https://github.com/apache/pulsar/pull/24469 The vote will stay open for at least 48 hours. Thanks, Penghui

Re: [DISCUSS] PIP-431: Add Creation and Last Publish Timestamps to Topic Stats

2025-07-01 Thread PengHui Li
Thanks for all your feedback. I will start the official vote thread. Regards, Penghui On Mon, Jun 30, 2025 at 7:51 AM Enrico Olivelli wrote: > Very useful > > +1 > > Enrico >

[DISCUSS] PIP-431: Add Creation and Last Publish Timestamps to Topic Stats

2025-06-26 Thread PengHui Li
Hi All, I have drafted a propoal to enhance topic observability by adding topicCreationTimeStamp and lastPublishTimeStamp to the topic stats API. *Motivation:* Currently, it is difficult to programmatically determine a topic's age or its most recent message activity. This hinders essential operat

Re: [VOTE] PIP-427: Align 'set-persistence' default for mark-delete rate with broker config

2025-06-25 Thread PengHui Li
Jun 21, 2025 at 3:40 AM PengHui Li wrote: > > > Hi all, > > > > This is the official VOTE thread for PIP-427 > > > > - Discuss thread: > > https://lists.apache.org/thread/j9vx6zkkgnz08sfgp14swylb8wv6djzs > > - Proposal link: https://github.com/apache/pu

Re: [DISCUSS]PIP-417: Provide ability for Pulsar clients to integrate with third-party schema registry service

2025-06-25 Thread PengHui Li
at 6:58 PM SiNan Liu wrote: > I don't seem to have seen any description of the relevant behaviour of > admin api. > > What should we do when calling pulsar-admin schemas get . > > > Thanks, > sinan > > > PengHui Li 于2025年6月24日 周二05:02写道: > > > Hi R

Re: [DISCUSS]PIP-417: Provide ability for Pulsar clients to integrate with third-party schema registry service

2025-06-23 Thread PengHui Li
Hi Ran, Thanks for adding the compatibility explanation and the new schema type. The proposal looks good to me. Regards, Penghui On Tue, Jun 10, 2025 at 2:47 AM Ran Gao wrote: > Thanks for the suggestions, I'll add them to the PIP. > > Thanks, > Ran Gao > > On 2025/06

[VOTE] PIP-427: Align 'set-persistence' default for mark-delete rate with broker config

2025-06-20 Thread PengHui Li
Hi all, This is the official VOTE thread for PIP-427 - Discuss thread: https://lists.apache.org/thread/j9vx6zkkgnz08sfgp14swylb8wv6djzs - Proposal link: https://github.com/apache/pulsar/pull/24425 The vote will stay open for at least 48 hours. Thanks, Penghui

Re: [DISCUSS]PIP-426: Enhanced Consumer Throttling and Unacknowledged Message Tracking for Exclusive and Failover Subscriptions

2025-06-20 Thread PengHui Li
; In conclution, I want to pickup the origin idea. If you have good idea > please take no hesitate to share it to me. I have been blocked here for > days. > > Regards, > Minjian > > PengHui Li 于2025年6月17日周二 06:23写道: > > > Hi Minjian, > > > > > Is it

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread PengHui Li
All the tests get passed and I have merged the PR Thanks Penghui On Wed, Jun 18, 2025 at 7:40 PM PengHui Li wrote: > Here is the PR https://github.com/apache/pulsar/pull/24429 to > revert https://github.com/apache/pulsar/pull/23611 and a related PR > > Thanks, > Penghui >

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread PengHui Li
> > On 2025/06/19 00:36:18 PengHui Li wrote: > > > the main problem is that this kind of optimization should never have > been > > cherry-picked into a stable branch. > > > > > We should be way more strict in only backporting bug-fixes / > > security-f

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread PengHui Li
eng wrote: > > > Hi Penghui, > > Thanks for your reply and the evidence provided. We can fix this problem > > by improving the implementation of method `getNumberOfDelayedMessages()`, > > which is a simple patch. I can help to do this. > > > > thanks, &g

Re: [DISCUSS] PIP-423: Add Support for Cancelling Individual Delayed Messages

2025-06-18 Thread PengHui Li
- Set `numMessages` to the size of `messageIds`, if this value is not equal > to the size of `messageIds`, return an error? > > I think setting `numMessages` to -1 is a good way to handle this. > > > Thanks, > sinan > > > PengHui Li 于2025年6月17日周二 02:53写道: > > > S

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread PengHui Li
terate the map defined in InMemoryDelayedDeliveryTracker ``` protected final Long2ObjectSortedMap> delayedMessageMap = new Long2ObjectAVLTreeMap<>(); ``` Regards Penghui On Wed, Jun 18, 2025 at 4:01 PM WenZhi Feng wrote: > -1 until much clearer proof is shown. > >

[DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread PengHui Li
Hi team, I am writing to propose an urgent revert of PR #23611 - https://github.com/apache/pulsar/pull/23611 *Reason for Revert:* This PR has introduced a significant performance regression in the Pulsar broker. The attached flame graph visually demonstrates increased CPU utilization and time s

[DISCUSS] PIP-427: Align 'set-persistence' default for mark-delete rate with broker config

2025-06-17 Thread PengHui Li
Hi everyone, I would like to start a discussion on a proposal to improve the default behavior of the pulsar-admin namespaces set-persistence command. *The Problem:* Currently, if an operator uses set-persistence to change a namespace policy, but omits the --ml-mark-delete-max-rate flag, the comm

Re: [DISCUSS]PIP-426: Enhanced Consumer Throttling and Unacknowledged Message Tracking for Exclusive and Failover Subscriptions

2025-06-16 Thread PengHui Li
ught from the root like this. Since there isn't > > a real-world scenarios to add flow permit to exclusive or failover > > subscription, we reach an agreement that it's useless. Is it still need a > > pip if we fix the origin isue in a lightweight way which just calculated

Re: [VOTE] PIP-418: Determine the behaviors for components that rely on BookKeeper when BookKeeper is not used

2025-06-16 Thread PengHui Li
Hi Yunze, Thanks for driving this proposal to clarify and address several unclear behaviors in non-BookKeeper-based storage. The motivation and goals look solid to me. I’ve left a few minor comments regarding some of the implementation details. Regards, Penghui On Tue, Jun 10, 2025 at 9:49 PM Y

Re: [VOTE] PIP-414: Enforce topic consistency check

2025-06-16 Thread PengHui Li
Hi Zixuan, Thanks for driving the proposal! I believe the second rule you’re proposing is already present on the master branch: • Partitioned topic (e.g., -partition-0) with missing metadata → reject the request. Or perhaps I missed something. I’ve left a few comments on the PR — could you take

Re: [DISCUSS] PIP-423: Add Support for Cancelling Individual Delayed Messages

2025-06-16 Thread PengHui Li
Since we already have an existing skipMessages API in the admin interface, could we consider simply adding a parameter (e.g., a list of message IDs) to support this use case? In my opinion, extending skipMessages is more appropriate than using acknowledge, as the messages being “canceled” haven’t

Re: [DISCUSS]PIP-426: Enhanced Consumer Throttling and Unacknowledged Message Tracking for Exclusive and Failover Subscriptions

2025-06-13 Thread PengHui Li
Hi Minjian, Thanks for sharing the proposal. Sharing my thoughts here: The maximum unacknowledged message limitation is crucial for consumer load balancing and managing broker resources in Pulsar's Shared and Key_Shared subscriptions: Consumer Load Balancing: The limit prevents any single consum

Re: [VOTE] PIP-422 Support global topic-level policy: replicated clusters and new API to delete topic-level policies

2025-06-05 Thread PengHui Li
+1, I just left a few minor comments on the PIP PR. Thanks, Penghui On Wed, Jun 4, 2025 at 9:24 PM Yubiao Feng wrote: > Hi all > > I want to start a vote on PIP-422: Support global topic-level policy: > replicated clusters and new API to delete topic-level policies > > Proposal link: https://gi

Re: [DISCUSS] PIP-421: Require Java 17 as the minimum for Pulsar Java client SDK

2025-06-02 Thread PengHui Li
+1 - Penghui On Fri, May 30, 2025 at 9:05 AM Tao Jiuming wrote: > great job, LGTM > > > Lari Hotari 于2025年5月30日 周五23:14写道: > > > sounds good to me. As you mentioned, Java 8 users can stay on 4.0.x, so > > that support isn't going away anytime soon. (4.0.x security support is in > > our plans un

Re: [DISCUSS]PIP-417: Provide ability for Pulsar clients to integrate with third-party schema registry service

2025-06-02 Thread PengHui Li
Thanks for the proposal. The motivation looks good to me, users can connect to their preferred or customized schema registry with this proposal, which can get rid of the limitation from the Pulsar built-in schema registry. I have a few questions about the migration or compatibility. - For a topi

Re: [VOTE] Accept BifroMQ into the Apache Incubator

2025-04-14 Thread Penghui Li
+1 (binding) Penghui Li On 2025/04/11 03:37:02 Willem Jiang wrote: > Hi everyone, > > I want to call a VOTE to accept BifroMQ into the Apache Incubator. > The proposal is: > https://cwiki.apache.org/confluence/display/INCUBATOR/BifroMQ+Proposal > > And th

Re: [VOTE] Release Apache Pulsar 4.0.4 based on 4.0.4-candidate-1

2025-04-10 Thread PengHui Li
+1 (binding) - Built from source - Checked the signatures of the source and binary release artifacts - Ran pulsar standalone - Checked producer and consumer - Verified the Cassandra connector - Verified the Stateful function -Penghui On Tue, Apr 8, 2025 at 7:09 AM Lari Hotari wrote: > +1 (bind

Re: [VOTE] Release Apache Pulsar 3.0.11 based on 3.0.11-candidate-1

2025-04-08 Thread PengHui Li
+1 (binding) - Built from source - Checked the signatures of the source and binary release artifacts - Ran pulsar standalone - Checked producer and consumer - Verified the Cassandra connector - Verified the Stateful function -Penghui On Tue, Apr 8, 2025 at 7:10 AM Lari Hotari wrote: > +1 (bind

Re: [VOTE] Release Apache Pulsar 3.3.6 based on 3.3.6-candidate-1

2025-04-08 Thread PengHui Li
+1 (binding) - Built from source - Checked the signatures of the source and binary release artifacts - Ran pulsar standalone - Checked producer and consumer - Verified the Cassandra connector - Verified the Stateful function -Penghui On Tue, Apr 8, 2025 at 7:10 AM Lari Hotari wrote: > +1 (bind

Re: [VOTE] PIP-412: Support setting messagePayloadProcessor in Pulsar Functions and Sinks

2025-04-04 Thread PengHui Li
+1 (binding) - Penghui On Tue, Apr 1, 2025 at 2:10 AM Pengcheng Jiang wrote: > Hi, All. > > I would like to start the voting thread for PIP-412: Support setting > messagePayloadProcessor in Pulsar Functions and Sinks > > Refers: > > - PIP: https://github.com/apache/pulsar/pull/24105 > - Discus

Re: [DICUSS] Cherry-pick PIP-406 to branch-4.0

2025-03-24 Thread PengHui Li
+1 -Penghui On Sun, Mar 23, 2025 at 11:43 PM Lari Hotari wrote: > +1 > > > -Lari > > On Mon, 24 Mar 2025, 3.22 Baodi Shi, wrote: > > > hi, all. > > > > I would like cherry-pick PIP-406 to branch-4.0. > > > > This add new metric for the RateLimit. but doesn't introduce any > > compatibility iss

Re: [VOTE] PIP-404: Introduce per-ledger properties

2025-03-04 Thread PengHui Li
+1 binding - Penghui On Mon, Mar 3, 2025 at 2:28 AM Tao Jiuming wrote: > bump > > Tao Jiuming 于2025年2月11日周二 14:37写道: > > > Hi all, > > > > I open PIP-404 to introduce per ledger properties, which will add a > > `properties` field to `LedgerInfo` to store extra properties for every > > `Ledger`

Re: [DISCUSS][Cherry-pick] #23757 makes replicateSubscriptionState nullable

2024-12-24 Thread PengHui Li
+1 Penghui On Mon, Dec 23, 2024 at 23:07 Zixuan Liu wrote: > Hi all, > > #23757 makes replicateSubscriptionState nullable, which is important for > supporting subscription replication on the namespace and topic levels. > > So I want to cherry-pick #23757 to the branch-3.0, branch-3.3, branch-4.

Re: [DISCUSS] PIP-398: Subscription replication on the namespace and topic levels

2024-12-23 Thread PengHui Li
; propose ignoring the consumer configuration, ensuring that replication is > controlled by the namespace or topic-level settings instead. > > Thanks, > Zixuan > > PengHui Li 于2024年12月24日周二 09:01写道: > > > Hi Zixuan, > > > > Thanks for bringing the d

Re: [DISCUSS] PIP-398: Subscription replication on the namespace and topic levels

2024-12-23 Thread PengHui Li
Hi Zixuan, Thanks for bringing the discussion here. After going through the context and discussions from https://github.com/apache/pulsar/pull/23770 and https://github.com/apache/pulsar/pull/23769. It looks like we can improve the option "replicateSubscriptionState" to make it only work for the ne

Re: [DISCUSS] Add an optional config to disable the feature that compresses cursor metadata, which contributed by #9292

2024-12-23 Thread PengHui Li
Hi Yubiao, Thanks for driving this fix. Based on the LTS version strategy, user should able to upgrade from 3.0 to 4.0 without and compatibility issues and downgrade from 4.0 to 3.0 without any compatibility issues. https://pulsar.apache.org/contribute/release-policy/#compatibility-between-releas

Re: [DISCUSS] PIP-391: Enable batch index ACK by default

2024-11-07 Thread PengHui Li
+1 I also had many questions during the discussion with Pulsar users. It's not easy to understand why their consumers get a lot of duplicated messages with batch messages without any consumer or broker restarts. Regards Penghui On Wed, Nov 6, 2024 at 4:45 AM Yunze Xu wrote: > Hi all, > > I wro

Re: [VOTE] Release Apache Pulsar 4.0.0 based on 4.0.0-candidate-1

2024-10-20 Thread PengHui Li
+1 (binding) - Verified the checksums and signatures - Build from source - Passed our internal tests Regards, Penghui On Thu, Oct 17, 2024 at 10:08 AM Nicolò Boschi wrote: > +1 (binding) > > - Verified the checksums and signatures > - Built sources with JDK21 > - Ran tests using the provided d

Re: [VOTE] Release Apache Pulsar 3.3.2 based on 3.3.2-candidate-1

2024-10-04 Thread PengHui Li
+1 (binding) - Checked the signature of the binary release artifacts - Start Pulsar standalone - Verified Produce and Consume - Verified Pulsar Function and Stateful Function - Verified the Cassandra connector Regards, Penghui On Fri, Oct 4, 2024 at 9:55 AM Lari Hotari wrote: > Hello Apache Pu

Re: [VOTE] Release Apache Pulsar 3.0.7 based on 3.0.7-candidate-1

2024-10-04 Thread PengHui Li
+1 (binding) - Checked the signature of the binary release artifacts - Start Pulsar standalone - Verified Produce and Consume - Verified Pulsar Function and Stateful Function - Verified the Cassandra connector Regards, Penghui On Fri, Oct 4, 2024 at 8:37 AM Lari Hotari wrote: > Hello Apache Pu

Re: [VOTE] PIP-384: ManagedLedger interface decoupling

2024-10-02 Thread PengHui Li
+1 (binding) Regards, Penghui On Tue, Oct 1, 2024 at 11:36 PM Enrico Olivelli wrote: > +1 (binding) > > Enrico > > Il Mer 2 Ott 2024, 03:21 Matteo Merli ha scritto: > > > +1 > > -- > > Matteo Merli > > > > > > > > On Tue, Oct 1, 2024 at 5:03 PM Rajan Dhabalia > > wrote: > > > > > +1 (binding

Re: [VOTE] PIP-383: Support granting/revoking permissions for multiple topics

2024-09-30 Thread PengHui Li
+1 (binding) Regards, Penghui On Mon, Sep 30, 2024 at 12:23 AM Zike Yang wrote: > +1 (binding) > > BR, > Zike Yang > > On Sun, Sep 29, 2024 at 11:52 PM Lari Hotari wrote: > > > > +1 (binding) > > > > -Lari > > > > su 29. syysk. 2024 klo 13.10 guo jiwei kirjoitti: > > > > > Hi dev, > > >I

Re: [VOTE] Pulsar Client Go Release 0.14.0 Candidate 1

2024-09-27 Thread PengHui Li
+1 (binding) - Verified checksum and signatures - Tested producer and consumer Regards, Penghui On Fri, Sep 27, 2024 at 4:56 AM Yunze Xu wrote: > +1 (binding) > > - Verified checksum and signatures > - Built from source with Go 1.22 > - Ran the perf tools > > Thanks, > Yunze > > On Fri, Sep 27

Re: [DISCUSS] PIP-381: Handle large PositionInfo state

2024-09-24 Thread PengHui Li
Thanks for driving the proposal. I would like to share the related context that happened many years ago - https://lists.apache.org/thread/y0r9kk0968ydpxtf16x6ql3x6kwy7dc1 - https://lists.apache.org/thread/hfv18cg0yckt5cqd0fc66rp7tth036kf We have two major approaches: 1. Minimize the persistent

Re: [VOTE] PIP-378 Add ServiceUnitStateTableView abstraction (ExtensibleLoadMangerImpl only)

2024-09-16 Thread PengHui Li
+1 (binding) Regards, Penghui On Mon, Sep 16, 2024 at 8:17 AM Yunze Xu wrote: > +1 (binding) > > Thanks, > Yunze > > On Mon, Sep 16, 2024 at 3:06 AM Lari Hotari wrote: > > > > +1 (binding) > > > > -Lari > > > > On Sun, 15 Sept 2024 at 21:34, Heesung Sohn wrote: > > > > > > Hi all, > > > > > >

Re: [DISCUSS] PIP-379: Key_Shared Draining Hashes for Improved Message Ordering

2024-09-15 Thread PengHui Li
Hi Lari, I recommend creating a new implementation rather than directly replacing the existing one. This approach aligns with how we’ve handled several proposals in the past and allows us to maintain stability while introducing improvements - PIP-192: New Pulsar Broker Load Balancer - PIP-195: Ne

Re: [VOTE] PIP-374: Visibility of messages in receiverQueue for the consumers

2024-09-05 Thread PengHui Li
+1 binding Regards Penghui On Wed, Sep 4, 2024 at 19:55 Yunze Xu wrote: > +1 (binding) > > Thanks, > Yunze > > On Wed, Sep 4, 2024 at 2:15 PM Baodi Shi wrote: > > > > +1(binding) > > > > Thanks, > > Baodi Shi > > > > Bhat, Vinay 于2024年9月4日周三 12:22写道: > > > > > > Hi All, > > > > > > I want to

Re: [VOTE] PIP-376 Make topic policies pluggable

2024-09-04 Thread PengHui Li
+1 Thanks Penghui On Wed, Sep 4, 2024 at 20:14 Lari Hotari wrote: > +1 (binding) > > -Lari > > On 2024/09/05 02:53:22 Yunze Xu wrote: > > Hi all, > > > > I want to start a vote on PIP-376 Make topic policies pluggable. > > > > Proposal link: https://github.com/streamnative/pulsar/pull/307 > > D

Re: [DISCUSS] PIP-376 Make topic policies service pluggable

2024-09-03 Thread PengHui Li
Thanks for driving the proposal. I support this proposal and left a few comments on the PR Regards, Penghui On Tue, Sep 3, 2024 at 8:54 AM Enrico Olivelli wrote: > Nice write up ! > > I generally support this proposal, we should have clearer APIs for the > components we want to allow users to

Re: [VOTE] PIP-370: An optional flag: disable the replicators to automatically trigger topic creation

2024-08-15 Thread PengHui Li
+1 (binding) Sorry for the late response on the mailing list. Regards, Penghui On Thu, Aug 15, 2024 at 7:44 PM Yubiao Feng wrote: > The vote is approved with 4 binding votes and close now. > > Votes: > - Hang Chen (binding) > - Jiwei Guo (binding) > - Lari Hotari (bindi

Re: [VOTE] Reactive Java client for Apache Pulsar 0.5.7 Candidate 1

2024-08-14 Thread PengHui Li
+1 (binding) - Checked the signature - Verified the checksum Regards, Penghui On Wed, Aug 14, 2024 at 10:09 AM Lari Hotari wrote: > +1 (binding) > > Validated source artifacts > - checked sha512 checksum > - checked signature > > Validated binaries > - ran sample app > > -Lari > > On 2024/08/1

Re: [VOTE] PIP-370: An optional flag: disable the replicators to automatically trigger topic creation

2024-08-12 Thread PengHui Li
Hi Yubiao, Thanks for driving the improvements to Pulsar. The motivation and the high-level solution look good to me. I just left some comments on the proposal for the details. The major idea for resolving this issue is to separate the user-facing topic auto-creation and topic auto-creation by da

Re: [VOTE] Release Apache Pulsar 3.0.6 based on 3.0.6-candidate-1

2024-07-31 Thread PengHui Li
+1 (binding) - Checked the signature of the binary release artifacts - Start Pulsar standalone - Verified Produce and Consume - Verified Pulsar Function and Stateful Function - Verified the Cassandra connector - Ran the perf test with 100 topics and batch disabled Regards, Penghui On Tue, Jul 30

Re: [VOTE] Release Apache Pulsar 3.2.4 based on 3.2.4-candidate-1

2024-07-31 Thread PengHui Li
+1 (binding) - Checked the signature of the binary release artifacts - Start Pulsar standalone - Verified Produce and Consume - Verified Pulsar Function and Stateful Function - Verified the Cassandra connector - Ran the perf test with 100 topics and batch disabled Regards, Penghui On Tue, Jul 30

Re: [VOTE] Release Apache Pulsar 3.3.1 based on 3.3.1-candidate-1

2024-07-31 Thread PengHui Li
+1 (binding) - Checked the signature of the binary release artifacts - Start Pulsar standalone - Verified Produce and Consume - Verified Pulsar Function and Stateful Function - Verified the Cassandra connector - Ran the perf test with 100 topics and batch disabled Regards, Penghui On Tue, Jul 3

Re: [VOTE] PIP-366: Support to specify different config for Configuration and Local Metadata Store

2024-07-22 Thread PengHui Li
+1 (binding) Thanks for driving the proposal. Regards, Penghui On Sun, Jul 21, 2024 at 6:46 PM Kai Wang wrote: > Hi all, I want to start a vote on PIP-366: Support to specify different > config for Configuration and Local Metadata Store. > > You can find the proposal at https://github.com/apac

Re: [VOTE] Reactive Java client for Apache Pulsar 0.5.6 Candidate 1

2024-06-17 Thread PengHui Li
+1 (binding) - Verified checksum - Verified signatures Thanks, Penghui On Sun, Jun 16, 2024 at 8:29 PM Yunze Xu wrote: > +1 (binding) > > - Verified checksum and signatures > - Built from source > - Verified the binaries > > Thanks, > Yunze > > On Sun, Jun 16, 2024 at 3:23 AM Chris Bono wrote

Re: [VOTE] PIP-355: Enhancing Broker-Level Metrics for Pulsar

2024-06-10 Thread PengHui Li
+1 (binding) Regards, Penghui On Sat, Jun 1, 2024 at 5:05 AM Dragos Misca wrote: > +1 non-binding > > Thank you, > Dragos > > > On May 30, 2024, at 5:47 PM, Hang Chen wrote: > > > > Hi, all > > > > I would like to start the voting thread for PIP-355: Enhancing > > Broker-Level Metrics for Puls

Re: [VOTE] PIP-357: Correct the conf name in load balance module.

2024-06-06 Thread PengHui Li
+1 (binding) Regards, Penghui On Thu, Jun 6, 2024 at 3:25 PM thetumbled wrote: > The vote is approved with 3 binding votes and close now. > Votes: > - Kai Wang(non-binding) > - Yunze Xu(binding) > - guo jiwei(binding) > - Yubiao Feng(binding) > > Thank you all for verifying and voting! > Wenzhi

Re: [VOTE] PIP-357: Correct the conf name in load balance module.

2024-06-05 Thread PengHui Li
Hi Wenzhi, Thanks for driving the proposal. The old configuration name should not be removed directly. It might break users when they upgrade to the new cluster. Instead, we can move it to the `Deprecated settings` section and use `-1` as the default value. If the user sets it to a positive numbe

Re: [VOTE] Release Apache Pulsar 3.3.0 based on 3.3.0-candidate-3

2024-05-28 Thread PengHui Li
+1 (binding) - Build from source - Checked the signatures - Run standalone - Verified the Cassandra connector - Verified the Stateful function - Run pulsar-perf with 100 topics and batch disabled Regards, Penghui On Wed, May 29, 2024 at 8:32 AM PengHui Li wrote: > Sorry for the confus

Re: [VOTE] Release Apache Pulsar 3.3.0 based on 3.3.0-candidate-3

2024-05-28 Thread PengHui Li
Sorry for the confusion. After checking more details, the fix makes more sense. For more cases, user think it's a bug if you can grant permission to a non-existent topic. I will verify this release today. Thanks, Penghui On Tue, May 28, 2024 at 4:33 PM PengHui Li wrote: > Hi Cong, &g

Re: [VOTE] Release Apache Pulsar 3.3.0 based on 3.3.0-candidate-3

2024-05-28 Thread PengHui Li
Hi Cong, Thanks for driving the release. This PR https://github.com/apache/pulsar/pull/22547 has changed the behavior of permission operations on a topic. The issue is it will break the user's case which relies on the lazy auto-creation of the topic. They can grant permission to the topic but the

Re: [VOTE] PIP-354: apply topK mechanism to ModularLoadManagerImpl

2024-05-26 Thread PengHui Li
+1 (binding) Regards, Penghui On Mon, May 27, 2024 at 10:24 AM Kai Wang wrote: > +1 (non-binding) > > Thanks, > Kai >

Re: [VOTE] Release Apache Pulsar 3.2.3 based on 3.2.3-candidate-1

2024-05-17 Thread PengHui Li
+1 (binding) - Build from the source code - Checked the signatures - Start the standalone - Run the perf tests Penghui On Wed, May 15, 2024 at 1:33 PM guo jiwei wrote: > +1 (binding) > > - Build from source > - Checked the signatures > - Start standalone > - Verified producers and consumers >

Re: [VOTE] PIP-347: add role field in consumer's stat

2024-05-14 Thread PengHui Li
+1 (binding) Regards, Penghui On Tue, May 14, 2024 at 5:50 PM Enrico Olivelli wrote: > +1 (binding) > > Enrico > > Il giorno mar 14 mag 2024 alle ore 11:31 太上玄元道君 ha > scritto: > > > +1 nonbinding > > > > Thanks, > > Tao Jiuming > > > > thetumbled 于2024年5月14日 周二17:26写道: > > > > > Hi, Pulsar Co

Re: [VOTE] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-08 Thread PengHui Li
+1 (binding) Regards, Penghui On Wed, May 8, 2024 at 6:58 PM Zixuan Liu wrote: > +1 (non-binding) > > Thanks, > Zixuan > > Yubiao Feng 于2024年5月8日周三 18:22写道: > > > +1 (binding) > > > > Thanks > > Yubiao Feng > > > > On Tue, May 7, 2024 at 11:25 AM Hang Chen wrote: > > > > > Hi guys, > > >

Re: [VOTE] PIP-348: Trigger offload on topic load stage

2024-05-08 Thread PengHui Li
+1 (binding) Penghui On Wed, May 8, 2024 at 8:27 PM Enrico Olivelli wrote: > +1 (binding) > > Enrico > > Il giorno mer 8 mag 2024 alle ore 12:51 Zike Yang ha > scritto: > > > +1 (binding) > > > > Thanks, > > Zike Yang > > > > On Wed, May 8, 2024 at 6:22 PM Yubiao Feng > > wrote: > > > > > > +

Re: [DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-06 Thread PengHui Li
For the backlog quota check, I think we also need the same capacity. For configurable. I think the reason is users can have their plugins running with the broker which relies on the Pulsar topic. They don't want the application to change the TTL or backlog policies for some subscription/cursor. Bu

Re: [DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-05 Thread PengHui Li
LGTM, Regards, Penghui On Mon, May 6, 2024 at 2:02 PM Lari Hotari wrote: > LGTM, very useful. Thanks for driving this. > > -Lari > > On 2024/05/04 16:01:41 Hang Chen wrote: > > Hi guys, > > I proposed a new proposal to improve the TTL impact on system > > cursors. Please help take a look, t

Re: [DISCUSS] Apache Pulsar 3.3.0 release

2024-04-28 Thread PengHui Li
+1 Thanks for driving the release. Penghui On Sun, Apr 28, 2024 at 8:17 PM Cong Zhao wrote: > Hi community, > It has been more than three months since the release of 3.2.0. we now > have more than 280 commits > < > https://github.com/apache/pulsar/pulls?q=is%3Apr+milestone%3A3.3.0+is%3Amerged+

[DISCUSS] Cherry-pick topic load failed count metrics to release branches

2024-04-22 Thread PengHui Li
Hi, all I would like to start a discussion to cherry-pick https://github.com/apache/pulsar/pull/19236 to the release branches - branch-3.0 - branch-2.11 - branch-2.10 The topic load is a critical operation in Pulsar. If the topic not able to be loaded, the producer or consumer will not able to c

[ANNOUNCE] Zike Yang as a new PMC member in Apache Pulsar

2024-04-11 Thread PengHui Li
The Apache Pulsar Project Management Committee (PMC) has invited Zike Yang https://github.com/RobertIndie to join the PMC, and we are pleased to announce that he has accepted. Zike Yang is actively driving the Golang client release, contributing to multiple Pulsar repos, Golang client, CPP Client,

[ANNOUNCE] Baodi Shi as a new PMC member in Apache Pulsar

2024-04-11 Thread PengHui Li
The Apache Pulsar Project Management Committee (PMC) has invited Baodi Shi https://github.com/shibd to join the PMC, and we are pleased to announce that he has accepted. Baodi Shi is actively driving the NodeJS client release, contributing to multiple Pulsar repos, Nodejs client, CPP Client, Pytho

Re: [DISCUSS] cherry-pick #22034 Create new ledger after the current ledger is closed

2024-04-11 Thread PengHui Li
It sounds good to me. Regards, Penghui On Thu, Apr 11, 2024 at 9:05 PM Baodi Shi wrote: > Hi, xiangying. > > I agree with cherry-picking the historical branch. This change in behavior > is as expected, and it can indeed be understood as a bug. > > We can cherry-pick them all together after fixi

Re: [VOTE] Release Apache Pulsar 3.2.2 based on 3.2.2-candidate-1

2024-04-01 Thread PengHui Li
+1 (binding) - Build from source - Checked the signatures - Start standalone - Verified producers and consumers - Verified Cassandra connect - Verified Stateful function Regards, Penghui On Mon, Apr 1, 2024 at 3:49 PM guo jiwei wrote: > +1 (binding) > > - Built from source > - Checked the sign

Re: [VOTE] Pulsar Client C++ Release 3.5.1 Candidate 1

2024-03-31 Thread PengHui Li
+1 (binding) - Verified the signatures - Built from source on macOS m2 pro - Ran the producer and consumer Regards, Penghui On Mon, Apr 1, 2024 at 9:45 AM guo jiwei wrote: > +1 (binding) > > - Verified checksum and signatures > - Built from source on macOS m1 > - Ran the tests > > Regards > Ji

[DISCUSS] cherry-pick #21816 resolving the metrics missing issue for time-based backlog

2024-03-25 Thread PengHui Li
Hi all, I want to start a discussion to cherry-pick #21816[0] to release branches. This PR added the metrics for the time-based backlog, which is introduced in 2.8.0 [1]. However, there has always been a lack of relevant indicators to assist users in daily monitoring work. It becomes a blocker for

Re: [DISCUSS] Broken builds and CI Failures in Maintenance Branches; improving maintenance strategy to address root causes

2024-03-25 Thread PengHui Li
Hi, Lari Thanks for driving the discussion, and I agree that the cherry-picking is the pain especially when we need to maintain old branches for a long time. Frankly, my first impression is to target the bug fix to branch-3.0, but the features and improvements to the master branch will burden the

Re: [VOTE] PIP-345: Optimize finding message by timestamp

2024-03-25 Thread PengHui Li
er add entries complete, add a index to `ManagedLedgerIndex` and > store the index to ML. What do you think? > > Thanks, > Tao Jiuming > > > > PengHui Li 于2024年3月25日周一 15:17写道: > > > Hi, Jiuming > > > > I'm sorry for not getting back to you sooner. &g

Re: [VOTE] PIP-344: Correct the behavior of the public API pulsarClient.getPartitionsForTopic(topicName)

2024-03-25 Thread PengHui Li
Hi, Yubiao It's better to list the names of the 3 bindings. Thanks, Penghui On Mon, Mar 25, 2024 at 4:58 PM Yubiao Feng wrote: > Close the vote with 3(binding). > > Thanks > Yubiao Feng > > On Sat, Mar 16, 2024 at 6:28 AM Yubiao Feng > wrote: > > > Hi All > > > > This thread is to start a vo

Re: [RESULT] [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-25 Thread PengHui Li
on > * PengHui > * Matteo > > Non-Binding +1s: > * Dao Jun > * Apurva > * Asaf > * Zixuan > > > Thanks, > Matteo > > > -- > Matteo Merli > > > > On Thu, Mar 14, 2024 at 11:54 PM Zixuan Liu wrote: > > > +1 (non-binding) > &g

Re: [VOTE] Pulsar Client Python Release 3.5.0 Candidate 2

2024-03-25 Thread PengHui Li
+1 (binding) - Checked the signature - Installed the wheel on macOS with Python 3.12 - Run the consume and produce examples Regards, Penghui On Fri, Mar 22, 2024 at 11:55 PM Yunze Xu wrote: > This is the 2nd release candidate for Apache Pulsar Client Python, > version 3.5.0. > > It fixes the f

Re: Suggestions on GitHub labels and issue templates

2024-03-25 Thread PengHui Li
The labels updates: - Removed the `java` label. We only have a few legacy PRs labeled with `java`. - Changed `component/*` to `area/*` - Deprecated `question` label - Changed `PIP` to `type/PIP` - Changed `flaky-test` to `type/flaky-test` On Mon, Mar 25, 2024 at 3:17 PM PengHui Li wrote: >

  1   2   3   4   5   6   7   8   9   10   >