Hi Zixuan,

Thanks for bringing the discussion here. After going through the context
and discussions
from https://github.com/apache/pulsar/pull/23770 and
https://github.com/apache/pulsar/pull/23769.
It looks like we can improve the option "replicateSubscriptionState" to
make it only work for the newly created subscription.
The reason is we don't have consumer-level control of the replicate
subscription state, it's subscription-level control.

With this solution, you can enable or disable the replicate subscription
state with Admin API for the existing topics/subscriptions.
And we also don't need to introduce another Admin API mode to replicate the
subscription state on the cluster level which ignores
the configurations from the consumer.

Regards,
Penghui

On Mon, Dec 23, 2024 at 12:20 AM Lari Hotari <lhot...@apache.org> wrote:

> This PIP is very useful.
>
> One weakness of this PIP is that it would require client upgrades before it
> would be effective.
> To achieve the desired outcome, I think it would be useful to have a way to
> override the consumer-side setting and enable subscription replication for
> all topics in a namespace, regardless of the consumer-side setting.
>
> There's a separate recent PR about enabling subscription replication
> globally at the broker level, https://github.com/apache/pulsar/pull/23769.
> I wonder if there's a need for a global broker-level configuration? Zixuan,
> would you mind reviewing that PR?
> Since this recent PR #23769 is in the same area, I think it would make
> sense to combine the work in a single PIP to ensure that we achieve
> consistency across the changes.
>
> -Lari
>
> On Mon, 23 Dec 2024 at 10:08, Zixuan Liu <zix...@apache.org> wrote:
>
> > Hi, Pulsar community,
> >
> > Subscription replication is an important feature in the failover
> scenario,
> > I made a PIP to add the subscription replication feature on the namespace
> > and topic levels.
> >
> > PIP: https://github.com/apache/pulsar/pull/23770
> >
> > Thanks,
> > Zixuan
> >
>

Reply via email to