Hi!
On Sun, May 25, 2025 at 5:10 PM Sergey Vojtovich wrote:
>> If possible, I suggest we use --metadata-locks-instances=1 to disable
>> the fast lanes. (Assuming there is no speedup or other gain by using
>> 1 instance of fast lanes). If we do this, we should allow values
>> 1-256 for the vari
Hi!
Review of
commit 7919442a866491d78c342c809f080c3fb006d626 (HEAD -> svoj-mdl)
MDEV-19749 - MDL scalability regression after backup locks
+ --metadata-locks-instances=#
+ Number of fast lanes to create for metadata locks. Can be
+ used to improve DML scalability by eliminating
+ MDL_lock::r
Hi!
Review of
MDEV-33675 Assertion(reclength < vreclength) in setup_vcols_for_repair()
Thanks for the clear explanation of the problem.
Please add that this problem only occurs with tables where there is no
data for the main record outside of the null bits.
As slightly smaller patch is (same id
Review of:
MDEV-36213 Doubled memory usage (11.4.4 <-> 11.4.5)
Fixing the code adding MySQL _0900_ collations as _uca1400_ aliases
not to perform deep initialization of the corresponding _uca1400_
collations.
-
> b. it introduced cyclic dependency between /mysys and /strings
> - /mysys/
Hi!
On Mon, Apr 14, 2025 at 9:51 AM Marko Mäkelä wrote:
>
> Hi Monty,
>
> Thank you for the review. I will revise
> https://github.com/MariaDB/server/pull/3966/ accordingly.
>
> When it comes to the C++11 noexcept keyword, I believe that there was
> a reason why -fno-exceptions was included in al
Hi!
Review of:
commit 5b0b5f529f760021e97bc20f33cb33863bf2
Author: Marko Mäkelä
Date: Fri Apr 11 14:43:07 2025 +0300
MDEV-19749 MDL scalability regression after backup locks
diff --git a/sql/backup.cc b/sql/backup.cc
index f634a11f867..a312904dc70 100644
--- a/sql/backup.cc
+++ b/sql
Review of MDEV-34857: Implement --slave-abort-blocking-timeout
If a slave replicating an event has waited for more than
@@slave_abort_blocking_timeout for a conflicting metadata lock held by a
non-replication thread, the blocking query is killed to allow replication to
proceed and not be blocked i
Hi!
Review of MDEV-31273: Precompute binlog checksums
On Fri, Aug 25, 2023 at 10:16 AM Kristian Nielsen
wrote:
>
> Compute binlog checksums (when enabled) already when writing events
> into the statement or transaction caches, where before it was done
> when the caches are copied to the real bin
Hi!
On Fri, Aug 25, 2023 at 10:16 AM Kristian Nielsen
wrote:
>
> Preparatory patch for pre-computing binlog checksums outside of holding
> LOCK_log.
>
> The existing code for MYSQL_BIN_LOG::write_cache() was needlessly complex
> and very hard to understand and modify for handling the new case wh
