Re: RFR: 8343956: Focus delegation API

2025-08-02 Thread Michael Strauß
On Fri, 1 Aug 2025 21:18:53 GMT, Andy Goryachev wrote: > There is more: I think the kind of issues we see stem from the sub-optimal > event dispatching mechanism in JavaFX, the weirdest part of which is creating > multiple event instances for the same event. The key events should be > targeti

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale [v4]

2025-07-31 Thread Michael Strauß
On Thu, 31 Jul 2025 16:02:05 GMT, Andy Goryachev wrote: >> This is a very localized fix for the issue described in >> https://bugs.openjdk.org/browse/JDK-8364049 which resulted from comparing >> snapped and non-snapped values. The issue seems to happen only with >> fractional scale, that is,

Re: RFR: 8343956: Focus delegation API [v3]

2025-07-30 Thread Michael Strauß
On Thu, 17 Jul 2025 05:18:28 GMT, Michael Strauß wrote: >> Implementation of [focus >> delegation](https://gist.github.com/mstr2/44d94f0bd5b5c030e26a47103063aa29). > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last r

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale [v3]

2025-07-30 Thread Michael Strauß
On Wed, 30 Jul 2025 18:52:20 GMT, Andy Goryachev wrote: >> This is a very localized fix for the issue described in >> https://bugs.openjdk.org/browse/JDK-8364049 which resulted from comparing >> snapped and non-snapped values. The issue seems to happen only with >> fractional scale, that is,

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale [v3]

2025-07-30 Thread Michael Strauß
On Wed, 30 Jul 2025 18:52:20 GMT, Andy Goryachev wrote: >> This is a very localized fix for the issue described in >> https://bugs.openjdk.org/browse/JDK-8364049 which resulted from comparing >> snapped and non-snapped values. The issue seems to happen only with >> fractional scale, that is,

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale [v2]

2025-07-30 Thread Michael Strauß
On Wed, 30 Jul 2025 17:42:54 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ToolBarSkin.java >> line 692: >> >>> 690: */ >>> 691: private int getOverflowNodeIndex(double length) { >>> 692: if (getSkinnable().getOrientation() == Ori

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale [v2]

2025-07-30 Thread Michael Strauß
On Tue, 29 Jul 2025 18:46:44 GMT, Andy Goryachev wrote: >> This is a very localized fix for the issue described in >> https://bugs.openjdk.org/browse/JDK-8364049 which resulted from comparing >> snapped and non-snapped values. The issue seems to happen only with >> fractional scale, that is,

Re: RFR: 8364088: ToolBarSkin: NPE in select()

2025-07-29 Thread Michael Strauß
On Fri, 25 Jul 2025 22:32:36 GMT, Andy Goryachev wrote: > Fixed an NPE in the ToolBar, looks like a corner case. Marked as reviewed by mstrauss (Reviewer). - PR Review: https://git.openjdk.org/jfx/pull/1857#pullrequestreview-3068567204

Re: RFR: 8358450: Viewport characteristics media features [v4]

2025-07-27 Thread Michael Strauß
lone` (note: `browser` and > `minimal-ui` are not supported in JavaFX) Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional

Re: RFR: 8358820: Allow interpolation outside of range [0,1] [v3]

2025-07-27 Thread Michael Strauß
> 3. `SplineInterpolator` now accepts control points with any Y coordinate. > > Here's how the result looks like for the previously unrepresentable > interpolation function `cubic-bezier(0.34, 2.2, 0.64, 1)`: > src="https://github.com/user-attachments/assets/72c10d0d-71b4-4bb

Re: RFR: 8362091: Window title bar should reflect scene color scheme [v2]

2025-07-27 Thread Michael Strauß
ay to do that). > Depending on how you look at it, this is either a bug fix or an enhancement. Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' into feature/dark-window

[jfx25] Integrated: 8359601: Fix window button states of an extended stage

2025-07-26 Thread Michael Strauß
On Fri, 25 Jul 2025 13:10:03 GMT, Michael Strauß wrote: > 8359601: Fix window button states of an extended stage This pull request has now been integrated. Changeset: 5398b14c Author: Michael Strauß URL: https://git.openjdk.org/jfx/commit/5398b14cac39a3e7371e3f837754a399ccd8b

Re: RFR: 8364088: ToolBarSkin: NPE in select()

2025-07-25 Thread Michael Strauß
On Fri, 25 Jul 2025 22:32:36 GMT, Andy Goryachev wrote: > Fixed an NPE in the ToolBar, looks like a corner case. Is this unit-testable? - PR Comment: https://git.openjdk.org/jfx/pull/1857#issuecomment-3120984515

[jfx25] RFR: 8359601: Fix window button states of an extended stage

2025-07-25 Thread Michael Strauß
8359601: Fix window button states of an extended stage - Commit messages: - Backport bc433da812461a1c2796cdb3123f814e4ce532d5 Changes: https://git.openjdk.org/jfx/pull/1855/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1855&range=00 Issue: https://bugs.openjdk.org/brows

Integrated: 8359601: Fix window button states of an extended stage

2025-07-25 Thread Michael Strauß
On Sun, 15 Jun 2025 20:01:11 GMT, Michael Strauß wrote: > The window button states (disabled/hidden) of extended stages with a > `HeaderButtonOverlay` or custom header buttons are inconsistent with what we > would expect from the OS (Windows and Linux). To figure out what we would &g

Re: RFR: 8359601: Fix window button states of an extended stage [v6]

2025-07-24 Thread Michael Strauß
On Thu, 24 Jul 2025 21:28:43 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix resizable state of macOS window > > modules/javafx.graphics/src/main/native-gla

Re: RFR: 8359601: Fix window button states of an extended stage [v6]

2025-07-22 Thread Michael Strauß
On Sat, 21 Jun 2025 23:37:13 GMT, Michael Strauß wrote: >> The window button states (disabled/hidden) of extended stages with a >> `HeaderButtonOverlay` or custom header buttons are inconsistent with what we >> would expect from the OS (Windows and Linux). To figure

Re: RFR: 8362873: Regression in BorderPane after JDK-8350149

2025-07-22 Thread Michael Strauß
On Tue, 22 Jul 2025 00:05:35 GMT, John Hendrikx wrote: > This PR fixes a regression introduced in #1723 > > It reverts the changes made in the BorderPaneTest with new comments > explaining why the values are what they are. It only fixes the regression > that was introduced, but it can be said

Re: RFR: 8343956: Focus delegation API [v3]

2025-07-16 Thread Michael Strauß
On Mon, 14 Jul 2025 18:36:48 GMT, Martin Fox wrote: > In this PR setting hoistFocus on a control only updates the flag in the > control itself. What if the control’s skin introduces sub-nodes? I would > assume that setting hoistFocus on a control would automatically set that flag > on the cont

Re: RFR: 8343956: Focus delegation API [v3]

2025-07-16 Thread Michael Strauß
On Mon, 14 Jul 2025 18:59:49 GMT, John Hendrikx wrote: >> Yeah, I'm sure traversal is solvable, I just wanted to spend some cycles >> figuring it out. For example, would you set focusTraversable on the >> date/time control AND it's delegates? My guess is just the delegates but >> this is the s

Re: RFR: 8343956: Focus delegation API [v3]

2025-07-16 Thread Michael Strauß
> Implementation of [focus > delegation](https://gist.github.com/mstr2/44d94f0bd5b5c030e26a47103063aa29). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: Avoid variable reassignment - Changes: - all:

Re: RFR: 8343956: Focus delegation API [v2]

2025-07-16 Thread Michael Strauß
> Implementation of [focus > delegation](https://gist.github.com/mstr2/44d94f0bd5b5c030e26a47103063aa29). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: Handling of several edge cases - Changes: - all:

Re: RFR: 8358450: Viewport characteristics media features [v3]

2025-07-15 Thread Michael Strauß
lone` (note: `browser` and > `minimal-ui` are not supported in JavaFX) Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: documentation - Changes: - all: https://git.openjdk.org/jfx/pull/1844/files - new: https://

Re: RFR: 8354539: [macOS] ComboBox and Spinner disable system menu bar shortcuts [v2]

2025-07-15 Thread Michael Strauß
On Wed, 16 Jul 2025 01:40:54 GMT, John Hendrikx wrote: > Another way to look at it: do we want to outlaw what ComboBox and Spinner are > doing? It's not illegal to create a KeyEvent and fire it at a control. It's > not illegal to consume a KeyEvent that originated in Glass. Things only fail >

Re: Viewport characteristics media features

2025-07-14 Thread Michael Strauß
I assume that custom media queries would follow the same rules as custom variables. That means that a custom media query defined in a Scene stylesheet would be accessible in all Parent stylesheets. On Sun, Jul 13, 2025 at 3:46 AM Christopher Schnick wrote: > > Yeah that would definitely improve

Re: RFR: 8360886: Cmd + plus shortcut does not work reliably [v2]

2025-07-14 Thread Michael Strauß
On Mon, 7 Jul 2025 16:59:13 GMT, Martin Fox wrote: >> The Mac platform code figures out where characters are on the keyboard as >> the user types. The character table is updated on every key press by calling >> a registerKeyEvent: in GlassApplication. This character table is used to >> resolve

Re: Pluggable image loading and frame size

2025-07-14 Thread Michael Strauß
A JavaFX Image always has a fixed size. Usually, this will be the intrinsic size of the image, but it can also be any other size if the image is created with the constructor that takes requestedWidth and requestedHeight. Internally, the JavaFX Image is stored with an arbitrary pixel density. There'

Integrated: 8362095: HeaderButtonMetrics should not be used across toolkit boundary

2025-07-14 Thread Michael Strauß
On Sun, 13 Jul 2025 21:34:42 GMT, Michael Strauß wrote: > The record `com.sun.glass.ui.HeaderButtonMetrics` is used by Glass, but also > in the FX layer (in `Stage` and `HeaderBar`). This is architectually unsound, > as the FX layer should not directly reference the Glass imple

RFR: 8362095: HeaderButtonMetrics should not be used across toolkit boundary

2025-07-13 Thread Michael Strauß
The record `com.sun.glass.ui.HeaderButtonMetrics` is used by Glass, but also in the FX layer (in `Stage` and `HeaderBar`). This is architectually unsound, as the FX layer should not directly reference the Glass implementation. The solution here is to introduce another record that is used in the

RFR: 8362091: Window title bar should reflect scene color scheme

2025-07-12 Thread Michael Strauß
Currently, the color scheme of a system-decorated stage is as follows: * On Windows, the title bar is always light (even if the OS color scheme is dark). * On macOS and Linux, the title bar is light or dark depending on the OS color scheme. The expected behavior is that the title bar matches the

Re: RFR: 8358450: Viewport characteristics media features [v2]

2025-07-12 Thread Michael Strauß
lone` (note: `browser` and > `minimal-ui` are not supported in JavaFX) Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: Replace context awareness flags with EnumSet - Changes: - all: https://git.openjdk.org/jfx

Re: Viewport characteristics media features

2025-07-12 Thread Michael Strauß
Maybe @custom-media queries can get you part of the way there: https://www.w3.org/TR/mediaqueries-5/#custom-mq So instead of repeating a media query multiple times, you can define a custom media query like this: @custom-media --sm (width >= 40); And use it with the regular syntax: @media

Re: Viewport characteristics media features

2025-07-12 Thread Michael Strauß
In general, I'm skeptical about inventing non-standard CSS features. What would be the use case for custom properties in the way that you describe? On Sat, Jul 12, 2025 at 6:03 PM Christopher Schnick wrote: > > That is very exciting. > > Would it be possible to create custom boolean properties t

RFR: 8358450: Viewport characteristics media features

2025-07-11 Thread Michael Strauß
Implementation of [viewport characteristics media features](https://www.w3.org/TR/mediaqueries-5/#mf-viewport-characteristics): * `width` * `height` * `aspect-ratio`: width / height * `orientation`: `portrait`, `landscape` * `display-mode`: `fullscreen`, `standalone` (note: `browser` and `minimal-

Viewport characteristics media features

2025-07-11 Thread Michael Strauß
JavaFX 25 introduces user-preference media queries, which allows developers to probe user preferences in stylesheets. I propose to enhance media queries by adding the following viewport characteristics media features [0]: 1. width 2. height 3. aspect-ratio (=width/height) 4. orientation (with valu

Re: RFR: 8357594: Additional geometry-based Text/TextFlow APIs [v6]

2025-07-11 Thread Michael Strauß
On Fri, 11 Jul 2025 15:11:57 GMT, Andy Goryachev wrote: >> ## Summary >> This change adds new methods to the `TextFlow` which work correctly in the >> presence of non-empty insets (borders/padding). For backward compatibility, >> the old buggy methods are getting deprecated (not for removal). A

Integrated: 8345348: CSS media feature queries

2025-07-11 Thread Michael Strauß
On Mon, 2 Dec 2024 16:19:46 GMT, Michael Strauß wrote: > Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). This pull request has now been integrated. Changeset: e0f8e720 Author:Michael Strauß URL: https://git.openjdk.o

Re: Wrong behavior of Stage header

2025-07-10 Thread Michael Strauß
one then there's no issue, but in any > commit that includes this one (master included) I get this issue. > > On Thu, Jul 10, 2025 at 11:27 PM Michael Strauß > wrote: >> >> I can't reproduce this issue with the latest jfx/master running on Windows >&g

Re: Wrong behavior of Stage header

2025-07-10 Thread Michael Strauß
I can't reproduce this issue with the latest jfx/master running on Windows 10 22H2 build 19045.3803 in LTR or RTL locales. What version are you using? >

Re: RFR: 8314482: TextFlow: TabStopPolicy [v2]

2025-07-09 Thread Michael Strauß
On Wed, 9 Jul 2025 15:29:50 GMT, Andy Goryachev wrote: >> Getting back to this, there are two naming questions here. First, should >> "tab" be in the name (it does seem a bit redundant, since the name of the >> class is TabStopPolicy)? Second, what is the best name for the value that >> define

Re: RFR: 8345348: CSS media feature queries [v34]

2025-07-08 Thread Michael Strauß
On Tue, 8 Jul 2025 21:08:45 GMT, Kevin Rushforth wrote: >> Very likely this is a javadoc limitation. I don't know how likely it will be >> to get it fixed, but it would be no earlier than in JDK 26, which means that >> it would be (at least) JavaFX 27 before it started working. That makes >> o

Re: RFR: 8345348: CSS media feature queries [v36]

2025-07-08 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: documentation changes - Changes: - all:

Re: RFR: 8345348: CSS media feature queries [v35]

2025-07-08 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: documentation changes - Changes: - all:

Re: RFR: 8345348: CSS media feature queries [v34]

2025-07-08 Thread Michael Strauß
On Tue, 8 Jul 2025 20:30:14 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line >> 617: >> >>> 615: * >>> 616: * @return the {@code persistentScrollBars} property >>> 617:

Re: RFR: 8345348: CSS media feature queries [v34]

2025-07-08 Thread Michael Strauß
On Tue, 8 Jul 2025 18:32:10 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 50 commits: >> >> - Merge branch 'master' into feature/media-querie

Re: Debugger

2025-07-07 Thread Michael Strauß
Probably because no one felt the need to work on a public API for it yet. There seems to be some prior work for WebView debugging, maybe this can be of some use: https://github.com/vsch/Javafx-WebView-Debugger On Sun, Jul 6, 2025 at 6:56 PM wrote: > > Why is WebEngine Debugger private? > > Marvi

Re: Enhanced Text/TextFlow APIs

2025-07-07 Thread Michael Strauß
In most cases, I would advise against having similarly-named methods that exhibit different semantics. If the behavior of the existing methods is indeed a bug (and not just different, but legitimate semantics), then fixing that would be best. We've done breaking changes in the past where appropriat

Re: RFR: 8341438: TextFlow: incorrect caretShape(), hitTest(), rangeShape() with non-empty padding/border [v2]

2025-07-07 Thread Michael Strauß
On Mon, 7 Jul 2025 20:56:56 GMT, Andy Goryachev wrote: > > Have alternatives been discussed? > > Yes, internally. This PR has been out for quite a while, too. Okay... the OpenJFX project states in CONTRIBUTING.md, section "New features / API additions": _Discuss the proposed feature on the [o

Re: RFR: 8341438: TextFlow: incorrect caretShape(), hitTest(), rangeShape() with non-empty padding/border [v2]

2025-07-07 Thread Michael Strauß
On Fri, 27 Jun 2025 15:02:29 GMT, Andy Goryachev wrote: >> ## Summary >> This change adds new methods to the `TextFlow` which work correctly in the >> presence of non-empty insets (borders/padding). For backward compatibility, >> the old buggy methods are getting deprecated (not for removal). A

Re: RFR: 8343956: Focus delegation API

2025-07-06 Thread Michael Strauß
On Sat, 9 Nov 2024 01:28:53 GMT, Michael Strauß wrote: > Implementation of [focus > delegation](https://gist.github.com/mstr2/44d94f0bd5b5c030e26a47103063aa29). Dispatching an event in the presence of focus delegation is slightly different, because it requires cooperation of the `Node

Re: RFR: 8343956: Focus delegation API

2025-07-06 Thread Michael Strauß
On Sun, 9 Feb 2025 22:45:14 GMT, John Hendrikx wrote: > Why doesn't it just set the delegate to whatever hoisted focus in the first > place? A not entirely hypothetical `DateEntryControl` with 3 separate fields > internally (with borders stripped) could have a day-month-year area (such > contr

Re: RFR: 8343956: Focus delegation API

2025-07-06 Thread Michael Strauß
On Sun, 9 Feb 2025 11:31:09 GMT, John Hendrikx wrote: > > @hjohn I think what's missing in your model is the option to have an > > independently focusable node inside of a control. For example, think of a > > Button placed within a Button (via its `graphic` property). Clicking the > > nested b

Re: RFR: 8343956: Focus delegation API

2025-07-06 Thread Michael Strauß
On Fri, 3 Jan 2025 10:36:23 GMT, John Hendrikx wrote: >> Implementation of [focus >> delegation](https://gist.github.com/mstr2/44d94f0bd5b5c030e26a47103063aa29). > > This looks really good. I'm wondering if this could be simplified further. > Specifically, I think the `hoistFocus` flag and ma

RFR: 8343956: Focus delegation API

2025-07-06 Thread Michael Strauß
Implementation of [focus delegation](https://gist.github.com/mstr2/44d94f0bd5b5c030e26a47103063aa29). - Commit messages: - javadoc - Added documentation - Add EventTarget.dispatchEvent(Event) - Capture (parent, delegate, dispatcher) in DelegatingEventDispatcher - Improved docume

Re: Support for new blend modes: CLEAR, ALPHA_MAX

2025-06-24 Thread Michael Strauß
The CLEAR blend mode seems to be an obvious addition. The case for ALPHA_MAX is a bit more difficult to justify, as it seems like a special-purpose mode. You need this particular blend mode, but the next developer might need COLOR_DODGE_WITH_ALPHA_MAX or LIGHTEN_WITH_ALPHA_ATOP. Maybe we can prev

Re: HeaderBar (preview) clipped out of window during resize

2025-06-24 Thread Michael Strauß
We had a brief discussion back in October 2024 whether HeaderBar should be a normal layout container in the scene graph, or whether it should live somewhere else (for example something like Scene.setHeaderBar(), analogous to Scene.setRoot()). It became clear that we wanted HeaderBar to be a part of

Re: RFR: 8359601: Fix window button states of an extended stage [v6]

2025-06-24 Thread Michael Strauß
On Tue, 24 Jun 2025 08:16:48 GMT, Cormac Redmond wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix resizable state of macOS window > > I have found another bug/issue, which is ag

Re: RFR: 8359601: Fix window button states of an extended stage [v6]

2025-06-21 Thread Michael Strauß
---|---| > | resizable, not modal | yes | yes | yes | > | not resizable, not modal | yes | no | yes | > | resizable, modal | no | yes | yes | > | not resizable, modal | no | no | yes | > > ## Fixes > > This PR includes the following changes: > 1. Unused code relatin

Re: RFR: 8359601: Fix window button states of an extended stage [v3]

2025-06-21 Thread Michael Strauß
On Sat, 21 Jun 2025 17:37:02 GMT, Markus Mack wrote: > I also checked the behavior in macOS Sequoia 15.5. There, a window where > `setResizable(false)` is called before showing the stage, unexpectedly has a > working maximize button even without `StageStyle.EXTENDED`. Looks like this > was not

Re: RFR: 8359601: Fix window button states of an extended stage [v5]

2025-06-21 Thread Michael Strauß
---|---| > | resizable, not modal | yes | yes | yes | > | not resizable, not modal | yes | no | yes | > | resizable, modal | no | yes | yes | > | not resizable, modal | no | no | yes | > > ## Fixes > > This PR includes the following changes: > 1. Unused code relatin

Re: RFR: 8359601: Fix window button states of an extended stage [v3]

2025-06-21 Thread Michael Strauß
On Sat, 21 Jun 2025 21:05:48 GMT, Cormac Redmond wrote: > > I've filed another ticket for that: > > [JDK-8359763](https://bugs.openjdk.org/browse/JDK-8359763). > > Just curious, why a separate bug for this instead of fixing in this PR and > avoiding the headaches/conversations of more PRs -- i

Re: RFR: 8359601: Fix window button states of an extended stage [v4]

2025-06-21 Thread Michael Strauß
---|---| > | resizable, not modal | yes | yes | yes | > | not resizable, not modal | yes | no | yes | > | resizable, modal | no | yes | yes | > | not resizable, modal | no | no | yes | > > ## Fixes > > This PR includes the following changes: > 1. Unused code relatin

Re: RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues [v45]

2025-06-21 Thread Michael Strauß
On Sat, 21 Jun 2025 14:45:25 GMT, Thiago Milczarek Sayao wrote: >> This is a continuation to >> [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to >> stabilize the linux glass gtk backend. >> >> >> Overall, it has been made more robust within its scope, particularly in

Re: RFR: 8345348: CSS media feature queries [v34]

2025-06-19 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 50 commits: - Merge branch 'master' in

Re: RFR: 8324941: POC for Headless platform for JavaFX [v2]

2025-06-19 Thread Michael Strauß
On Thu, 19 Jun 2025 08:47:08 GMT, Johan Vos wrote: >> After spending a year in the sandbox repository, the Headless Platform is >> now ready to be reviewed in the main repository. >> >> ### the Headless Platform >> The Headless Platform is a top-level com.sun.glass.ui platform that replaces >>

Re: RFR: 8359601: Fix window button states of an extended stage [v3]

2025-06-19 Thread Michael Strauß
On Tue, 17 Jun 2025 00:41:54 GMT, Michael Strauß wrote: >> The window button states (disabled/hidden) of extended stages with a >> `HeaderButtonOverlay` or custom header buttons are inconsistent with what we >> would expect from the OS (Windows and Linux). To figure

Re: RFR: 8314482: TextFlow: TabStopPolicy [v2]

2025-06-18 Thread Michael Strauß
On Wed, 18 Jun 2025 17:02:13 GMT, Kevin Rushforth wrote: >> This terminology is borrowed from a well known software product. I think it >> is apt as it describes the spacing (and the positions) of multiple tab >> stops, and also the users might be familiar with the term. > > Hmm. OK then. Thi

Re: RFR: 8359601: Fix window button states of an extended stage [v3]

2025-06-16 Thread Michael Strauß
On Tue, 17 Jun 2025 00:41:54 GMT, Michael Strauß wrote: >> The window button states (disabled/hidden) of extended stages with a >> `HeaderButtonOverlay` or custom header buttons are inconsistent with what we >> would expect from the OS (Windows and Linux). To figure

Re: RFR: 8359601: Fix window button states of an extended stage [v2]

2025-06-16 Thread Michael Strauß
On Tue, 17 Jun 2025 00:23:48 GMT, Michael Strauß wrote: >> The window button states (disabled/hidden) of extended stages with a >> `HeaderButtonOverlay` or custom header buttons are inconsistent with what we >> would expect from the OS (Windows and Linux). To figure

Re: RFR: 8359601: Fix window button states of an extended stage [v3]

2025-06-16 Thread Michael Strauß
---|---| > | resizable, not modal | yes | yes | yes | > | not resizable, not modal | yes | no | yes | > | resizable, modal | no | yes | yes | > | not resizable, modal | no | no | yes | > > ## Fixes > > This PR includes the following changes: > 1. Unused code relatin

Re: RFR: 8359601: Fix window button states of an extended stage [v2]

2025-06-16 Thread Michael Strauß
---|---| > | resizable, not modal | yes | yes | yes | > | not resizable, not modal | yes | no | yes | > | resizable, modal | no | yes | yes | > | not resizable, modal | no | no | yes | > > ## Fixes > > This PR includes the following changes: > 1. Unused code relatin

Re: RFR: 8345348: CSS media feature queries [v33]

2025-06-16 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 49 commits: - Merge branch 'master' in

Re: RFR: 8345348: CSS media feature queries [v32]

2025-06-15 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 48 commits: - Merge branch 'master' in

Re: RFR: 8358820: Allow interpolation outside of range [0,1] [v2]

2025-06-15 Thread Michael Strauß
On Sun, 15 Jun 2025 05:22:13 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> javadoc > > modules/javafx.graphics/src/main/java/javafx/animation/Interpolat

Re: RFR: 8358820: Allow interpolation outside of range [0,1] [v2]

2025-06-15 Thread Michael Strauß
> 3. `SplineInterpolator` now accepts control points with any Y coordinate. > > Here's how the result looks like for the previously unrepresentable > interpolation function `cubic-bezier(0.34, 2.2, 0.64, 1)`: > src="https://github.com/user-attachments/assets/72c10d0d

Re: RFR: 8358820: Allow interpolation outside of range [0,1]

2025-06-15 Thread Michael Strauß
On Sun, 15 Jun 2025 05:34:17 GMT, Nir Lisker wrote: >> JavaFX unnecessarily restricts interpolation in the following ways: >> 1. `Interpolatable` implementations often clamp intermediate values to the >> interpolation factor range [0,1]. >> 2. `SplineInterpolator` doesn't accept Y coordinates ou

Re: StageStyle.EXTENDED & dialogs

2025-06-15 Thread Michael Strauß
Hi Cormac, I think there are several overlapping problems here. Let's start with the window button states. I've prepared a PR to align the states of extended window buttons with what would be expected on the OS [0]. This seems to address your points 2, 3, and 4. Second, let's look at this piece

RFR: 8359601: Fix window button states of an extended stage

2025-06-15 Thread Michael Strauß
The window button states (disabled/hidden) of extended stages with a `HeaderButtonOverlay` or custom header buttons are inconsistent with what we would expect from the OS (Windows and Linux). To figure out what we would expect, I started with gathering some data. The following table shows the b

Re: RFR: 8358820: Allow interpolation outside of range [0,1]

2025-06-13 Thread Michael Strauß
On Sat, 7 Jun 2025 18:45:06 GMT, Nir Lisker wrote: > Noting that this proposed change supersedes the previous changes that were > done for for https://bugs.openjdk.org/browse/JDK-8226911. The proposed > behavioral change makes sense. Can I interest you in a review of the API and/or the impleme

Integrated: 8313424: JavaFX controls in the title bar (Preview)

2025-06-12 Thread Michael Strauß
On Sun, 20 Oct 2024 00:47:51 GMT, Michael Strauß wrote: > Implementation of > [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). This pull request has now been integrated. Changeset: fd30c948 Author:Michael Strauß URL: https://git.openj

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v86]

2025-06-12 Thread Michael Strauß
On Fri, 13 Jun 2025 00:05:00 GMT, Cormac Redmond wrote: > Have DialogPanes and Alerts been considered for use with HeaderBar & > StageStyle.EXTENDED? I haven't spent much time thinking about this yet. > I.e., re: Alerts, cater for **hiding** minimise / maximise icons by default, > but still s

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v84]

2025-06-12 Thread Michael Strauß
On Thu, 12 Jun 2025 21:05:38 GMT, Markus Mack wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 108 commits: >> >> - Fix full-screen bug >> - Merge branch 'master'

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v86]

2025-06-12 Thread Michael Strauß
> Implementation of > [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: add the same fix in childVisibilityChanged - C

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v85]

2025-06-12 Thread Michael Strauß
> Implementation of > [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: typo - Changes: - all: https://git.openjdk.org/jf

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v83]

2025-06-12 Thread Michael Strauß
On Thu, 12 Jun 2025 16:05:56 GMT, Andy Goryachev wrote: > > On Windows, when switching to fullscreen mode, the application crashes with > > an endless repetition of the error. > > Same issue on macOS 15.5 > > Can be reproduced with the Stage Tester + simple HeaderBar. Perhaps it was > introdu

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v84]

2025-06-12 Thread Michael Strauß
> Implementation of > [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 108 commits: - Fix full-screen bug - Merge

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v83]

2025-06-12 Thread Michael Strauß
On Tue, 10 Jun 2025 02:51:34 GMT, Michael Strauß wrote: >> Implementation of >> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). > > Michael Strauß has updated the pull request incrementally with one additional > commit si

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v34]

2025-06-11 Thread Michael Strauß
On Wed, 11 Jun 2025 19:17:24 GMT, Andy Goryachev wrote: >> Please refer to >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md >> >> The RichTextArea control >> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom >> control that needs n

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v83]

2025-06-10 Thread Michael Strauß
On Tue, 10 Jun 2025 17:30:44 GMT, Andy Goryachev wrote: > > ```java > > .-FX-INTERNAL-header-button-container > > ``` > > yikes! I think I tried to modify this particular selector... > > So let me ask this question again. Since the application can change these > styles, I feel they should be d

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v83]

2025-06-10 Thread Michael Strauß
On Tue, 10 Jun 2025 16:51:35 GMT, Andy Goryachev wrote: > Looks good. > > Spent some time trying to set the new -FX-INTERNAL- CSS properties via scene > stylesheet, failed as expected (win11). BTW, did not see any CSS errors in > stderr. This "works" for me: scene.getStylesheets().add("data:

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v83]

2025-06-09 Thread Michael Strauß
On Tue, 10 Jun 2025 02:51:34 GMT, Michael Strauß wrote: >> Implementation of >> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). > > Michael Strauß has updated the pull request incrementally with one additional > commit si

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v83]

2025-06-09 Thread Michael Strauß
> Implementation of > [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: only dispose ViewSceneOverlay when non-null - C

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v82]

2025-06-09 Thread Michael Strauß
> Implementation of > [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request incrementally with two additional commits since the last revision: - Rename default window button style classes - Set the scene r

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v81]

2025-06-09 Thread Michael Strauß
On Sun, 8 Jun 2025 14:39:55 GMT, Cormac Redmond wrote: > So I don't know if there's a bug worth investigating here or not, these > comments are mainly intended as a source of information to others. This seems like a bug. If developers use an API wrongly, a clearly defined error should result;

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v81]

2025-06-06 Thread Michael Strauß
On Sat, 7 Jun 2025 01:47:15 GMT, Cormac Redmond wrote: > Just something to consider regarding this "dark" mode reliance on a Scene's > fill property. > > As far as I know, a Scene's fill property cannot be set via CSS. > > I have a light and dark theme (two css files), and the user can pick "l

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v81]

2025-06-06 Thread Michael Strauß
On Sat, 7 Jun 2025 01:26:09 GMT, Cormac Redmond wrote: > No, the docs on that are good. Although, nothing stood out to make it obvious > that the WindowDecoration.css styles cannot be overridden. > > Regarding the "dark" + scene fill, there are some good docs in > HeaderButtonOverlay, but I do

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v81]

2025-06-06 Thread Michael Strauß
On Thu, 5 Jun 2025 00:50:30 GMT, Michael Strauß wrote: >> Implementation of >> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). > > Michael Strauß has updated the pull request incrementally with one additional > commit si

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v81]

2025-06-06 Thread Michael Strauß
On Sat, 7 Jun 2025 00:35:02 GMT, Cormac Redmond wrote: > It appears that the CSS of the Window icons cannot be overridden; see below > example which doesn't apply css.css. > > What is the proper/expected way to style the window icons; and should there > be some documentation on this somewhere

RFR: 8358820: Allow interpolation outside of range [0,1]

2025-06-06 Thread Michael Strauß
JavaFX unnecessarily restricts interpolation in the following ways: 1. `Interpolatable` implementations often clamp intermediate values to the interpolation factor range [0,1]. 2. `SplineInterpolator` doesn't accept Y coordinates outside of [0,1] for its control points. While this was probably do

Re: RFR: 8313424: JavaFX controls in the title bar (Preview) [v80]

2025-06-05 Thread Michael Strauß
On Thu, 5 Jun 2025 15:37:17 GMT, Kevin Rushforth wrote: >> Our production build system is Oracle Linux 8, which has GTK 3.22. >> >> The oldest system I now have access to is Ubuntu 16.04 (yeah, I know...it's >> probably time to retire it), which has GTK 3.18. I build JavaFX using GCC >> 14.2 (

  1   2   3   4   5   6   7   8   9   10   >