rs to private structures is also a non-starter.
After looking at the code, there doesn't appear to be any inclusion of
the MFD core header. How can this be an MFD if you do not use the MFD
API? MFD is not a dumping area for common code and call-backs. It's a
subsystem used to neatly separate out and share resources between
functionality that just happens to share the same hardware chip.
--
Lee Jones [李琼斯]
+
> drivers/nvmem/Kconfig | 12 +
> drivers/nvmem/Makefile | 2 +
> drivers/nvmem/max77759-nvmem.c | 156 +
> include/linux/mfd/max77759.h | 165 +
> 14 files changed, 1769 insertions(+)
> ---
> base-commit: 9388ec571cb1adba59d1cded2300eeb11827679c
> change-id: 20250224-max77759-mfd-aaa7a3121b62
>
> Best regards,
> --
> André Draszik
Didn't apply cleanly. Please rebase onto v6.15-rc1.
--
Lee Jones [李琼斯]
3x.h
FWIW, I'm not planning to even look at this until Andy and Krzysztof are
satisfied. What I will say is that all of those horrible macros will
have to be removed and no abstractions will be accepted unless they are
accompanied with very good reasons as to why they are required.
--
Lee Jones [李琼斯]
On Thu, 10 Apr 2025, Lee Jones wrote:
> On Fri, 21 Mar 2025 10:53:53 +0100, Thomas Zimmermann wrote:
> > This series removes the remaining dependencies on fbdev from the
> > backlight, lcd and led subsystems. Each depends on fbdev events to
> > track display state. M
8409b817
[10/11] leds: backlight trigger: Replace fb events with a dedicated function
call
commit: dc2139c0aa3283e5749109641af1878ed7bf7371
[11/11] fbdev: Remove constants of unused events
commit: d32a0b567a8a8b6e677d35c4f8eb8bd32b7029a0
--
Lee Jones [李琼斯]
On Fri, 14 Mar 2025, André Draszik wrote:
> Hi Lee,
>
> Thanks for your review!
>
> On Fri, 2025-03-14 at 12:31 +, Lee Jones wrote:
> > On Wed, 12 Mar 2025, André Draszik wrote:
> >
> > > The Maxim MAX77759 is a companion PMIC for USB Type-C application
comes in, feel free to merge it via the backlight tree. I can also take the
> series into dri-devel.
I plan to take this in via the Backlight tree. Once applied, I'll send
out a pull-request for other maintainers to pull from.
For the record, just so we're clear, this will not make v6.15.
--
Lee Jones [李琼斯]
.
>
> So, with these changes, fix the following warning:
>
> [...]
Applied, thanks!
[1/1] leds: Avoid -Wflex-array-member-not-at-end warning
commit: c0adca7285b2bdf2ef7a67bb02e282d861e7b6a8
--
Lee Jones [李琼斯]
define SE_CMD_START 0x0
> +#define SE_CMD_STOP 0x1
> +#define SE_CMD_GETVER 0x2
> +#define SE_CMD_SETBUF0x3
> +#define SE_CMD_SETMSG0x4
> +
> +#define SE_CMD_RNG 0x100
> +#define SE_CMD_SM2_SIGN 0x200
> +#define SE_CMD_SM2_VSIGN 0x201
> +#define SE_CMD_SM3_DIGEST0x300
> +#define SE_CMD_SM3_UPDATE0x301
> +#define SE_CMD_SM3_FINISH0x302
> +#define SE_CMD_SM4_ECB_ENCRY 0x400
> +#define SE_CMD_SM4_ECB_DECRY 0x401
> +#define SE_CMD_SM4_CBC_ENCRY 0x402
> +#define SE_CMD_SM4_CBC_DECRY 0x403
> +#define SE_CMD_SM4_CTR 0x404
> +#define SE_CMD_TPM 0x500
> +#define SE_CMD_ZUC_INIT_READ 0x600
> +#define SE_CMD_ZUC_READ 0x601
> +#define SE_CMD_SDF 0x700
> +
> +#define SE_CH_MAX32
> +#define SE_CH_RNG1
> +#define SE_CH_SM22
> +#define SE_CH_SM33
> +#define SE_CH_SM44
> +#define SE_CH_TPM5
> +#define SE_CH_ZUC6
> +#define SE_CH_SDF7
> +
> +struct se_channel {
> + struct loongson_se *se;
> + void *priv;
> + u32 version;
What do you do with this information?
> + u32 id;
> + u32 int_bit;
> +
> + void *smsg;
> + void *rmsg;
> + int msg_size;
> +
> + void *data_buffer;
> + int data_size;
> + u32 off;
Most of these variables have terrible names.
So either use proper nomenclature or document them.
> +
> + void (*complete)(struct se_channel *se_ch);
Non-subsystem-level call-backs are generally evil.
You'd need to provide a very good reason as to why nothing else works.
> +};
> +
> +struct se_channel *se_init_ch(struct device *dev, int id, int data_size, int
> msg_size,
> + void *priv, void (*complete)(struct se_channel
> *se_ch));
> +int se_send_ch_requeset(struct se_channel *ch);
> +
> +#endif
> --
> 2.45.2
>
--
Lee Jones [李琼斯]
On Fri, 04 Apr 2025, Lee Jones wrote:
> On Tue, 01 Apr 2025 17:16:47 +0800, Henry Martin wrote:
> > devm_kasprintf() returns NULL when memory allocation fails. Currently,
> > wled_configure() does not check for this case, which results in a NULL
> > pointer dereference.
&g
vent this issue.
>
>
> [...]
Applied, thanks!
[1/1] backlight: pm8941: Add NULL check in wled_configure()
commit: b0fdeb96ead46de57a6226bc3a3ac7f9b50c0ace
--
Lee Jones [李琼斯]
.org/all/Z8z236h4B5A6Ki3D@gallifrey/
>
> Remove it.
>
> [...]
Applied, thanks!
[7/9] backlight: pcf50633-backlight: Remove
commit: dfc034a0494b8fb8ea881aeb41a0c4e2619ff1e4
--
Lee Jones [李琼斯]
On Mon, 10 Mar 2025 12:56:36 +0800, WangYuli wrote:
> The description for CONFIG_LCD_TDO24M has redundant whitespace.
> Trim it to keep the code tidy.
>
>
Applied, thanks!
[1/1] backlight: tdo24m: Eliminate redundant whitespace
commit: c9fe785857fdfc780d49b60b5bb77ca21a51
gt; + * Client interface for Maxim MAX77759 MFD driver
> + */
> +
> +#ifndef __LINUX_MFD_MAX77759_H
> +#define __LINUX_MFD_MAX77759_H
> +
> +/* MaxQ opcodes */
> +#define MAX77759_MAXQ_OPCODE_MAXLENGTH 33
> +
> +#define MAX77759_MAXQ_OPCODE_GPIO_TRIGGER_READ 0x21
> +#define MAX77759_MAXQ_OPCODE_GPIO_TRIGGER_WRITE 0x22
> +#define MAX77759_MAXQ_OPCODE_GPIO_CONTROL_READ 0x23
> +#define MAX77759_MAXQ_OPCODE_GPIO_CONTROL_WRITE 0x24
> +#define MAX77759_MAXQ_OPCODE_USER_SPACE_READ 0x81
> +#define MAX77759_MAXQ_OPCODE_USER_SPACE_WRITE0x82
> +
> +/*
> + * register map (incomplete) - registers not useful for drivers are not
> + * declared here
> + */
> +/* MaxQ */
> +#define MAX77759_MAXQ_REG_UIC_INT10x64
> +#define MAX77759_MAXQ_REG_UIC_INT1_APCMDRESI BIT(7)
> +#define MAX77759_MAXQ_REG_UIC_INT1_SYSMSGIBIT(6)
> +#define MAX77759_MAXQ_REG_UIC_INT1_GPIO6I BIT(1)
> +#define MAX77759_MAXQ_REG_UIC_INT1_GPIO5I BIT(0)
> +#define MAX77759_MAXQ_REG_UIC_INT1_GPIOxI(offs, en) (((en) & 1) << (offs))
> +#define MAX77759_MAXQ_REG_UIC_INT1_GPIOxI_MASK(offs) \
> + MAX77759_MAXQ_REG_UIC_INT1_GPIOxI(offs, ~0)
> +
> +#define MAX77759_MAXQ_REG_UIC_INT20x65
> +#define MAX77759_MAXQ_REG_UIC_INT30x66
> +#define MAX77759_MAXQ_REG_UIC_INT40x67
> +#define MAX77759_MAXQ_REG_UIC_UIC_STATUS1 0x68
> +#define MAX77759_MAXQ_REG_UIC_UIC_STATUS2 0x69
> +#define MAX77759_MAXQ_REG_UIC_UIC_STATUS3 0x6a
> +#define MAX77759_MAXQ_REG_UIC_UIC_STATUS4 0x6b
> +#define MAX77759_MAXQ_REG_UIC_UIC_STATUS5 0x6c
> +#define MAX77759_MAXQ_REG_UIC_UIC_STATUS6 0x6d
> +#define MAX77759_MAXQ_REG_UIC_UIC_STATUS7 0x6f
> +#define MAX77759_MAXQ_REG_UIC_UIC_STATUS8 0x6f
> +#define MAX77759_MAXQ_REG_UIC_INT1_M 0x70
> +#define MAX77759_MAXQ_REG_UIC_INT2_M 0x71
> +#define MAX77759_MAXQ_REG_UIC_INT3_M 0x72
> +#define MAX77759_MAXQ_REG_UIC_INT4_M 0x73
> +
> +/* charger */
> +#define MAX77759_CHGR_REG_CHG_INT0xb0
> +#define MAX77759_CHGR_REG_CHG_INT2 0xb1
> +#define MAX77759_CHGR_REG_CHG_INT_MASK 0xb2
> +#define MAX77759_CHGR_REG_CHG_INT2_MASK 0xb3
> +
> +struct max77759_mfd;
Place the definition in here instead.
> +/**
> + * struct max77759_maxq_command - structure containing the MaxQ command to
> + * send
> + *
> + * @length: The number of bytes to send.
> + * @cmd: The data to send.
> + */
> +struct max77759_maxq_command {
> + u8 length;
> + u8 cmd[] __counted_by(length);
> +};
> +
> +/**
> + * struct max77759_maxq_response - structure containing the MaxQ response
> + *
> + * @length: The number of bytes to receive.
> + * @rsp: The data received. Must have at least @length bytes space.
> + */
> +struct max77759_maxq_response {
> + u8 length;
> + u8 rsp[] __counted_by(length);
> +};
> +
> +/**
> + * max77759_maxq_command() - issue a MaxQ command and wait for the response
> + * and associated data
> + *
> + * @max77759_mfd: The core max77759 mfd device handle.
> + * @cmd: The command to be sent.
> + * @rsp: Any response data associated with the command will be copied here;
> + * can be %NULL if the command has no response (other than ACK).
> + *
> + * Return: 0 on success, a negative error number otherwise.
> + */
> +int max77759_maxq_command(struct max77759_mfd *max77759_mfd,
> + const struct max77759_maxq_command *cmd,
> + struct max77759_maxq_response *rsp);
> +
> +#endif /* __LINUX_MFD_MAX77759_H */
>
> --
> 2.49.0.rc0.332.g42c0ae87b1-goog
>
--
Lee Jones [李琼斯]
/9] mfd: pcf50633: Remove irq code
commit: 786ad21f4350601c9d118ddbd19b7b830c04ece6
[9/9] mfd: pcf50633: Remove remains
commit: 44356090d59efd8db152e9eecb8e7f843be319f0
--
Lee Jones [李琼斯]
re/fbmem.c | 82 ++---
> drivers/video/fbdev/core/fbsysfs.c | 8 +-
> include/linux/backlight.h| 22 ++---
> include/linux/fb.h | 12 +--
> include/linux/lcd.h | 21 -
> include/linux/leds.h
+obj-$(CONFIG_MFD_LS6000SE) += ls6000se.o
> diff --git a/drivers/mfd/ls6000se.c b/drivers/mfd/ls6000se.c
> new file mode 100644
> index 00..24d76c2ffc
> --- /dev/null
> +++ b/drivers/mfd/ls6000se.c
[...]
> +static const struct mfd_cell se_devs[] = {
> + { .name = "ls6000se-sdf" },
> + { .name = "ls6000se-tpm" },
> +};
Where are the drivers for these devices? I don't see them anywhere.
I do see ls6000se-rng. How is that registered?
--
Lee Jones [李琼斯]
On Sat, 08 Mar 2025, Jonathan Cameron wrote:
> On Wed, 5 Mar 2025 16:18:38 +0200
> Svyatoslav Ryhel wrote:
>
> > ср, 5 бер. 2025 р. о 15:45 Jonathan Cameron пише:
> > >
> > > On Fri, 28 Feb 2025 11:30:51 +0200
> > > Svyatoslav Ryhel wrote:
> > &
>dev.parent,
> + bl, &lm3533_bl_ops, &props);
> if (IS_ERR(bd)) {
> dev_err(&pdev->dev, "failed to register backlight device\n");
> return PTR_ERR(bd);
> @@ -320,7 +339,20 @@ static int lm3533_bl_probe(struct platform_device *pdev)
>
> backlight_update_status(bd);
>
> - ret = lm3533_bl_setup(bl, pdata);
> + /* 5000 - 29800 uA (800 uA step) */
> + val = 5000;
> + device_property_read_u32(&pdev->dev, "ti,max-current-microamp", &val);
> + bl->max_current = val;
> +
> + /* 0 - 0x3f */
> + val = 0;
> + device_property_read_u32(&pdev->dev, "ti,pwm-config-mask", &val);
> + bl->pwm = val;
> +
> + bl->linear = device_property_read_bool(&pdev->dev,
> "ti,linear-mapping-mode");
> + bl->hvled = device_property_read_bool(&pdev->dev,
> "ti,hardware-controlled");
> +
> + ret = lm3533_bl_setup(bl);
> if (ret)
> goto err_sysfs_remove;
>
> @@ -381,10 +413,17 @@ static void lm3533_bl_shutdown(struct platform_device
> *pdev)
> lm3533_ctrlbank_disable(&bl->cb);
> }
>
> +static const struct of_device_id lm3533_bl_match_table[] = {
> + { .compatible = "ti,lm3533-backlight" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, lm3533_bl_match_table);
> +
> static struct platform_driver lm3533_bl_driver = {
> .driver = {
> .name = "lm3533-backlight",
> .pm = &lm3533_bl_pm_ops,
> + .of_match_table = lm3533_bl_match_table,
> },
> .probe = lm3533_bl_probe,
> .remove = lm3533_bl_remove,
> diff --git a/include/linux/mfd/lm3533.h b/include/linux/mfd/lm3533.h
> index 69059a7a2ce5..3b28fc0970f6 100644
> --- a/include/linux/mfd/lm3533.h
> +++ b/include/linux/mfd/lm3533.h
> @@ -27,6 +27,9 @@ struct lm3533 {
> struct gpio_desc *hwen;
> int irq;
>
> + u32 boost_ovp;
> + u32 boost_freq;
> +
> unsigned have_als:1;
> unsigned have_backlights:1;
> unsigned have_leds:1;
> @@ -38,25 +41,6 @@ struct lm3533_ctrlbank {
> int id;
> };
>
> -struct lm3533_als_platform_data {
> - unsigned pwm_mode:1;/* PWM input mode (default analog) */
> - u8 r_select;/* 1 - 127 (ignored in PWM-mode) */
> -};
> -
> -struct lm3533_bl_platform_data {
> - char *name;
> - u16 max_current;/* 5000 - 29800 uA (800 uA step) */
> - u8 default_brightness; /* 0 - 255 */
> - u8 pwm; /* 0 - 0x3f */
> -};
> -
> -struct lm3533_led_platform_data {
> - char *name;
> - const char *default_trigger;
> - u16 max_current;/* 5000 - 29800 uA (800 uA step) */
> - u8 pwm; /* 0 - 0x3f */
> -};
> -
> enum lm3533_boost_freq {
> LM3533_BOOST_FREQ_500KHZ,
> LM3533_BOOST_FREQ_1000KHZ,
> @@ -69,19 +53,6 @@ enum lm3533_boost_ovp {
> LM3533_BOOST_OVP_40V,
> };
>
> -struct lm3533_platform_data {
> - enum lm3533_boost_ovp boost_ovp;
> - enum lm3533_boost_freq boost_freq;
> -
> - struct lm3533_als_platform_data *als;
> -
> - struct lm3533_bl_platform_data *backlights;
> - int num_backlights;
> -
> - struct lm3533_led_platform_data *leds;
> - int num_leds;
> -};
> -
> extern int lm3533_ctrlbank_enable(struct lm3533_ctrlbank *cb);
> extern int lm3533_ctrlbank_disable(struct lm3533_ctrlbank *cb);
>
> --
> 2.43.0
>
--
Lee Jones [李琼斯]
Apple DWI backlight driver
commit: ea45d216dd4e5b389af984f8c9effa1312e3cd74
[3/3] MAINTAINERS: Add entries for Apple DWI backlight controller
commit: d1ebaf003a065d5d337b8fa3d69f9b90d7bb759d
--
Lee Jones [李琼斯]
On Thu, 13 Feb 2025, Thomas Zimmermann wrote:
> Hi
>
> Am 11.02.25 um 14:57 schrieb Lee Jones:
> > On Thu, 06 Feb 2025, Thomas Zimmermann wrote:
> >
> > > Remove support for fb events from the led backlight trigger. Provide the
> > > helper ledtrig_backli
b52aa741c1a1
--
Lee Jones [李琼斯]
backlight: led_bl: Hold led_access lock when calling led_sysfs_disable()
commit: 276822a00db3c1061382b41e72cafc09d6a0ec30
--
Lee Jones [李琼斯]
n = led_get_trigger_data(led);
>
> + mutex_lock(&ledtrig_backlight_list_mutex);
> + list_del(&n->entry);
> + mutex_unlock(&ledtrig_backlight_list_mutex);
> +
> fb_unregister_client(&n->notifier);
> kfree(n);
> }
> --
> 2.48.1
>
--
Lee Jones [李琼斯]
On Thu, 06 Feb 2025, Thomas Zimmermann wrote:
> Remove support for fb events from the led backlight trigger. Provide the
> helper ledtrig_backlight_blank() instead. Call it from fbdev to inform
> the trigger of changes to a display's blank state.
>
> Signed-off-by: Thomas Zimmermann
> ---
> dri
commit: d520ae4707fd6dafcb55649460059f67f54fc743
[15/16] backlight: vgg2432a4: Do not include
commit: d023cc09d9dbd5c6a4a81e0e3866c3b976d70891
[16/16] backlight: wm831x_bl: Do not include
commit: 373dacfeb55e1ac73dccd91b83437183ca0fbd43
--
Lee Jones [李琼斯]
--- a/include/linux/mfd/atmel-hlcdc.h
> +++ b/include/linux/mfd/atmel-hlcdc.h
> @@ -75,6 +75,7 @@
> */
> struct atmel_hlcdc {
> struct regmap *regmap;
> + struct clk *lvds_pll_clk;
> struct clk *periph_clk;
> struct clk *sys_clk;
> struct clk *slow_clk;
> --
> 2.25.1
>
--
Lee Jones [李琼斯]
On Wed, 18 Dec 2024 22:08:27 +0100, A. Sverdlin wrote:
> Add driver for TI LP8864, LP8864S, LP8866 4/6 channel LED-backlight drivers
> with I2C interface.
>
>
Applied, thanks!
[2/2] leds: lp8864: New driver
commit: e14d879292b0f7755c0d51b82a19b30859bb080a
--
Lee Jones [李琼斯]
gmap),
> + "Failed to allocate register map\n");
If you want to shorten this 'regmap' is fine.
> + /* Control brightness by DISPLAY_BRT register */
> + ret = regmap_update_bits(led->regmap, LP8864_USER_CONFIG1,
> + LP8864_BRT_MODE_MASK, LP8864_BRT_MODE_REG);
> + if (ret) {
> + dev_err(&led->client->dev, "Cannot write USER_CONFIG1\n");
Write user friendly messages.
"Failed to set the ..."
> + return ret;
> + }
> +
> + ret = lp8864_fault_check(led);
> + if (ret)
> + return ret;
> +
> + init_data.fwnode = of_fwnode_handle(child_node);
> + init_data.devicename = "lp8864";
> + init_data.default_label = ":display_cluster";
> +
> + ret = devm_led_classdev_register_ext(&client->dev, &led->led_dev,
> + &init_data);
> + if (ret)
> + dev_err(&client->dev, "Failed to register LED device (%pe)\n",
> + ERR_PTR(ret));
> +
> + return ret;
> +}
> +
> +static const struct i2c_device_id lp8864_id[] = {
> + { "lp8864" },
> + {}
> +};
> +MODULE_DEVICE_TABLE(i2c, lp8864_id);
> +
> +static const struct of_device_id of_lp8864_leds_match[] = {
> + { .compatible = "ti,lp8864" },
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, of_lp8864_leds_match);
> +
> +static struct i2c_driver lp8864_driver = {
> + .driver = {
> + .name = "lp8864",
> + .of_match_table = of_lp8864_leds_match,
> + },
> + .probe = lp8864_probe,
> + .id_table = lp8864_id,
> +};
> +module_i2c_driver(lp8864_driver);
> +
> +MODULE_DESCRIPTION("Texas Instruments LP8864/LP8866 LED driver");
> +MODULE_AUTHOR("Alexander Sverdlin ");
> +MODULE_LICENSE("GPL");
> --
> 2.47.1
>
>
--
Lee Jones [李琼斯]
On Sat, 12 Oct 2024 21:31:38 +0200, Karel Balej wrote:
> Add a MFD cell for the chip's real-time clock.
>
>
Applied, thanks!
[1/2] mfd: 88pm886: add the RTC cell
commit: 156d87b679a565a166da4a7ce892cb87f6317faf
--
Lee Jones [李琼斯]
On Fri, 08 Nov 2024 08:30:44 +, Daniel Thompson wrote:
> Going forward, I'll be using my kernel.org address for upstream work.
>
>
Applied, thanks!
[1/2] MAINTAINERS: Use Daniel Thompson's korg address for backlight work
commit: 3adec6f907b698b32ab62f70da31b41abed
On Mon, 21 Oct 2024, Jiri Kosina wrote:
> On Tue, 1 Oct 2024, Lee Jones wrote:
>
> > Enjoy!
> >
> > The following changes since commit 9852d85ec9d492ebef56dc5f229416c925758edc:
> >
> > Linux 6.12-rc1 (2024-09-29 15:06:19 -0700)
> >
> > are av
ht: convert zii,rave-sp-backlight.txt to yaml
commit: 0eda30af58809224d80dc3bf3f368fc677fe8c08
--
Lee Jones [李琼斯]
txt to yaml format
commit: f4b00ab2c29960961f9641be8f3e8ba4960fd849
--
Lee Jones [李琼斯]
es),
> MFD_CELL_NAME("88pm886-regulator"),
> + MFD_CELL_NAME("88pm886-rtc"),
> };
>
> static int pm886_power_off_handler(struct sys_off_data *sys_off_data)
> --
> 2.47.0
>
--
Lee Jones [李琼斯]
gt; MAINTAINERS | 1 +
> drivers/rtc/Kconfig | 10
> drivers/rtc/Makefile| 1 +
> drivers/rtc/rtc-88pm886.c | 97 +++++++++
> include/linux/mfd/88pm886.h | 9
Acked-by: Lee Jones
> 5 files changed, 118 inser
On Thu, 10 Oct 2024, Karel Balej wrote:
> Lee Jones, 2024-10-10T09:35:19+01:00:
> > On Thu, 10 Oct 2024, Lee Jones wrote:
> >
> > > On Wed, 09 Oct 2024, Karel Balej wrote:
> > >
> > > > Lee Jones, 2024-10-09T11:06:43+01:00:
> > > >
an Muralidharan
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 8 +++-
> include/linux/mfd/atmel-hlcdc.h | 1 +
Acked-by: Lee Jones
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
On Wed, 09 Oct 2024, Lee Jones wrote:
> On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote:
> > RTC lives on the base register page of the chip. Add definitions of the
> > registers needed for a basic set/read time functionality.
> >
> >
>
> Applied, thanks!
On Thu, 10 Oct 2024, Lee Jones wrote:
> On Wed, 09 Oct 2024, Karel Balej wrote:
>
> > Lee Jones, 2024-10-09T11:06:43+01:00:
> > > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote:
> > > > RTC lives on the base register page of the chip. Add definitions of t
On Wed, 09 Oct 2024, Karel Balej wrote:
> Lee Jones, 2024-10-09T11:06:43+01:00:
> > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote:
> > > RTC lives on the base register page of the chip. Add definitions of the
> > > registers needed for a basic
;)
>
> With those not being called, it means that the backlight_notifier
> list is always empty.
>
> [...]
Applied, thanks!
[1/1] backlight: Remove notifier
commit: 5461f3fd74a89757f95f351eb0bc26aafc2a2e91
--
Lee Jones [李琼斯]
s, the list itself and the enum used in the
> > notifications.
> >
> > Signed-off-by: Dr. David Alan Gilbert
>
> Reviewed-by: Simona Vetter
>
> I think Lee Jones or Daniel Thompson will pick this up.
I will pick this up with Daniel's review.
--
Lee Jones [李琼斯]
commit: 0a936c2c45884b9a3800379f3cab4d0a685d63f5
--
Lee Jones [李琼斯]
On Mon, 07 Oct 2024, Werner Sembach wrote:
>
> Am 07.10.24 um 14:58 schrieb Lee Jones:
> > On Fri, 04 Oct 2024, Werner Sembach wrote:
> >
> > > Am 03.10.24 um 09:59 schrieb Lee Jones:
> > > > On Wed, 02 Oct 2024, Werner Sembach wrote:
> > > >
On Fri, 04 Oct 2024, Werner Sembach wrote:
>
> Am 03.10.24 um 09:59 schrieb Lee Jones:
> > On Wed, 02 Oct 2024, Werner Sembach wrote:
> >
> > > Hi,
> > >
> > > Am 02.10.24 um 14:52 schrieb Lee Jones:
> > > > On Fri, 27 Sep 2024, Wer
On Wed, 02 Oct 2024, Werner Sembach wrote:
> Hi,
>
> Am 02.10.24 um 14:52 schrieb Lee Jones:
> > On Fri, 27 Sep 2024, Werner Sembach wrote:
> >
> > > Hi,
> > > first revision integrating Armins feedback.
> > >
> > > Stuff I did not ye
nnotate and --compose next time please.
--
Lee Jones [李琼斯]
/fbdev/omap/lcd_ams_delta.c | 8 ++---
include/linux/fb.h | 13 +
include/linux/lcd.h | 29 +-
include/video/platform_lcd.h | 3 --
21 files changed, 181 insertions(+), 158 deletions(-)
--
Lee Jones [李琼斯]
ght: lcd: Do not include in lcd header
commit: 0d580d99749e759b62dc8e28f511310e9235da7a
--
Lee Jones [李琼斯]
d08906be37b8
--
Lee Jones [李琼斯]
commit: 3db60398b4c10425dd32c076280af7f334431064
--
Lee Jones [李琼斯]
On Thu, 12 Sep 2024, Mark Brown wrote:
> On Thu, Sep 12, 2024 at 03:51:00PM +0100, Lee Jones wrote:
> > On Wed, 04 Sep 2024, Mark Brown wrote:
>
> > > [03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC
> > > commit: 761cab667898d86c04867
se engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
>
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
>
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
>
> Thanks,
> Mark
>
--
Lee Jones [李琼斯]
u can do what you like with them since
> > none are major enough to stop me also sharing a:
> > Reviewed-by: Daniel Thompson
>
> Thanks for reviewing. I'll send out an update. Why tree do these patches go
> into? Backlight?
Yes, that's expected.
--
Lee Jones [李琼斯]
roller we wouldn't
> be able to implement that without having some other DT property to
> indicate which output ports are connected to the DP endpoint.
>
> Reviewed-by: Rob Herring (Arm)
> Cc: Krzysztof Kozlowski
> Cc: Conor Dooley
> Acked-by: Lee Jones
> Cc: B
On Wed, 28 Aug 2024 15:10:55 +, Detlev Casanova wrote:
> Document rk3576 compatible for QoS registers.
>
>
Applied, thanks!
[04/11] dt-bindings: mfd: syscon: Add rk3576 QoS register compatible
commit: 2f9709b8541dc742235743d19b8a6e2baa2e81d4
--
Lee Jones [李琼斯]
On Thu, 22 Aug 2024, Kees Cook wrote:
> On Thu, Jul 25, 2024 at 11:22:40AM +0100, Lee Jones wrote:
> > On Tue, 16 Jul 2024, Gustavo A. R. Silva wrote:
> >
> > >
> > >
> > > On 16/07/24 15:24, Kees Cook wrote:
> > > > With the new __c
to the array.
>
> [...]
Applied, thanks!
[1/1] leds: gpio: Set num_leds after allocation
commit: 045391a02bd971d431c83ad03f7cc51b6e2fe331
--
Lee Jones [李琼斯]
On Mon, 19 Aug 2024, Stephen Boyd wrote:
> This binding is about USB type-c control. Move the binding to the usb
> directory as it's a better home than chrome.
>
> Cc: Rob Herring
> Cc: Krzysztof Kozlowski
> Cc: Conor Dooley
> Cc: Lee Jones
> Cc: Benson Leu
roller we wouldn't
> be able to implement that without having some other DT property to
> indicate which output ports are connected to the DP endpoint.
>
> Cc: Rob Herring
> Cc: Krzysztof Kozlowski
> Cc: Conor Dooley
> Cc: Lee Jones
> Cc: Benson Leung
> Cc: Guenter
gning your mails like this. It means that some of
us have to physically click a pop-up box as we are parsing our inboxes.
I'm deleting all mails in this thread.
--
Lee Jones [李琼斯]
down.
>
> Also, add the audio power supply property which is dedicated for
> the audio codec sub-device.
>
> [...]
Applied, thanks!
[03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC
commit: 3821149eb101fe2d45a4697659e60930828400d8
--
Lee Jones [李琼斯]
down.
>
> Also, add the audio power supply property which is dedicated for
> the audio codec sub-device.
>
> [...]
Applied, thanks!
[03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC
commit: 3821149eb101fe2d45a4697659e60930828400d8
--
Lee Jones [李琼斯]
| 12 -
> drivers/clk/qcom/common.c | 4 +--
> drivers/clk/sunxi/clk-simple-gates.c| 4 +--
> drivers/clk/sunxi/clk-sun8i-bus-gates.c | 4 +--
> drivers/clocksource/samsung_pwm_timer.c | 4 +--
> drivers/gpio/gpio-brcmstb.c
A. R. Silva
>
> Thanks
> --
Using the signature tag in the middle of an email turns the remainder of
the body into a signature block, which is odd to say the least. By all
means sign-off in the middle of a mail, but please refrain from
converting the rest of the mail.
> Gustavo
&
575651c593a9
--
Lee Jones [李琼斯]
16/17] backlight: rave-sp-backlight: Use backlight power constants
commit: 22f8a85ef0c563ba7e53d9ece39c1f2dc99f53ed
[17/17] backlight: sky81452-backlight: Use backlight power constants
commit: 1df5aa3754cac2045998ca505edb84d994786c67
--
Lee Jones [李琼斯]
On Fri, 28 Jun 2024, Lee Jones wrote:
> On Fri, 31 May 2024 19:34:55 +0200, Karel Balej wrote:
> > the following implements basic support for Marvell's 88PM886 PMIC which
> > is found for instance as a component of the samsung,coreprimevelte
> > smartphone which inspired
144396e9570efea02d467df0a68fd28db6f
[4/5] input: add onkey driver for Marvell 88PM886 PMIC
commit: 914089db309ccc590314b6c21df5a1f812e9ab0b
[5/5] MAINTAINERS: add myself for Marvell 88PM886 PMIC
commit: f53d3efa366b1754f0389944401bb53397d22468
--
Lee Jones [李琼斯]
> In particular, the allocation for the array of pointers was converted
> into a single-pointer allocation.
>
> [...]
Applied, thanks!
[1/1] mfd: omap-usb-tll: use struct_size to allocate tll
commit: 1938e6882b89d1d01926ed3e0bbdd8346263c317
--
Lee Jones [李琼斯]
y SY7802 flash LED controller
commit: d0838d7c837820733c4e6b9c6d16323d307ebd96
--
Lee Jones [李琼斯]
> The scoped version of the macro accounts for such early breaks, fixing
> the early exits without the need for explicit calls to of_node_put().
>
> [...]
Applied, thanks!
[1/1] backlight: lm3509_bl: Fix early returns in for_each_child_of_node()
commit: b337cc3ce47549528fc3ee0b8c7ebd
w clear
> what is what.
>
>
> [...]
Applied, thanks!
[1/2] mfd: omap-usb-tll: annotate struct usbtll_omap with __counted_by
commit: 621a62fdd279b06c23bc6c3073b8fe52b5dc356c
--
Lee Jones [李琼斯]
-tll.c
> @@ -230,8 +230,7 @@ static int usbtll_omap_probe(struct platform_device *pdev)
> break;
> }
>
> - tll = devm_kzalloc(dev, sizeof(*tll) + sizeof(tll->ch_clk[nch]),
> -GFP_KERNEL);
> + tll = devm_kzalloc(dev, struct
On Sat, 22 Jun 2024, André Apitzsch wrote:
> Hello Lee,
>
> Am Freitag, dem 21.06.2024 um 11:26 +0100 schrieb Lee Jones:
> > On Sun, 16 Jun 2024, André Apitzsch via B4 Relay wrote:
> >
> > > From: André Apitzsch
> > >
> > > The SY7802 is a
+++
> 3 files changed, 554 insertions(+)
Generally very nice.
Just a couple of teensy nits to fix then add my and resubmit please.
Acked-by: Lee Jones
> diff --git a/drivers/leds/flash/Kconfig b/drivers/leds/flash/Kconfig
> index 809b6d98bb3e..f39f0bfe6eef 100644
> --- a/drivers
er, more experienced maintainer's reviews would also be a good
> > use
> > of your time.
>
> I am trying to influence adjustments in desirable directions for a while.
Never stop trying to improve.
These are only my opinions of course. Take the advice or leave it.
There's no need to reply to this.
--
Lee Jones [李琼斯]
iew points, rather than repeating the same
few over and over? Reading other, more experienced maintainer's reviews
would also be a good use of your time.
--
Lee Jones [李琼斯]
On Fri, 21 Jun 2024, Nuno Sá wrote:
> On Fri, 2024-06-21 at 12:39 +0530, Vinod Koul wrote:
> > On 20-06-24, 18:05, Lee Jones wrote:
> > > On Thu, 20 Jun 2024, Vinod Koul wrote:
> > >
> > > > On 20-06-24, 12:45, Markus Elfring wrote:
> > > &g
o initialization or named designators. But it's also a nice
> cleanup on its own.
>
> [...]
Applied, thanks!
[1/1] backlight: Drop explicit initialization of struct
i2c_device_id::driver_data to 0
commit: bfd3587760498227510acc1b18c4299c7922ffe3
--
Lee Jones [李琼斯]
> The one where all emails from Markus go to dev/null
Play nice please.
Documentation/process/code-of-conduct.rst
--
Lee Jones [李琼斯]
natural as you can.
Ex 1: Please place curly brackets around this section to aid with
Ex 2: To save N lines of clean-up, please use scoped_guard()
Ex 3: Moving out this chunk to another function would help with
Etc.
--
Lee Jones [李琼斯]
MEM;
> > mutex_init(&powernv_led_common->lock);
> > powernv_led_common->max_led_type = cpu_to_be64(OPAL_SLOT_LED_TYPE_MAX);
> > platform_set_drvdata(pdev, powernv_led_common);
> > - rc = powernv_led_classdev(pdev, led_node, powernv_led_common);
> > -out:
> > - of_node_put(led_node);
> > - return rc;
> > + return powernv_led_classdev(pdev, led_node, powernv_led_common);
> > }
> > /* Platform driver remove */
>
> Hello,
> Did you have a chance to look at the patch after the requested change?
Was that for me? Please refrain from pinging.
My TODO list is long and I'm doing my best to get through it.
--
Lee Jones [李琼斯]
in the kernel code.
>
> [...]
Applied, thanks!
[1/1] leds: powernv: replace of_node_put to __free
commit: 7c85503b6d597b84ea58fe3dd95cd9eaeb1f3206
--
Lee Jones [李琼斯]
/video/backlight/rt4831-backlight.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
>
> [...]
Applied, thanks!
[1/1] backlight: add missing MODULE_DESCRIPTION() macros
commit: 7857f5c38d04a38e7a20060a6d370caf0424aa4e
--
Lee Jones [李琼斯]
tion
commit: 90b7f2ead953aab5677ae8235d78841cee8fd13e
--
Lee Jones [李琼斯]
> drivers/regulator/Makefile| 1 +
> 3 files changed, 399 insertions(+)
> create mode 100644 drivers/regulator/88pm886-regulator.c
I'm fine with this set - just waiting for Mark to review.
--
Lee Jones [李琼斯]
now I leave it to Lee and Johan to decide
> the destiny of the drivers.
Let's not rush into it. Take your time.
--
Lee Jones [李琼斯]
> 11 files changed, 2865 deletions(-)
> delete mode 100644 drivers/iio/light/lm3533-als.c
> delete mode 100644 drivers/leds/leds-lm3533.c
> delete mode 100644 drivers/mfd/lm3533-core.c
> delete mode 100644 drivers/video/backlight/lm3533_bl.c
> delete mode 100644 include/linux/mfd/lm3533.h
>
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>
--
Lee Jones [李琼斯]
d_common->lock);
> powernv_led_common->max_led_type = cpu_to_be64(OPAL_SLOT_LED_TYPE_MAX);
>
> platform_set_drvdata(pdev, powernv_led_common);
>
> - rc = powernv_led_classdev(pdev, led_node, powernv_led_common);
> -out:
> - of_node_put(led_node);
> - return rc;
> + return powernv_led_classdev(pdev, led_node, powernv_led_common);
> }
>
> /* Platform driver remove */
> --
> 2.34.1
>
--
Lee Jones [李琼斯]
river
commit: b72755f5b577357cac661cbf9048cad704eb4ad8
--
Lee Jones [李琼斯]
gt; drivers/mfd/Makefile| 1 +
> include/linux/mfd/88pm886.h | 69 +
> 4 files changed, 230 insertions(+)
> create mode 100644 drivers/mfd/88pm886.c
> create mode 100644 include/linux/mfd/88pm886.h
I don't see any more issues.
Are you planning on seeing to Mark's review comments?
--
Lee Jones [李琼斯]
17, 1, "active-low", "active-high"),
> + fld("ii", 16, 1, "normal", "inverted"),
> + fld("pll", 15, 1, "disable", "enable"),
> + fld("gap", 13, 2, "0"),
> + fld("dac", 12, 1, "enable", "disable"),
> + fld("mc", 11, 1, "cpu", "8051"),
> + fld("bl", 10, 8, "1"),
> + fld("usb", 9, 1, "master", "slave"),
> + fld("vr", 4, 1, "0x1e0", "0x3e0"),
> + { .name = NULL },
> +};
I've been avoiding this set for a while now!
I appreciate the amount of work that you've put into this, but this is a
bit of a disaster. It's a hell of lot of over-complex infrastructure
just to pull out some values from DT.
Forgive me if I have this wrong, but it looks like you're defining
various structs then populating static versions with hard-coded offsets
into DT arrays! Then you have a bunch of hoop-jumpy functions to
firstly parse the offset-structs, then conduct look-ups to pull the
final value which in turn gets shifted into an encoded variable ready
for to write out to the registers. Bonkers.
What does 'timing' even mean in this context? Clocks?
What other devices require this kind of handling? Why is this device so
different from all other supported devices to date? Instead of
attempting to shoehorn this into a 20 year old driver, why not reshape
it to bring it into alignment with how we do things today?
E.g. handle all clocking from the clock driver, all display settings
(including timing?) from the display driver, etc.
--
Lee Jones [李琼斯]
earer
> bindings.
>
>
> [...]
Applied, thanks!
[1/1] dt-bindings: leds: add FUNCTION defines for per-band WLANs
commit: 89d9d3eedc8804e06a770e3cf1279f9131b785f1
--
Lee Jones [李琼斯]
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.o
/lcd.h | 6 +++---
scripts/const_structs.checkpatch | 1 +
20 files changed, 23 insertions(+), 22 deletions(-)
--
Lee Jones [李琼斯]
On Sat, 04 May 2024, André Apitzsch wrote:
> Am Freitag, dem 03.05.2024 um 08:19 +0100 schrieb Lee Jones:
> > On Thu, 11 Apr 2024, Lee Jones wrote:
> >
> > > On Mon, 01 Apr 2024, André Apitzsch via B4 Relay wrote:
> > >
> > > > From: André Apitzsch
On Fri, 03 May 2024, Lee Jones wrote:
> On Fri, 03 May 2024, Lee Jones wrote:
>
> > On Wed, 24 Apr 2024 08:33:26 +0200, Krzysztof Kozlowski wrote:
> > > Changes in v2:
> > > - Collect tags, including wrongly places Thomas' tag (which requires me
> > >
On Fri, 03 May 2024, Lee Jones wrote:
> On Wed, 24 Apr 2024 08:33:26 +0200, Krzysztof Kozlowski wrote:
> > Changes in v2:
> > - Collect tags, including wrongly places Thomas' tag (which requires me
> > to manually edit 15 other patches to drop it).
> >
ec6108d768f54d31e7cb48b06c0e3814
--
Lee Jones [李琼斯]
1 - 100 of 3923 matches
Mail list logo
