kmap_local_page() can be unsafe to call from a panic handler, if
CONFIG_HIGHMEM is set, and the page is in the highmem zone.
So add kmap_local_page_try_from_panic() to handle this case.
Suggested-by: Simona Vetter
Reviewed-by: Thomas Gleixner
Signed-off-by: Jocelyn Falempe
---
v3:
* Add a
vice *dev);
int (*reset_done)(struct virtio_device *dev);
+ void (*shutdown)(struct virtio_device *dev);
};
#define drv_to_virtio(__drv) container_of_const(__drv, struct virtio_driver, driver)
Best regards,
--
Jocelyn
On 10/04/2025 14:48, Michael S. Tsirkin wrote:
On Thu, Apr 10, 2025 at 02:33:26PM +0200, Jocelyn Falempe wrote:
On 10/04/2025 09:16, Michael S. Tsirkin wrote:
It looks like GPUs are used by panic after shutdown is invoked.
Thus, breaking virtio gpu in the shutdown callback is not a good idea
On 07/04/2025 15:42, Jocelyn Falempe wrote:
Some drivers like virtio-gpu, don't map the scanout buffer in the
kernel. Calling vmap() in a panic handler is not safe, and writing an
atomic_vmap() API is more complex than expected [1].
So instead, pass the array of pages of the scanout buff
at a time to draw the pixels.
This is obviously slow, but acceptable for a panic handler.
[1]
https://lore.kernel.org/dri-devel/20250305152555.318159-1-ryasu...@redhat.com/
Acked-by: Thomas Zimmermann
Acked-by: Simona Vetter
Signed-off-by: Jocelyn Falempe
---
v3:
* Replace DRM_WARN_ONCE
pages shouldn't be allocated in the get_scanout_buffer() callback.
v3:
* Replace DRM_WARN_ONCE with pr_debug_once (Simona Vetter)
* Add a comment in kmap_local_page_try_from_panic() (Thomas Gleixner)
Jocelyn Falempe (2):
mm/kmap: Add kmap_local_page_try_from_panic()
drm/panic: Add support
On 07/04/2025 15:47, Thomas Zimmermann wrote:
After moving most of the mode-setting pipeline into drm_sysfb_helper.c,
simpledrm_device_of_dev() is no longer being used. Remove it.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
Reported-by
in struct
simpledrm_device.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
Fixes: 11e8f5fd223b ("drm: Add simpledrm driver")
Cc: # v5.14+
---
drivers/gpu/drm/sysfb/simpledrm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
Add #if to define the function only when needed.
Signed-off-by: Jocelyn Falempe
Fixes: 177dfbdb7e67 ("drm/sysfb: Merge primary-plane functions")
---
drivers/gpu/drm/sysfb/simpledrm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/sysfb/simpledrm.c
b/drivers/gpu/d
– LincolnAFM
<https://lincolnafm.wordpress.com/sweet-spirit-alpaca-farm/>
Jocelyn Finlay Photo studio https://jocelynfinlay.com/reservations/
Charlotte Hand drawn gift cards and crochet items Charlotte’s Crafty
Creations – LincolnAFM
<https://lincolnafm.wordpress.com/charlottes-crafty-
drm_panic draws in linear framebuffer, so it's easier to re-use the
current framebuffer, and disable tiling in the panic handler, to show
the panic screen.
Signed-off-by: Jocelyn Falempe
---
.../drm/i915/display/skl_universal_plane.c| 20 +++
1 file changed, 20 inser
On 01/04/2025 15:48, Jani Nikula wrote:
On Tue, 01 Apr 2025, Jocelyn Falempe wrote:
This adds drm_panic support for a wide range of Intel GPU. I've
tested it only on 4 laptops, Haswell (with 128MB of eDRAM),
Comet Lake, Raptor Lake, and Lunar Lake.
For hardware using DPT, it's not p
On this morning (Saturday) 9-1! Come and join us for the Lincoln Arts and Farmers Market, Spring Market. Saturday 5th April, 9-1pmPierce House17 Weston RdLincoln MA 01773Many great vendors will be there with local farm produce, arts and crafts. Spring Market, 5th April 2025Bill HussAlpaca yarnSwe
ple
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/drm_format_helper.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_format_helper.c
b/drivers/gpu/drm/drm_format_helper.c
index 66137df85
kmap_local_page() can be unsafe to call from a panic handler, if
CONFIG_HIGHMEM is set, and the page is in the highmem zone.
So add kmap_local_page_try_from_panic() to handle this case.
Suggested-by: Simona Vetter
Signed-off-by: Jocelyn Falempe
---
include/linux/highmem-internal.h | 12
Come and join us for the Lincoln Arts and Farmers Market, Spring Market. Saturday 5th April, 9-1pmPierce House17 Weston RdLincoln MA 01773Many great vendors will be there with local farm produce, arts and crafts. Spring Market, 5th April 2025Bill HussAlpaca yarnSweet Spirit Alpaca Farm – LincolnAF
Come and join us for the Lincoln Arts and Farmers Market, Spring Market. Saturday 5th April, 9-1pmPierce House17 Weston RdLincoln MA 01773Many great vendors will be there with local farm produce, arts and crafts. Spring Market, 5th April 2025Bill HussAlpaca yarnSweet Spirit Alpaca Farm – LincolnAF
On 01/04/2025 19:57, Ville Syrjälä wrote:
On Tue, Apr 01, 2025 at 08:47:50PM +0300, Ville Syrjälä wrote:
On Tue, Apr 01, 2025 at 02:51:10PM +0200, Jocelyn Falempe wrote:
Prepare the work for drm_panic support. This is used to map the
current framebuffer, so the CPU can overwrite it with the
On 01/04/2025 19:47, Ville Syrjälä wrote:
On Tue, Apr 01, 2025 at 02:51:10PM +0200, Jocelyn Falempe wrote:
Prepare the work for drm_panic support. This is used to map the
current framebuffer, so the CPU can overwrite it with the panic
message.
Signed-off-by: Jocelyn Falempe
---
v5:
* Use
On 01/04/2025 19:57, Ville Syrjälä wrote:
On Tue, Apr 01, 2025 at 08:47:50PM +0300, Ville Syrjälä wrote:
On Tue, Apr 01, 2025 at 02:51:10PM +0200, Jocelyn Falempe wrote:
Prepare the work for drm_panic support. This is used to map the
current framebuffer, so the CPU can overwrite it with the
On 01/04/2025 19:47, Ville Syrjälä wrote:
On Tue, Apr 01, 2025 at 02:51:10PM +0200, Jocelyn Falempe wrote:
Prepare the work for drm_panic support. This is used to map the
current framebuffer, so the CPU can overwrite it with the panic
message.
Signed-off-by: Jocelyn Falempe
---
v5:
* Use
On 01/04/2025 19:38, Ville Syrjälä wrote:
On Tue, Apr 01, 2025 at 02:51:08PM +0200, Jocelyn Falempe wrote:
drm_panic draws in linear framebuffer, so it's easier to re-use the
current framebuffer, and disable tiling in the panic handler, to show
the panic screen.
Signed-off-by: Jocelyn Fa
On 01/04/2025 19:38, Ville Syrjälä wrote:
On Tue, Apr 01, 2025 at 02:51:08PM +0200, Jocelyn Falempe wrote:
drm_panic draws in linear framebuffer, so it's easier to re-use the
current framebuffer, and disable tiling in the panic handler, to show
the panic screen.
Signed-off-by: Jocelyn Fa
On Alder Lake and later, it's not possible to disable tiling when DPT
is enabled.
So this commit implements Y-Tiling support, to still be able to draw
the panic screen.
Signed-off-by: Jocelyn Falempe
---
.../gpu/drm/i915/display/intel_atomic_plane.c | 69 ++-
.../drm
On Alder Lake and later, it's not possible to disable tiling when DPT
is enabled.
So this commit implements 4-Tiling support, to still be able to draw
the panic screen.
Signed-off-by: Jocelyn Falempe
---
.../gpu/drm/i915/display/intel_atomic_plane.c | 22 ++-
1 file change
On Lunar Lake, if the panic occurs when fbcon is active, the panic
screen is only partially visible on the screen. Adding this
intel_frontbuffer_flush() call solves the issue.
It's probably not safe to do that in the panic handler, but that's
still better than nothing.
Signed-off-b
On Alder Lake and later, it's not possible to disable tiling when DPT
is enabled.
So this commit implements Y-Tiling support, to still be able to draw
the panic screen.
Signed-off-by: Jocelyn Falempe
---
.../gpu/drm/i915/display/intel_atomic_plane.c | 69 ++-
.../drm
essing the
framebuffer.
Signed-off-by: Jocelyn Falempe
---
v4:
* Add support for Xe driver.
v6:
* Use struct intel_display instead of drm_i915_private for
intel_atomic_plane.c
.../gpu/drm/i915/display/intel_atomic_plane.c | 79 ++-
1 file changed, 78 insertions(+), 1 deletion(-)
Prepare the work for drm_panic support. This is used to map the
current framebuffer, so the CPU can overwrite it with the panic
message.
Signed-off-by: Jocelyn Falempe
---
v5:
* Use iosys_map for intel_bo_panic_map().
drivers/gpu/drm/i915/display/intel_bo.c| 5
drivers/gpu/drm/i915
On Alder Lake and later, it's not possible to disable tiling when DPT
is enabled.
So this commit implements 4-Tiling support, to still be able to draw
the panic screen.
Signed-off-by: Jocelyn Falempe
---
.../gpu/drm/i915/display/intel_atomic_plane.c | 22 ++-
1 file change
On Lunar Lake, if the panic occurs when fbcon is active, the panic
screen is only partially visible on the screen. Adding this
intel_frontbuffer_flush() call solves the issue.
It's probably not safe to do that in the panic handler, but that's
still better than nothing.
Signed-off-b
drm_panic draws in linear framebuffer, so it's easier to re-use the
current framebuffer, and disable tiling in the panic handler, to show
the panic screen.
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/i915/display/i9xx_plane.c | 23 +++
.../drm/i915/di
essing the
framebuffer.
Signed-off-by: Jocelyn Falempe
---
v4:
* Add support for Xe driver.
v6:
* Use struct intel_display instead of drm_i915_private for
intel_atomic_plane.c
.../gpu/drm/i915/display/intel_atomic_plane.c | 79 ++-
1 file changed, 78 insertions(+), 1 deletion(-)
Prepare the work for drm_panic support. This is used to map the
current framebuffer, so the CPU can overwrite it with the panic
message.
Signed-off-by: Jocelyn Falempe
---
v5:
* Use iosys_map for intel_bo_panic_map().
drivers/gpu/drm/i915/display/intel_bo.c| 5
drivers/gpu/drm/i915
/i915/kernel.git
drm-intel-next
* Use struct intel_display instead of drm_i915_private for intel_atomic_plane.c
Jocelyn Falempe (8):
drm/i915/fbdev: Add intel_fbdev_get_map()
drm/i915/display/i9xx: Add a disable_tiling() for i9xx planes
drm/i915/display: Add a disable_tiling() for skl planes
drm_panic draws in linear framebuffer, so it's easier to re-use the
current framebuffer, and disable tiling in the panic handler, to show
the panic screen.
Signed-off-by: Jocelyn Falempe
---
.../drm/i915/display/skl_universal_plane.c| 20 +++
1 file changed, 20 inser
drm_panic draws in linear framebuffer, so it's easier to re-use the
current framebuffer, and disable tiling in the panic handler, to show
the panic screen.
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/i915/display/i9xx_plane.c | 23 +++
.../drm/i915/di
The vaddr of the fbdev framebuffer is private to the struct
intel_fbdev, so this function is needed to access it for drm_panic.
Also the struct i915_vma is different between i915 and xe, so it
requires a few functions to access fbdev->vma->iomap.
Signed-off-by: Jocelyn Falempe
---
v2:
/i915/kernel.git
drm-intel-next
* Use struct intel_display instead of drm_i915_private for intel_atomic_plane.c
Jocelyn Falempe (8):
drm/i915/fbdev: Add intel_fbdev_get_map()
drm/i915/display/i9xx: Add a disable_tiling() for i9xx planes
drm/i915/display: Add a disable_tiling() for skl planes
The vaddr of the fbdev framebuffer is private to the struct
intel_fbdev, so this function is needed to access it for drm_panic.
Also the struct i915_vma is different between i915 and xe, so it
requires a few functions to access fbdev->vma->iomap.
Signed-off-by: Jocelyn Falempe
---
v2:
On 25/03/2025 20:04, Miguel Ojeda wrote:
On Tue, Mar 25, 2025 at 10:05 AM Jocelyn Falempe wrote:
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
You want to take the whole series in the rust tree?
Otherwise I can push the patch 1-2 to drm-misc-next if needed.
Please take them
existing line-conversion functions with the new
generic call and the respective pixel-conversion helper.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/drm_format_helper.c | 38 ++-
drivers/gpu/drm
=> multiple
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/drm_format_helper.c | 40 -
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_format_helper.c
b/drivers/gpu/drm/drm_format_helper.c
in
On 25/03/2025 11:31, Thomas Zimmermann wrote:
For ease of implementation, existing line-conversion functions
for 24-bit formats write each byte individually. Optimize the
performance by writing 4 pixels in 3 32-bit stores.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed
existing line-conversion functions with the new
generic call and the respective pixel-conversion helper. There's one
pixel-conversion helper that swaps output bytes. It is for gud and
requires refactoring, so don't move it into the header file.
Thanks, it looks good to me.
Reviewed-b
existing line-conversion functions with the new
generic call and the respective pixel-conversion helper.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/drm_format_helper.c | 43 ---
drivers/gpu/drm
existing line-conversion functions with the new
generic call and the respective pixel-conversion helper.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/drm_format_helper.c | 84 +++--
1 file changed
format conversion helpers.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/drm_draw.c| 100 +++---
drivers/gpu/drm/drm_format_internal.h | 119 ++
2 files changed, 130 insertions
On 24/03/2025 10:44, Thomas Zimmermann wrote:
Reimplement ast_mode_config_mode_valid() with DRM format helpers and
ast's helpers for framebuffer size calculation. Replaces ast's open-
coded assumptions on bpp and page-alignments.
Thanks, it looks good to me.
Reviewed-by: Jocel
On 24/03/2025 22:03, Miguel Ojeda wrote:
Add missing Markdown code span.
This was found using the Clippy `doc_markdown` lint, which we may want
to enable.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
You want to take the whole series in the rust tree?
Otherwise I can push the
On 24/03/2025 22:03, Miguel Ojeda wrote:
Add missing space in sentence.
This was found using the Clippy `doc_markdown` lint, which we may want
to enable.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Fixes: cb5164ac43d0 ("drm/panic: Add a QR code panic screen")
Sig
, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
Fixes: 1fe182154984 ("drm/ast: Acquire I/O-register lock in atomic_commit_tail
function")
Cc: Thomas Zimmermann
Cc: Jocelyn Falempe
Cc: Dave Airlie
Cc: dri-devel@lists.freedesktop.org
C
. This cannot legally happen.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/ast/ast_cursor.c | 8 +++-
drivers/gpu/drm/ast/ast_drv.h| 4 ++--
drivers/gpu/drm/ast/ast_mode.c | 19 ---
3 files
pages shouldn't be allocated in the get_scanout_buffer() callback.
Jocelyn Falempe (2):
mm/kmap: Add kmap_local_page_try_from_panic()
drm/panic: Add support to scanout buffer as array of pages
drivers/gpu/drm/drm_panic.c | 142 +--
include/drm/drm_panic.h
at a time to draw the pixels.
This is obviously slow, but acceptable for a panic handler.
[1]
https://lore.kernel.org/dri-devel/20250305152555.318159-1-ryasu...@redhat.com/
Signed-off-by: Jocelyn Falempe
Acked-by: Thomas Zimmermann
---
drivers/gpu/drm/drm_panic.c
at a time to draw the pixels.
This is obviously slow, but acceptable for a panic handler.
[1]
https://lore.kernel.org/dri-devel/20250305152555.318159-1-ryasu...@redhat.com/
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/drm_panic.c | 139 ++--
includ
On 05/03/2025 17:30, Thomas Zimmermann wrote:
The ast drivers stores the cursor image at the end of the video memory.
Add helpers to calculate the offset and size.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/ast
On 05/03/2025 14:35, Thomas Zimmermann wrote:
Add register constants for VGACRAA and use them when detecting the
size of the VGA memory. Aligns the code with the programming manual.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers
unused and the default size is not
necessary. Remove both of them.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/ast/ast_drv.h | 8
drivers/gpu/drm/ast/ast_mm.c | 9 -
drivers/gpu/drm/ast/ast_p
sure you can use the extra
bytes.
Otherwise, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/ast/ast_cursor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ast/ast_cursor.c b/drivers/gpu/dr
: Jocelyn Falempe
v2:
- initialize plane size
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/ast/ast_cursor.c | 18 --
drivers/gpu/drm/ast/ast_drv.h| 4
drivers/gpu/drm/ast/ast_mm.c | 1 -
3 files changed, 4 insertions(+), 19 deletions(-)
diff --git a
On 05/03/2025 17:30, Thomas Zimmermann wrote:
The ast driver stores the primary plane's image in the framebuffer
memory up to where the cursor is located. Add helpers to calculate
the offset and size.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: T
ed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/ast/ast_mm.c | 13 ++---
drivers/gpu/drm/ast/ast_reg.h | 1 +
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_mm.c b/drivers/gpu/drm/ast/ast_mm.c
index 8d8aac8c0814..3d03ef5
On 05/03/2025 17:30, Thomas Zimmermann wrote:
Add register constants for VGACRAA and use them when detecting the
size of the VGA memory. Aligns the code with the programming manual.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers
On 05/03/2025 14:35, Thomas Zimmermann wrote:
The ast drivers stores the cursor image at the end of the video memory.
Add helpers to calculate the offset and size.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/ast
ed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/ast/ast_mm.c | 13 ++---
drivers/gpu/drm/ast/ast_reg.h | 1 +
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_mm.c b/drivers/gpu/drm/ast/ast_mm.c
index 8d8aac8
unused and the default size is not
necessary. Remove both of them.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/ast/ast_drv.h | 8
drivers/gpu/drm/ast/ast_mm.c | 9 -
drivers/gpu/drm/ast/ast_p
On 09/03/2025 09:07, Ryosuke Yasuoka wrote:
On Fri, Mar 7, 2025 at 4:55 PM Jocelyn Falempe wrote:
On 06/03/2025 16:52, Simona Vetter wrote:
On Thu, Mar 06, 2025 at 02:24:51PM +0100, Jocelyn Falempe wrote:
On 06/03/2025 05:52, Matthew Wilcox wrote:
On Thu, Mar 06, 2025 at 12:25:53AM +0900
On 06/03/2025 16:52, Simona Vetter wrote:
On Thu, Mar 06, 2025 at 02:24:51PM +0100, Jocelyn Falempe wrote:
On 06/03/2025 05:52, Matthew Wilcox wrote:
On Thu, Mar 06, 2025 at 12:25:53AM +0900, Ryosuke Yasuoka wrote:
Some drivers can use vmap in drm_panic, however, vmap is sleepable and
takes
taken. (In the panic handler, only 1 CPU
remain active, so it's unlikely the lock would be released anyway).
If we need to pre-allocate the page table and reserve the vmap area,
maybe it would be easier to just always vmap() the primary framebuffer,
so it can be used in the panic handler?
Best regards,
--
Jocelyn
eries?
Sorry, should have gotten back to you sooner. Xe was working with the
series applied. :)
Hi,
Is it possible to also review and merge i915 vmap support?
https://patchwork.freedesktop.org/series/135554/
This is required to have drm_log working on i915
Best regards,
--
Jocelyn
C
eries?
Sorry, should have gotten back to you sooner. Xe was working with the
series applied. :)
Hi,
Is it possible to also review and merge i915 vmap support?
https://patchwork.freedesktop.org/series/135554/
This is required to have drm_log working on i915
Best regards,
--
Jocelyn
C
ze}`
The signature declarations are moved to a header file so it can be
included in the Rust bindings helper, and the extern keyword is removed
as it is unnecessary.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Reviewed-by: Andreas Hindborg
Reviewed-by: Tamir Duberstein
Ack
On 13/02/2025 17:25, Thomas Zimmermann wrote:
Add support for cursor image data in ARGB format. This is the
hardware's native format and requires no conversion.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/dr
On 13/02/2025 17:25, Thomas Zimmermann wrote:
Move the cursor code into a separate source file for readability. No
functional changes.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/ast/Makefile | 1 +
drivers/gpu
area (And I'm not sure userspace actually change only parts of the cursor).
The format-conversion helper still contains the old implementation's
optimization of writing 2 output pixels at the same time.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe
Signed
to move the
typo: helper
format conversion into a shared helper.
Thanks, I've only one remark below, but you can keep it as-is if you prefer.
Reviewed-by: Jocelyn Falempe
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/ast/ast_drv.h | 13 +++-
drivers/gpu/drm/ast/ast_m
On Alder Lake and later, it's not possible to disable tiling when DPT
is enabled.
So this commit implements 4-Tiling support, to still be able to draw
the panic screen.
Signed-off-by: Jocelyn Falempe
---
.../gpu/drm/i915/display/intel_atomic_plane.c | 22 ++-
1 file change
drm_panic draws in linear framebuffer, so it's easier to re-use the
current framebuffer, and disable tiling in the panic handler, to show
the panic screen.
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/i915/display/i9xx_plane.c | 23 +++
.../drm/i915/di
On Alder Lake and later, it's not possible to disable tiling when DPT
is enabled.
So this commit implements 4-Tiling support, to still be able to draw
the panic screen.
Signed-off-by: Jocelyn Falempe
---
.../gpu/drm/i915/display/intel_atomic_plane.c | 22 ++-
1 file change
On Alder Lake and later, it's not possible to disable tiling when DPT
is enabled.
So this commit implements Y-Tiling support, to still be able to draw
the panic screen.
Signed-off-by: Jocelyn Falempe
---
.../gpu/drm/i915/display/intel_atomic_plane.c | 69 ++-
.../drm
On Alder Lake and later, it's not possible to disable tiling when DPT
is enabled.
So this commit implements Y-Tiling support, to still be able to draw
the panic screen.
Signed-off-by: Jocelyn Falempe
---
.../gpu/drm/i915/display/intel_atomic_plane.c | 69 ++-
.../drm
On Lunar Lake, if the panic occurs when fbcon is active, the panic
screen is only partially visible on the screen. Adding this
intel_frontbuffer_flush() call solves the issue.
It's probably not safe to do that in the panic handler, but that's
still better than nothing.
Signed-off-b
On Lunar Lake, if the panic occurs when fbcon is active, the panic
screen is only partially visible on the screen. Adding this
intel_frontbuffer_flush() call solves the issue.
It's probably not safe to do that in the panic handler, but that's
still better than nothing.
Signed-off-b
essing the
framebuffer.
Signed-off-by: Jocelyn Falempe
---
v4:
* Add support for Xe driver.
.../gpu/drm/i915/display/intel_atomic_plane.c | 79 ++-
1 file changed, 78 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
b/drivers/gpu/drm/i9
essing the
framebuffer.
Signed-off-by: Jocelyn Falempe
---
v4:
* Add support for Xe driver.
.../gpu/drm/i915/display/intel_atomic_plane.c | 79 ++-
1 file changed, 78 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
b/drivers/gpu/drm/i9
nd in newest GPU.
v5:
* Rebase on top of g...@gitlab.freedesktop.org:drm/i915/kernel.git
drm-intel-next
* Use struct intel_display instead of drm_i915_private.
* Use iosys_map for intel_bo_panic_map().
Jocelyn Falempe (8):
drm/i915/fbdev: Add intel_fbdev_get_map()
drm/i915/display/i9xx:
Prepare the work for drm_panic support. This is used to map the
current framebuffer, so the CPU can overwrite it with the panic
message.
Signed-off-by: Jocelyn Falempe
---
v5:
* Use iosys_map for intel_bo_panic_map().
drivers/gpu/drm/i915/display/intel_bo.c| 5
drivers/gpu/drm/i915
Prepare the work for drm_panic support. This is used to map the
current framebuffer, so the CPU can overwrite it with the panic
message.
Signed-off-by: Jocelyn Falempe
---
v5:
* Use iosys_map for intel_bo_panic_map().
drivers/gpu/drm/i915/display/intel_bo.c| 5
drivers/gpu/drm/i915
drm_panic draws in linear framebuffer, so it's easier to re-use the
current framebuffer, and disable tiling in the panic handler, to show
the panic screen.
Signed-off-by: Jocelyn Falempe
---
.../drm/i915/display/skl_universal_plane.c| 20 +++
1 file changed, 20 inser
drm_panic draws in linear framebuffer, so it's easier to re-use the
current framebuffer, and disable tiling in the panic handler, to show
the panic screen.
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/i915/display/i9xx_plane.c | 23 +++
.../drm/i915/di
drm_panic draws in linear framebuffer, so it's easier to re-use the
current framebuffer, and disable tiling in the panic handler, to show
the panic screen.
Signed-off-by: Jocelyn Falempe
---
.../drm/i915/display/skl_universal_plane.c| 20 +++
1 file changed, 20 inser
The vaddr of the fbdev framebuffer is private to the struct
intel_fbdev, so this function is needed to access it for drm_panic.
Also the struct i915_vma is different between i915 and xe, so it
requires a few functions to access fbdev->vma->iomap.
Signed-off-by: Jocelyn Falempe
---
v2:
The vaddr of the fbdev framebuffer is private to the struct
intel_fbdev, so this function is needed to access it for drm_panic.
Also the struct i915_vma is different between i915 and xe, so it
requires a few functions to access fbdev->vma->iomap.
Signed-off-by: Jocelyn Falempe
---
v2:
nd in newest GPU.
v5:
* Rebase on top of g...@gitlab.freedesktop.org:drm/i915/kernel.git
drm-intel-next
* Use struct intel_display instead of drm_i915_private.
* Use iosys_map for intel_bo_panic_map().
Jocelyn Falempe (8):
drm/i915/fbdev: Add intel_fbdev_get_map()
drm/i915/display/i9xx:
patch <https://xba.soartist.net/ast-drm_nba_20250211/nba-dump/
ast-fullpatch.patch>
Diff is about 250+ kb so the 2 drivers seems to have nothing to do with
each others...
Thanks again for help
Kind regards
Nicolas
Le 2025-02-13 08:57, Thomas Zimmermann a écrit :
Hi Nicolas
Am 12.02.25 um 19:58
https://bugs.kde.org/show_bug.cgi?id=500043
--- Comment #3 from Jocelyn ---
Created attachment 178350
--> https://bugs.kde.org/attachment.cgi?id=178350&action=edit
Image of the Metadata Behaviour settings I have selected
I've selected "Delegate to ExifTool backend all op
https://bugs.kde.org/show_bug.cgi?id=500043
Bug ID: 500043
Summary: GPS being deleted from .mp4 when I "Read metadata from
file to database"
Classification: Applications
Product: digikam
Version: 8.5.0
Platform: Microso
On 13/02/2025 15:01, Thomas Zimmermann wrote:
Hi
Am 13.02.25 um 14:33 schrieb Jocelyn Falempe:
Hi Thomas and Jammy,
I've got a regression report, and it's caused by https://
patchwork.freedesktop.org/patch/540015/
On this ast2600 server, the firmware says it has a DP output, but
ixing the firmware would be the best solution, it's not
always possible.
I'm considering different options:
- Add a kernel module parameter to override the tx_chip_types, something
like "ast.output=vga"
- Add a DMI quirk, to force vga on this particular motherboard.
What do you think?
Best regards,
--
Jocelyn
1 - 100 of 1434 matches
Mail list logo
