On Fri, Apr 11, 2025 at 10:32:45AM +0200, Stefano Garzarella wrote:
> On Thu, Apr 10, 2025 at 06:07:59PM -0700, Bobby Eshleman wrote:
> > This commit introduces a new vmtest.sh runner for vsock.
> >
> > It uses virtme-ng/qemu to run tests in a VM. The tests are designed to
:
$ tools/testing/selftests/vsock/vmtest.sh
Signed-off-by: Bobby Eshleman
---
MAINTAINERS| 1 +
tools/testing/selftests/vsock/.gitignore | 1 +
tools/testing/selftests/vsock/config.vsock | 6 +
tools/testing/selftests/vsock/vmtest.sh| 247
On Thu, Apr 03, 2025 at 11:33:14AM +0200, Stefano Garzarella wrote:
> On Wed, Apr 02, 2025 at 03:28:19PM -0700, Bobby Eshleman wrote:
> > On Wed, Apr 02, 2025 at 03:18:13PM -0700, Bobby Eshleman wrote:
> > > On Wed, Apr 02, 2025 at 10:21:36AM +0100, Daniel P. Berrangé wrote:
>
On Wed, Apr 02, 2025 at 03:18:13PM -0700, Bobby Eshleman wrote:
> On Wed, Apr 02, 2025 at 10:21:36AM +0100, Daniel P. Berrangé wrote:
> > On Wed, Apr 02, 2025 at 10:13:43AM +0200, Stefano Garzarella wrote:
> > > On Wed, 2 Apr 2025 at 02:21, Bobby Eshleman
> > > wrote
On Wed, Apr 02, 2025 at 10:21:36AM +0100, Daniel P. Berrangé wrote:
> On Wed, Apr 02, 2025 at 10:13:43AM +0200, Stefano Garzarella wrote:
> > On Wed, 2 Apr 2025 at 02:21, Bobby Eshleman wrote:
> > >
> > > I do like Stefano's suggestion to add a sysctl for a &quo
On Tue, Apr 01, 2025 at 08:05:16PM +0100, Daniel P. Berrangé wrote:
> On Fri, Mar 28, 2025 at 06:03:19PM +0100, Stefano Garzarella wrote:
> > CCing Daniel
> >
> > On Wed, Mar 12, 2025 at 01:59:34PM -0700, Bobby Eshleman wrote:
> > > Picking up Stefano's v1 [1]
On Fri, Mar 28, 2025 at 05:19:44PM +0100, Stefano Garzarella wrote:
> On Fri, Mar 28, 2025 at 09:07:22AM -0700, Bobby Eshleman wrote:
> > On Thu, Mar 27, 2025 at 10:14:59AM +0100, Stefano Garzarella wrote:
> > > On Tue, Mar 25, 2025 at 05:11:49PM -0700, Bobby Eshleman wrote:
>
On Fri, Mar 28, 2025 at 06:03:19PM +0100, Stefano Garzarella wrote:
> CCing Daniel
>
> On Wed, Mar 12, 2025 at 01:59:34PM -0700, Bobby Eshleman wrote:
> > Picking up Stefano's v1 [1], this series adds netns support to
> > vhost-vsock. Unlike v1, this series does not
On Thu, Mar 27, 2025 at 10:14:59AM +0100, Stefano Garzarella wrote:
> On Tue, Mar 25, 2025 at 05:11:49PM -0700, Bobby Eshleman wrote:
> > On Fri, Mar 21, 2025 at 11:02:34AM +0100, Stefano Garzarella wrote:
> > > On Thu, Mar 20, 2025 at 02:05:38PM -0700, Bobby Eshleman wrote:
>
On Fri, Mar 21, 2025 at 11:02:34AM +0100, Stefano Garzarella wrote:
> On Thu, Mar 20, 2025 at 02:05:38PM -0700, Bobby Eshleman wrote:
> > On Thu, Mar 20, 2025 at 10:08:02AM +0100, Stefano Garzarella wrote:
> > > On Wed, Mar 19, 2025 at 10:09:44PM +0100, Paolo Abeni wrote:
>
On Fri, Mar 21, 2025 at 03:49:38PM -0400, Michael S. Tsirkin wrote:
> On Wed, Mar 12, 2025 at 01:59:34PM -0700, Bobby Eshleman wrote:
> > Picking up Stefano's v1 [1], this series adds netns support to
> > vhost-vsock. Unlike v1, this series does not address guest-to-host
On Fri, Mar 21, 2025 at 11:02:34AM +0100, Stefano Garzarella wrote:
> On Thu, Mar 20, 2025 at 02:05:38PM -0700, Bobby Eshleman wrote:
> > On Thu, Mar 20, 2025 at 10:08:02AM +0100, Stefano Garzarella wrote:
> > > On Wed, Mar 19, 2025 at 10:09:44PM +0100, Paolo Abeni wrote:
>
On Thu, Mar 20, 2025 at 10:08:02AM +0100, Stefano Garzarella wrote:
> On Wed, Mar 19, 2025 at 10:09:44PM +0100, Paolo Abeni wrote:
> > On 3/12/25 9:59 PM, Bobby Eshleman wrote:
> > > @@ -753,6 +783,8 @@ static int vhost_vsock_dev_release(struct inode
> > >
On Wed, Mar 19, 2025 at 10:09:44PM +0100, Paolo Abeni wrote:
> On 3/12/25 9:59 PM, Bobby Eshleman wrote:
> > @@ -753,6 +783,8 @@ static int vhost_vsock_dev_release(struct inode *inode,
> > struct file *file)
> > virtio_vsock_skb_queue_purge(&
On Thu, Mar 20, 2025 at 09:57:57AM +0100, Stefano Garzarella wrote:
> On Wed, Mar 19, 2025 at 12:00:38PM -0700, Bobby Eshleman wrote:
> > On Wed, Mar 19, 2025 at 02:02:32PM +0100, Stefano Garzarella wrote:
> > > On Wed, Mar 12, 2025 at 01:59:35PM -0700, Bobby Eshleman wrote:
>
On Wed, Mar 19, 2025 at 03:15:36PM +0100, Stefano Garzarella wrote:
> On Wed, Mar 12, 2025 at 01:59:37PM -0700, Bobby Eshleman wrote:
> > From: Stefano Garzarella
> >
> > This patch assigns the network namespace of the process that opened
> > vhost-vsock-netns devic
On Wed, Mar 19, 2025 at 02:26:04PM +0100, Stefano Garzarella wrote:
> On Wed, Mar 12, 2025 at 01:59:36PM -0700, Bobby Eshleman wrote:
> > From: Stefano Garzarella
> >
> > This patch allows transports that use virtio_transport_common
> > to specify the network namespace
On Wed, Mar 19, 2025 at 02:02:32PM +0100, Stefano Garzarella wrote:
> On Wed, Mar 12, 2025 at 01:59:35PM -0700, Bobby Eshleman wrote:
> > From: Stefano Garzarella
> >
> > This patch adds a check of the "net" assigned to a socket during
> &
On Thu, Mar 13, 2025 at 04:37:16PM +0100, Stefano Garzarella wrote:
> Hi Bobby,
> first of all, thank you for starting this work again!
>
You're welcome, thank you for your work getting it started!
> On Wed, Mar 12, 2025 at 07:28:33PM -0700, Bobby Eshleman wrote:
> > Hey
Hey all,
Apologies for forgetting the 'net-next' prefix on this one. Should I
resend or no?
Best,
Bobby
On Wed, Mar 12, 2025 at 01:59:34PM -0700, Bobby Eshleman wrote:
> Picking up Stefano's v1 [1], this series adds netns support to
> vhost-vsock. Unlike v1, this series d
On Tue, Mar 11, 2025 at 08:59:44AM +0800, Jason Wang wrote:
> On Tue, Mar 11, 2025 at 4:14 AM Bobby Eshleman
> wrote:
> >
> > On Wed, Mar 05, 2025 at 01:46:54PM +0800, Jason Wang wrote:
> > > On Wed, Mar 5, 2025 at 8:39 AM Bobby Eshleman
> > > wrote:
> &
VMs, running in different
network namespace, with the same CID/port.
This patch brings namespace support only to vhost-vsock, but not
to virtio-vsock, hyperv, or vmci.
Signed-off-by: Stefano Garzarella
Signed-off-by: Bobby Eshleman
---
v1 -> v2
* removed 'netns' module par
serves old behavior, and does not yet bring up namespace
support fully.
Signed-off-by: Stefano Garzarella
Signed-off-by: Bobby Eshleman
---
v1 -> v2:
* remove 'netns' module param
* remove vsock_net_eq()
* use vsock_global_net() for "global" namespace
* use fallback logic i
Garzarella
Signed-off-by: Bobby Eshleman
---
V1 -> V2
* use vsock_global_net()
* add net to skb->cb
* forward port for skb
---
drivers/vhost/vsock.c | 1 +
include/linux/virtio_vsock.h| 2 ++
net/vmw_vsock/virtio_transport.c| 1 +
net/vmw
st cid: Address already in use
Signed-off-by: Bobby Eshleman
---
Changes in v2:
- only support vhost-vsock namespaces
- all g2h namespaces retain old behavior, only common API changes
impacted by vhost-vsock changes
- add /dev/vhost-vsock-netns for "opt-in"
- leave /dev/vhost-vsock to old
On Wed, Mar 05, 2025 at 01:46:54PM +0800, Jason Wang wrote:
> On Wed, Mar 5, 2025 at 8:39 AM Bobby Eshleman wrote:
> >
> > On Tue, Apr 28, 2020 at 06:00:52PM +0200, Stefano Garzarella wrote:
> > > On Tue, Apr 28, 2020 at 04:13:22PM +0800, Jason Wang wrote:
> >
>
On Wed, Mar 05, 2025 at 05:07:13PM +0100, Stefano Garzarella wrote:
> On Wed, 5 Mar 2025 at 16:55, Bobby Eshleman wrote:
> >
> > Do you know of any use cases for guest-side vsock netns?
>
> Yep, as I mentioned in another mail this morning, the use case is
> nested VMs
On Wed, Mar 05, 2025 at 10:42:58AM +0100, Stefano Garzarella wrote:
> On Tue, Mar 04, 2025 at 04:06:02PM -0800, Bobby Eshleman wrote:
> > On Thu, Jan 16, 2020 at 06:24:25PM +0100, Stefano Garzarella wrote:
> >
> > One question: what is the behavior we expect from guest namesp
On Wed, Mar 05, 2025 at 10:30:17AM +0100, Stefano Garzarella wrote:
> On Wed, Mar 05, 2025 at 02:27:12AM -0500, Michael S. Tsirkin wrote:
> > On Tue, Mar 04, 2025 at 04:39:02PM -0800, Bobby Eshleman wrote:
> > > I think it might be a lot of complexity to bring into the picture
On Wed, Mar 05, 2025 at 10:23:08AM +0100, Stefano Garzarella wrote:
> On Wed, 5 Mar 2025 at 08:32, Michael S. Tsirkin wrote:
> >
[...]
> >
> >
> > I'm not sure I understand the usecase. Can you explain a bit more,
> > please?
>
> It's been five years, but I'm trying!
> We are tracking this RFE
On Tue, Apr 28, 2020 at 06:00:52PM +0200, Stefano Garzarella wrote:
> On Tue, Apr 28, 2020 at 04:13:22PM +0800, Jason Wang wrote:
> >
> >
> > As we've discussed, it should be a netdev probably in either guest or host
> > side. And it would be much simpler if we want do implement namespace then.
>
On Thu, Jan 16, 2020 at 06:24:25PM +0100, Stefano Garzarella wrote:
> RFC -> v1:
> * added 'netns' module param to vsock.ko to enable the
>network namespace support (disabled by default)
> * added 'vsock_net_eq()' to check the "net" assigned to a socket
>only when 'netns' support is enabl
On Wed, Sep 06, 2023 at 04:28:12PM +0200, Stefano Garzarella wrote:
> On Sat, Sep 02, 2023 at 04:35:25AM -0400, Michael S. Tsirkin wrote:
> > On Sat, Sep 02, 2023 at 04:56:42AM +0000, Bobby Eshleman wrote:
> > > On Fri, Sep 01, 2023 at 02:45:14PM +0200, Stefano Garzarella wro
On Wed, Sep 06, 2023 at 04:17:59AM -0400, Michael S. Tsirkin wrote:
> On Sat, Sep 02, 2023 at 09:24:26AM +0000, Bobby Eshleman wrote:
> > On Sat, Sep 02, 2023 at 04:41:28AM -0400, Michael S. Tsirkin wrote:
> > > On Sat, Sep 02, 2023 at 04:37:19AM +0000, Bobby Eshleman wrote:
>
On Sat, Sep 02, 2023 at 04:35:25AM -0400, Michael S. Tsirkin wrote:
> On Sat, Sep 02, 2023 at 04:56:42AM +0000, Bobby Eshleman wrote:
> > On Fri, Sep 01, 2023 at 02:45:14PM +0200, Stefano Garzarella wrote:
> > > On Tue, Aug 29, 2023 at 09:29:45PM +0000, Bobby Eshleman wrote:
On Sat, Sep 02, 2023 at 04:41:28AM -0400, Michael S. Tsirkin wrote:
> On Sat, Sep 02, 2023 at 04:37:19AM +0000, Bobby Eshleman wrote:
> > On Fri, Sep 01, 2023 at 09:31:03AM -0400, Michael S. Tsirkin wrote:
> > > On Wed, Aug 30, 2023 at 12:43:03AM +0000, Bobby Eshleman wrote:
>
On Fri, Sep 01, 2023 at 02:45:14PM +0200, Stefano Garzarella wrote:
> On Tue, Aug 29, 2023 at 09:29:45PM +0000, Bobby Eshleman wrote:
> > This adds support for datagrams to the virtio-vsock device.
> >
> > virtio-vsock already supports stream and seqpacket types. The exist
On Fri, Sep 01, 2023 at 09:31:03AM -0400, Michael S. Tsirkin wrote:
> On Wed, Aug 30, 2023 at 12:43:03AM +0000, Bobby Eshleman wrote:
> > On Tue, Aug 29, 2023 at 06:21:35PM -0400, Michael S. Tsirkin wrote:
> > > On Tue, Aug 29, 2023 at 09:29:45PM +0000, Bobby Eshleman wrote:
On Tue, Aug 29, 2023 at 06:21:35PM -0400, Michael S. Tsirkin wrote:
> On Tue, Aug 29, 2023 at 09:29:45PM +0000, Bobby Eshleman wrote:
> > This adds support for datagrams to the virtio-vsock device.
> >
> > virtio-vsock already supports stream and seqpacket types. The exist
t; __aligned(STACK_SIZE);
>
> -/*
> - * To be sure that .bss isn't zero. It will simplify code of
> - * .bss initialization.
> - * TODO:
> - * To be deleted when the first real .bss user appears
> - */
> -int dummy_bss __attribute__((unused));
> -
> void __init noreturn start_xen(unsigned long bootcpu_id,
> paddr_t dtb_addr)
> {
> --
> 2.40.1
>
>
Acked-by: Bobby Eshleman
d update CSR_STVEC with it.
> + * MMU is configured in a way where linker addresses are mapped
> + * on load addresses so in a case when linker addresses are not equal
> + * to load addresses, after MMU is enabled, it will cause
> + * an exception and jump to linker time addresses.
> + * Otherwise if load addresses are equal to linker addresses the code
> + * after mmu_is_enabled label will be executed without exception.
> + */
> +csr_write(CSR_STVEC, LOAD_TO_LINK((unsigned long)&&mmu_is_enabled));
> +
> +/* Ensure page table writes precede loading the SATP */
> +sfence_vma();
> +
> +/* Enable the MMU and load the new pagetable for Xen */
> +csr_write(CSR_SATP,
> + PFN_DOWN((unsigned long)stage1_pgtbl_root) |
> + RV_STAGE1_MODE << SATP_MODE_SHIFT);
> +
> +asm volatile ( ".p2align 2" );
> + mmu_is_enabled:
> +/*
> + * Stack should be re-inited as:
> + * 1. Right now an address of the stack is relative to load time
> + *addresses what will cause an issue in case of load start address
> + *isn't equal to linker start address.
> + * 2. Addresses in stack are all load time relative which can be an
> + *issue in case when load start address isn't equal to linker
> + *start address.
> + *
> + * We can't return to the caller because the stack was reseted
> + * and it may have stash some variable on the stack.
> + * Jump to a brand new function as the stack was reseted
> + */
> +
> +switch_stack_and_jump((unsigned long)cpu0_boot_stack + STACK_SIZE,
> + cont_after_mmu_is_enabled);
> +}
> +
> diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c
> index 3786f337e0..315804aa87 100644
> --- a/xen/arch/riscv/setup.c
> +++ b/xen/arch/riscv/setup.c
> @@ -2,6 +2,7 @@
> #include
>
> #include
> +#include
>
> /* Xen stack for bringing up the first CPU. */
> unsigned char __initdata cpu0_boot_stack[STACK_SIZE]
> @@ -26,3 +27,13 @@ void __init noreturn start_xen(unsigned long bootcpu_id,
>
> unreachable();
> }
> +
> +void __init noreturn cont_after_mmu_is_enabled(void)
> +{
> +early_printk("All set up\n");
> +
> +for ( ;; )
> +asm volatile ("wfi");
> +
> +unreachable();
> +}
> diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S
> index 31e0d3576c..fe475d096d 100644
> --- a/xen/arch/riscv/xen.lds.S
> +++ b/xen/arch/riscv/xen.lds.S
> @@ -172,3 +172,6 @@ ASSERT(IS_ALIGNED(__bss_end,POINTER_ALIGN),
> "__bss_end is misaligned")
>
> ASSERT(!SIZEOF(.got), ".got non-empty")
> ASSERT(!SIZEOF(.got.plt), ".got.plt non-empty")
> +
> +ASSERT(_end - _start <= MB(2), "Xen too large for early-boot assumptions")
> +
> --
> 2.40.1
>
>
LGTM. Nice code to boot!
Acked-by: Bobby Eshleman
. = ALIGN(POINTER_ALIGN);
> __bss_start = .;
> *(.bss.stack_aligned)
> -. = ALIGN(PAGE_SIZE);
> *(.bss.page_aligned)
> . = ALIGN(PAGE_SIZE);
> __per_cpu_start = .;
> --
> 2.40.1
>
>
Acked-by: Bobby Eshleman
/arch/riscv/setup.c
> +++ b/xen/arch/riscv/setup.c
> @@ -21,7 +21,10 @@ void __init noreturn start_xen(unsigned long bootcpu_id,
> {
> early_printk("Hello from C env\n");
>
> -early_printk("All set up\n");
> +setup_initial_pagetables();
> +
> +enable_mmu();
> +
> for ( ;; )
> asm volatile ("wfi");
>
> --
> 2.40.1
>
>
Acked-by: Bobby Eshleman
... | 194 GB | L2 0 - 193 | Unused
> + *
>
> + *
> +#endif
> + */
> +
> #if defined(CONFIG_RISCV_64)
> # define LONG_BYTEORDER 3
> # define ELFSIZE 64
> --
> 2.40.1
>
>
Acked-by: Bobby Eshleman
On Fri, Apr 28, 2023 at 12:43:09PM +0200, Stefano Garzarella wrote:
> On Sat, Apr 15, 2023 at 07:13:47AM +0000, Bobby Eshleman wrote:
> > CC'ing virtio-dev@lists.oasis-open.org because this thread is starting
> > to touch the spec.
> >
> > On Wed, Apr 19, 2
CC'ing virtio-dev@lists.oasis-open.org because this thread is starting
to touch the spec.
On Wed, Apr 19, 2023 at 12:00:17PM +0200, Stefano Garzarella wrote:
> Hi Bobby,
>
> On Fri, Apr 14, 2023 at 11:18:40AM +, Bobby Eshleman wrote:
> > CC'ing Cong.
> >
&g
ODO:
> + * To be deleted when the first real .bss user appears
> + */
> +int dummy_bss __attribute__((unused));
> +
> void __init noreturn start_xen(unsigned long bootcpu_id,
> unsigned long dtb_base)
> {
> --
> 2.39.0
>
>
Reviewed-by: Bobby Eshleman
ot_stack[STACK_SIZE]
> __aligned(STACK_SIZE);
>
> -void __init noreturn start_xen(void)
> +void __init noreturn start_xen(unsigned long bootcpu_id,
> + unsigned long dtb_base)
> {
> early_printk("Hello from C env\n");
>
> --
> 2.39.0
>
>
Reviewed-by: Bobby Eshleman
t0, STACK_SIZE
> add sp, sp, t0
> --
> 2.39.0
>
>
My last email had the wrong trailer:
Reviewed-by: Bobby Eshleman
t0, STACK_SIZE
> add sp, sp, t0
> --
> 2.39.0
>
>
Acked-by: Bobby Eshleman
F_POINTER__
> bltut3, t4, .L_clear_bss
>
> -la sp, cpu0_boot_stack
> +lla sp, cpu0_boot_stack
> li t0, STACK_SIZE
> add sp, sp, t0
>
> --
> 2.39.2
>
>
Reviewed-by: Bobby Eshleman
I just wanted to let you know I have this queued up to review, I’ve just
been very overloaded. I’ll give these a review in the coming week.
Best,
Bobby
On Fri, Mar 3, 2023 at 2:24 AM Oleksii Kurochko
wrote:
> The patch series groups and updates the following patches:
> 1. xen/riscv: disable fpu
On Wed, Feb 01, 2023 at 09:06:21AM +, Julien Grall wrote:
> Hi Andrew,
>
> On 01/02/2023 00:21, Andrew Cooper wrote:
> > On 31/01/2023 11:17 pm, Alistair Francis wrote:
> > > On Tue, Jan 31, 2023 at 10:03 PM Julien Grall wrote:
> > > > On 31/01/2023 11:44, Alistair Francis wrote:
> > > > > On
On Mon, Jan 23, 2023 at 11:09:13PM +, Andrew Cooper wrote:
> On 19/01/2023 1:05 pm, Bobby Eshleman wrote:
> > On Mon, Jan 23, 2023 at 06:56:19PM +0200, Oleksii wrote:
> >> Hi Alistair and community,
> >>
> >> I am working on RISC-V support upstream for Xen
On Mon, Jan 23, 2023 at 06:56:19PM +0200, Oleksii wrote:
> Hi Alistair and community,
>
> I am working on RISC-V support upstream for Xen based on your and Bobby
> patches.
>
> Adding the RISC-V support I realized that Xen is ran in S-mode. Output
> of OpenSBI:
> ...
> Domain0 Next Mode
basic stuff of early_printk functionality
> which will be enough to print 'hello from C environment".
>
> Originally early_printk.{c,h} was introduced by Bobby Eshleman
> (https://github.com/glg-rv/xen/commit/a3c9916bbdff7ad6030055bbee7e53d1aab71384)
> but some functionality wa
On Mon, Jan 16, 2023 at 04:39:30PM +0200, Oleksii Kurochko wrote:
> From: Bobby Eshleman
>
> Originally SBI implementation for Xen was introduced by
> Bobby Eshleman but it was removed
> all the stuff for simplicity except SBI call for putting
> character to console.
>
&
> > obj-y += sbi.o
> > obj-y += setup.o
> > diff --git a/xen/arch/riscv/early_printk.c
> b/xen/arch/riscv/early_printk.c
> > new file mode 100644
> > index 00..88da5169ed
> > --- /dev/null
> > +++ b/xen/arch/riscv/early_printk.c
> >
On Fri, Jan 06, 2023 at 05:16:31PM +, Andrew Cooper wrote:
> On 20/12/2022 6:23 am, Bobby Eshleman wrote:
> > On Fri, Jan 06, 2023 at 03:14:25PM +0200, Oleksii Kurochko wrote:
> >> The patch introduce sbi_putchar() SBI call which is necessary
> >> to implement init
; +++ b/xen/arch/riscv/include/asm/sbi.h
> @@ -0,0 +1,34 @@
> +/* SPDX-License-Identifier: (GPL-2.0-or-later) */
> +/*
> + * Copyright (c) 2021 Vates SAS.
> + *
> + * Taken from xvisor, modified by Bobby Eshleman (bobby.eshle...@gmail.com).
> + *
> + * Taken/modified from Xv
On Fri, Dec 02, 2022 at 12:56:06PM +, Andrew Cooper wrote:
> On 02/12/2022 12:35, Ayan Kumar Halder wrote:
> > Currently this change will not have any impact on the existing
> > architectures.
> > The following table illustrates PADDR_BITS vs BITS_PER_LONG of different
> > archs
> >
> > -
On Thu, Aug 18, 2022 at 08:35:48AM +, Arseniy Krasnov wrote:
> On Tue, 2022-08-16 at 09:58 +0000, Bobby Eshleman wrote:
> > On Wed, Aug 17, 2022 at 05:42:08AM +, Arseniy Krasnov wrote:
> > > On 17.08.2022 08:01, Arseniy Krasnov wrote:
> > > > On 16.08.20
On Wed, Aug 17, 2022 at 05:42:08AM +, Arseniy Krasnov wrote:
> On 17.08.2022 08:01, Arseniy Krasnov wrote:
> > On 16.08.2022 05:32, Bobby Eshleman wrote:
> >> CC'ing virtio-dev@lists.oasis-open.org
> >>
> >> On Mon, Aug 15, 2022 at 10:56:08AM -070
On Wed, Aug 17, 2022 at 05:01:00AM +, Arseniy Krasnov wrote:
> On 16.08.2022 05:32, Bobby Eshleman wrote:
> > CC'ing virtio-dev@lists.oasis-open.org
> >
> > On Mon, Aug 15, 2022 at 10:56:08AM -0700, Bobby Eshleman wrote:
> >> This patch supports dgram in vi
CC'ing virtio-dev@lists.oasis-open.org
On Mon, Aug 15, 2022 at 10:56:09AM -0700, Bobby Eshleman wrote:
> From: Jiang Wang
>
> Added test cases for vsock dgram types.
>
> Signed-off-by: Jiang Wang
> ---
> tools/testing/vsock/util.c | 105 +
>
CC'ing virtio-dev@lists.oasis-open.org
On Mon, Aug 15, 2022 at 10:56:08AM -0700, Bobby Eshleman wrote:
> This patch supports dgram in virtio and on the vhost side.
>
> Signed-off-by: Jiang Wang
> Signed-off-by: Bobby Eshleman
> ---
> drivers/vhost/vsock.c
CC'ing virtio-dev@lists.oasis-open.org
On Mon, Aug 15, 2022 at 10:56:07AM -0700, Bobby Eshleman wrote:
> This commit adds a feature bit for virtio vsock to support datagrams.
>
> Signed-off-by: Jiang Wang
> Signed-off-by: Bobby Eshleman
> ---
> drivers/vhost/
CC'ing virtio-dev@lists.oasis-open.org
On Mon, Aug 15, 2022 at 10:56:06AM -0700, Bobby Eshleman wrote:
> In order to support usage of qdisc on vsock traffic, this commit
> introduces a struct net_device to vhost and virtio vsock.
>
> Two new devices are created, vhost-vsock for
CC'ing virtio-dev@lists.oasis-open.org
On Mon, Aug 15, 2022 at 10:56:05AM -0700, Bobby Eshleman wrote:
> This commit allows vsock implementations to return errors
> to the socket layer other than -ENOMEM. One immediate effect
> of this is that upon the sk_sndbuf threshold being r
CC'ing virtio-dev@lists.oasis-open.org
On Mon, Aug 15, 2022 at 10:56:04AM -0700, Bobby Eshleman wrote:
> This patch replaces virtio_vsock_pkt with sk_buff.
>
> The benefit of this series includes:
>
> * The bug reported @ https://bugzilla.redhat.com/show_bug.cgi?id=2009935
CC'ing virtio-dev@lists.oasis-open.org
On Mon, Aug 15, 2022 at 10:56:03AM -0700, Bobby Eshleman wrote:
> Hey everybody,
>
> This series introduces datagrams, packet scheduling, and sk_buff usage
> to virtio vsock.
>
> The usage of struct sk_buff benefits users by a)
On Mon, Nov 01, 2021 at 10:47:26AM +, Andrew Cooper wrote:
> Hello,
>
> On ARM, the GIC is a hard prerequisite for VMs.
>
> I can't remember what the state of RISCV is, but IIRC there is still
> some debate over how interrupts are expected to work under virt.
>
Yes sir, that addition to the
no longer required, arm/debugger.h is removed.
Signed-off-by: Bobby Eshleman
---
Changes in v4:
- Replace #include with `struct cpu_user_regs`
xen/arch/x86/traps.c | 1 +
xen/common/domain.c| 2 +-
xen/common/gdbstub.c | 2 +-
xen/common/keyhandler.c
domain_pause_for_debugger() was previously in debugger.h. This commit
moves it to domain.h because its implementation is in domain.c.
Signed-off-by: Bobby Eshleman
---
Changes in v3:
- domain_pause_for_debugger() is now moved into debugger.h, not a new
file debugger.c
Changes in v4:
- Don&#
Because dbg_rw_mem() has only a single call site, this commit
expands it inline.
Signed-off-by: Bobby Eshleman
---
Changes in v4:
- Add DCO
xen/arch/x86/gdbsx.c | 30 +-
1 file changed, 9 insertions(+), 21 deletions(-)
diff --git a/xen/arch/x86/gdbsx.c b/xen/arch
adds a stub that would preserve the functioning
of that call site if the #ifdef CONFIG_GDBSX were to ever be removed or
the function were to ever be called outside of such an ifdef block.
Signed-off-by: Bobby Eshleman
---
Changes in v4:
- Alphebetize Makefile addition
- Fix broken header guard
ut of
debugger_trap_entry() are removed completely (when the trapnr is not
int3/debug).
This commit is one of a series geared towards removing the unnecessary
requirement that all architectures to implement .
Signed-off-by: Bobby Eshleman
---
Changes in v4:
- Reword commit message for accuracy
ARM doesn't actually use debugger_trap_* anything, and is stubbed out.
This commit simply removes the unneeded calls.
Signed-off-by: Bobby Eshleman
---
xen/arch/arm/traps.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 4ccb6
when !CONFIG_CRASH_DEBUG
- Adds stronger separation between gdbstub, gdbsx, and generic debugger
code.
v4 simply includes the review feedback from v3 with no other big changes
(as was the case for v3 in comparison to v2).
Bobby Eshleman (6):
arm/traps: remove debugger_trap_fatal() calls
x86/deb
On Tue, Aug 24, 2021, 2:20 PM Jan Beulich wrote:
> On 18.08.2021 22:29, Bobby Eshleman wrote:
> > --- /dev/null
> > +++ b/xen/include/asm-x86/gdbsx.h
> > @@ -0,0 +1,17 @@
> > +#ifndef __X86_GDBX_H
> > +#define __X86_GDBX_H__
> > +
> > +#ifdef C
no longer required, arm/debugger.h is removed.
Signed-off-by: Bobby Eshleman
---
Changes in v3:
- No longer introduces a fake TRAP_invalid_op for arm to consume, it
is not necessary given the removal of the arm calls now precedes
this patch.
- Instead of defining prototypes that arch/ is
domain_pause_for_debugger() was previously in debugger.h. This commit
moves it to domain.h because its implementation is in domain.c.
Signed-off-by: Bobby Eshleman
---
Changes in v3:
- domain_pause_for_debugger() is now moved into debugger.h, not a new
file debugger.c
xen/arch/x86/hvm/svm
ssary
requirement that all architectures to implement .
Signed-off-by: Bobby Eshleman
---
xen/arch/x86/domain.c | 2 +-
xen/arch/x86/traps.c | 48 --
xen/include/asm-x86/debugger.h | 42 ++---
3 files changed, 31 insertions(+
adds a stub that would preserve the functioning
of that call site if the #ifdef CONFIG_GDBSX were to ever be removed or
the function were to ever be called outside of such an ifdef block.
Signed-off-by: Bobby Eshleman
---
xen/arch/x86/Makefile | 2 +-
xen/arch/x86/domctl.c
Because dbg_rw_mem() has only a single call site, this commit
expands it inline.
---
xen/arch/x86/gdbsx.c | 32 +++-
1 file changed, 11 insertions(+), 21 deletions(-)
diff --git a/xen/arch/x86/gdbsx.c b/xen/arch/x86/gdbsx.c
index adea0f017b..4cb8e042f9 100644
--- a/xen
ARM doesn't actually use debugger_trap_* anything, and is stubbed out.
This commit simply removes the unneeded calls.
Signed-off-by: Bobby Eshleman
---
xen/arch/arm/traps.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 4ccb6
rily calls into the gdbstub… but
further generalization is unnecessary while it is still only
backed by the gdbstub.
As I'm not *exactly* an expert on this code, so feel free to inform me of my
confusion where you see it.
Bobby Eshleman (6):
arm/traps: remove debugger_trap_fatal() calls
x8
The function domain_pause_for_debugger() is conditionally compiled if
CONFIG_CRASH_DEBUG=y. Instead of placing an extra #ifdef inside
domain.c, this commit moves domain_pause_for_debugger() into
x86/debugger.c which is only built by Kbuild given CONFIG_CRASH_DEBUG=y.
Signed-off-by: Bobby
Previously Xen required all architectures implement the debugger_trap_*
functions whether or not it actually needs them.
This commit makes debugger_trap* functions resolve to arch-specific
function definitions if CONFIG_CRASH_DEBUG=y, but resolves to a set of
common no-op stubs if !CONFIG_CRASH_DE
The function debugger_trap_entry() is somewhat large for an inlined
function. This commit moves debugger_trap_entry() into debugger.c and
makes it not inlined.
Signed-off-by: Bobby Eshleman
---
Changes in v2:
- Move obj-$(CONFIG_CRASH_DEBUG) += debugger.o to be in alphabetical
order
ARM doesn't actually use debugger_trap_* anything, and is stubbed out.
Simply remove the calls. This also renders TRAP_invalid_op unused in
any common code, so remove that definition too.
Signed-off-by: Bobby Eshleman
---
xen/arch/arm/traps.c | 6 --
1 file changed, 6 deletions(-)
code conditionally compiled by CONFIG_CRASH_DEBUG
into arch/x86/debugger.c, which is now conditionally built for
CONFIG_CRASH_DEBUG via Kbuild (i.e., obj-$(CONFIG_CRASH_DEBUG)).
* Tries to improve the x86 implementation by not inlining large
functions (but preserving inlining for those that seemed "small&
The function domain_pause_for_debugger() is conditionally compiled if
CONFIG_CRASH_DEBUG=y. Instead of placing an extra #ifdef inside
domain.c, this commit moves domain_pause_for_debugger() into
x86/debugger.c which is only built by Kbuild given CONFIG_CRASH_DEBUG=y.
Signed-off-by: Bobby
The function debugger_trap_entry() is rather large for an inlined
function. This commit moves debugger_trap_entry() into debugger.c and
makes it not inlined.
Signed-off-by: Bobby Eshleman
---
xen/arch/x86/Makefile | 1 +
xen/arch/x86/debugger.c| 41
ARM doesn't actually use debugger_trap_* anything, and is stubbed out.
Simply remove the calls. This also renders TRAP_invalid_op unused in
any common code, so remove that definition too.
Signed-off-by: Bobby Eshleman
---
xen/arch/arm/traps.c | 6 --
xen/include/xen/debugger.
!CONFIG_CRASH_DEBUG, which avoids requiring every
arch to carry its own stubs. This means asm/debugger.h may also be
dropped for architectures that do not need this functionality.
Inside xen/debugger.h:
* If !CONFIG_CRASH_DEBUG, use stubs.
* Otherwise, include arch-specific
Signed-off-by: Bobby
IG_CRASH_DEBUG
into arch/x86/debugger.c, which is now conditionally built for
CONFIG_CRASH_DEBUG via Kbuild (i.e., obj-$(CONFIG_CRASH_DEBUG)).
* Tries to improve the x86 implementation by not inlining large
functions (but preserving inlining for those that seemed "small").
Bobby Esh
Hey all,
I just wanted to request more feedback on this series and put it on the radar,
while acknowledging
that I'm sure given the recent code freeze it is a busy time for everybody.
Best,
Bob
On Fri, Jan 22, 2021 at 12:27:29PM +0100, Jan Beulich wrote:
> On 22.01.2021 01:51, Bobby Eshleman wrote:
> > export XEN_BUILD_DATE ?= $(shell LC_ALL=C date)
> > export XEN_BUILD_TIME ?= $(shell LC_ALL=C date +%T)
> > export XEN_BUILD_HOST ?= $(shell
On Fri, Jan 22, 2021 at 10:39:28AM +0100, Jan Beulich wrote:
> On 22.01.2021 01:51, Bobby Eshleman wrote:
> > I followed with v2 feedback and attempted to convert the PE/COFF header
> > into C instead of ASM. Unfortunately, this was only possible for the
> > first part (L
1 - 100 of 144 matches
Mail list logo
