1);
}
is basically saying you are trying to read icount at a point its not a
known precise value. Any attempt to do a device access should trigger a
TB recompile so the device access is on the last translated instruction
of the block. However if a TCG helper queries time and its not the last
instruction in a block that would trigger it.
>
> Regards
>
> Saanjh Sengupta
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Mario Fleischmann writes:
> On 08.04.2025 16:37, Markus Armbruster wrote:
>
>> Alex Bennée writes:
>>
>>> Markus Armbruster writes:
>>>
>>>> Alex Bennée writes:
>>>>
>>>>> Markus Armbruster writes:
>>>&g
xtra owner reference in the memory region and causes the MR to be
> freed right away in the main context.
>
> Acked-by: Michael S. Tsirkin
> Signed-off-by: Manos Pitsidianakis
Reviewed-by: Alex Bennée
Tested-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Branch: refs/tags/v10.0.0-rc3
Home: https://github.com/qemu/qemu
To unsubscribe from these emails, change your notification settings at
https://github.com/qemu/qemu/settings/notifications
o the _exit handler with a failing status code.
Signed-off-by: Alex Bennée
Reviewed-by: Richard Henderson
Message-Id: <20250404115641.258048-1-alex.ben...@linaro.org>
diff --git a/tests/tcg/aarch64/system/boot.S b/tests/tcg/aarch64/system/boot.S
index 4eb1b35b88..a5df9c173d 100644
---
From: Pierrick Bouvier
Reported and fixed by Dmitry Kurakin.
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/2901
Signed-off-by: Pierrick Bouvier
Message-Id: <20250404032027.430575-2-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
diff
g tests on unexpected exceptions
- fix deadlock when uninstalling a plugin
----
Alex Bennée (1):
tests/tcg: fix semihosting SYS_EXIT for aarch64 in boot.S
Pierrick Bouvier (2):
plugins/loader: fix deadlock when resetting/unin
From: Pierrick Bouvier
We perform a plugin reset, uninstall, and make sure we went through
those steps.
Signed-off-by: Pierrick Bouvier
Message-Id: <20250404032027.430575-3-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
diff --git a/tests/tcg/plugins/reset.c b/tests/tcg/p
SIGTERM
Ok: 0
Expected Fail: 0
Fail: 0
Unexpected Pass:0
Skipped:0
Timeout:1
Full log written to
/home/alex/lsrc/qemu.git/builds/virtio-gpu/meson-logs/testlog-thorough.txt
🕙10:31:12 alex@toolbox:qemu.git/builds/virtio-gpu on
virtio/virtio-blk-fallback [$?] took 8m [🔴 ERROR]
>
> Manos Pitsidianakis (2):
> virtio-gpu: fix hang under TCG when unmapping blob
> virtio-gpu: refactor async blob unmapping
>
> hw/display/virtio-gpu-virgl.c | 37 ---
> 1 file changed, 26 insertions(+), 11 deletions(-)
>
>
> base-commit: 0adf626718bc0ca9c46550249a76047f8e45da15
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Zhao Liu writes:
> Fix the typo in the error message to help `grep` the example:
>
> ERROR: New file '***' requires 'SPDX-License-Identifer'
>
> Fixes: fa4d79c64dae ("scripts: mandate that new files have
> SPDX-License-Identifier")
> Signed-off
Markus Armbruster writes:
> Alex Bennée writes:
>
>> Markus Armbruster writes:
>>
>>> Mario Fleischmann writes:
>>>
>>>> Apologies for the line wrapping in yesterday's answer. Should be fixed now.
>>>>
>>>> On 08.0
d such.
>>>
>>> Fair?
>>
>> Couldn't have put it better myself.
>>
>>> What about providing the MCD interface as a separate QMP-like protocol?
>>> It gets its own QAPI schema, just like for qemu-ga. Simplifies
>>> compiling it out when not needed.
>>>
>>> It gets its own socket, just like the GDB stub. Might reduce
>>> interference between debugging and QMP.
>>>
>>> Thoughts? Alex, Philippe, care to chime in?
>>
>> Sound reasonable to me. Keeping in mind the size of generated QAPI code,
>> an option to `./configure [...] --enable-mcd` is definitely advisable.
>
> Alex, Philippe?
When I spoke to Mario at DVCon last year I liked the idea of re-using
QMP instead of inventing yet another RPC interface for QEMU. QMP
certainly has nicer properties than the gdbstub which has a very
"organic" and "serial" feel to it.
Are you suggesting we re-use the machinery but use an entirely separate
socket with just the MCD namespace in it? I don't see that being a
problem as long as we can test it properly in the CI.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
ation in plugins for things that are
"events" which we do do from other hypervisors and "instrumentation"
which can only be done under TCG.
>
>
> Cheers
> Mark.
>
>
>> On 3 Apr 2025, at 13:38, Alex Bennée wrote:
>>
>> WARNING: This em
-
> 3 files changed, 75 insertions(+), 2 deletions(-)
> create mode 100644 tests/tcg/plugins/reset.c
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Pierrick Bouvier writes:
> On 3/19/25 11:22, Alex Bennée wrote:
>> For some of the helpers we need a temporary variable to copy from
>> although we could add some helpers to return pointers into env in
>> those cases if we wanted to.
>> Signed-off-by: Alex Ben
We've not yet deprecated but we should steer users away from these
helpers if they want to be in a single/heterogeneous binary.
Signed-off-by: Alex Bennée
---
include/gdbstub/helpers.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/gdbstub/helpers.h b/in
Branch: refs/tags/v10.0.0-rc0
Home: https://github.com/qemu/qemu
To unsubscribe from these emails, change your notification settings at
https://github.com/qemu/qemu/settings/notifications
hypervisors.
So what do people think? Where would be a good place for common test
repository to live?
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
exception levels.
With this we can run the memory test with:
-M virt,secure=on
-M virt,secure=on,virtualization=on
-M virt,virtualisation=on
Cc: Julian Armistead
Cc: Jim MacArthur
Signed-off-by: Alex Bennée
---
tests/tcg/aarch64/system/boot.S | 88 +
1
Hi,
The KVM/QEMU community call is at:
https://meet.jit.si/kvmcallmeeting
@
01/04/2025 14:00 UTC
Are there any agenda items for the sync-up?
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
o the _exit handler with a failing status code.
Signed-off-by: Alex Bennée
---
tests/tcg/aarch64/system/boot.S | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/tcg/aarch64/system/boot.S b/tests/tcg/aarch64/system/boot.S
index 8fbcba757e..81a60b9c43 100644
--- a/test
When we added qemu_plugin_update_ns() to advance time we missed the
fact that users of virtual clock don't get updated. Rather than
implement the logic inside QEMU to keep track of the magic number lets
just delegate it to the plugin instead.
Compile tested only.
Alex.
Alex Bennée (2):
Rather than allowing cpus_get_virtual_clock() to fall through to
cpu_get_clock() introduce a TCG handler so it can make a decision
about what time it is.
Initially this just calls cpu_get_clock() as before but this will
change in later commits.
Signed-off-by: Alex Bennée
---
accel/tcg/tcg
This allows the a plugin which has control of time to supply a callback
so it can control the reported virtual time instead of using the
default cpu_get_clock().
Time control plugins still need to call qemu_plugin_update_ns() to
ensure timers are moved forward.
Signed-off-by: Alex Bennée
Branch: refs/tags/v10.0.0-rc2
Home: https://github.com/qemu/qemu
To unsubscribe from these emails, change your notification settings at
https://github.com/qemu/qemu/settings/notifications
48.00
> Flags:fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics
> fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 asimddp sha512 asim
> dfhm dit uscat ilrcpc flagm ssbs sb paca pacg
> dcpodp flagm2 frint
>
> Signed-off-by: Z
Stefan Hajnoczi writes:
> On Mon, Mar 31, 2025 at 6:39 AM Alex Bennée wrote:
>> The unikernel utilizes rcore-os's no_std VirtIO drivers to discover and
>> initialize a range of VirtIO devices.
>
> https://github.com/rcore-os/virtio-drivers
>
> I
to avoid
> accessing protected memory.
> Note: this is *not* needed for the similar test_aarch64_rme_sbsaref.
>
> More information is available on the associated GitLab issue.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2823
> Signed-off-by: Pierrick Bouvier
security
bugs but the emulation use case shouldn't be relied upon for guest
isolation or security guarantees.
>
>
>
> Thank you for your assistance. We look forward to your response.
>
>
>
> Best regards,
>
>
>
> Louis-Vincent DERIAN
>
>
>
> ST Restricted
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
ldl_le_p(addr)
> -#define ldtul_be_p(addr) ldl_be_p(addr)
> #endif
>
> #endif /* _GDBSTUB_HELPERS_H_ */
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Branch: refs/tags/v10.0.0-rc1
Home: https://github.com/qemu/qemu
To unsubscribe from these emails, change your notification settings at
https://github.com/qemu/qemu/settings/notifications
Philippe Mathieu-Daudé writes:
> There are no more use of ldtul_p() in the code base,
> remove the definitions.
>
> Signed-off-by: Philippe Mathieu-Daudé
Queued to gdbstub/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Philippe Mathieu-Daudé writes:
> Replace the few ldtul_p() calls by a generic ldn_p() ones.
> No logical change.
Queued to gdbstub/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Philippe Mathieu-Daudé writes:
> When TARGET_LONG_BITS == 64, ldtul_p() expand to ldq_p().
> Directly use the expanded form for clarity.
>
> Signed-off-by: Philippe Mathieu-Daudé
Queued to gdbsub/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Branch: refs/heads/staging-7.2
Home: https://github.com/qemu/qemu
Commit: 40b933fca98943d9f14b9c81ba4184b4714df9ad
https://github.com/qemu/qemu/commit/40b933fca98943d9f14b9c81ba4184b4714df9ad
Author: Michael Tokarev
Date: 2025-03-26 (Wed, 26 Mar 2025)
Changed paths:
M V
Branch: refs/tags/v8.2.10
Home: https://github.com/qemu/qemu
To unsubscribe from these emails, change your notification settings at
https://github.com/qemu/qemu/settings/notifications
Branch: refs/tags/v9.2.3
Home: https://github.com/qemu/qemu
To unsubscribe from these emails, change your notification settings at
https://github.com/qemu/qemu/settings/notifications
t-arm: Add the AArch64 view of the Secure physical
timer")
Signed-off-by: Peter Maydell
Reviewed-by: Alex Bennée
Reviewed-by: Richard Henderson
Message-id: 20250130182309.717346-2-peter.mayd...@linaro.org
(cherry picked from commit b819fd6994243aee6f9613edbbacedce4f511c32)
Signed-off-b
Branch: refs/heads/staging-9.2
Home: https://github.com/qemu/qemu
Commit: 9027aa63959c0a6cdfe53b2a610aaec98764a2da
https://github.com/qemu/qemu/commit/9027aa63959c0a6cdfe53b2a610aaec98764a2da
Author: Michael Tokarev
Date: 2025-03-26 (Wed, 26 Mar 2025)
Changed paths:
M V
correct syndrome
value for an UNDEFINED instruction.
Cc: qemu-sta...@nongnu.org
Fixes: b4d3978c2fd ("target-arm: Add the AArch64 view of the Secure physical
timer")
Signed-off-by: Peter Maydell
Reviewed-by: Alex Bennée
Reviewed-by: Richard Henderson
Message-id: 20250130182309.717346-
P_ACCESS_TRAP_UNCATEGORIZED, which reports the correct syndrome
value for an UNDEFINED instruction.
Cc: qemu-sta...@nongnu.org
Fixes: b4d3978c2fd ("target-arm: Add the AArch64 view of the Secure physical
timer")
Signed-off-by: Peter Maydell
Reviewed-by: Alex Bennée
Reviewed-by: Richar
Branch: refs/tags/v7.2.17
Home: https://github.com/qemu/qemu
To unsubscribe from these emails, change your notification settings at
https://github.com/qemu/qemu/settings/notifications
Branch: refs/heads/staging-8.2
Home: https://github.com/qemu/qemu
Commit: f671ce11d2a15a58ab752d7cf0b2890c9022c7ba
https://github.com/qemu/qemu/commit/f671ce11d2a15a58ab752d7cf0b2890c9022c7ba
Author: Michael Tokarev
Date: 2025-03-26 (Wed, 26 Mar 2025)
Changed paths:
M V
e're at it, also make sure that this test is covered in the
> right section in the MAINTAINERS file.
>
> Signed-off-by: Thomas Huth
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Philippe Mathieu-Daudé writes:
> On 24/3/25 11:21, Alex Bennée wrote:
>> We've not yet deprecated but we should steer users away from these
>> helpers if they want to be in a single/heterogeneous binary.
>
> Why not deprecate?
I guess philosophically do we expect
sical count is described
in the Arm ARM DDI4087 rev L.a section D12.2.4.1. This is different
from when the offset should be applied for a direct read of the
counter sysreg.
We got this right for the EL1 physical timer and for the EL1 virtual
timer, but got all the rest wrong: they should be using a
Alex Bennée writes:
> The current helper.h functions rely on hard coded assumptions about
> target endianess to use the tswap macros. We also end up double
> swapping a bunch of values if the target can run in multiple endianess
> modes. Avoid this by getting the target to pass the e
For some of the helpers we need a temporary variable to copy from
although we could add some helpers to return pointers into env in
those cases if we wanted to.
Signed-off-by: Alex Bennée
---
v2
- use MO32/MO64 varients for reg sizes
- use wrappers for 32/64 bit regs
- do SVE Z registers
setting env
vars directly? This is complicated by aliasing though.
We also have to deal with heavy usage of target_ulong so we copy some
macro stuff from the old helpers.h and add a gdb_get_regl_value()
helper.
Signed-off-by: Alex Bennée
---
v2
- use new helpers
- fix bunch of target_ulong
We can handle larger sized memops now, expand the range of the assert.
Fixes: 4b473e0c60 (tcg: Expand MO_SIZE to 3 bits)
Signed-off-by: Alex Bennée
---
v2
- instead of 128 use 1 << MO_SIZE for future proofing
---
include/exec/memop.h | 4 ++--
1 file changed, 2 insertions(+), 2 del
For some of the helpers we need a temporary variable to copy from
although we could add some helpers to return pointers into env in
those cases if we wanted to.
Reviewed-by: Pierrick Bouvier
Signed-off-by: Alex Bennée
---
v2
- use new wrappers
- explicit MO_32 usage and reg32/64 helpers
When things go wrong we want to assert on the register that failed to
be able to figure out what went wrong.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
---
gdbstub/gdbstub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdbstub/gdbstub.c b/gdbstub
Mainly as an aid to myself getting confused too many bswaps deep into
the code.
Reviewed-by: Pierrick Bouvier
Signed-off-by: Alex Bennée
---
target/ppc/cpu.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
index efab54a068
r 10.0 but I'll leave that up to maintainers.
Alex Bennée (11):
include/exec: fix assert in size_memop
include/gdbstub: fix include guard in commands.h
gdbstub: assert earlier in handle_read_all_regs
gdbstub: introduce target independent gdb register helper
target/arm: convert 32 bit
This is a pretty simple conversion given a single set of registers and
an existing helper to probe endianess.
Signed-off-by: Alex Bennée
---
v2
- use mb_cpu_is_big_endian
- use explicit MO_32 size
- handle differing size of env->ear between user/system
---
target/microblaze/gdbstu
up appropriately.
Reviewed-by: Pierrick Bouvier
Signed-off-by: Alex Bennée
---
v2
- use unsigned consistently
- fix some rouge whitespace
- add typed reg32/64 wrappers
- pass void * to underlying helper to avoid casting
---
include/gdbstub/registers.h | 55
Reviewed-by: Pierrick Bouvier
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
---
include/gdbstub/commands.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/gdbstub/commands.h b/include/gdbstub/commands.h
index 40f0514fe9..bff3674872 100644
--- a
It's not used outside of the gdbstub code.
Reviewed-by: Pierrick Bouvier
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
---
target/ppc/cpu.h | 1 -
target/ppc/gdbstub.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/ppc/cpu.h b/targe
Pierrick Bouvier writes:
> On 3/19/25 11:22, Alex Bennée wrote:
>> The aim of this work is to get rid of the endian aware helpers in
>> gdbstub/helpers.h which due to their use of tswap() mean target
>> gdbstubs need to be built multiple times. While this series doesn
Pierrick Bouvier writes:
> On 3/20/25 12:30, Pierrick Bouvier wrote:
>> On 3/19/25 11:22, Alex Bennée wrote:
>>> The current helper.h functions rely on hard coded assumptions about
>>> target endianess to use the tswap macros. We also end up double
>>> swap
[External] [PATCH] contrib/plugins: Install plugins to moddir
>> To: , "Alex Bennée",
>> "Alexandre Iooss", "Mahmoud
>> Mandour", "Pierrick
>> Bouvier"
>> Cc: "Wang Pengcheng", "Christoph
>> Müllner"
It's not used outside of the gdbstub code.
Signed-off-by: Alex Bennée
---
target/ppc/cpu.h | 1 -
target/ppc/gdbstub.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
index 1e833ade04..950bb6e06c 100644
--- a/target/ppc/cpu.h
e a return statement at end of a
> function.
>
> Based on that, I'd say return in the middle of function is
> overwhelmingly common in our code.
And with autofree variables it saves on clumsy goto and cleanup handlers.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
For some of the helpers we need a temporary variable to copy from
although we could add some helpers to return pointers into env in
those cases if we wanted to.
Signed-off-by: Alex Bennée
---
target/arm/gdbstub64.c | 53 ++
1 file changed, 33 insertions
Signed-off-by: Alex Bennée
---
include/gdbstub/commands.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/gdbstub/commands.h b/include/gdbstub/commands.h
index 40f0514fe9..bff3674872 100644
--- a/include/gdbstub/commands.h
+++ b/include/gdbstub/commands.h
@@ -1,5 +1,5
For some of the helpers we need a temporary variable to copy from
although we could add some helpers to return pointers into env in
those cases if we wanted to.
Signed-off-by: Alex Bennée
---
target/arm/gdbstub.c | 57
1 file changed, 36 insertions
This is a pretty simple conversion which will be trivial to update
once TARGET_BIGENDIAN is replaced with a helper function.
Signed-off-by: Alex Bennée
---
target/microblaze/gdbstub.c | 44 ++---
1 file changed, 17 insertions(+), 27 deletions(-)
diff --git a
Mainly as an aid to myself getting confused too many bswaps deep into
the code.
Signed-off-by: Alex Bennée
---
target/ppc/cpu.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
index efab54a068..1e833ade04 100644
--- a/target/ppc
When things go wrong we want to assert on the register that failed to
be able to figure out what went wrong.
Signed-off-by: Alex Bennée
---
gdbstub/gdbstub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
index 3d7b1028e4..8561d9d527
up appropriately.
Signed-off-by: Alex Bennée
---
include/gdbstub/registers.h | 30 ++
gdbstub/gdbstub.c | 22 ++
2 files changed, 52 insertions(+)
create mode 100644 include/gdbstub/registers.h
diff --git a/include/gdbstub/registers.h b
We can handle larger sized memops now, expand the range of the assert.
Fixes: 4b473e0c60 (tcg: Expand MO_SIZE to 3 bits)
Signed-off-by: Alex Bennée
---
include/exec/memop.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/exec/memop.h b/include/exec/memop.h
index
setting env
vars directly? This is complicated by aliasing though.
Signed-off-by: Alex Bennée
---
target/ppc/gdbstub.c | 192 ---
1 file changed, 108 insertions(+), 84 deletions(-)
diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c
index c09e93abaf
icking for 10.0 but I'll leave that up to maintainers.
Alex.
Alex Bennée (10):
include/gdbstub: fix include guard in commands.h
gdbstub: introduce target independent gdb register helper
target/arm: convert 32 bit gdbstub to new helper
target/arm: convert 64 bit gdbstub to new help
constraints or best practices regarding adding new
> code or features to QEMU.
What documentation that exists can be found in the developers section of
the manual:
https://qemu.readthedocs.io/en/master/devel/index.html
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
@ static inline void tcg_set_insn_start_param(TCGOp *op,
> int arg, uint64_t v)
> }
> }
>
> +void tcg_gen_insn_start(uint64_t pc, uint64_t a1, uint64_t a2);
> +
Is would be nice to docstring the function to explain what it does and
note where the additional data is interpreted
(cpu_restore_state_from_tb?).
Otherwise:
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
hew.org/QEMU/20241022105614.839199-1-alex.ben...@linaro.org/20241022105614.839199-18-alex.ben...@linaro.org/
>
> Regards
> Saanjh Sengupta
> -----
> From: Alex Bennée
> Sent: Tuesday,
a GDB triggered
callback
From: =?UTF-8?q?Alex=20Benn=C3=A9e?=
>
> If so, could you please direct me to the same ?
>
> On 14 Mar 2025, at 12:11 AM, Alex Bennée wrote:
>
> Saanjh Sengupta writes:
>
> Hi,
>
> What we are trying to achieve is that the QEMU should r
Hi,
The KVM/QEMU community call is at:
https://meet.jit.si/kvmcallmeeting
@
18/03/2025 14:00 UTC
Are there any agenda items for the sync-up?
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
the
> CPU of TYPE_AARCH64_CPU?", so that this produces no behavioural
> change. When we've moved all the gdbstub related methods across to
> the base class, we will be able to change this to be "does the CPU
> have the ARM_FEATURE_AARCH64 feature?".
>
> Signe
s will allow Arm CPUs to use different XML files for AArch32 vs
> AArch64 without having to have an extra AArch64-specific class type
> purely to give somewhere to set cc->gdb_core_xml_file differently.
>
> Signed-off-by: Peter Maydell
Acked-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
update
> the documentation.
>
> Make the documentation match the new semantics.
>
> Fixes: a650683871ba728 ("hw/core/cpu: Return static value with
> gdb_arch_name()")
> Signed-off-by: Peter Maydell
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Richard Henderson writes:
> We assert that env immediately follows CPUState in cpu-all.h.
> Change the offsetof expressions to be based on CPUState instead
> of ArchCPU.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
indeed style says:
Do not include "qemu/osdep.h" from header files since the .c file will have
already included it.
> +#include "exec/hwaddr.h"
> +#include "hw/core/cpu.h"
> #include "hw/hyperv/hyperv-proto.h"
>
> typedef struct HvSintRoute HvSintRoute;
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Pierrick Bouvier writes:
> Signed-off-by: Pierrick Bouvier
Reviewed-by: Alex Bennée
Tested-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Branch: refs/heads/staging-7.2
Home: https://github.com/qemu/qemu
Commit: ac9a4070ea2d8bf7a45fa72da20ecbac1dc07940
https://github.com/qemu/qemu/commit/ac9a4070ea2d8bf7a45fa72da20ecbac1dc07940
Author: Michael Tokarev
Date: 2025-03-15 (Sat, 15 Mar 2025)
Changed paths:
M n
Branch: refs/heads/staging-8.2
Home: https://github.com/qemu/qemu
Commit: 266f493b987474e7c9488cc82d44a65d7462faa7
https://github.com/qemu/qemu/commit/266f493b987474e7c9488cc82d44a65d7462faa7
Author: Michael Tokarev
Date: 2025-03-15 (Sat, 15 Mar 2025)
Changed paths:
M n
value: false,
>> description: 'split debug info from object files')
>> option('qom_cast_debug', type: 'boolean', value: true,
>> description: 'cast debugging support')
>
> Unfortunate coincidence, this appears at the same time MSYS2 fixed
> some issue triggering a segfault [1]. So I didn't investigate further
> the current issue, thinking something else have been changed I don't
> know where.
>
> Would be better to revert it completely indeed, creating another build
> configuration is not worth the (cheap) disk storage saved.
Well we should disable debug info on the CI builds then. Nothing is free
and our CI is pretty damned heavy and the builds all add up when debug
info is on by default.
>
> [1] https://github.com/msys2/MINGW-packages/issues/23577
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
It was reported this breaks the final artefacts on windows when run
under Wine.
Signed-off-by: Alex Bennée
Cc: Konstantin Kostiuk
---
meson.build | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index c2c71b6f8a..9b1af6d030 100644
--- a
Konstantin Kostiuk writes:
> On Wed, Mar 12, 2025 at 6:24 PM Alex Bennée wrote:
>
> Daniel P. Berrangé writes:
>
> > On Wed, Mar 12, 2025 at 02:05:09PM +, Daniel P. Berrangé wrote:
> >> On Wed, Mar 12, 2025 at 03:52:45PM +0200, Konstantin Ko
Richard Henderson writes:
> CONFIG_USER_ONLY == !CONFIG_SYSTEM_ONLY.
> Therefore it's cleaner to just add to user_ss.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
---
> From: Pierrick Bouvier
> Sent: Wednesday, March 12, 2025 11:50:23 am
> To: Saanjh Sengupta ; Philippe Mathieu-Daudé
> ; Paolo Bonzini
> ; Marc-André Lureau
> Cc: amir.gon...@neuroblade.ai ;
> qemu-devel@nongnu.org ; Alex
> Benn
ces.h"
#include "system/memory.h"
#include "system/ram_addr.h"
-#include "exec/ram_addr.h"
#include "exec/target_page.h"
#include "hw/hw.h"
#include "qemu/error-report.h"
modified hw/vfio/iommufd.c
@@ -25,7 +25,6 @@
#include
ArchState *env, abi_ptr addr,
> -uint64_t val, uintptr_t ra)
> -{
> -int mmu_index = cpu_mmu_index(env_cpu(env), false);
> - cpu_stq_be_mmuidx_ra(env, addr, val, mmu_index, ra);
> -}
> -
> -void cpu_stw_le_data_ra(CPUArchState *env, abi_ptr addr,
> -uint32_t val, uintptr_t ra)
> -{
> -int mmu_index = cpu_mmu_index(env_cpu(env), false);
> -cpu_stw_le_mmuidx_ra(env, addr, val, mmu_index, ra);
> -}
> -
> -void cpu_stl_le_data_ra(CPUArchState *env, abi_ptr addr,
> -uint32_t val, uintptr_t ra)
> -{
> -int mmu_index = cpu_mmu_index(env_cpu(env), false);
> -cpu_stl_le_mmuidx_ra(env, addr, val, mmu_index, ra);
> -}
> -
> -void cpu_stq_le_data_ra(CPUArchState *env, abi_ptr addr,
> -uint64_t val, uintptr_t ra)
> -{
> -int mmu_index = cpu_mmu_index(env_cpu(env), false);
> -cpu_stq_le_mmuidx_ra(env, addr, val, mmu_index, ra);
> -}
> -
> -/*--*/
> -
> uint32_t cpu_ldub_data(CPUArchState *env, abi_ptr addr)
> {
> return cpu_ldub_data_ra(env, addr, 0);
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
fd.c
In file included from ../../hw/vfio/iommufd.c:28:
/home/alex/lsrc/qemu.git/include/system/ram_addr.h:22:10: fatal error: cpu.h:
No such file or directory
22 | #include "cpu.h"
| ^~~
compilation terminated.
I'll see if I can bisect...
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
)
Signed-off-by: Alex Bennée
---
tests/functional/test_aarch64_virt_gpu.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/functional/test_aarch64_virt_gpu.py
b/tests/functional/test_aarch64_virt_gpu.py
index f19a47f8b6..314d994a7a 100755
--- a/tests/functional/test_aarch64_virt_gpu
casued a problem.
>
> Hmm it appears that the meson "get_option('debug')" is entirely
> unconnected to QEMU's --enable-debug configure flag, which I did
> not realize.
>
> IOW, we've got -gsplit-dwarf enabled by default for everyone
> building QEMU, which feels dubious. IMHO only an explicit
> --enable-debug configure arg should have triggered it.
--enable-debug is more than debug info, --enable-debug-info is enabled
by default. If you build with --disable-debug-info then -gsplit-dwarf
won't be applied.
>
> In addition since its breaking Windows builds, it appears we
> need to block its usage on Windows.
>
>
> With regards,
> Daniel
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
These are only usable in system mode where we control the timer. For
user-mode make them NOPs.
Reviewed-by: Richard Henderson
Signed-off-by: Alex Bennée
Message-Id: <20250304222439.2035603-29-alex.ben...@linaro.org>
diff --git a/plugins/api-system.c b/plugins/api-system.c
index 3856
. Let
> us know
> if there are existing discussions or preferred directions for this work.
>
> Best regards,
>
> David Milosevic
> Firmware Developer
> 9elements
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
lobals*, like the
> generic globals residing in system/globals.c.
>
> [*]
> https://lore.kernel.org/qemu-devel/e514d6db-781d-4afe-b057-9046c7004...@redhat.com/
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
t early on stalled RME tests
- compile core plugin code once
- update MAINTAINERS
----
Alex Bennée (26):
tests/functional: move aarch64 GPU test into own file
tests/functional: factor out common code in gpu test
tests/
1 - 100 of 2075 matches
Mail list logo
