[webkit-changes] [WebKit/WebKit] 33d8a4: Add some tests that decide to download after an HT...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 33d8a411c327e0b5afa05799bb9a2935c46b19f4 https://github.com/WebKit/WebKit/commit/33d8a411c327e0b5afa05799bb9a2935c46b19f4 Author: Alex Christensen Date: 2024-01-31 (Wed, 31 Jan 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm M Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h M Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm Log Message: --- Add some tests that decide to download after an HTTP redirection https://bugs.webkit.org/show_bug.cgi?id=268350 rdar://121891934 Reviewed by Charlie Wolfe. Choosing to download only after seeing a redirect response is a case that has no tests. It currently uses much of the same code paths as choosing to download when initially seeing a navigation action, but with some upcoming work I'm planning to make them different code paths, so it's important to add a test for this case to verify existing behavior does not change. * Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm: * Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h: * Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm: (-[TestNavigationDelegate waitForDidFailProvisionalNavigation]): (-[TestNavigationDelegate webView:navigationAction:didBecomeDownload:]): (-[TestNavigationDelegate webView:navigationResponse:didBecomeDownload:]): Canonical link: https://commits.webkit.org/273854@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 58b0fd: RemoteDOMWindow::close needs same security checks ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 58b0fdf84a3249ec5964ceb9fddf236f2c99b01c https://github.com/WebKit/WebKit/commit/58b0fdf84a3249ec5964ceb9fddf236f2c99b01c Author: Alex Christensen Date: 2024-02-01 (Thu, 01 Feb 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations M Source/WebCore/page/DOMWindow.cpp M Source/WebCore/page/DOMWindow.h M Source/WebCore/page/FrameDestructionObserver.cpp M Source/WebCore/page/LocalDOMWindow.cpp M Source/WebCore/page/LocalDOMWindow.h M Source/WebCore/page/RemoteDOMWindow.cpp M Source/WebCore/page/RemoteDOMWindow.h M Source/WebCore/page/RemoteFrame.cpp M Source/WebCore/page/RemoteFrameClient.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h Log Message: --- RemoteDOMWindow::close needs same security checks as LocalDOMWindow::close https://bugs.webkit.org/show_bug.cgi?id=268530 rdar://117381050 Reviewed by Charlie Wolfe. I moved the checks to DOMWindow and shared them. I added RemoteDOMWindow::frameDetached so that frame.remove() followed immediately by frame.contentWindow.closed returns true with a RemoteDOMWindow like it does a LocalDOMWindow because the frame gets detached. WebPageProxy::closeRemoteFrame isn't really needed any more because we already have checks that the close() call is only coming from a main frame, so it is closing the page. Just call WebPage::closePage to close the page without having an unneeded code path. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Source/WebCore/page/DOMWindow.cpp: (WebCore::DOMWindow::close): (WebCore::DOMWindow::console const): (WebCore::DOMWindow::checkedConsole const): * Source/WebCore/page/DOMWindow.h: * Source/WebCore/page/FrameDestructionObserver.cpp: (WebCore::FrameDestructionObserver::~FrameDestructionObserver): * Source/WebCore/page/LocalDOMWindow.cpp: (WebCore::LocalDOMWindow::closePage): (WebCore::LocalDOMWindow::console const): Deleted. (WebCore::LocalDOMWindow::checkedConsole const): Deleted. (WebCore::LocalDOMWindow::close): Deleted. * Source/WebCore/page/LocalDOMWindow.h: * Source/WebCore/page/RemoteDOMWindow.cpp: (WebCore::RemoteDOMWindow::closePage): (WebCore::RemoteDOMWindow::frameDetached): (WebCore::RemoteDOMWindow::close): Deleted. * Source/WebCore/page/RemoteDOMWindow.h: * Source/WebCore/page/RemoteFrame.cpp: (WebCore::RemoteFrame::frameDetached): * Source/WebCore/page/RemoteFrameClient.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::closeRemoteFrame): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp: (WebKit::WebRemoteFrameClient::closePage): (WebKit::WebRemoteFrameClient::close): Deleted. * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h: Canonical link: https://commits.webkit.org/273911@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 439730: Document::isFullyActive should return true for roo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 439730f0a14873980e7da9b305f7aad6ae4d2c39 https://github.com/WebKit/WebKit/commit/439730f0a14873980e7da9b305f7aad6ae4d2c39 Author: Alex Christensen Date: 2024-02-02 (Fri, 02 Feb 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations M Source/WebCore/dom/Document.cpp Log Message: --- Document::isFullyActive should return true for root frames in addition to main frames https://bugs.webkit.org/show_bug.cgi?id=268603 rdar://122164616 Reviewed by Charlie Wolfe. Before this change XMLHttpRequest::open would always throw an exception if called from a cross-site iframe with site isolation enabled. This will probably fix a lot of behavior. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Source/WebCore/dom/Document.cpp: (WebCore::Document::isFullyActive const): Canonical link: https://commits.webkit.org/273989@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f3054a: Add some tests for CFArrayRef serialization
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f3054ac4d2cb5b6348a7612c2366c4ba539df389 https://github.com/WebKit/WebKit/commit/f3054ac4d2cb5b6348a7612c2366c4ba539df389 Author: Alex Christensen Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebKit/Shared/cf/ArgumentCodersCF.cpp M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm Log Message: --- Add some tests for CFArrayRef serialization https://bugs.webkit.org/show_bug.cgi?id=268681 Reviewed by Brady Eidson. Also make WebKit not assert when things that were previously untested happen. * Source/WebKit/Shared/cf/ArgumentCodersCF.cpp: (IPC::typeFromCFTypeRef): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): * Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm: (secTrustRefsEqual): (cfHolder): (operator==): (operator!=): (arraysEqual): (TEST): (compareSecTrustRefs): Deleted. Canonical link: https://commits.webkit.org/274048@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 817b93: Generate serialization of CFArrayRef
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 817b93374cbff38a0b7693d8b316219157b68478 https://github.com/WebKit/WebKit/commit/817b93374cbff38a0b7693d8b316219157b68478 Author: Alex Christensen Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm M Source/WebKit/Shared/Cocoa/CoreIPCCFType.h M Source/WebKit/Shared/Cocoa/CoreIPCCFType.serialization.in A Source/WebKit/Shared/Cocoa/CoreIPCRetainPtr.h M Source/WebKit/Shared/cf/ArgumentCodersCF.cpp M Source/WebKit/Shared/cf/ArgumentCodersCF.h M Source/WebKit/Shared/cf/CFTypes.serialization.in A Source/WebKit/Shared/cf/CoreIPCCFArray.h A Source/WebKit/Shared/cf/CoreIPCCFArray.mm A Source/WebKit/Shared/cf/CoreIPCCFArray.serialization.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Generate serialization of CFArrayRef https://bugs.webkit.org/show_bug.cgi?id=268700 Reviewed by Brady Eidson. To retain existing behavior, we need a type distinct from CoreIPCArray which wraps NSArray. The day may come when all our array serialization specifies what is inside the array, but until then we need CoreIPCCFArray. Covered by tests from 274048@main * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h: (IPC::ArgumentCoder>::encode): (IPC::CoreIPCRetainPtr::CoreIPCRetainPtr): Deleted. * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::encodeObjectDirectly): * Source/WebKit/Shared/Cocoa/CoreIPCCFType.h: * Source/WebKit/Shared/Cocoa/CoreIPCCFType.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCRetainPtr.h: Copied from Source/WebKit/Shared/Cocoa/CoreIPCCFType.h. (IPC::CoreIPCRetainPtr::CoreIPCRetainPtr): * Source/WebKit/Shared/cf/ArgumentCodersCF.cpp: (IPC::typeFromCFTypeRef): (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder>::decode): Deleted. * Source/WebKit/Shared/cf/ArgumentCodersCF.h: * Source/WebKit/Shared/cf/CFTypes.serialization.in: * Source/WebKit/Shared/cf/CoreIPCCFArray.h: Copied from Source/WebKit/Shared/Cocoa/CoreIPCCFType.h. (WebKit::CoreIPCCFArray::CoreIPCCFArray): (WebKit::CoreIPCCFArray::array const): * Source/WebKit/Shared/cf/CoreIPCCFArray.mm: Copied from Source/WebKit/Shared/Cocoa/CoreIPCCFType.h. (WebKit::CoreIPCCFArray::CoreIPCCFArray): (WebKit::CoreIPCCFArray::createCFArray const): * Source/WebKit/Shared/cf/CoreIPCCFArray.serialization.in: Copied from Source/WebKit/Shared/Cocoa/CoreIPCCFType.serialization.in. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/274062@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b0bcfd: Generate serialization of SerializedPlatformDataCu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b0bcfd764ea406c4eea381e0a0191977fc06ad81 https://github.com/WebKit/WebKit/commit/b0bcfd764ea406c4eea381e0a0191977fc06ad81 Author: Alex Christensen Date: 2024-02-06 (Tue, 06 Feb 2024) Changed paths: M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/platform/SerializedPlatformDataCueValue.h A Source/WebCore/platform/cocoa/SerializedPlatformDataCueValue.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm M Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h M Source/WebCore/platform/mac/SerializedPlatformDataCueMac.mm M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp M Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm M Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp Log Message: --- Generate serialization of SerializedPlatformDataCueValue https://bugs.webkit.org/show_bug.cgi?id=268805 Reviewed by Eric Carlson. Before this change, SerializedPlatformDataCueValue was a strange abstraction that contained a RetainPtr that was either a AVMetadataItem or an NSDictionary extracted from it, and there wasn't a good way to tell if that extraction had happened from the abstraction itself. Also, the NSDictionary had a generous allowance for the types of contents it would allow to be serialized across IPC. This changes SerializedPlatformDataCueValue to be a container for strictly typed data that is extracted from an AVMetadataItem. I made a few assumptions to make this possible: 1. AVMetadataItem.extraAttributes contains only keys and values we care about that have a type of NSString. Others will now be ignored. Non-String keys were already ignored. AVMetadataItem.h pointed to AVMetadataFormat.h which seems to indicate this is a reasonable assumption. 2. AVMetadataItem.key contains only an NSString if we care about it. The API indicates it is a id but I don't think we support anything useful that isn't an NSString. 3. AVMetadataItem.value is either nil, a number, a string, an NSDate, or an NSData. The existence of stringValue, numberValue, dateValue, and dataValue selectors on AVMetadataItem objects seems to indicate that these are the valid values. * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/SerializedPlatformDataCueValue.h: (WebCore::SerializedPlatformDataCueValue::SerializedPlatformDataCueValue): (WebCore::SerializedPlatformDataCueValue::data const): (WebCore::SerializedPlatformDataCueValue::platformType const): Deleted. (WebCore::SerializedPlatformDataCueValue::nativeValue const): Deleted. (WebCore::SerializedPlatformDataCueValue::encodingRequiresPlatformData const): Deleted. (): Deleted. * Source/WebCore/platform/cocoa/SerializedPlatformDataCueValue.mm: Added. (WebCore::SerializedPlatformDataCueValue::SerializedPlatformDataCueValue): (WebCore::SerializedPlatformDataCueValue::toNSDictionary const): (WebCore::SerializedPlatformDataCueValue::operator== const): (WebCore::SerializedPlatformDataCueValue::Data::operator== const): * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive): * Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h: * Source/WebCore/platform/mac/SerializedPlatformDataCueMac.mm: (WebCore::SerializedPlatformDataCueMac::SerializedPlatformDataCueMac): (WebCore::SerializedPlatformDataCueMac::deserialize const): (WebCore::SerializedPlatformDataCueMac::isEqual const): (WebCore::toSerializedPlatformDataCueMac): (WebCore::SerializedPlatformDataCueMac::encodableValue const): (WebCore::jsValueWithAVMetadataItemInContext): (WebCore::NSDictionaryWithAVMetadataItem): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm: (IPC::ArgumentCoder::encodePlatformData): Deleted. (IPC::ArgumentCoder::decodePlatformData): Deleted. Canonical link: https://commits.webkit.org/274146@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 46c731: Remove PlatformCALayer.serialization.in
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 46c731bfce9e972c97c486307dfb1d9b3d19860d https://github.com/WebKit/WebKit/commit/46c731bfce9e972c97c486307dfb1d9b3d19860d Author: Alex Christensen Date: 2024-02-06 (Tue, 06 Feb 2024) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj R Source/WebCore/platform/graphics/ca/PlatformCALayer.serialization.in M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in Log Message: --- Remove PlatformCALayer.serialization.in https://bugs.webkit.org/show_bug.cgi?id=268840 rdar://121877374 Unreviewed. It is causing a build failure because of the way it's included in WebCore.framework. To be sure the build failure is gone, remove the file completely and move its contents to WebCoreArgumentCodersCocoa.serialization.in. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/graphics/ca/PlatformCALayer.serialization.in: Removed. * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in: Canonical link: https://commits.webkit.org/274166@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0d2bc1: Generate serialization of CFDictionaryRef
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d2bc1171d06de6b2816e04b2b292aaa00a68391 https://github.com/WebKit/WebKit/commit/0d2bc1171d06de6b2816e04b2b292aaa00a68391 Author: Alex Christensen Date: 2024-02-06 (Tue, 06 Feb 2024) Changed paths: M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/Cocoa/CoreIPCArray.h M Source/WebKit/Shared/Cocoa/CoreIPCArray.mm M Source/WebKit/Shared/Cocoa/CoreIPCArray.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCCFType.h M Source/WebKit/Shared/Cocoa/CoreIPCDictionary.h M Source/WebKit/Shared/Cocoa/CoreIPCDictionary.mm M Source/WebKit/Shared/Cocoa/CoreIPCDictionary.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.serialization.in M Source/WebKit/Shared/cf/ArgumentCodersCF.cpp M Source/WebKit/Shared/cf/ArgumentCodersCF.h M Source/WebKit/Shared/cf/CFTypes.serialization.in M Source/WebKit/Shared/cf/CoreIPCCFArray.h M Source/WebKit/Shared/cf/CoreIPCCFArray.mm M Source/WebKit/Shared/cf/CoreIPCCFArray.serialization.in A Source/WebKit/Shared/cf/CoreIPCCFDictionary.h A Source/WebKit/Shared/cf/CoreIPCCFDictionary.mm A Source/WebKit/Shared/cf/CoreIPCCFDictionary.serialization.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm Log Message: --- Generate serialization of CFDictionaryRef https://bugs.webkit.org/show_bug.cgi?id=268777 Reviewed by Brady Eidson. And clean up the other Array/Dictionary serialization. Remove some unneeded allocations from unneeded UniqueRef pointers. * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/Cocoa/CoreIPCArray.h: (WebKit::CoreIPCArray::CoreIPCArray): * Source/WebKit/Shared/Cocoa/CoreIPCArray.mm: (WebKit::CoreIPCArray::CoreIPCArray): (WebKit::CoreIPCArray::toID const): * Source/WebKit/Shared/Cocoa/CoreIPCArray.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCCFType.h: * Source/WebKit/Shared/Cocoa/CoreIPCDictionary.h: * Source/WebKit/Shared/Cocoa/CoreIPCDictionary.mm: (WebKit::CoreIPCDictionary::CoreIPCDictionary): (WebKit::CoreIPCDictionary::createNSDictionaryIfNeeded const): * Source/WebKit/Shared/Cocoa/CoreIPCDictionary.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h: (WebKit::CoreIPCNSCFObject::value const): * Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.serialization.in: * Source/WebKit/Shared/cf/ArgumentCodersCF.cpp: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder>::decode): Deleted. * Source/WebKit/Shared/cf/ArgumentCodersCF.h: * Source/WebKit/Shared/cf/CFTypes.serialization.in: * Source/WebKit/Shared/cf/CoreIPCCFArray.h: (WebKit::CoreIPCCFArray::array const): (WebKit::CoreIPCCFArray::CoreIPCCFArray): Deleted. * Source/WebKit/Shared/cf/CoreIPCCFArray.mm: (WebKit::CoreIPCCFArray::CoreIPCCFArray): * Source/WebKit/Shared/cf/CoreIPCCFArray.serialization.in: * Source/WebKit/Shared/cf/CoreIPCCFDictionary.h: Copied from Source/WebKit/Shared/cf/CoreIPCCFArray.h. (WebKit::CoreIPCCFDictionary::vector const): * Source/WebKit/Shared/cf/CoreIPCCFDictionary.mm: Copied from Source/WebKit/Shared/cf/CoreIPCCFArray.mm. (WebKit::CoreIPCCFDictionary::CoreIPCCFDictionary): (WebKit::CoreIPCCFDictionary::createCFDictionary const): * Source/WebKit/Shared/cf/CoreIPCCFDictionary.serialization.in: Copied from Source/WebKit/Shared/cf/CoreIPCCFArray.serialization.in. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm: (operator==): (dictionariesEqual): (TEST): Canonical link: https://commits.webkit.org/274192@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c7f3c0: Fix iOS build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c7f3c0c1ffdff4ed0d71887170d44c3ddaff https://github.com/WebKit/WebKit/commit/c7f3c0c1ffdff4ed0d71887170d44c3ddaff Author: Alex Christensen Date: 2024-02-07 (Wed, 07 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm Log Message: --- Fix iOS build https://bugs.webkit.org/show_bug.cgi?id=268919 Unreviewed. * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: Canonical link: https://commits.webkit.org/274217@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0c1bf2: Enable WKWebsiteDataStore.proxyConfigurations test...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0c1bf2e5136c5cba56cc4e647169be09861a1a52 https://github.com/WebKit/WebKit/commit/0c1bf2e5136c5cba56cc4e647169be09861a1a52 Author: Alex Christensen Date: 2024-02-07 (Wed, 07 Feb 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm Log Message: --- Enable WKWebsiteDataStore.proxyConfigurations tests on iOS simulator https://bugs.webkit.org/show_bug.cgi?id=26 rdar://122444342 Reviewed by Chris Dumez. * Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Canonical link: https://commits.webkit.org/274219@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a869bc: Remove runtime check for using extensions when USE...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a869bc0414302a680f5ca9968bf01326f1af76d2 https://github.com/WebKit/WebKit/commit/a869bc0414302a680f5ca9968bf01326f1af76d2 Author: Alex Christensen Date: 2024-02-07 (Wed, 07 Feb 2024) Changed paths: M Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h M Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm M Source/WebKit/UIProcess/Launcher/ProcessLauncher.h M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/ios/WKContentView.mm Log Message: --- Remove runtime check for using extensions when USE(EXTENSIONKIT) is true https://bugs.webkit.org/show_bug.cgi?id=268944 Reviewed by Per Arne Vollan. The runtime check is no longer needed. This also fixes some issues when you use a WKWebsiteDataStore and the network process before a WKProcessPool has been allocated. * Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp: * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: (WebKit::AuxiliaryProcessProxy::setManageProcessesAsExtensions): Deleted. (WebKit::AuxiliaryProcessProxy::manageProcessesAsExtensions): Deleted. * Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm: (WebKit::AuxiliaryProcessProxy::platformGetLaunchOptions): * Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::updateMediaCapability): * Source/WebKit/UIProcess/WebProcessPool.cpp: * Source/WebKit/UIProcess/ios/WKContentView.mm: (-[WKContentView _setupVisibilityPropagationForWebProcess]): (-[WKContentView _setupVisibilityPropagationForGPUProcess]): (-[WKContentView _createVisibilityPropagationView]): Canonical link: https://commits.webkit.org/274267@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eb3525: Proxy configuration should apply after a network p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eb352590aabe6bd659e180e58eaa5fd9b00fe33b https://github.com/WebKit/WebKit/commit/eb352590aabe6bd659e180e58eaa5fd9b00fe33b Author: Alex Christensen Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M Source/WebKit/NetworkProcess/NetworkSession.h M Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h M Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.serialization.in M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm Log Message: --- Proxy configuration should apply after a network process crash https://bugs.webkit.org/show_bug.cgi?id=268952 rdar://122361008 Reviewed by Brady Eidson. * Source/WebKit/NetworkProcess/NetworkSession.h: (WebKit::NetworkSession::setProxyConfigData): * Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h: * Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.serialization.in: * Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h: * Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::NetworkSessionCocoa): (WebKit::NetworkSessionCocoa::setProxyConfigData): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::parameters): (WebKit::WebsiteDataStore::setProxyConfigData): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/274287@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4c2316: Pass opener frame info from UI process to main fra...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4c2316acb3d16926f92634aedb92ecdd0fb32829 https://github.com/WebKit/WebKit/commit/4c2316acb3d16926f92634aedb92ecdd0fb32829 Author: Alex Christensen Date: 2024-02-09 (Fri, 09 Feb 2024) Changed paths: M Source/WebCore/loader/CrossOriginOpenerPolicy.cpp M Source/WebCore/loader/CrossOriginOpenerPolicy.h M Source/WebCore/loader/EmptyClients.cpp M Source/WebCore/page/LocalFrame.cpp M Source/WebCore/page/LocalFrame.h M Source/WebCore/page/Page.cpp M Source/WebCore/page/PageConfiguration.cpp M Source/WebCore/page/PageConfiguration.h M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.h M Source/WebKit/UIProcess/RemotePageProxy.cpp M Source/WebKit/UIProcess/RemotePageProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKitLegacy/mac/WebView/WebView.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- Pass opener frame info from UI process to main frame constructor https://bugs.webkit.org/show_bug.cgi?id=268704 rdar://122248591 Reviewed by Pascoe. If a page has an opener, with site isolation we will need to get that information from the UI process if the opener is in a different process than the opened page. This is the first step to better supporting window.open and iframe combinations with site isolation. The next step is having the BrowsingContextGroup not only keep track of what processes are in the group for what domain, but also keep track of what pages are in the group so they can all have RemoteFrames injected into a new process in the group. * Source/WebCore/loader/EmptyClients.cpp: (WebCore::pageConfigurationWithEmptyClients): * Source/WebCore/page/LocalFrame.cpp: (WebCore::LocalFrame::LocalFrame): (WebCore::LocalFrame::createMainFrame): (WebCore::LocalFrame::createSubframe): (WebCore::LocalFrame::createSubframeHostedInAnotherProcess): * Source/WebCore/page/LocalFrame.h: * Source/WebCore/page/Page.cpp: (WebCore::createMainFrame): (WebCore::Page::Page): * Source/WebCore/page/PageConfiguration.cpp: (WebCore::PageConfiguration::PageConfiguration): * Source/WebCore/page/PageConfiguration.h: * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::initializeWebPage): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): * Source/WebKit/WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::transitionToLocal): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::frameOpener): (WebKit::m_unifiedTextReplacementController): * Source/WebKitLegacy/mac/WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/274396@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 61fe26: Generate serialization of CFTypeRef
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 61fe261d3f3700cddd82c2ace9b93ceeaa55146f https://github.com/WebKit/WebKit/commit/61fe261d3f3700cddd82c2ace9b93ceeaa55146f Author: Alex Christensen Date: 2024-02-12 (Mon, 12 Feb 2024) Changed paths: M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Platform/IPC/ArgumentCoders.h M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/TestWithCVPixelBufferMessageReceiver.cpp M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm M Source/WebKit/Shared/Cocoa/CoreIPCArray.h M Source/WebKit/Shared/Cocoa/CoreIPCArray.mm M Source/WebKit/Shared/Cocoa/CoreIPCCFType.h A Source/WebKit/Shared/Cocoa/CoreIPCCFType.mm M Source/WebKit/Shared/Cocoa/CoreIPCCFType.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCColor.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCDictionary.h M Source/WebKit/Shared/Cocoa/CoreIPCDictionary.mm M Source/WebKit/Shared/Cocoa/CoreIPCError.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.serialization.in A Source/WebKit/Shared/Cocoa/CoreIPCNull.h A Source/WebKit/Shared/Cocoa/CoreIPCNull.mm A Source/WebKit/Shared/Cocoa/CoreIPCNull.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCRetainPtr.h M Source/WebKit/Shared/Cocoa/CoreIPCString.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCTypes.h M Source/WebKit/Shared/Cocoa/CoreIPCURL.serialization.in M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h R Source/WebKit/Shared/cf/ArgumentCodersCF.cpp R Source/WebKit/Shared/cf/ArgumentCodersCF.h M Source/WebKit/Shared/cf/CFTypes.serialization.in M Source/WebKit/Shared/cf/CoreIPCCFArray.h M Source/WebKit/Shared/cf/CoreIPCCFArray.mm M Source/WebKit/Shared/ios/InteractionInformationRequest.cpp M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm Log Message: --- Generate serialization of CFTypeRef https://bugs.webkit.org/show_bug.cgi?id=269090 rdar://122666159 Reviewed by Brady Eidson. * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Platform/IPC/ArgumentCoders.h: * Source/WebKit/Scripts/webkit/messages.py: (class_template_headers): * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h: * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::typeFromObject): * Source/WebKit/Shared/Cocoa/CoreIPCArray.h: (WebKit::CoreIPCArray::CoreIPCArray): Deleted. * Source/WebKit/Shared/Cocoa/CoreIPCArray.mm: (WebKit::CoreIPCArray::CoreIPCArray): * Source/WebKit/Shared/Cocoa/CoreIPCCFType.h: (WebKit::CoreIPCCFType::object const): (WebKit::CoreIPCCFType::CoreIPCCFType): Deleted. (WebKit::CoreIPCCFType::toID const): Deleted. * Source/WebKit/Shared/Cocoa/CoreIPCCFType.mm: Added. (WebKit::variantFromCFType): (WebKit::CoreIPCCFType::CoreIPCCFType): (WebKit::CoreIPCCFType::toID const): (WebKit::CoreIPCCFType::toCFType const): (IPC::typeFromCFTypeRef): (IPC::ArgumentCoder>::encode): (IPC::ArgumentCoder>::decode): * Source/WebKit/Shared/Cocoa/CoreIPCCFType.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCColor.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCDictionary.h: (WebKit::CoreIPCDictionary::CoreIPCDictionary): Deleted. * Source/WebKit/Shared/Cocoa/CoreIPCDictionary.mm: (WebKit::CoreIPCDictionary::CoreIPCDictionary): * Source/WebKit/Shared/Cocoa/CoreIPCError.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h: * Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm: (WebKit::valueFromID): * Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCNull.h: Copied from Source/WebKit/Shared/Cocoa/CoreIPCRetainPtr.h. * Source/WebKit/Shared/Cocoa/CoreIPCNull.mm: Copied from Source/WebKit/Shared/Cocoa/CoreIPCRetainPtr.h. (WebKit::CoreIPCNull::CoreIPCNull): (WebKit::CoreIPCNull::toID const): (WebKit::CoreIPCNull::toCFObject const): * Source/WebKit/Shared/Cocoa/CoreIPCNull.serialization.in: Copied from Source/WebKit/Shared/Cocoa/CoreIPCCFType.serialization.in. * Source/WebKit/Shared/Cocoa/CoreIPCRetainPtr.h: * Source/WebKit/Shared/Cocoa/CoreIPCString.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCTypes.h: * Source/WebKit/Shared/Cocoa/CoreIPCURL.serialization.in: * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm: * Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm: * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: * Source/
[webkit-changes] [WebKit/WebKit] 272b9b: Move VKCImageAnalysis deserialization away from ot...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 272b9bed22c24464ce9e3862066291558badba97 https://github.com/WebKit/WebKit/commit/272b9bed22c24464ce9e3862066291558badba97 Author: Alex Christensen Date: 2024-02-12 (Mon, 12 Feb 2024) Changed paths: M Source/WebCore/platform/TextRecognitionResult.h M Source/WebCore/platform/cocoa/TextRecognitionResultCocoa.mm M Source/WebCore/testing/Internals.cpp M Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm M Source/WebKit/Shared/TextRecognitionResult.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.h Log Message: --- Move VKCImageAnalysis deserialization away from other NSObject deserializers https://bugs.webkit.org/show_bug.cgi?id=269230 rdar://122825380 Reviewed by Wenson Hsieh. It is currently the only ObjC object that is deserialized from IPC without _enableStrictSecureDecodingMode, which is less urgent because it is only sent from the trusted UI process to the untrusted web content process. This PR just moves that logic away from the rest of the IPC logic and adds a release assertion to make sure we don't introduce a security issue in the future. * Source/WebCore/platform/TextRecognitionResult.h: * Source/WebCore/platform/cocoa/TextRecognitionResultCocoa.mm: (WebCore::TextRecognitionResult::encodeVKCImageAnalysis): (WebCore::TextRecognitionResult::decodeVKCImageAnalysis): (WebCore::stringForRange): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::installImageOverlay): * Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm: (WebKit::makeTextRecognitionResult): * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::shouldEnableStrictMode): * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm: (IPC::getClass): Deleted. (IPC::ArgumentCoder>::encode): Deleted. (IPC::ArgumentCoder>::decode): Deleted. * Source/WebKit/Shared/TextRecognitionResult.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.h: Canonical link: https://commits.webkit.org/274495@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fa850b: Remove DictionaryLookupLegacy and associated NSDic...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fa850bc9a68cedc60740b89dd3aadc436431f8f4 https://github.com/WebKit/WebKit/commit/fa850bc9a68cedc60740b89dd3aadc436431f8f4 Author: Alex Christensen Date: 2024-02-12 (Mon, 12 Feb 2024) Changed paths: M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/editing/DictionaryPopupInfo.h M Source/WebCore/editing/cocoa/DictionaryLookup.mm M Source/WebCore/editing/mac/DictionaryLookup.h R Source/WebCore/editing/mac/DictionaryLookupLegacy.mm M Source/WebCore/page/cocoa/EventHandlerCocoa.mm M Source/WebCore/testing/Internals.mm M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PluginView.cpp M Source/WebKit/WebProcess/Plugins/PluginView.h M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm M Source/WebKitLegacy/mac/WebView/WebImmediateActionController.h M Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm Log Message: --- Remove DictionaryLookupLegacy and associated NSDictionary piping https://bugs.webkit.org/show_bug.cgi?id=269248 rdar://122837616 Reviewed by Megan Gardner. DictionaryLookupLegacy is dead code that is not compiled anywhere. It is also the only source of the NSDictionary "options" that is sent to the UI process, then nothing is done with it. Remove all that. * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/editing/DictionaryPopupInfo.h: * Source/WebCore/editing/cocoa/DictionaryLookup.mm: (WebCore::DictionaryLookup::rangeForSelection): (WebCore::DictionaryLookup::rangeAtHitTestResult): (WebCore::DictionaryLookup::stringForPDFSelection): (): Deleted. * Source/WebCore/editing/mac/DictionaryLookup.h: * Source/WebCore/editing/mac/DictionaryLookupLegacy.mm: Removed. * Source/WebCore/page/cocoa/EventHandlerCocoa.mm: (WebCore::EventHandler::selectClosestWordFromHitTestResultBasedOnLookup): * Source/WebCore/testing/Internals.mm: (WebCore::Internals::rangeForDictionaryLookupAtLocation): * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in: * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit:: const): * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit:: const): * Source/WebKit/WebProcess/Plugins/PluginView.cpp: (WebKit:: const): * Source/WebKit/WebProcess/Plugins/PluginView.h: * Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::performDictionaryLookupAtLocation): (WebKit::WebPage::performDictionaryLookupForSelection): (WebKit::WebPage::performDictionaryLookupForRange): (WebKit::WebPage::dictionaryPopupInfoForRange): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::dictionaryPopupInfoForSelectionInPDFPlugin): (WebKit::WebPage::performImmediateActionHitTestAtLocation): (WebKit::WebPage::lookupTextAtLocation): * Source/WebKitLegacy/mac/WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): * Source/WebKitLegacy/mac/WebView/WebImmediateActionController.h: * Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm: (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:indicatorOptions:transition:]): (-[WebImmediateActionController _animationControllerForText]): (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]): Deleted. Canonical link: https://commits.webkit.org/274520@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dc8400: Use generated structures instead of NSDictionary t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dc8400212ff7ed91d184f6340b65758f860b5de5 https://github.com/WebKit/WebKit/commit/dc8400212ff7ed91d184f6340b65758f860b5de5 Author: Alex Christensen Date: 2024-02-15 (Thu, 15 Feb 2024) Changed paths: M Source/WebKit/Scripts/generate-serializers.py M Source/WebKit/Scripts/webkit/tests/GeneratedWebKitSecureCoding.cpp M Source/WebKit/Scripts/webkit/tests/GeneratedWebKitSecureCoding.h M Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp M Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in M Source/WebKit/Scripts/webkit/tests/WebKitPlatformGeneratedSerializers.cpp M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm M Source/WebKit/Shared/Cocoa/CoreIPCDictionary.h M Source/WebKit/Shared/Cocoa/CoreIPCDictionary.mm M Source/WebKit/Shared/Cocoa/CoreIPCDictionary.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm M Source/WebKit/Shared/Cocoa/CoreIPCNSURLProtectionSpace.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCPassKit.serialization.in Log Message: --- Use generated structures instead of NSDictionary to serialize members of ObjC classes https://bugs.webkit.org/show_bug.cgi?id=269438 rdar://122994790 Reviewed by Brady Eidson. This makes it so that we don't need to expand what an NSDictionary can contain in order to increase the number of ObjC classes that are serialized using generated serialization. This also makes it so we don't need "webkit_secure_coding" in SerializedTypeInfo.cpp, so all the metadata has the same form. We can also simplify CoreIPCDictionary to just a vector of key/value pairs. If a type is not declared as optional with a question mark in the serialization.in file, then we debug assert on the encoding side if it is missing and we fail to decode on the decoding side if it is missing. * Source/WebKit/Scripts/generate-serializers.py: (SerializedType.__init__): (SerializedType.name_declaration_for_serialized_type_info): (SerializedType.members_for_serialized_type_info): (MemberVariable.value_without_question_mark): (MemberVariable): (MemberVariable.ns_type_enum_value): (MemberVariable.array_contents): (MemberVariable.dictionary_contents): (MemberVariable.has_container_contents): (MemberVariable.ns_type): (MemberVariable.dictionary_type): (MemberVariable.value_is_optional): (check_type_members): (check_type_members.is): (encode_type): (decode_type): (construct_type): (generate_impl): (generate_one_serialized_type_info): (generate_serialized_type_info): (parse_serialized_types): (generate_webkit_secure_coding_impl): (generate_webkit_secure_coding_impl.is): (generate_webkit_secure_coding_header): (generate_one_dictionary_member_validation): Deleted. * Source/WebKit/Scripts/webkit/tests/GeneratedWebKitSecureCoding.cpp: (WebKit::dictionaryFromVector): (WebKit::dictionaryFromOptionalVector): (WebKit::vectorFromDictionary): (WebKit::optionalVectorFromDictionary): (WebKit::arrayFromVector): (WebKit::arrayFromOptionalVector): (WebKit::vectorFromArray): (WebKit::optionalVectorFromArray): (WebKit::CoreIPCAVOutputContext::CoreIPCAVOutputContext): (WebKit::CoreIPCAVOutputContext::toID const): (WebKit::CoreIPCNSSomeFoundationType::CoreIPCNSSomeFoundationType): (WebKit::CoreIPCNSSomeFoundationType::toID const): (WebKit::CoreIPCDDScannerResult::CoreIPCDDScannerResult): (WebKit::CoreIPCDDScannerResult::toID const): (WebKit::CoreIPCAVOutputContext::isValidDictionary): Deleted. (WebKit::CoreIPCNSSomeFoundationType::isValidDictionary): Deleted. (WebKit::CoreIPCDDScannerResult::isValidDictionary): Deleted. * Source/WebKit/Scripts/webkit/tests/GeneratedWebKitSecureCoding.h: (WebKit::CoreIPCAVOutputContext::CoreIPCAVOutputContext): (WebKit::CoreIPCNSSomeFoundationType::CoreIPCNSSomeFoundationType): (WebKit::CoreIPCDDScannerResult::CoreIPCDDScannerResult): * Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp: (WebKit::allSerializedTypes): * Source/WebKit/Scripts/webkit/tests/WebKitPlatformGeneratedSerializers.cpp: (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h: * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::getClass): * Source/WebKit/Shared/Cocoa/CoreIPCDictionary.h: * Source/WebKit/Shared/Cocoa/CoreIPCDictionary.mm: (WebKit::CoreIPCDictionary::CoreIPCDictionary): (WebKit::CoreIPCDictionary::toID const): (WebKit::CoreIPCDictionary::keyHasValueOfType const): Deleted. (WebKit::CoreIPCDictionary::keyIsMissingOrHasValueOfType const): Deleted. (WebKit::CoreIPCDictionary::collectionValuesAreOfType const): Deleted. (WebKit::CoreIPCDictionary::createNSDictionaryIfNeeded const): Dele
[webkit-changes] [WebKit/WebKit] c7e6ce: Fix Windows and Linux GPU process build after 2748...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c7e6ce586dfa3d5790f7feb2c3c8c0fc6a8ba893 https://github.com/WebKit/WebKit/commit/c7e6ce586dfa3d5790f7feb2c3c8c0fc6a8ba893 Author: Alex Christensen Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M Source/WebKit/GPUProcess/glib/GPUProcessMainGLib.cpp M Source/WebKit/GPUProcess/win/GPUProcessMainWin.cpp Log Message: --- Fix Windows and Linux GPU process build after 274801@main https://bugs.webkit.org/show_bug.cgi?id=269583 Unreviewed. The GPU process was changed to a singleton. * Source/WebKit/GPUProcess/glib/GPUProcessMainGLib.cpp: * Source/WebKit/GPUProcess/win/GPUProcessMainWin.cpp: Canonical link: https://commits.webkit.org/274836@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 89855a: Re-introduce CoreIPCNSURLProtectionSpace use
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 89855a5c73f6f58734d18cc0e08a7e2909fb7231 https://github.com/WebKit/WebKit/commit/89855a5c73f6f58734d18cc0e08a7e2909fb7231 Author: Alex Christensen Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm Log Message: --- Re-introduce CoreIPCNSURLProtectionSpace use https://bugs.webkit.org/show_bug.cgi?id=269555 rdar://123068342 Reviewed by Brady Eidson. * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h: * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::typeFromObject): (IPC::shouldEnableStrictMode): * Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h: * Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm: (WebKit::valueFromID): Canonical link: https://commits.webkit.org/274840@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9db70c: Re-enable generated serialization in PKPaymentMerc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9db70c5ef012a6e7693256a680db74af0f20c008 https://github.com/WebKit/WebKit/commit/9db70c5ef012a6e7693256a680db74af0f20c008 Author: Alex Christensen Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm M Source/WebKit/Shared/Cocoa/CoreIPCPassKit.serialization.in Log Message: --- Re-enable generated serialization in PKPaymentMerchantSession https://bugs.webkit.org/show_bug.cgi?id=269603 rdar://123107869 Reviewed by Brady Eidson. Optionalness is enforced for arrays and dictionary. We were missing a question mark. * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::typeFromObject): * Source/WebKit/Shared/Cocoa/CoreIPCPassKit.serialization.in: Canonical link: https://commits.webkit.org/274867@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6303dc: Fix and check using statements in serialization.in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6303dc5ac35a183593e52eb8a2409f3057dd179a https://github.com/WebKit/WebKit/commit/6303dc5ac35a183593e52eb8a2409f3057dd179a Author: Alex Christensen Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in M Source/WebKit/Scripts/generate-serializers.py M Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp M Source/WebKit/Shared/RTCNetwork.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Fix and check using statements in serialization.in files https://bugs.webkit.org/show_bug.cgi?id=269616 rdar://123118176 Reviewed by Brady Eidson. Some of them were wrong. I added static_asserts so it won't compile if any of them are wrong. * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in: * Source/WebKit/Scripts/generate-serializers.py: (generate_serialized_type_info): * Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp: * Source/WebKit/Shared/RTCNetwork.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/274903@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d7c3b9: Remove setting to enable plugin code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d7c3b9f118aa2f97ac8ff88f841b0e966c1d0a2a https://github.com/WebKit/WebKit/commit/d7c3b9f118aa2f97ac8ff88f841b0e966c1d0a2a Author: Alex Christensen Date: 2024-02-17 (Sat, 17 Feb 2024) Changed paths: M LayoutTests/fast/events/resources/tabindex-focus-blur-all.js M LayoutTests/fast/events/tabindex-focus-blur-all-expected.txt R LayoutTests/platform/mac-wk1/fast/events/tabindex-focus-blur-all-expected.txt M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/dom/DOMImplementation.cpp M Source/WebCore/editing/markup.cpp M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/html/HTMLPlugInImageElement.cpp M Source/WebCore/loader/SubframeLoader.cpp M Source/WebCore/page/Frame.cpp M Source/WebCore/page/Frame.h M Source/WebCore/page/SettingsBase.cpp M Source/WebCore/page/SettingsBase.h M Source/WebCore/svg/graphics/SVGImage.cpp M Source/WebKit/UIProcess/API/C/WKPreferences.cpp M Source/WebKit/UIProcess/API/C/WKPreferencesRef.h M Source/WebKit/UIProcess/WebPreferences.cpp M Source/WebKit/UIProcess/mac/WebViewImpl.mm M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm M Source/WebKitLegacy/mac/WebCoreSupport/WebPluginInfoProvider.mm M Source/WebKitLegacy/mac/WebView/WebDataSource.mm M Source/WebKitLegacy/mac/WebView/WebFrame.mm M Source/WebKitLegacy/mac/WebView/WebFrameView.mm M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h M Source/WebKitLegacy/mac/WebView/WebPreferences.mm M Source/WebKitLegacy/mac/WebView/WebView.mm M Tools/DumpRenderTree/TestOptions.cpp M Tools/TestWebKitAPI/Tests/WebKit/WKPreferences.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/Coding.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/Copying.mm M Tools/WebKitTestRunner/TestOptions.cpp Log Message: --- Remove setting to enable plugin code https://bugs.webkit.org/show_bug.cgi?id=269256 rdar://122841838 Reviewed by Brady Eidson. The code to actually load a plug in has been removed for a few years now, but there is still some runtime code to support plugins, but it's off by default. This continues the code removal. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): * Source/WebCore/editing/markup.cpp: (WebCore::createPageForSanitizingWebContent): * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::rendererIsEverNeeded): * Source/WebCore/html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::shouldBypassCSPForPDFPlugin const): * Source/WebCore/loader/SubframeLoader.cpp: (WebCore::FrameLoader::SubframeLoader::requestPlugin): * Source/WebCore/page/Frame.cpp: (WebCore::Frame::arePluginsEnabled): Deleted. * Source/WebCore/page/Frame.h: * Source/WebCore/page/SettingsBase.cpp: (WebCore::SettingsBase::pluginsEnabledChanged): Deleted. * Source/WebCore/page/SettingsBase.h: * Source/WebCore/svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): * Source/WebKit/UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetPluginsEnabled): (WKPreferencesGetPluginsEnabled): * Source/WebKit/UIProcess/API/C/WKPreferencesRef.h: * Source/WebKit/UIProcess/BrowsingContextGroup.cpp: (WebKit::BrowsingContextGroup::addProcessForDomain): (WebKit::BrowsingContextGroup::removeProcessForDomain): (WebKit::BrowsingContextGroup::addPage): (WebKit::BrowsingContextGroup::removePage): (WebKit::BrowsingContextGroup::forEachPageInOpeningOrder): * Source/WebKit/UIProcess/BrowsingContextGroup.h: * Source/WebKit/UIProcess/WebPreferences.cpp: (WebKit::WebPreferences::createWithLegacyDefaults): * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::preferencesDidChange): * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp: (WebKit::WebLocalFrameLoaderClient::objectContentType): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::canShowMIMEType const): * Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): * Source/WebKitLegacy/mac/WebCoreSupport/WebPluginInfoProvider.mm: (WebPluginInfoProvider::pluginInfo): * Source/WebKitLegacy/mac/WebView/WebDataSource.mm: (-[WebDataSource _makeRepresentation]): * Source/WebKitLegacy/mac/WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): * Source/WebKitLegacy/mac/WebView/WebFrameView.mm: (-[WebFrameView _viewClassForMIMEType:]): * Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferences.mm: (-[WebPreferences arePlugInsEnabled]): (-[WebPreferences setPlugInsEnabled:]): * Source/WebKitLegacy/mac/WebView/WebView.mm: (-[We
[webkit-changes] [WebKit/WebKit] 3eb7fa: Restrict types serialized in an NSDictionary and N...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3eb7fa3d34df30dc1066f15dd1f6137865df49b8 https://github.com/WebKit/WebKit/commit/3eb7fa3d34df30dc1066f15dd1f6137865df49b8 Author: Alex Christensen Date: 2024-02-17 (Sat, 17 Feb 2024) Changed paths: M Source/WebKit/Scripts/generate-serializers.py M Source/WebKit/Scripts/webkit/tests/GeneratedWebKitSecureCoding.cpp M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm Log Message: --- Restrict types serialized in an NSDictionary and NSArray https://bugs.webkit.org/show_bug.cgi?id=269613 rdar://122817546 Reviewed by Brady Eidson. When we used CoreIPCDictionary for serialization of all types that used WKKeyedCoder, when we increased the number of types that used WKKeyedCoder we increased the number of types that could be serialized in any NSDictionary or NSArray. Now that we are using generated structures for serialization of types using WKKeyedCoder, we can separate the coders and bring the number of types allowed in NSDictionary and NSArray back down. * Source/WebKit/Scripts/generate-serializers.py: (MemberVariable.type_check): (generate_webkit_secure_coding_impl): * Source/WebKit/Scripts/webkit/tests/GeneratedWebKitSecureCoding.cpp: (WebKit::CoreIPCAVOutputContext::CoreIPCAVOutputContext): (WebKit::CoreIPCNSSomeFoundationType::CoreIPCNSSomeFoundationType): (WebKit::CoreIPCDDScannerResult::CoreIPCDDScannerResult): * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h: (IPC::decodeRequiringAllowedClasses): (IPC::ArgumentCoderhttps://commits.webkit.org/274933@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e1cab3: Generate serialization of NSURLCredential
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e1cab360c28ad35642b685bd17a9d3db6a052121 https://github.com/WebKit/WebKit/commit/e1cab360c28ad35642b685bd17a9d3db6a052121 Author: Alex Christensen Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm A Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.h A Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.mm A Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.serialization.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm Log Message: --- Generate serialization of NSURLCredential https://bugs.webkit.org/show_bug.cgi?id=269651 Reviewed by Pascoe. There's still work to be done to expose exactly what this dictionary should look like in SerializedTypeInfo.mm somehow, but at least we're not using SecureCoding any more. This is a baby step in the right direction. This works on all platforms except macOS Monterey, which doesn't use _enableStrictSecureDecodingMode for all types anyways, so on Monterey only, just use NSKeyedUnarchiver. Monterey also doesn't have the ability to serialize NSURLCredentials with identities in them. The Monterey code will be removed soon. * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::encodeObjectDirectly>): (IPC::shouldEnableStrictMode): * Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.h: Added. (WebKit::CoreIPCNSURLCredential::CoreIPCNSURLCredential): * Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.mm: Added. (WebKit::CoreIPCNSURLCredential::CoreIPCNSURLCredential): (WebKit::CoreIPCNSURLCredential::toID const): * Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.serialization.in: Added. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm: (NSURLCredentialTesting_isEqual): (operator==): (TEST): Canonical link: https://commits.webkit.org/275132@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b99b4d: FocusController::focusedOrMainFrame should return ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b99b4d6f85701aeb323b540fb5eaef0d891a564a https://github.com/WebKit/WebKit/commit/b99b4d6f85701aeb323b540fb5eaef0d891a564a Author: Alex Christensen Date: 2024-02-22 (Thu, 22 Feb 2024) Changed paths: M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/dom/Element.cpp M Source/WebCore/editing/FrameSelection.cpp M Source/WebCore/editing/VisibleSelection.cpp M Source/WebCore/editing/VisibleSelection.h M Source/WebCore/editing/cocoa/DictionaryLookup.mm M Source/WebCore/history/CachedPage.cpp M Source/WebCore/html/BaseDateAndTimeInputType.cpp M Source/WebCore/inspector/InspectorFrontendHost.cpp M Source/WebCore/page/DragController.cpp M Source/WebCore/page/EventHandler.cpp M Source/WebCore/page/FocusController.cpp M Source/WebCore/page/FocusController.h M Source/WebCore/page/LocalDOMWindow.cpp M Source/WebCore/page/Page.cpp M Source/WebCore/page/ios/EventHandlerIOS.mm M Source/WebCore/page/mac/EventHandlerMac.mm M Source/WebCore/page/mac/ServicesOverlayController.mm M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp M Source/WebKit/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm M Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.cpp M Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm M Source/WebKitLegacy/mac/Misc/WebSharingServicePickerController.mm M Source/WebKitLegacy/mac/WebView/WebView.mm Log Message: --- FocusController::focusedOrMainFrame should return a LocalFrame* https://bugs.webkit.org/show_bug.cgi?id=269761 rdar://116201648 Reviewed by Chris Dumez. With site isolation, the main frame is not always a LocalFrame. Instead of returning a random root frame, correctly return null. This requires null checks for all callers. This should fix rdar://121960445 too. In order to make it so that the layout test security/clip-invalid-rect.html does not crash because of an invalid IPC message WebPageProxy::EditorStateChanged, I made it so that WebPage::editorState always returns an EditorState with a valid identifier. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::focusedObjectForPage): * Source/WebCore/dom/Element.cpp: (WebCore::Element::focus): (WebCore::Element::blur): * Source/WebCore/editing/FrameSelection.cpp: (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected): (WebCore::FrameSelection::setFocusedElementIfNeeded): * Source/WebCore/editing/VisibleSelection.cpp: (WebCore::VisibleSelection::emptySelection): * Source/WebCore/editing/VisibleSelection.h: * Source/WebCore/editing/cocoa/DictionaryLookup.mm: (WebCore::DictionaryLookup::rangeAtHitTestResult): * Source/WebCore/history/CachedPage.cpp: (WebCore::CachedPage::restore): * Source/WebCore/html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::handleFocusEvent): * Source/WebCore/inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::killText): * Source/WebCore/page/DragController.cpp: (WebCore::DragController::performDragOperation): * Source/WebCore/page/EventHandler.cpp: (WebCore::EventHandler::handlePasteGlobalSelection): (WebCore::EventHandler::dispatchMouseEvent): (WebCore::EventHandler::internalKeyEvent): (WebCore::EventHandler::defaultArrowEventHandler): (WebCore::EventHandler::defaultTabEventHandler): (WebCore::EventHandler::focusDocumentView): * Source/WebCore/page/FocusController.cpp: (WebCore::FocusController::focusedOrMainFrame const): (WebCore::FocusController::setFocusedInternal): (WebCore::FocusController::setInitialFocus): (WebCore::FocusController::relinquishFocusToChrome): (WebCore::FocusController::advanceFocusInDocumentOrder): (WebCore::FocusController::setActiveInternal): (WebCore::FocusController::advanceFocusDirectionallyInContainer): (WebCore::FocusController::advanceFocusDirectionally): (WebCore::FocusController::focusRepaintTimerFired): * Source/WebCore/page/FocusController.h: * Source/WebCore/page/LocalDOMWindow.cpp: (WebCore::LocalDOMWindow::focus): * Source/WebCore/page/Page.cpp: (WebCore::Page::replaceSelectionWithText): (WebCore::Page::editableElementsInRect const): (WebCore::Page::selection const): (WebCore::Page::fragmentDirectiveURLForSelectedText): (WebCore::Page::revealCurrentSelection): * Source/WebCore/page/ios/EventHandlerIOS.mm: (WebCore::EventHandler::focusDocumentView): * Source/WebCore/page/mac/EventHandlerMac.mm: (WebCore::EventHandler
[webkit-changes] [WebKit/WebKit] 4098a1: TypeChecker::visit should set zeroValue for arrays...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4098a18a57d8b50fa8970688171dba7bd6ef71d7 https://github.com/WebKit/WebKit/commit/4098a18a57d8b50fa8970688171dba7bd6ef71d7 Author: Alex Christensen Date: 2024-02-29 (Thu, 29 Feb 2024) Changed paths: A LayoutTests/fast/webgpu/type-checker-array-without-argument-expected.txt A LayoutTests/fast/webgpu/type-checker-array-without-argument.html M Source/WebGPU/WGSL/TypeCheck.cpp Log Message: --- TypeChecker::visit should set zeroValue for arrays without arguments https://bugs.webkit.org/show_bug.cgi?id=270230 rdar://123745652 Reviewed by Tadeu Zagallo. This matches what we do with ConstantStruct. * LayoutTests/fast/webgpu/type-checker-array-bounds-expected.txt: Added. * LayoutTests/fast/webgpu/type-checker-array-bounds.html: Added. * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): Canonical link: https://commits.webkit.org/275534@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ec0105: [WebGPU] Forbid bottom types as struct members
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec01055eeeba8b823b13cd7badff17a2c3366e27 https://github.com/WebKit/WebKit/commit/ec01055eeeba8b823b13cd7badff17a2c3366e27 Author: Alex Christensen Date: 2024-02-29 (Thu, 29 Feb 2024) Changed paths: A LayoutTests/fast/webgpu/forbid-bottom-struct-member-expected.txt A LayoutTests/fast/webgpu/forbid-bottom-struct-member.html M Source/WebGPU/WGSL/TypeCheck.cpp Log Message: --- [WebGPU] Forbid bottom types as struct members https://bugs.webkit.org/show_bug.cgi?id=270266 rdar://123745671 Reviewed by Dan Glastonbury. * LayoutTests/fast/webgpu/forbid-bottom-struct-member-expected.txt: Added. * LayoutTests/fast/webgpu/forbid-bottom-struct-member.html: Added. * Source/WebGPU/WGSL/ConstantFunctions.h: (WGSL::zeroValue): * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::convertValueImpl): Canonical link: https://commits.webkit.org/275535@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fcdb5d: [WebGPU] Fix RenderPipeline color format validation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fcdb5d4b016f49f0fc3c205f8cb37b7269e55312 https://github.com/WebKit/WebKit/commit/fcdb5d4b016f49f0fc3c205f8cb37b7269e55312 Author: Alex Christensen Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/render-bundle-validation-color-format-expected.txt A LayoutTests/fast/webgpu/render-bundle-validation-color-format.html M Source/WebGPU/WebGPU/RenderPipeline.mm Log Message: --- [WebGPU] Fix RenderPipeline color format validation https://bugs.webkit.org/show_bug.cgi?id=270333 rdar://123810621 Reviewed by Mike Wyrzykowski. If fragment.targetCount is not equal to descriptor.colorFormatCount then we want to verify that all color formats are undefined. Otherwise, we want to verify that they are all equal to the descriptor color formats. * LayoutTests/fast/webgpu/render-bundle-validation-color-format-expected.txt: Added. * LayoutTests/fast/webgpu/render-bundle-validation-color-format.html: Added. * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::RenderPipeline::validateRenderBundle const): Canonical link: https://commits.webkit.org/275550@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 499319: Clean up site isolation process selection logic
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4993196dda0c8b38391058300b282bc802a4ffd2 https://github.com/WebKit/WebKit/commit/4993196dda0c8b38391058300b282bc802a4ffd2 Author: Alex Christensen Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/Sources.txt M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h M Source/WebKit/UIProcess/BrowsingContextGroup.cpp M Source/WebKit/UIProcess/BrowsingContextGroup.h A Source/WebKit/UIProcess/FrameProcess.cpp A Source/WebKit/UIProcess/FrameProcess.h M Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp M Source/WebKit/UIProcess/ProvisionalFrameProxy.h M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.h M Source/WebKit/UIProcess/RemotePageProxy.cpp M Source/WebKit/UIProcess/RemotePageProxy.h R Source/WebKit/UIProcess/RemotePageProxyState.h M Source/WebKit/UIProcess/SuspendedPageProxy.cpp M Source/WebKit/UIProcess/SuspendedPageProxy.h M Source/WebKit/UIProcess/WebFrameProxy.cpp M Source/WebKit/UIProcess/WebFrameProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxyInternals.h M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- Clean up site isolation process selection logic https://bugs.webkit.org/show_bug.cgi?id=270045 rdar://116202371 Reviewed by Charlie Wolfe. This pulls the process selection and RemotePageProxy management logic from various places into BrowsingContextGroup. I introduce a new abstraction, FrameProcess, that represents a frame's use of a particular process. The WebFrameProxy retains a reference to a FrameProcess instead of a RemotePageProxy. When a FrameProcess is created or destroyed, the BrowsingContextGroup updates the containers of RemotePageProxy objects. This change allows us to keep track of opened pages using structures that are more elegant and robust to handle all possible combinations of window.open and iframe creation or destruction. Two small changes are observable in site isolation API tests, but they are both progressions because of processes and frames being managed more correctly in some cases. * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::allowsFirstPartyForCookies): * Source/WebKit/Shared/AuxiliaryProcess.cpp: (WebKit::AuxiliaryProcess::allowsFirstPartyForCookies): * Source/WebKit/Sources.txt: * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: * Source/WebKit/UIProcess/BrowsingContextGroup.cpp: (WebKit::BrowsingContextGroup::ensureProcessForDomain): (WebKit::BrowsingContextGroup::processForDomain): (WebKit::BrowsingContextGroup::addFrameProcess): (WebKit::BrowsingContextGroup::removeFrameProcess): (WebKit::BrowsingContextGroup::addPage): (WebKit::BrowsingContextGroup::removePage): (WebKit::BrowsingContextGroup::forEachRemotePage): (WebKit::BrowsingContextGroup::remotePageInProcess): (WebKit::BrowsingContextGroup::takeRemotePageInProcessForProvisionalPage): (WebKit::BrowsingContextGroup::transitionPageToRemotePage): (WebKit::BrowsingContextGroup::addProcessForDomain): Deleted. * Source/WebKit/UIProcess/BrowsingContextGroup.h: * Source/WebKit/UIProcess/FrameProcess.cpp: Renamed from Source/WebKit/UIProcess/RemotePageProxyState.h. (WebKit::FrameProcess::FrameProcess): (WebKit::FrameProcess::~FrameProcess): * Source/WebKit/UIProcess/FrameProcess.h: Copied from Source/WebKit/UIProcess/BrowsingContextGroup.h. (WebKit::FrameProcess::domain const): (WebKit::FrameProcess::process const): (WebKit::FrameProcess::process): (WebKit::FrameProcess::create): * Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp: (WebKit::ProvisionalFrameProxy::ProvisionalFrameProxy): (WebKit::ProvisionalFrameProxy::takeFrameProcess): (WebKit::ProvisionalFrameProxy::process const): (WebKit::ProvisionalFrameProxy::takeRemotePageProxy): Deleted. * Source/WebKit/UIProcess/ProvisionalFrameProxy.h: (WebKit::ProvisionalFrameProxy::process const): Deleted. * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::ProvisionalPageProxy): (WebKit::ProvisionalPageProxy::~ProvisionalPageProxy): (WebKit::ProvisionalPageProxy::process): (WebKit::ProvisionalPageProxy::setNavigation): (WebKit::ProvisionalPageProxy::cancel): (WebKit::ProvisionalPageProxy::initializeWebPage): (WebKit::ProvisionalPageProxy::loadData): (WebKit::ProvisionalPageProxy::loadRequest): (WebKit::ProvisionalPageProxy::goToBackForwardItem): (WebKit::ProvisionalPageProxy::didCreateMainFrame): (WebKit::ProvisionalPageProxy::didPerformClientRedirect): (WebKit::ProvisionalPageProxy::didStartProvisionalLoadForFrame): (WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame): (W
[webkit-changes] [WebKit/WebKit] 4f76c5: Use WeakPtr for members of GPUDeviceVideoFrameRequ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4f76c56c5655b26ed84f9f1b1d03a59c87e74885 https://github.com/WebKit/WebKit/commit/4f76c56c5655b26ed84f9f1b1d03a59c87e74885 Author: Alex Christensen Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/Modules/WebGPU/GPUDevice.cpp M Source/WebCore/Modules/WebGPU/GPUDevice.h Log Message: --- Use WeakPtr for members of GPUDeviceVideoFrameRequestCallback https://bugs.webkit.org/show_bug.cgi?id=270362 rdar://123908079 Reviewed by Mike Wyrzykowski. This makes it more robust against lifetime issues. * Source/WebCore/Modules/WebGPU/GPUDevice.cpp: * Source/WebCore/Modules/WebGPU/GPUDevice.h: Canonical link: https://commits.webkit.org/275567@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 56f214: [WebGPU] Remove duplicate typeError when a bottom ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 56f2145d88f7f995e572dc334dbeb43a56969951 https://github.com/WebKit/WebKit/commit/56f2145d88f7f995e572dc334dbeb43a56969951 Author: Alex Christensen Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebGPU/WGSL/TypeCheck.cpp Log Message: --- [WebGPU] Remove duplicate typeError when a bottom type is a member of a struct https://bugs.webkit.org/show_bug.cgi?id=270350 rdar://123898425 Reviewed by Tadeu Zagallo. An error was already generated when the bottom type was inferred * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): Canonical link: https://commits.webkit.org/275568@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 85712d: PresentationContextIOSurface::present should do no...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 85712d7f2f1965e3772b2173bcb1fba6e99e7a46 https://github.com/WebKit/WebKit/commit/85712d7f2f1965e3772b2173bcb1fba6e99e7a46 Author: Alex Christensen Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/present-without-compute-pipeline-expected.txt A LayoutTests/fast/webgpu/present-without-compute-pipeline.html M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm Log Message: --- PresentationContextIOSurface::present should do nothing if there is no compute pipeline state https://bugs.webkit.org/show_bug.cgi?id=270367 rdar://123912101 Reviewed by Mike Wyrzykowski. There is nothing to do if there is no compute pipeline, but we don't want to dereference null. * LayoutTests/fast/webgpu/present-without-compute-pipeline-expected.txt: Added. * LayoutTests/fast/webgpu/present-without-compute-pipeline.html: Added. * Source/WebGPU/WebGPU/PresentationContextIOSurface.mm: Canonical link: https://commits.webkit.org/275582@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 43475b: Add test using loadHTMLString with site isolation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 43475b58f7c91962c5dad360a4b12076054461d1 https://github.com/WebKit/WebKit/commit/43475b58f7c91962c5dad360a4b12076054461d1 Author: Alex Christensen Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- Add test using loadHTMLString with site isolation https://bugs.webkit.org/show_bug.cgi?id=270372 rdar://123914567 Reviewed by Charlie Wolfe. * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/275583@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 067f08: Use smart pointers in Modules/WebGPU
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 067f08a43f10286e6d769a0b31847652244fbead https://github.com/WebKit/WebKit/commit/067f08a43f10286e6d769a0b31847652244fbead Author: Alex Christensen Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/Modules/WebGPU/GPUBindGroupDescriptor.h M Source/WebCore/Modules/WebGPU/GPUBindGroupLayout.h M Source/WebCore/Modules/WebGPU/GPUBuffer.cpp M Source/WebCore/Modules/WebGPU/GPUBuffer.h M Source/WebCore/Modules/WebGPU/GPUBufferBinding.h M Source/WebCore/Modules/WebGPU/GPUCanvasConfiguration.h M Source/WebCore/Modules/WebGPU/GPUComputePassTimestampWrites.h M Source/WebCore/Modules/WebGPU/GPUImageCopyBuffer.h M Source/WebCore/Modules/WebGPU/GPUImageCopyTexture.h M Source/WebCore/Modules/WebGPU/GPUPresentationContext.cpp M Source/WebCore/Modules/WebGPU/GPUProgrammableStage.h M Source/WebCore/Modules/WebGPU/GPUQuerySet.h M Source/WebCore/Modules/WebGPU/GPURenderPassColorAttachment.h M Source/WebCore/Modules/WebGPU/GPURenderPassDepthStencilAttachment.h M Source/WebCore/Modules/WebGPU/GPURenderPassDescriptor.h M Source/WebCore/Modules/WebGPU/GPURenderPassTimestampWrites.h M Source/WebCore/Modules/WebGPU/GPUShaderModule.h M Source/WebCore/Modules/WebGPU/GPUTexture.h M Source/WebCore/Modules/WebGPU/GPUTextureView.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBindGroupDescriptor.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBindGroupLayout.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBuffer.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBufferBinding.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUCanvasConfiguration.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUComputePassTimestampWrites.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUDevice.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUImageCopyBuffer.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUImageCopyTexture.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPipelineDescriptorBase.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPipelineLayout.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUProgrammableStage.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUQuerySet.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassColorAttachment.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassDepthStencilAttachment.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassDescriptor.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassTimestampWrites.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUShaderModule.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUTexture.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUTextureView.h M Source/WebKit/Shared/WebGPU/WebGPUBindGroupDescriptor.cpp M Source/WebKit/Shared/WebGPU/WebGPUBufferBinding.cpp M Source/WebKit/Shared/WebGPU/WebGPUCanvasConfiguration.cpp M Source/WebKit/Shared/WebGPU/WebGPUComputePassTimestampWrites.cpp M Source/WebKit/Shared/WebGPU/WebGPUImageCopyBuffer.cpp M Source/WebKit/Shared/WebGPU/WebGPUImageCopyTexture.cpp M Source/WebKit/Shared/WebGPU/WebGPUPipelineDescriptorBase.cpp M Source/WebKit/Shared/WebGPU/WebGPUProgrammableStage.cpp M Source/WebKit/Shared/WebGPU/WebGPURenderPassColorAttachment.cpp M Source/WebKit/Shared/WebGPU/WebGPURenderPassTimestampWrites.cpp Log Message: --- Use smart pointers in Modules/WebGPU https://bugs.webkit.org/show_bug.cgi?id=270378 rdar://123810573 Reviewed by Mike Wyrzykowski. * Source/WebCore/Modules/WebGPU/GPUBindGroupDescriptor.h: (): Deleted. * Source/WebCore/Modules/WebGPU/GPUBindGroupLayout.h: * Source/WebCore/Modules/WebGPU/GPUBuffer.cpp: (WebCore::makeArrayBuffer): (WebCore::GPUBuffer::unmap): * Source/WebCore/Modules/WebGPU/GPUBuffer.h: * Source/WebCore/Modules/WebGPU/GPUBufferBinding.h: * Source/WebCore/Modules/WebGPU/GPUCanvasConfiguration.h: * Source/WebCore/Modules/WebGPU/GPUComputePassTimestampWrites.h: * Source/WebCore/Modules/WebGPU/GPUImageCopyBuffer.h: (): Deleted. * Source/WebCore/Modules/WebGPU/GPUImageCopyTexture.h: * Source/WebCore/Modules/WebGPU/GPUPresentationContext.cpp: (WebCore::GPUPresentationContext::configure): * Source/WebCore/Modules/WebGPU/GPUProgrammableStage.h: (): Deleted. * Source/WebCore/Modules/WebGPU/GPUQuerySet.h: * Source/WebCore/Modules/WebGPU/GPURenderPassColorAttachment.h: * Source/WebCore/Modules/WebGPU/GPURenderPassDepthStencilAttachment.h: * Source/WebCore/Modules/WebGPU/GPURenderPassDescriptor.h: (): Deleted. * Source/WebCore/Modules/WebGPU/GPURenderPassTimestampWrites.h: * Source/WebCore/Modules/WebGPU/GPUShaderModule.h: * Source/WebCore/Modules/WebGPU/GPUTexture.h: * Source/WebCore/Modules/WebGPU/GPUTextureView.h: * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUComputePassTimestampWrites.h: * Source/WebCore
[webkit-changes] [WebKit/WebKit] fd156d: Clean up site isolation process selection logic, t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fd156dff97eb3b90c5ffb095d3b0b61b6efe20a1 https://github.com/WebKit/WebKit/commit/fd156dff97eb3b90c5ffb095d3b0b61b6efe20a1 Author: Alex Christensen Date: 2024-03-02 (Sat, 02 Mar 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations M Source/WebKit/Sources.txt M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h M Source/WebKit/UIProcess/BrowsingContextGroup.cpp M Source/WebKit/UIProcess/BrowsingContextGroup.h A Source/WebKit/UIProcess/FrameProcess.cpp A Source/WebKit/UIProcess/FrameProcess.h M Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp M Source/WebKit/UIProcess/ProvisionalFrameProxy.h M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.h M Source/WebKit/UIProcess/RemotePageProxy.cpp M Source/WebKit/UIProcess/RemotePageProxy.h R Source/WebKit/UIProcess/RemotePageProxyState.h M Source/WebKit/UIProcess/SuspendedPageProxy.cpp M Source/WebKit/UIProcess/SuspendedPageProxy.h M Source/WebKit/UIProcess/WebFrameProxy.cpp M Source/WebKit/UIProcess/WebFrameProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxyInternals.h M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- Clean up site isolation process selection logic, take 2 https://bugs.webkit.org/show_bug.cgi?id=270390 rdar://123936252 Reviewed by Charlie Wolfe. This re-lands 275551@main but with two important changes: 1. I retain the preferences().siteIsolationEnabled() check when finding processNavigatingFrom to make it so there is no change in behavior with site isolation off. I verified this fixes the three API tests that were broken by 275551@main. 2. I skip some site isolation layout tests that start timing out or asserting because the logic isn't quite right when opening a new page but severing the opener relationship with something like an anchor tag with target=_blank. This will be fixed in a future PR. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Source/WebKit/Sources.txt: * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: * Source/WebKit/UIProcess/BrowsingContextGroup.cpp: (WebKit::BrowsingContextGroup::ensureProcessForDomain): (WebKit::BrowsingContextGroup::processForDomain): (WebKit::BrowsingContextGroup::addFrameProcess): (WebKit::BrowsingContextGroup::removeFrameProcess): (WebKit::BrowsingContextGroup::addPage): (WebKit::BrowsingContextGroup::removePage): (WebKit::BrowsingContextGroup::forEachRemotePage): (WebKit::BrowsingContextGroup::remotePageInProcess): (WebKit::BrowsingContextGroup::takeRemotePageInProcessForProvisionalPage): (WebKit::BrowsingContextGroup::transitionPageToRemotePage): (WebKit::BrowsingContextGroup::addProcessForDomain): Deleted. * Source/WebKit/UIProcess/BrowsingContextGroup.h: * Source/WebKit/UIProcess/FrameProcess.cpp: Renamed from Source/WebKit/UIProcess/RemotePageProxyState.h. (WebKit::FrameProcess::FrameProcess): (WebKit::FrameProcess::~FrameProcess): * Source/WebKit/UIProcess/FrameProcess.h: Copied from Source/WebKit/UIProcess/BrowsingContextGroup.h. (WebKit::FrameProcess::domain const): (WebKit::FrameProcess::process const): (WebKit::FrameProcess::process): (WebKit::FrameProcess::create): * Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp: (WebKit::ProvisionalFrameProxy::ProvisionalFrameProxy): (WebKit::ProvisionalFrameProxy::takeFrameProcess): (WebKit::ProvisionalFrameProxy::process const): (WebKit::ProvisionalFrameProxy::takeRemotePageProxy): Deleted. * Source/WebKit/UIProcess/ProvisionalFrameProxy.h: (WebKit::ProvisionalFrameProxy::process const): Deleted. * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::ProvisionalPageProxy): (WebKit::ProvisionalPageProxy::~ProvisionalPageProxy): (WebKit::ProvisionalPageProxy::process): (WebKit::ProvisionalPageProxy::protectedProcess): (WebKit::ProvisionalPageProxy::setNavigation): (WebKit::ProvisionalPageProxy::cancel): (WebKit::ProvisionalPageProxy::initializeWebPage): (WebKit::ProvisionalPageProxy::loadData): (WebKit::ProvisionalPageProxy::loadRequest): (WebKit::ProvisionalPageProxy::goToBackForwardItem): (WebKit::ProvisionalPageProxy::didCreateMainFrame): (WebKit::ProvisionalPageProxy::didPerformClientRedirect): (WebKit::ProvisionalPageProxy::didStartProvisionalLoadForFrame): (WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame): (WebKit::ProvisionalPageProxy::didCommitLoadForFrame): (WebKit::ProvisionalPageProxy::didNavigateWithNavigationData): (WebKit::ProvisionalPageProxy::didChangeProvisionalURLForFrame): (WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionAsync): (W
[webkit-changes] [WebKit/WebKit] 6dae67: [WebGPU] Fix bounds check with offset in Queue::wr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6dae676c4f80b3c0fab306f0a7aed956dbd57d6a https://github.com/WebKit/WebKit/commit/6dae676c4f80b3c0fab306f0a7aed956dbd57d6a Author: Alex Christensen Date: 2024-03-02 (Sat, 02 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/queue-write-texture-offset-expected.txt A LayoutTests/fast/webgpu/queue-write-texture-offset.html M Source/WebGPU/WebGPU/Queue.mm Log Message: --- [WebGPU] Fix bounds check with offset in Queue::writeTexture https://bugs.webkit.org/show_bug.cgi?id=270400 rdar://123810754 Reviewed by Mike Wyrzykowski. * LayoutTests/fast/webgpu/queue-write-texture-offset-expected.txt: Added. * LayoutTests/fast/webgpu/queue-write-texture-offset.html: Added. * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::writeTexture): Canonical link: https://commits.webkit.org/275593@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da4ede: VideoSourceIdentifier should contain std::optional...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da4ede4b4b39958909e39b0e8bc6b34be16a7178 https://github.com/WebKit/WebKit/commit/da4ede4b4b39958909e39b0e8bc6b34be16a7178 Author: Alex Christensen Date: 2024-03-02 (Sat, 02 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/optional-media-identifier-expected.txt A LayoutTests/fast/webgpu/optional-media-identifier.html M Source/WebCore/Modules/WebGPU/GPUExternalTextureDescriptor.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUExternalTextureDescriptor.h M Source/WebCore/platform/VideoPixelFormat.cpp M Source/WebKit/Shared/WebGPU/WebGPUExternalTextureDescriptor.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp Log Message: --- VideoSourceIdentifier should contain std::optional https://bugs.webkit.org/show_bug.cgi?id=270397 rdar://123810898 Reviewed by Mike Wyrzykowski. Otherwise in RemoteDeviceProxy::importExternalTexture we send a non-nullopt identifier with a value of 0 when what we wanted was to send nullopt. Identifiers with a value of 0 fail to decode on the receiving side. Also fix a few small issues: removed an invalid debug assertion, and call some completion handlers in error cases. * LayoutTests/fast/webgpu/optional-media-identifier-expected.txt: Added. * LayoutTests/fast/webgpu/optional-media-identifier.html: Added. * Source/WebCore/Modules/WebGPU/GPUExternalTextureDescriptor.h: (WebCore::GPUExternalTextureDescriptor::mediaIdentifierForSource): * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUExternalTextureDescriptor.h: * Source/WebCore/platform/VideoPixelFormat.cpp: (WebCore::convertVideoFramePixelFormat): * Source/WebKit/Shared/WebGPU/WebGPUExternalTextureDescriptor.cpp: (WebKit::WebGPU::ConvertToBackingContext::convertToBacking): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp: (WebKit::WebGPU::RemoteAdapterProxy::requestDevice): Canonical link: https://commits.webkit.org/275594@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da059d: Give fast/webgpu/present-without-compute-pipeline....
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da059d5a3fefdbe6e69ef20eb8123bc868712dfd https://github.com/WebKit/WebKit/commit/da059d5a3fefdbe6e69ef20eb8123bc868712dfd Author: Alex Christensen Date: 2024-03-02 (Sat, 02 Mar 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/wincairo/TestExpectations Log Message: --- Give fast/webgpu/present-without-compute-pipeline.html extra time to run in debug builds https://bugs.webkit.org/show_bug.cgi?id=270403 rdar://123957005 Unreviewed. It timed out in a debug build. Mark it as slow. It's 5k lines of code. Also, it always times out on Windows. Skip it entirely there like we do all the webgpu tests. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/275595@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 981990: Add WeakPtr check in GPUDevice::importExternalTexture
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 98199059b940dd5c33741b7aafd26f118a496527 https://github.com/WebKit/WebKit/commit/98199059b940dd5c33741b7aafd26f118a496527 Author: Alex Christensen Date: 2024-03-04 (Mon, 04 Mar 2024) Changed paths: M Source/WebCore/Modules/WebGPU/GPUDevice.cpp Log Message: --- Add WeakPtr check in GPUDevice::importExternalTexture https://bugs.webkit.org/show_bug.cgi?id=270482 rdar://124031745 Reviewed by Mike Wyrzykowski. * Source/WebCore/Modules/WebGPU/GPUDevice.cpp: Canonical link: https://commits.webkit.org/275661@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0ade44: Check Texture::supportsBlending in addition to has...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ade4480b548839fd84b43494f5d1eef8ce47792 https://github.com/WebKit/WebKit/commit/0ade4480b548839fd84b43494f5d1eef8ce47792 Author: Alex Christensen Date: 2024-03-04 (Mon, 04 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/texture-supports-blending-expected.txt A LayoutTests/fast/webgpu/texture-supports-blending.html M Source/WebGPU/WebGPU/RenderPipeline.mm Log Message: --- Check Texture::supportsBlending in addition to hasAlphaChannel https://bugs.webkit.org/show_bug.cgi?id=270484 rdar://123811134 Reviewed by Mike Wyrzykowski. This is being discussed in https://github.com/gpuweb/gpuweb/issues/4506 We don't want to crash when using Metal. * LayoutTests/fast/webgpu/texture-supports-blending-expected.txt: Added. * LayoutTests/fast/webgpu/texture-supports-blending.html: Added. * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::Device::createRenderPipeline): (WebGPU::hasAlphaChannel): Deleted. Canonical link: https://commits.webkit.org/275662@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d48aa4: Use smart pointer in HTMLVideoElementPictureInPicture
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d48aa4d06a551f682a0cdceb0382c17e1dd805a7 https://github.com/WebKit/WebKit/commit/d48aa4d06a551f682a0cdceb0382c17e1dd805a7 Author: Alex Christensen Date: 2024-03-04 (Mon, 04 Mar 2024) Changed paths: M Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp M Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.h Log Message: --- Use smart pointer in HTMLVideoElementPictureInPicture https://bugs.webkit.org/show_bug.cgi?id=270381 rdar://123922744 Reviewed by Eric Carlson. * Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp: (WebCore::HTMLVideoElementPictureInPicture::HTMLVideoElementPictureInPicture): (WebCore::HTMLVideoElementPictureInPicture::~HTMLVideoElementPictureInPicture): (WebCore::HTMLVideoElementPictureInPicture::exitPictureInPicture): (WebCore::HTMLVideoElementPictureInPicture::didEnterPictureInPicture): (WebCore::HTMLVideoElementPictureInPicture::didExitPictureInPicture): * Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.h: Canonical link: https://commits.webkit.org/275663@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 561208: [WebGPU] getBindGroupLayout should return a non-nu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 561208853674e4014dff6180ec6e96e098110514 https://github.com/WebKit/WebKit/commit/561208853674e4014dff6180ec6e96e098110514 Author: Alex Christensen Date: 2024-03-04 (Mon, 04 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/bind-group-layout-invalid-expected.txt A LayoutTests/fast/webgpu/bind-group-layout-invalid.html M Source/WebGPU/WebGPU/ComputePipeline.h M Source/WebGPU/WebGPU/ComputePipeline.mm M Source/WebGPU/WebGPU/RenderPipeline.h M Source/WebGPU/WebGPU/RenderPipeline.mm Log Message: --- [WebGPU] getBindGroupLayout should return a non-null possibly-invalid layout https://bugs.webkit.org/show_bug.cgi?id=270469 rdar://123810931 Reviewed by Mike Wyrzykowski. * LayoutTests/fast/webgpu/bind-group-layout-invalid-expected.txt: Added. * LayoutTests/fast/webgpu/bind-group-layout-invalid.html: Added. * Source/WebGPU/WebGPU/ComputePipeline.h: * Source/WebGPU/WebGPU/ComputePipeline.mm: (WebGPU::ComputePipeline::getBindGroupLayout): * Source/WebGPU/WebGPU/RenderPipeline.h: * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::RenderPipeline::getBindGroupLayout): Canonical link: https://commits.webkit.org/275664@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ed9a48: imageBytesForSource should only copy the required ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ed9a48d72012671cf9e92c59f443855d48ea55e1 https://github.com/WebKit/WebKit/commit/ed9a48d72012671cf9e92c59f443855d48ea55e1 Author: Alex Christensen Date: 2024-03-04 (Mon, 04 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/image-data-8-bytes-per-pixel-expected.txt A LayoutTests/fast/webgpu/image-data-8-bytes-per-pixel.html M Source/WebCore/Modules/WebGPU/GPUQueue.cpp Log Message: --- imageBytesForSource should only copy the required bytes for images with more than 4 bytes per pixel https://bugs.webkit.org/show_bug.cgi?id=270493 rdar://123810952 Reviewed by Mike Wyrzykowski. Also use early returns to remove deeply nested if statements. Also use smart pointers to retain and release images while using them. * LayoutTests/fast/webgpu/image-data-8-bytes-per-pixel-expected.txt: Added. * LayoutTests/fast/webgpu/image-data-8-bytes-per-pixel.html: Added. * Source/WebCore/Modules/WebGPU/GPUQueue.cpp: (WebCore::imageBytesForSource): Canonical link: https://commits.webkit.org/275671@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4e0d0a: Conversion from rgba to rg8unorm should copy corre...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4e0d0a195db543549fc827e2252061de45c22016 https://github.com/WebKit/WebKit/commit/4e0d0a195db543549fc827e2252061de45c22016 Author: Alex Christensen Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/conversion-to-rg8unorm-expected.txt A LayoutTests/fast/webgpu/conversion-to-rg8unorm.html M Source/WebCore/Modules/WebGPU/GPUQueue.cpp Log Message: --- Conversion from rgba to rg8unorm should copy correct pixel values https://bugs.webkit.org/show_bug.cgi?id=270558 rdar://123810638 Reviewed by Mike Wyrzykowski. * LayoutTests/fast/webgpu/conversion-to-rg8unorm-expected.txt: Added. * LayoutTests/fast/webgpu/conversion-to-rg8unorm.html: Added. * Source/WebCore/Modules/WebGPU/GPUQueue.cpp: (WebCore::copyToDestinationFormat): Canonical link: https://commits.webkit.org/275738@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7fed86: Fix bounds check in Queue::writeBuffer when buffer...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7fed8609a81438d9ae188d1b83db749dba59236d https://github.com/WebKit/WebKit/commit/7fed8609a81438d9ae188d1b83db749dba59236d Author: Alex Christensen Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/write-to-destroyed-buffer-expected.txt A LayoutTests/fast/webgpu/write-to-destroyed-buffer.html M Source/WebGPU/WebGPU/BindGroup.mm M Source/WebGPU/WebGPU/Buffer.h M Source/WebGPU/WebGPU/Buffer.mm M Source/WebGPU/WebGPU/CommandEncoder.mm M Source/WebGPU/WebGPU/CommandsMixin.mm M Source/WebGPU/WebGPU/ComputePassEncoder.mm M Source/WebGPU/WebGPU/Queue.mm M Source/WebGPU/WebGPU/RenderBundleEncoder.mm M Source/WebGPU/WebGPU/RenderPassEncoder.mm Log Message: --- Fix bounds check in Queue::writeBuffer when buffer has been destroyed https://bugs.webkit.org/show_bug.cgi?id=270538 rdar://123811082 Reviewed by Mike Wyrzykowski. Buffer::destroy updates m_buffer but didn't update m_size, and it shouldn't update the size as seen by the JS API. Instead of updating it, I derive the size from m_buffer and replace size() with currentSize() and initialSize() I also add a null check to avoid writing to a buffer that is null. * LayoutTests/fast/webgpu/write-to-destroyed-buffer-expected.txt: Added. * LayoutTests/fast/webgpu/write-to-destroyed-buffer.html: Added. * Source/WebGPU/WebGPU/Buffer.h: (WebGPU::Buffer::create): * Source/WebGPU/WebGPU/Buffer.mm: (WebGPU::Device::createBuffer): (WebGPU::Buffer::Buffer): (WebGPU::Buffer::getMappedRange): (WebGPU::Buffer::errorValidatingMapAsync const): (WebGPU::Buffer::mapAsync): (WebGPU::Buffer::size const): * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::validateWriteBuffer const): Canonical link: https://commits.webkit.org/275756@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5cbab2: Queue::commandBufferWithDescriptor needs to null c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5cbab24ef4f3b2808ca46748bf6c34f3306dca7e https://github.com/WebKit/WebKit/commit/5cbab24ef4f3b2808ca46748bf6c34f3306dca7e Author: Alex Christensen Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/command-buffer-after-destruction-expected.txt A LayoutTests/fast/webgpu/command-buffer-after-destruction.html M Source/WebGPU/WebGPU/Queue.mm Log Message: --- Queue::commandBufferWithDescriptor needs to null check buffer before adding to NSMutableOrderedSet https://bugs.webkit.org/show_bug.cgi?id=270597 rdar://124143184 Reviewed by Mike Wyrzykowski. * LayoutTests/fast/webgpu/command-buffer-after-destruction-expected.txt: Added. * LayoutTests/fast/webgpu/command-buffer-after-destruction.html: Added. * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::commandBufferWithDescriptor): Canonical link: https://commits.webkit.org/275761@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 88b3ec: Null check buffer in GPUCanvasContextCocoa::drawBu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 88b3ecbe50b9c2b2fb330ede40e092d730a8a365 https://github.com/WebKit/WebKit/commit/88b3ecbe50b9c2b2fb330ede40e092d730a8a365 Author: Alex Christensen Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/draw-null-buffer-to-canvas-expected.txt A LayoutTests/fast/webgpu/draw-null-buffer-to-canvas.html A LayoutTests/platform/ios/fast/webgpu/draw-null-buffer-to-canvas-expected.txt M Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm Log Message: --- Null check buffer in GPUCanvasContextCocoa::drawBufferToCanvas https://bugs.webkit.org/show_bug.cgi?id=270599 rdar://124143249 Reviewed by Mike Wyrzykowski. * LayoutTests/fast/webgpu/draw-null-buffer-to-canvas-expected.txt: Added. * LayoutTests/fast/webgpu/draw-null-buffer-to-canvas.html: Added. * Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm: (WebCore::GPUCanvasContextCocoa::drawBufferToCanvas): Canonical link: https://commits.webkit.org/275770@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 055511: PresentationContextIOSurface::configure should che...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 055511d1aab8adce779b45c6dff36d74e3b8d381 https://github.com/WebKit/WebKit/commit/055511d1aab8adce779b45c6dff36d74e3b8d381 Author: Alex Christensen Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/invalid-surface-height-expected.txt A LayoutTests/fast/webgpu/invalid-surface-height.html M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm Log Message: --- PresentationContextIOSurface::configure should check for invalid height before creating MTLTexture https://bugs.webkit.org/show_bug.cgi?id=270608 rdar://124143113 Reviewed by Mike Wyrzykowski. * LayoutTests/fast/webgpu/invalid-surface-height-expected.txt: Added. * LayoutTests/fast/webgpu/invalid-surface-height.html: Added. * Source/WebGPU/WebGPU/PresentationContextIOSurface.mm: (WebGPU::PresentationContextIOSurface::configure): Canonical link: https://commits.webkit.org/275772@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9d53b7: Fix nullptr crash in recreateRenderBuffers when IO...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9d53b7214e2477e2ad77a2c0be44157b915329bb https://github.com/WebKit/WebKit/commit/9d53b7214e2477e2ad77a2c0be44157b915329bb Author: Alex Christensen Date: 2024-03-07 (Thu, 07 Mar 2024) Changed paths: M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCompositorIntegrationImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCompositorIntegrationImpl.h Log Message: --- Fix nullptr crash in recreateRenderBuffers when IOSurface::create fails https://bugs.webkit.org/show_bug.cgi?id=270641 rdar://124213354 Reviewed by Mike Wyrzykowski. * Source/WebCore/Modules/WebGPU/Implementation/WebGPUCompositorIntegrationImpl.cpp: (WebCore::WebGPU::CompositorIntegrationImpl::recreateRenderBuffers): * Source/WebCore/Modules/WebGPU/Implementation/WebGPUCompositorIntegrationImpl.h: Canonical link: https://commits.webkit.org/275805@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b5d883: PresentationContextIOSurface::getCurrentTexture sh...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b5d883c007df4a82390ff0f9e00028dee0044d28 https://github.com/WebKit/WebKit/commit/b5d883c007df4a82390ff0f9e00028dee0044d28 Author: Alex Christensen Date: 2024-03-11 (Mon, 11 Mar 2024) Changed paths: M Source/WebGPU/WebGPU/PresentationContextIOSurface.h M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.cpp Log Message: --- PresentationContextIOSurface::getCurrentTexture should return an invalid texture instead of null https://bugs.webkit.org/show_bug.cgi?id=270800 rdar://124392010 Reviewed by Mike Wyrzykowski. This, along with https://github.com/WebKit/WebKit/pull/25636 is necessary to fix rdar://124213314 * Source/WebGPU/WebGPU/PresentationContextIOSurface.h: * Source/WebGPU/WebGPU/PresentationContextIOSurface.mm: (WebGPU::PresentationContextIOSurface::configure): * Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.cpp: (WebKit::RemotePresentationContext::getCurrentTexture): Canonical link: https://commits.webkit.org/275912@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 94f1c3: Unskip some layout tests when running with --site-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 94f1c3176829feba3fb266fd73bb45cba7f86c02 https://github.com/WebKit/WebKit/commit/94f1c3176829feba3fb266fd73bb45cba7f86c02 Author: Alex Christensen Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- Unskip some layout tests when running with --site-isolation https://bugs.webkit.org/show_bug.cgi?id=270870 rdar://124472866 Reviewed by Charlie Wolfe. This increases the number of tests we run by over 10x from 3 to 34. An assertion needed updating in WebPageProxy because we receive messages from processes that are not the main frame's process. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleMessage): (WebKit::WebPageProxy::handleSynchronousMessage): Canonical link: https://commits.webkit.org/275993@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f816a1: Fix some assertions when using a canvas without a ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f816a1743b89245484a0ea3462c76fe88d593d3e https://github.com/WebKit/WebKit/commit/f816a1743b89245484a0ea3462c76fe88d593d3e Author: Alex Christensen Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/use-canvas-without-layer-expected.txt A LayoutTests/fast/webgpu/use-canvas-without-layer.html M Source/WebCore/Modules/WebGPU/GPU.cpp M Source/WebCore/Modules/WebGPU/GPU.h M Source/WebCore/Modules/WebGPU/GPUCommandEncoder.cpp M Source/WebCore/Modules/WebGPU/GPUCommandEncoder.h M Source/WebCore/Modules/WebGPU/GPUDevice.cpp M Source/WebCore/Modules/WebGPU/GPUDevice.h M Source/WebCore/Modules/WebGPU/GPUPresentationContext.cpp M Source/WebCore/Modules/WebGPU/GPUPresentationContext.h M Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.cpp M Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.h M Source/WebCore/Modules/WebGPU/GPUTexture.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.h M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.h M Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.h M Source/WebCore/Modules/WebGPU/Implementation/WebGPUPresentationContextImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUPresentationContextImpl.h M Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderBundleEncoderImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderBundleEncoderImpl.h M Source/WebCore/Modules/WebGPU/Implementation/WebGPUTextureImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUTextureImpl.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUCommandEncoder.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUDevice.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPresentationContext.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderBundleEncoder.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUTexture.h M Source/WebCore/html/canvas/GPUCanvasContextCocoa.h M Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.cpp M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.h M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemotePresentationContextProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemotePresentationContextProxy.h M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.h M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.h M Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.h Log Message: --- Fix some assertions when using a canvas without a layer with webgpu https://bugs.webkit.org/show_bug.cgi?id=270705 rdar://124213314 Reviewed by Mike Wyrzykowski. The test in this PR hit several issues: 1. PresentationContextIOSurface::present asserted, which I changed to an early return. 2. I handle errors when creating objects by returning nullptr instead of an object that has no corresponding object in the GPU process, and propogate those
[webkit-changes] [WebKit/WebKit] 85ca8b: Clean up serialized type info for IPC test API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 85ca8bbdbc74fb2a06470bfc623af965a5db6ee1 https://github.com/WebKit/WebKit/commit/85ca8bbdbc74fb2a06470bfc623af965a5db6ee1 Author: Alex Christensen Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in M Source/WebKit/Scripts/generate-serializers.py M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp M Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp M Source/WebKit/Scripts/webkit/tests/WebKitPlatformGeneratedSerializers.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/Shared/WebGPU/WebGPUColor.serialization.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: --- Clean up serialized type info for IPC test API https://bugs.webkit.org/show_bug.cgi?id=270884 rdar://124491555 Reviewed by Mike Wyrzykowski. This fixes a number of issues: Incorrect spaces in serialization.in files Missing C preprocessor guards around type info for types with conditions Missing wrapper information for webkit_secure_coding_types and cf_types I also improved the test to know about more container types and fundamental types. * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in: * Source/WebKit/Scripts/generate-serializers.py: (generate_one_serialized_type_info): * Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp: * Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp: (WebKit::allSerializedTypes): * Source/WebKit/Scripts/webkit/tests/WebKitPlatformGeneratedSerializers.cpp: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/Shared/WebGPU/WebGPUColor.serialization.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: Canonical link: https://commits.webkit.org/276023@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e87abc: Add bounds check when writing multidimensional tex...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e87abc019b58b6bec3af3db905ff83ba39a9302e https://github.com/WebKit/WebKit/commit/e87abc019b58b6bec3af3db905ff83ba39a9302e Author: Alex Christensen Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/fast/webgpu/multidimensional-texture-bounds-expected.txt A LayoutTests/fast/webgpu/multidimensional-texture-bounds.html M Source/WebGPU/WebGPU/Queue.mm Log Message: --- Add bounds check when writing multidimensional texture https://bugs.webkit.org/show_bug.cgi?id=270896 rdar://124475299 Reviewed by Mike Wyrzykowski. * LayoutTests/TestExpectations: * LayoutTests/fast/webgpu/multidimensional-texture-bounds-expected.txt: Added. * LayoutTests/fast/webgpu/multidimensional-texture-bounds.html: Added. * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::writeTexture): Canonical link: https://commits.webkit.org/276024@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 60aeff: Use smart pointers to store references to ObjectHeap
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 60aeffa2f9b8aaa7da3ae2fe2815090ca79f2e9d https://github.com/WebKit/WebKit/commit/60aeffa2f9b8aaa7da3ae2fe2815090ca79f2e9d Author: Alex Christensen Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCompositorIntegrationImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCompositorIntegrationImpl.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUCompositorIntegration.h M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp M Source/WebKit/GPUProcess/ShapeDetection/RemoteBarcodeDetector.cpp M Source/WebKit/GPUProcess/ShapeDetection/RemoteBarcodeDetector.h M Source/WebKit/GPUProcess/ShapeDetection/RemoteFaceDetector.cpp M Source/WebKit/GPUProcess/ShapeDetection/RemoteFaceDetector.h M Source/WebKit/GPUProcess/ShapeDetection/RemoteTextDetector.cpp M Source/WebKit/GPUProcess/ShapeDetection/RemoteTextDetector.h M Source/WebKit/GPUProcess/ShapeDetection/ShapeDetectionObjectHeap.h M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroupLayout.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroupLayout.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandBuffer.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandBuffer.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteExternalTexture.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteExternalTexture.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePipelineLayout.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePipelineLayout.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQuerySet.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQuerySet.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundle.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundle.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteSampler.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteSampler.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteShaderModule.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteShaderModule.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTextureView.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTextureView.h M Source/WebKit/GPUProcess/graphics/WebGPU/WebGPUObjectHeap.h M Source/WebKit/GPUProcess/mac/LocalAudioSessionRoutingArbitrator.cpp M Source/WebKit/GPUProcess/mac/LocalAudioSessionRoutingArbitrator.h M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.h M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.cpp M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.h M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp M Source/WebKit/GPUProcess/media
[webkit-changes] [WebKit/WebKit] 7debec: Null check video element in imageBytesForSource
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7debec9d62d0792976658aede004da32cefc88b0 https://github.com/WebKit/WebKit/commit/7debec9d62d0792976658aede004da32cefc88b0 Author: Alex Christensen Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/fast/webgpu/null-video-texture-expected.txt A LayoutTests/fast/webgpu/null-video-texture.html M Source/WebCore/Modules/WebGPU/GPUQueue.cpp Log Message: --- Null check video element in imageBytesForSource https://bugs.webkit.org/show_bug.cgi?id=270922 rdar://124475221 Reviewed by Mike Wyrzykowski. Also add a release assertion to verify that the callback is called synchronously so that the captured references are still in scope. * LayoutTests/fast/webgpu/null-video-texture-expected.txt: Added. * LayoutTests/fast/webgpu/null-video-texture.html: Added. * Source/WebCore/Modules/WebGPU/GPUQueue.cpp: (WebCore::imageBytesForSource): (WebCore::GPUQueue::copyExternalImageToTexture): Canonical link: https://commits.webkit.org/276047@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8e3980: CommandEncoder::clearTexture should only allocate ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8e39803a4c17f35737254dbc26993ab097ef187f https://github.com/WebKit/WebKit/commit/8e39803a4c17f35737254dbc26993ab097ef187f Author: Alex Christensen Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/copy-texture-more-than-4gb-expected.txt A LayoutTests/fast/webgpu/copy-texture-more-than-4gb.html M Source/WebGPU/WebGPU/CommandEncoder.mm Log Message: --- CommandEncoder::clearTexture should only allocate once to make temporaryBuffer https://bugs.webkit.org/show_bug.cgi?id=270938 rdar://124475200 Reviewed by Mike Wyrzykowski. Instead of allocating a Vector then allocating a buffer from it with newBufferWithBytes, just use newBufferWithLength. This also fixes crashes where the buffer length is more than 4GB, which Vector can't allocate. * LayoutTests/fast/webgpu/copy-texture-more-than-4gb-expected.txt: Added. * LayoutTests/fast/webgpu/copy-texture-more-than-4gb.html: Added. * Source/WebGPU/WebGPU/CommandEncoder.mm: (WebGPU::CommandEncoder::clearTexture): Canonical link: https://commits.webkit.org/276058@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7c93bf: Move some WKWebViewConfiguration ivars to API::Pag...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7c93bf95a3d4107ef243dbfe98fba8207de3bb09 https://github.com/WebKit/WebKit/commit/7c93bf95a3d4107ef243dbfe98fba8207de3bb09 Author: Alex Christensen Date: 2024-03-14 (Thu, 14 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/APIPageConfiguration.h M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm Log Message: --- Move some WKWebViewConfiguration ivars to API::PageConfiguration https://bugs.webkit.org/show_bug.cgi?id=270957 rdar://124574976 Reviewed by Charlie Wolfe. This is needed so we can move the configuration construction into platform-independent code in WebPageProxy::createNewPage. Explicit copy code is no longer needed because API::PageConfiguration::copy uses API::PageConfiguration::Data's default copy assignment operator. * Source/WebKit/UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::showsURLsInToolTips const): (API::PageConfiguration::setShowsURLsInToolTips): (API::PageConfiguration::serviceControlsEnabled const): (API::PageConfiguration::setServiceControlsEnabled): (API::PageConfiguration::imageControlsEnabled const): (API::PageConfiguration::setImageControlsEnabled): (API::PageConfiguration::contextMenuQRCodeDetectionEnabled const): (API::PageConfiguration::setContextMenuQRCodeDetectionEnabled): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration _showsURLsInToolTips]): (-[WKWebViewConfiguration _setShowsURLsInToolTips:]): (-[WKWebViewConfiguration _serviceControlsEnabled]): (-[WKWebViewConfiguration _setServiceControlsEnabled:]): (-[WKWebViewConfiguration _imageControlsEnabled]): (-[WKWebViewConfiguration _setImageControlsEnabled:]): (-[WKWebViewConfiguration _contextMenuQRCodeDetectionEnabled]): (-[WKWebViewConfiguration _setContextMenuQRCodeDetectionEnabled:]): Canonical link: https://commits.webkit.org/276075@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 025ad3: Expose more metadata to IPC testing API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 025ad3b399a60ab568ca1ad2486b5513bd0ba5d2 https://github.com/WebKit/WebKit/commit/025ad3b399a60ab568ca1ad2486b5513bd0ba5d2 Author: Alex Christensen Date: 2024-03-14 (Thu, 14 Mar 2024) Changed paths: M Source/WebKit/GPUProcess/GPUProcess.messages.in M Source/WebKit/GPUProcess/GPUProcessCreationParameters.serialization.in M Source/WebKit/GPUProcess/GPUProcessSessionParameters.serialization.in M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in M Source/WebKit/NetworkProcess/NetworkProcess.cpp M Source/WebKit/NetworkProcess/NetworkProcess.messages.in M Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.serialization.in M Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.serialization.in M Source/WebKit/Platform/IPC/ConnectionHandle.serialization.in M Source/WebKit/Platform/IPC/FormDataReference.h M Source/WebKit/Platform/IPC/FormDataReference.serialization.in M Source/WebKit/Platform/IPC/IPCEvent.serialization.in M Source/WebKit/Scripts/generate-serializers.py M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Shared/API/APIURL.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCCVPixelBufferRef.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCLocale.serialization.in M Source/WebKit/Shared/Databases/IndexedDB/WebIDBResult.serialization.in M Source/WebKit/Shared/GoToBackForwardItemParameters.serialization.in M Source/WebKit/Shared/LoadParameters.serialization.in M Source/WebKit/Shared/NavigationActionData.serialization.in M Source/WebKit/Shared/PolicyDecision.serialization.in M Source/WebKit/Shared/ResourceLoadStatisticsParameters.serialization.in M Source/WebKit/Shared/UnifiedTextReplacement.serialization.in M Source/WebKit/Shared/WTFArgumentCoders.serialization.in M Source/WebKit/Shared/WebPageCreationParameters.serialization.in M Source/WebKit/Shared/WebProcessCreationParameters.serialization.in M Source/WebKit/Shared/WebProcessDataStoreParameters.serialization.in M Source/WebKit/Shared/WebsiteDataStoreParameters.serialization.in M Source/WebKit/Shared/WebsitePoliciesData.serialization.in M Source/WebKit/UIProcess/Downloads/DownloadProxy.messages.in M Source/WebKit/UIProcess/WebPasteboardProxy.messages.in M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.serialization.in M Source/WebKit/WebProcess/MediaStream/MediaDeviceSandboxExtensions.serialization.in M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Source/WebKit/WebProcess/WebProcess.h M Source/WebKit/WebProcess/WebProcess.messages.in M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: --- Expose more metadata to IPC testing API https://bugs.webkit.org/show_bug.cgi?id=270956 rdar://124574394 Reviewed by Sihui Liu. * Source/WebKit/GPUProcess/GPUProcess.messages.in: * Source/WebKit/GPUProcess/GPUProcessCreationParameters.serialization.in: * Source/WebKit/GPUProcess/GPUProcessSessionParameters.serialization.in: * Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in: * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in: * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in: * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::resumeDownload): * Source/WebKit/NetworkProcess/NetworkProcess.messages.in: * Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.serialization.in: * Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.serialization.in: * Source/WebKit/Platform/IPC/ConnectionHandle.serialization.in: * Source/WebKit/Platform/IPC/FormDataReference.h: (IPC::FormDataReference::FormDataReference): (IPC::FormDataReference::sandboxExtensionHandles const): * Source/WebKit/Platform/IPC/FormDataReference.serialization.in: * Source/WebKit/Platform/IPC/IPCEvent.serialization.in: * Source/WebKit/Scripts/generate-serializers.py: (SerializedType.namespace_if_not_wtf_and_name): (generate_one_serialized_type_info): * Source/WebKit/Scripts/webkit/messages.py: (types_that_must_be_moved): * Source/WebKit/Shared/API/APIURL.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCCVPixelBufferRef.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCLocale.serialization.in: * Source/WebKit/Shared/Databases/IndexedDB/WebIDBResult.serialization.in: * Source/WebKit/Shared/GoToBackForwardItemParameters.serialization.in: * Source/WebKit/Shared/LoadParameters.serialization.in: * Source/WebKit/Shared/NavigationActionData.serialization.in: * Source/WebKit/Shared/PolicyDecision.serialization.in
[webkit-changes] [WebKit/WebKit] dec125: Refine smart pointer use in GPU process
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dec1255bbfdf0d5e0007306ce19be2c2076d0ed1 https://github.com/WebKit/WebKit/commit/dec1255bbfdf0d5e0007306ce19be2c2076d0ed1 Author: Alex Christensen Date: 2024-03-14 (Thu, 14 Mar 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/fast/webgpu/write-to-destroyed-buffer.html M Source/WTF/wtf/WeakPtr.h M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.h M Source/WebKit/GPUProcess/graphics/WebGPU/WebGPUObjectHeap.cpp M Source/WebKit/GPUProcess/mac/LocalAudioSessionRoutingArbitrator.cpp M Source/WebKit/GPUProcess/mac/LocalAudioSessionRoutingArbitrator.h M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.h M Source/WebKit/GPUProcess/media/RemoteAudioHardwareListenerProxy.cpp M Source/WebKit/GPUProcess/media/RemoteAudioHardwareListenerProxy.h M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.cpp M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.h M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp M Source/WebKit/GPUProcess/media/RemoteAudioTrackProxy.cpp M Source/WebKit/GPUProcess/media/RemoteAudioTrackProxy.h M Source/WebKit/GPUProcess/media/RemoteCDMFactoryProxy.cpp M Source/WebKit/GPUProcess/media/RemoteCDMFactoryProxy.h M Source/WebKit/GPUProcess/media/RemoteCDMInstanceProxy.cpp M Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp M Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.cpp M Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.h M Source/WebKit/GPUProcess/media/RemoteLegacyCDMFactoryProxy.cpp M Source/WebKit/GPUProcess/media/RemoteLegacyCDMFactoryProxy.h M Source/WebKit/GPUProcess/media/RemoteLegacyCDMProxy.cpp M Source/WebKit/GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.h M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h M Source/WebKit/GPUProcess/media/RemoteRemoteCommandListenerProxy.cpp M Source/WebKit/GPUProcess/media/RemoteRemoteCommandListenerProxy.h M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h M Source/WebKit/GPUProcess/media/RemoteTextTrackProxy.cpp M Source/WebKit/GPUProcess/media/RemoteTextTrackProxy.h M Source/WebKit/GPUProcess/media/RemoteVideoTrackProxy.cpp M Source/WebKit/GPUProcess/media/RemoteVideoTrackProxy.h M Source/WebKit/GPUProcess/media/ios/RemoteMediaSessionHelperProxy.cpp M Source/WebKit/GPUProcess/media/ios/RemoteMediaSessionHelperProxy.h M Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp M Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.h M Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.cpp M Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.h M Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorderManager.cpp M Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorderManager.h M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h Log Message: --- Refine smart pointer use in GPU process https://bugs.webkit.org/show_bug.cgi?id=270961 rdar://124589610 Reviewed by Kimmo Kinnunen. RemoteGPU and WebGPU::ObjectHeap are used exclusively on a non-main thread, but they are constructed on the main thread. Introduce WeakPtrFactory::prepareForUseOnlyOnNonMainThread to make this safe use of WeakRef and WeakPtr not assert. GPUConnectionToWebProcess is ThreadSafeRefCounted and used on main and non-main threads. Use ThreadSafeWeakPtr for all weak references to it. This added a lot of null checks where possible. * LayoutTests/TestExpectations: * LayoutTests/fast/webgpu/write-to-destroyed-buffer.html: * Source/WTF/wtf/WeakPtr.h: (WTF::WeakPtrFactory::prepareForUseOnlyOnNonMainThread): * Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp: * Source
[webkit-changes] [WebKit/WebKit] e7bb5f: Migrate more ivars from WKWebViewConfiguration to ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e7bb5f0f51c631f0fdfbdfeab27b4b7e559c6ea2 https://github.com/WebKit/WebKit/commit/e7bb5f0f51c631f0fdfbdfeab27b4b7e559c6ea2 Author: Alex Christensen Date: 2024-03-14 (Thu, 14 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/APIPageConfiguration.h M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm Log Message: --- Migrate more ivars from WKWebViewConfiguration to API::PageConfiguration https://bugs.webkit.org/show_bug.cgi?id=270990 rdar://124627697 Reviewed by Charlie Wolfe. This is another step towards moving the PageConfiguration creation to platform-independent code in WebPageProxy::createNewPage. * Source/WebKit/UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::incrementalRenderingSuppressionTimeout const): (API::PageConfiguration::setIncrementalRenderingSuppressionTimeout): (API::PageConfiguration::allowsJavaScriptMarkup const): (API::PageConfiguration::setAllowsJavaScriptMarkup): (API::PageConfiguration::convertsPositionStyleOnCopy const): (API::PageConfiguration::setConvertsPositionStyleOnCopy): (API::PageConfiguration::allowsMetaRefresh const): (API::PageConfiguration::setAllowsMetaRefresh): (API::PageConfiguration::allowUniversalAccessFromFileURLs const): (API::PageConfiguration::setAllowUniversalAccessFromFileURLs): (API::PageConfiguration::allowTopNavigationToDataURLs const): (API::PageConfiguration::setAllowTopNavigationToDataURLs): (API::PageConfiguration::needsStorageAccessFromFileURLsQuirk const): (API::PageConfiguration::setNeedsStorageAccessFromFileURLsQuirk): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration _incrementalRenderingSuppressionTimeout]): (-[WKWebViewConfiguration _setIncrementalRenderingSuppressionTimeout:]): (-[WKWebViewConfiguration _allowsJavaScriptMarkup]): (-[WKWebViewConfiguration _setAllowsJavaScriptMarkup:]): (-[WKWebViewConfiguration _allowUniversalAccessFromFileURLs]): (-[WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:]): (-[WKWebViewConfiguration _allowTopNavigationToDataURLs]): (-[WKWebViewConfiguration _setAllowTopNavigationToDataURLs:]): (-[WKWebViewConfiguration _convertsPositionStyleOnCopy]): (-[WKWebViewConfiguration _setConvertsPositionStyleOnCopy:]): (-[WKWebViewConfiguration _allowsMetaRefresh]): (-[WKWebViewConfiguration _setAllowsMetaRefresh:]): (-[WKWebViewConfiguration _needsStorageAccessFromFileURLsQuirk]): (-[WKWebViewConfiguration _setNeedsStorageAccessFromFileURLsQuirk:]): Canonical link: https://commits.webkit.org/276117@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 129e64: Expose more type metadata to IPC test API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 129e6466acb1ebebfb9b62b5c21956aa9950a716 https://github.com/WebKit/WebKit/commit/129e6466acb1ebebfb9b62b5c21956aa9950a716 Author: Alex Christensen Date: 2024-03-14 (Thu, 14 Mar 2024) Changed paths: M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.messages.in M Source/WebKit/Scripts/generate-serializers.py M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h M Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp M Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in M Source/WebKit/Scripts/webkit/tests/WebKitPlatformGeneratedSerializers.cpp M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.messages.in M Source/WebKit/WebProcess/Network/webrtc/WebRTCMonitor.messages.in M Source/WebKit/WebProcess/Network/webrtc/WebRTCResolver.messages.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: --- Expose more type metadata to IPC test API https://bugs.webkit.org/show_bug.cgi?id=270985 rdar://124626429 Reviewed by Sihui Liu. This exposes type metadata for ObjC types wrapped by CoreIPC types, and fixes up a few other types so their contents are consistently exposed. * Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.messages.in: * Source/WebKit/Scripts/generate-serializers.py: (SerializedType.name_declaration_for_serialized_type_info): (SerializedType.members_for_serialized_type_info): (ObjCWrappedType): (ObjCWrappedType.__init__): (generate_impl): (generate_serialized_type_info): (parse_serialized_types): (main): * Source/WebKit/Scripts/webkit/messages.py: (headers_for_type): * Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h: (IPC::ArgumentCoder>::encode): * Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp: (WebKit::allSerializedTypes): * Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in: * Source/WebKit/Scripts/webkit/tests/WebKitPlatformGeneratedSerializers.cpp: (IPC::encodeObjectDirectly): (IPC::decodeObjectDirectlyRequiringAllowedClasses): (IPC::encodeObjectDirectly): (IPC::decodeObjectDirectlyRequiringAllowedClasses): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder>::decode): * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.messages.in: * Source/WebKit/WebProcess/Network/webrtc/WebRTCMonitor.messages.in: * Source/WebKit/WebProcess/Network/webrtc/WebRTCResolver.messages.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: Canonical link: https://commits.webkit.org/276118@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2524a1: REGRESSION(276077@main) http/tests/navigation/pars...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2524a1511ef01e3daea353627dcf132cc92f66fa https://github.com/WebKit/WebKit/commit/2524a1511ef01e3daea353627dcf132cc92f66fa Author: Alex Christensen Date: 2024-03-14 (Thu, 14 Mar 2024) Changed paths: M Source/WebKit/GPUProcess/media/RemoteLegacyCDMFactoryProxy.h Log Message: --- REGRESSION(276077@main) http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html asserts in debug builds https://bugs.webkit.org/show_bug.cgi?id=271025 rdar://124649753 Reviewed by Charlie Wolfe. If you run the test http/tests/navigation/page-cache-mediakeysession.html followed by the test http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html then RemoteLegacyCDMFactoryProxy::clear is called from the RemoteLegacyCDMFactoryProxy destructor which is called from the unique_ptr destructor which is calld from the GPUConnectionToWebProcess destructor. ThreadSafeWeakPtr::get returns null if the destructor has begun, but WeakPtr::get does not. So to fix this crash, go back to using WeakPtr in this case. * Source/WebKit/GPUProcess/media/RemoteLegacyCDMFactoryProxy.h: Canonical link: https://commits.webkit.org/276132@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 551268: Move more ivars from WKWebViewConfiguration to API...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 55126806e72c760b8a83b281576adbd54931d6b1 https://github.com/WebKit/WebKit/commit/55126806e72c760b8a83b281576adbd54931d6b1 Author: Alex Christensen Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/APIPageConfiguration.h M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm Log Message: --- Move more ivars from WKWebViewConfiguration to API::PageConfiguration https://bugs.webkit.org/show_bug.cgi?id=271034 rdar://124659985 Reviewed by Sihui Liu. This is in preparation for moving PageConfiguration initialization to platform-independent WebPageProxy::createNewPage. * Source/WebKit/UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::legacyEncryptedMediaAPIEnabled const): (API::PageConfiguration::setLegacyEncryptedMediaAPIEnabled): (API::PageConfiguration::allowMediaContentTypesRequiringHardwareSupportAsFallback const): (API::PageConfiguration::setAllowMediaContentTypesRequiringHardwareSupportAsFallback): (API::PageConfiguration::colorFilterEnabled const): (API::PageConfiguration::setColorFilterEnabled): (API::PageConfiguration::incompleteImageBorderEnabled const): (API::PageConfiguration::setIncompleteImageBorderEnabled): (API::PageConfiguration::shouldDeferAsynchronousScriptsUntilAfterDocumentLoad const): (API::PageConfiguration::setShouldDeferAsynchronousScriptsUntilAfterDocumentLoad): (API::PageConfiguration::undoManagerAPIEnabled const): (API::PageConfiguration::setUndoManagerAPIEnabled): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration _colorFilterEnabled]): (-[WKWebViewConfiguration _setColorFilterEnabled:]): (-[WKWebViewConfiguration _incompleteImageBorderEnabled]): (-[WKWebViewConfiguration _setIncompleteImageBorderEnabled:]): (-[WKWebViewConfiguration _shouldDeferAsynchronousScriptsUntilAfterDocumentLoad]): (-[WKWebViewConfiguration _setShouldDeferAsynchronousScriptsUntilAfterDocumentLoad:]): (-[WKWebViewConfiguration _drawsBackground]): (-[WKWebViewConfiguration _setDrawsBackground:]): (-[WKWebViewConfiguration _setLegacyEncryptedMediaAPIEnabled:]): (-[WKWebViewConfiguration _legacyEncryptedMediaAPIEnabled]): (-[WKWebViewConfiguration _setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]): (-[WKWebViewConfiguration _allowMediaContentTypesRequiringHardwareSupportAsFallback]): (-[WKWebViewConfiguration _setUndoManagerAPIEnabled:]): (-[WKWebViewConfiguration _undoManagerAPIEnabled]): Canonical link: https://commits.webkit.org/276178@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 114350: Expose more serialized type metadata to IPC test API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 114350b607aedcaeca5163b4e7539e4f7fe63f72 https://github.com/WebKit/WebKit/commit/114350b607aedcaeca5163b4e7539e4f7fe63f72 Author: Alex Christensen Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.h M Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h M Source/WebCore/platform/ScrollTypes.h M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebKit/GPUProcess/GPUProcess.messages.in M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.messages.in M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in M Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in M Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.messages.in M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Shared/Cocoa/CoreIPCNSValue.h M Source/WebKit/Shared/Cocoa/CoreIPCNSValue.serialization.in M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in M Source/WebKit/Shared/Extensions/WebExtensionContextParameters.serialization.in M Source/WebKit/Shared/UnifiedTextReplacement.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/Shared/WebImage.serialization.in M Source/WebKit/Shared/WebPreferencesStore.serialization.in M Source/WebKit/UIProcess/Automation/WebAutomationSession.messages.in M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.messages.in M Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/UIProcess/dmabuf/AcceleratedBackingStoreDMABuf.messages.in M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerState.serialization.in M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.messages.in M Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.serialization.in M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.messages.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: --- Expose more serialized type metadata to IPC test API https://bugs.webkit.org/show_bug.cgi?id=271071 Reviewed by Timothy Hatcher. * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::computeUpdatedLayoutViewportRect): (WebCore::LocalFrameView::computeLayoutViewportOrigin): (WebCore::LocalFrameView::updateLayoutViewport): (WebCore::LocalFrameView::scrollPositionForFixedPosition): (WebCore::LocalFrameView::rectForViewportConstrainedObjects): (WebCore::LocalFrameView::scrollBehaviorForFixedElements const): * Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.h: * Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.cpp: (WebCore::ScrollingTreeFrameScrollingNode::layoutViewportRespectingRubberBanding const): * Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h: * Source/WebCore/platform/ScrollTypes.h: * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::customPositionForVisibleRectComputation const): * Source/WebKit/GPUProcess/GPUProcess.messages.in: * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in: * Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.messages.in: * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in: * Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in: * Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in: * Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in: * Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.messages.in: * Source/WebKit/Scripts/webkit/messages.py: (types_that_must_be_moved): (types_that_cannot_be_forward_declared): (headers_for_type): * Source/WebKit/Shared/Cocoa/CoreIPCNSValue.h: * Source/WebKit/Shared/Cocoa/CoreIPCNSValue.serialization.in: * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in: * Source/WebKit/Shared/Extensions/WebExtensionContextParameters.serialization.in: * Source/WebKit/Shared/UnifiedTextReplacement.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/Shared/WebImage.serialization.in: * Source/WebKit/Shared/WebPreferencesStore.serialization.in: * Source/WebKit/UIProcess/Automation/WebAutomationSession.messages.in: * Source/WebKit
[webkit-changes] [WebKit/WebKit] dff426: Early return if accelerated image conversion fails
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dff42693529a291af9cee354a873f1b8bbdb2134 https://github.com/WebKit/WebKit/commit/dff42693529a291af9cee354a873f1b8bbdb2134 Author: Alex Christensen Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/accelerated-image-conversion-failure-expected.txt A LayoutTests/fast/webgpu/accelerated-image-conversion-failure.html M Source/WebCore/platform/graphics/PixelBufferConversion.cpp Log Message: --- Early return if accelerated image conversion fails https://bugs.webkit.org/show_bug.cgi?id=271078 rdar://124288802 Reviewed by Mike Wyrzykowski. * LayoutTests/fast/webgpu/accelerated-image-conversion-failure-expected.txt: Added. * LayoutTests/fast/webgpu/accelerated-image-conversion-failure.html: Added. * Source/WebCore/platform/graphics/PixelBufferConversion.cpp: (WebCore::convertImagePixelsAccelerated): Canonical link: https://commits.webkit.org/276205@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 131257: Store smart pointers in Source/WebGPU/WebGPU
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 131257ba6812a47538c2fa5547532fa4f0dcd7e5 https://github.com/WebKit/WebKit/commit/131257ba6812a47538c2fa5547532fa4f0dcd7e5 Author: Alex Christensen Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/WebGPU/WebGPU/BindGroupLayout.h M Source/WebGPU/WebGPU/BindGroupLayout.mm M Source/WebGPU/WebGPU/ComputePassEncoder.h M Source/WebGPU/WebGPU/ComputePipeline.h M Source/WebGPU/WebGPU/PipelineLayout.h M Source/WebGPU/WebGPU/RenderBundleEncoder.h M Source/WebGPU/WebGPU/RenderPassEncoder.h Log Message: --- Store smart pointers in Source/WebGPU/WebGPU https://bugs.webkit.org/show_bug.cgi?id=271095 rdar://124712975 Reviewed by Mike Wyrzykowski and Charlie Wolfe. * Source/WebGPU/WebGPU/BindGroupLayout.h: * Source/WebGPU/WebGPU/BindGroupLayout.mm: (WebGPU::BindGroupLayout::autogeneratedPipelineLayout const): * Source/WebGPU/WebGPU/ComputePassEncoder.h: * Source/WebGPU/WebGPU/ComputePipeline.h: * Source/WebGPU/WebGPU/PipelineLayout.h: * Source/WebGPU/WebGPU/RenderBundleEncoder.h: * Source/WebGPU/WebGPU/RenderPassEncoder.h: Canonical link: https://commits.webkit.org/276221@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cdc342: Expose more serialized type metadata to IPC test API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cdc342c5f229f8c9c21c008c6bcb7d0edc46648a https://github.com/WebKit/WebKit/commit/cdc342c5f229f8c9c21c008c6bcb7d0edc46648a Author: Alex Christensen Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.messages.in M Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.messages.in M Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.messages.in M Source/WebKit/Platform/IPC/ArgumentCoders.h M Source/WebKit/Platform/IPC/ObjectIdentifierReference.serialization.in M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp M Source/WebKit/Shared/Cocoa/CoreIPCCFType.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.serialization.in M Source/WebKit/Shared/Extensions/WebExtensionContextParameters.serialization.in M Source/WebKit/Shared/Extensions/WebExtensionTab.serialization.in M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTree.serialization.in M Source/WebKit/Shared/TextCheckerState.h M Source/WebKit/Shared/TextFlags.serialization.in M Source/WebKit/Shared/WebGPU/WebGPUExtent3D.serialization.in M Source/WebKit/Shared/WebGPU/WebGPUOrigin2D.serialization.in M Source/WebKit/Shared/WebGPU/WebGPUOrigin3D.serialization.in M Source/WebKit/Shared/WebGPU/WebGPUOutOfMemoryError.serialization.in M Source/WebKit/Shared/cf/CoreIPCNumber.serialization.in M Source/WebKit/Shared/ios/DynamicViewportSizeUpdate.serialization.in M Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in M Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager.messages.in M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in M Source/WebKit/WebProcess/GPU/graphics/PrepareBackingStoreBuffersData.serialization.in M Source/WebKit/WebProcess/GPU/media/RemoteAudioSourceProviderManager.messages.in M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemoteProperties.serialization.in M Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.messages.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: --- Expose more serialized type metadata to IPC test API https://bugs.webkit.org/show_bug.cgi?id=271096 rdar://124721207 Reviewed by Charlie Wolfe. * Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.messages.in: * Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.messages.in: * Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.messages.in: * Source/WebKit/Platform/IPC/ArgumentCoders.h: (IPC::SimpleArgumentCoder::encode): Deleted. (IPC::SimpleArgumentCoder::decode): Deleted. * Source/WebKit/Platform/IPC/ObjectIdentifierReference.serialization.in: * Source/WebKit/Scripts/webkit/messages.py: (types_that_must_be_moved): (serialized_identifiers): (headers_for_type): * Source/WebKit/Shared/Cocoa/CoreIPCCFType.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.serialization.in: * Source/WebKit/Shared/Extensions/WebExtensionContextParameters.serialization.in: * Source/WebKit/Shared/Extensions/WebExtensionTab.serialization.in: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTree.serialization.in: * Source/WebKit/Shared/TextCheckerState.h: * Source/WebKit/Shared/TextFlags.serialization.in: * Source/WebKit/Shared/WebGPU/WebGPUExtent3D.serialization.in: * Source/WebKit/Shared/WebGPU/WebGPUOrigin2D.serialization.in: * Source/WebKit/Shared/WebGPU/WebGPUOrigin3D.serialization.in: * Source/WebKit/Shared/WebGPU/WebGPUOutOfMemoryError.serialization.in: * Source/WebKit/Shared/cf/CoreIPCNumber.serialization.in: * Source/WebKit/Shared/ios/DynamicViewportSizeUpdate.serialization.in: * Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in: * Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager.messages.in: * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in: * Source/WebKit/WebProcess/GPU/graphics/PrepareBackingStoreBuffersData.serialization.in: * Source/WebKit/WebProcess/GPU/media/RemoteAudioSourceProviderManager.messages.in: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemoteProperties.serialization.in: * Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.messages.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: Canonical link: https://commits.webkit.org/276225@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6e7fff: Skip gb18030 table correction on platforms with IC...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6e7fffdeac955986ee20f2a860d754e7f494ec00 https://github.com/WebKit/WebKit/commit/6e7fffdeac955986ee20f2a860d754e7f494ec00 Author: Alex Christensen Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/WebCore/PAL/pal/text/EncodingTables.cpp Log Message: --- Skip gb18030 table correction on platforms with ICU 74 https://bugs.webkit.org/show_bug.cgi?id=271101 rdar://124720057 Reviewed by Yusuke Suzuki. On the Sonoma 23E214 build released last week, ICU 74 is present as indicated by the updated gb18030 table. However, uvernum.h is not in the public SDK so open source builds use the definition of U_ICU_VERSION_MAJOR_NUM in our copy of uvernum.h in Source/WTF/icu/unicode/uvernum.h which has U_ICU_VERSION_MAJOR_NUM defined to 70. Change the compile check to a runtime check. * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/PAL/pal/text/EncodingTables.cpp: (PAL::gb18030): Canonical link: https://commits.webkit.org/276229@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 803074: Remove managed configuration setting to enable leg...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 803074e08cd722c86aa733598862df6250c1b826 https://github.com/WebKit/WebKit/commit/803074e08cd722c86aa733598862df6250c1b826 Author: Alex Christensen Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebKit/UIProcess/Cocoa/NavigationState.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm Log Message: --- Remove managed configuration setting to enable legacy TLS without warning in Safari https://bugs.webkit.org/show_bug.cgi?id=271162 rdar://124635456 Reviewed by Chris Dumez. It was added several years ago to allow transition to a Safari that warns when you are using TLS 1.0 or 1.1. That several year long transition no longer needs a managed configuration setting to allow legacy TLS in Safari without a warning. Safari uses _WKWebsiteDataStoreConfiguration.legacyTLSEnabled to disable it. Users also have the ability to click through a warning to access pages with legacy TLS. * Source/WebKit/UIProcess/Cocoa/NavigationState.mm: (WebKit::systemAllowsLegacyTLSFor): Canonical link: https://commits.webkit.org/276308@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9179ad: Cast result of soft-linked MCProfileConnection.sha...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9179adab36b2aa57b758e6cd6d12ba17c134c8cc https://github.com/WebKit/WebKit/commit/9179adab36b2aa57b758e6cd6d12ba17c134c8cc Author: Alex Christensen Date: 2024-03-19 (Tue, 19 Mar 2024) Changed paths: M Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Log Message: --- Cast result of soft-linked MCProfileConnection.sharedConnection to MCProfileConnection pointer https://bugs.webkit.org/show_bug.cgi?id=271249 rdar://124635456 Reviewed by Chris Dumez. It is believed by some that this will fix a build failure. * Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm: (WebKit::allowsDeprecatedSynchronousXMLHttpRequestDuringUnload): * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _effectiveDataOwner:]): * Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::initializeManagedDomains): * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView canPerformActionForWebView:withSender:]): Canonical link: https://commits.webkit.org/276354@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ac7e2c: Move more ivars from WKWebViewConfiguration to API...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ac7e2c914e1046e159a945949f54fe122b0ec8cd https://github.com/WebKit/WebKit/commit/ac7e2c914e1046e159a945949f54fe122b0ec8cd Author: Alex Christensen Date: 2024-03-19 (Tue, 19 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/APIPageConfiguration.h M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm Log Message: --- Move more ivars from WKWebViewConfiguration to API::PageConfiguration https://bugs.webkit.org/show_bug.cgi?id=271282 rdar://125046091 Reviewed by Charlie Wolfe. * Source/WebKit/UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::mainContentUserGestureOverrideEnabled const): (API::PageConfiguration::setMainContentUserGestureOverrideEnabled): (API::PageConfiguration::invisibleAutoplayNotPermitted const): (API::PageConfiguration::setInvisibleAutoplayForbidden): (API::PageConfiguration::attachmentElementEnabled const): (API::PageConfiguration::setAttachmentElementEnabled): (API::PageConfiguration::attachmentWideLayoutEnabled const): (API::PageConfiguration::setAttachmentWideLayoutEnabled): (API::PageConfiguration::allowsInlinePredictions const): (API::PageConfiguration::setAllowsInlinePredictions): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]): (-[WKWebViewConfiguration setAllowsInlinePredictions:]): (-[WKWebViewConfiguration allowsInlinePredictions]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration _invisibleAutoplayNotPermitted]): (-[WKWebViewConfiguration _setInvisibleAutoplayNotPermitted:]): (-[WKWebViewConfiguration _attachmentElementEnabled]): (-[WKWebViewConfiguration _setAttachmentElementEnabled:]): (-[WKWebViewConfiguration _attachmentWideLayoutEnabled]): (-[WKWebViewConfiguration _setAttachmentWideLayoutEnabled:]): (-[WKWebViewConfiguration _mainContentUserGestureOverrideEnabled]): (-[WKWebViewConfiguration _setMainContentUserGestureOverrideEnabled:]): (-[WKWebViewConfiguration _waitsForPaintAfterViewDidMoveToWindow]): (-[WKWebViewConfiguration _setWaitsForPaintAfterViewDidMoveToWindow:]): (-[WKWebViewConfiguration _setMarkedTextInputEnabled:]): (-[WKWebViewConfiguration _markedTextInputEnabled]): Canonical link: https://commits.webkit.org/276383@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc094b: Use connection instead of mainFrameOrOpenerDomain ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc094b8fd290a9d342b4abd87e8e7effc6e4b575 https://github.com/WebKit/WebKit/commit/cc094b8fd290a9d342b4abd87e8e7effc6e4b575 Author: Alex Christensen Date: 2024-03-19 (Tue, 19 Mar 2024) Changed paths: M Source/WebKit/UIProcess/BrowsingContextGroup.cpp M Source/WebKit/UIProcess/BrowsingContextGroup.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebProcessPool.cpp Log Message: --- Use connection instead of mainFrameOrOpenerDomain when deciding what process to use for site isolated window.open https://bugs.webkit.org/show_bug.cgi?id=271280 rdar://125044857 Reviewed by Charlie Wolfe. This is the first of at least 2 steps to get http/tests/site-isolation/iframe-and-window-open.html to not assert when run with --site-isolation. The other is to make WebProcessPool::createWebPage not assume that the opened page's main frame needs to start in the same process as the opener's main frame process because window.open can be called from iframes. * Source/WebKit/UIProcess/BrowsingContextGroup.cpp: (WebKit::BrowsingContextGroup::processForConnection): (WebKit::BrowsingContextGroup::addPage): * Source/WebKit/UIProcess/BrowsingContextGroup.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCreateMainFrame): (WebKit::WebPageProxy::decidePolicyForNavigationActionSync): (WebKit::WebPageProxy::creationParameters): (WebKit::WebPageProxy::mainFrameOrOpenerDomain const): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::createWebPage): Canonical link: https://commits.webkit.org/276384@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5043f9: Expose more serialized type metadata to IPC test API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5043f9e1fc8b095077e52178fbf2e2fce33c5979 https://github.com/WebKit/WebKit/commit/5043f9e1fc8b095077e52178fbf2e2fce33c5979 Author: Alex Christensen Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTree.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.messages.in M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.messages.in M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.messages.in M Source/WebKit/WebProcess/Network/NetworkProcessConnection.messages.in M Source/WebKit/WebProcess/Network/WebResourceLoader.messages.in M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemoteProperties.serialization.in M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.messages.in M Source/WebKit/WebProcess/cocoa/VideoPresentationManager.messages.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: --- Expose more serialized type metadata to IPC test API https://bugs.webkit.org/show_bug.cgi?id=271341 rdar://125116221 Reviewed by Sihui Liu. * Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in: * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in: * Source/WebKit/Scripts/webkit/messages.py: (types_that_must_be_moved): (serialized_identifiers): (headers_for_type): * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTree.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.messages.in: * Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.messages.in: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.messages.in: * Source/WebKit/WebProcess/Network/NetworkProcessConnection.messages.in: * Source/WebKit/WebProcess/Network/WebResourceLoader.messages.in: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemoteProperties.serialization.in: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.messages.in: * Source/WebKit/WebProcess/cocoa/VideoPresentationManager.messages.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: Canonical link: https://commits.webkit.org/276461@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9b4ec9: Move most LazyInitialized ivars from WKWebViewConf...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b4ec97c63d50b56e80eff37479ba48885b92965 https://github.com/WebKit/WebKit/commit/9b4ec97c63d50b56e80eff37479ba48885b92965 Author: Alex Christensen Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M Source/WebKit/SourcesCocoa.txt M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp M Source/WebKit/UIProcess/API/APIPageConfiguration.h M Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp M Source/WebKit/UIProcess/API/APIWebsitePolicies.h M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesInternal.h M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/UIProcess/Cocoa/NavigationState.mm A Source/WebKit/UIProcess/Cocoa/WebPagePreferencesLockdownModeObserver.h A Source/WebKit/UIProcess/Cocoa/WebPagePreferencesLockdownModeObserver.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm M Source/WebKit/UIProcess/win/WebView.cpp M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm Log Message: --- Move most LazyInitialized ivars from WKWebViewConfiguration to API::PageConfiguration https://bugs.webkit.org/show_bug.cgi?id=271301 rdar://125067469 Reviewed by Chris Dumez. This is a step towards the API::PageConfiguration being made in WebPageProxy::createNewPage rather than UIClient::createNewPage. This new way of storing these objects is more robust against invalid use of WKWebViewConfiguration if nil is set as the value of non-nullable objects, so the validate step is no longer needed and the InvalidConfiguration API test needed some changes, but this should have no impact on legitimate use of the API. * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/UIProcess/API/APIPageConfiguration.cpp: (API::PageConfiguration::Data::createBrowsingContextGroup): (API::PageConfiguration::Data::createWebProcessPool): (API::PageConfiguration::Data::createWebUserContentControllerProxy): (API::PageConfiguration::Data::createWebPreferences): (API::PageConfiguration::Data::createVisitedLinkStore): (API::PageConfiguration::Data::createWebsitePolicies): (API::PageConfiguration::create): (API::PageConfiguration::browsingContextGroup const): (API::PageConfiguration::processPool const): (API::PageConfiguration::userContentController const): (API::PageConfiguration::preferences const): (API::PageConfiguration::pageToCloneSessionStorageFrom const): (API::PageConfiguration::setPageToCloneSessionStorageFrom): (API::PageConfiguration::visitedLinkStore const): (API::PageConfiguration::websiteDataStore const): (API::PageConfiguration::websiteDataStoreIfExists const): (API::PageConfiguration::protectedWebsiteDataStore const): (API::PageConfiguration::setWebsiteDataStore): (API::PageConfiguration::defaultWebsitePolicies const): (API::PageConfiguration::urlSchemeHandlerForURLScheme): (API::PageConfiguration::setURLSchemeHandlerForURLScheme): (API::PageConfiguration::lockdownModeEnabled const): (API::PageConfiguration::delaysWebProcessLaunchUntilFirstLoad const): (API::PageConfiguration::isLockdownModeExplicitlySet const): (API::PageConfiguration::preferencesForGPUProcess const): (API::PageConfiguration::preferencesForNetworkProcess const): (API::PageConfiguration::PageConfiguration): Deleted. (API::PageConfiguration::browsingContextGroup): Deleted. (API::PageConfiguration::processPool): Deleted. (API::PageConfiguration::userContentController): Deleted. (API::PageConfiguration::visitedLinkStore): Deleted. (API::PageConfiguration::websiteDataStore): Deleted. (API::PageConfiguration::protectedWebsiteDataStore): Deleted. * Source/WebKit/UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::Data::initializer): * Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp: (API::WebsitePolicies::WebsitePolicies): (API::WebsitePolicies::copy const): * Source/WebKit/UIProcess/API/APIWebsitePolicies.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _initializeWithConfiguration:]): (-[WKWebView _setupPageConfiguration:]): (validate): Deleted. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration processPool]): (-[WKWebViewConfiguration setProcessPool:]): (-[WKWebViewConfiguration preferences]): (-[WKWebViewConfiguration setPreferences:]): (-[WKWebViewConfiguration userContentController]): (-[WKWebViewConfiguration setUserContentController:]): (-[WKWebViewConfiguration websiteDataStore]): (-[WKWebViewConfiguration setWebsiteDataStore:]): (-[WKWebViewConfiguration
[webkit-changes] [WebKit/WebKit] 29b1ce: Simplify use of WKWebViewContentProviderRegistry o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 29b1ce3d4b3f123118c251175d50cdf2dbce9453 https://github.com/WebKit/WebKit/commit/29b1ce3d4b3f123118c251175d50cdf2dbce9453 Author: Alex Christensen Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationInternal.h M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm M Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.h M Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in Log Message: --- Simplify use of WKWebViewContentProviderRegistry on iOS https://bugs.webkit.org/show_bug.cgi?id=271397 rdar://125177028 Reviewed by Tim Horton. WKWebViewContentProviderRegistry is a small and simple class that allows a WKWebView to get an ObjC class from a MIME type based on its preferences. It does not need to be a member of WKWebViewConfiguration. It does not need to know about its pages. It does not need to add MIME types with the WebPage::AddMIMETypeWithCustomContentProvider message because all the MIME types are sent in WebPageCreationParameters's mimeTypesWithCustomContentProviders. * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _initializeWithConfiguration:]): (-[WKWebView dealloc]): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration setLimitsNavigationsToAppBoundDomains:]): (-[WKWebViewConfiguration _contentProviderRegistry]): Deleted. (-[WKWebViewConfiguration _setContentProviderRegistry:]): Deleted. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationInternal.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h: * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _contentProviderRegistry]): (-[WKWebView _setHasCustomContentView:loadedMIMEType:]): (-[WKWebView _isDisplayingPDF]): * Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.h: * Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm: (-[WKWebViewContentProviderRegistry registerProvider:forMIMEType:]): (-[WKWebViewContentProviderRegistry addPage:]): Deleted. (-[WKWebViewContentProviderRegistry removePage:]): Deleted. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::addMIMETypeWithCustomContentProvider): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::addMIMETypeWithCustomContentProvider): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: Canonical link: https://commits.webkit.org/276486@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b2db74: Move more ivars from WKWebViewConfiguration to API...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b2db7454f86da1a03978a6d4460b02c8b9245558 https://github.com/WebKit/WebKit/commit/b2db7454f86da1a03978a6d4460b02c8b9245558 Author: Alex Christensen Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M Source/WebKit/SourcesCocoa.txt M Source/WebKit/UIProcess/API/APIPageConfiguration.h A Source/WebKit/UIProcess/API/Cocoa/APIPageConfigurationCocoa.mm M Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationInternal.h M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Move more ivars from WKWebViewConfiguration to API::PageConfiguration https://bugs.webkit.org/show_bug.cgi?id=271405 rdar://125186260 Reviewed by Charlie Wolfe. * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::inlineMediaPlaybackRequiresPlaysInlineAttribute const): (API::PageConfiguration::setInlineMediaPlaybackRequiresPlaysInlineAttribute): (API::PageConfiguration::allowsInlineMediaPlaybackAfterFullscreen const): (API::PageConfiguration::setAllowsInlineMediaPlaybackAfterFullscreen): (API::PageConfiguration::mediaDataLoadsAutomatically const): (API::PageConfiguration::setMediaDataLoadsAutomatically): (API::PageConfiguration::dragLiftDelay const): (API::PageConfiguration::setDragLiftDelay): (API::PageConfiguration::textInteractionGesturesEnabled const): (API::PageConfiguration::setTextInteractionGesturesEnabled): (API::PageConfiguration::longPressActionsEnabled const): (API::PageConfiguration::setLongPressActionsEnabled): (API::PageConfiguration::systemPreviewEnabled const): (API::PageConfiguration::setSystemPreviewEnabled): (API::PageConfiguration::shouldDecidePolicyBeforeLoadingQuickLookPreview const): (API::PageConfiguration::setShouldDecidePolicyBeforeLoadingQuickLookPreview): * Source/WebKit/UIProcess/API/Cocoa/APIPageConfigurationCocoa.mm: Added. (API::PageConfiguration::Data::defaultShouldDecidePolicyBeforeLoadingQuickLookPreview): (API::PageConfiguration::Data::defaultDragLiftDelay): * Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (toDragLiftDelay): (toWKDragLiftDelay): (fromWKDragLiftDelay): (-[WKWebViewConfiguration init]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration _inlineMediaPlaybackRequiresPlaysInlineAttribute]): (-[WKWebViewConfiguration _setInlineMediaPlaybackRequiresPlaysInlineAttribute:]): (-[WKWebViewConfiguration _allowsInlineMediaPlaybackAfterFullscreen]): (-[WKWebViewConfiguration _setAllowsInlineMediaPlaybackAfterFullscreen:]): (-[WKWebViewConfiguration _dragLiftDelay]): (-[WKWebViewConfiguration _setDragLiftDelay:]): (-[WKWebViewConfiguration _longPressActionsEnabled]): (-[WKWebViewConfiguration _setLongPressActionsEnabled:]): (-[WKWebViewConfiguration _systemPreviewEnabled]): (-[WKWebViewConfiguration _setSystemPreviewEnabled:]): (-[WKWebViewConfiguration _shouldDecidePolicyBeforeLoadingQuickLookPreview]): (-[WKWebViewConfiguration _setShouldDecidePolicyBeforeLoadingQuickLookPreview:]): (-[WKWebViewConfiguration _mediaDataLoadsAutomatically]): (-[WKWebViewConfiguration _setMediaDataLoadsAutomatically:]): (-[WKWebViewConfiguration _textInteractionGesturesEnabled]): (-[WKWebViewConfiguration _setTextInteractionGesturesEnabled:]): (defaultShouldDecidePolicyBeforeLoadingQuickLookPreview): Deleted. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationInternal.h: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/276517@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f3a782: Move more ivars from WKWebViewConfiguration to API...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f3a7825e8d6e739ddbcda9db8f7b1a1c992843c6 https://github.com/WebKit/WebKit/commit/f3a7825e8d6e739ddbcda9db8f7b1a1c992843c6 Author: Alex Christensen Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/APIPageConfiguration.h M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- Move more ivars from WKWebViewConfiguration to API::PageConfiguration https://bugs.webkit.org/show_bug.cgi?id=271438 Reviewed by Charlie Wolfe. * Source/WebKit/UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::attachmentFileWrapperClass const): (API::PageConfiguration::setAttachmentFileWrapperClass): (API::PageConfiguration::additionalSupportedImageTypes const): (API::PageConfiguration::setAdditionalSupportedImageTypes): (API::PageConfiguration::applePayEnabled const): (API::PageConfiguration::setApplePayEnabled): (API::PageConfiguration::appHighlightsEnabled const): (API::PageConfiguration::setAppHighlightsEnabled): (API::PageConfiguration::groupIdentifier const): (API::PageConfiguration::setGroupIdentifier): (API::PageConfiguration::mediaContentTypesRequiringHardwareSupport const): (API::PageConfiguration::setMediaContentTypesRequiringHardwareSupport): (API::PageConfiguration::applicationNameForUserAgent const): (API::PageConfiguration::setApplicationNameForUserAgent): (API::PageConfiguration::sampledPageTopColorMaxDifference const): (API::PageConfiguration::setSampledPageTopColorMaxDifference): (API::PageConfiguration::sampledPageTopColorMinHeight const): (API::PageConfiguration::setSampledPageTopColorMinHeight): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]): (-[WKWebViewConfiguration encodeWithCoder:]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration _applicationNameForDesktopUserAgent]): (-[WKWebViewConfiguration applicationNameForUserAgent]): (-[WKWebViewConfiguration setApplicationNameForUserAgent:]): (-[WKWebViewConfiguration _groupIdentifier]): (-[WKWebViewConfiguration _setGroupIdentifier:]): (-[WKWebViewConfiguration _attachmentFileWrapperClass]): (-[WKWebViewConfiguration _setAttachmentFileWrapperClass:]): (-[WKWebViewConfiguration _isControlledByAutomation]): (-[WKWebViewConfiguration _setControlledByAutomation:]): (-[WKWebViewConfiguration _applePayEnabled]): (-[WKWebViewConfiguration _setApplePayEnabled:]): (-[WKWebViewConfiguration _mediaContentTypesRequiringHardwareSupport]): (-[WKWebViewConfiguration _setMediaContentTypesRequiringHardwareSupport:]): (-[WKWebViewConfiguration _additionalSupportedImageTypes]): (-[WKWebViewConfiguration _setAdditionalSupportedImageTypes:]): (-[WKWebViewConfiguration _setAppHighlightsEnabled:]): (-[WKWebViewConfiguration _appHighlightsEnabled]): (-[WKWebViewConfiguration _setSampledPageTopColorMaxDifference:]): (-[WKWebViewConfiguration _sampledPageTopColorMaxDifference]): (-[WKWebViewConfiguration _setSampledPageTopColorMinHeight:]): (-[WKWebViewConfiguration _sampledPageTopColorMinHeight]): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): Canonical link: https://commits.webkit.org/276532@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cf4a98: Move remaining ivars from WKWebViewConfiguration t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf4a98a316fb56c1d99211c7d5542233c8784398 https://github.com/WebKit/WebKit/commit/cf4a98a316fb56c1d99211c7d5542233c8784398 Author: Alex Christensen Date: 2024-03-22 (Fri, 22 Mar 2024) Changed paths: M Source/WebKit/Shared/API/Cocoa/WKDataDetectorTypesInternal.h M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp M Source/WebKit/UIProcess/API/APIPageConfiguration.h M Source/WebKit/UIProcess/API/Cocoa/APIPageConfigurationCocoa.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm M Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm Log Message: --- Move remaining ivars from WKWebViewConfiguration to API::PageConfiguration https://bugs.webkit.org/show_bug.cgi?id=271451 rdar://125216495 Reviewed by Tim Horton. * Source/WebKit/Shared/API/Cocoa/WKDataDetectorTypesInternal.h: (toWKDataDetectorTypes): * Source/WebKit/UIProcess/API/APIPageConfiguration.cpp: (API::PageConfiguration::setRelatedPage): (API::PageConfiguration::setPageToCloneSessionStorageFrom): (API::PageConfiguration::alternateWebViewForNavigationGestures const): (API::PageConfiguration::setAlternateWebViewForNavigationGestures): * Source/WebKit/UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::dataDetectorTypes const): (API::PageConfiguration::setDataDetectorTypes): (API::PageConfiguration::selectionGranularity const): (API::PageConfiguration::setSelectionGranularity): (API::PageConfiguration::allowsPictureInPictureMediaPlayback const): (API::PageConfiguration::setAllowsPictureInPictureMediaPlayback): (API::PageConfiguration::mediaTypesRequiringUserActionForPlayback const): (API::PageConfiguration::setMediaTypesRequiringUserActionForPlayback): (API::PageConfiguration::suppressesIncrementalRendering const): (API::PageConfiguration::setSuppressesIncrementalRendering): (API::PageConfiguration::allowsAirPlayForMediaPlayback const): (API::PageConfiguration::setAllowsAirPlayForMediaPlayback): (API::PageConfiguration::ignoresViewportScaleLimits const): (API::PageConfiguration::setIgnoresViewportScaleLimits): (API::PageConfiguration::userInterfaceDirectionPolicy const): (API::PageConfiguration::setUserInterfaceDirectionPolicy): * Source/WebKit/UIProcess/API/Cocoa/APIPageConfigurationCocoa.mm: (API::PageConfiguration::Data::defaultMediaTypesRequiringUserActionForPlayback): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]): (-[WKWebViewConfiguration selectionGranularity]): (-[WKWebViewConfiguration setSelectionGranularity:]): (-[WKWebViewConfiguration setAllowsPictureInPictureMediaPlayback:]): (-[WKWebViewConfiguration allowsPictureInPictureMediaPlayback]): (-[WKWebViewConfiguration setIgnoresViewportScaleLimits:]): (-[WKWebViewConfiguration ignoresViewportScaleLimits]): (-[WKWebViewConfiguration setDataDetectorTypes:]): (-[WKWebViewConfiguration dataDetectorTypes]): (-[WKWebViewConfiguration userInterfaceDirectionPolicy]): (-[WKWebViewConfiguration setUserInterfaceDirectionPolicy:]): (-[WKWebViewConfiguration initWithCoder:]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration mediaTypesRequiringUserActionForPlayback]): (-[WKWebViewConfiguration setMediaTypesRequiringUserActionForPlayback:]): (-[WKWebViewConfiguration suppressesIncrementalRendering]): (-[WKWebViewConfiguration setSuppressesIncrementalRendering:]): (-[WKWebViewConfiguration setAllowsAirPlayForMediaPlayback:]): (-[WKWebViewConfiguration allowsAirPlayForMediaPlayback]): (-[WKWebViewConfiguration _relatedWebView]): (-[WKWebViewConfiguration _setRelatedWebView:]): (-[WKWebViewConfiguration _webViewToCloneSessionStorageFrom]): (-[WKWebViewConfiguration _setWebViewToCloneSessionStorageFrom:]): (-[WKWebViewConfiguration _alternateWebViewForNavigationGestures]): (-[WKWebViewConfiguration _setAlternateWebViewForNavigationGestures:]): Canonical link: https://commits.webkit.org/276554@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b7a780: Remove unnecessary SubframeProcessPageParameters c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b7a7805ab3a2a1b719af3112657934e837ee3df5 https://github.com/WebKit/WebKit/commit/b7a7805ab3a2a1b719af3112657934e837ee3df5 Author: Alex Christensen Date: 2024-03-22 (Fri, 22 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h Log Message: --- Remove unnecessary SubframeProcessPageParameters copy in WebPageProxy::creationParameters https://bugs.webkit.org/show_bug.cgi?id=271441 Reviewed by Charlie Wolfe. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): (WebKit::WebPageProxy::creationParametersForRemotePage): * Source/WebKit/UIProcess/WebPageProxy.h: Canonical link: https://commits.webkit.org/276555@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a66494: Make WKWebViewConfiguration a wrapper around API::...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a66494cd648255f4674c3aa5a133e81259a8db0b https://github.com/WebKit/WebKit/commit/a66494cd648255f4674c3aa5a133e81259a8db0b Author: Alex Christensen Date: 2024-03-22 (Fri, 22 Mar 2024) Changed paths: M Source/WebKit/Shared/Cocoa/APIObject.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationInternal.h Log Message: --- Make WKWebViewConfiguration a wrapper around API::PageConfiguration https://bugs.webkit.org/show_bug.cgi?id=271471 rdar://125240015 Reviewed by Tim Horton. * Source/WebKit/Shared/Cocoa/APIObject.mm: (API::Object::newObject): * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _initializeWithConfiguration:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration _apiObject]): (-[WKWebViewConfiguration copyPageConfiguration]): Deleted. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationInternal.h: Canonical link: https://commits.webkit.org/276566@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2e0302: Move API::PageConfiguration construction from plat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2e0302df3d680ce3b2e1289cd6caa8a51c4a3564 https://github.com/WebKit/WebKit/commit/2e0302df3d680ce3b2e1289cd6caa8a51c4a3564 Author: Alex Christensen Date: 2024-03-22 (Fri, 22 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/APIUIClient.cpp M Source/WebKit/UIProcess/API/APIUIClient.h M Source/WebKit/UIProcess/API/C/WKPage.cpp M Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp M Source/WebKit/UIProcess/Cocoa/UIDelegate.h M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- Move API::PageConfiguration construction from platform specific code to WebPageProxy::createNewPage https://bugs.webkit.org/show_bug.cgi?id=271486 rdar://125254796 Reviewed by Tim Horton. * Source/WebKit/UIProcess/API/APIUIClient.cpp: (API::UIClient::createNewPage): * Source/WebKit/UIProcess/API/APIUIClient.h: * Source/WebKit/UIProcess/API/C/WKPage.cpp: (WKPageSetPageUIClient): * Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp: * Source/WebKit/UIProcess/Cocoa/UIDelegate.h: * Source/WebKit/UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::UIClient::createNewPage): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::triggerBrowsingContextGroupSwitchForNavigation): (WebKit::WebPageProxy::createNewPage): Canonical link: https://commits.webkit.org/276574@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a4b39a: REGRESSION(276505@main) reloading after crashing r...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a4b39a8c7766b2eae64e5cc8676ab35483f18bc8 https://github.com/WebKit/WebKit/commit/a4b39a8c7766b2eae64e5cc8676ab35483f18bc8 Author: Alex Christensen Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- REGRESSION(276505@main) reloading after crashing registers RegistrableDomain as a public suffix https://bugs.webkit.org/show_bug.cgi?id=271662 rdar://125363034 Reviewed by Sihui Liu. topPrivatelyControlledDomain was actually unused, but what we should be sending as a public suffix should actually be a public suffix. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::launchProcessForReload): Canonical link: https://commits.webkit.org/276635@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eab787: Make window.open use correct process when called f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eab78766e024f6411cb60e10a3ed18b84e84aa30 https://github.com/WebKit/WebKit/commit/eab78766e024f6411cb60e10a3ed18b84e84aa30 Author: Alex Christensen Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp M Source/WebKit/UIProcess/API/APIPageConfiguration.h M Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.cpp M Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.h M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebProcessPool.cpp M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm Log Message: --- Make window.open use correct process when called from a site isolated iframe https://bugs.webkit.org/show_bug.cgi?id=271514 Reviewed by Charlie Wolfe. When JS calls window.open, WebPageProxy::createNewPage gives an API::PageConfiguration (which is now equivalent to a WKWebViewConfiguration) to the UIClient containing state that must be used to make the new WKWebView. Before site isolation, that state was just the related page, whose process must be shared to keep functionality working such as iframes with the same origin as the opener being able to directly access the opener's DOM. With site isolation, the state that is needed to keep this functionality working is the BrowsingContextGroup, which contains the maps of domains to processes, and the opener frame identifier, which needs to be used to put the opened frame initially in the same process as the opener while the opened frame contains only about:blank. From about:blank it can then use the BrowsingContextGroup to navigate to the correct process for any domain. Unfortunately, though, there is SPI to do tricky things with the related page, and WebKitTestRunner uses this SPI to retrofit an unrelated WKWebViewConfiguration into looking enough like the suggested WKWebViewConfiguration that WebKit accepts it and uses it correctly. In order to keep this working, I needed to make additional SPI to copy the site isolation state from one WKPageConfigurationRef to another. Conveninetly, WKPageConfigurationRef can now be converted to WKWebViewConfiguration using toll-free-bridging. It looks like all that work I did over the last week to clean up WKWebViewConfiguration is already paying off! I verified this fixes http/tests/site-isolation/iframe-and-window-open.html but only how we used to run it before 276416@main. Additional work is being done on our strategy for running existing layout tests to verify site isolation correctness. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Source/WebKit/UIProcess/API/APIPageConfiguration.cpp: (API::PageConfiguration::setBrowsingContextGroup): (API::PageConfiguration::openerFrameID const): (API::PageConfiguration::setOpenerFrameID): * Source/WebKit/UIProcess/API/APIPageConfiguration.h: * Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.cpp: (WKPageConfigurationCopySiteIsolationState): * Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::createNewPage): * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::createWebPage): * Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateOtherPage): Canonical link: https://commits.webkit.org/276636@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 072015: Remove unnecessary Vector copy in mapHostName
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 07201542805cb54b6385b71196040c2d6c10f3ef https://github.com/WebKit/WebKit/commit/07201542805cb54b6385b71196040c2d6c10f3ef Author: Alex Christensen Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WTF/wtf/URLHelpers.cpp Log Message: --- Remove unnecessary Vector copy in mapHostName https://bugs.webkit.org/show_bug.cgi?id=271440 Reviewed by Sihui Liu. * Source/WTF/wtf/URLHelpers.cpp: (WTF::URLHelpers::mapHostName): Canonical link: https://commits.webkit.org/276638@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a06598: Expose more serialized type metadata to IPC test API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a065988161d6135e409d797948336b4c5c1b977a https://github.com/WebKit/WebKit/commit/a065988161d6135e409d797948336b4c5c1b977a Author: Alex Christensen Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/GraphicsContextGL.h M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp M Source/WebKit/Shared/Cocoa/CoreIPCNSValue.serialization.in M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in M Source/WebKit/Shared/ProcessQualified.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemoteProperties.serialization.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: --- Expose more serialized type metadata to IPC test API https://bugs.webkit.org/show_bug.cgi?id=271422 Reviewed by Sihui Liu. * Source/WebCore/platform/graphics/GraphicsContextGL.h: * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in: * Source/WebKit/Scripts/webkit/messages.py: (serialized_identifiers): (headers_for_type): * Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp: (IPC::serializedIdentifiers): * Source/WebKit/Shared/Cocoa/CoreIPCNSValue.serialization.in: * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in: * Source/WebKit/Shared/ProcessQualified.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemoteProperties.serialization.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: Canonical link: https://commits.webkit.org/276639@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cf3a32: Fix some watchOS builds after 276639@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf3a32feaad71981575de9c509fe8a850ea3503a https://github.com/WebKit/WebKit/commit/cf3a32feaad71981575de9c509fe8a850ea3503a Author: Alex Christensen Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in Log Message: --- Fix some watchOS builds after 276639@main https://bugs.webkit.org/show_bug.cgi?id=271670 rdar://125372380 Unreviewed. OSStatus isn't the same exact type as int32_t on all platforms. Remove this and I'll worry about it later. * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in: Canonical link: https://commits.webkit.org/276652@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f01c61: Simplify WKWebViewConfiguration handling in WebKit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f01c6123341051af8531de0eb3e7158c3211b2bd https://github.com/WebKit/WebKit/commit/f01c6123341051af8531de0eb3e7158c3211b2bd Author: Alex Christensen Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.cpp M Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.h M Tools/WebKitTestRunner/PlatformWebView.h M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm M Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm M Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm Log Message: --- Simplify WKWebViewConfiguration handling in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=271671 rdar://125373165 Reviewed by Charlie Wolfe. Now that WKWebViewConfiguration and WKPageConfigurationRef are equivalent, we can remove some of the strange Cocoa-specific stuff in WebKitTestRunner. * Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.cpp: (WKPageConfigurationSetPortsForUpgradingInsecureSchemeForTesting): (WKPageConfigurationCopySiteIsolationState): Deleted. * Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.h: * Tools/WebKitTestRunner/PlatformWebView.h: * Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateWebView): (WTR::TestController::platformCreateOtherPage): * Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::PlatformWebView): * Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::PlatformWebView): Canonical link: https://commits.webkit.org/276692@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 02eeb8: Fix http/tests/workers/service/openwindow-from-not...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 02eeb88eab8d658f76929689ddde92e813422b9e https://github.com/WebKit/WebKit/commit/02eeb88eab8d658f76929689ddde92e813422b9e Author: Alex Christensen Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations M Tools/WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm Log Message: --- Fix http/tests/workers/service/openwindow-from-notification-click.html https://bugs.webkit.org/show_bug.cgi?id=271736 rdar://125438183 Reviewed by Charlie Wolfe. The PlatformWebView ctor now assumes the configuration is non-null. Make this true. * LayoutTests/platform/mac-wk2/TestExpectations: * Tools/WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm: (-[TestWebsiteDataStoreDelegate websiteDataStore:openWindow:fromServiceWorkerOrigin:completionHandler:]): * tmp: Added. Canonical link: https://commits.webkit.org/276721@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 465201: Introduce RemoteFrame support for testRunner.dumpC...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 46520106b8b99191f7af6b78883c380f883178f7 https://github.com/WebKit/WebKit/commit/46520106b8b99191f7af6b78883c380f883178f7 Author: Alex Christensen Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M LayoutTests/http/tests/site-isolation/notify-done-expected.txt M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp Log Message: --- Introduce RemoteFrame support for testRunner.dumpChildFramesAsText https://bugs.webkit.org/show_bug.cgi?id=271724 rdar://125437971 Reviewed by Charlie Wolfe. This is the first of at least two steps to get tests like http/tests/security/window-properties-pass.html passing with --site-isolation. If the frame text is not in the current process, send a message to the process that contains the frame to get its text. FrameTree::uniqueName is not hooked up correctly so the test output isn't identical yet, but this makes more than 0 output. The separate asDocumentElement test wasn't actually useful because it was redundant with the same test done in WebFrame::innerText, so it was removed. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::renderTreeAsTextForTesting): (WebKit::WebPageProxy::frameTextForTesting): (WebKit::WebPageProxy::renderTreeAsText): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameCopyInnerText): Deleted. * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageCopyFrameTextForTesting): * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h: * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp: (WebKit::WebRemoteFrameClient::renderTreeAsText): * Source/WebKit/WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::innerText const): (WebKit::WebFrame::frameTextForTesting): * Source/WebKit/WebProcess/WebPage/WebFrame.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::frameTextForTestingIncludingSubframes): (WebKit::WebPage::renderTreeAsTextForTesting): (WebKit::WebPage::frameTextForTesting): (WebKit::WebPage::renderTreeAsText): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dumpAllFramesText): (WTR::InjectedBundlePage::dump): (WTR::hasDocumentElement): Deleted. (WTR::dumpFrameText): Deleted. (WTR::dumpDescendantFramesText): Deleted. Canonical link: https://commits.webkit.org/276723@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0b216b: REGRESSION(276827@main) Retain frame request queue...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0b216b7fee1af5547c9b478998c8ea3c412e6489 https://github.com/WebKit/WebKit/commit/0b216b7fee1af5547c9b478998c8ea3c412e6489 Author: Alex Christensen Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: A LayoutTests/fast/images/protected-image-queue-expected.txt A LayoutTests/fast/images/protected-image-queue.html M Source/WebCore/platform/graphics/ImageFrameWorkQueue.cpp Log Message: --- REGRESSION(276827@main) Retain frame request queue in ImageFrameWorkQueue::start https://bugs.webkit.org/show_bug.cgi?id=271979 rdar://125721264 Reviewed by Said Abou-Hallawa. Protecting the ImageFrameWorkQueue is not sufficient because the RequestQueue can be deallocated separately. Restore the protection of the queue. * LayoutTests/fast/images/protected-image-queue-expected.txt: Added. * LayoutTests/fast/images/protected-image-queue.html: Added. * Source/WebCore/platform/graphics/ImageFrameWorkQueue.cpp: (WebCore::ImageFrameWorkQueue::start): Canonical link: https://commits.webkit.org/276906@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a92549: Send WebPage::PreferencesDidChange to all processe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a925498ca136fcd8de543d406e3cab73c876a4f2 https://github.com/WebKit/WebKit/commit/a925498ca136fcd8de543d406e3cab73c876a4f2 Author: Alex Christensen Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- Send WebPage::PreferencesDidChange to all processes with site isolation enabled https://bugs.webkit.org/show_bug.cgi?id=271999 rdar://125740635 Reviewed by Charlie Wolfe. I also added test SPI to evaluate JS in a child frame without a user gesture so I could use the success of window.open without a user gesture to test the success of updating preferences in an iframe's process. * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _evaluateJavaScript:withSourceURL:inFrame:inContentWorld:withUserGesture:completionHandler:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::preferencesDidChange): * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/276922@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aae48f: Fix internal build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aae48f4337568b498b0afd6b57066ba2807d65f3 https://github.com/WebKit/WebKit/commit/aae48f4337568b498b0afd6b57066ba2807d65f3 Author: Alex Christensen Date: 2024-04-02 (Tue, 02 Apr 2024) Changed paths: M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm Log Message: --- Fix internal build https://bugs.webkit.org/show_bug.cgi?id=272049 rdar://125798297 Unreviewed. * Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm: (WebKit::UnifiedTextReplacementController::getTextIndicatorForID): Canonical link: https://commits.webkit.org/276956@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b60e09: Handle EncodeRequestBody attribute when generating...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b60e09bdf50654d47a5a6f4475739c55e931678d https://github.com/WebKit/WebKit/commit/b60e09bdf50654d47a5a6f4475739c55e931678d Author: Alex Christensen Date: 2024-04-02 (Tue, 02 Apr 2024) Changed paths: M Source/WebKit/Scripts/generate-serializers.py M Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp Log Message: --- Handle EncodeRequestBody attribute when generating serialized type metadata https://bugs.webkit.org/show_bug.cgi?id=272050 rdar://125793485 Reviewed by Brady Eidson. * Source/WebKit/Scripts/generate-serializers.py: (generate_one_serialized_type_info): * Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp: (WebKit::allSerializedTypes): Canonical link: https://commits.webkit.org/276964@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe895b: Expose correct ProcessQualified metadata to IPC te...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe895b4254ce16d774d9b8d50b74cef117ff5f07 https://github.com/WebKit/WebKit/commit/fe895b4254ce16d774d9b8d50b74cef117ff5f07 Author: Alex Christensen Date: 2024-04-02 (Tue, 02 Apr 2024) Changed paths: M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp M Source/WebKit/Shared/ProcessQualified.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: --- Expose correct ProcessQualified metadata to IPC test API https://bugs.webkit.org/show_bug.cgi?id=272058 rdar://125804590 Reviewed by Brady Eidson. * Source/WebKit/Scripts/webkit/messages.py: (serialized_identifiers): (headers_for_type): * Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp: (IPC::serializedIdentifiers): * Source/WebKit/Shared/ProcessQualified.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: (SerializedTypeInfo)): Canonical link: https://commits.webkit.org/276980@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b7a0ef: Expose correct enum values to IPC test API for neg...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b7a0efc2c0d91301c4966c434aea9a28b29a5778 https://github.com/WebKit/WebKit/commit/b7a0efc2c0d91301c4966c434aea9a28b29a5778 Author: Alex Christensen Date: 2024-04-02 (Tue, 02 Apr 2024) Changed paths: M Source/WebKit/Scripts/generate-serializers.py M Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: --- Expose correct enum values to IPC test API for negative values https://bugs.webkit.org/show_bug.cgi?id=272061 Reviewed by Abrar Rahman Protyasha. * Source/WebKit/Scripts/generate-serializers.py: (generate_serialized_type_info): * Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp: (WebKit::enumValueForIPCTestAPI): (WebKit::allSerializedTypes): Deleted. (WebKit::allSerializedEnums): Deleted. * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: (SerializedTypeInfo)): Canonical link: https://commits.webkit.org/276986@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 664b7b: Expose more type metadata to IPC test API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 664b7bf627029f4ce7a114f132974308189ab7b6 https://github.com/WebKit/WebKit/commit/664b7bf627029f4ce7a114f132974308189ab7b6 Author: Alex Christensen Date: 2024-04-03 (Wed, 03 Apr 2024) Changed paths: M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in M Source/WebCore/platform/PlatformMediaError.h M Source/WebCore/svg/SVGPreserveAspectRatioValue.h M Source/WebKit/GPUProcess/graphics/PathSegment.serialization.in M Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/Shared/cf/CoreIPCCGColorSpace.serialization.in M Source/WebKit/UIProcess/WebProcessProxy.messages.in M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemoteMessageReceiver.messages.in M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Source/WebKit/WebProcess/WebProcess.messages.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: --- Expose more type metadata to IPC test API https://bugs.webkit.org/show_bug.cgi?id=272071 Reviewed by Brady Eidson. * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in: * Source/WebCore/platform/PlatformMediaError.h: * Source/WebCore/svg/SVGPreserveAspectRatioValue.h: * Source/WebKit/GPUProcess/graphics/PathSegment.serialization.in: * Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in: * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in: * Source/WebKit/Scripts/webkit/messages.py: (headers_for_type): * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/Shared/cf/CoreIPCCGColorSpace.serialization.in: * Source/WebKit/UIProcess/WebProcessProxy.messages.in: * Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in: * Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemoteMessageReceiver.messages.in: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: * Source/WebKit/WebProcess/WebProcess.messages.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: (SerializedTypeInfo)): Canonical link: https://commits.webkit.org/277017@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 95a0fa: Functionally fix fast/loader/window-open-to-invali...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 95a0fa3e3d5ee8a82829bb5939c033ac88fc6cd8 https://github.com/WebKit/WebKit/commit/95a0fa3e3d5ee8a82829bb5939c033ac88fc6cd8 Author: Alex Christensen Date: 2024-04-03 (Wed, 03 Apr 2024) Changed paths: M Source/WebCore/page/LocalDOMWindow.cpp M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm M Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h Log Message: --- Functionally fix fast/loader/window-open-to-invalid-url-calls-policy-delegate.html with --site-isolation https://bugs.webkit.org/show_bug.cgi?id=272092 Reviewed by Per Arne Vollan. This fixes two issues. The first is that the test calls window.open with _top as the second parameter, and when running with --site-isolation the top frame is a RemoteFrame, so I moved a few dynamicDowncast calls from LocalDOMWindow::open to only be where we really need a LocalFrame. The second issue is that we were calling WebProcessProxy::fontdMachExtensionHandles multiple times for the same process, which caused an assertion and is unnecessary. Fix that by only calling it once per process, since it is a process-global thing. This makes the test pass except for another change needed to printNavigationErrorMessage which I'll do in a separate PR because that will need to remove the frame URL of the frame we attempted to navigate, which is unavailable and should not be available if it is a RemoteFrame. I'll do that in a separate PR because it'll require updating 64 test expectations files. * Source/WebCore/page/LocalDOMWindow.cpp: (WebCore::LocalDOMWindow::open): * Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::switchFromStaticFontRegistryToUserFontRegistry): * Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm: (WebKit::WebProcessProxy::fontdMachExtensionHandles): (WebKit::WebProcessProxy::fontdMachExtensionHandles const): Deleted. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): * Source/WebKit/UIProcess/WebProcessProxy.h: Canonical link: https://commits.webkit.org/277018@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 38a194: Implement printNavigationErrorMessage with site is...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 38a194b1080ba3d5db300fabc999b8e8fc30225e https://github.com/WebKit/WebKit/commit/38a194b1080ba3d5db300fabc999b8e8fc30225e Author: Alex Christensen Date: 2024-04-04 (Thu, 04 Apr 2024) Changed paths: M LayoutTests/fast/loader/window-open-to-invalid-url-calls-policy-delegate.html M LayoutTests/platform/mac-site-isolation/TestExpectations M Source/WebCore/dom/Document.cpp M Source/WebCore/page/Frame.h M Source/WebCore/page/LocalFrame.cpp M Source/WebCore/page/LocalFrame.h M Source/WebCore/page/RemoteFrame.cpp M Source/WebCore/page/RemoteFrame.h M Source/WebCore/page/RemoteFrameClient.h M Source/WebKit/UIProcess/API/C/WKPageInjectedBundleClient.h M Source/WebKit/UIProcess/WebPageInjectedBundleClient.cpp M Source/WebKit/UIProcess/WebPageInjectedBundleClient.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Tools/DumpRenderTree/TestRunner.cpp M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h M Tools/WebKitTestRunner/TestController.cpp Log Message: --- Implement printNavigationErrorMessage with site isolation https://bugs.webkit.org/show_bug.cgi?id=272135 rdar://125885740 Reviewed by Charlie Wolfe. printNavigationErrorMessage would be easy to implement if we didn't want to print the URL of the frame whose navigation was unsuccessfully attempted. Having both URLs is useful for the web inspector, but if the target frame is a RemoteFrame, then the current process does not and should not have the URL. To keep the test output the same and keep the inspector log useful, if the Frame is a RemoteFrame, then send an asynchronous message to a process that has the URL before printing to the console. When we do this, we now have console output that doesn't appear immediately. We have to wait for it to arrive. I implemented this by adding TestRunner.flushConsoleLogs, which just needs to send a round trip message to the UI process. Unfortunately, in order to have the reply sent to the right process, we can't just use WKPagePostMessageToInjectedBundle like we have so far because that always sends a message to the main frame's process. We need a new bundle SPI, WKBundlePagePostMessageWithAsyncReply, which sends the reply to whatever process sent the message. Migrating other use of cacheTestRunnerCallback and callTestRunnerCallback to this will probably make our test infrastructure a little more site-isolation-friendly. * LayoutTests/fast/loader/window-open-to-invalid-url-calls-policy-delegate.html: * LayoutTests/platform/mac-site-isolation/TestExpectations: * Source/WebCore/dom/Document.cpp: (WebCore::printNavigationErrorMessage): (WebCore::Document::canNavigate): (WebCore::Document::canNavigateInternal): * Source/WebCore/page/Frame.h: * Source/WebCore/page/LocalFrame.cpp: (WebCore::LocalFrame::documentURLForConsoleLog): * Source/WebCore/page/LocalFrame.h: * Source/WebCore/page/RemoteFrame.cpp: (WebCore::RemoteFrame::documentURLForConsoleLog): * Source/WebCore/page/RemoteFrame.h: * Source/WebCore/page/RemoteFrameClient.h: * Source/WebKit/UIProcess/API/C/WKPageInjectedBundleClient.h: * Source/WebKit/UIProcess/WebPageInjectedBundleClient.cpp: (WebKit::WebPageInjectedBundleClient::didReceiveAsyncMessageFromInjectedBundle): * Source/WebKit/UIProcess/WebPageInjectedBundleClient.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleMessageWithAsyncReply): (WebKit::WebPageProxy::documentURLForConsoleLog): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePagePostMessageWithAsyncReply): * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h: * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp: (WebKit::WebRemoteFrameClient::documentURLForConsoleLog): * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::postMessageWithAsyncReply): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Tools/DumpRenderTree/TestRunner.cpp: (flushConsoleLogsCallback): (TestRunner::stati
[webkit-changes] [WebKit/WebKit] 6aed92: Expose more type metadata to IPC test API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6aed9201ded09bfce33bd22143168e74786782c9 https://github.com/WebKit/WebKit/commit/6aed9201ded09bfce33bd22143168e74786782c9 Author: Alex Christensen Date: 2024-04-04 (Thu, 04 Apr 2024) Changed paths: M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in M Source/WebCore/Modules/notifications/NotificationDirection.h M Source/WebCore/Modules/notifications/NotificationOptionsPayloadCocoa.mm M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/svg/SVGUnitTypes.h M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in M Source/WebKit/GPUProcess/GPUProcess.messages.in M Source/WebKit/GPUProcess/graphics/PathSegment.serialization.in M Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.messages.in M Source/WebKit/ModelProcess/ModelProcess.messages.in M Source/WebKit/NetworkProcess/NetworkProcess.messages.in M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp M Source/WebKit/Scripts/webkit/tests/TestWithStreamServerConnectionHandle.messages.in M Source/WebKit/Scripts/webkit/tests/TestWithStreamServerConnectionHandleMessages.h M Source/WebKit/Shared/ContextMenuContextData.serialization.in M Source/WebKit/Shared/IPCTester.messages.in M Source/WebKit/Shared/WTFArgumentCoders.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.messages.in M Source/WebKit/UIProcess/WebProcessProxy.messages.in M Source/WebKit/WebProcess/Inspector/WebInspector.messages.in M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: --- Expose more type metadata to IPC test API https://bugs.webkit.org/show_bug.cgi?id=272139 rdar://125891742 Reviewed by Brady Eidson. Also add the actually correct test expectations for the test I added in 276986@main and has been failing since then. * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in: * Source/WebCore/Modules/notifications/NotificationDirection.h: (WebCore::isValidNotificationDirection): * Source/WebCore/Modules/notifications/NotificationOptionsPayloadCocoa.mm: (WebCore::NotificationOptionsPayload::fromDictionary): * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/svg/SVGUnitTypes.h: * Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in: * Source/WebKit/GPUProcess/GPUProcess.messages.in: * Source/WebKit/GPUProcess/graphics/PathSegment.serialization.in: * Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in: * Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.messages.in: * Source/WebKit/ModelProcess/ModelProcess.messages.in: * Source/WebKit/NetworkProcess/NetworkProcess.messages.in: * Source/WebKit/Scripts/webkit/messages.py: (types_that_must_be_moved): (headers_for_type): * Source/WebKit/Shared/ContextMenuContextData.serialization.in: * Source/WebKit/Shared/IPCTester.messages.in: * Source/WebKit/Shared/WTFArgumentCoders.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.messages.in: * Source/WebKit/UIProcess/WebProcessProxy.messages.in: * Source/WebKit/WebProcess/Inspector/WebInspector.messages.in: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: (SerializedTypeInfo)): Canonical link: https://commits.webkit.org/277057@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
