[webkit-changes] [WebKit/WebKit] 156db6: [Grid] Separate out clearing of grid item overridi...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 156db6b0c1095bc94706507f6128b55baa0ab516
  
https://github.com/WebKit/WebKit/commit/156db6b0c1095bc94706507f6128b55baa0ab516
  Author: Sammy Gill 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  ---
  [Grid] Separate out clearing of grid item overriding sizes from 
computeAspectRatioDependentAndBaselineItems
https://bugs.webkit.org/show_bug.cgi?id=289989
rdar://147345726

Reviewed by Brandon Stewart.

One of the things that RenderGrid::computeAspectRatioDependentAndBaselineItems()
does currently is reset the overriding sizes of its grid items. This
needs to be done because overriding sizes are the mechanism used to set
the sizes of the grid item computed as a result of grid layout, so we
need to clear these values before we perform layout in order to avoid
using stale values.

However, I do not see a reason why this needs to be coupled with the
rest of the logic in computeAspectRatioDependentAndBaselineItems. Seeing
this code here is a bit confusing, and I think it would make more sense
to do this as early as possible before we perform any sort of grid
layout logic, so I think we should move this next to the couple of other
functions that are performing grid-specific tasks before layout.

* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::clearGridItemOverridingSizesBeforeLayout):
(WebCore::RenderGrid::layoutGrid):
(WebCore::RenderGrid::layoutMasonry):

Canonical link: https://commits.webkit.org/292343@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 19da6c: [JSC] Explicitly capture `outOfBounds` in lambda t...

[Yijia Huang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19da6c56338dc6cbd249ef2f76673fc103f0ecbb
  
https://github.com/WebKit/WebKit/commit/19da6c56338dc6cbd249ef2f76673fc103f0ecbb
  Author: Yijia Huang 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp

  Log Message:
  ---
  [JSC] Explicitly capture `outOfBounds` in lambda to fix structured binding 
issue
rdar://147378241
https://bugs.webkit.org/show_bug.cgi?id=290027

Reviewed by Yusuke Suzuki.

Some older versions of Clang (such as the one in Xcode 13) have a bug where
structured bindings (`auto [x, y] = ...;`) are not captured properly when using
default capture `[=]`. This causes compilation errors when `outOfBounds` is used
inside the lambda.

To resolve this, we explicitly capture `outOfBounds` as `outOfBoundsJump`
inside the lambda. This ensures that the `Jump` object is properly passed down
and avoids potential miscompilation issues. No functional change.

* Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::typedArrayLength):

Canonical link: https://commits.webkit.org/292346@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] beed55: IPInt try.table catch_all should pass sp=0 to retr...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: beed5500ee3fb85539153ffb107a7e18126adcad
  
https://github.com/WebKit/WebKit/commit/beed5500ee3fb85539153ffb107a7e18126adcad
  Author: Daniel Liu 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/JavaScriptCore/llint/InPlaceInterpreter.asm

  Log Message:
  ---
  IPInt try.table catch_all should pass sp=0 to retrieve_and_clear_exception
https://bugs.webkit.org/show_bug.cgi?id=289973
rdar://144331778

Reviewed by Yijia Huang.

We use sp=0 to indicate that we shouldn't push the arguments onto the stack. 
However,
in this case, we mistakenly pass the real value of sp, meaning that we push 
arguments
to the stack when we shouldn't be. This causes incorrect values to be pushed 
onto the
stack during execution.

* Source/JavaScriptCore/llint/InPlaceInterpreter.asm:

Canonical link: https://commits.webkit.org/292326@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c7df23: [web-animations] REGRESSION(289928@main): Crash in...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7df234e8e3024e0bba88b9c78313b08877c4a74
  
https://github.com/WebKit/WebKit/commit/c7df234e8e3024e0bba88b9c78313b08877c4a74
  Author: Antoine Quint 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
A LayoutTests/webanimations/very-short-transition-crash-expected.txt
A LayoutTests/webanimations/very-short-transition-crash.html
M Source/WebCore/animation/AnimationTimeline.cpp

  Log Message:
  ---
  [web-animations] REGRESSION(289928@main): Crash in 
Style::TreeResolver::createAnimatedElementUpdate on auth.w3.org
https://bugs.webkit.org/show_bug.cgi?id=289980
rdar://146866523

Reviewed by Tim Nguyen.

We must make sure to remove effects from the keyframe effect stack that they're 
a member of
or we may end up in situations where an effect stack has null values in its 
effect list.

* LayoutTests/webanimations/very-short-transition-crash-expected.txt: Added.
* LayoutTests/webanimations/very-short-transition-crash.html: Added.
* Source/WebCore/animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::removeAnimation):

Canonical link: https://commits.webkit.org/292328@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9d14cb: Add Andrew Fryer as committer in contributors.json

[Andrew-Fryer]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9d14cb76c0aa5e86deabca515b423d2fab1bd0fe
  
https://github.com/WebKit/WebKit/commit/9d14cb76c0aa5e86deabca515b423d2fab1bd0fe
  Author: Andrew Fryer 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Add Andrew Fryer as committer in contributors.json
https://bugs.webkit.org/show_bug.cgi?id=288897
rdar://145897887

Reviewed by Ryan Reno.

Adding Andrew Fryer as committer in contributors.json

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/292313@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8e50dd: [Flex] Try to use cached logical height for flex i...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e50dd5daa89220c06096dc5961f86e225c165f7
  
https://github.com/WebKit/WebKit/commit/8e50dd5daa89220c06096dc5961f86e225c165f7
  Author: Sammy Gill 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percent-height-flex-items-cross-sizes-with-mutations-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percent-height-flex-items-cross-sizes-with-mutations.html
A PerformanceTests/Layout/flexbox-percent-height-cross-size-caching.html
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  ---
  [Flex] Try to use cached logical height for flex item's hypothetical cross 
size.
rdar://132034177
https://bugs.webkit.org/show_bug.cgi?id=276796

Reviewed by Alan Baradlay.

Currently, in RenderFlexibleBox::layoutAndPlaceFlexItems, we currently
call setNeedsLayout on a flex item if it has a relative logical height
(e.g. % min-height). In some cases, this can result in us doing some extra
work on subsequent layouts when we may not need to. Consider the
following piece of content:


  
  foobar


In this example, when we run flex layout, we do the following for each of
the flex items:

1.) Compute the main axis size
2.) Compute the hypothetical cross size
3.) Perform stretch alignment

For this type of content, we need to call layout() on each of the flex
items during both 2 and 3, and we should also note that calling layout on
 may be "expensive," for a variety
of reasons. On a subsequent layout, for example, if we change the content
inside the , we end up calling setNeedsLayout() on the first flex
item due to its % logical height and perform layout on it in order to
compute its hypothetical cross axis size again. During this process, we
unfortunately end up losing the item's stretched size and so must
stretch it again, which requires calling layout() on it one final time.

This patch attempts to mitigate this less than ideal behavior by
attempting to reuse a previously stored hypothetical cross axis size on
a subsequent layout. Rather than invalidating the flex item and
attempting to recompute it due to the % logical height, we can use the
previous value because the flexbox itself has an indefinite logical
height. This causes the flex items' % logical height to behave as auto,
and the resulting size will be based just off of its content.

RenderFlexibleBox already seems to cache the logical heights for its
flex items within a map called m_intrinsicContentLogicalHeights. This
cache is populated when a renderer goes through layout as one of its
first steps inside of updateLogicalHeight(). Inside of
RenderFlexibleBox::layoutAndPlaceItems: we will try not to invalidate the
flex item if the following are true for flex items with a relative
logical height:

1.) The main axis direction is the same as the flex item's inline direction
2.) The flexbox has an indefinite logical height
3.) We have a previously cached value for the cross size

Note that if the flex item's content may have been mutated, we will still
call layout on it due to the mutation, but during layout, we will end up
updating the cached value.

When the flexbox code needs the cross size of the flex item, for example,
to determine the size of the line, it will use
crossAxisIntrinsicExtentForFlexItem, which checks to see if it has a
cached cross size to use.

In order to use this cached size correctly we also needed to add some
extra invalidation when certain types of mutations occur. In this patch
we started removing percent logical height items from the cache in two
scenarios:

1.) When the computed logical height of the flexbox changes
2.) When a flexbox goes from being stretched to no longer stretching in
cases where itself participates in a flex or grid formatting context.

In order to accomplish 2 we allow RenderFlexibleBox to keep track of a
new bit that represents this type of damage. This bit will be set by
callers, in this case RenderFlexibleBox and RenderGrid, to inform the
flexbox that it is no longer being stretched. During flex layout it will
check to see if this bit is set and prune from the cache if it is.

On my M4 Max the included performance test went from ~590 runs/s to ~87K
runs/s.

I also included a new testcase which attempts to exercise this logic to
make sure we are computing the correct sizes and invalidating the cache
properly. This testcase includes a variety of subtests in which the
content is mutated in different ways.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percent-height-flex-items-cross-sizes-with-mutations-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percent-height-flex-items-cross-sizes-with-mutations.html:
 Added.
* PerformanceTests/Layout/flexbox-percent-height

[webkit-changes] [WebKit/WebKit] 654f0c: EnumTraits.h: error: no matching function for call...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 654f0c3862f7bae5bad07b4b451e10c9e9affa35
  
https://github.com/WebKit/WebKit/commit/654f0c3862f7bae5bad07b4b451e10c9e9affa35
  Author: Fujii Hironori 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WTF/wtf/EnumTraits.h

  Log Message:
  ---
  EnumTraits.h: error: no matching function for call to 'enumName' with Clang 20
https://bugs.webkit.org/show_bug.cgi?id=289669

Reviewed by Keith Miller.

Clang 20 couldn't compile EnumTraits.h.

> wtf/EnumTraits.h:212:33: note: candidate template ignored: invalid 
> explicitly-specified argument for template parameter 'V'

An invalid enum value can't be specifed to the template parameter `V`.

> template constexpr std::span enumName()

The upstream Magic Enum C++ has a template variable 
`is_enum_constexpr_static_cast_valid` to check a enum value is valid.


Imported the template variable.

* Source/WTF/wtf/EnumTraits.h:
(WTF::enumName):
(WTF::makeEnumNames):

Canonical link: https://commits.webkit.org/292321@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 75e9f6: Correct performance regression caused by additiona...

[Brent Fulgham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75e9f6372cbf1b0e384a46130bf757021e3c5959
  
https://github.com/WebKit/WebKit/commit/75e9f6372cbf1b0e384a46130bf757021e3c5959
  Author: Brent Fulgham 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/platform/graphics/Font.h

  Log Message:
  ---
  Correct performance regression caused by additional bounds check
https://bugs.webkit.org/show_bug.cgi?id=289969
rdar://147325714

Reviewed by Matthieu Dubet and Vitor Roriz.

When I landed PR-41576 (292198@main) I added an additional zero-length check on 
a
Glyph buffer. That branch slowed the patch enough to make it a 
performance-neutral change.

This patch hints to the branch predictor that the null buffer is unexpected, 
which
restores the 0.18% performance improvement.

* Source/WebCore/platform/graphics/Font.h:
(WebCore::Font::boundsForGlyphs const):

Canonical link: https://commits.webkit.org/292325@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8adb7f: text-spacing: text-autospace: Fast path for some A...

[Vitor Roriz]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8adb7f552d00f1d4cd617cd0077c52caab773dc0
  
https://github.com/WebKit/WebKit/commit/8adb7f552d00f1d4cd617cd0077c52caab773dc0
  Author: Vitor Roriz 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/platform/text/TextSpacing.cpp

  Log Message:
  ---
  text-spacing: text-autospace: Fast path for some ASCII characters in 
characterClass
https://bugs.webkit.org/show_bug.cgi?id=287357
rdar://144471199

Reviewed by Tim Nguyen.

This should cause no changes on behavior.

* Source/WebCore/platform/text/TextSpacing.cpp:
(WebCore::TextSpacing::characterClass):

Canonical link: https://commits.webkit.org/292324@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8a5808: Unreviewed non-unified source build fix 2025-03 (p...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a58081901bf0dd620c9a5446047d03f4d0a9adb
  
https://github.com/WebKit/WebKit/commit/8a58081901bf0dd620c9a5446047d03f4d0a9adb
  Author: Fujii Hironori 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/rendering/style/FillLayer.cpp

  Log Message:
  ---
  Unreviewed non-unified source build fix 2025-03 (part 15)
https://bugs.webkit.org/show_bug.cgi?id=288990

* Source/WebCore/rendering/style/FillLayer.cpp:

Canonical link: https://commits.webkit.org/292329@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 05b030: REGRESSION (292320@main): [ Mac OS WK2 Release ] f...

[Jay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05b0306d8a8af8551e5d7ca68dfafeee4cd61648
  
https://github.com/WebKit/WebKit/commit/05b0306d8a8af8551e5d7ca68dfafeee4cd61648
  Author: Jay Stfleur 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  REGRESSION (292320@main): [ Mac OS WK2 Release ] 
fast/webgpu/nocrash/fuzz-275228.html  is a consistent crash
https://bugs.webkit.org/show_bug.cgi?id=290020

Unreviewed test gardening.

Adding test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/292338@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c37172: Fix compile error on Windows due to invalid constexpr

[190n]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3717279a34a046c62d5bd225c79e75c08e390b5
  
https://github.com/WebKit/WebKit/commit/c3717279a34a046c62d5bd225c79e75c08e390b5
  Author: Ben Grant 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WTF/wtf/FileHandle.h

  Log Message:
  ---
  Fix compile error on Windows due to invalid constexpr
https://bugs.webkit.org/show_bug.cgi?id=290001

Reviewed by Fujii Hironori.

The functions in Win32HandleMarkableTraits cannot be constexpr because
they read invalidPlatformFileHandle, which is not constexpr, and cannot
be made constexpr because its initializer uses a cast equivalent to
reinterpret_cast.

The Windows definition of invalidPlatformFileHandle is also changed to
use the INVALID_HANDLE_VALUE macro instead of a copy of that macro's
logic.

* Source/WTF/wtf/FileHandle.h:
(WTF::FileSystemImpl::Win32HandleMarkableTraits::isEmptyValue):
(WTF::FileSystemImpl::Win32HandleMarkableTraits::emptyValue):

Canonical link: https://commits.webkit.org/292340@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 328759: Add support for generating a consumer for CSS prop...

[Sam Weinig]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3287590b319a716ad2cc268b3fd4bf51e48510b4
  
https://github.com/WebKit/WebKit/commit/3287590b319a716ad2cc268b3fd4bf51e48510b4
  Author: Sam Weinig 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/parser/CSSPropertyParser.cpp
R Source/WebCore/css/parser/CSSPropertyParserConsumer+Sizing.cpp
R Source/WebCore/css/parser/CSSPropertyParserConsumer+Sizing.h
M Source/WebCore/css/scripts/process-css-properties.py
M Source/WebCore/css/scripts/test/TestCSSProperties.json
M 
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyNames.gperf
M 
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyNames.h
M 
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyParsing.cpp
M 
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSStyleDeclaration+PropertyNames.idl
M 
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/StyleBuilderGenerated.cpp
M 
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/StyleInterpolationWrapperMap.cpp

  Log Message:
  ---
  Add support for generating a consumer for CSS properties that require custom 
types for ordered groups
https://bugs.webkit.org/show_bug.cgi?id=289872

Reviewed by Antti Koivisto.

Adds support for custom type annotations on ordered group terms.

This allows generation of:
contain-intrinsic-width
contain-intrinsic-height
contain-intrinsic-block-size
contain-intrinsic-inline-size

* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Sizing.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Sizing.h:
* Source/WebCore/css/scripts/process-css-properties.py:
* Source/WebCore/css/scripts/test/TestCSSProperties.json:
* 
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyNames.gperf:
* Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyNames.h:
* 
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyParsing.cpp:
* 
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSStyleDeclaration+PropertyNames.idl:
* 
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/StyleBuilderGenerated.cpp:
* 
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/StyleInterpolationWrapperMap.cpp:

Canonical link: https://commits.webkit.org/292310@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 74b216: IPInt table.fill should pop its operands from the ...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 74b216bb19b2119bed128ca004bb5d9b25bcfb9e
  
https://github.com/WebKit/WebKit/commit/74b216bb19b2119bed128ca004bb5d9b25bcfb9e
  Author: Daniel Liu 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M JSTests/wasm/ipint-tests/ipint-test-table-fill.js
M Source/JavaScriptCore/llint/InPlaceInterpreter64.asm
M Tools/lldb/debug_ipint.py

  Log Message:
  ---
  IPInt table.fill should pop its operands from the stack
https://bugs.webkit.org/show_bug.cgi?id=289916
rdar://144077195

Reviewed by Yusuke Suzuki.

During execution, table.fill uses the stack pointer to pass multiple arguments 
to the operation.
However, we do not move the stack pointer down in this case, meaning that we 
end up having three
extra values on the stack. This seems to be the only operation where we miss 
doing this.

* JSTests/wasm/ipint-tests/ipint-test-table-fill.js:
(from.string_appeared_here.import.as.assert.from.string_appeared_here.let.wat.module.type.i2i.func.param.i32.result.i32.table.table.5.funcref.elem.i32.const.0.0.0.0.0.0.func.export.string_appeared_here.result.i32.table.size.table.func.export.string_appeared_here.param.i32.i32.result.i32.i32.const.42.local.0.ref.null.func.local.1.table.fill.table.func.export.string_appeared_here.param.i32.result.i32.local.0.table.table.ref.is_null.async
 test):
(from.string_appeared_here.import.as.assert.from.string_appeared_here.let.wat.module.type.i2i.func.param.i32.result.i32.table.table.5.funcref.elem.i32.const.0.0.0.0.0.0.func.export.string_appeared_here.result.i32.table.size.table.func.export.string_appeared_here.param.i32.i32.local.0.ref.null.func.local.1.table.fill.table.func.export.string_appeared_here.param.i32.result.i32.local.0.table.table.ref.is_null.async
 test): Deleted.
* Source/JavaScriptCore/llint/InPlaceInterpreter64.asm:
* Tools/lldb/debug_ipint.py:
(print_stack):

Canonical link: https://commits.webkit.org/292309@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7ffc29: [GTK][WPE] Use _LIBCPP_HARDENING_MODE with newer l...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7ffc2962425803bb09767b655b0a5ef21546d0a7
  
https://github.com/WebKit/WebKit/commit/7ffc2962425803bb09767b655b0a5ef21546d0a7
  Author: Adrian Perez de Castro 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/cmake/OptionsCommon.cmake

  Log Message:
  ---
  [GTK][WPE] Use _LIBCPP_HARDENING_MODE with newer libc++ versions
https://bugs.webkit.org/show_bug.cgi?id=289953

Reviewed by Alicia Boya Garcia.

* Source/cmake/OptionsCommon.cmake: Add a new check for the libc++
  version, if it is 19 or newer, use the new _LIBCPP_HARDENING_MODE
  macro, otherwise for older versions keep _LIBCPP_ENABLE_ASSERTIONS.

Canonical link: https://commits.webkit.org/292304@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2c1054: Cherry-pick 292304@main (7ffc29624258). https://bu...

[Adrian Perez]

  Branch: refs/heads/webkitglib/2.48
  Home:   https://github.com/WebKit/WebKit
  Commit: 2c105443d41e5ce3de3a4cac2ed8a07ebd134459
  
https://github.com/WebKit/WebKit/commit/2c105443d41e5ce3de3a4cac2ed8a07ebd134459
  Author: Adrian Perez de Castro 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/cmake/OptionsCommon.cmake

  Log Message:
  ---
  Cherry-pick 292304@main (7ffc29624258). 
https://bugs.webkit.org/show_bug.cgi?id=289953

[GTK][WPE] Use _LIBCPP_HARDENING_MODE with newer libc++ versions
https://bugs.webkit.org/show_bug.cgi?id=289953

Reviewed by Alicia Boya Garcia.

* Source/cmake/OptionsCommon.cmake: Add a new check for the libc++
  version, if it is 19 or newer, use the new _LIBCPP_HARDENING_MODE
  macro, otherwise for older versions keep _LIBCPP_ENABLE_ASSERTIONS.

Canonical link: https://commits.webkit.org/292304@main

Canonical link: https://commits.webkit.org/290945.71@webkitglib/2.48



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7c43a3: [ macOS wk1 ] imported/w3c/web-platform-tests/vide...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7c43a3ed8031bd2b206375b764c5ae654207b54e
  
https://github.com/WebKit/WebKit/commit/7c43a3ed8031bd2b206375b764c5ae654207b54e
  Author: Youenn Fablet 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/platform/graphics/MediaPlayer.h

  Log Message:
  ---
  [ macOS wk1 ] 
imported/w3c/web-platform-tests/video-rvfc/request-video-frame-callback-dom.html
 is a flaky failure
rdar://145096680
https://bugs.webkit.org/show_bug.cgi?id=287904

Reviewed by Jean-Yves Avenard.

Before the patch, a video element could be GCed while a rvfc callback is 
registered.
To prevent this, we update HTMLMediaElement::virtualHasPendingActivity to check 
for the registration of a rvfc callback.

* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::virtualHasPendingActivity const):
* Source/WebCore/platform/graphics/MediaPlayer.h:

Canonical link: https://commits.webkit.org/292303@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c680ae: [HDR] Enable HDR display for CSS images

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c680aebea33bf4560a419eb2c30798a85c0b56f6
  
https://github.com/WebKit/WebKit/commit/c680aebea33bf4560a419eb2c30798a85c0b56f6
  Author: Said Abou-Hallawa 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/compositing/hdr/hdr-background-image-expected.txt
A LayoutTests/compositing/hdr/hdr-background-image.html
A LayoutTests/compositing/hdr/hdr-border-image-expected.txt
A LayoutTests/compositing/hdr/hdr-border-image.html
R LayoutTests/compositing/hdr/hdr-css-image.html
A LayoutTests/compositing/hdr/hdr-pseudo-before-image.html
A LayoutTests/fast/images/hdr-background-image-expected.html
A LayoutTests/fast/images/hdr-background-image.html
M LayoutTests/fast/images/hdr-basic-image-expected.html
M LayoutTests/fast/images/hdr-basic-image.html
A LayoutTests/fast/images/hdr-border-image-expected.html
A LayoutTests/fast/images/hdr-border-image.html
R LayoutTests/fast/images/hdr-css-image-expected.html
R LayoutTests/fast/images/hdr-css-image.html
A LayoutTests/fast/images/hdr-pseudo-before-image-expected.html
A LayoutTests/fast/images/hdr-pseudo-before-image.html
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/ios/compositing/hdr/hdr-basic-image-expected.txt
R LayoutTests/platform/ios/compositing/hdr/hdr-css-image-expected.txt
A 
LayoutTests/platform/ios/compositing/hdr/hdr-pseudo-before-image-expected.txt
M LayoutTests/platform/mac-wk2/TestExpectations
M LayoutTests/platform/mac-wk2/compositing/hdr/hdr-basic-image-expected.txt
R LayoutTests/platform/mac-wk2/compositing/hdr/hdr-css-image-expected.txt
A 
LayoutTests/platform/mac-wk2/compositing/hdr/hdr-pseudo-before-image-expected.txt
M Source/WebCore/platform/graphics/BitmapImage.cpp
M Source/WebCore/rendering/BackgroundPainter.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderImage.cpp
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/style/FillLayer.cpp
M Source/WebCore/rendering/style/FillLayer.h
M Source/WebCore/rendering/style/NinePieceImage.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.cpp

  Log Message:
  ---
  [HDR] Enable HDR display for CSS images
https://bugs.webkit.org/show_bug.cgi?id=289363
rdar://146509866

Reviewed by Simon Fraser.

The CSS images needs to be checked to decide whether rendererHasHDRContent()
returns true. Headroom::FromImage will be passed in the ImagePaintingOptions
when drawing the HDR CSS images.

RenderElement::imageContentChanged() will setHasHDRContent() on Document. It
will also mark contentChanged(Image) on its enclosingCompsitedLayer().

* LayoutTests/TestExpectations:
* LayoutTests/compositing/hdr/hdr-background-image-expected.txt: Renamed from 
LayoutTests/platform/ios/compositing/hdr/hdr-css-image-expected.txt.
* LayoutTests/compositing/hdr/hdr-background-image.html: Copied from 
LayoutTests/compositing/hdr/hdr-css-image.html.
* LayoutTests/compositing/hdr/hdr-border-image-expected.txt: Renamed from 
LayoutTests/platform/mac-wk2/compositing/hdr/hdr-css-image-expected.txt.
* LayoutTests/compositing/hdr/hdr-border-image.html: Copied from 
LayoutTests/compositing/hdr/hdr-css-image.html.
* LayoutTests/compositing/hdr/hdr-pseudo-before-image.html: Renamed from 
LayoutTests/compositing/hdr/hdr-css-image.html.
* LayoutTests/fast/images/hdr-background-image-expected.html: Renamed from 
LayoutTests/fast/images/hdr-css-image-expected.html.
* LayoutTests/fast/images/hdr-background-image.html: Copied from 
LayoutTests/fast/images/hdr-css-image.html.
* LayoutTests/fast/images/hdr-basic-image-expected.html:
* LayoutTests/fast/images/hdr-basic-image.html:
* LayoutTests/fast/images/hdr-border-image-expected.html: Copied from 
LayoutTests/fast/images/hdr-basic-image-expected.html.
* LayoutTests/fast/images/hdr-border-image.html: Copied from 
LayoutTests/fast/images/hdr-css-image.html.
* LayoutTests/fast/images/hdr-pseudo-before-image-expected.html: Copied from 
LayoutTests/fast/images/hdr-basic-image-expected.html.
* LayoutTests/fast/images/hdr-pseudo-before-image.html: Renamed from 
LayoutTests/fast/images/hdr-css-image.html.
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/ios/compositing/hdr/hdr-basic-image-expected.txt:
* 
LayoutTests/platform/ios/compositing/hdr/hdr-pseudo-before-image-expected.txt: 
Copied from 
LayoutTests/platform/ios/compositing/hdr/hdr-basic-image-expected.txt.
* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/platform/mac-wk2/compositing/hdr/hdr-basic-image-expected.txt:
* 
LayoutTests/platform/mac-wk2/compositing/hdr/hdr-pseudo-before-image-expected.txt:
 Copied from 
LayoutTests/platform/ios/compositing/hdr/hdr-basic-image-expected.txt.
* Source/WebCore/platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::drawPat

[webkit-changes] [WebKit/WebKit] 43de8b: REGRESSION (291478@main): [ macOS wk2 arm64 ] http...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 43de8b9eaabfc4556c0fd2ad28758c3f79b65549
  
https://github.com/WebKit/WebKit/commit/43de8b9eaabfc4556c0fd2ad28758c3f79b65549
  Author: Alex Christensen 
  Date:   2025-03-17 (Mon, 17 Mar 2025)

  Changed paths:
M LayoutTests/http/tests/site-isolation/fullscreen-expected.txt
M LayoutTests/http/tests/site-isolation/fullscreen.html
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp

  Log Message:
  ---
  REGRESSION (291478@main): [ macOS wk2 arm64 ] 
http/tests/site-isolation/fullscreen.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=289347
rdar://146487655

Reviewed by Charlie Wolfe.

When entering fullscreen on an element in a site-isolated iframe, 
enterFullScreenForOwnerElementsInOtherProcesses
applies CSS to the owner element in another process.  During a presentation 
update, Messages::WebPage::UpdateFrameSize
is sent to the child frame after the parent frame changes the child frame's 
size.  In order to get the correct
starting and ending size, this needs to happen before 
Messages::WebFullScreenManagerProxy::BeganEnterFullScreen
is sent.  To accomplish this, I await the presentation update earlier in the 
enterFullscreen pipeline when site
isolation is enabled in addition to waiting in 
WebFullScreenManagerProxy::beganEnterFullScreen.

* LayoutTests/http/tests/site-isolation/fullscreen-expected.txt:
* LayoutTests/http/tests/site-isolation/fullscreen.html:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):

Canonical link: https://commits.webkit.org/292289@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bb9256: [WebGPU] Range check built-in functions

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb9256b06c27e21ce833aa01a41d103cb0e97b59
  
https://github.com/WebKit/WebKit/commit/bb9256b06c27e21ce833aa01a41d103cb0e97b59
  Author: Tadeu Zagallo 
  Date:   2025-03-17 (Mon, 17 Mar 2025)

  Changed paths:
A LayoutTests/fast/webgpu/nocrash/fuzz-147019863-expected.txt
A LayoutTests/fast/webgpu/nocrash/fuzz-147019863.html
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Source/WebGPU/WGSL/wgslc.cpp

  Log Message:
  ---
  [WebGPU] Range check built-in functions
https://bugs.webkit.org/show_bug.cgi?id=289776
rdar://147019863

Reviewed by Mike Wyrzykowski.

Introduce __wgsl builtins for all trigonometric functions for bounds checking 
the input.
For every function `f` the builting does `f(select(value, 0, value < -1 || 
value > 1))`.

The patch also introduces a new mechanism to generate helpers, that doesn't 
require
manually tracking what helpers are used in other compilation phases. Later all 
simple
helpers should be refactored to use this mechanism.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::FunctionDefinitionWriter):
(WGSL::Metal::FunctionDefinitionWriter::stringBuilder):
(WGSL::Metal::FunctionDefinitionWriter::write):
(WGSL::Metal::FunctionDefinitionWriter::emitNecessaryHelpers):
(WGSL::Metal::FunctionDefinitionWriter::visit):
(WGSL::Metal::FunctionDefinitionWriter::generatePackingHelpers):
(WGSL::Metal::FunctionDefinitionWriter::emitPackedVector):
(WGSL::Metal::FunctionDefinitionWriter::serializeVariable):
(WGSL::Metal::FunctionDefinitionWriter::visitArgumentBufferParameter):
(WGSL::Metal::FunctionDefinitionWriter::serializeBinaryExpression):
(WGSL::Metal::FunctionDefinitionWriter::visitStatements):
(WGSL::Metal::FunctionDefinitionWriter::serializeConstant):
* Source/WebGPU/WGSL/wgslc.cpp:
(CommandLine::parseArguments):
(runWGSL):

Canonical link: https://commits.webkit.org/292296@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 68934b: REGRESSION(292189@main) TestWebKitAPI.SampledPageT...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 68934b95216222300d0a01c80c6876826fe5f5a6
  
https://github.com/WebKit/WebKit/commit/68934b95216222300d0a01c80c6876826fe5f5a6
  Author: Alan Baradlay 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/page/PageColorSampler.cpp

  Log Message:
  ---
  REGRESSION(292189@main) TestWebKitAPI.SampledPageTopColor.HitTestHTMLImage 
and .HitTestCSSBackgroundImage are failing constantly
https://bugs.webkit.org/show_bug.cgi?id=289922

Unreviewed, partial revert.

* Source/WebCore/page/PageColorSampler.cpp:
(WebCore::isValidSampleLocation):

Canonical link: https://commits.webkit.org/292302@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 960ce8: Mark http/tests/site-isolation/fullscreen.html as ...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 960ce8d623da9a1474727b5784392d36dbabf299
  
https://github.com/WebKit/WebKit/commit/960ce8d623da9a1474727b5784392d36dbabf299
  Author: Alex Christensen 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  Mark http/tests/site-isolation/fullscreen.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=289964

Unreviewed.

292289@main fixed one source of flakiness, but there is still another.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/292307@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 36765b: Cherry-pick 292218@main (2b5f8c207511). https://bu...

[Xi Ruoyao]

  Branch: refs/heads/webkitglib/2.48
  Home:   https://github.com/WebKit/WebKit
  Commit: 36765b04788a4f386ebf81278ac42eaca8260d1f
  
https://github.com/WebKit/WebKit/commit/36765b04788a4f386ebf81278ac42eaca8260d1f
  Author: Xi Ruoyao 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h

  Log Message:
  ---
  Cherry-pick 292218@main (2b5f8c207511). 
https://bugs.webkit.org/show_bug.cgi?id=289849

webkitgtk-2.48.0 fails to build with GST_DISABLE_GST_DEBUG
https://bugs.webkit.org/show_bug.cgi?id=289849

Reviewed by Philippe Normand.

Move definitions needed even though GST_DISABLE_GST_DEBUG out of #ifndef
GST_DISABLE_GST_DEBUG.

* Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp:
(WebCore::PlatformRawAudioData::copyTo):
* Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::streamTypeToStringLower):
* Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:
(WebCore::AppendPipeline::streamTypeToStringLower):

Canonical link: https://commits.webkit.org/292218@main

Canonical link: https://commits.webkit.org/290945.70@webkitglib/2.48



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 50dbd5: [macOS] Add vector-based version of resizer

[lilyspiniolas]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 50dbd547b8a226a9da4a573772d5ae2d38fb94ed
  
https://github.com/WebKit/WebKit/commit/50dbd547b8a226a9da4a573772d5ae2d38fb94ed
  Author: Lily Spiniolas 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/rendering/RenderLayerScrollableArea.cpp
M Source/WebCore/rendering/RenderLayerScrollableArea.h
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/RenderTheme.h
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.h
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm

  Log Message:
  ---
  [macOS] Add vector-based version of resizer
https://bugs.webkit.org/show_bug.cgi?id=289806
rdar://147062251

Reviewed by Abrar Rahman Protyasha and Aditya Keerthi.

Added support for a vector-based version of the resizer. Moved
codepath for drawing the resizer image and resizer frame to RenderTheme
in order to account for platform differences.

* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::paintResizer):
(WebCore::RenderLayerScrollableArea::drawPlatformResizerImage): Deleted.
* Source/WebCore/rendering/RenderLayerScrollableArea.h:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintPlatformResizer):
(WebCore::RenderTheme::paintPlatformResizerFrame):
* Source/WebCore/rendering/RenderTheme.h:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.h:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::paintPlatformResizer):
(WebCore::RenderThemeCocoa::paintPlatformResizerFrame):

Canonical link: https://commits.webkit.org/292298@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 21bf9f: [GStreamer] Switch doCapsHaveType to ASCIILiteral

[Xabier Rodríguez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 21bf9f8e8de570b3c9fb24e36481c27f63f1a087
  
https://github.com/WebKit/WebKit/commit/21bf9f8e8de570b3c9fb24e36481c27f63f1a087
  Author: Xabier Rodriguez-Calvar 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp
M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h
M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp

  Log Message:
  ---
  [GStreamer] Switch doCapsHaveType to ASCIILiteral
https://bugs.webkit.org/show_bug.cgi?id=289896

Reviewed by Philippe Normand.

* Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::plugDeinterleave):
* Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:
(WebCore::AudioSourceProviderGStreamer::AudioSourceProviderGStreamer):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::doCapsHaveType):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
* Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
(WebCore::ImageDecoderGStreamer::ImageDecoderGStreamer):
* 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp:
(WebCore::GStreamerIncomingTrackProcessor::configure):
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:

Canonical link: https://commits.webkit.org/292297@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 21866a: [css-anchor-position-1] Reimport WPT /css/css-anch...

[Kiet Ho]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 21866a8493bfb9844916526cb6f0a23a8503
  
https://github.com/WebKit/WebKit/commit/21866a8493bfb9844916526cb6f0a23a8503
  Author: Kiet Ho 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/imported/w3c/resources/resource-files.json
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-as-multicol-crash.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-center-003-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-center-003.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-center-fallback-transition-behavior-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-center-fallback-transition-behavior.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-fallback-to-self-crash.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-getComputedStyle-001.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-getComputedStyle-002.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-getComputedStyle-003.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-parse-valid-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-parse-valid.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-position-005-print-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-position-005-print.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-position-multicol-007-expected.xht
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-position-multicol-007.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-position-multicol-008-expected.xht
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-position-multicol-008.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-position-multicol-009.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-position-multicol-010.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-position-multicol-011-expected.xht
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-position-multicol-011.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scope-basic-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scope-basic.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scope-scroll-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scope-scroll-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scope-scroll.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-004.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-composited-scrolling-006.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-001-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-001.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-006-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-006.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-007-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-007.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-008-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-008.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-009-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-009.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-010-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-010.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-011-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-po

[webkit-changes] [WebKit/WebKit] bacd81: Rename several helper methods in iOS selection cod...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bacd813bd34a82d93fb689dd9f4d34371d7277bc
  
https://github.com/WebKit/WebKit/commit/bacd813bd34a82d93fb689dd9f4d34371d7277bc
  Author: Wenson Hsieh 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  ---
  Rename several helper methods in iOS selection code after 291696@main
https://bugs.webkit.org/show_bug.cgi?id=289968

Reviewed by Abrar Rahman Protyasha and Aditya Keerthi.

Rename several helper methods that are grammatically incorrect:

- `currentNodeRequiresToSeparateLines` → `shouldRenderSelectionOnSeparateLine`
- `previousNodeRequiresToSeparateLines` → 
`shouldRenderPreviousSelectionOnSeparateLine`
- `hasAncestorRequiresToSeparateLines` → 
`hasAncestorWithSelectionOnSeparateLine`

* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::shouldRenderSelectionOnSeparateLine):
(WebCore::hasAncestorWithSelectionOnSeparateLine):
(WebCore::shouldRenderPreviousSelectionOnSeparateLine):
(WebCore::RenderObject::collectSelectionGeometriesInternal):
(WebCore::currentNodeRequiresToSeparateLines): Deleted.
(WebCore::hasAncestorRequiresToSeparateLines): Deleted.
(WebCore::previousNodeRequiresToSeparateLines): Deleted.

Canonical link: https://commits.webkit.org/292317@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ffda14: [GStreamer] Change isGStreamerPluginAvailable to A...

[Xabier Rodríguez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ffda146cba5d826f409db78494abc16d4d436307
  
https://github.com/WebKit/WebKit/commit/ffda146cba5d826f409db78494abc16d4d436307
  Author: Xabier Rodriguez-Calvar 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp
M Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerAudioMixer.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h
M Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Change isGStreamerPluginAvailable to ASCIILiteral
https://bugs.webkit.org/show_bug.cgi?id=289942

Reviewed by Philippe Normand.

* 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::createGStreamerPeerConnectionBackend):
* Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:
(webKitGLVideoSinkProbePlatform):
* Source/WebCore/platform/graphics/gstreamer/GStreamerAudioMixer.cpp:
(WebCore::GStreamerAudioMixer::isAvailable):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::isGStreamerPluginAvailable):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
* Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
(webKitTextCombinerHandleCaps):
(webkitTextCombinerNew):
* Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp:
(WebCore::MediaRecorderPrivateBackend::containerProfile):

Canonical link: https://commits.webkit.org/292299@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 92b1b1: Adopt 'if constexpr' in URLParser::advance

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 92b1b1fdf7d4da1576d40e4352b20161b5e00e6d
  
https://github.com/WebKit/WebKit/commit/92b1b1fdf7d4da1576d40e4352b20161b5e00e6d
  Author: Anne van Kesteren 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WTF/wtf/URLParser.cpp

  Log Message:
  ---
  Adopt 'if constexpr' in URLParser::advance
https://bugs.webkit.org/show_bug.cgi?id=289931

Reviewed by Abrar Rahman Protyasha.

* Source/WTF/wtf/URLParser.cpp:
(WTF::URLParser::advance):

Canonical link: https://commits.webkit.org/292306@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4bb565: Fix Clang v20.1 compiler warnings

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4bb5658007ea02e95c2578aecc1f5f358aa0f487
  
https://github.com/WebKit/WebKit/commit/4bb5658007ea02e95c2578aecc1f5f358aa0f487
  Author: Fujii Hironori 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M 
Source/WebCore/layout/formattingContexts/inline/InlineContentConstrainer.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineContentConstrainer.h
M Source/WebCore/platform/graphics/adwaita/ControlAdwaita.cpp
M Source/WebCore/platform/graphics/adwaita/ControlAdwaita.h
M Source/WebCore/platform/graphics/egl/GLFenceEGL.cpp
M Source/WebCore/platform/graphics/egl/GLFenceEGL.h
M Source/WebCore/platform/network/HTTPParsers.cpp
M Source/WebKit/UIProcess/API/APIAttachment.h
M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp
M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h

  Log Message:
  ---
  Fix Clang v20.1 compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=289937

Reviewed by Michael Catanzaro.

Fixed return-stack-address and unused-private-field warnings.

* Source/WebCore/layout/formattingContexts/inline/InlineContentConstrainer.cpp:
(WebCore::Layout::SlidingWidth::SlidingWidth):
* Source/WebCore/layout/formattingContexts/inline/InlineContentConstrainer.h:
* Source/WebCore/platform/graphics/adwaita/ControlAdwaita.cpp:
(WebCore::ControlAdwaita::ControlAdwaita):
* Source/WebCore/platform/graphics/adwaita/ControlAdwaita.h:
* Source/WebCore/platform/graphics/egl/GLFenceEGL.cpp:
(WebCore::GLFenceEGL::GLFenceEGL):
* Source/WebCore/platform/graphics/egl/GLFenceEGL.h:
* Source/WebCore/platform/network/HTTPParsers.cpp:
(WebCore::filenameFromHTTPContentDisposition):
* Source/WebKit/UIProcess/API/APIAttachment.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp:
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

Canonical link: https://commits.webkit.org/292322@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0db380: Empty origin directory is not removed after cleari...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0db3804cde171731c89c7f0dc5bade64edf8223a
  
https://github.com/WebKit/WebKit/commit/0db3804cde171731c89c7f0dc5bade64edf8223a
  Author: Sihui Liu 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm

  Log Message:
  ---
  Empty origin directory is not removed after clearing all website data
https://bugs.webkit.org/show_bug.cgi?id=289966

Reviewed by Ben Nham.

WebKit currently deletes origin diretory when it becomes "empty", meaning it 
only contains the "origin" file. On macOS,
the directory can have a hidden file ".DS_Store". For origin directory that has 
both ".DS_Store" and "origin" files, it
should also be considered as "empty" and gets deleted.

* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::isEmptyOriginDirectory):
(WebKit::deleteEmptyOriginDirectory):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(TEST(WebKit, DeleteEmptyOriginDirectoryWithHiddenFile)):

Canonical link: https://commits.webkit.org/292323@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9892a2: Unreviewed safer C++ bot fix.

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9892a270f2c159cf58f73f5733d4a35b183b6f3e
  
https://github.com/WebKit/WebKit/commit/9892a270f2c159cf58f73f5733d4a35b183b6f3e
  Author: Ryosuke Niwa 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp

  Log Message:
  ---
  Unreviewed safer C++ bot fix.

Use protectedPreferences() instead of regular preferences() to call 
siteIsolationEnabled().

* Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::enterFullScreen):

Canonical link: https://commits.webkit.org/292333@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a0985b: [Win] Unreviewed test gardening

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a0985bd97e833209777a08f5fbfd8e4c180e791d
  
https://github.com/WebKit/WebKit/commit/a0985bd97e833209777a08f5fbfd8e4c180e791d
  Author: Fujii Hironori 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M LayoutTests/platform/win/TestExpectations

  Log Message:
  ---
  [Win] Unreviewed test gardening

* LayoutTests/platform/win/TestExpectations:

Canonical link: https://commits.webkit.org/292341@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3b5647: [iOS] Keyboard scrolling does not work in sub-scro...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b564766bf831003582c5bc07c0975854a5478e8
  
https://github.com/WebKit/WebKit/commit/3b564766bf831003582c5bc07c0975854a5478e8
  Author: Richard Robinson 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
A 
LayoutTests/fast/scrolling/ios/keyboard-scrolling-subscrollable-expected.txt
A LayoutTests/fast/scrolling/ios/keyboard-scrolling-subscrollable.html
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/EventHandler.h
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm
M Source/WebKit/UIProcess/ios/WKBaseScrollView.h
M Source/WebKit/UIProcess/ios/WKBaseScrollView.mm
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.h
M Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm
M Source/WebKit/UIProcess/ios/WKPDFView.mm
M Source/WebKit/UIProcess/ios/WKScrollView.h
R Source/WebKit/UIProcess/ios/WKVelocityTrackingScrollView.h
R Source/WebKit/UIProcess/ios/WKVelocityTrackingScrollView.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  ---
  [iOS] Keyboard scrolling does not work in sub-scrollable regions
https://bugs.webkit.org/show_bug.cgi?id=287721
rdar://131354460

Reviewed by Tim Horton.

Add functionality to allow scrolling in sub-scrollable regions on iOS like 
macOS.

* LayoutTests/fast/scrolling/ios/keyboard-scrolling-subscrollable-expected.txt: 
Added.
* LayoutTests/fast/scrolling/ios/keyboard-scrolling-subscrollable.html: Added.

Layout tests.

* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::focusedScrollableArea const):

Fallback to the last touched node if there is no mouse press node or focused 
node.

* Source/WebCore/page/Page.h:
(WebCore::Page::setLastTouchedNode):
(WebCore::Page::lastTouchedNode const):

Store the last touched node so that EventHandler can later use it.

* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _scrollViewInternal]):
* Source/WebKit/UIProcess/ios/WKVelocityTrackingScrollView.h: Removed.
* Source/WebKit/UIProcess/ios/WKVelocityTrackingScrollView.mm: Removed.

Remove WKVelocityTrackingScrollView in favor of using WKBaseScrollView directly 
so that all scroll views can track velocities.

* Source/WebKit/UIProcess/ios/WKBaseScrollView.h:
* Source/WebKit/UIProcess/ios/WKBaseScrollView.mm:
(ScrollingDeltaWindow::update):
(ScrollingDeltaWindow::reset):
(ScrollingDeltaWindow::averageVelocity const):
(-[WKBaseScrollView updateInteractiveScrollVelocity]):
(-[WKBaseScrollView interactiveScrollVelocityInPointsPerSecond]):

Give WKBaseScrollView the functionality that WKVelocityTrackingScrollView had.

* 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:
(-[WKScrollingNodeScrollViewDelegate scrollViewDidScroll:]):

For sub-scrollable regions, call `updateInteractiveScrollVelocity` just like 
the main scroll view.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setUpInteraction]):

Since the scroll view that the scrolling animator uses is now dynamic, don't 
provide a scroll view when creating the animator;
instead, provide it on-demand.

(-[WKContentView _interpretKeyEvent:withContext:]):

Compute the scroll view that should be used for the keyboard scrolling 
animator, based on whichever view was focused/clicked/touched last.
Fallback to the main scroll view if no others are found.

(-[WKContentView keyboardScrollViewAnimatorDidFinishScrolling:]):

Use the correct scroll view when passing it to `_didFinishScrolling`.

* Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.h:
* Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm:
(-[WKKeyboardScrollViewAnimator init]):
(-[WKKeyboardScrollViewAnimator initWithScrollView:]): Deleted.

Instead of providing a scroll view at the beginning, it is provided on-demand.

(-[WKKeyboardScrollViewAnimator beginWithEvent:scrollView:]):
(-[WKKeyboardScrollViewAnimator beginWithEvent:]): Deleted.

Amend this function to allow specifying the current scroll view that should be 
targeted.
If there is no ongoing scroll, set the ivar _scrollView to the parameter's 
value.
If there is an ongoing scroll on a different scroll view, ignore the request on 
the new scroll view.

(-[WKKeyboardScrollViewAnimator scrollView]):

Allow querying for the current scroll view that the animator is using.

(-[WKKeyboardScrollViewAnimator didFinishScrolling]):

Set _scrollView to nil to indicate that there is now no scroll view that is 
currently keyboard scrolling.

* Source/WebKit/UIProcess/ios/WKPDFVi

[webkit-changes] [WebKit/WebKit] dad496: [iOS] Add support for extending background colors ...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dad4965a309ad44ea11bb8cb3a95712bb08b7caa
  
https://github.com/WebKit/WebKit/commit/dad4965a309ad44ea11bb8cb3a95712bb08b7caa
  Author: Wenson Hsieh 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/editing/mac/DictionaryLookup.h
A Source/WebCore/platform/cocoa/CocoaView.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  ---
  [iOS] Add support for extending background colors beyond fixed-position 
containers when obscured insets are set
https://bugs.webkit.org/show_bug.cgi?id=289918
rdar://147258935

Reviewed by Megan Gardner.

Extend background colors beyond the edges of fixed containers when `-[WKWebView 
_obscuredInsets]`
are present, on iOS. This primarily moves logic introduced in 
https://commits.webkit.org/292256@main
out of `WebViewImpl` and into `WKWebView.mm`. See below for more details.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/editing/mac/DictionaryLookup.h:
* Source/WebCore/platform/cocoa/CocoaView.h: Added.

Add a new WebCore `platform/` header that just defines `CocoaView` to be either 
`NSView` or
`UIView`. Deploy this in `DictionaryLookup.h` above, as well as 
`WKWebViewInternal.h` below.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView 
_recalculateViewportSizesWithMinimumViewportInset:maximumViewportInset:throwOnInvalidInput:]):
(-[WKWebView _updateFixedContainerEdges:]):
(-[WKWebView _obscuredInsetsForFixedColorExtension]):
(-[WKWebView _containerForFixedColorExtension]):
(-[WKWebView _updateFixedColorExtensionViews]):

Moved here from (the macOS-specific) `WebViewImpl`. Also split out this logic 
across two methods:
(1) this method, which installs, updates the visibility, background colors, and 
frames for each
of the color extension views, and (2) another method right below, which only 
updates the frames of
each of the color extension views.

This allows us to only update frames when the insets or other geometry change, 
but perform a full
update when fixed-position container state changes.

(-[WKWebView _updateFixedColorExtensionViewFrames]):
(-[WKWebView _coreFixedContainerEdges]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView scrollViewDidScroll:]):

Update the frame of the fixed color extension views whenever the main scroll 
view is scrolled. Note
that we install the extension views underneath the `WKScrollView` on iOS 
instead of the web view
itself, for compatibility with clients (e.g. Safari) which already install 
views below the scroll
view, and expect these views to not be covered by other views under the 
`WKWebView`.

(-[WKWebView _setObscuredInsets:]):
(-[WKWebView _setObscuredInsetEdgesAffectedBySafeArea:]):

Update the frame of the fixed color extension views whenever obscured insets 
change.

* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::updateFixedContentExtensionViews): Deleted.

Canonical link: https://commits.webkit.org/292308@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 56c98d: Cherry-pick 292322@main (4bb5658007ea). https://bu...

[Fujii Hironori]

  Branch: refs/heads/webkitglib/2.48
  Home:   https://github.com/WebKit/WebKit
  Commit: 56c98d4e96af72672138b55f2f8b5c881bf37c78
  
https://github.com/WebKit/WebKit/commit/56c98d4e96af72672138b55f2f8b5c881bf37c78
  Author: Fujii Hironori 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M 
Source/WebCore/layout/formattingContexts/inline/InlineContentConstrainer.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineContentConstrainer.h
M Source/WebCore/platform/graphics/adwaita/ControlAdwaita.cpp
M Source/WebCore/platform/graphics/adwaita/ControlAdwaita.h
M Source/WebCore/platform/graphics/egl/GLFenceEGL.cpp
M Source/WebCore/platform/graphics/egl/GLFenceEGL.h
M Source/WebCore/platform/network/HTTPParsers.cpp
M Source/WebKit/UIProcess/API/APIAttachment.h
M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp
M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h

  Log Message:
  ---
  Cherry-pick 292322@main (4bb5658007ea). 
https://bugs.webkit.org/show_bug.cgi?id=289937

Fix Clang v20.1 compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=289937

Reviewed by Michael Catanzaro.

Fixed return-stack-address and unused-private-field warnings.

* 
Source/WebCore/layout/formattingContexts/inline/InlineContentConstrainer.cpp:
(WebCore::Layout::SlidingWidth::SlidingWidth):
* 
Source/WebCore/layout/formattingContexts/inline/InlineContentConstrainer.h:
* Source/WebCore/platform/graphics/adwaita/ControlAdwaita.cpp:
(WebCore::ControlAdwaita::ControlAdwaita):
* Source/WebCore/platform/graphics/adwaita/ControlAdwaita.h:
* Source/WebCore/platform/graphics/egl/GLFenceEGL.cpp:
(WebCore::GLFenceEGL::GLFenceEGL):
* Source/WebCore/platform/graphics/egl/GLFenceEGL.h:
* Source/WebCore/platform/network/HTTPParsers.cpp:
(WebCore::filenameFromHTTPContentDisposition):
* Source/WebKit/UIProcess/API/APIAttachment.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp:
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

Canonical link: https://commits.webkit.org/292322@main

Canonical link: https://commits.webkit.org/290945.72@webkitglib/2.48



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 20e1e6: Remove `RenderStyle::shouldApplyColorFilterWhenIna...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20e1e624642ebd4f74a0da28d117b75219c16d9b
  
https://github.com/WebKit/WebKit/commit/20e1e624642ebd4f74a0da28d117b75219c16d9b
  Author: Aditya Keerthi 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/rendering/TextPaintStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/style/RenderStyleSetters.h
M Source/WebCore/rendering/style/StyleRareInheritedData.cpp
M Source/WebCore/rendering/style/StyleRareInheritedData.h

  Log Message:
  ---
  Remove `RenderStyle::shouldApplyColorFilterWhenInactive`
https://bugs.webkit.org/show_bug.cgi?id=290005
rdar://147362207

Reviewed by Tim Horton.

`RenderStyle::insideDefaultButton` serves the use cases for
`shouldApplyColorFilterWhenInactive`.

* Source/WebCore/rendering/TextPaintStyle.cpp:
(WebCore::computeTextPaintStyle):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::insideDefaultButton const):
(WebCore::RenderStyle::shouldApplyColorFilterWhenInactive const): Deleted.
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setInsideDefaultButton):
(WebCore::RenderStyle::setShouldApplyColorFilterWhenInactive): Deleted.
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):
(WebCore::StyleRareInheritedData::dumpDifferences const):
* Source/WebCore/rendering/style/StyleRareInheritedData.h:

Canonical link: https://commits.webkit.org/292337@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 555d88: REGRESSION(290220@main): [ iOS ] 12x TestWebKitAPI...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 555d88497d88eda6c0f4289b9d6d515979a0e93b
  
https://github.com/WebKit/WebKit/commit/555d88497d88eda6c0f4289b9d6d515979a0e93b
  Author: Tim Horton 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm

  Log Message:
  ---
  REGRESSION(290220@main): [ iOS ] 12x TestWebKitAPI.UnifiedPDF* (api-tests) 
are constant failures
https://bugs.webkit.org/show_bug.cgi?id=287579
rdar://144724909

Reviewed by Abrar Rahman Protyasha.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
(TestWebKitAPI::UNIFIED_PDF_TEST):
I can't reproduce the debug-only failures, so re-enable these tests.
(If EWS disagrees, we can diagnose there).

Also, bring up a UIApp for the tests that are disabled because mouse events 
need a UIApp now.

Canonical link: https://commits.webkit.org/292311@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e02e12: Web Inspector: The new ServiceWorkerDebuggableProx...

[Qianlang Chen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e02e121abf243cc5c461af6def0d30df24eadf81
  
https://github.com/WebKit/WebKit/commit/e02e121abf243cc5c461af6def0d30df24eadf81
  Author: Qianlang Chen 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp
M Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.cpp
M Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.cpp
M Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.h
M Source/JavaScriptCore/inspector/remote/RemoteInspector.cpp
M Source/JavaScriptCore/inspector/remote/RemoteInspector.h
M 
Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm
M Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm
M Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp
M Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WebCore/inspector/InspectorController.cpp
M Source/WebCore/inspector/WorkerInspectorController.cpp
M Source/WebCore/inspector/WorkerInspectorController.h
M Source/WebCore/workers/service/context/SWContextManager.cpp
M Source/WebCore/workers/service/context/SWContextManager.h
M Source/WebCore/workers/service/context/ServiceWorkerDebuggable.cpp
M Source/WebCore/workers/service/context/ServiceWorkerDebuggable.h
M Source/WebCore/workers/service/context/ServiceWorkerInspectorProxy.cpp
M Source/WebCore/workers/service/context/ServiceWorkerInspectorProxy.h
M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp
M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h
M Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm
M Source/WebKit/UIProcess/WebProcessProxy.h
M Source/WebKit/UIProcess/WebProcessProxy.messages.in
M Source/WebKit/WebProcess/Inspector/ServiceWorkerDebuggableProxy.cpp
M Source/WebKit/WebProcess/Inspector/ServiceWorkerDebuggableProxy.h
M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h
M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in

  Log Message:
  ---
  Web Inspector: The new ServiceWorkerDebuggableProxy needs to adopt auto 
inspection
rdar://145795990
https://bugs.webkit.org/show_bug.cgi?id=288776

Reviewed by BJ Burg.

This work adds support to automatically inspect or pause the
ServiceWorkerDebuggableProxy, alongside minor refactoring of existing
code around auto-inspection.

The squashed commit includes three patches:

(Patch 1 of 3) Make pausing for automatic inspection a responsibility
of the RemoteInspectionTarget rather than RemoteInspector.

To summarize how automatic inspection generally works:
1. The web content marks its debuggable as inspectable.
2. The debuggable blocks its thread before starting code execution.
3. The auto-launched frontend, after initializing, notifies the backend.
4. The backend unblocks the debuggable to resume its code execution.

As the newly introduced ServiceWorkerDebuggableProxy lives in the UI
process but controls a different thread, during step 2, it's the service
worker thread that would need to be blocked, while the UI process
remains free to handle incoming messages from the remote inspector host.

This patch builds the ground work for supporting pausing in a different
thread by moving the handling of pausing or unpausing into the
debuggable instead of implicitly in RemoteInspector. With this change:
- From the RemoteInspector's perspective, it only needs to manage the
  set of debuggables waiting for a reply of auto-inspection policy.
  Notably, it now tells the debuggable to unpause when auto-inspection
  is rejected, rather than relying on the call to 
pauseWaitingForAutomaticInspection
  to return and assuming that it was a blocking operation.
- From the RemoteInspectionTarget's perspective, it should decide
  what the pausing behavior is, defaulting to blocking the current
  thread with a busy loop. The pause should then persist until an
  explicit call of unpauseForResolvedAutomaticInspection.

With this patch, it'll be easier to let ServiceWorkerDebuggableProxy
later define a custom pausing behavior that controls a different thread.

I tested on both Mac and iOS, with an app that spawns a JSContext, that
this change preserves normal and automatic inspection with no noticeable
difference from before.

* Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.h:
* Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.cpp:
(Inspector::RemoteInspectionTarget::pauseWaitingForAutomaticInspection):
(Inspector::RemoteInspectionTarget::unpauseForResolvedAutomaticInspection):
(Inspector::RemoteInspectionTarget::unpauseForInitializedInspector): Deleted.
   - Use m_i

[webkit-changes] [WebKit/WebKit] b095da: [Gardening]: REGRESSION(291808@main): [macOS Debug...

[Marta]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b095dac9cc0093a97ad0ccdd75dce12b9c8f7681
  
https://github.com/WebKit/WebKit/commit/b095dac9cc0093a97ad0ccdd75dce12b9c8f7681
  Author: Marta Darbinyan 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION(291808@main): [macOS Debug]: ASSERTION FAILED in 
html5lib/generated/run-entities01-data.html
https://bugs.webkit.org/show_bug.cgi?id=290012
rdar://147365119

Unreviewed test gardening

Skipping the test in Debug due to flakiness in EWS

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/292335@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f55d80: [ macOS wk2 Release ] imported/w3c/web-platform-te...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f55d8061c2b360892c44ccc8355d95dbd83b93be
  
https://github.com/WebKit/WebKit/commit/f55d8061c2b360892c44ccc8355d95dbd83b93be
  Author: Ryosuke Niwa 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [ macOS wk2 Release ] 
imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-remove-popover-attribute.html
 is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=289576
rdar://146804468

Reviewed by Sammy Gill.

This test failed exactly once on one bot and we can't reproduce the failure 
locally.
Remove the flaky test expectation for now.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/292336@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ffe347: Drop a signpost for programmatic scrolls

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ffe34721c4a1069b89aa079940285eb72d7a7087
  
https://github.com/WebKit/WebKit/commit/ffe34721c4a1069b89aa079940285eb72d7a7087
  Author: Simon Fraser 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WTF/wtf/SystemTracing.h
M Source/WTF/wtf/glib/SysprofAnnotator.h
M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
M Source/WebKit/Resources/Signposts/SystemTracePoints.plist
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

  Log Message:
  ---
  Drop a signpost for programmatic scrolls
https://bugs.webkit.org/show_bug.cgi?id=289905
rdar://147232655

Reviewed by Ben Nham.

Call tracePoint() from `AsyncScrollingCoordinator::requestScrollToPosition()` 
so that perf traces
can show when web content is triggering programmatic scrolling.

* Source/WTF/wtf/SystemTracing.h:
* Source/WTF/wtf/glib/SysprofAnnotator.h:
* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::requestScrollToPosition):
* Source/WebKit/Resources/Signposts/SystemTracePoints.plist:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/292331@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8237aa: Move webpushd state to container

[bnham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8237aaf69a3ffed7d5969214385fa99cfeb71ded
  
https://github.com/WebKit/WebKit/commit/8237aaf69a3ffed7d5969214385fa99cfeb71ded
  Author: Ben Nham 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebKit/Scripts/process-entitlements.sh
M Source/WebKit/webpushd/WebPushDaemonMain.mm
M Source/WebKit/webpushd/mac/com.apple.WebKit.webpushd.mac.sb.in

  Log Message:
  ---
  Move webpushd state to container
https://bugs.webkit.org/show_bug.cgi?id=289557
rdar://110714823

Reviewed by Brady Eidson.

The data in ~/Library/WebKit/WebPush contains state that only webpushd needs to 
access. To enforce
this, move that state in to a container. We do this at process launch time. If 
we detect state in
the old location and no state in the new location, then we initiate a one-time 
migration.

* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/webpushd/WebPushDaemonMain.mm:
(WebKit::getWebPushDirectoryPathWithMigrationIfNecessary):
(WebKit::WebPushDaemonMain):
* Source/WebKit/webpushd/mac/com.apple.WebKit.webpushd.mac.sb.in:

Canonical link: https://commits.webkit.org/292327@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 291555: [WebGPU] GPURenderPassEncoder.setBindGroup() shows...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29155572a7c4547529fc876564975662d36d15be
  
https://github.com/WebKit/WebKit/commit/29155572a7c4547529fc876564975662d36d15be
  Author: Mike Wyrzykowski 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebGPU/WebGPU/Buffer.h
M Source/WebGPU/WebGPU/Buffer.mm
M Source/WebGPU/WebGPU/CommandEncoder.h
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/ComputePassEncoder.mm
M Source/WebGPU/WebGPU/Device.h
M Source/WebGPU/WebGPU/Device.mm
M Source/WebGPU/WebGPU/ExternalTexture.h
M Source/WebGPU/WebGPU/ExternalTexture.mm
M Source/WebGPU/WebGPU/HardwareCapabilities.h
M Source/WebGPU/WebGPU/HardwareCapabilities.mm
M Source/WebGPU/WebGPU/QuerySet.h
M Source/WebGPU/WebGPU/QuerySet.mm
M Source/WebGPU/WebGPU/Queue.h
M Source/WebGPU/WebGPU/Queue.mm
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.h
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
M Source/WebGPU/WebGPU/Texture.h
M Source/WebGPU/WebGPU/Texture.mm
M Source/WebGPU/WebGPU/TextureView.h
M Source/WebGPU/WebGPU/TextureView.mm

  Log Message:
  ---
  [WebGPU] GPURenderPassEncoder.setBindGroup() shows up in CPU trace samples as 
significant
https://bugs.webkit.org/show_bug.cgi?id=289433
rdar://146605221

Reviewed by Tadeu Zagallo.

CPU profile showed significant time in setBindGroup calls

* Source/WebGPU/WebGPU/Buffer.h:
* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::Device::safeCreateBuffer const):
(WebGPU::Buffer::incrementBufferMapCount):
(WebGPU::Buffer::decrementBufferMapCount):
(WebGPU::Buffer::setCommandEncoder const):
(WebGPU::Buffer::destroy):
Creating the WeakPtr was showing up significantly in traces,
we can avoid this by storing identifiers and then performing
lookups in the rare cases it is needed.

* Source/WebGPU/WebGPU/CommandEncoder.h:
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::Device::createCommandEncoder):
(WebGPU::CommandEncoder::CommandEncoder):
(WebGPU::CommandEncoder::~CommandEncoder):
(WebGPU::CommandEncoder::encoderIsCurrent const):
(WebGPU::CommandEncoder::computeSize):
(WebGPU::CommandEncoder::trackEncoder):
Adapt new container.

(WebGPU::CommandEncoder::useResidencySet):
Allow for residency sets on devices which support them.

* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::addTextureToActiveResources):
(WebGPU::addResourceToActiveResources):
(WebGPU::ComputePassEncoder::executePreDispatchCommands):
Track textures and buffers seperately as buffers consume less resources.

* Source/WebGPU/WebGPU/Device.h:
(WebGPU::Device::isShaderValidationEnabled const):
(WebGPU::Device::commandEncoderFromIdentifier const):
(WebGPU::Device::commandEncoderFromIdentifier):
(WebGPU::Device::removeCommandEncoder):
(WebGPU::Device::supportsResidencySets):
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::Device):
(WebGPU::Device::newBufferWithBytes const):
(WebGPU::Device::newBufferWithBytesNoCopy const):
Skip memory attributions for buffers of short lifetime, the attribution
cost is significant and the GPU process already needs headroom available
to allocate the memory initially.

* Source/WebGPU/WebGPU/ExternalTexture.h:
* Source/WebGPU/WebGPU/ExternalTexture.mm:
(WebGPU::ExternalTexture::destroy):
(WebGPU::ExternalTexture::openCommandEncoderCount const):
Use adopted helper functions.

* Source/WebGPU/WebGPU/HardwareCapabilities.h:
* Source/WebGPU/WebGPU/HardwareCapabilities.mm:
(WebGPU::baseCapabilities):
(WebGPU::apple6):
(WebGPU::apple7):
(WebGPU::mergeBaseCapabilities):
Apple6 and later support residency sets.

* Source/WebGPU/WebGPU/QuerySet.h:
* Source/WebGPU/WebGPU/QuerySet.mm:
(WebGPU::QuerySet::destroy):
Use new container.

* Source/WebGPU/WebGPU/Queue.h:
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::span):
(WebGPU::Queue::newTemporaryBufferWithBytes):
(WebGPU::Queue::writeBuffer):
(WebGPU::Queue::writeTexture):
Sub-allocate small writeBuffer calls from a single buffer.

* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::addResource):
* Source/WebGPU/WebGPU/RenderPassEncoder.h:
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::addTextureToActiveResources):
(WebGPU::RenderPassEncoder::addResourceToActiveResources):
(WebGPU::RenderPassEncoder::executePreDrawCommands):
(WebGPU::RenderPassEncoder::executeBundles):
(WebGPU::RenderPassEncoder::setBindGroup):
(WebGPU::RenderPassEncoder::setIndexBuffer):
(WebGPU::RenderPassEncoder::setVertexBuffer):
Use lighter weight mechanism for tracking resources.

* Source/WebGPU/WebGPU/Texture.h:
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::waitForCommandBufferCompletion):
(WebGPU::Texture::destroy):
* Source/WebGPU/WebGPU/TextureView.h:
* Source/WebGPU/WebGPU/TextureView.mm:
(WebGPU::TextureView::destroy):
Adapt new container.

Canonical link: https://commits.webkit.org/292320@main



To unsubscribe from these 

[webkit-changes] [WebKit/WebKit] 7e8c6d: Remove unused code form SVGFilter

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e8c6d6eefd9cad23b4a4479efe12f3126995897
  
https://github.com/WebKit/WebKit/commit/7e8c6d6eefd9cad23b4a4479efe12f3126995897
  Author: Said Abou-Hallawa 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/svg/graphics/filters/SVGFilter.cpp
M Source/WebCore/svg/graphics/filters/SVGFilter.h

  Log Message:
  ---
  Remove unused code form SVGFilter
https://bugs.webkit.org/show_bug.cgi?id=289991

Unreviewed.

Remove one of the SVGFilter::create() methods and one of its constructors.

* Source/WebCore/svg/graphics/filters/SVGFilter.cpp:
* Source/WebCore/svg/graphics/filters/SVGFilter.h:

Canonical link: https://commits.webkit.org/292339@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 41c253: [Regression@292296@main] textureDimensions is brok...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41c2531885689f1396affaf45a8c702a19f2287d
  
https://github.com/WebKit/WebKit/commit/41c2531885689f1396affaf45a8c702a19f2287d
  Author: Mike Wyrzykowski 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M LayoutTests/fast/webgpu/regression/repro_275624-expected.txt
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

  Log Message:
  ---
  [Regression@292296@main] textureDimensions is broken for 1D textures
https://bugs.webkit.org/show_bug.cgi?id=289971
rdar://147325897

Reviewed by Tadeu Zagallo.

292296@main clamps the lod to the max mip level, but for 1D textures which
require constant levels we shouldn't do this. 1D textures don't support
mip levels in WebGPU, so the level is always zero.

Testing: existing wgslc tests caught this

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::emitTextureDimensions):

Canonical link: https://commits.webkit.org/292319@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e6b727: Synchronize WPT xhr

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e6b7271186b2bf9d6033e6f2a37377dcbcd87b85
  
https://github.com/WebKit/WebKit/commit/e6b7271186b2bf9d6033e6f2a37377dcbcd87b85
  Author: Anne van Kesteren 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/imported/w3c/web-platform-tests/xhr/abort-with-error.any.html
A LayoutTests/imported/w3c/web-platform-tests/xhr/abort-with-error.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/abort-with-error.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/abort-with-error.any.worker.html
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/blob-range.any-expected.txt
A LayoutTests/imported/w3c/web-platform-tests/xhr/blob-range.any.html
A LayoutTests/imported/w3c/web-platform-tests/xhr/blob-range.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/blob-range.any.worker-expected.txt
A LayoutTests/imported/w3c/web-platform-tests/xhr/blob-range.any.worker.html
M LayoutTests/imported/w3c/web-platform-tests/xhr/event-timeout-order.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/formdata/constructor-submitter-coordinate-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/formdata/constructor-submitter-coordinate.html
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/formdata/constructor-submitter-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/formdata/constructor-submitter.html
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/formdata/iteration.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/formdata/iteration.any.html
A LayoutTests/imported/w3c/web-platform-tests/xhr/formdata/iteration.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/formdata/iteration.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/formdata/iteration.any.worker.html
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/formdata/submitter-coordinate-value-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/formdata/submitter-coordinate-value.html
M LayoutTests/imported/w3c/web-platform-tests/xhr/formdata/w3c-import.log
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/idlharness.any-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/xhr/idlharness.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/progressevent-constructor-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/progressevent-constructor.html
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/progressevent-interface.html
M LayoutTests/imported/w3c/web-platform-tests/xhr/resources/auth1/auth.py
M LayoutTests/imported/w3c/web-platform-tests/xhr/resources/auth10/auth.py
M LayoutTests/imported/w3c/web-platform-tests/xhr/resources/auth11/auth.py
M LayoutTests/imported/w3c/web-platform-tests/xhr/resources/auth2/auth.py
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/resources/auth2/corsenabled.py
M LayoutTests/imported/w3c/web-platform-tests/xhr/resources/auth3/auth.py
M LayoutTests/imported/w3c/web-platform-tests/xhr/resources/auth4/auth.py
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/resources/auth7/corsenabled.py
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/resources/auth8/corsenabled-no-authorize.py
M LayoutTests/imported/w3c/web-platform-tests/xhr/resources/auth9/auth.py
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/resources/bad-chunk-encoding.py
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/resources/echo-content-type.py
M LayoutTests/imported/w3c/web-platform-tests/xhr/resources/echo-headers.py
M LayoutTests/imported/w3c/web-platform-tests/xhr/resources/redirect.py
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/responsexml-document-properties.htm
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/responsexml-invalid-type-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/responsexml-invalid-type.html
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/send-data-sharedarraybuffer.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/send-data-sharedarraybuffer.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/send-data-sharedarraybuffer.any.worker-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/xhr/send-redirect-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/xhr/send-redirect.htm
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/setrequestheader-header-forbidden-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/xhr/setrequestheader-header-forbidden.htm
M LayoutTests/imported/w3c/web-platform-tests/xhr/w3c-import.log
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/xhr-authorization-redirect.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/xhr/xhr-authorization-re

[webkit-changes] [WebKit/WebKit] 129b10: Rename HTTPResponse::Behavior::TerminateConnection...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 129b109956188fff0ba12b0935813c1a885a9400
  
https://github.com/WebKit/WebKit/commit/129b109956188fff0ba12b0935813c1a885a9400
  Author: Alex Christensen 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAndDecodeImage.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebNavigation.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebRequest.mm
M Tools/TestWebKitAPI/cocoa/HTTPServer.h
M Tools/TestWebKitAPI/cocoa/HTTPServer.mm

  Log Message:
  ---
  Rename HTTPResponse::Behavior::TerminateConnectionAfterReceivingResponse to 
TerminateConnectionAfterReceivingRequest
https://bugs.webkit.org/show_bug.cgi?id=289930
rdar://147269482

Reviewed by Matthew Finkel.

This is more accurate.  The server doesn't receive the response.  It receives 
the request then terminates the TCP connection.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
(TestWebKitAPI::TEST(WebKit, ErrorSecureCoding)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAndDecodeImage.mm:
(TestWebKitAPI::TEST(WebKit, LoadAndDecodeImage)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, ProvisionalLoadFailure)):
(TestWebKitAPI::TEST(SiteIsolation, 
NavigateOpenerToProvisionalNavigationFailure)):
(TestWebKitAPI::TEST(SiteIsolation, OpenProvisionalFailure)):
(TestWebKitAPI::TEST(SiteIsolation, 
NavigateIframeToProvisionalNavigationFailure)):
(TestWebKitAPI::TEST(SiteIsolation, ProvisionalLoadFailureOnCrossSiteRedirect)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebNavigation.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIWebNavigation, 
ErrorOccurredEventDuringProvisionalLoad)):
(TestWebKitAPI::TEST(WKWebExtensionAPIWebNavigation, ErrorOccurred)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebRequest.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIWebRequest, ErrorOccurredEvent)):
* Tools/TestWebKitAPI/cocoa/HTTPServer.h:
* Tools/TestWebKitAPI/cocoa/HTTPServer.mm:
(TestWebKitAPI::HTTPServer::respondToRequests):

Canonical link: https://commits.webkit.org/292330@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8b1ebb: [macOS] Selection color does not honor custom app ...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b1ebb351d75cb4d484bc9467cd9abe0026f6bb0
  
https://github.com/WebKit/WebKit/commit/8b1ebb351d75cb4d484bc9467cd9abe0026f6bb0
  Author: Aditya Keerthi 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/PAL/pal/spi/mac/NSColorSPI.h
M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm

  Log Message:
  ---
  [macOS] Selection color does not honor custom app accent colors
https://bugs.webkit.org/show_bug.cgi?id=289912
rdar://146919866

Reviewed by Richard Robinson.

App accent color support in WebKit works by forwarding the effective accent
color from the UI process to the web process, and updating the effective accent
color in the web process using `-[NSApplication _setAccentColor:]`.

More specifically, the web process attempts to set its accent color using
`[NSApp _setAccentColor:]`. `NSApp` is a static variable that is only set after
`-[NSApplication sharedApplication]` has been called once.

It appears that `-[NSApplication sharedApplication]` is no longer getting
invoked anywhere before WebKit attempts to set the accent color in the web
process. Consequently, `NSApp` is `nil`, `[NSApp _setAccentColor:]` is a
no-op, and the web process never updates its accent color.

Fix by calling `-[NSApplication sharedApplication]` upon process initialization,
and a regression test. This solution was chosen over updating the call site, as
other use of `NSApp` would remain risky.

* Source/WebCore/PAL/pal/spi/mac/NSColorSPI.h:
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
(TestWebKitAPI::TEST(WebKit, AppAccentColorAffectsSystemColors)):

The regression test does not directly test selection color, as that is not easy
to capture. Instead, it checks the value of a CSS system color, which should
follow the accent color.

Additionally, the test creates an additional web view for the sole purpose of
detecting when the user accent color has been correctly set in the global 
domain.
App accent colors do not apply unless the user accent color is "multicolor".

This test still "fails" occasionally when the system's accent color is not
already set to "multicolor", due to the preference update being slow. Since the
default setting is "multicolor", and the test still passes 90% of the time when
the user has a custom value, the test exits early rather than failing if the
user accent color could not be updated in a reasonable time.

Canonical link: https://commits.webkit.org/292312@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d4027f: Address Safer CPP warnings in MediaDevices

[Eric Carlson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d4027f7217f5c08d750eb8443f18161923675e33
  
https://github.com/WebKit/WebKit/commit/d4027f7217f5c08d750eb8443f18161923675e33
  Author: Eric Carlson 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/Modules/mediastream/MediaDevices.cpp
M Source/WebCore/Modules/mediastream/NavigatorMediaDevices.cpp
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations

  Log Message:
  ---
  Address Safer CPP warnings in MediaDevices
https://bugs.webkit.org/show_bug.cgi?id=289739
rdar://146989431

Reviewed by Youenn Fablet.

* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::stop):
(WebCore::MediaDevices::computeUserGesturePriviledge):
(WebCore::MediaDevices::getUserMedia):
(WebCore::MediaDevices::enumerateDevices):
(WebCore::MediaDevices::listenForDeviceChanges):
* Source/WebCore/Modules/mediastream/NavigatorMediaDevices.cpp:
(WebCore::NavigatorMediaDevices::from):
(WebCore::NavigatorMediaDevices::mediaDevices const):

Canonical link: https://commits.webkit.org/292345@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c635cf: DFG ASSERTION FAILED: AI-clobberize disagreement i...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c635cf4f53f3ff908c83ae627775817944c129ca
  
https://github.com/WebKit/WebKit/commit/c635cf4f53f3ff908c83ae627775817944c129ca
  Author: Yusuke Suzuki 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
A JSTests/stress/new-regexp-untyped-clobber-world.js
M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h

  Log Message:
  ---
  DFG ASSERTION FAILED: AI-clobberize disagreement in Symbol.matchAll.
https://bugs.webkit.org/show_bug.cgi?id=289959
rdar://147331449

Reviewed by Mark Lam.

NewRegExpUntyped should declare clobberWorld in AI when it does not have
StringUse edges.

* JSTests/stress/new-regexp-untyped-clobber-world.js: Added.
* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):

Canonical link: https://commits.webkit.org/292332@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 587d18: Better encapsulate coordinate fixups in Positioned...

[fantasai]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 587d18d0c38b403a354f903f967829658131a80e
  
https://github.com/WebKit/WebKit/commit/587d18d0c38b403a354f903f967829658131a80e
  Author: Elika Etemad 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebCore/rendering/PositionedLayoutConstraints.cpp
M Source/WebCore/rendering/PositionedLayoutConstraints.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/style/AnchorPositionEvaluator.cpp
M Source/WebCore/style/StyleTreeResolver.cpp

  Log Message:
  ---
  Better encapsulate coordinate fixups in PositionedLayoutConstraints
https://bugs.webkit.org/show_bug.cgi?id=289914
rdar://147250575

Reviewed by Alan Baradlay.

1. Caches the inset-modified containing block into PositionedLayoutConstraints.
2. Extracts various coordinate fixups into fixup methods in 
PositionedLayoutConstraints.
3. Compresses RenderBox fixup code into simply calling those fixup methods.

* Source/WebCore/rendering/PositionedLayoutConstraints.cpp:
(WebCore::PositionedLayoutConstraints::PositionedLayoutConstraints):
Capture inset-modified containing block geometry.

(WebCore::PositionedLayoutConstraints::resolvePosition const):
Used cached inset-modified containing block geometry.

(WebCore::PositionedLayoutConstraints::fixupLogicalLeftPosition const):
(WebCore::PositionedLayoutConstraints::fixupLogicalTopPosition const):
(WebCore::PositionedLayoutConstraints::convertLogicalLeftValue const): Deleted.
(WebCore::PositionedLayoutConstraints::convertLogicalTopValue const): Deleted.
Incorporate remaining coordinate fixup and simplify parameters.

* Source/WebCore/rendering/PositionedLayoutConstraints.h:
(WebCore::PositionedLayoutConstraints::containingSize const):
(WebCore::PositionedLayoutConstraints::insetModifiedContainingSize const):
(WebCore::PositionedLayoutConstraints::availableContentSpace const):
(WebCore::PositionedLayoutConstraints::insetModifiedContainingBlockSize const): 
Deleted.
Update accessors to use cached inset-modified containing block geometry.

* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth const):
(WebCore::RenderBox::computePositionedLogicalHeight const):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced const):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced const):
(WebCore::adjustmentForRTLInlineBoxContainingBlock): Deleted.
* Source/WebCore/style/AnchorPositionEvaluator.cpp:
(WebCore::Style::AnchorPositionEvaluator::overflowsInsetModifiedContainingBlock):
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::sortPositionOptionsIfNeeded):
Update to use new methods.

Canonical link: https://commits.webkit.org/292344@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 206e18: REGRESSION(290302@main): [ Internal macOS Release ...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 206e18a61007efae0d1e6534bca38d27e579cce4
  
https://github.com/WebKit/WebKit/commit/206e18a61007efae0d1e6534bca38d27e579cce4
  Author: Rupin Mittal 
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp

  Log Message:
  ---
  REGRESSION(290302@main): [ Internal macOS Release ] 
webrtc/datachannel/mdns-ice-candidates.html is a constant failure.
https://bugs.webkit.org/show_bug.cgi?id=289996
rdar://146984903

Reviewed by Brady Eidson.

https://commits.webkit.org/290302@main incorrectly changed
`localAddressStorageLength` to be the size of the struct
`sockaddr` (16 bytes) from the size of the struct
`sockaddr_storage` (128 bytes) which caused this test to fail.

We fix this test by undoing that change.

* Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp:
(WebKit::getSocketLocalAddress):

Canonical link: https://commits.webkit.org/292347@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes