Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c3717279a34a046c62d5bd225c79e75c08e390b5 https://github.com/WebKit/WebKit/commit/c3717279a34a046c62d5bd225c79e75c08e390b5 Author: Ben Grant <b...@bun.sh> Date: 2025-03-18 (Tue, 18 Mar 2025)
Changed paths: M Source/WTF/wtf/FileHandle.h Log Message: ----------- Fix compile error on Windows due to invalid constexpr https://bugs.webkit.org/show_bug.cgi?id=290001 Reviewed by Fujii Hironori. The functions in Win32HandleMarkableTraits cannot be constexpr because they read invalidPlatformFileHandle, which is not constexpr, and cannot be made constexpr because its initializer uses a cast equivalent to reinterpret_cast. The Windows definition of invalidPlatformFileHandle is also changed to use the INVALID_HANDLE_VALUE macro instead of a copy of that macro's logic. * Source/WTF/wtf/FileHandle.h: (WTF::FileSystemImpl::Win32HandleMarkableTraits::isEmptyValue): (WTF::FileSystemImpl::Win32HandleMarkableTraits::emptyValue): Canonical link: https://commits.webkit.org/292340@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes