[webkit-changes] [WebKit/WebKit] 93bde1: Cherry-pick 276925@main (59cedf7135bc). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 93bde17ed761f5de54726de83ced4959303794c6 https://github.com/WebKit/WebKit/commit/93bde17ed761f5de54726de83ced4959303794c6 Author: Abrar Rahman Protyasha Date: 2024-04-12 (Fri, 12 Apr 2024) Changed paths: M Source/WebCore/page/ViewportConfiguration.cpp M Source/WebCore/page/ViewportConfiguration.h Log Message: --- Cherry-pick 276925@main (59cedf7135bc). https://bugs.webkit.org/show_bug.cgi?id=271962 Linker error when logging ViewportConfiguration to TextStream in Release configuration https://bugs.webkit.org/show_bug.cgi?id=271962 rdar://125713559 Reviewed by Sihui Liu. WebCore::operator<<(WTF::TextStream&, WebCore::ViewConfiguration const&) is defined behind !LOG_DISABLED, which means in Release configuration, the linker cannot find this definition. This patch fixes the linker error by removing the relevant !LOG_DISABLED checks around both the operator<< overload definition and the description()/dump() declarations, since said methods are referenced by the operator<< overload. * Source/WebCore/page/ViewportConfiguration.cpp: (WebCore::ViewportConfiguration::setIsKnownToLayOutWiderThanViewport): (WebCore::ViewportConfiguration::dump const): * Source/WebCore/page/ViewportConfiguration.h: Canonical link: https://commits.webkit.org/276925@main Canonical link: https://commits.webkit.org/274313.133@webkitglib/2.44 Commit: aff53249f2d491d082094a2aa57008c46e55d278 https://github.com/WebKit/WebKit/commit/aff53249f2d491d082094a2aa57008c46e55d278 Author: Erica Li Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/WebCore/html/ImageDocument.cpp Log Message: --- Cherry-pick 276379@main (d036679431a5). https://bugs.webkit.org/show_bug.cgi?id=271028 ASAN_SEGV | WebCore::LocalFrame::injectUserScripts. rdar://124432384 https://bugs.webkit.org/show_bug.cgi?id=271028 Reviewed by Ryosuke Niwa. Frame might be detached early, null checking before injectUserScripts from image document. * Source/WebCore/html/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): Canonical link: https://commits.webkit.org/276379@main Canonical link: https://commits.webkit.org/274313.134@webkitglib/2.44 Compare: https://github.com/WebKit/WebKit/compare/8ce83c4bf224...aff53249f2d4 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 30130d: Break-word with a float can discard text
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 30130d3b5da29c0f75b942c0ecf2c1430151fbf2 https://github.com/WebKit/WebKit/commit/30130d3b5da29c0f75b942c0ecf2c1430151fbf2 Author: Alan Baradlay Date: 2024-04-13 (Sat, 13 Apr 2024) Changed paths: A LayoutTests/fast/text/missing-content-in-tight-space-with-float-expected.html A LayoutTests/fast/text/missing-content-in-tight-space-with-float.html M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp Log Message: --- Break-word with a float can discard text https://bugs.webkit.org/show_bug.cgi?id=272534 Reviewed by Antti Koivisto. 1. a suspended float gets placed on the current line (a float that we couldn't place while processing the previous line) 2. due to tight space and arbitrary breaking position, only partial content gets placed next to the float (e.g. [arbitrary] -> [arb][itrary] -where only the first part gets placed) In such cases we incorrectly compute the end of the "laid out" inline item range. This incorrectly computed range points to the end of inline item ([arbitrary]) as opposed to somewhere in the middle ([arb]) which makes us think the next line starts _after_ [arbitrary]. * LayoutTests/fast/text/missing-content-in-tight-space-with-float-expected.html: Added. * LayoutTests/fast/text/missing-content-in-tight-space-with-float.html: Added. * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::placeInlineAndFloatContent): Canonical link: https://commits.webkit.org/277461@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 68cebc: Use std::span in InspectorStyleSheet.cpp and Appli...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 68cebc10af146d4dd585d0c68e703f526c5027e8 https://github.com/WebKit/WebKit/commit/68cebc10af146d4dd585d0c68e703f526c5027e8 Author: Chris Dumez Date: 2024-04-13 (Sat, 13 Apr 2024) Changed paths: M Source/WebCore/inspector/InspectorStyleSheet.cpp M Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp Log Message: --- Use std::span in InspectorStyleSheet.cpp and ApplicationCacheManifestParser.cpp https://bugs.webkit.org/show_bug.cgi?id=272634 Reviewed by Brent Fulgham. * Source/WebCore/inspector/InspectorStyleSheet.cpp: (WebCore::StyleSheetHandler::setRuleHeaderEnd): (WebCore::StyleSheetHandler::endRuleHeader): * Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp: (WebCore::makeManifestURL): (WebCore::parseApplicationCacheManifest): Canonical link: https://commits.webkit.org/277463@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d2a029: Update StringParsingBuffer to use std::span
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d2a029f757b316ef28a6935af9d87a3b9d9d72e2 https://github.com/WebKit/WebKit/commit/d2a029f757b316ef28a6935af9d87a3b9d9d72e2 Author: Chris Dumez Date: 2024-04-13 (Sat, 13 Apr 2024) Changed paths: M Source/JavaScriptCore/runtime/ISO8601.cpp M Source/WTF/wtf/text/StringParsingBuffer.h M Source/WebCore/css/parser/CSSCustomPropertySyntax.cpp M Source/WebCore/css/parser/CSSCustomPropertySyntax.h M Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp M Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp M Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp M Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.h M Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp M Source/WebCore/page/csp/ContentSecurityPolicySourceList.h M Source/WebCore/page/csp/ContentSecurityPolicyTrustedTypesDirective.cpp M Source/WebCore/svg/SVGParserUtilities.cpp M Source/WebCore/svg/SVGPathStringViewSource.cpp M Tools/TestWebKitAPI/Tests/WTF/StringParsingBuffer.cpp Log Message: --- Update StringParsingBuffer to use std::span https://bugs.webkit.org/show_bug.cgi?id=272630 Reviewed by Darin Adler. Update StringParsingBuffer to use std::span. * Source/JavaScriptCore/runtime/ISO8601.cpp: (JSC::ISO8601::parseTimeSpec): * Source/WTF/wtf/text/StringParsingBuffer.h: (WTF::readCharactersForParsing): * Source/WebCore/css/parser/CSSCustomPropertySyntax.cpp: (WebCore::CSSCustomPropertySyntax::parseComponent): (WebCore::CSSCustomPropertySyntax::parse): * Source/WebCore/css/parser/CSSCustomPropertySyntax.h: * Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp: (WebCore::HTMLFastPathParser::HTMLFastPathParser): * Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp: (WebCore::parseApplicationCacheManifest): * Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp: (WebCore::ContentSecurityPolicyDirectiveList::parse): (WebCore::ContentSecurityPolicyDirectiveList::parseDirective): * Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.h: * Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp: (WebCore::ContentSecurityPolicySourceList::parse): (WebCore::ContentSecurityPolicySourceList::parseSource): (WebCore::ContentSecurityPolicySourceList::parseHost): (WebCore::ContentSecurityPolicySourceList::parsePath): (WebCore::ContentSecurityPolicySourceList::parsePort): * Source/WebCore/page/csp/ContentSecurityPolicySourceList.h: * Source/WebCore/page/csp/ContentSecurityPolicyTrustedTypesDirective.cpp: (WebCore::ContentSecurityPolicyTrustedTypesDirective::parse): * Source/WebCore/svg/SVGParserUtilities.cpp: (WebCore::parseUnicodeRange): (WebCore::parseKerningUnicodeString): * Source/WebCore/svg/SVGPathStringViewSource.cpp: (WebCore::SVGPathStringViewSource::SVGPathStringViewSource): * Tools/TestWebKitAPI/Tests/WTF/StringParsingBuffer.cpp: (TestWebKitAPI::TEST(WTF, StringParsingBufferInitial)): (TestWebKitAPI::TEST(WTF, StringParsingBufferAdvance)): (TestWebKitAPI::TEST(WTF, StringParsingBufferAdvanceBy)): (TestWebKitAPI::TEST(WTF, StringParsingBufferPreIncrement)): (TestWebKitAPI::TEST(WTF, StringParsingBufferPostIncrement)): (TestWebKitAPI::TEST(WTF, StringParsingBufferPlusEquals)): (TestWebKitAPI::TEST(WTF, StringParsingBufferEnd)): (TestWebKitAPI::TEST(WTF, StringParsingBufferSubscript)): (TestWebKitAPI::TEST(WTF, StringParsingBufferStringView)): Canonical link: https://commits.webkit.org/277466@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fd9e18: Update StringView::UpconvertedCharactersWithSize t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fd9e18c7f3c6303f8a7bb1d8b0af8767bb392410 https://github.com/WebKit/WebKit/commit/fd9e18c7f3c6303f8a7bb1d8b0af8767bb392410 Author: Chris Dumez Date: 2024-04-13 (Sat, 13 Apr 2024) Changed paths: M Source/JavaScriptCore/runtime/IntlCache.cpp M Source/JavaScriptCore/runtime/IntlCache.h M Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp M Source/WTF/wtf/text/StringImpl.cpp M Source/WTF/wtf/text/StringView.h M Source/WebCore/PAL/pal/text/TextCodecCJK.cpp M Source/WebCore/editing/Editor.cpp M Source/WebCore/html/parser/HTMLTreeBuilder.cpp M Source/WebCore/platform/Length.cpp M Source/WebCore/platform/SharedStringHash.cpp M Source/WebCore/platform/TelephoneNumberDetector.h M Source/WebCore/platform/cocoa/TelephoneNumberDetectorCocoa.cpp M Source/WebCore/platform/graphics/StringTruncator.cpp M Tools/TestWebKitAPI/Tests/WTF/StringView.cpp Log Message: --- Update StringView::UpconvertedCharactersWithSize to store its size https://bugs.webkit.org/show_bug.cgi?id=272629 Reviewed by Darin Adler. Update StringView::UpconvertedCharactersWithSize to store its size and add a span() function. * Source/JavaScriptCore/runtime/IntlCache.cpp: (JSC::IntlCache::getBestDateTimePattern): * Source/JavaScriptCore/runtime/IntlCache.h: * Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp: (JSC::IntlDateTimeFormat::initializeDateTimeFormat): * Source/WTF/wtf/text/StringImpl.cpp: (WTF::StringImpl::convertToUppercaseWithoutLocale): (WTF::StringImpl::convertToLowercaseWithLocale): (WTF::StringImpl::convertToUppercaseWithLocale): (WTF::StringImpl::foldCase): * Source/WTF/wtf/text/StringView.h: (WTF::StringView::UpconvertedCharactersWithSize::operator const UChar* const): (WTF::StringView::UpconvertedCharactersWithSize::get const): (WTF::StringView::UpconvertedCharactersWithSize::span const): (WTF::StringView::UpconvertedCharactersWithSize::UpconvertedCharactersWithSize): * Source/WebCore/PAL/pal/text/TextCodecCJK.cpp: (PAL::eucJPEncode): (PAL::iso2022JPEncode): (PAL::shiftJISEncode): (PAL::eucKREncode): (PAL::big5Encode): (PAL::gbEncodeShared): * Source/WebCore/editing/Editor.cpp: (WebCore::scanForTelephoneNumbers): * Source/WebCore/html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::linkifyPhoneNumbers): * Source/WebCore/platform/Length.cpp: (WebCore::newLengthArray): * Source/WebCore/platform/SharedStringHash.cpp: (WebCore::computeVisitedLinkHash): * Source/WebCore/platform/TelephoneNumberDetector.h: * Source/WebCore/platform/cocoa/TelephoneNumberDetectorCocoa.cpp: (WebCore::TelephoneNumberDetector::find): * Source/WebCore/platform/graphics/StringTruncator.cpp: (WebCore::stringWidth): (WebCore::truncateString): (WebCore::StringTruncator::width): * Tools/TestWebKitAPI/Tests/WTF/StringView.cpp: (TestWebKitAPI::TEST(WTF, StringViewUpconvert)): Canonical link: https://commits.webkit.org/277464@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ff42ff: Prefer checked ObjectC casts in ObjCObjectGraph
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ff42ff7f7c3827f5f57171879e1e979473336eae https://github.com/WebKit/WebKit/commit/ff42ff7f7c3827f5f57171879e1e979473336eae Author: Claudio Saavedra Date: 2024-04-13 (Sat, 13 Apr 2024) Changed paths: M Source/WebKit/Shared/mac/ObjCObjectGraph.mm Log Message: --- Prefer checked ObjectC casts in ObjCObjectGraph https://bugs.webkit.org/show_bug.cgi?id=272626 Reviewed by Darin Adler. Static casts are risky, prefer checked casts. * Source/WebKit/Shared/mac/ObjCObjectGraph.mm: (WebKit::ObjCObjectGraph::encode): Canonical link: https://commits.webkit.org/277467@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c83760: [Buildstream SDK] Update to libdav1d 1.4 and gst-p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8376090a588d29959d47b20ca522ab1c76dab0d https://github.com/WebKit/WebKit/commit/c8376090a588d29959d47b20ca522ab1c76dab0d Author: Philippe Normand Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Tools/buildstream/elements/freedesktop-sdk.bst A Tools/buildstream/elements/sdk/dav1d.bst M Tools/buildstream/elements/sdk/gst-plugin-dav1d.bst M Tools/buildstream/files/gst-plugin-dav1d/Cargo.lock A Tools/buildstream/files/gst-plugin-dav1d/dav1d-Cargo.toml Log Message: --- [Buildstream SDK] Update to libdav1d 1.4 and gst-plugin-dav1d from git main https://bugs.webkit.org/show_bug.cgi?id=272625 Reviewed by Adrian Perez de Castro. The dav1d project broke ABI between 1.2 and 1.4 versions. There's no release of gst-plugin-dav1d supporting the new ABI yet, so for the time being, vendor the development version, which comes with improved colorimetry handling, required for the WebCodecs tests. * Tools/buildstream/elements/freedesktop-sdk.bst: * Tools/buildstream/elements/sdk/dav1d.bst: Added. * Tools/buildstream/elements/sdk/gst-plugin-dav1d.bst: * Tools/buildstream/files/gst-plugin-dav1d/Cargo.lock: * Tools/buildstream/files/gst-plugin-dav1d/dav1d-Cargo.toml: Added. Canonical link: https://commits.webkit.org/277469@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 39ec95: [WebXR] Don't create WebXRSystem when iterating al...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 39ec95b06fd161d6480b867020ae4339b8f69e5e https://github.com/WebKit/WebKit/commit/39ec95b06fd161d6480b867020ae4339b8f69e5e Author: Dan Glastonbury Date: 2024-04-13 (Sat, 13 Apr 2024) Changed paths: M Source/WebCore/Modules/webxr/NavigatorWebXR.cpp M Source/WebCore/Modules/webxr/NavigatorWebXR.h M Source/WebCore/page/Page.cpp Log Message: --- [WebXR] Don't create WebXRSystem when iterating all DOM objects https://bugs.webkit.org/show_bug.cgi?id=272564 rdar://124261374 Reviewed by Cameron McCormack. WebCore::Page::hasActiveImmersiveSession() is creating a new WebXRSystem DOM object inside WebCore::ScriptExecutionContext::forEachActiveDOMObject(…) which is forbidden. If there is no WebXRSystem, we should consider that there is no active immersive session. * Source/WebCore/Modules/webxr/NavigatorWebXR.cpp: (WebCore::NavigatorWebXR::xrIfExists): * Source/WebCore/Modules/webxr/NavigatorWebXR.h: * Source/WebCore/page/Page.cpp: (WebCore::Page::hasActiveImmersiveSession const): Canonical link: https://commits.webkit.org/277468@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b014ce: Adopt std::span in rendering/BreakLines.h
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b014ce30e747780ea800ba482c970853131bfa69 https://github.com/WebKit/WebKit/commit/b014ce30e747780ea800ba482c970853131bfa69 Author: Chris Dumez Date: 2024-04-13 (Sat, 13 Apr 2024) Changed paths: M Source/WebCore/rendering/BreakLines.h Log Message: --- Adopt std::span in rendering/BreakLines.h https://bugs.webkit.org/show_bug.cgi?id=272631 Reviewed by Brent Fulgham. * Source/WebCore/rendering/BreakLines.h: (WebCore::nextBreakablePosition): (WebCore::nextBreakablePositionKeepingAllWords): (WebCore::nextBreakablePositionKeepingAllWordsIgnoringNBSP): (WebCore::nextBreakablePositionIgnoringNBSP): (WebCore::nextBreakablePositionWithoutShortcut): (WebCore::nextBreakablePositionIgnoringNBSPWithoutShortcut): Canonical link: https://commits.webkit.org/277465@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 907d98: [GTK][WPE] missing URI for injected user scripts a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 907d986d108c64d34ca622b88ec666a5152e5d18 https://github.com/WebKit/WebKit/commit/907d986d108c64d34ca622b88ec666a5152e5d18 Author: Przemyslaw Gorszkowski Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M LayoutTests/userscripts/window-onerror-for-isolated-world-1-expected.txt M LayoutTests/userscripts/window-onerror-for-isolated-world-2-expected.txt M LayoutTests/userscripts/window-onerror-for-isolated-world-3-expected.txt M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj A Source/WebCore/page/UserScript.cpp M Source/WebCore/page/UserScript.h A Source/WebCore/page/UserStyleSheet.cpp M Source/WebCore/page/UserStyleSheet.h M Source/WebCore/page/WorkerNavigator.cpp M Source/WebKit/UIProcess/API/APIUserScript.cpp M Source/WebKit/UIProcess/API/APIUserScript.h M Source/WebKit/UIProcess/API/APIUserStyleSheet.cpp M Source/WebKit/UIProcess/API/APIUserStyleSheet.h M Source/WebKit/UIProcess/API/C/WKUserScriptRef.cpp M Source/WebKit/UIProcess/API/Cocoa/WKUserScript.mm M Source/WebKit/UIProcess/API/Cocoa/_WKUserStyleSheet.mm Log Message: --- [GTK][WPE] missing URI for injected user scripts and style sheets https://bugs.webkit.org/show_bug.cgi?id=272152 Reviewed by Adrian Perez de Castro. User scripts/style sheets without the URI are not visible in WebInspector. With this change the URI of injected user scripts/style sheets are generated as: user-script:incremented_identifier user-style:incremented_identifier * LayoutTests/userscripts/window-onerror-for-isolated-world-1-expected.txt: * LayoutTests/userscripts/window-onerror-for-isolated-world-2-expected.txt: * LayoutTests/userscripts/window-onerror-for-isolated-world-3-expected.txt: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/page/UserScript.cpp: Copied from Source/WebKit/UIProcess/API/APIUserScript.cpp. (WebCore::generateUniqueURL): (WebCore::UserScript::UserScript): * Source/WebCore/page/UserScript.h: (WebCore::UserScript::UserScript): Deleted. * Source/WebCore/page/UserStyleSheet.cpp: Copied from Source/WebKit/UIProcess/API/APIUserScript.cpp. (WebCore::generateUniqueURL): (WebCore::UserStyleSheet::UserStyleSheet): * Source/WebCore/page/UserStyleSheet.h: * Source/WebCore/page/WorkerNavigator.cpp: * Source/WebKit/UIProcess/API/APIUserScript.cpp: (API::UserScript::generateUniqueURL): Deleted. * Source/WebKit/UIProcess/API/APIUserScript.h: * Source/WebKit/UIProcess/API/APIUserStyleSheet.cpp: (API::UserStyleSheet::generateUniqueURL): Deleted. * Source/WebKit/UIProcess/API/APIUserStyleSheet.h: * Source/WebKit/UIProcess/API/C/WKUserScriptRef.cpp: (WKUserScriptCreateWithSource): Canonical link: https://commits.webkit.org/277470@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c8fd17: [Skia] Do not force C++17 standard
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8fd178546fa83c6898f1828f05b00d8d8f13f48 https://github.com/WebKit/WebKit/commit/c8fd178546fa83c6898f1828f05b00d8d8f13f48 Author: Claudio Saavedra Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/ThirdParty/skia/CMakeLists.txt Log Message: --- [Skia] Do not force C++17 standard https://bugs.webkit.org/show_bug.cgi?id=272650 Reviewed by Chris Dumez. Building with C++17 is causing issues during the adoption of std::span in WebKit, let's not force it and let Skia build with C++20 and fix build issues as they come for now. * Source/ThirdParty/skia/CMakeLists.txt: Canonical link: https://commits.webkit.org/277471@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0ad7f8: Digital Credentials: IdentityRequestProvider's req...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ad7f8d69556cdbc2a8fa57775dfcf1c5e5cffe5 https://github.com/WebKit/WebKit/commit/0ad7f8d69556cdbc2a8fa57775dfcf1c5e5cffe5 Author: Marcos Caceres Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M LayoutTests/http/wpt/identity/identitycredentialscontainer-get-basics.https.html M LayoutTests/http/wpt/identity/idl.https.html M Source/WebCore/Modules/identity/IdentityRequestProvider.h M Source/WebCore/Modules/identity/IdentityRequestProvider.idl Log Message: --- Digital Credentials: IdentityRequestProvider's request should be an object https://bugs.webkit.org/show_bug.cgi?id=272443 rdar://126244307 Reviewed by Abrar Rahman Protyasha. Changed IdentityRequestProvider's request member to an object. Spec change: https://github.com/WICG/digital-identities/pull/97/ * LayoutTests/http/wpt/identity/identitycredentialscontainer-get-basics.https.html: * LayoutTests/http/wpt/identity/idl.https.html: * Source/WebCore/Modules/identity/IdentityRequestProvider.h: * Source/WebCore/Modules/identity/IdentityRequestProvider.idl: Canonical link: https://commits.webkit.org/277472@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40fa4e: Fix crash when entering fullscreen on SafariViewSe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40fa4e20214dd087e4fa7552266f84c779ba12a7 https://github.com/WebKit/WebKit/commit/40fa4e20214dd087e4fa7552266f84c779ba12a7 Author: Dana Estra Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm Log Message: --- Fix crash when entering fullscreen on SafariViewService https://bugs.webkit.org/show_bug.cgi?id=272562 rdar://126017564 Reviewed by Andy Estes. This patch reverts part of changes made by https://commits.webkit.org/276177@main to VideoPresentationInterfaceIOS::doSetup(). Only calling -addChildViewController: and -didMoveToParentViewController: when there is an m_viewController fixes the crash. * Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm: (WebCore::VideoPresentationInterfaceIOS::doSetup): Canonical link: https://commits.webkit.org/277473@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 292927: FindString should not be sent twice if a webpage h...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 292927b976641ccbaa30c5fd67d256589f7fc306 https://github.com/WebKit/WebKit/commit/292927b976641ccbaa30c5fd67d256589f7fc306 Author: Charlie Wolfe Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/WebKit/UIProcess/BrowsingContextGroup.cpp M Source/WebKit/UIProcess/BrowsingContextGroup.h M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- FindString should not be sent twice if a webpage has no iframe processes https://bugs.webkit.org/show_bug.cgi?id=271029 rdar://124652108 Reviewed by Alex Christensen. With site isolation, we need to search all web processes initially without setting selection because we do not know which frame should receive selection until we know which frames have matches. If a webpage has no iframe processes, or site isolation is disabled, we don’t need to do this because we can synchronously search all frames in the web process. So we should just send one FindString message in this situation. * Source/WebKit/UIProcess/BrowsingContextGroup.cpp: (WebKit::BrowsingContextGroup::hasRemotePages): * Source/WebKit/UIProcess/BrowsingContextGroup.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::findString): Canonical link: https://commits.webkit.org/277474@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 52af77: [Remote Inspection] Targeting incorrectly prefers ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 52af773ed3aebb787b7471e81634d5d68d2f7923 https://github.com/WebKit/WebKit/commit/52af773ed3aebb787b7471e81634d5d68d2f7923 Author: Wenson Hsieh Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: A LayoutTests/fast/element-targeting/target-container-with-pseudo-elements-expected.txt A LayoutTests/fast/element-targeting/target-container-with-pseudo-elements.html M Source/WebCore/page/ElementTargetingController.cpp Log Message: --- [Remote Inspection] Targeting incorrectly prefers pseudos over targets that contain their hosts https://bugs.webkit.org/show_bug.cgi?id=272647 rdar://126299041 Reviewed by Abrar Rahman Protyasha. When a candidate is chosen as a target, logic in the while loop in `findTargets` filters out other candidate elements that are redundant, due to being contained within the newly chosen target. However, this logic doesn't currently handle pseudo elements correctly, which means that front-most pseudo elements are surfaced as higher-priority targets, even though another container element enclosing them has already been chosen. Fix this by augmenting the check to omit pseudo element candidates if their host element is contained within the newly chosen target. * LayoutTests/fast/element-targeting/target-container-with-pseudo-elements-expected.txt: Added. * LayoutTests/fast/element-targeting/target-container-with-pseudo-elements.html: Added. * Source/WebCore/page/ElementTargetingController.cpp: (WebCore::ElementTargetingController::findTargets): Canonical link: https://commits.webkit.org/277475@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c6ce2: Adopt std::span in GIFImageReader
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c6ce2d397a52ce87ebd8e320943148333d5ad8d https://github.com/WebKit/WebKit/commit/6c6ce2d397a52ce87ebd8e320943148333d5ad8d Author: Chris Dumez Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp M Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp M Source/WebCore/platform/image-decoders/gif/GIFImageReader.h Log Message: --- Adopt std::span in GIFImageReader https://bugs.webkit.org/show_bug.cgi?id=272640 Reviewed by Darin Adler. * Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow): * Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp: (GIFLZWContext::doLZW): (GIFFrameContext::decode): (GIFImageReader::decode): (GIFImageReader::parse): * Source/WebCore/platform/image-decoders/gif/GIFImageReader.h: (GIFImageReader::GIFImageReader): (GIFImageReader::setData): (GIFImageReader::globalColormap const): (GIFImageReader::localColormap const): (GIFImageReader::data const): (GIFImageReader::globalColormapSize const): Deleted. (GIFImageReader::localColormapSize const): Deleted. Canonical link: https://commits.webkit.org/277476@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a7472b: Adopt std::span in CryptographicallyRandomNumber
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a7472bcca17d5e3401523e9538f31d883e478fed https://github.com/WebKit/WebKit/commit/a7472bcca17d5e3401523e9538f31d883e478fed Author: Chris Dumez Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/WTF/wtf/Algorithms.h M Source/WTF/wtf/CryptographicallyRandomNumber.cpp M Source/WTF/wtf/CryptographicallyRandomNumber.h M Source/WTF/wtf/FileSystem.cpp M Source/WTF/wtf/OSRandomSource.cpp M Source/WTF/wtf/OSRandomSource.h M Source/WTF/wtf/RandomDevice.cpp M Source/WTF/wtf/RandomDevice.h M Source/WTF/wtf/UUID.cpp M Source/WTF/wtf/persistence/PersistentCoders.cpp M Source/WTF/wtf/persistence/PersistentCoders.h M Source/WTF/wtf/text/Base64.cpp M Source/WTF/wtf/win/FileSystemWin.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp M Source/WebCore/Modules/push-api/PushMessageCrypto.cpp M Source/WebCore/Modules/websockets/WebSocketFrame.cpp M Source/WebCore/Modules/websockets/WebSocketHandshake.cpp M Source/WebCore/PAL/pal/text/win/TextCodecWin.cpp M Source/WebCore/bindings/js/SerializedScriptValue.cpp M Source/WebCore/crypto/CryptoKey.cpp M Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp M Source/WebCore/page/Crypto.cpp M Source/WebCore/platform/sql/SQLiteStatement.cpp M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h M Source/WebKit/Platform/IPC/DaemonCoders.h M Source/WebKit/Platform/IPC/Encoder.h M Source/WebKit/Platform/IPC/StreamConnectionEncoder.h M Source/WebKit/Shared/IPCTester.cpp M Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp M Source/WebKit/UIProcess/API/C/WKPage.cpp M Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp M Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp M Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp M Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualHidConnection.cpp M Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp M Tools/TestWebKitAPI/Tests/WebCore/curl/CurlMultipartHandleTests.cpp Log Message: --- Adopt std::span in CryptographicallyRandomNumber https://bugs.webkit.org/show_bug.cgi?id=272635 Reviewed by Darin Adler. * Source/WTF/wtf/CryptographicallyRandomNumber.cpp: (WTF::cryptographicallyRandomValues): * Source/WTF/wtf/CryptographicallyRandomNumber.h: * Source/WTF/wtf/FileSystem.cpp: (WTF::FileSystemImpl::makeSalt): * Source/WTF/wtf/OSRandomSource.cpp: (WTF::cryptographicallyRandomValuesFromOS): * Source/WTF/wtf/OSRandomSource.h: * Source/WTF/wtf/RandomDevice.cpp: (WTF::RandomDevice::cryptographicallyRandomValues): * Source/WTF/wtf/RandomDevice.h: * Source/WTF/wtf/UUID.cpp: (WTF::generateCryptographicallyRandomUUIDVersion4): * Source/WTF/wtf/win/FileSystemWin.cpp: (WTF::FileSystemImpl::generateTemporaryPath): * Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp: (WebCore::generateCertificate): * Source/WebCore/Modules/push-api/PushMessageCrypto.cpp: (WebCore::PushCrypto::ClientKeys::generate): * Source/WebCore/Modules/websockets/WebSocketFrame.cpp: (WebCore::appendFramePayload): * Source/WebCore/Modules/websockets/WebSocketHandshake.cpp: (WebCore::generateSecWebSocketKey): * Source/WebCore/crypto/CryptoKey.cpp: (WebCore::CryptoKey::randomData): * Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp: (WebCore::generateRandomBoundary): * Source/WebCore/page/Crypto.cpp: (WebCore::Crypto::getRandomValues): * Source/WebKit/Shared/IPCTester.cpp: * Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp: (WebKit::DeviceIdHashSaltStorage::completeDeviceIdHashSaltForOriginCall): * Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp: (WebKit::UserMediaPermissionRequestManagerProxy::ephemeralDeviceHashSaltForFrame): * Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp: (WebKit::MockHidConnection::feedReports): * Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualHidConnection.cpp: (WebKit::VirtualHidConnection::parseRequest): Canonical link: https://commits.webkit.org/277477@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9ec336: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9ec33623cd2e30550c5a9b39546ee0e02ac54775 https://github.com/WebKit/WebKit/commit/9ec33623cd2e30550c5a9b39546ee0e02ac54775 Author: Fujii Hironori Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/277478@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6de368: Update WPT css/css-color/parsing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6de3683da41cd05774e766c22dda0a6c90479afb https://github.com/WebKit/WebKit/commit/6de3683da41cd05774e766c22dda0a6c90479afb Author: Sam Weinig Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/WEB_FEATURES.yml M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-mix-function-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-mix-function.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-relative-color-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-relative-color.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/w3c-import.log Log Message: --- Update WPT css/css-color/parsing https://bugs.webkit.org/show_bug.cgi?id=272651 Reviewed by Tim Nguyen. Update WPT css/css-color/parsing to daa07cf3c47652ed67e637f2a39bbc34f91cfe10. * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/WEB_FEATURES.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-mix-function-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-mix-function.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-relative-color-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-relative-color.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/w3c-import.log: Canonical link: https://commits.webkit.org/277479@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 89b306: Cherry-pick 275915@main (565848432d81). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 89b306093de10ea247e6af7718fed8119dd364a8 https://github.com/WebKit/WebKit/commit/89b306093de10ea247e6af7718fed8119dd364a8 Author: Diego Pino Garcia Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/ThirdParty/libwebrtc/CMakeLists.txt Log Message: --- Cherry-pick 275915@main (565848432d81). https://bugs.webkit.org/show_bug.cgi?id=270689 [WPE] [LibWebRTC] Fix build for ARM 32-bit https://bugs.webkit.org/show_bug.cgi?id=270689 Reviewed by Philippe Normand. Set build flags "-mfpu=neon;-mfloat-abi=hard" on several files that need them. * Source/ThirdParty/libwebrtc/CMakeLists.txt: Canonical link: https://commits.webkit.org/275915@main Canonical link: https://commits.webkit.org/274313.135@webkitglib/2.44 Commit: 9b801864fd4395f8869236220c1220dd3875fe97 https://github.com/WebKit/WebKit/commit/9b801864fd4395f8869236220c1220dd3875fe97 Author: Vitaly Dyachkov Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp Log Message: --- Cherry-pick 275785@main (4a1b2c8aedf2). https://bugs.webkit.org/show_bug.cgi?id=270447 [GTK][Debug] ASSERTs on inspector tests https://bugs.webkit.org/show_bug.cgi?id=270447 Reviewed by Carlos Garcia Campos. `InspectorTimelineAgent` uses a stack to store timeline records and expects `pushCurrentRecord()`/`didCompleteCurrentRecord()` to be called in the correct order. But since frame rendering occurs more frequently than compositing, associated records may be processed in the wrong order: - push `TimelineRecordType::RenderingFrame` - push `TimelineRecordType::Composite` - complete `TimelineRecordType::RenderingFrame` - complete `TimelineRecordType::Composite` To prevent this, we must explicitly call `didComposite()` before pushing a new `RenderingFrame` record, like it's done on Mac. * Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::internalStart): Canonical link: https://commits.webkit.org/275785@main Canonical link: https://commits.webkit.org/274313.136@webkitglib/2.44 Commit: 579b6eb1766f7715f1204c98bcb9b79491f55f72 https://github.com/WebKit/WebKit/commit/579b6eb1766f7715f1204c98bcb9b79491f55f72 Author: Miguel Gomez Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/WebCore/platform/gamepad/libwpe/GamepadLibWPE.cpp M Source/WebCore/platform/gamepad/manette/ManetteGamepad.cpp Log Message: --- Cherry-pick 275781@main (6b3a8aa7666d). https://bugs.webkit.org/show_bug.cgi?id=270575 [GTK][WPE] Make gamepad visible/connected on axis movement https://bugs.webkit.org/show_bug.cgi?id=270575 Reviewed by Michael Catanzaro. Dispatch the gamepadconnected event when an axis is moved. * Source/WebCore/platform/gamepad/libwpe/GamepadLibWPE.cpp: (WebCore::GamepadLibWPE::absoluteAxisChanged): * Source/WebCore/platform/gamepad/manette/ManetteGamepad.cpp: (WebCore::ManetteGamepad::absoluteAxisChanged): Canonical link: https://commits.webkit.org/275781@main Canonical link: https://commits.webkit.org/274313.137@webkitglib/2.44 Commit: 0be271d358f82c1dcbb470b2b339133c02e99f34 https://github.com/WebKit/WebKit/commit/0be271d358f82c1dcbb470b2b339133c02e99f34 Author: Georges Basile Stavracas Neto Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.cpp M Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.h Log Message: --- Cherry-pick 275746@main (18a97d248bdc). https://bugs.webkit.org/show_bug.cgi?id=220253 [WPE][GTK] Implement portal-based geolocation https://bugs.webkit.org/show_bug.cgi?id=220253 Reviewed by Michael Catanzaro. This turned into a somewhat messy patch, but the principle behind it is to try and use the Location portal first, and fallback to the direct Geoclue calls that it already does. The Location portal has two particular steps: (1) create a geolocation session, and (2) start the session and get geolocation updates. Step 1 is where the location accuracy is set. For this reason, unlike the direct Geoclue code path, we have to close and recreate the Location portal session when high accuracy mode changes. Talking about high accuracy mode, apparently the new value was never stored into m_isHighAccuracyEnabled! This is fixed in this patch too. Step 2 is where the Location session is started. Only after this call that we'd receive geolocation position updates. In theory we'd be able to pass a parent window handler in this step, and that would allow the desktop environment to nicely place access control requests on it; that is not currentl
[webkit-changes] [WebKit/WebKit] 8c35e0: Move std::span-related utility functions to
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8c35e078b772cb94d9436eef8a90a33a2c718088 https://github.com/WebKit/WebKit/commit/8c35e078b772cb94d9436eef8a90a33a2c718088 Author: Chris Dumez Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/WTF/wtf/Algorithms.h M Source/WTF/wtf/StdLibExtras.h M Source/WTF/wtf/persistence/PersistentCoders.cpp M Source/WTF/wtf/persistence/PersistentCoders.h M Source/WTF/wtf/text/Base64.cpp M Source/WTF/wtf/text/WTFString.cpp M Source/WebCore/PAL/pal/text/win/TextCodecWin.cpp M Source/WebCore/bindings/js/SerializedScriptValue.cpp M Source/WebCore/dom/TextEncoder.cpp M Source/WebCore/platform/generic/KeyedEncoderGeneric.cpp M Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp M Source/WebCore/platform/sql/SQLiteStatement.cpp M Source/WebCore/workers/ScriptBuffer.cpp M Source/WebKit/NetworkProcess/storage/CacheStorageManager.cpp M Source/WebKit/Platform/IPC/DaemonCoders.h M Source/WebKit/Platform/IPC/Decoder.h M Source/WebKit/Platform/IPC/Encoder.h M Source/WebKit/Platform/IPC/StreamConnectionEncoder.h M Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp M Source/WebKit/UIProcess/API/C/WKPage.cpp M Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp M Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp M Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp M Tools/TestWebKitAPI/glib/CMakeLists.txt Log Message: --- Move std::span-related utility functions to https://bugs.webkit.org/show_bug.cgi?id=272653 Reviewed by Darin Adler and Sam Weinig. * Source/WTF/wtf/Algorithms.h: (WTF::spanReinterpretCast): Deleted. (WTF::sizeof): Deleted. (WTF::equalSpans): Deleted. (WTF::memcpySpan): Deleted. (WTF::memsetSpan): Deleted. * Source/WTF/wtf/StdLibExtras.h: (WTF::spanReinterpretCast): (WTF::sizeof): (WTF::equalSpans): (WTF::memcpySpan): (WTF::memsetSpan): * Source/WTF/wtf/persistence/PersistentCoders.cpp: * Source/WTF/wtf/persistence/PersistentCoders.h: * Source/WTF/wtf/text/Base64.cpp: * Source/WTF/wtf/text/WTFString.cpp: * Source/WebCore/PAL/pal/text/win/TextCodecWin.cpp: * Source/WebCore/bindings/js/SerializedScriptValue.cpp: * Source/WebCore/dom/TextEncoder.cpp: * Source/WebCore/platform/generic/KeyedEncoderGeneric.cpp: * Source/WebCore/platform/sql/SQLiteStatement.cpp: * Source/WebCore/workers/ScriptBuffer.cpp: * Source/WebKit/Platform/IPC/DaemonCoders.h: * Source/WebKit/Platform/IPC/Decoder.h: * Source/WebKit/Platform/IPC/Encoder.h: * Source/WebKit/Platform/IPC/StreamConnectionEncoder.h: * Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp: * Source/WebKit/UIProcess/API/C/WKPage.cpp: * Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp: * Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp: * Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp: * Tools/TestWebKitAPI/glib/CMakeLists.txt: Stop forcing build with C++17 since std::span requires C++20. Canonical link: https://commits.webkit.org/277480@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8a3d36: Add missing color interpolation methods added to C...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a3d3672b571656a923a0ed60872d771ac33b133 https://github.com/WebKit/WebKit/commit/8a3d3672b571656a923a0ed60872d771ac33b133 Author: Sam Weinig Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function-expected.txt M Source/WebCore/css/CSSGradientValue.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/platform/graphics/ColorInterpolationMethod.cpp M Source/WebCore/platform/graphics/ColorInterpolationMethod.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Add missing color interpolation methods added to CSS color since initial implementation https://bugs.webkit.org/show_bug.cgi?id=272646 Reviewed by Tim Nguyen. Adds support for the four additional color interpolation methods, `display-p3`, `a98-rgb`, `prophoto-rgb` and `rec2020`, that have been added as valid interpolation method color spaces since the initial implementation. Tests updated: imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function.html imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function.html * Source/WebCore/css/CSSGradientValue.cpp: (WebCore::appendColorInterpolationMethod): (WebCore::appendHueInterpolationMethod): Deleted. Refactor to re-use more of the existing serialization in ColorInterpolationMethod.h and reduce duplication by using a generic overload. * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeColorInterpolationMethod): Adds support for parsing the new color spaces. Also fixes the comment with the spec text to remove "specified" as a hue-interpolation-method as that is no longer supported (both in the spec and WebCore). * Source/WebCore/platform/graphics/ColorInterpolationMethod.cpp: (WebCore::serializationForCSS): (WebCore::operator<<): * Source/WebCore/platform/graphics/ColorInterpolationMethod.h: (WebCore::serializationForCSS): Add new interpolation method color spaces and their serialization. Expose a few serialization helpers so that the gradient serialization can use them as well. * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Update to match new definitions. Canonical link: https://commits.webkit.org/277481@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 913ff8: [view-transitions] Visual overflow rect should be ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 913ff8ca74490f55505e0e1211cda10dbd7ac43f https://github.com/WebKit/WebKit/commit/913ff8ca74490f55505e0e1211cda10dbd7ac43f Author: Matt Woodrow Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-changes-overflow-left-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-changes-overflow-left-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-changes-overflow-left.html M LayoutTests/platform/glib/TestExpectations M Source/WebCore/dom/ViewTransition.cpp M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/RenderViewTransitionCapture.cpp M Source/WebCore/rendering/RenderViewTransitionCapture.h M Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp Log Message: --- [view-transitions] Visual overflow rect should be recomputed at every frame https://bugs.webkit.org/show_bug.cgi?id=272496 Reviewed by Tim Nguyen. The existing code only read the visual overflow rect of the old element, and used it for both the new and old pseudo elements. The visual overflow of the new element should be copied every frame, and updated on the relevant pseudo element. This also exposed a bug where we were used the computed value for width and height as the specified style for the group pseudo, instead of using the border-box size. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-changes-overflow-left-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-changes-overflow-left-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-changes-overflow-left.html: Added. * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::captureOldState): (WebCore::ViewTransition::copyElementBaseProperties): (WebCore::ViewTransition::updatePseudoElementStyles): * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGeometry): * Source/WebCore/rendering/RenderViewTransitionCapture.cpp: (WebCore::RenderViewTransitionCapture::setImage): (WebCore::RenderViewTransitionCapture::setSize): * Source/WebCore/rendering/RenderViewTransitionCapture.h: * Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp: (WebCore::createRendererIfNeeded): Canonical link: https://commits.webkit.org/277482@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ba4c75: [Gardening]: REGRESSION (277328@main): [ MacOS WK1...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ba4c75e9f9fb1aa0eaae53f30ac4e005809166b5 https://github.com/WebKit/WebKit/commit/ba4c75e9f9fb1aa0eaae53f30ac4e005809166b5 Author: Jay Stfleur Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [Gardening]: REGRESSION (277328@main): [ MacOS WK1 ] fast/canvas/offscreen-nested-worker-serialization.html is a constant timeout https://bugs.webkit.org/show_bug.cgi?id=126461671 rdar://126461671 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/277483@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] faafe6: [GCC] Unreviewed, build fix for Ubuntu LTS after 2...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: faafe6773774b3c1b779ef5af3915fafc8ea7e87 https://github.com/WebKit/WebKit/commit/faafe6773774b3c1b779ef5af3915fafc8ea7e87 Author: Diego Pino Garcia Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp M Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp M Source/WebCore/page/csp/ContentSecurityPolicyTrustedTypesDirective.cpp Log Message: --- [GCC] Unreviewed, build fix for Ubuntu LTS after 277466@main https://bugs.webkit.org/show_bug.cgi?id=272630 Several build bots using GCC10.2 (Debian 11) and GCC 11.4 (Ubuntu 22.04) are failing, possibly due to limitations in the compiler. * Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp: (WebCore::parseApplicationCacheManifest): * Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp: (WebCore::ContentSecurityPolicySourceList::parse): * Source/WebCore/page/csp/ContentSecurityPolicyTrustedTypesDirective.cpp: (WebCore::ContentSecurityPolicyTrustedTypesDirective::parse): Canonical link: https://commits.webkit.org/277484@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
