Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 89b306093de10ea247e6af7718fed8119dd364a8 https://github.com/WebKit/WebKit/commit/89b306093de10ea247e6af7718fed8119dd364a8 Author: Diego Pino Garcia <dp...@igalia.com> Date: 2024-04-14 (Sun, 14 Apr 2024)
Changed paths: M Source/ThirdParty/libwebrtc/CMakeLists.txt Log Message: ----------- Cherry-pick 275915@main (565848432d81). https://bugs.webkit.org/show_bug.cgi?id=270689 [WPE] [LibWebRTC] Fix build for ARM 32-bit https://bugs.webkit.org/show_bug.cgi?id=270689 Reviewed by Philippe Normand. Set build flags "-mfpu=neon;-mfloat-abi=hard" on several files that need them. * Source/ThirdParty/libwebrtc/CMakeLists.txt: Canonical link: https://commits.webkit.org/275915@main Canonical link: https://commits.webkit.org/274313.135@webkitglib/2.44 Commit: 9b801864fd4395f8869236220c1220dd3875fe97 https://github.com/WebKit/WebKit/commit/9b801864fd4395f8869236220c1220dd3875fe97 Author: Vitaly Dyachkov <vit...@igalia.com> Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp Log Message: ----------- Cherry-pick 275785@main (4a1b2c8aedf2). https://bugs.webkit.org/show_bug.cgi?id=270447 [GTK][Debug] ASSERTs on inspector tests https://bugs.webkit.org/show_bug.cgi?id=270447 Reviewed by Carlos Garcia Campos. `InspectorTimelineAgent` uses a stack to store timeline records and expects `pushCurrentRecord()`/`didCompleteCurrentRecord()` to be called in the correct order. But since frame rendering occurs more frequently than compositing, associated records may be processed in the wrong order: - push `TimelineRecordType::RenderingFrame` - push `TimelineRecordType::Composite` - complete `TimelineRecordType::RenderingFrame` - complete `TimelineRecordType::Composite` To prevent this, we must explicitly call `didComposite()` before pushing a new `RenderingFrame` record, like it's done on Mac. * Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::internalStart): Canonical link: https://commits.webkit.org/275785@main Canonical link: https://commits.webkit.org/274313.136@webkitglib/2.44 Commit: 579b6eb1766f7715f1204c98bcb9b79491f55f72 https://github.com/WebKit/WebKit/commit/579b6eb1766f7715f1204c98bcb9b79491f55f72 Author: Miguel Gomez <mago...@igalia.com> Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/WebCore/platform/gamepad/libwpe/GamepadLibWPE.cpp M Source/WebCore/platform/gamepad/manette/ManetteGamepad.cpp Log Message: ----------- Cherry-pick 275781@main (6b3a8aa7666d). https://bugs.webkit.org/show_bug.cgi?id=270575 [GTK][WPE] Make gamepad visible/connected on axis movement https://bugs.webkit.org/show_bug.cgi?id=270575 Reviewed by Michael Catanzaro. Dispatch the gamepadconnected event when an axis is moved. * Source/WebCore/platform/gamepad/libwpe/GamepadLibWPE.cpp: (WebCore::GamepadLibWPE::absoluteAxisChanged): * Source/WebCore/platform/gamepad/manette/ManetteGamepad.cpp: (WebCore::ManetteGamepad::absoluteAxisChanged): Canonical link: https://commits.webkit.org/275781@main Canonical link: https://commits.webkit.org/274313.137@webkitglib/2.44 Commit: 0be271d358f82c1dcbb470b2b339133c02e99f34 https://github.com/WebKit/WebKit/commit/0be271d358f82c1dcbb470b2b339133c02e99f34 Author: Georges Basile Stavracas Neto <feane...@igalia.com> Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.cpp M Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.h Log Message: ----------- Cherry-pick 275746@main (18a97d248bdc). https://bugs.webkit.org/show_bug.cgi?id=220253 [WPE][GTK] Implement portal-based geolocation https://bugs.webkit.org/show_bug.cgi?id=220253 Reviewed by Michael Catanzaro. This turned into a somewhat messy patch, but the principle behind it is to try and use the Location portal first, and fallback to the direct Geoclue calls that it already does. The Location portal has two particular steps: (1) create a geolocation session, and (2) start the session and get geolocation updates. Step 1 is where the location accuracy is set. For this reason, unlike the direct Geoclue code path, we have to close and recreate the Location portal session when high accuracy mode changes. Talking about high accuracy mode, apparently the new value was never stored into m_isHighAccuracyEnabled! This is fixed in this patch too. Step 2 is where the Location session is started. Only after this call that we'd receive geolocation position updates. In theory we'd be able to pass a parent window handler in this step, and that would allow the desktop environment to nicely place access control requests on it; that is not currently supported by WebKit though, so just pass empty string for now. The destroy timer is used to release both Portal and Geoclue resources so name the timer and the corresponding methods to match that. Also rename Geoclue-specific methods to explicitly mention Geoclue, which helps following the callback chain. * Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.cpp: (WebKit::GeoclueGeolocationProvider::GeoclueGeolocationProvider): (WebKit::GeoclueGeolocationProvider::start): (WebKit::GeoclueGeolocationProvider::stop): (WebKit::GeoclueGeolocationProvider::setEnableHighAccuracy): (WebKit::GeoclueGeolocationProvider::destroyStateLater): (WebKit::GeoclueGeolocationProvider::destroyState): (WebKit::GeoclueGeolocationProvider::acquirePortalProxy): (WebKit::GeoclueGeolocationProvider::setupPortalProxy): (WebKit::GeoclueGeolocationProvider::createPortalSession): (WebKit::GeoclueGeolocationProvider::startPortalSession): (WebKit::GeoclueGeolocationProvider::portalLocationUpdated): (WebKit::GeoclueGeolocationProvider::stopPortalSession): (WebKit::GeoclueGeolocationProvider::createGeoclueManager): (WebKit::GeoclueGeolocationProvider::setupGeoclueManager): (WebKit::GeoclueGeolocationProvider::createGeoclueClient): (WebKit::GeoclueGeolocationProvider::setupGeoclueClient): (WebKit::GeoclueGeolocationProvider::startGeoclueClient): (WebKit::GeoclueGeolocationProvider::stopGeoclueClient): (WebKit::GeoclueGeolocationProvider::requestAccuracyLevel): (WebKit::GeoclueGeolocationProvider::destroyManagerLater): Deleted. (WebKit::GeoclueGeolocationProvider::destroyManager): Deleted. (WebKit::GeoclueGeolocationProvider::setupManager): Deleted. (WebKit::GeoclueGeolocationProvider::createClient): Deleted. (WebKit::GeoclueGeolocationProvider::setupClient): Deleted. (WebKit::GeoclueGeolocationProvider::startClient): Deleted. (WebKit::GeoclueGeolocationProvider::stopClient): Deleted. * Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.h: Canonical link: https://commits.webkit.org/275746@main Canonical link: https://commits.webkit.org/274313.138@webkitglib/2.44 Commit: 7a1e9cda9bf866696e0525cbd34a7edb5594d40a https://github.com/WebKit/WebKit/commit/7a1e9cda9bf866696e0525cbd34a7edb5594d40a Author: Philippe Normand <ph...@igalia.com> Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp M Source/WebCore/Modules/webaudio/MediaStreamAudioSourceGStreamer.cpp M Source/WebCore/platform/GStreamer.cmake M Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h Log Message: ----------- Cherry-pick 275681@main (1ff489b643f7). https://bugs.webkit.org/show_bug.cgi?id=270449 [GStreamer] Build without WebAudio support is broken https://bugs.webkit.org/show_bug.cgi?id=270449 Reviewed by Xabier Rodriguez-Calvar. This most likely started failing after the GStreamer source units were unified. * Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp: (WebCore::MediaStreamTrack::createAudioSourceProvider): * Source/WebCore/Modules/webaudio/MediaStreamAudioSourceGStreamer.cpp: * Source/WebCore/platform/GStreamer.cmake: * Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp: * Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp: * Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h: Canonical link: https://commits.webkit.org/275681@main Canonical link: https://commits.webkit.org/274313.139@webkitglib/2.44 Compare: https://github.com/WebKit/WebKit/compare/aff53249f2d4...7a1e9cda9bf8 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes