Re: [U-Boot] [PATCH] serial: ns16550: add setconfig support
On 03.11.2018 07:08, Simon Glass wrote: On 2 November 2018 at 14:28, Simon Goldschmidt wrote: Add possibility to update the serial parity used. Signed-off-by: Simon Goldschmidt --- drivers/serial/ns16550.c | 43 ++-- 1 file changed, 41 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass Ideally we should call this from sandbox (or a test) somewhere. Hmm, I'm a bit lost there. I haven't really used the tests so far and grep'ing through test/ does not show any reference to ns16550 either (where I could easily add a test). Did you mean adding a test for this specific driver (ns16550) or for the call to 'setconfig' in general? (Because I thought Patrice had already done that.) Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 00/13] dm: DM_FLAG_PRE_RELOC flag clean up
Hi Simon, On Sat, Nov 3, 2018 at 2:08 PM Simon Glass wrote: > > Hi Bin, > > On 1 November 2018 at 20:25, Bin Meng wrote: > > On Sun, Oct 28, 2018 at 9:31 PM Adam Ford wrote: > >> > >> On Wed, Oct 24, 2018 at 8:32 AM Bin Meng wrote: > >> > > >> > When a driver declares DM_FLAG_PRE_RELOC flag, it wishes to be > >> > bound before relocation. However due to a bug in the DM core, > >> > the flag only takes effect when devices are statically declared > >> > via U_BOOT_DEVICE(). This bug has been fixed recently by commit > >> > "dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in > >> > lists_bind_fdt()", but with the fix, it has a side effect that > >> > all existing drivers that declared DM_FLAG_PRE_RELOC flag will > >> > be bound before relocation now. This may expose potential boot > >> > failure on some boards due to insufficient memory during the > >> > pre-relocation stage. > >> > > >> > To mitigate this potential impact, the following changes are > >> > implemented: > >> > > >> > - Remove DM_FLAG_PRE_RELOC flag in the driver, if the driver > >> > only supports configuration from device tree (OF_CONTROL) > >> > - Keep DM_FLAG_PRE_RELOC flag in the driver only if the device > >> > is statically declared via U_BOOT_DEVICE() > >> > - Surround DM_FLAG_PRE_RELOC flag with OF_CONTROL check, for > >> > drivers that support both statically declared devices and > >> > configuration from device tree > >> > > >> > This series should be applied on top of u-boot-dm/master, for > >> > v2018.11 release. > >> > > >> > > >> > Bin Meng (13): > >> > arm: stm32mp: Remove DM_FLAG_PRE_RELOC flag > >> > clk: Remove DM_FLAG_PRE_RELOC flag in various drivers > >> > gpio: Remove DM_FLAG_PRE_RELOC flag in various drivers > >> > i2c: omap24xx: Surround DM_FLAG_PRE_RELOC flag with OF_CONTROL check > >> > mmc: omap: Surround DM_FLAG_PRE_RELOC flag with OF_CONTROL check > >> > pinctrl: Remove DM_FLAG_PRE_RELOC flag in various drivers > >> > ram: bmips: Remove DM_FLAG_PRE_RELOC flag > >> > timer: Remove DM_FLAG_PRE_RELOC flag in various drivers > >> > serial: Remove DM_FLAG_PRE_RELOC flag in various drivers > >> > sysreset: Remove DM_FLAG_PRE_RELOC flag in various drivers > >> > video: simplefb: Remove DM_FLAG_PRE_RELOC flag > >> > watchdog: Remove DM_FLAG_PRE_RELOC flag in various drivers > >> > dm: doc: Update description of pre-relocation support > >> > > >> > >> This works just fine for me on the am3517_evm and the omap3_logic boards. > >> > >> Tested-by Adam Ford > >> > > > > Thanks Adam and Stephen's testing. > > > > Simon, > > > > Looks we don't have too much time before release, would you please > > test and send the PR? > > > > Another series > > (http://patchwork.ozlabs.org/project/uboot/list/?series=70686) > > needs to be pulled in to unblock x86 too. > > I had assumed we could wait to the next release. > > Could you please explain what you are wanting me to do here? Short version: As I mentioned in this series' cover letter, "This series should be applied on top of u-boot-dm/master, for v2018.11 release.". The other x86 series should be applied for this release too. The long story: In [1] I said: "It looks that I have to send out a fix to correct Tegra in this release now, and leave other clean ups in next release.", was because I think the clean up changes are massive and only Stephen reported the Tegra was broken by previous series [2] which was applied in *u-boot-dm/master* so initially I only wanted to send out the Tegra fixes. However later Stefan reported in [3] that some x86 boards just don't boot with *u-boot/mater*. Then I had a look and suggested adding DM_FLAG_PRE_RELOC flag to x86 CPU drivers, which was the x86 fixes series [4] I mentioned above. However the issue is that without my fix in series [2], the x86 fix just doesn't work. Then I mentioned that in [5] I said "I spent some time to clean up all driver usage about DM_FLAG_PRE_RELOC flag" and it should fix Tegra (reported) as well as other potential (un-reported) broken. [1] https://lists.denx.de/pipermail/u-boot/2018-October/345085.html [2] http://patchwork.ozlabs.org/project/uboot/list/?series=70150&state=*&q=&archive=both [3] https://lists.denx.de/pipermail/u-boot/2018-October/344266.html [4] http://patchwork.ozlabs.org/project/uboot/list/?series=70686 [5] https://lists.denx.de/pipermail/u-boot/2018-October/345479.html Note both my previous series [2] and x86 fix series [4] are attempting to fix the side effect brought up by c0434407b595 ("board_f: Use static print_cpuinfo if CONFIG_CPU is active") which was part of the MPC83xx CPU uclass driver support. So the root cause is the MPC83xx changes. But I am not sure if we can revert that patch easily now, as I suspect many later commits are dependent on that one, and we may break some more stuff if we revert that. Up to now, I see some 'Tested-by' tags were provided for this series, I think we are good to go. Does this make sense? Regards, Bin
[U-Boot] [GIT PULL] mips-fixes-for-v2018.11
Hi Tom, please pull an important bugfix for MIPS, thanks. Travis CI: https://travis-ci.org/danielschwierzeck/u-boot/builds/450057399 The following changes since commit 99431c1c21685fe63d46b6eac995b78ce9adce0a: Merge tag 'arc-for-2018.11' of git://git.denx.de/u-boot-arc (2018-11-02 09:39:18 -0400) are available in the Git repository at: git://git.denx.de/u-boot-mips.git tags/mips-fixes-for-v2018.11 for you to fetch changes up to 963014641117291c15df2425caf46c7b4b979f18: MIPS: make size of relocation table fixed but configurable (2018-11-02 22:39:07 +0100) - replace the dynamic size of the relocation table with a fixed but configurable size - fixes non-working CONFIG_OF_SEPARATE=y due to invalid _end symbol Daniel Schwierzeck (1): MIPS: make size of relocation table fixed but configurable arch/mips/Kconfig| 18 ++ arch/mips/config.mk | 2 +- arch/mips/cpu/u-boot.lds | 20 +--- tools/mips-relocs.c | 30 -- 4 files changed, 40 insertions(+), 30 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] mt7623 bootup example
Hi Simon, hi Ryder, i tried Patches so far, they are working well https://patchwork.ozlabs.org/patch/992398/ here my github-repo with steps to build: https://github.com/frank-w/u-boot there is a build.sh, which compiles uboot the common way with some additions like bootmenu and full environment to load a kernel on BPI-R2 here are instructions how to prepare SD-Card for boot-up: https://www.fw-web.de/dokuwiki/doku.php?id=en:bpi-r2:storage#extended_boot-headers as you see you need 3 Headers on SD-Card (SDMMC_BOOT, BRLYT, Preloader) and the uboot.bin for SD-Card. on emmc imho preloader in boot0-block and uboot on main-Partition is enough for uboot to boot Source: https://www.fw-web.de/dokuwiki/doku.php?id=en:bpi-r2:uboot#update_uboot btw. @ryder.lee you have a small typo in the readme: Boorom => Bootrom (2 times) maybe you can add Infos above from my wiki. Btw. how far is the ethernet-driver? then i can replace my 2014-uboot ;) regards Frank ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] board: rockchip: rk3399: add Rockpro64 board support
Rockpro64 is rk3399 based board from pine64.org. add initial board support for Rockpro64. complete board support will be added later in upcoming patchsets. Signed-off-by: Akash Gajjar --- arch/arm/dts/Makefile |1 + arch/arm/dts/rk3399-rockpro64.dts | 519 +++ arch/arm/dts/rk3399-sdram-lpddr4-1600.dtsi | 1535 arch/arm/mach-rockchip/rk3399/Kconfig | 10 + board/rockchip/rockpro64/Kconfig | 15 + board/rockchip/rockpro64/MAINTAINERS |6 + board/rockchip/rockpro64/Makefile |7 + board/rockchip/rockpro64/rockpro64.c | 94 ++ configs/rockpro64-rk3399_defconfig | 78 + include/configs/rockpro64.h| 15 + 10 files changed, 2280 insertions(+) create mode 100644 arch/arm/dts/rk3399-rockpro64.dts create mode 100644 arch/arm/dts/rk3399-sdram-lpddr4-1600.dtsi create mode 100644 board/rockchip/rockpro64/Kconfig create mode 100644 board/rockchip/rockpro64/MAINTAINERS create mode 100644 board/rockchip/rockpro64/Makefile create mode 100644 board/rockchip/rockpro64/rockpro64.c create mode 100644 configs/rockpro64-rk3399_defconfig create mode 100644 include/configs/rockpro64.h diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index d36447d18d..8a84cf55a3 100644 --- a/arch/arm/dts/Makefile +++ b/arch/arm/dts/Makefile @@ -51,6 +51,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \ rk3399-puma-ddr1333.dtb \ rk3399-puma-ddr1600.dtb \ rk3399-puma-ddr1866.dtb \ + rk3399-rockpro64.dtb \ rv1108-evb.dtb dtb-$(CONFIG_ARCH_MESON) += \ meson-gxbb-nanopi-k2.dtb \ diff --git a/arch/arm/dts/rk3399-rockpro64.dts b/arch/arm/dts/rk3399-rockpro64.dts new file mode 100644 index 00..8497a1124b --- /dev/null +++ b/arch/arm/dts/rk3399-rockpro64.dts @@ -0,0 +1,519 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (c) 2018 Akash Gajjar + */ + +/dts-v1/; +#include +#include +#include "rk3399.dtsi" +#include "rk3399-sdram-lpddr4-1600.dtsi" + +/ { + model = "Pine64 Rockpro64-RK3399 Board"; + compatible = "pine64,rockpro64", "rockchip,rk3399"; + + chosen { + stdout-path = &uart2; + u-boot,spl-boot-order = &sdhci, &sdmmc; + }; + + clkin_gmac: external-gmac-clock { + compatible = "fixed-clock"; + clock-frequency = <12500>; + clock-output-names = "clkin_gmac"; + #clock-cells = <0>; + }; + + vcc3v3_sys: vcc3v3-sys { + compatible = "regulator-fixed"; + regulator-name = "vcc3v3_sys"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <330>; + regulator-max-microvolt = <330>; + }; + + vcc5v0_host: vcc5v0-host-regulator { + compatible = "regulator-fixed"; + enable-active-high; + gpio = <&gpio4 RK_PD2 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&host_vbus_drv>; + regulator-name = "vcc5v0_host"; + regulator-always-on; + }; + + vcc5v0_sys: vcc5v0-sys { + compatible = "regulator-fixed"; + regulator-name = "vcc5v0_sys"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <500>; + regulator-max-microvolt = <500>; + }; + + vcc_phy: vcc-phy-regulator { + compatible = "regulator-fixed"; + regulator-name = "vcc_phy"; + regulator-always-on; + regulator-boot-on; + }; + + vdd_log: vdd-log { + compatible = "pwm-regulator"; + pwms = <&pwm2 0 25000 1>; + regulator-name = "vdd_log"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <43>; + regulator-max-microvolt = <140>; + regulator-init-microvolt = <95>; + }; + + vccadc_ref: vccadc-ref { + compatible = "regulator-fixed"; + regulator-name = "vcc1v8_sys"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <180>; + regulator-max-microvolt = <180>; + }; +}; + +&cpu_l0 { + cpu-supply = <&vdd_cpu_l>; +}; + +&cpu_l1 { + cpu-supply = <&vdd_cpu_l>; +}; + +&cpu_l2 { + cpu-supply = <&vdd_cpu_l>; +}; + +&cpu_l3 { + cpu-supply = <&vdd_cpu_l>; +}; + +&cpu_b0 { + cpu-supply = <&vdd_cpu_b>; +}; + +&cpu_b1 { + cpu-supply = <&vdd_cpu_b>; +}; + +&emmc_phy { + status = "okay"; +}; + +&gmac { + assigned-clocks = <&cru SCLK_RMII_SRC>; + assigned-clock-parents = <&clkin_gmac>; + clock_in_out = "input"; + phy-supply = <&vcc_phy>; +
[U-Boot] FOSDEM 2019 Hardware Enablement Devroom Call for Participation
Hi, The Hardware Enablement devroom is back for a second year at FOSDEM! It will take place on Sunday 3 February 2019. # Call for Participation We are opening the call for participation to our devroom, with the deadline for talk proposals set to Saturday 1 December 2018. # Devroom Scope This devroom covers topics related to hardware support and enablement with free software. It includes the following topics: * peripheral/controller firmwares * boot software * kernel drivers and hardware interfaces * hardware-related adaptation in operating systems * tools for firmware flashing * tools for low-level development Despite this large scope, the focus of the devroom is set on highlighting the technical aspects of the hardware and its enablement in free projects, rather than the specific applications and use cases that benefit from it. We also want to avoid purely commercial vague talks with marketing content, which leave little place to technical aspects. This year, we are looking to particularly highlighting free software outside of the operating system boundaries, especially with boot software as well as controller and peripheral firmwares. # Talk Format Since no Embedded devroom is taking place this year (and our devroom also covers embedded devices), we are expecting a significant number of submissions. In order to cover as much ground as we can, a new talk will be scheduled every half-hour, so accepted talks will follow this format: 20 minutes for the talk + 5 minutes for questions + 5 minutes for speaker setup We ask speakers to be present in the room before their talk so that speaker setup can go smoothly. # Submission Talks that fit in our devroom's scope can be submitted to the FOSDEM Pentabarf interface at https://penta.fosdem.org/submission/FOSDEM19 We encourage reusing accounts from previous years instead of creating new ones: * lost password: https://penta.fosdem.org/user/forgot_password * new Account: https://penta.fosdem.org/user/new_account/FOSDEM19 Here are a few guidelines when submitting a talk: * select the Hardware Enablement devroom as track * include an abstract for every submission and optionally a full description * make sure your contact details are up to date # Video Talks will be streamed live during the event and recorded. They will be available under a Creative Commons Attribution (BY) license later. # Contact For more information or questions about the devroom and this CFP, feel free to email hardware-devroom-manager at fosdem.org We're looking forward to lots of interesting proposals and hoping to see you all in Brussels at the event! Cheers, Paul for the Hardware Enablement devroom signature.asc Description: This is a digitally signed message part ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 28/29] riscv: qemu: detect and boot the kernel passed by QEMU
On Tue, 2018-10-30 at 16:27 +0100, Alexander Graf wrote: > > On 30.10.18 16:02, Auer, Lukas wrote: > > On Tue, 2018-10-30 at 13:55 +0100, Lukas Auer wrote: > > > QEMU embeds the location of the kernel image in the device tree. > > > Store > > > this address in the environment as variable kernel_start and use > > > it > > > in > > > CONFIG_BOOTCOMMAND to boot the kernel. Use the device tree passed > > > by > > > the > > > prior boot stage to boot Linux. > > > > > > Signed-off-by: Lukas Auer > > > --- > > > > > > Changes in v2: > > > - Rebase onto u-boot-dm/next > > > - Boot Linux with the device tree provided by the prior boot > > > stage > > > > > > board/emulation/qemu-riscv/Kconfig | 1 + > > > board/emulation/qemu-riscv/qemu-riscv.c | 29 > > > + > > > configs/qemu-riscv32_defconfig | 1 + > > > configs/qemu-riscv64_defconfig | 1 + > > > include/configs/qemu-riscv.h| 10 - > > > 5 files changed, 41 insertions(+), 1 deletion(-) > > > > > > diff --git a/board/emulation/qemu-riscv/Kconfig > > > b/board/emulation/qemu-riscv/Kconfig > > > index 37a80db6a9..be5839b7db 100644 > > > --- a/board/emulation/qemu-riscv/Kconfig > > > +++ b/board/emulation/qemu-riscv/Kconfig > > > @@ -29,5 +29,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy > > > imply CMD_EXT2 > > > imply CMD_EXT4 > > > imply CMD_FAT > > > + imply BOARD_LATE_INIT > > > > > > endif > > > diff --git a/board/emulation/qemu-riscv/qemu-riscv.c > > > b/board/emulation/qemu-riscv/qemu-riscv.c > > > index 2ce093e19a..ee20983095 100644 > > > --- a/board/emulation/qemu-riscv/qemu-riscv.c > > > +++ b/board/emulation/qemu-riscv/qemu-riscv.c > > > @@ -19,3 +19,32 @@ int board_init(void) > > > > > > return 0; > > > } > > > + > > > +int board_late_init(void) > > > +{ > > > + ulong kernel_start; > > > + ofnode chosen_node; > > > + int ret; > > > + > > > + chosen_node = ofnode_path("/chosen"); > > > + if (!ofnode_valid(chosen_node)) { > > > + printf("No chosen node found\n"); > > > + return 0; > > > + } > > > + > > > +#ifdef CONFIG_ARCH_RV64I > > > + ret = ofnode_read_u64(chosen_node, "riscv,kernel-start", > > > + (u64 *)&kernel_start); > > > +#else > > > + ret = ofnode_read_u32(chosen_node, "riscv,kernel-start", > > > + (u32 *)&kernel_start); > > > +#endif > > > + if (ret) { > > > + printf("Can't find kernel start address in device > > > tree\n"); > > > + return 0; > > > + } > > > + > > > + env_set_hex("kernel_start", kernel_start); > > > + > > > + return 0; > > > +} > > > diff --git a/configs/qemu-riscv32_defconfig b/configs/qemu- > > > riscv32_defconfig > > > index b55644378a..13dd53a550 100644 > > > --- a/configs/qemu-riscv32_defconfig > > > +++ b/configs/qemu-riscv32_defconfig > > > @@ -4,4 +4,5 @@ CONFIG_NR_DRAM_BANKS=1 > > > CONFIG_FIT=y > > > CONFIG_DISPLAY_CPUINFO=y > > > CONFIG_DISPLAY_BOARDINFO=y > > > +CONFIG_HUSH_PARSER=y > > > CONFIG_OF_PRIOR_STAGE=y > > > diff --git a/configs/qemu-riscv64_defconfig b/configs/qemu- > > > riscv64_defconfig > > > index a542ac4893..06eb3042fa 100644 > > > --- a/configs/qemu-riscv64_defconfig > > > +++ b/configs/qemu-riscv64_defconfig > > > @@ -5,4 +5,5 @@ CONFIG_NR_DRAM_BANKS=1 > > > CONFIG_FIT=y > > > CONFIG_DISPLAY_CPUINFO=y > > > CONFIG_DISPLAY_BOARDINFO=y > > > +CONFIG_HUSH_PARSER=y > > > CONFIG_OF_PRIOR_STAGE=y > > > diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu- > > > riscv.h > > > index ba6a18f2e6..7c88ba300a 100644 > > > --- a/include/configs/qemu-riscv.h > > > +++ b/include/configs/qemu-riscv.h > > > @@ -21,7 +21,15 @@ > > > #define CONFIG_ENV_SIZE SZ_4K > > > > > > #define CONFIG_EXTRA_ENV_SETTINGS \ > > > - "fdt_high=0x\0" \ > > > + "fdt_high=0x8200\0" \ > > > + "bootm_size=0x1000\0" \ > > > "initrd_high=0x\0" > > > > > > +#define CONFIG_BOOTCOMMAND \ > > > + "if env exists kernel_start; then " \ > > > + "bootm ${kernel_start} - ${prior_stage_dtb};" \ > > > > As Alexander Graf pointed out in reply to patch 24, we don't need > > the > > separate environment variable "prior_stage_dtb". I will replace it > > with > > "fdtcontroladdr" here and drop patch 24 in the next version. > > Also, can you please enable distro boot? :) > > > Thanks, > > Alex I just had a closer look at distro boot and it's actually quite easy to use. I will update this patch to enable it and will add a bootcmd for virtio block devices (virtio support is currently in u-boot-dm/next). I was looking into testing bootefi on U-Boot and tried to run the hello world and selftest EFI binaries, however I could not get them running. After starting them I immediately get a load access fault. The faulting instruction is at 0xfe77c1fa, which is strange since the binary is loaded to 0x8020. Do you know what this could be caused by? Also note that I completed the list of exception codes i
Re: [U-Boot] [PATCH V2 6/6] test: vboot: add padding pss for rsa signature
Hi, I'm not an expert but regarding commit b8790ebeec13c882979dc986947397738d9f38aa I think you should drop the unit-address in its files. "The DT spec demands a unit-address of a node name to match the "reg" property in that node. Newer dtc versions will throw warnings if this is not the case. Fix all occurences in the FIT image example files where this was not observed, to not give bad examples to the reader. " Regards, Clement On Sat, 3 Nov 2018 at 07:08, Simon Glass wrote: > > On 25 October 2018 at 03:29, Philippe Reynes > wrote: > > The padding pss is now supported for rsa signature. > > This add test with padding pss on vboot test. > > > > Signed-off-by: Philippe Reynes > > --- > > test/py/tests/test_vboot.py | 10 +++--- > > test/py/tests/vboot/sign-configs-sha1-pss.its | 46 > > + > > test/py/tests/vboot/sign-configs-sha256-pss.its | 46 > > + > > test/py/tests/vboot/sign-images-sha1-pss.its| 44 > > +++ > > test/py/tests/vboot/sign-images-sha256-pss.its | 44 > > +++ > > 5 files changed, 186 insertions(+), 4 deletions(-) > > create mode 100644 test/py/tests/vboot/sign-configs-sha1-pss.its > > create mode 100644 test/py/tests/vboot/sign-configs-sha256-pss.its > > create mode 100644 test/py/tests/vboot/sign-images-sha1-pss.its > > create mode 100644 test/py/tests/vboot/sign-images-sha256-pss.its > > > > Changelog: > > v2: > > - new patch in the serie > > - add vboot for pss padding (thanks Simon Glass) > > Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] FW: [PATCH 18/30] riscv: invalidate the instruction cache before jumping to Linux
Hi Rick, On Wed, 2018-10-31 at 12:22 +0800, Rick Chen wrote: > Greentime Hu 於 2018年10月31日 週三 上午11:48寫道: > > > > Rick Chen 於 2018年10月29日 週一 上午10:25寫道: > > > > > > Auer, Lukas 於 2018年10月27日 週六 > > > 上午12:27寫道: > > > > > > > > Hi Rick, > > > > > > > > On Mon, 2018-10-22 at 09:39 +0800, Rick Chen wrote: > > > > > > From: Lukas Auer [mailto:lukas.a...@aisec.fraunhofer.de] > > > > > > Sent: Saturday, October 20, 2018 6:08 AM > > > > > > To: u-boot@lists.denx.de > > > > > > Cc: Bin Meng; Lukas Auer; Greentime Hu; Alexander Graf; > > > > > > Rick Jian- > > > > > > Zhi Chen(陳建志) > > > > > > Subject: [PATCH 18/30] riscv: invalidate the instruction > > > > > > cache > > > > > > before jumping to Linux > > > > > > > > > > > > Signed-off-by: Lukas Auer > > > > > > --- > > > > > > > > > > > > arch/riscv/lib/bootm.c | 1 + > > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > diff --git a/arch/riscv/lib/bootm.c > > > > > > b/arch/riscv/lib/bootm.c index > > > > > > a7a9fb921b..bc1d4b2864 100644 > > > > > > --- a/arch/riscv/lib/bootm.c > > > > > > +++ b/arch/riscv/lib/bootm.c > > > > > > @@ -38,6 +38,7 @@ int do_bootm_linux(int flag, int argc, > > > > > > char > > > > > > *argv[], bootm_headers_t *images) > > > > > > return 1; > > > > > > > > > > > > kernel = (void (*)(ulong, void *))images->ep; > > > > > > + invalidate_icache_all(); > > > > > > > > > > Hi Likas > > > > > > > > > > I wull use cleanup_before_linux() which is in cpu.c as below > > > > > > > > > > > > > I would prefer to keep the invalidate_icache_all() in bootm.c > > > > since it > > > > is important in the context of the function. I do agree that > > > > the data > > > > and instruction caches should be disabled in > > > > cleanup_before_linux(). > > > > > > > > > > Hi Lukas > > > > > > It is ok to keep the invalidate_icache_all() in bootm.c > > > > > > Rick > > > > > > > Hi Rick, > > > > Since cleanup_before_linux() will invalidate icache, I think it > > will > > be better to do the whole cache operations there. > > As we can see the document from ARM(doc/README.arm-caches) it also > > said that > > " > > Cleanup Before Linux: > > - cleanup_before_linux() should flush the D-cache, invalidate I- > > cache, and > > disable MMU and caches. > > " > > This may reduce the redundant codes/cost. > > What do you think? > > Hi Greentime > > I agree with you. We shall consider to reduce the redundant > codes/cost. > > Hi Lukas > > Can you drop this patch ? > And move it to cache_flush() ? > > Thought this patch have implement it. > [PATCH] riscv: cache: Implement i/dcache [status, enable, disable] > > But I will send v2 patch to separate /riscv/lib/cache.c > to /riscv/cpu/ax25/cache.c and /riscv/cpu/qemu/cache.c > > After that you can implement it in /riscv/cpu/qemu/cache.c > > Rick Ok, I will drop this patch in the next version. Thanks, Lukas ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] 2018-11 rc1 vs rc3
Hi, i've noticed that with rc3 i need swig-package, which i did not need with rc1...has anything changed regarding to this? i only applied mediatek-Patches for mt7623 but here i found nothing related to it... on google i've found only a thread from 2017 ( https://lists.denx.de/pipermail/u-boot/2017-December/314100.html ), but this seems to change between rc1 and rc3 of 2018-11 any hints? regards Frank ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/5] Add support for Pinebook
I have tested the series on my pinebook on top of git commit 99431c1c21685fe63d46b6eac995b78ce9adce0a I am not sure if video is expected to work or not, in my case it does not work. U-Boot SPL 2018.11-rc3-00027-g77a46c3a3c (Nov 03 2018 - 13:42:47 -0500) DRAM: 2048 MiB Trying to boot from MMC1 NOTICE: BL31: v1.6(release): NOTICE: BL31: Built : 09:10:17, Sep 23 2018 NOTICE: BL31: Detected Allwinner A64/H64/R18 SoC (1689) NOTICE: BL31: STUB PMIC setup code called U-Boot 2018.11-rc3-00027-g77a46c3a3c (Nov 03 2018 - 13:42:47 -0500) Allwinner Technology CPU: Allwinner A64 (SUN50I) Model: Pinebook DRAM: 2 GiB MMC: SUNXI SD/MMC: 0, SUNXI SD/MMC: 1 Loading Environment from FAT... *** Warning - bad CRC, using default environment Warning: HDMI PHY init timeout! Warning: HDMI PHY init timeout! In:serial Out: serial Err: serial u-boot however works fine and the system is able to boot and the correct dtb is loaded. Tested-by: Dennis Gilmore El mar, 30-10-2018 a las 14:36 -0700, Vagrant Cascadian escribió: > Tested series applied to u-boot 2018.11-rc3 on pinebook, both with > reboot and cold boot. > > Thanks for all the work on it! > > Tested-by: Vagrant Cascadian > > On 2018-10-28, Vasily Khoruzhick wrote: > > This series adds support for the Pinebook, an allwinner A64 laptop > > produced by Pine64. It also syncs sun50i-a64.dtsi with linux, > > adds support for mmc delay calibration, R_I2C controller, > > and addresses the issue with activating video bridge when any of > > GPIOs is missing. > > > > v2: - sync sun50i-a64.dtsi with linux instead of adding missing > > nodes > > - take sun50i-a64-pinebook.dts from linux > > - don't introduce new Kconfig for A64 MMC calibration > > - improve code in video bridge uclass to check for presensce of > > GPIO instead of ingoring EINVAL errors > > v3: - enable calibration for H6 as well > > - init ret variable in video_bridge_set_active() > > - fix order of dts files Makefile > > - split anx6345 binding into sun50i-a64-pinebook-u-boot.dts > > - drop speaker_amp node from pinebook dts > > - drop unnecessary options from defconfig > > v4: - sync device tree files with linux-next > > > > Vasily Khoruzhick (5): > > mmc: sunxi: add support for automatic delay calibration > > dm: video: bridge: don't fail to activate bridge if reset or > > sleep > > GPIO is missing > > sunxi: DT: A64: update device tree files for Allwinner A64 SoC > > sun50i: A64: add support for R_I2C controller > > sunxi: DT: add support for Pinebook > > > > arch/arm/dts/Makefile| 1 + > > arch/arm/dts/sun50i-a64-amarula-relic.dts| 168 +- > > arch/arm/dts/sun50i-a64-bananapi-m64.dts | 34 +- > > arch/arm/dts/sun50i-a64-nanopi-a64.dts | 89 +- > > arch/arm/dts/sun50i-a64-olinuxino.dts| 103 +- > > arch/arm/dts/sun50i-a64-orangepi-win.dts | 179 ++- > > arch/arm/dts/sun50i-a64-pine64.dts | 32 +- > > arch/arm/dts/sun50i-a64-pinebook-u-boot.dtsi | 15 + > > arch/arm/dts/sun50i-a64-pinebook.dts | 294 > > + > > arch/arm/dts/sun50i-a64-sopine-baseboard.dts | 32 +- > > arch/arm/dts/sun50i-a64-sopine.dtsi | 15 + > > arch/arm/dts/sun50i-a64.dtsi | 313 > > +-- > > arch/arm/include/asm/arch-sunxi/gpio.h | 1 + > > arch/arm/include/asm/arch-sunxi/mmc.h| 6 +- > > arch/arm/mach-sunxi/Kconfig | 1 + > > board/sunxi/board.c | 6 + > > configs/pinebook_defconfig | 22 ++ > > drivers/mmc/sunxi_mmc.c | 21 +- > > drivers/video/bridge/video-bridge-uclass.c | 16 +- > > 19 files changed, 1296 insertions(+), 52 deletions(-) > > create mode 100644 arch/arm/dts/sun50i-a64-pinebook-u-boot.dtsi > > create mode 100644 arch/arm/dts/sun50i-a64-pinebook.dts > > create mode 100644 configs/pinebook_defconfig > > > > -- > > 2.19.1 > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 28/29] riscv: qemu: detect and boot the kernel passed by QEMU
On 03.11.18 18:07, Auer, Lukas wrote: > On Tue, 2018-10-30 at 16:27 +0100, Alexander Graf wrote: >> >> On 30.10.18 16:02, Auer, Lukas wrote: >>> On Tue, 2018-10-30 at 13:55 +0100, Lukas Auer wrote: QEMU embeds the location of the kernel image in the device tree. Store this address in the environment as variable kernel_start and use it in CONFIG_BOOTCOMMAND to boot the kernel. Use the device tree passed by the prior boot stage to boot Linux. Signed-off-by: Lukas Auer --- Changes in v2: - Rebase onto u-boot-dm/next - Boot Linux with the device tree provided by the prior boot stage board/emulation/qemu-riscv/Kconfig | 1 + board/emulation/qemu-riscv/qemu-riscv.c | 29 + configs/qemu-riscv32_defconfig | 1 + configs/qemu-riscv64_defconfig | 1 + include/configs/qemu-riscv.h| 10 - 5 files changed, 41 insertions(+), 1 deletion(-) diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig index 37a80db6a9..be5839b7db 100644 --- a/board/emulation/qemu-riscv/Kconfig +++ b/board/emulation/qemu-riscv/Kconfig @@ -29,5 +29,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy imply CMD_EXT2 imply CMD_EXT4 imply CMD_FAT + imply BOARD_LATE_INIT endif diff --git a/board/emulation/qemu-riscv/qemu-riscv.c b/board/emulation/qemu-riscv/qemu-riscv.c index 2ce093e19a..ee20983095 100644 --- a/board/emulation/qemu-riscv/qemu-riscv.c +++ b/board/emulation/qemu-riscv/qemu-riscv.c @@ -19,3 +19,32 @@ int board_init(void) return 0; } + +int board_late_init(void) +{ + ulong kernel_start; + ofnode chosen_node; + int ret; + + chosen_node = ofnode_path("/chosen"); + if (!ofnode_valid(chosen_node)) { + printf("No chosen node found\n"); + return 0; + } + +#ifdef CONFIG_ARCH_RV64I + ret = ofnode_read_u64(chosen_node, "riscv,kernel-start", +(u64 *)&kernel_start); +#else + ret = ofnode_read_u32(chosen_node, "riscv,kernel-start", +(u32 *)&kernel_start); +#endif + if (ret) { + printf("Can't find kernel start address in device tree\n"); + return 0; + } + + env_set_hex("kernel_start", kernel_start); + + return 0; +} diff --git a/configs/qemu-riscv32_defconfig b/configs/qemu- riscv32_defconfig index b55644378a..13dd53a550 100644 --- a/configs/qemu-riscv32_defconfig +++ b/configs/qemu-riscv32_defconfig @@ -4,4 +4,5 @@ CONFIG_NR_DRAM_BANKS=1 CONFIG_FIT=y CONFIG_DISPLAY_CPUINFO=y CONFIG_DISPLAY_BOARDINFO=y +CONFIG_HUSH_PARSER=y CONFIG_OF_PRIOR_STAGE=y diff --git a/configs/qemu-riscv64_defconfig b/configs/qemu- riscv64_defconfig index a542ac4893..06eb3042fa 100644 --- a/configs/qemu-riscv64_defconfig +++ b/configs/qemu-riscv64_defconfig @@ -5,4 +5,5 @@ CONFIG_NR_DRAM_BANKS=1 CONFIG_FIT=y CONFIG_DISPLAY_CPUINFO=y CONFIG_DISPLAY_BOARDINFO=y +CONFIG_HUSH_PARSER=y CONFIG_OF_PRIOR_STAGE=y diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu- riscv.h index ba6a18f2e6..7c88ba300a 100644 --- a/include/configs/qemu-riscv.h +++ b/include/configs/qemu-riscv.h @@ -21,7 +21,15 @@ #define CONFIG_ENV_SIZE SZ_4K #define CONFIG_EXTRA_ENV_SETTINGS \ - "fdt_high=0x\0" \ + "fdt_high=0x8200\0" \ + "bootm_size=0x1000\0" \ "initrd_high=0x\0" +#define CONFIG_BOOTCOMMAND \ + "if env exists kernel_start; then " \ + "bootm ${kernel_start} - ${prior_stage_dtb};" \ >>> >>> As Alexander Graf pointed out in reply to patch 24, we don't need >>> the >>> separate environment variable "prior_stage_dtb". I will replace it >>> with >>> "fdtcontroladdr" here and drop patch 24 in the next version. >> >> Also, can you please enable distro boot? :) >> >> >> Thanks, >> >> Alex > > I just had a closer look at distro boot and it's actually quite easy to > use. I will update this patch to enable it and will add a bootcmd for > virtio block devices (virtio support is currently in u-boot-dm/next). > > I was looking into testing bootefi on U-Boot and tried to run the hello > world and selftest EFI binaries, however I could not get them running. > After starting them I immediately get a load access fault. The faulting > instruction is at 0xfe77c1fa, which is strange since the binary is > loaded to 0x8020. Do you know what this could be caused by? I'm not quite sure yet what goes wrong. I tested and verified the riscv uefi por
Re: [U-Boot] 2018-11 rc1 vs rc3
it seems that this is caused by v3-patches (https://patchwork.ozlabs.org/project/uboot/list/?series=73809), but i did not found it yet i added v3-patchset to my 2018-11-rc1 (where v2-patches did not have this depency) and also got this error but i did not found yet the cause... > Gesendet: Samstag, 03. November 2018 um 18:45 Uhr > Von: "Frank Wunderlich" > An: u-boot@lists.denx.de > Betreff: 2018-11 rc1 vs rc3 > > Hi, > > i've noticed that with rc3 i need swig-package, which i did not need with > rc1...has anything changed regarding to this? i only applied mediatek-Patches > for mt7623 but here i found nothing related to it... > > on google i've found only a thread from 2017 ( > https://lists.denx.de/pipermail/u-boot/2017-December/314100.html ), but this > seems to change between rc1 and rc3 of 2018-11 > > any hints? > > regards Frank > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/5] Add support for Pinebook
Video is supposed to work, but you need ATF from Andre to enable LCD power: https://github.com/apritzel/arm-trusted-firmware/ On Sat, Nov 3, 2018 at 11:53 AM Dennis Gilmore wrote: > > I have tested the series on my pinebook on top of git commit > 99431c1c21685fe63d46b6eac995b78ce9adce0a > > I am not sure if video is expected to work or not, in my case it does > not work. > > U-Boot SPL 2018.11-rc3-00027-g77a46c3a3c (Nov 03 2018 - 13:42:47 -0500) > DRAM: 2048 MiB > Trying to boot from MMC1 > NOTICE: BL31: v1.6(release): > NOTICE: BL31: Built : 09:10:17, Sep 23 2018 > NOTICE: BL31: Detected Allwinner A64/H64/R18 SoC (1689) > NOTICE: BL31: STUB PMIC setup code called > > > U-Boot 2018.11-rc3-00027-g77a46c3a3c (Nov 03 2018 - 13:42:47 -0500) > Allwinner Technology > > CPU: Allwinner A64 (SUN50I) > Model: Pinebook > DRAM: 2 GiB > MMC: SUNXI SD/MMC: 0, SUNXI SD/MMC: 1 > Loading Environment from FAT... *** Warning - bad CRC, using default > environment > > Warning: HDMI PHY init timeout! > Warning: HDMI PHY init timeout! > In:serial > Out: serial > Err: serial > > u-boot however works fine and the system is able to boot and the > correct dtb is loaded. > > Tested-by: Dennis Gilmore > > El mar, 30-10-2018 a las 14:36 -0700, Vagrant Cascadian escribió: > > Tested series applied to u-boot 2018.11-rc3 on pinebook, both with > > reboot and cold boot. > > > > Thanks for all the work on it! > > > > Tested-by: Vagrant Cascadian > > > > On 2018-10-28, Vasily Khoruzhick wrote: > > > This series adds support for the Pinebook, an allwinner A64 laptop > > > produced by Pine64. It also syncs sun50i-a64.dtsi with linux, > > > adds support for mmc delay calibration, R_I2C controller, > > > and addresses the issue with activating video bridge when any of > > > GPIOs is missing. > > > > > > v2: - sync sun50i-a64.dtsi with linux instead of adding missing > > > nodes > > > - take sun50i-a64-pinebook.dts from linux > > > - don't introduce new Kconfig for A64 MMC calibration > > > - improve code in video bridge uclass to check for presensce of > > > GPIO instead of ingoring EINVAL errors > > > v3: - enable calibration for H6 as well > > > - init ret variable in video_bridge_set_active() > > > - fix order of dts files Makefile > > > - split anx6345 binding into sun50i-a64-pinebook-u-boot.dts > > > - drop speaker_amp node from pinebook dts > > > - drop unnecessary options from defconfig > > > v4: - sync device tree files with linux-next > > > > > > Vasily Khoruzhick (5): > > > mmc: sunxi: add support for automatic delay calibration > > > dm: video: bridge: don't fail to activate bridge if reset or > > > sleep > > > GPIO is missing > > > sunxi: DT: A64: update device tree files for Allwinner A64 SoC > > > sun50i: A64: add support for R_I2C controller > > > sunxi: DT: add support for Pinebook > > > > > > arch/arm/dts/Makefile| 1 + > > > arch/arm/dts/sun50i-a64-amarula-relic.dts| 168 +- > > > arch/arm/dts/sun50i-a64-bananapi-m64.dts | 34 +- > > > arch/arm/dts/sun50i-a64-nanopi-a64.dts | 89 +- > > > arch/arm/dts/sun50i-a64-olinuxino.dts| 103 +- > > > arch/arm/dts/sun50i-a64-orangepi-win.dts | 179 ++- > > > arch/arm/dts/sun50i-a64-pine64.dts | 32 +- > > > arch/arm/dts/sun50i-a64-pinebook-u-boot.dtsi | 15 + > > > arch/arm/dts/sun50i-a64-pinebook.dts | 294 > > > + > > > arch/arm/dts/sun50i-a64-sopine-baseboard.dts | 32 +- > > > arch/arm/dts/sun50i-a64-sopine.dtsi | 15 + > > > arch/arm/dts/sun50i-a64.dtsi | 313 > > > +-- > > > arch/arm/include/asm/arch-sunxi/gpio.h | 1 + > > > arch/arm/include/asm/arch-sunxi/mmc.h| 6 +- > > > arch/arm/mach-sunxi/Kconfig | 1 + > > > board/sunxi/board.c | 6 + > > > configs/pinebook_defconfig | 22 ++ > > > drivers/mmc/sunxi_mmc.c | 21 +- > > > drivers/video/bridge/video-bridge-uclass.c | 16 +- > > > 19 files changed, 1296 insertions(+), 52 deletions(-) > > > create mode 100644 arch/arm/dts/sun50i-a64-pinebook-u-boot.dtsi > > > create mode 100644 arch/arm/dts/sun50i-a64-pinebook.dts > > > create mode 100644 configs/pinebook_defconfig > > > > > > -- > > > 2.19.1 > > > > ___ > > U-Boot mailing list > > U-Boot@lists.denx.de > > https://lists.denx.de/listinfo/u-boot > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/5] Add support for Pinebook
On Sat, Nov 3, 2018 at 1:18 PM Vasily Khoruzhick wrote: > > Video is supposed to work, but you need ATF from Andre to enable LCD power: > > https://github.com/apritzel/arm-trusted-firmware/ You need "allwinner" branch from this repo. > On Sat, Nov 3, 2018 at 11:53 AM Dennis Gilmore wrote: > > > > I have tested the series on my pinebook on top of git commit > > 99431c1c21685fe63d46b6eac995b78ce9adce0a > > > > I am not sure if video is expected to work or not, in my case it does > > not work. > > > > U-Boot SPL 2018.11-rc3-00027-g77a46c3a3c (Nov 03 2018 - 13:42:47 -0500) > > DRAM: 2048 MiB > > Trying to boot from MMC1 > > NOTICE: BL31: v1.6(release): > > NOTICE: BL31: Built : 09:10:17, Sep 23 2018 > > NOTICE: BL31: Detected Allwinner A64/H64/R18 SoC (1689) > > NOTICE: BL31: STUB PMIC setup code called > > > > > > U-Boot 2018.11-rc3-00027-g77a46c3a3c (Nov 03 2018 - 13:42:47 -0500) > > Allwinner Technology > > > > CPU: Allwinner A64 (SUN50I) > > Model: Pinebook > > DRAM: 2 GiB > > MMC: SUNXI SD/MMC: 0, SUNXI SD/MMC: 1 > > Loading Environment from FAT... *** Warning - bad CRC, using default > > environment > > > > Warning: HDMI PHY init timeout! > > Warning: HDMI PHY init timeout! > > In:serial > > Out: serial > > Err: serial > > > > u-boot however works fine and the system is able to boot and the > > correct dtb is loaded. > > > > Tested-by: Dennis Gilmore > > > > El mar, 30-10-2018 a las 14:36 -0700, Vagrant Cascadian escribió: > > > Tested series applied to u-boot 2018.11-rc3 on pinebook, both with > > > reboot and cold boot. > > > > > > Thanks for all the work on it! > > > > > > Tested-by: Vagrant Cascadian > > > > > > On 2018-10-28, Vasily Khoruzhick wrote: > > > > This series adds support for the Pinebook, an allwinner A64 laptop > > > > produced by Pine64. It also syncs sun50i-a64.dtsi with linux, > > > > adds support for mmc delay calibration, R_I2C controller, > > > > and addresses the issue with activating video bridge when any of > > > > GPIOs is missing. > > > > > > > > v2: - sync sun50i-a64.dtsi with linux instead of adding missing > > > > nodes > > > > - take sun50i-a64-pinebook.dts from linux > > > > - don't introduce new Kconfig for A64 MMC calibration > > > > - improve code in video bridge uclass to check for presensce of > > > > GPIO instead of ingoring EINVAL errors > > > > v3: - enable calibration for H6 as well > > > > - init ret variable in video_bridge_set_active() > > > > - fix order of dts files Makefile > > > > - split anx6345 binding into sun50i-a64-pinebook-u-boot.dts > > > > - drop speaker_amp node from pinebook dts > > > > - drop unnecessary options from defconfig > > > > v4: - sync device tree files with linux-next > > > > > > > > Vasily Khoruzhick (5): > > > > mmc: sunxi: add support for automatic delay calibration > > > > dm: video: bridge: don't fail to activate bridge if reset or > > > > sleep > > > > GPIO is missing > > > > sunxi: DT: A64: update device tree files for Allwinner A64 SoC > > > > sun50i: A64: add support for R_I2C controller > > > > sunxi: DT: add support for Pinebook > > > > > > > > arch/arm/dts/Makefile| 1 + > > > > arch/arm/dts/sun50i-a64-amarula-relic.dts| 168 +- > > > > arch/arm/dts/sun50i-a64-bananapi-m64.dts | 34 +- > > > > arch/arm/dts/sun50i-a64-nanopi-a64.dts | 89 +- > > > > arch/arm/dts/sun50i-a64-olinuxino.dts| 103 +- > > > > arch/arm/dts/sun50i-a64-orangepi-win.dts | 179 ++- > > > > arch/arm/dts/sun50i-a64-pine64.dts | 32 +- > > > > arch/arm/dts/sun50i-a64-pinebook-u-boot.dtsi | 15 + > > > > arch/arm/dts/sun50i-a64-pinebook.dts | 294 > > > > + > > > > arch/arm/dts/sun50i-a64-sopine-baseboard.dts | 32 +- > > > > arch/arm/dts/sun50i-a64-sopine.dtsi | 15 + > > > > arch/arm/dts/sun50i-a64.dtsi | 313 > > > > +-- > > > > arch/arm/include/asm/arch-sunxi/gpio.h | 1 + > > > > arch/arm/include/asm/arch-sunxi/mmc.h| 6 +- > > > > arch/arm/mach-sunxi/Kconfig | 1 + > > > > board/sunxi/board.c | 6 + > > > > configs/pinebook_defconfig | 22 ++ > > > > drivers/mmc/sunxi_mmc.c | 21 +- > > > > drivers/video/bridge/video-bridge-uclass.c | 16 +- > > > > 19 files changed, 1296 insertions(+), 52 deletions(-) > > > > create mode 100644 arch/arm/dts/sun50i-a64-pinebook-u-boot.dtsi > > > > create mode 100644 arch/arm/dts/sun50i-a64-pinebook.dts > > > > create mode 100644 configs/pinebook_defconfig > > > > > > > > -- > > > > 2.19.1 > > > > > > ___ > > > U-Boot mailing list > > > U-Boot@lists.denx.de > > > https://lists.denx.de/listinfo/u-boot > > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 12/17] board_f: Use static print_cpuinfo if CONFIG_CPU is active
On Fri, Oct 12, 2018 at 6:34 PM Bin Meng wrote: > On Fri, Oct 12, 2018 at 10:00 PM Stefan Roese wrote: > diff --git a/arch/x86/cpu/baytrail/cpu.c b/arch/x86/cpu/baytrail/cpu.c > index 56e9813..2eb9172 100644 > --- a/arch/x86/cpu/baytrail/cpu.c > +++ b/arch/x86/cpu/baytrail/cpu.c > @@ -203,4 +203,5 @@ U_BOOT_DRIVER(cpu_x86_baytrail_drv) = { > .bind = cpu_x86_bind, > .probe = cpu_x86_baytrail_probe, > .ops= &cpu_x86_baytrail_ops, > + .flags = DM_FLAG_PRE_RELOC, This has to be done for all x86 boards I suppose? Actually I don't see this in the v2018.11-rc3. > } > > This patch needs to be applied on top of u-boot-x86/dm-fixes. Could > you please have a try? > > I was not aware Mario's changes broke the Baytrail boards too! I was > only testing on QEMU x86 before. Not only. Edison board is broken by this patch. This must be fixed before release, or better just to revert the patch ASAP. -- With Best Regards, Andy Shevchenko ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 12/17] board_f: Use static print_cpuinfo if CONFIG_CPU is active
On Sat, Nov 3, 2018 at 10:45 PM Andy Shevchenko wrote: > > On Fri, Oct 12, 2018 at 6:34 PM Bin Meng wrote: > > On Fri, Oct 12, 2018 at 10:00 PM Stefan Roese wrote: > > > diff --git a/arch/x86/cpu/baytrail/cpu.c b/arch/x86/cpu/baytrail/cpu.c > > index 56e9813..2eb9172 100644 > > --- a/arch/x86/cpu/baytrail/cpu.c > > +++ b/arch/x86/cpu/baytrail/cpu.c > > @@ -203,4 +203,5 @@ U_BOOT_DRIVER(cpu_x86_baytrail_drv) = { > > .bind = cpu_x86_bind, > > .probe = cpu_x86_baytrail_probe, > > .ops= &cpu_x86_baytrail_ops, > > > + .flags = DM_FLAG_PRE_RELOC, > > This has to be done for all x86 boards I suppose? > Actually I don't see this in the v2018.11-rc3. Adding this to arch/x86/cpu/cpu_x86.c does NOT fix the problem! > > } > > > > This patch needs to be applied on top of u-boot-x86/dm-fixes. Could > > you please have a try? > > > > I was not aware Mario's changes broke the Baytrail boards too! I was > > only testing on QEMU x86 before. > > Not only. > Edison board is broken by this patch. > > This must be fixed before release, or better just to revert the patch ASAP. Please, revert, if there is no quick cure. -- With Best Regards, Andy Shevchenko ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/5] Add support for Pinebook
On 11/3/18 8:19 PM, Vasily Khoruzhick wrote: > On Sat, Nov 3, 2018 at 1:18 PM Vasily Khoruzhick wrote: >> >> Video is supposed to work, but you need ATF from Andre to enable LCD power: >> >> https://github.com/apritzel/arm-trusted-firmware/ > > You need "allwinner" branch from this repo. I deliberately switched the standard branch away, since everything is merged in mainline ATF now (including PMIC support). I will post U-Boot patches to change the instructions soon, but just use the master branch from the official repo (and report back any issues!): https://github.com/ARM-Software/arm-trusted-firmware.git You might need the latest DT in U-Boot (patches are queued, AFAIK) to let ATF know about your PMIC requirements. Cheers, Andre >> On Sat, Nov 3, 2018 at 11:53 AM Dennis Gilmore wrote: >>> >>> I have tested the series on my pinebook on top of git commit >>> 99431c1c21685fe63d46b6eac995b78ce9adce0a >>> >>> I am not sure if video is expected to work or not, in my case it does >>> not work. >>> >>> U-Boot SPL 2018.11-rc3-00027-g77a46c3a3c (Nov 03 2018 - 13:42:47 -0500) >>> DRAM: 2048 MiB >>> Trying to boot from MMC1 >>> NOTICE: BL31: v1.6(release): >>> NOTICE: BL31: Built : 09:10:17, Sep 23 2018 >>> NOTICE: BL31: Detected Allwinner A64/H64/R18 SoC (1689) >>> NOTICE: BL31: STUB PMIC setup code called >>> >>> >>> U-Boot 2018.11-rc3-00027-g77a46c3a3c (Nov 03 2018 - 13:42:47 -0500) >>> Allwinner Technology >>> >>> CPU: Allwinner A64 (SUN50I) >>> Model: Pinebook >>> DRAM: 2 GiB >>> MMC: SUNXI SD/MMC: 0, SUNXI SD/MMC: 1 >>> Loading Environment from FAT... *** Warning - bad CRC, using default >>> environment >>> >>> Warning: HDMI PHY init timeout! >>> Warning: HDMI PHY init timeout! >>> In:serial >>> Out: serial >>> Err: serial >>> >>> u-boot however works fine and the system is able to boot and the >>> correct dtb is loaded. >>> >>> Tested-by: Dennis Gilmore >>> >>> El mar, 30-10-2018 a las 14:36 -0700, Vagrant Cascadian escribió: Tested series applied to u-boot 2018.11-rc3 on pinebook, both with reboot and cold boot. Thanks for all the work on it! Tested-by: Vagrant Cascadian On 2018-10-28, Vasily Khoruzhick wrote: > This series adds support for the Pinebook, an allwinner A64 laptop > produced by Pine64. It also syncs sun50i-a64.dtsi with linux, > adds support for mmc delay calibration, R_I2C controller, > and addresses the issue with activating video bridge when any of > GPIOs is missing. > > v2: - sync sun50i-a64.dtsi with linux instead of adding missing > nodes > - take sun50i-a64-pinebook.dts from linux > - don't introduce new Kconfig for A64 MMC calibration > - improve code in video bridge uclass to check for presensce of > GPIO instead of ingoring EINVAL errors > v3: - enable calibration for H6 as well > - init ret variable in video_bridge_set_active() > - fix order of dts files Makefile > - split anx6345 binding into sun50i-a64-pinebook-u-boot.dts > - drop speaker_amp node from pinebook dts > - drop unnecessary options from defconfig > v4: - sync device tree files with linux-next > > Vasily Khoruzhick (5): > mmc: sunxi: add support for automatic delay calibration > dm: video: bridge: don't fail to activate bridge if reset or > sleep > GPIO is missing > sunxi: DT: A64: update device tree files for Allwinner A64 SoC > sun50i: A64: add support for R_I2C controller > sunxi: DT: add support for Pinebook > > arch/arm/dts/Makefile| 1 + > arch/arm/dts/sun50i-a64-amarula-relic.dts| 168 +- > arch/arm/dts/sun50i-a64-bananapi-m64.dts | 34 +- > arch/arm/dts/sun50i-a64-nanopi-a64.dts | 89 +- > arch/arm/dts/sun50i-a64-olinuxino.dts| 103 +- > arch/arm/dts/sun50i-a64-orangepi-win.dts | 179 ++- > arch/arm/dts/sun50i-a64-pine64.dts | 32 +- > arch/arm/dts/sun50i-a64-pinebook-u-boot.dtsi | 15 + > arch/arm/dts/sun50i-a64-pinebook.dts | 294 > + > arch/arm/dts/sun50i-a64-sopine-baseboard.dts | 32 +- > arch/arm/dts/sun50i-a64-sopine.dtsi | 15 + > arch/arm/dts/sun50i-a64.dtsi | 313 > +-- > arch/arm/include/asm/arch-sunxi/gpio.h | 1 + > arch/arm/include/asm/arch-sunxi/mmc.h| 6 +- > arch/arm/mach-sunxi/Kconfig | 1 + > board/sunxi/board.c | 6 + > configs/pinebook_defconfig | 22 ++ > drivers/mmc/sunxi_mmc.c | 21 +- > drivers/video/bridge/video-bridge-uclass.c | 16 +- > 19 files changed, 1296 insertions(+), 52 deletions(-) > create mode 100644 arch/arm/dts/sun50i-a64-pinebook-u-boot.dtsi > create mode 100644 arch/arm/dts/sun50i-a64
Re: [U-Boot] [PATCH] doc: imx: fix typo in imximage.txt
Hi Michael, Em sex, 2 de nov de 2018 às 19:12, Michael Heimpold escreveu: > > Signed-off-by: Michael Heimpold Reviewed-by: Breno Lima Thanks, Breno Lima ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] doc: imx: fix typos in mxsimage.txt
Hi Michael, Em sex, 2 de nov de 2018 às 19:12, Michael Heimpold escreveu: > > This fixes two small typos in mxsimage.txt. > > Signed-off-by: Michael Heimpold Reviewed-by: Breno Lima Thanks, Breno Lima ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/5] Add support for Pinebook
On Sat, Nov 3, 2018 at 2:15 PM André Przywara wrote: > > On 11/3/18 8:19 PM, Vasily Khoruzhick wrote: > > > > You need "allwinner" branch from this repo. > > I deliberately switched the standard branch away, since everything is > merged in mainline ATF now (including PMIC support). I will post U-Boot > patches to change the instructions soon, but just use the master branch > from the official repo (and report back any issues!): > https://github.com/ARM-Software/arm-trusted-firmware.git > > You might need the latest DT in U-Boot (patches are queued, AFAIK) to > let ATF know about your PMIC requirements. Thanks, I just tested it - and my patches work fine with ATF from official repo. > Cheers, > Andre > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] pci: layerscape: Add the dts fixup for EP and RC
-Original Message- From: York Sun Sent: 2018年11月2日 22:53 To: Xiaowei Bao ; M.h. Lian ; Z.q. Hou ; Mingkai Hu ; bmeng...@gmail.com; yamada.masah...@socionext.com; u-boot@lists.denx.de Cc: Jiafei Pan Subject: Re: [U-Boot] [PATCH 3/3] pci: layerscape: Add the dts fixup for EP and RC On 10/25/18 7:01 PM, Xiaowei Bao wrote: > Add the dts fixup when PCI controller work diffferent mode. > > Signed-off-by: Xiaowei Bao > --- > drivers/pci/pcie_layerscape_fixup.c | 25 +++-- > 1 files changed, 23 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/pcie_layerscape_fixup.c > b/drivers/pci/pcie_layerscape_fixup.c > index 1a17bd9..089e031 100644 > --- a/drivers/pci/pcie_layerscape_fixup.c > +++ b/drivers/pci/pcie_layerscape_fixup.c > @@ -218,7 +218,7 @@ static void fdt_fixup_pcie(void *blob) } #endif > > -static void ft_pcie_ls_setup(void *blob, struct ls_pcie *pcie) > +static void ft_pcie_rc_fix(void *blob, struct ls_pcie *pcie) > { > int off; > uint svr; > @@ -243,12 +243,33 @@ static void ft_pcie_ls_setup(void *blob, struct ls_pcie > *pcie) > return; > } > > - if (pcie->enabled) > + if (pcie->enabled && pcie->mode == PCI_HEADER_TYPE_BRIDGE) > + fdt_set_node_status(blob, off, FDT_STATUS_OKAY, 0); > + else > + fdt_set_node_status(blob, off, FDT_STATUS_DISABLED, 0); } > + > +static void ft_pcie_ep_fix(void *blob, struct ls_pcie *pcie) { > + int off; > + > + off = fdt_node_offset_by_compat_reg(blob, "fsl,ls-pcie-ep", > + pcie->dbi_res.start); > + if (off < 0) > + return; > + > + if (pcie->enabled && pcie->mode == PCI_HEADER_TYPE_NORMAL) > fdt_set_node_status(blob, off, FDT_STATUS_OKAY, 0); > else > fdt_set_node_status(blob, off, FDT_STATUS_DISABLED, 0); } > > +static void ft_pcie_ls_setup(void *blob, struct ls_pcie *pcie) { > + ft_pcie_ep_fix(blob, pcie); > + ft_pcie_rc_fix(blob, pcie); > +} Wouldn't it be faster to check the result of first call before entering the second function? One cannot be both EP and RC, right? York [Xiaowei Bao] Hi York, we add the different note in DTS for RC mode and EP mode of one controller, and the compatible also difference, and the status is disabled in default, so we check the it separately. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot