Re: [U-Boot] Running vanilla u-boot v2012.10 on Guruplug
Hi Dirk, On Sat, 12 Jan 2013 20:41:36 +0100, Dirk Heinrichs wrote: > Am Samstag 12 Januar 2013, 16:51:51 schrieb Wolfgang Denk: > > > Did you read the FAQ? Especially > > http://www.denx.de/wiki/view/DULG/CanUBootBeConfiguredSuchThatItCanBeStarted > > InRAM ? > > Now I did :) Thanx a lot. > > Interesting that [1] states it's possible, though... > > Bye... > > Dirk My experience with starting U-Boot from RAM is that it's usually impossible when U-Boot is meant to start directly from FLASH, mostly (but not only) because the code at some point will rely on being able to keep on running even through access to DRAM is not possible. Now, starting U-Boot *may* be possible when U-Boot is loaded in DRAM before starting it, but is a very tricky and undependable process. For instance, on the Wireless Space target I am maintaining, and which is supposed to be preloaded from FLASH into DRAM by a ROM monitor, if I start the OpenOCD server, then in the console, do a break and / or a reset halt, I won't be able to load_image u-boot; whereas if I do the same actions as -c options when launching OpenOCD. And I have checked countless times that the DRAM init sequence in the config file is bit-for-bit identical to that used by the KWB which wraps the U-Boot image, and which boots fine on its own. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 1/1] mx31/mx35/mx51/mx53/mx6: add watchdog
On 12/01/2013 00:26, Troy Kisky wrote: > On 10/28/2012 4:48 AM, Stefano Babic wrote: >> On 23/10/2012 03:19, Troy Kisky wrote: >>> Use a common watchdog driver for all these cpus. >>> >>> Signed-off-by: Troy Kisky >>> >>> --- Hi Troy, >>> v2:add README.watchdog >>> include mx31/mx35 watchdogs >>> move to drivers/watchdog >>> >>> v3:change drivers/watchdog/Makefile to list relevant soc's >>> Please test on a mx31 and mx35 board. >>> qong and mx31pdk would be best!! >>> --- >>> arch/arm/cpu/arm1136/mx31/timer.c | 39 - >>> arch/arm/cpu/arm1136/mx35/generic.c |6 --- >>> arch/arm/imx-common/cpu.c |5 --- >>> arch/arm/include/asm/arch-mx31/clock.h|2 - >>> arch/arm/include/asm/arch-mx31/imx-regs.h | 13 +- >>> arch/arm/include/asm/arch-mx35/imx-regs.h | 11 + >>> arch/arm/include/asm/arch-mx5/imx-regs.h | 10 - >>> board/davedenx/qong/qong.c|9 +--- >>> board/freescale/mx31pdk/mx31pdk.c |9 +--- >>> board/hale/tt01/tt01.c|2 +- >>> doc/README.watchdog | 29 + >>> drivers/watchdog/Makefile |3 ++ >>> drivers/watchdog/imx_watchdog.c | 66 >>> + >>> include/configs/mx31pdk.h |1 + >>> include/configs/qong.h|1 + >>> include/watchdog.h|1 + >>> 16 files changed, 106 insertions(+), 101 deletions(-) >>> create mode 100644 doc/README.watchdog >>> create mode 100644 drivers/watchdog/imx_watchdog.c >>> >> >> Applied to u-boot-imx, thanks. >> >> Best regards, >> Stefano Babic >> >> > Has this patch been dropped?? I do not know what happened. You are right, the patch is missing. I have re-applied after rebasing - many thanks to have found this issue ! Thanks, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6 4/6] mx53loco: Add support to dynamically choose between fdt use or not
On 10/01/2013 20:45, Otavio Salvador wrote: > The CONFIG_SYS_CBSIZE has been change to 512 to avoid runtime errors as: > Hi Otavio, > ,---[ Runtime error ] > | Hit any key to stop autoboot: 0 > | MX53LOCO U-Boot > pri netboot > | netboot=echo Booting from net ...; run netargs; if test ... > | prefetch abort > | pc : [<20747368>] lr : [<20747365>] > | sp : af566e20 ip : fp : > | r10: 0002 r9 : af6dfc28 r8 : af566f58 > | r7 : af6dfc10 r6 : 0001 r5 : 0002 r4 : 74206669 > | r3 : r2 : 0060 r1 : 0020 r0 : 018e > | Flags: nZCv IRQs off FIQs off Mode SVC_32 > | Resetting CPU ... > | > | resetting ... > `--- Bug is fixed ! Tested-by: Stefano Babic Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] mx51evk: Add DVI output support
On 09/01/2013 15:55, Fabio Estevam wrote: > Add DVI output support and make it the default video output. > > Currently the CLAA WVGA panel is supported, but this panel has to be purchased > separately, so using the DVI output as the default would allow more people to > try the splash screen feature on a mx51evk. > > If someone still wants to use the CLAA WVGA, just set the panel variable as: > set panel claa > > Signed-off-by: Fabio Estevam > --- Applied to -u-boot-imx (fix), thanks. Best regards, Stefan Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] mx6qsabresd: Fix booting the kernel from SDHC3
On 10/01/2013 20:00, Fabio Estevam wrote: > Since commit de7d02aeb (mx6qsabresd: add usdhc2 and usdhc4 support) > SDHC3 device node is no longer 0, which breaks loading a uImage from SDHC3. > > Fix it by adapting the default environment to use CONFIG_SYS_MMC_ENV_DEV as > the > correct mmc node for loading the kernel from. > > While at it, go back to using SDHC3 as the default mmc, since we have Yocto > images that generate an SD card containing U-boot,kernel and rootfs, so it is > more convenient to keep using SDHC3 as it was originally. > > Signed-off-by: Fabio Estevam > --- Applied to -u-boot-imx (fix), thanks. Best regards, Stefan Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6 1/6] mx6qsabrelite: Use tabs to environment setting
On 10/01/2013 20:45, Otavio Salvador wrote: > This rework the environment to use tabs for environment setting as > done in other boards. > > Signed-off-by: Otavio Salvador > --- > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: > - New patch > Whole series applied to u-boot-imx, thanks! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Remove duplication of CONFIG_BOOTCOUNT_LIMIT
Remove duplication of CONFIG_BOOTCOUNT_LIMIT Signed-off-by: Ashok Kumar Reddy --- common/main.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/common/main.c b/common/main.c index 5d8454e..2314f27 100644 --- a/common/main.c +++ b/common/main.c @@ -369,16 +369,14 @@ void main_loop (void) #ifdef CONFIG_PREBOOT char *p; #endif + + bootstage_mark_name(BOOTSTAGE_ID_MAIN_LOOP, "main_loop"); + #ifdef CONFIG_BOOTCOUNT_LIMIT unsigned long bootcount = 0; unsigned long bootlimit = 0; char *bcs; char bcs_set[16]; -#endif /* CONFIG_BOOTCOUNT_LIMIT */ - - bootstage_mark_name(BOOTSTAGE_ID_MAIN_LOOP, "main_loop"); - -#ifdef CONFIG_BOOTCOUNT_LIMIT bootcount = bootcount_load(); bootcount++; bootcount_store (bootcount); -- 1.7.9.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Running vanilla u-boot v2012.10 on Guruplug
Hi Dirk, Am 13.01.2013 10:25, schrieb Albert ARIBAUD: On Sat, 12 Jan 2013 20:41:36 +0100, Dirk Heinrichs wrote: Am Samstag 12 Januar 2013, 16:51:51 schrieb Wolfgang Denk: Did you read the FAQ? Especially http://www.denx.de/wiki/view/DULG/CanUBootBeConfiguredSuchThatItCanBeStarted InRAM ? Now I did :) Thanx a lot. Interesting that [1] states it's possible, though... Bye... Dirk My experience with starting U-Boot from RAM is that it's usually impossible when U-Boot is meant to start directly from FLASH, mostly (but not only) because the code at some point will rely on being able to keep on running even through access to DRAM is not possible. You can use the kwboot tool from the tools directory to boot a Marvell Kirkwood SoC via UART0. Kind regards, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/10] lcd, amba: remove this frame buffer driver since it is not used
Hello. > Since CONFIG_VIDEO_AMBA is not set by any board, it does not seem > to be used, so remove it since there is no way to (compile) test it. I used the driver on the nhk8815. But actually it looks like the "later patch in this set", that my commit message references, was not merged. I remember I used it in 32-bit mode and had to hack some things to make it work, inluding a fater memcopy as scrolling was very slow. I don't think I can resurrect my nhk8815 device any soon, and it looks like nobody else is using this logic cell, so I'm fine removing the driver. Acked-by: Alessandro Rubini /alessandro ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Remove duplication of CONFIG_BOOTCOUNT_LIMIT
Dear Ashok Kumar Reddy, In message <50f2d8d2.9010...@gmail.com> you wrote: > Remove duplication of CONFIG_BOOTCOUNT_LIMIT > > Signed-off-by: Ashok Kumar Reddy > --- > common/main.c |8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/common/main.c b/common/main.c > index 5d8454e..2314f27 100644 > --- a/common/main.c > +++ b/common/main.c > @@ -369,16 +369,14 @@ void main_loop (void) > #ifdef CONFIG_PREBOOT > char *p; > #endif > + > + bootstage_mark_name(BOOTSTAGE_ID_MAIN_LOOP, "main_loop"); > + > #ifdef CONFIG_BOOTCOUNT_LIMIT > unsigned long bootcount = 0; > unsigned long bootlimit = 0; > char *bcs; > char bcs_set[16]; > -#endif /* CONFIG_BOOTCOUNT_LIMIT */ > - > - bootstage_mark_name(BOOTSTAGE_ID_MAIN_LOOP, "main_loop"); > - > -#ifdef CONFIG_BOOTCOUNT_LIMIT > bootcount = bootcount_load(); > bootcount++; > bootcount_store (bootcount); NAK. You must not move code right in the middle of the declarations. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de What was sliced bread the greatest thing since? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Running vanilla u-boot v2012.10 on Guruplug
Hello, thanks a lot for all your helpful replies. I have tested v2012.10 succesfully using the OpenOCD method and wrote it to nand from within itself afterwards. I wasn't sure where Debians 2012.04.01 came from (Denx or Marvell), so I needed the test. Now that I'm confident that vanilla versions will work w/o problems, I will flash future versions directly from the running Linux system again. Bye... Dirk -- Dirk Heinrichs Tel: +49 (0)2471 209385 | Mobil: +49 (0)176 34473913 GPG Public Key C2E467BB | Jabber: dirk.heinri...@altum.de signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] fix linker generated lists on non-C locales
Dear David Marqvar Nielsen, > Hi Marex, > > Any change that the fix for the problem this patch addresses will make it > into 2013.01 ? > I will test the variant "*LC_ALL= *LC_COLLATE=C sort -u | \ > tomorrow. Please always reply to the list. I'm Ccing most of the involved people. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Googlers please reply: commiters in U-Boot
I work for Google and have as long as I have had a chromium.org account. Anything from diand...@google.com or diand...@chromium.org can be attributed to Google. On Sat, Jan 12, 2013 at 9:20 AM, Simon Glass wrote: > Hi, > > You are being copied because you have written U-Boot code which is now > in mainline. > > The chromium.org domain does not automatically attribute U-Boot > commits by company. Each author needs to be manually added to the list > and this can only be done if you confirm your employer. > > So, if you are on the CC list and work at Google, please reply-all > with a quick email stating this (without top posting). > > Regards, > Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] please pull u-boot-samsung master
Hi Albert, - VCMA9 is broken by commit a9d2ae7014d9e66dde6dd4a344308449508e4a22, >> which causes the following build errors: >> >> In file included from s3c24x0_i2c.c:40:0: >> s3c24x0_i2c.h:38:17: error: field 'id' has incomplete type >> s3c24x0_i2c.c:70:39: error: 'CONFIG_MAX_I2C_NUM' undeclared here (not >> in a function) s3c24x0_i2c.c:70:31: warning: 'i2c_bus' defined but >> not used [-Wunused-variable] s3c24x0_i2c.c:72:12: warning: >> 'i2c_busses' defined but not used [-Wunused-variable] I would resolve these errors sorry for inconvenience >> - smdk5250 is broken by commit f482310c6def17ba975a041077f89d984be54b68 >> which causes the following build errors: >> >> sound.c: In function 'codec_init': >> sound.c:151:4: warning: passing argument 1 of 'wm8994_init' discards >> 'const' qualifier from pointer target type [enabled by default] In file >> included from sound.c:33:0: wm8994.h:83:5: note: expected 'struct >> sound_codec_info *' but argument is of type 'const void *' cmd_sound.c: >> In function 'do_init': cmd_sound.c:36:2: error: too few arguments to >> function 'sound_init' In file included from cmd_sound.c:27:0: >> /home/albert/src/u-boot-arm/include/sound.h:52:5: note: declared here Sorry but I am not getting these errors could you please let me know you your environment settings to get the same. -- Regards, Rajeshwari Shinde On Sat, Jan 12, 2013 at 1:31 PM, Albert ARIBAUD wrote: > On Fri, 11 Jan 2013 22:33:58 +0100, Albert ARIBAUD > wrote: >> Hi Minkyu, >> >> On Fri, 11 Jan 2013 17:23:10 +0900, Minkyu Kang >> wrote: >> > Dear Albert, >> > >> > Merge samsung, imx, tegra into u-boot-arm/master (2012-12-22 11:59:14 >> > +0100) >> > >> > are available in the git repository at: >> > >> > >> > git://git.denx.de/u-boot-samsung master >> > >> > for you to fetch changes up to a2468dedef569863e1243e802fbe3aa7565e1de1: >> > >> > EXYNOS5: Enable console multiplexing in u-boot (2013-01-11 17:15:04 >> > +0900) >> > >> > >> > Ajay Kumar (6): >> > EXYNOS5: Add support for FIMD and DP >> > EXYNOS5: Change parent clock of FIMD to MPLL >> > EXYNOS: Add dummy definition to fix compilation dependency on >> > CONFIG_EXYNOS_MIPI_DSIM >> > video: Modify exynos_fimd driver to support LCD console >> > EXYNOS5: Make all display related code dependent on CONFIG_LCD >> > EXYNOS5: Enable console multiplexing in u-boot >> > >> > Chander Kashyap (4): >> > EXYNOS: EXYNOS4X12: Populate Exynos4x12 register addresses >> > EXYNOS: EXYNOS4X12: Add clock structure for EXYNOS4X12 >> > EXYNOS: EXYNOS4X12: Add gpio structure for EXYNOS4X12 >> > EXYNOS: EXYNOS4X12: extract Exynos4x12 IPs clock frequency >> > >> > Hatim RV (5): >> > EXYNOS5: FDT: add initial dts file for EXYNOS5250, SMDK5250 >> > fdt: exynos5: Add DT node definition for SROM and SMSC9215 >> > exynos5: Add DT based driver for SMC911X ethernet >> > exynos5: config: Rename the smdk5250.h to exynos5250-dt.h >> > SMDK5250: config: Add configuration file for SMDK5250 board >> > >> > Jaehoon Chung (2): >> > Exynos: clock: support get_mmc_clk for exynos >> > Exynos: clock: add CLK_DIV_FSYS3 at set_mmc_clk >> > >> > Piotr Wilczek (1): >> > arm:exynos4:pinmux: Modify the gpio function for mmc >> > >> > Rajeshwari Shinde (22): >> > EXYNOS5: FDT: Add I2C device node data >> > EXYNOS5 : FDT: Add Aliases for I2C device >> > FDT: Add compatible string for I2C >> > EXYNOS5: FDT : Decode peripheral id >> > I2C: Driver changes for FDT support >> > SMDK5250: Initialise I2C using FDT >> > EXYNOS5: FDT: Add sound device node data >> > EXYNOS5: FDT: Add sound and codec device node >> > EXYNOS5: FDT: Add compatible strings for sound >> > Sound: Add FDT support to driver >> > Sound: WM8994: Add FDT support to codec >> > Sound: Add FDT support to CMD. >> > EXYNOS5: FDT: Add compatible strings for SPI >> > EXYNOS5 : FDT: Add Aliases for SPI device >> > EXYNOS5: FDT: Add SPI device node data >> > SPI: EXYNOS: Add FDT support to driver. >> > EHCI: Exynos: Add fdt support >> > EXYNOS5: Add device node for USB. >> > EXYNOS5: FDT: Add compatible strings for USB >> > EXYNOS5: FDT: Add compatible strings for PMIC >> > EXYNOS5: Add device node for PMIC >> > PMIC: MAX77686: Add FDT Support >> > >> > Vivek Gautam (1): >> > SMDK5250: Enable VBus for USB 2.0 controller >> > >> > Łukasz Majewski (2): >> > spl:falcon:trats Update Trats default board configuration file to >> > support FALCON MODE >> > video:cache:fix: Enable dcache flush at LCD subsystem for Exynos >> > based boards >> > >> > arch/arm/cpu/armv7/exynos/clock.c| 272 +- >> > arch/arm/cpu/armv7/exynos/pinmux.c | 74 ++ >> > arch/arm/dts/exynos5250.dtsi
Re: [U-Boot] please pull u-boot-samsung master
Dear Albert, On 12/01/13 06:33, Albert ARIBAUD wrote: > Hi Minkyu, > > On Fri, 11 Jan 2013 17:23:10 +0900, Minkyu Kang > wrote: >> Dear Albert, >> >> Merge samsung, imx, tegra into u-boot-arm/master (2012-12-22 11:59:14 >> +0100) >> >> are available in the git repository at: >> >> >> git://git.denx.de/u-boot-samsung master >> >> for you to fetch changes up to a2468dedef569863e1243e802fbe3aa7565e1de1: >> >> EXYNOS5: Enable console multiplexing in u-boot (2013-01-11 17:15:04 +0900) >> >> >> Ajay Kumar (6): >> EXYNOS5: Add support for FIMD and DP >> EXYNOS5: Change parent clock of FIMD to MPLL >> EXYNOS: Add dummy definition to fix compilation dependency on >> CONFIG_EXYNOS_MIPI_DSIM >> video: Modify exynos_fimd driver to support LCD console >> EXYNOS5: Make all display related code dependent on CONFIG_LCD >> EXYNOS5: Enable console multiplexing in u-boot >> >> Chander Kashyap (4): >> EXYNOS: EXYNOS4X12: Populate Exynos4x12 register addresses >> EXYNOS: EXYNOS4X12: Add clock structure for EXYNOS4X12 >> EXYNOS: EXYNOS4X12: Add gpio structure for EXYNOS4X12 >> EXYNOS: EXYNOS4X12: extract Exynos4x12 IPs clock frequency >> >> Hatim RV (5): >> EXYNOS5: FDT: add initial dts file for EXYNOS5250, SMDK5250 >> fdt: exynos5: Add DT node definition for SROM and SMSC9215 >> exynos5: Add DT based driver for SMC911X ethernet >> exynos5: config: Rename the smdk5250.h to exynos5250-dt.h >> SMDK5250: config: Add configuration file for SMDK5250 board >> >> Jaehoon Chung (2): >> Exynos: clock: support get_mmc_clk for exynos >> Exynos: clock: add CLK_DIV_FSYS3 at set_mmc_clk >> >> Piotr Wilczek (1): >> arm:exynos4:pinmux: Modify the gpio function for mmc >> >> Rajeshwari Shinde (22): >> EXYNOS5: FDT: Add I2C device node data >> EXYNOS5 : FDT: Add Aliases for I2C device >> FDT: Add compatible string for I2C >> EXYNOS5: FDT : Decode peripheral id >> I2C: Driver changes for FDT support >> SMDK5250: Initialise I2C using FDT >> EXYNOS5: FDT: Add sound device node data >> EXYNOS5: FDT: Add sound and codec device node >> EXYNOS5: FDT: Add compatible strings for sound >> Sound: Add FDT support to driver >> Sound: WM8994: Add FDT support to codec >> Sound: Add FDT support to CMD. >> EXYNOS5: FDT: Add compatible strings for SPI >> EXYNOS5 : FDT: Add Aliases for SPI device >> EXYNOS5: FDT: Add SPI device node data >> SPI: EXYNOS: Add FDT support to driver. >> EHCI: Exynos: Add fdt support >> EXYNOS5: Add device node for USB. >> EXYNOS5: FDT: Add compatible strings for USB >> EXYNOS5: FDT: Add compatible strings for PMIC >> EXYNOS5: Add device node for PMIC >> PMIC: MAX77686: Add FDT Support >> >> Vivek Gautam (1): >> SMDK5250: Enable VBus for USB 2.0 controller >> >> Łukasz Majewski (2): >> spl:falcon:trats Update Trats default board configuration file to >> support FALCON MODE >> video:cache:fix: Enable dcache flush at LCD subsystem for Exynos based >> boards >> >> arch/arm/cpu/armv7/exynos/clock.c| 272 +- >> arch/arm/cpu/armv7/exynos/pinmux.c | 74 ++ >> arch/arm/dts/exynos5250.dtsi | 154 >> arch/arm/include/asm/arch-exynos/clk.h |1 + >> arch/arm/include/asm/arch-exynos/clock.h | 276 ++ >> arch/arm/include/asm/arch-exynos/cpu.h | 48 +++- >> arch/arm/include/asm/arch-exynos/dp_info.h |2 + >> arch/arm/include/asm/arch-exynos/gpio.h | 85 +++ >> arch/arm/include/asm/arch-exynos/mipi_dsim.h |7 + >> arch/arm/include/asm/arch-exynos/periph.h| 33 +-- >> arch/arm/include/asm/arch-exynos/pinmux.h|8 + >> arch/arm/include/asm/arch-exynos/sromc.h | 18 ++ >> board/samsung/dts/exynos5250-smdk5250.dts| 69 ++ >> board/samsung/smdk5250/smdk5250.c| 237 +++ >> board/samsung/trats/trats.c |2 +- >> common/cmd_sound.c |2 +- >> doc/device-tree-bindings/exynos/isp-spi.txt | 22 ++ >> doc/device-tree-bindings/exynos/sound.txt| 27 +++ >> drivers/i2c/s3c24x0_i2c.c| 83 ++- >> drivers/i2c/s3c24x0_i2c.h|8 + >> drivers/power/pmic/pmic_max77686.c | 37 ++- >> drivers/sound/sound.c| 171 -- >> drivers/sound/wm8994.c | 74 +- >> drivers/sound/wm8994.h |6 +- >> drivers/spi/exynos_spi.c | 96 +++- >> drivers/usb/host/ehci-exynos.c | 92 +++- >> drivers/video/exynos_fb.c|5 + >> drivers/video/exynos_fimd.c | 12 +- >> include/config
[U-Boot] [PATCH] I2C: S3C24X0: Resolve build error for VCMA9
This patch resolves the build error for I2C driver in
VCMA9.
Signed-off-by: Rajeshwari Shinde
---
drivers/i2c/s3c24x0_i2c.c |4 +++-
drivers/i2c/s3c24x0_i2c.h |3 ++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c
index 7ec01ec..769a2ba 100644
--- a/drivers/i2c/s3c24x0_i2c.c
+++ b/drivers/i2c/s3c24x0_i2c.c
@@ -67,9 +67,11 @@
* variables to live in SRAM
*/
static unsigned int g_current_bus __attribute__((section(".data")));
+#ifdef CONFIG_OF_CONTROL
+static int i2c_busses __attribute__((section(".data")));
static struct s3c24x0_i2c_bus i2c_bus[CONFIG_MAX_I2C_NUM]
__attribute__((section(".data")));
-static int i2c_busses __attribute__((section(".data")));
+#endif
#if !(defined CONFIG_EXYNOS4 || defined CONFIG_EXYNOS5)
static int GetI2CSDA(void)
diff --git a/drivers/i2c/s3c24x0_i2c.h b/drivers/i2c/s3c24x0_i2c.h
index 1243bf1..c75bcab 100644
--- a/drivers/i2c/s3c24x0_i2c.h
+++ b/drivers/i2c/s3c24x0_i2c.h
@@ -31,11 +31,12 @@ struct s3c24x0_i2c {
u32 iiclc;
};
+#ifdef CONFIG_OF_CONTROL
struct s3c24x0_i2c_bus {
int node; /* device tree node */
int bus_num;/* i2c bus number */
struct s3c24x0_i2c *regs;
enum periph_id id;
};
-
+#endif
#endif /* _S3C24X0_I2C_H */
--
1.7.4.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] I2C: S3C24X0: Resolve build error for VCMA9
On 14/01/13 14:17, Rajeshwari Shinde wrote:
> This patch resolves the build error for I2C driver in
> VCMA9.
what about errors?
>
> Signed-off-by: Rajeshwari Shinde
> ---
> drivers/i2c/s3c24x0_i2c.c |4 +++-
> drivers/i2c/s3c24x0_i2c.h |3 ++-
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c
> index 7ec01ec..769a2ba 100644
> --- a/drivers/i2c/s3c24x0_i2c.c
> +++ b/drivers/i2c/s3c24x0_i2c.c
> @@ -67,9 +67,11 @@
> * variables to live in SRAM
> */
> static unsigned int g_current_bus __attribute__((section(".data")));
> +#ifdef CONFIG_OF_CONTROL
> +static int i2c_busses __attribute__((section(".data")));
> static struct s3c24x0_i2c_bus i2c_bus[CONFIG_MAX_I2C_NUM]
> __attribute__((section(".data")));
> -static int i2c_busses __attribute__((section(".data")));
> +#endif
>
> #if !(defined CONFIG_EXYNOS4 || defined CONFIG_EXYNOS5)
> static int GetI2CSDA(void)
> diff --git a/drivers/i2c/s3c24x0_i2c.h b/drivers/i2c/s3c24x0_i2c.h
> index 1243bf1..c75bcab 100644
> --- a/drivers/i2c/s3c24x0_i2c.h
> +++ b/drivers/i2c/s3c24x0_i2c.h
> @@ -31,11 +31,12 @@ struct s3c24x0_i2c {
> u32 iiclc;
> };
>
> +#ifdef CONFIG_OF_CONTROL
> struct s3c24x0_i2c_bus {
> int node; /* device tree node */
> int bus_num;/* i2c bus number */
> struct s3c24x0_i2c *regs;
> enum periph_id id;
I think int is suitable more than enum.
Currently periph_id is exynos specific.
> };
> -
> +#endif
> #endif /* _S3C24X0_I2C_H */
>
Thanks.
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Googlers please reply: commiters in U-Boot
On Sun, Jan 13, 2013 at 1:20 AM, Simon Glass wrote: > Hi, > > You are being copied because you have written U-Boot code which is now > in mainline. > > The chromium.org domain does not automatically attribute U-Boot > commits by company. Each author needs to be manually added to the list > and this can only be done if you confirm your employer. > > So, if you are on the CC list and work at Google, please reply-all > with a quick email stating this (without top posting). > > Regards, > Simon > I work for Google and CLs from hun...@chromium.org or hun...@google.com can be attributed to Google. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Googlers please reply: commiters in U-Boot
I work at Google and CLs from yj...@google.com or yj...@chromium.org can be attributed to Google. On Mon, Jan 14, 2013 at 10:02 AM, Hung-Te Lin wrote: > On Sun, Jan 13, 2013 at 1:20 AM, Simon Glass wrote: > >> Hi, >> >> You are being copied because you have written U-Boot code which is now >> in mainline. >> >> The chromium.org domain does not automatically attribute U-Boot >> commits by company. Each author needs to be manually added to the list >> and this can only be done if you confirm your employer. >> >> So, if you are on the CC list and work at Google, please reply-all >> with a quick email stating this (without top posting). >> >> Regards, >> Simon >> > > I work for Google and CLs from hun...@chromium.org or hun...@google.com can > be attributed to Google. > > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Googlers please reply: commiters in U-Boot
I work at Google and any submission from semenz...@chromium.org or semenz...@google.com can be attributed to Google. On Sun, Jan 13, 2013 at 7:31 PM, Louis Yung-Chieh Lo wrote: > I work at Google and CLs from yj...@google.com or yj...@chromium.org can be > attributed to Google. > > > On Mon, Jan 14, 2013 at 10:02 AM, Hung-Te Lin wrote: >> >> On Sun, Jan 13, 2013 at 1:20 AM, Simon Glass wrote: >>> >>> Hi, >>> >>> You are being copied because you have written U-Boot code which is now >>> in mainline. >>> >>> The chromium.org domain does not automatically attribute U-Boot >>> commits by company. Each author needs to be manually added to the list >>> and this can only be done if you confirm your employer. >>> >>> So, if you are on the CC list and work at Google, please reply-all >>> with a quick email stating this (without top posting). >>> >>> Regards, >>> Simon >> >> >> I work for Google and CLs from hun...@chromium.org or hun...@google.com >> can be attributed to Google. >> > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V2] I2C: S3C24X0: Resolve build error for VCMA9
This patch resolves the following build errors for I2C driver in
VCMA9:
In file included from s3c24x0_i2c.c:40:0:
s3c24x0_i2c.h:38:17: error: field 'id' has incomplete type
s3c24x0_i2c.c:70:39: error: 'CONFIG_MAX_I2C_NUM' undeclared here (not
in a function) s3c24x0_i2c.c:70:31: warning: 'i2c_bus' defined but
not used [-Wunused-variable] s3c24x0_i2c.c:72:12: warning:
'i2c_busses' defined but not used [-Wunused-variable]
Signed-off-by: Rajeshwari Shinde
---
Changes since V1:
- Changes the commit message to add the errors.
- changed enum periph_id to int
drivers/i2c/s3c24x0_i2c.c |4 +++-
drivers/i2c/s3c24x0_i2c.h |3 +--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c
index 7ec01ec..769a2ba 100644
--- a/drivers/i2c/s3c24x0_i2c.c
+++ b/drivers/i2c/s3c24x0_i2c.c
@@ -67,9 +67,11 @@
* variables to live in SRAM
*/
static unsigned int g_current_bus __attribute__((section(".data")));
+#ifdef CONFIG_OF_CONTROL
+static int i2c_busses __attribute__((section(".data")));
static struct s3c24x0_i2c_bus i2c_bus[CONFIG_MAX_I2C_NUM]
__attribute__((section(".data")));
-static int i2c_busses __attribute__((section(".data")));
+#endif
#if !(defined CONFIG_EXYNOS4 || defined CONFIG_EXYNOS5)
static int GetI2CSDA(void)
diff --git a/drivers/i2c/s3c24x0_i2c.h b/drivers/i2c/s3c24x0_i2c.h
index 1243bf1..a56d749 100644
--- a/drivers/i2c/s3c24x0_i2c.h
+++ b/drivers/i2c/s3c24x0_i2c.h
@@ -35,7 +35,6 @@ struct s3c24x0_i2c_bus {
int node; /* device tree node */
int bus_num;/* i2c bus number */
struct s3c24x0_i2c *regs;
- enum periph_id id;
+ int id;
};
-
#endif /* _S3C24X0_I2C_H */
--
1.7.4.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/4 V2] SMDK5250: Convert lowlevel_init.S to lowlevel_init.c
Hi Minkyu Kang, >OK, but is this something you intend to fix, perhaps in a future > series? It seems like you need separate directories sooner rather than > later.I don't think this is board-specific code, but chip-specific. Please do let me know your opinion on the above comment. Regards, Rajeshwari Shinde. On Fri, Jan 11, 2013 at 7:54 PM, Simon Glass wrote: > Hi Rajeshwari, > > On Fri, Jan 11, 2013 at 2:43 AM, Rajeshwari Birje > wrote: >> Hi Simon, >> >> Thank you for comments. >> >> On Thu, Jan 10, 2013 at 11:04 PM, Simon Glass wrote: >>> Hi Rajeshwari, >>> >>> On Mon, Jan 7, 2013 at 5:08 AM, Rajeshwari Shinde >>> wrote: This patch converts lowlevel_init.S to lowlevel_init_c.c for SMDK5250. Lowlevel.S as of now added only for SMDK5250 and same can be extended to other SOC in future. >>> >>> Should perhaps also mention new feature (controllable memory reset for >>> resume?) >> -OK >>> Signed-off-by: Rajeshwari Shinde --- Changes in V2: - Renamed lowlevel_init.S to lowlevel.S and moved to arch/arm/cpu/armv7/exynos/ - Moved power mode defines to power.h - Added early serial support. - Renamed mem_reset to reset. arch/arm/cpu/armv7/exynos/Makefile |6 ++ arch/arm/cpu/armv7/exynos/lowlevel.S | 35 arch/arm/include/asm/arch-exynos/power.h |8 ++ board/samsung/smdk5250/Makefile |2 +- board/samsung/smdk5250/dmc_common.c |4 +- board/samsung/smdk5250/dmc_init_ddr3.c |6 +- board/samsung/smdk5250/lowlevel_init.S | 96 board/samsung/smdk5250/lowlevel_init.c | 81 + >>> >>> Any change we could move all of this to arch/arm/cpu/armv7/exynos...? >> We do not have a separate directory for exynos5 and exynos4 and if we >> add all these files in arch/arm/cpu/armv7/exynos it would break the >> compilation for EXYNOS4. Also Later versions of exynos5 have different >> memory and timing variants. > > OK, but is this something you intend to fix, perhaps in a future > series? It seems like you need separate directories sooner rather than > later.I don't think this is board-specific code, but chip-specific. > >>> >>> It really doesn't relate to this board alone, but to the chip. >>> board/samsung/smdk5250/setup.h | 19 - board/samsung/smdk5250/spl_boot.c| 140 +++-- spl/Makefile |4 + 11 files changed, 288 insertions(+), 113 deletions(-) create mode 100644 arch/arm/cpu/armv7/exynos/lowlevel.S delete mode 100644 board/samsung/smdk5250/lowlevel_init.S create mode 100644 board/samsung/smdk5250/lowlevel_init.c diff --git a/arch/arm/cpu/armv7/exynos/Makefile b/arch/arm/cpu/armv7/exynos/Makefile index 9119961..2aa2722 100644 --- a/arch/arm/cpu/armv7/exynos/Makefile +++ b/arch/arm/cpu/armv7/exynos/Makefile @@ -22,6 +22,12 @@ include $(TOPDIR)/config.mk LIB= $(obj)lib$(SOC).o +ifdef CONFIG_SMDK5250 +ifdef CONFIG_SPL +COBJS += lowlevel.o >>> >>> Could do: >>> >>> COBJS-$(CONFIG_SPL) += lowlevel.o >>> >>> and remove the inner ifdef >> - OK >>> +endif +endif + COBJS += clock.o power.o soc.o system.o pinmux.o SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) diff --git a/arch/arm/cpu/armv7/exynos/lowlevel.S b/arch/arm/cpu/armv7/exynos/lowlevel.S new file mode 100644 index 000..7307959 --- /dev/null +++ b/arch/arm/cpu/armv7/exynos/lowlevel.S @@ -0,0 +1,35 @@ +/* + * Lowlevel setup for SMDK5250 board based on S5PC520 + * + * Copyright (C) 2012 Samsung Electronics + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, + * MA 02111-1307 USA + */ + +#include +#include + + .globl lowlevel_init +lowlevel_init: + /* +* Set the stack pointer, although it will be overwritten by the caller +* It seems we will not boot if this
Re: [U-Boot] [PATCH V2] I2C: S3C24X0: Resolve build error for VCMA9
Hello Rajeshwari, On 14.01.2013 06:49, Rajeshwari Shinde wrote: This patch resolves the following build errors for I2C driver in VCMA9: In file included from s3c24x0_i2c.c:40:0: s3c24x0_i2c.h:38:17: error: field 'id' has incomplete type s3c24x0_i2c.c:70:39: error: 'CONFIG_MAX_I2C_NUM' undeclared here (not in a function) s3c24x0_i2c.c:70:31: warning: 'i2c_bus' defined but not used [-Wunused-variable] s3c24x0_i2c.c:72:12: warning: 'i2c_busses' defined but not used [-Wunused-variable] Which U-Boot do you use? I just tried current head of mainline: [hs@pollux u-boot]$ git log commit fd70aa41468be4324275910f85578cb5be6a0439 Author: angelo Date: Fri Nov 23 12:23:39 2012 + m68k/lib: fix serial driver relocation Fix coldfire serial driver bindings no more relocated to ram after last changes to drivers/serial/serial.c (regression). Serial initialization in ram has to be called after that gd->reloc_off is calculated. Signed-off-by: Angelo Dureghello Cc: Jason Jin Acked-by: Jens Scharsig (BuS Elektronik) Tested-by: Jens Scharsig (BuS Elektronik) and it compiles clean with eldk-5.2: [hs@pollux u-boot]$ ./MAKEALL VCMA9 Configuring for VCMA9 board... textdata bss dec hex filename 523055 15112 296056 834223 cbaaf ./u-boot - SUMMARY Boards compiled: 1 -- [hs@pollux u-boot]$ bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2] I2C: S3C24X0: Resolve build error for VCMA9
Hi Heiko, I built it on latest tree u-boot-samsung. For VCMA9_config I got the the errors. Regards, Rajeshwari Shinde. On Mon, Jan 14, 2013 at 12:12 PM, Heiko Schocher wrote: > -- Regards, Rajeshwari Shinde ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] please pull u-boot-samsung master
Hi Minkyu, On Mon, 14 Jan 2013 13:56:40 +0900, Minkyu Kang wrote: > Dear Albert, > > On 12/01/13 06:33, Albert ARIBAUD wrote: > > Hi Minkyu, > > > > On Fri, 11 Jan 2013 17:23:10 +0900, Minkyu Kang > > wrote: > >> Dear Albert, > >> > >> Merge samsung, imx, tegra into u-boot-arm/master (2012-12-22 11:59:14 > >> +0100) > >> > >> are available in the git repository at: > >> > >> > >> git://git.denx.de/u-boot-samsung master > >> > >> for you to fetch changes up to a2468dedef569863e1243e802fbe3aa7565e1de1: > >> > >> EXYNOS5: Enable console multiplexing in u-boot (2013-01-11 17:15:04 > >> +0900) > >> > >> > >> Ajay Kumar (6): > >> EXYNOS5: Add support for FIMD and DP > >> EXYNOS5: Change parent clock of FIMD to MPLL > >> EXYNOS: Add dummy definition to fix compilation dependency on > >> CONFIG_EXYNOS_MIPI_DSIM > >> video: Modify exynos_fimd driver to support LCD console > >> EXYNOS5: Make all display related code dependent on CONFIG_LCD > >> EXYNOS5: Enable console multiplexing in u-boot > >> > >> Chander Kashyap (4): > >> EXYNOS: EXYNOS4X12: Populate Exynos4x12 register addresses > >> EXYNOS: EXYNOS4X12: Add clock structure for EXYNOS4X12 > >> EXYNOS: EXYNOS4X12: Add gpio structure for EXYNOS4X12 > >> EXYNOS: EXYNOS4X12: extract Exynos4x12 IPs clock frequency > >> > >> Hatim RV (5): > >> EXYNOS5: FDT: add initial dts file for EXYNOS5250, SMDK5250 > >> fdt: exynos5: Add DT node definition for SROM and SMSC9215 > >> exynos5: Add DT based driver for SMC911X ethernet > >> exynos5: config: Rename the smdk5250.h to exynos5250-dt.h > >> SMDK5250: config: Add configuration file for SMDK5250 board > >> > >> Jaehoon Chung (2): > >> Exynos: clock: support get_mmc_clk for exynos > >> Exynos: clock: add CLK_DIV_FSYS3 at set_mmc_clk > >> > >> Piotr Wilczek (1): > >> arm:exynos4:pinmux: Modify the gpio function for mmc > >> > >> Rajeshwari Shinde (22): > >> EXYNOS5: FDT: Add I2C device node data > >> EXYNOS5 : FDT: Add Aliases for I2C device > >> FDT: Add compatible string for I2C > >> EXYNOS5: FDT : Decode peripheral id > >> I2C: Driver changes for FDT support > >> SMDK5250: Initialise I2C using FDT > >> EXYNOS5: FDT: Add sound device node data > >> EXYNOS5: FDT: Add sound and codec device node > >> EXYNOS5: FDT: Add compatible strings for sound > >> Sound: Add FDT support to driver > >> Sound: WM8994: Add FDT support to codec > >> Sound: Add FDT support to CMD. > >> EXYNOS5: FDT: Add compatible strings for SPI > >> EXYNOS5 : FDT: Add Aliases for SPI device > >> EXYNOS5: FDT: Add SPI device node data > >> SPI: EXYNOS: Add FDT support to driver. > >> EHCI: Exynos: Add fdt support > >> EXYNOS5: Add device node for USB. > >> EXYNOS5: FDT: Add compatible strings for USB > >> EXYNOS5: FDT: Add compatible strings for PMIC > >> EXYNOS5: Add device node for PMIC > >> PMIC: MAX77686: Add FDT Support > >> > >> Vivek Gautam (1): > >> SMDK5250: Enable VBus for USB 2.0 controller > >> > >> Łukasz Majewski (2): > >> spl:falcon:trats Update Trats default board configuration file to > >> support FALCON MODE > >> video:cache:fix: Enable dcache flush at LCD subsystem for Exynos > >> based boards > >> > >> arch/arm/cpu/armv7/exynos/clock.c| 272 +- > >> arch/arm/cpu/armv7/exynos/pinmux.c | 74 ++ > >> arch/arm/dts/exynos5250.dtsi | 154 > >> arch/arm/include/asm/arch-exynos/clk.h |1 + > >> arch/arm/include/asm/arch-exynos/clock.h | 276 ++ > >> arch/arm/include/asm/arch-exynos/cpu.h | 48 +++- > >> arch/arm/include/asm/arch-exynos/dp_info.h |2 + > >> arch/arm/include/asm/arch-exynos/gpio.h | 85 +++ > >> arch/arm/include/asm/arch-exynos/mipi_dsim.h |7 + > >> arch/arm/include/asm/arch-exynos/periph.h| 33 +-- > >> arch/arm/include/asm/arch-exynos/pinmux.h|8 + > >> arch/arm/include/asm/arch-exynos/sromc.h | 18 ++ > >> board/samsung/dts/exynos5250-smdk5250.dts| 69 ++ > >> board/samsung/smdk5250/smdk5250.c| 237 +++ > >> board/samsung/trats/trats.c |2 +- > >> common/cmd_sound.c |2 +- > >> doc/device-tree-bindings/exynos/isp-spi.txt | 22 ++ > >> doc/device-tree-bindings/exynos/sound.txt| 27 +++ > >> drivers/i2c/s3c24x0_i2c.c| 83 ++- > >> drivers/i2c/s3c24x0_i2c.h|8 + > >> drivers/power/pmic/pmic_max77686.c | 37 ++- > >> drivers/sound/sound.c| 171 -- > >> drivers/sound/wm8994.c | 74 +- > >> drivers/sound/wm8994.h
Re: [U-Boot] [STATUS] v2013.01-rc3 out
On 01/10/2013 11:49 PM, Tom Rini wrote: Hey all, As a reminder, we're scheduled for v2013.01 on the 15th. I've pushed out v2013.01-rc3 now. I still expect: - At least one more u-boot-arm PR - Any other outstand bug fixes I saw there was a request for an m68k change to come in from a developer, Jason can you review and pass along please? It is assigned to you in patchwork. And I suspect there's a few more bugfixes out there we need to handle (I know of 2 different one for IGEP boards). Please remind me here if there's something else that needs reviewing and going in, thanks! Any chance of including my card detect and write protection series for omap mmc (omap mmc: implement card detect and write protection)? We really want this in the next release and it looks like Andy is away, so he probably won't respond to it in time. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot -- Regards, Nikita. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/4 V2] SMDK5250: Convert lowlevel_init.S to lowlevel_init.c
On 11/01/13 19:10, Rajeshwari Birje wrote: > Hi Minkyu Kang, > > Thank you for comments. > > On Fri, Jan 11, 2013 at 1:24 PM, Minkyu Kang wrote: >> Dear Rajeshwari, >> >> On 07/01/13 22:08, Rajeshwari Shinde wrote: >>> This patch converts lowlevel_init.S to lowlevel_init_c.c for >>> SMDK5250. >>> Lowlevel.S as of now added only for SMDK5250 and same can be >>> extended to other SOC in future. >>> >>> Signed-off-by: Rajeshwari Shinde >>> --- >>> Changes in V2: >>> - Renamed lowlevel_init.S to lowlevel.S and moved to >>> arch/arm/cpu/armv7/exynos/ >>> - Moved power mode defines to power.h >>> - Added early serial support. >>> - Renamed mem_reset to reset. >>> arch/arm/cpu/armv7/exynos/Makefile |6 ++ >>> arch/arm/cpu/armv7/exynos/lowlevel.S | 35 >>> arch/arm/include/asm/arch-exynos/power.h |8 ++ >>> board/samsung/smdk5250/Makefile |2 +- >>> board/samsung/smdk5250/dmc_common.c |4 +- >>> board/samsung/smdk5250/dmc_init_ddr3.c |6 +- >>> board/samsung/smdk5250/lowlevel_init.S | 96 >>> board/samsung/smdk5250/lowlevel_init.c | 81 + >>> board/samsung/smdk5250/setup.h | 19 - >>> board/samsung/smdk5250/spl_boot.c| 140 >>> +++-- >>> spl/Makefile |4 + >>> 11 files changed, 288 insertions(+), 113 deletions(-) >>> create mode 100644 arch/arm/cpu/armv7/exynos/lowlevel.S >>> delete mode 100644 board/samsung/smdk5250/lowlevel_init.S >>> create mode 100644 board/samsung/smdk5250/lowlevel_init.c >>> >>> diff --git a/arch/arm/cpu/armv7/exynos/Makefile >>> b/arch/arm/cpu/armv7/exynos/Makefile >>> index 9119961..2aa2722 100644 >>> --- a/arch/arm/cpu/armv7/exynos/Makefile >>> +++ b/arch/arm/cpu/armv7/exynos/Makefile >>> @@ -22,6 +22,12 @@ include $(TOPDIR)/config.mk >>> >>> LIB = $(obj)lib$(SOC).o >>> >>> +ifdef CONFIG_SMDK5250 >> >> Is it SMDK5250 specific? > - Yes, As mentioned in the commit message it is currently been done > only for SMDK5250 and can be also > extended to other SOC in Future. >> But I think, we don't have to get dependency with the board. Thanks. Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] please pull u-boot-samsung master
Hi Rajeshwari, On Mon, 14 Jan 2013 10:16:05 +0530, Rajeshwari Birje wrote: > Hi Albert, > > - VCMA9 is broken by commit a9d2ae7014d9e66dde6dd4a344308449508e4a22, > >> which causes the following build errors: > >> > >> In file included from s3c24x0_i2c.c:40:0: > >> s3c24x0_i2c.h:38:17: error: field 'id' has incomplete type > >> s3c24x0_i2c.c:70:39: error: 'CONFIG_MAX_I2C_NUM' undeclared here (not > >> in a function) s3c24x0_i2c.c:70:31: warning: 'i2c_bus' defined but > >> not used [-Wunused-variable] s3c24x0_i2c.c:72:12: warning: > >> 'i2c_busses' defined but not used [-Wunused-variable] > > I would resolve these errors sorry for inconvenience Thanks. > >> - smdk5250 is broken by commit f482310c6def17ba975a041077f89d984be54b68 > >> which causes the following build errors: > >> > >> sound.c: In function 'codec_init': > >> sound.c:151:4: warning: passing argument 1 of 'wm8994_init' discards > >> 'const' qualifier from pointer target type [enabled by default] In file > >> included from sound.c:33:0: wm8994.h:83:5: note: expected 'struct > >> sound_codec_info *' but argument is of type 'const void *' cmd_sound.c: > >> In function 'do_init': cmd_sound.c:36:2: error: too few arguments to > >> function 'sound_init' In file included from cmd_sound.c:27:0: > >> /home/albert/src/u-boot-arm/include/sound.h:52:5: note: declared here > > Sorry but I am not getting these errors could you please let me know > you your environment settings to get the same. For some reason -- possibly commits I took in later -- I cannot reproduce the smdk5250 errors above in current u-boot-arm/master. However it still fails with warnings, both in u-boot-samsung/master and when merged into u-boot-arm/master: exynos_dp.c: In function 'exynos_init_dp': exynos_dp.c:860:23: warning: variable 'disp_info' set but not used [-Wunused-but-set-variable] exynos_fb.c: In function 'draw_logo': exynos_fb.c:74:8: warning: variable 'addr' set but not used [-Wunused-but-set-variable] exynos_fb.c:73:9: warning: variable 'y' set but not used [-Wunused-but-set-variable] exynos_fb.c:73:6: warning: variable 'x' set but not used [-Wunused-but-set-variable] Tested with with both ELDK 5.3: gcc version 4.7.2, and the Linaro ARM GCC from Ubuntu (gcc version 4.7.2: Ubuntu/Linaro 4.7.2-1ubuntu1. > Regards, > Rajeshwari Shinde Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/4 V2] SMDK5250: Convert lowlevel_init.S to lowlevel_init.c
On 14/01/13 15:32, Rajeshwari Birje wrote: > Hi Minkyu Kang, > >> OK, but is this something you intend to fix, perhaps in a future >> series? It seems like you need separate directories sooner rather than >> later.I don't think this is board-specific code, but chip-specific. > > Please do let me know your opinion on the above comment. > > Regards, > Rajeshwari Shinde. > > On Fri, Jan 11, 2013 at 7:54 PM, Simon Glass wrote: >> Hi Rajeshwari, >> >> On Fri, Jan 11, 2013 at 2:43 AM, Rajeshwari Birje >> wrote: >>> Hi Simon, >>> >>> Thank you for comments. >>> >>> On Thu, Jan 10, 2013 at 11:04 PM, Simon Glass wrote: Hi Rajeshwari, On Mon, Jan 7, 2013 at 5:08 AM, Rajeshwari Shinde wrote: > This patch converts lowlevel_init.S to lowlevel_init_c.c for > SMDK5250. > Lowlevel.S as of now added only for SMDK5250 and same can be > extended to other SOC in future. Should perhaps also mention new feature (controllable memory reset for resume?) >>> -OK > > Signed-off-by: Rajeshwari Shinde > --- > Changes in V2: > - Renamed lowlevel_init.S to lowlevel.S and moved to > arch/arm/cpu/armv7/exynos/ > - Moved power mode defines to power.h > - Added early serial support. > - Renamed mem_reset to reset. > arch/arm/cpu/armv7/exynos/Makefile |6 ++ > arch/arm/cpu/armv7/exynos/lowlevel.S | 35 > arch/arm/include/asm/arch-exynos/power.h |8 ++ > board/samsung/smdk5250/Makefile |2 +- > board/samsung/smdk5250/dmc_common.c |4 +- > board/samsung/smdk5250/dmc_init_ddr3.c |6 +- > board/samsung/smdk5250/lowlevel_init.S | 96 > board/samsung/smdk5250/lowlevel_init.c | 81 + Any change we could move all of this to arch/arm/cpu/armv7/exynos...? >>> We do not have a separate directory for exynos5 and exynos4 and if we >>> add all these files in arch/arm/cpu/armv7/exynos it would break the >>> compilation for EXYNOS4. Also Later versions of exynos5 have different >>> memory and timing variants. >> >> OK, but is this something you intend to fix, perhaps in a future >> series? It seems like you need separate directories sooner rather than >> later.I don't think this is board-specific code, but chip-specific. >> We don't have to separate directory for exynos5 and exynos4. We can check this by cpu_is_exynos5 or cpu_is_exynos4. I think each SoCs have different memory and timing but the logic can be same. If so we can move all of changes to SoC directory. -- Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4 V2] SMDK5250: Convert lowlevel_init.S to .c and set PMIC values
Hi Rajeshwari, On Mon, 07 Jan 2013 18:38:42 +0530, Rajeshwari Shinde wrote: > This patch converts lowlevel_init.S to lowlevel_init_c.c. > Add PMIC MAX77686 voltage settings for SMDK5250. > > Changes in V2: > - Added early serial support. > - Moved patch 2 containing power apis to patch 1 due to dependency > - moved lowlevel_init.S to arch/arm/cpu/armv7/exynos and > renamed as lowlevel.S > - Moved power mode #defines to power.h > - added error check for PMIC voltage settings. > > Rajeshwari Shinde (4): > EXYNOS: Add functions for power initialisation > SMDK5250: Convert lowlevel_init.S to lowlevel_init.c > SMDK5250: Add PMIC voltage settings > SMDK5250: Modify IRAM stack pointer address > > arch/arm/cpu/armv7/exynos/Makefile |6 ++ > arch/arm/cpu/armv7/exynos/lowlevel.S | 35 > arch/arm/cpu/armv7/exynos/power.c| 27 ++ > arch/arm/include/asm/arch-exynos/power.h | 18 > board/samsung/smdk5250/Makefile |2 +- > board/samsung/smdk5250/dmc_common.c |4 +- > board/samsung/smdk5250/dmc_init_ddr3.c |6 +- > board/samsung/smdk5250/lowlevel_init.S | 96 > board/samsung/smdk5250/lowlevel_init.c | 81 + > board/samsung/smdk5250/setup.h | 19 - > board/samsung/smdk5250/smdk5250.c| 110 +++- > board/samsung/smdk5250/spl_boot.c| 140 +++-- > include/configs/exynos5250-dt.h | 11 ++- > include/power/max77686_pmic.h| 30 +++ > spl/Makefile |4 + > 15 files changed, 471 insertions(+), 118 deletions(-) > create mode 100644 arch/arm/cpu/armv7/exynos/lowlevel.S > delete mode 100644 board/samsung/smdk5250/lowlevel_init.S > create mode 100644 board/samsung/smdk5250/lowlevel_init.c > > -- > 1.7.4.4 Sorry for only chiming in at V2 stage, but... lowlevel_init is supposed to be the earliest code run ever, and is supposed to set up the environment for possibly, later, setting up a C environment. So what exactly sets up the C environment *for* lowlevel_init to be able to run in C? Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
