DO NOT REPLY [Bug 16160] New: - Upload problem: Stream ended unexpectedly

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16160

Upload problem: Stream ended unexpectedly

   Summary: Upload problem: Stream ended unexpectedly
   Product: Tomcat 4
   Version: 4.1.12
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Connector:Coyote JK 2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


We are using IIS server in front of a Tomcat4(Apache Tomcat/4.1.12-LE-jdk14)
server using the JK connector. We have a problem with uploads which fail with a
"Stream ended unexpectedly" (the upload package is jakarta commons fileupload
provided with struts1.1b).
The upload works fine when accessing tomcat directly.
Not sure if the following exception has anything to with this problem but I am
providing it here:

Jan 15, 2003 8:55:35 AM org.apache.jk.common.HandlerRequest invoke
SEVERE: Error decoding request 
java.lang.NumberFormatException
at org.apache.tomcat.util.buf.Ascii.parseInt(Ascii.java:195)
at org.apache.tomcat.util.buf.ByteChunk.getInt(ByteChunk.java:439)
at org.apache.tomcat.util.buf.MessageBytes.getInt(MessageBytes.java:629)
at org.apache.jk.common.HandlerRequest.decodeHeaders(HandlerRequest.java:628)
at org.apache.jk.common.HandlerRequest.decodeRequest(HandlerRequest.java:446)
at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:344)
at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:563)
at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:535)
at org.apache.jk.common.SocketConnection.runIt(ChannelSocket.java:638)
at
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:533)
at java.lang.Thread.run(Thread.java:536)


The exception we get when uploading is:

javax.servlet.ServletException: Processing of multipart/form-data request
failed. Stream ended unexpectedly
at
org.apache.struts.upload.CommonsMultipartRequestHandler.handleRequest(CommonsMultipartRequestHandler.java:245)
at org.apache.struts.util.RequestUtils.populate(RequestUtils.java:934)
at
org.apache.struts.action.RequestProcessor.processPopulate(RequestProcessor.java:779)
at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:246)
at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1292)
at org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:510)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:760)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:247)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
at com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(Unknown Source)
at com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(Unknown Source)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:213)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:260)
at
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
at org.apache.catalina.core.StandardContext.invoke(StandardContext.java:2396)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:180)
at
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
at
org.apache.catalina.valves.ErrorDispatcherValve.invoke(ErrorDispatcherValve.java:170)
at
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:641)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:172)
at
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:641)
at org.apache.catalina.core.StandardPipeline.invoke

DO NOT REPLY [Bug 16146] - POST request with invalid Content-Length header

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16146

POST request with invalid Content-Length header

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 08:21 ---
If the client sends a bogus value, then it's the client problem. I will not put
hacks and workarounds because IE is broken. Of course, you are free to patch
your own Tomcat installation to do whatever you want.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16152] - problems using new versions

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16152

problems using new versions

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Blocker |Major
 Status|NEW |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 08:26 ---
Sorry, but there is nothing reproduceable in this bug report. I didn't hear
about problems with JDOM. You should investigate more, maybe post on
tomcat-user, and try to give more precise bug report (like exactly what is not
working, and how to reproduce the problem).

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16114] - autoFlush on jsp is not DONE.

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16114

autoFlush on jsp is not DONE.

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Critical|Blocker
Summary|custom tag output is not|autoFlush on jsp is not
   |flushed then not writed to  |DONE.
   |jsp output  |



--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 09:26 ---
I have made some tests with Tomcat and I have found that, the problem is not
what I had said. It is different. Sorry for this :(

The problem is a very simple one. 
When a Jsp finishes its execution it does not flush its output. On JSP 1.2
specification, autoFlush (attribute of the page directive) is true by default,
then flush should be done automatically.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Problem with JSTL on W2k

2003-01-16 Thread Holger Brozio
Hello,

i have a problem with the JSTL on W2k. If i start tomcat i get the follwoing
exception:

javax.servlet.ServletException: Exception processing JAR at resource path
/WEB-INF/lib/jaxen-full.jar
 at
org.apache.catalina.startup.ContextConfig.tldScanJar(ContextConfig.java:930)
 at
org.apache.catalina.startup.ContextConfig.tldScan(ContextConfig.java:868)
 at org.apache.catalina.startup.ContextConfig.start(ContextConfig.java:647)
 at
org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:
243)
 at
org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSuppor
t.java:166)
 at
org.apache.catalina.core.StandardContext.start(StandardContext.java:3493)
 at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1188)
 at org.apache.catalina.core.StandardHost.start(StandardHost.java:738)
 at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1188)
 at org.apache.catalina.core.StandardEngine.start(StandardEngine.java:347)
 at org.apache.catalina.startup.Embedded.start(Embedded.java:994)
 at
com.intershop.beehive.core.internal.startup.EmbeddedTomcatMgr.startTomcat(Em
beddedTomcatMgr.java:393)
 at
com.intershop.beehive.core.internal.startup.EmbeddedTomcatMgr.onReadyHook(Em
beddedTomcatMgr.java:333)
 at
com.intershop.beehive.core.internal.startup.AdminServer.start(AdminServer.ja
va:70)
 at
com.intershop.beehive.core.internal.startup.AdminServer.main(AdminServer.jav
a:264)

I have debugged the ContextConfig class and found out, that an exception is
thrown at the line 930, which has "Access is denied" as description. It
seems that tomcat tries to open an URLConnection with the url
"jndi:/ /WEB-INF/lib/jaxen-full.jar!/".
My user on W2k is a normal user. If i add the user to the administrators or
power user group, there are no problems. I have also tried
to change the file permissions of the jar file without an effect.
So it seems to be a permission problem. Does anybody know, which permission
on W2k is missing for my user or group, which doesn't allow a normal user to
get the jar informations?

Thanx in advance.

Holger


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 10544] - crossContext for servlets not working

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10544

crossContext for servlets not working





--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 12:15 ---
Created an attachment (id=4462)
This a suggestion to fix Bug 10544

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 10544] - crossContext for servlets not working

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10544

crossContext for servlets not working





--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 12:17 ---
Hello,

I found the bug:
src/share/org/apache/catalina/core/ApplicationContext.java line 445 (in tomcat 
4.1.18):
if ((contextPath.length() > 0) && (uri.startsWith(contextPath))) {
return (this);
}
since the root context is "/" every uri starts with the contextPath and hence 
the root context is returned again.
To fix it the 0 has to be replaced with 1.
I attached a patch.

Christian

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16165] New: - Problems with response.setHeader after chain.doFilter

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16165

Problems with response.setHeader after chain.doFilter

   Summary: Problems with response.setHeader after chain.doFilter
   Product: Tomcat 4
   Version: 4.0.6 Final
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Servlet & JSP API
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I have problems using setHeader after calling doFilter in a ServletFilter with 
Response-Wrapper:

public void doFilter(ServletRequest request, ServletResponse response, 
FilterChain chain ) throws IOException, ServletException {
HttpServletRequest hreq=(HttpServletRequest)request;
HttpServletResponse hres=(HttpServletResponse)response;

LocalResponseWrapper lrw=new LocalResponseWrapper(hres);
PrintWriter w=response.getWriter();
hres.setHeader("1","1");
chain.doFilter(hreq,lrw);
hres.setHeader("2","2");
String result=lrw.toString();
w.println(result);
w.close();  
}
Header "1" will be set, header "2" not...
With tomcat 4.1.18 this works. Is this a bug or a feature???

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 10026] - manager/stop and manager/remove

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10026

manager/stop and manager/remove





--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 12:54 ---
Tomcat: 4.1.18/4.1.19
JDK: 1.4.1
System: W2K SP3

I can reproduce this bug on 4.1.18 and 4.1.19 (also with other applications 
using struts.jar), but it seems rather related to Struts itself since removal 
of any other webapps works fine for me.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16165] - Problems with response.setHeader after chain.doFilter

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16165

Problems with response.setHeader after chain.doFilter





--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 13:04 ---
Addition:

I have that problem only when I want to access a JSP through the filter. When I 
access a static wml/html page it works...

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 10026] - manager/stop and manager/remove

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10026

manager/stop and manager/remove

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 13:21 ---
I will mark this bug as invalid for Tomcat then.  Please work with the
struts team to resolve it.  Thanks for checking.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 10026] - manager/stop and manager/remove

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10026

manager/stop and manager/remove

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 12643] - Undeploy an Existing Application in the Manager App fails

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12643

Undeploy an Existing Application in the Manager App fails





--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 13:38 ---
Are there any stacktraces in the logs?  

Does this application use struts?

Was the application installed using /manager/deploy?  

Does this still fail with the latest Tomcat 4.1.19 release?  

Please provide more information.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 13588] - tld does not update when redeployed through manager

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13588

tld does not update when redeployed through manager





--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 13:42 ---
Please test to see if you still have the problem using Tomcat 4.1.19.
If you do, please provide an example war and more detailed information
on how to reproduce the bug. What OS are you using, what JVM version?

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 12643] - Undeploy an Existing Application in the Manager App fails

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12643

Undeploy an Existing Application in the Manager App fails





--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 13:44 ---
Personally, I recommend resolving that kind of report with a WORKSFORME (no test
case, and no instructions on how to reproduce).
At least before your change, you can't undeploy an application which wasn't
deployed with the manager.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 10544] - crossContext for servlets not working

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10544

crossContext for servlets not working

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 13:57 ---


*** This bug has been marked as a duplicate of 13040 ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 13040] - can't retrieve external context who's uri is a sub-dir of current context

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13040

can't retrieve external context who's uri is a sub-dir of current context

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 13:57 ---
*** Bug 10544 has been marked as a duplicate of this bug. ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16127] - Seems to be a problem doing a static include of content when using a different charset.

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16127

Seems to be a problem doing a static include of content when using a different charset.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 14:17 ---
It seems I misunderstood the bug report.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 15845] - 4.1.19 Memory Leak when creating compilier for JSP pages

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15845

4.1.19 Memory Leak when creating compilier for JSP pages

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |
Summary|Memory Leak when compiling  |4.1.19 Memory Leak when
   |JSP |creating compilier for JSP
   ||pages
Version|4.1.14  |4.1.19



--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 15:24 ---
there is still a memory leak in 4.1.19

it is not the compile itself that causes the leak, but the 
JspCompilationContext being stored with is compilier indefinatly.  

I have tracked to down somewhat if you read below there is a way to fix it, but 
not sure of the side effects it might have.  the culprit seems to be the code 
that checks all the includes to see if they have changed.  it appears to hold 
on the the jspcompilationcontext in a map, and never gets rid of the map so the 
more jsp pages you compile the bigger that map gets and the more memory that is 
taken up.

please someone take a serious look at this.  I know some of you think the 
solution is to precomile every thing, but that is not always posible.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16001] - Tag.release() not invoked

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16001

Tag.release() not invoked





--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 16:13 ---
Created an attachment (id=4464)
A war containing an example of the scenario in which the bug is exposed

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16171] New: - release() on TagHandlerPool.reuse() not called

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16171

release() on TagHandlerPool.reuse() not called

   Summary: release() on TagHandlerPool.reuse() not called
   Product: Tomcat 4
   Version: 4.1.18
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The release() method is only called, if the maximum number of tags in the pool 
is reached. If the Tag is returned to the pool by calling reuse() the release() 
method is not called. This should be done, since release() is necessary to 
reset the tag.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16001] - Tag.release() not invoked

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16001

Tag.release() not invoked

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 16:25 ---
I think that Tag.release is not invoked between two uses of the same tag, now
that it is extracted from the pool.

If the tag store a value in an internal variable, depending on a required
attribute, you'll find the previuos value in the next use even if you set it to
null in release.

I don't know if the life-cycle model of custom tags is changed in last
specifications, but I expect to have a clean instance of the object every time I
use it, especially if I've implemented release.

I've posted an attachment containing a small war with a simple tag and a page of
example. Try it.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16001] - Tag.release() not invoked

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16001

Tag.release() not invoked





--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 16:42 ---
You cannot put it to null. You have to make a call to removeValue(). Really you
SHOULD NOT do this, because we think that has to be done automatically :P

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16001] - Tag.release() not invoked

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16001

Tag.release() not invoked

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 16:55 ---

Lets see if I can get through to you guys, Jan Luehe's fine post was 
apparently not enough.

>From the Tag.release() javadoc:
"...there may be multiple invocations on doStartTag and doEndTag in between."

This is plain english and means that on the same page the tag can be taken out 
of the pool, and then used several times _WITHOUT_ .release() being called in 
between AND THIS IS NOT A BUG. Ergo, Tag.release can NOT be used for resetting 
states between uses of tags.

If you need to reset your internal values that SHOULD be done in doEndTag for 
instance.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 10047] - IllegalStateException and Browser "back" button

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10047

IllegalStateException and Browser "back" button

[EMAIL PROTECTED] changed:

   What|Removed |Added

 OS/Version|Linux   |All
   Priority|Other   |High

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16001] - Tag.release() not invoked

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16001

Tag.release() not invoked

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |



--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 17:23 ---
I think that from a progammers view :

The programmers should not care about how internal things are done. That is, if
tomcat uses pools of objects for performance improvements or any other approach,
programmer should not care about it, it should only use a tag and if later it is
reused, asume a initial state.



Should not be this the right approach as done on other servers ?

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16001] - Tag.release() not invoked

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16001

Tag.release() not invoked





--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 17:41 ---

As with any API, the programmer is supposed to understand how it works. I 
didn't write the spec, but it is pretty obvious to me that it is working as 
intended.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




[Q] Where was vulnerability fixed?

2003-01-16 Thread Sam
http://online.securityfocus.com/archive/1/302169/2002-12-03/2002-12-09/2

This vulnerability was reported last month.  The report
says mod_jk 1.2.1 as fixing the vulnerability.
Yet I have searched Bugzilla for reference to this vuln.
as well as looking at mod_jk.c to see what revision was
changed, but I have not been able to locate this change.

Can anyone shed some light as to whether this vuln. was fixed
or not, and if so, and what source file(s) were changed?  
I cannot seem to find it.

Thanks,
Sam


__
Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
http://mailplus.yahoo.com

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16171] - release() on TagHandlerPool.reuse() not called

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16171

release() on TagHandlerPool.reuse() not called

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 18:21 ---


*** This bug has been marked as a duplicate of 16001 ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16001] - Tag.release() not invoked

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16001

Tag.release() not invoked

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 18:21 ---
*** Bug 16171 has been marked as a duplicate of this bug. ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16178] New: - Unix process does not get killed when Tomcat is shutdown

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16178

Unix process does not get killed when Tomcat is shutdown

   Summary: Unix process does not get killed when Tomcat is shutdown
   Product: Tomcat 4
   Version: 4.1.18
  Platform: Sun
OS/Version: Solaris
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I bring up Tomcat 4.1 with the startup.sh script.  Both the $CATALINA_HOME and 
$JAVA_HOME are set correctly.  When I run the shutdown.sh script, I do not get 
any errors, the catalina.out and localhost output looks normal, but, the Unix 
process is still running.  I have to run the "kill" command to kill the 
process.  When I was running Tomcat 3.2 I did not have to do this.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-catalina/catalina build.xml

2003-01-16 Thread costin
costin  2003/01/16 12:58:24

  Modified:catalina build.xml
  Log:
  Split the build in 2 parts. One is "required", with no external dependencies
  ( except JAAS and JMX ).
  
  Also added fileupload check - probably it needs to be added to download too.
  
  Revision  ChangesPath
  1.36  +47 -9 jakarta-tomcat-catalina/catalina/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/build.xml,v
  retrieving revision 1.35
  retrieving revision 1.36
  diff -u -r1.35 -r1.36
  --- build.xml 15 Jan 2003 03:40:42 -  1.35
  +++ build.xml 16 Jan 2003 20:58:24 -  1.36
  @@ -601,7 +601,51 @@
   
   
 
  -  
  +  
  +
  +  
  +
  +
  +  
  +
  +  
  +  
  +  
  +
  +  
  +  
  +  
  +  
  +  
  +  
  +  
  +  
  +  
  +
  +
  +
  +
  +
  +  
  +
  +
  +  
  +
  +
  +  
  +
  +  
  +
  +
  +  
  +
  +  
   
   
 
  -  
  +  
 
 
  -  
  -  
 
 
 
   
  -
 
  -
   
 
 
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/jk/native build.xml

2003-01-16 Thread mmanders
mmanders2003/01/16 13:00:57

  Modified:jk/native build.xml
  Log:
  Removed netware exclusion on _REENTRANT define for NetWare.  LibC now provides 
necessary functionality and this allows us to run MP.
  
  Revision  ChangesPath
  1.36  +5 -5  jakarta-tomcat-connectors/jk/native/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/build.xml,v
  retrieving revision 1.35
  retrieving revision 1.36
  diff -u -r1.35 -r1.36
  --- build.xml 12 Jun 2002 15:30:01 -  1.35
  +++ build.xml 16 Jan 2003 21:00:57 -  1.36
  @@ -107,7 +107,7 @@
 
 
 
  -  
  +  
 
 
 
  @@ -132,7 +132,7 @@
debug="${so.debug}"
taskDebug="0"
profile="${so.profile}" >
  -  
  +  
 
 
 
 
  -  
  +  
 
 
 
  @@ -283,7 +283,7 @@
 
 
 
  -  
  +  
 
 
 
  @@ -417,7 +417,7 @@
 
 
 
  -  
  +  
 
 
 
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16181] New: - JspWriter not restored properly when exception thrown in a tag's body content

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16181

JspWriter not restored properly when exception thrown in a tag's body content

   Summary: JspWriter not restored properly when exception thrown in
a tag's body content
   Product: Tomcat 4
   Version: 4.1.18
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Jasper 2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


If an exception is thrown in the body content of a tag,
and this tag is wrapped around a , the 
JspWriter is not properly restored with Jasper2
(with our without pooling enabled).

The example below fails to output properly anything sent to the
JspWriter after the exception is thrown. 
Tested with tomcat 4.1.18 and JSTL 1.0.3 (currently the nightly
of 'standard' at jakarta-taglibs).

-
<%@ taglib prefix="c" uri="http://java.sun.com/jstl/core"; %>

<%!
   public String throwEx() throws Exception {
  throw new java.lang.Exception("exception thrown by throwEx");  
   }
%>

begin


  
<% throwEx(); %>
  



end

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2003-01-16 Thread costin
costin  2003/01/16 13:38:25

  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
  Log:
  - remove unused imports
  
  - converted to commons-logging
  
  - Implement the JSR77 "servlets" attribute ( required for WebModule )
  
  - Use JSR77 name for the context.
  
  The old name is still available, until someone updates the admin
  to use the new name.
  
  Note that the last 2 components of the name default to "none",
  if tomcat is run inside a J2EEserver, the integration code will need
  to set the name of the server and the name of the application for the
  context.
  
  Revision  ChangesPath
  1.13  +65 -29
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
  
  Index: StandardContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- StandardContext.java  8 Dec 2002 13:42:09 -   1.12
  +++ StandardContext.java  16 Jan 2003 21:38:25 -  1.13
  @@ -69,48 +69,30 @@
   import java.io.IOException;
   import java.util.ArrayList;
   import java.util.HashMap;
  -import java.net.URL;
   import java.util.Iterator;
   import java.util.TreeMap;
   import java.util.Hashtable;
   import java.util.Stack;
  -import java.util.Enumeration;
  -import java.util.StringTokenizer;
   import javax.servlet.FilterConfig;
   import javax.servlet.ServletContext;
   import javax.servlet.ServletContextEvent;
   import javax.servlet.ServletContextListener;
   import javax.servlet.ServletException;
   import javax.servlet.ServletRequestListener;
  -import javax.servlet.http.HttpServletRequest;
  -import javax.servlet.http.HttpServletResponse;
   import javax.naming.NamingException;
  -import javax.naming.InitialContext;
  -import javax.naming.Reference;
  -import javax.naming.StringRefAddr;
  -import javax.naming.NamingEnumeration;
  -import javax.naming.Binding;
  -import javax.naming.StringRefAddr;
   import javax.naming.directory.DirContext;
  -import org.apache.naming.NamingContext;
  +import javax.management.ObjectName;
   import org.apache.naming.ContextBindings;
  -import org.apache.naming.ContextAccessController;
  -import org.apache.naming.EjbRef;
  -import org.apache.naming.ResourceRef;
  -import org.apache.naming.ResourceEnvRef;
  -import org.apache.naming.TransactionRef;
   import org.apache.naming.resources.BaseDirContext;
   import org.apache.naming.resources.FileDirContext;
   import org.apache.naming.resources.ProxyDirContext;
   import org.apache.naming.resources.WARDirContext;
   import org.apache.naming.resources.DirContextURLStreamHandler;
  -import org.apache.catalina.Cluster;
   import org.apache.catalina.Container;
   import org.apache.catalina.ContainerListener;
   import org.apache.catalina.Context;
   import org.apache.catalina.Host;
   import org.apache.catalina.Globals;
  -import org.apache.catalina.HttpRequest;
   import org.apache.catalina.InstanceListener;
   import org.apache.catalina.Lifecycle;
   import org.apache.catalina.LifecycleEvent;
  @@ -139,7 +121,6 @@
   import org.apache.catalina.deploy.ResourceParams;
   import org.apache.catalina.deploy.SecurityCollection;
   import org.apache.catalina.deploy.SecurityConstraint;
  -import org.apache.catalina.loader.StandardClassLoader;
   import org.apache.catalina.loader.WebappLoader;
   import org.apache.catalina.session.StandardManager;
   import org.apache.catalina.util.CharsetMapper;
  @@ -147,6 +128,9 @@
   import org.apache.catalina.util.RequestUtil;
   
   import org.apache.tomcat.util.log.SystemLogHandler;
  +import org.apache.commons.modeler.Registry;
  +import org.apache.commons.logging.Log;
  +import org.apache.commons.logging.LogFactory;
   
   /**
* Standard implementation of the Context interface.  Each
  @@ -160,7 +144,10 @@
   
   public class StandardContext
   extends ContainerBase
  -implements Context {
  +implements Context
  + {
  +private static Log log = LogFactory.getLog(StandardContext.class);
  +
   
   
   // --- Constructors
  @@ -512,6 +499,7 @@
*/
   private DirContext webappResources = null;
   
  +private ArrayList wrappers=new ArrayList();
   
   // - Context Properties
   
  @@ -874,7 +862,7 @@
   String loginPage = config.getLoginPage();
   if ((loginPage != null) && !loginPage.startsWith("/")) {
   if (isServlet22()) {
  -log(sm.getString("standardContext.loginConfig.loginWarning",
  +log.info(sm.getString("standardContext.loginConfig.loginWarning",
loginPage));
   config.setLoginPage("/" + loginPage);

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java

2003-01-16 Thread costin
costin  2003/01/16 13:41:45

  Modified:catalina/src/share/org/apache/catalina/core
StandardWrapper.java
  Log:
  The servlet wrapper will register itself using the JSR77 name.
  The app and server name are taken from the context.
  
  The load time, processing time and other nice data is exposed via JMX
   (collected in the valve - to not affect the performance ).
  
  Revision  ChangesPath
  1.11  +72 -15
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
  
  Index: StandardWrapper.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- StandardWrapper.java  8 Dec 2002 13:42:09 -   1.10
  +++ StandardWrapper.java  16 Jan 2003 21:41:45 -  1.11
  @@ -90,6 +90,7 @@
   import org.apache.catalina.util.Enumerator;
   import org.apache.catalina.util.InstanceSupport;
   import org.apache.tomcat.util.log.SystemLogHandler;
  +import org.apache.commons.modeler.Registry;
   /**
* Standard implementation of the Wrapper interface that represents
* an individual servlet definition.  No child Containers are allowed, and
  @@ -115,7 +116,8 @@
   public StandardWrapper() {
   
   super();
  -pipeline.setBasic(new StandardWrapperValve());
  +swValve=new StandardWrapperValve();
  +pipeline.setBasic(swValve);
   
   }
   
  @@ -246,6 +248,10 @@
*/
   private boolean swallowOutput = false;
   
  +// To support jmx attributes
  +private StandardWrapperValve swValve;
  +private long loadTime=0;
  +
   // - Properties
   
   
  @@ -867,11 +873,6 @@
   // Special case class loader for a container provided servlet
   if (isContainerProvidedServlet(actualClass)) {
   classLoader = this.getClass().getClassLoader();
  -long t2=System.currentTimeMillis();
  -if( t2-t1 > 200 )
  -log.info(sm.getString
  - ("standardWrapper.containerServlet", getName()) +
  - " " + (t2 - t1 ));
   }
   
   // Load the specified servlet class from the appropriate class loader
  @@ -993,10 +994,8 @@
   instancePool = new Stack();
   }
   fireContainerEvent("load", this);
  -if( System.currentTimeMillis() -t1 > 200 ) {
  -log.info("Loaded servlet  " + actualClass + " " +
  - (System.currentTimeMillis() - t1 ) );
  -}
  +
  +loadTime=System.currentTimeMillis() -t1;
   } finally {
   if (swallowOutput) {
   String log = SystemLogHandler.stopCapture();
  @@ -1009,6 +1008,7 @@
   }
   }
   }
  +registerJMX((ContainerBase)getParent(), this);
   return servlet;
   
   }
  @@ -1274,7 +1274,45 @@
   
   }
   
  +public long getProcessingTime() {
  +return swValve.getProcessingTime();
  +}
  +
  +public void setProcessingTime(long processingTime) {
  +swValve.setProcessingTime(processingTime);
  +}
  +
  +public long getMaxTime() {
  +return swValve.getMaxTime();
  +}
  +
  +public void setMaxTime(long maxTime) {
  +swValve.setMaxTime(maxTime);
  +}
  +
  +public int getRequestCount() {
  +return swValve.getRequestCount();
  +}
   
  +public void setRequestCount(int requestCount) {
  +swValve.setRequestCount(requestCount);
  +}
  +
  +public int getErrorCount() {
  +return swValve.getErrorCount();
  +}
  +
  +public void setErrorCount(int errorCount) {
  +   swValve.setErrorCount(errorCount);
  +}
  +
  +public long getLoadTime() {
  +return loadTime;
  +}
  +
  +public void setLoadTime(long loadTime) {
  +this.loadTime = loadTime;
  +}
   //  Package Methods
   
   
  @@ -1400,5 +1438,24 @@
   
   }
   
  -
  +void registerJMX(ContainerBase ctx, StandardWrapper wrapper) {
  +try {
  +String name=wrapper.getJspFile();
  +if( name==null ) {
  +name=wrapper.getServletName();
  +}
  +// it should be full name
  +String parentName=ctx.getName();
  +String hostName=ctx.getParent().getName();
  +String webMod=((hostName==null)? "DEFAULT" :hostName ) +
  +(("".equals(parentName) ) ? "/" : parentName );
  +String oname="j2eeType=Servlet,name=" + name + ",WebModule=" +
  + 

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup ContextConfig.java

2003-01-16 Thread costin
costin  2003/01/16 13:44:18

  Modified:catalina/src/share/org/apache/catalina/startup
ContextConfig.java
  Log:
  Better messages ( I hope )
  
  Revision  ChangesPath
  1.17  +10 -13
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java
  
  Index: ContextConfig.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- ContextConfig.java29 Oct 2002 08:21:29 -  1.16
  +++ ContextConfig.java16 Jan 2003 21:44:17 -  1.17
  @@ -1,7 +1,4 @@
   /*
  - * $Header$
  - * $Revision$
  - * $Date$
*
* 
*
  @@ -413,7 +410,8 @@
   Pipeline pipeline = ((ContainerBase) context).getPipeline();
   if (pipeline != null) {
   ((ContainerBase) context).addValve(authenticator);
  -log.info(sm.getString("contextConfig.authenticatorConfigured",
  +if( log.isDebugEnabled() )
  +
log.debug(sm.getString("contextConfig.authenticatorConfigured",
loginConfig.getAuthMethod()));
   }
   }
  @@ -491,6 +489,7 @@
   ((ContainerBase) context).addValve(certificates);
   log.error(sm.getString
   ("contextConfig.certificatesConfig.added"));
  +
   }
   }
   } catch (Throwable t) {
  @@ -565,7 +564,6 @@
* web application deployment descriptor (web.xml).
*/
   private static Digester createWebDigester() {
  -long t1=System.currentTimeMillis();
   URL url = null;
   Digester webDigester = new Digester();
   webDigester.setNamespaceAware(xmlNamespaceAware);
  @@ -594,8 +592,6 @@
   
   webDigester.setEntityResolver(webEntityResolver);
   webDigester.addRuleSet(new WebRuleSet());
  -long t2=System.currentTimeMillis();
  -//log.info("Create web digester " + ( t2-t1));
   return (webDigester);
   }
   
  @@ -1071,14 +1067,15 @@
   // FIXME - Closing the JAR file messes up the class loader???
   //jarFile.close();
   } catch (Exception e) {
  +// XXX Why do we wrap it ? The signature is 'throws Exception'
   if (name == null) {
   throw new ServletException
   (sm.getString("contextConfig.tldJarException",
  -  resourcePath), e);
  +  resourcePath, context.getPath()), e);
   } else {
   throw new ServletException
   (sm.getString("contextConfig.tldEntryException",
  -  name, resourcePath), e);
  +  name, resourcePath, context.getPath()), e);
   }
   } finally {
   if (inputStream != null) {
  @@ -1156,9 +1153,9 @@
   inputStream.close();
   inputStream = null;
   } catch (Exception e) {
  -throw new ServletException
  -(sm.getString("contextConfig.tldFileException", resourcePath),
  - e);
  + throw new ServletException
  + (sm.getString("contextConfig.tldFileException", resourcePath, 
context.getPath()),
  +  e);
   } finally {
   if (inputStream != null) {
   try {
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup LocalStrings.properties

2003-01-16 Thread costin
costin  2003/01/16 13:45:25

  Modified:catalina/src/share/org/apache/catalina/startup
LocalStrings.properties
  Log:
  Part 2 of messages change.
  
  If the tld can't be read, it helps to know what context has the problem.
  
  Revision  ChangesPath
  1.3   +3 -3  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/LocalStrings.properties
  
  Index: LocalStrings.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/LocalStrings.properties,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- LocalStrings.properties   15 Jan 2003 03:40:43 -  1.2
  +++ LocalStrings.properties   16 Jan 2003 21:45:25 -  1.3
  @@ -22,9 +22,9 @@
   contextConfig.role.runas=WARNING: Security role name {0} used in a  without 
being defined in a 
   contextConfig.start=ContextConfig: Processing START
   contextConfig.stop=ContextConfig: Processing STOP
  -contextConfig.tldEntryException=Exception processing TLD {0} in JAR at resource 
path {1}
  -contextConfig.tldFileException=Exception processing TLD at resource path {0}
  -contextConfig.tldJarException=Exception processing JAR at resource path {0}
  +contextConfig.tldEntryException=Exception processing TLD {0} in JAR at resource 
path {1} in context {2}
  +contextConfig.tldFileException=Exception processing TLD at resource path {0} in 
context {1}
  +contextConfig.tldJarException=Exception processing JAR at resource path {0} in 
context {1}
   contextConfig.tldResourcePath=Invalid TLD resource path {0}
   contextConfig.unavailable=Marking this application unavailable due to previous 
error(s)
   embedded.alreadyStarted=Embedded service has already been started
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 12387] - JSP Compilation errors: jars in WEB-INF/lib and classes in WEB-INF/classes not in classpath

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12387

JSP Compilation errors: jars in WEB-INF/lib and classes in WEB-INF/classes not in 
classpath

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |
Version|4.1.10  |4.1.12



--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 21:48 ---
Hi.

I've found this problem (the way Martin has described) on 4.1.12 from the exe
distribution on W2K wihtout any Service Pack.
I share he's thought about the offending slash and I also  think i've found the
place in the code where it happens and how to correct it.

Looking deeply inside the code (I am not going to walk thru the full path of
code evaluation I did but I'll go straight to the point) it looks that the
method getServletJavaFileName() of the class
org.apache.jasper.JspCompilationContext is intended primary for achieving
physical file system path names and not virtual site names. The problem shows on
line 333 and line 338 of source file for that class where it checks for leading
slashes (hard-coded), where I understand it should be checking for
system-dependent separator (File.separator).

My guess is that replacing the following lines:

333:if( outputDir.endsWith("/" ) ) {

338:servletJavaFileName = outputDir + "/" + servletJavaFileName;

with:

333:if( outputDir.endsWith("/" ) || outputDir.endWith(
File.separator ) ) {

338:servletJavaFileName = outputDir + File.separator +
servletJavaFileName;

should solve the problem.

Unfortunly I tried to recompile Tomcat after this changes using the scripts set
provided with source code but I couldn't. So I'm posting this here to see if
someone that agrees with me on this can made those changes and recompile so we
can test them and see if they really solve the problem.

Thanks and hope it helps.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 12387] - JSP Compilation errors: jars in WEB-INF/lib and classes in WEB-INF/classes not in classpath

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12387

JSP Compilation errors: jars in WEB-INF/lib and classes in WEB-INF/classes not in 
classpath

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-01-16 21:56 ---
Please, please, do not attempt to fix that bug, since it is not a bug. Instead,
upgrade to a newer Tomcat release. I'll revert to the original resolution.
Please do not reopen the bug.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote RequestProcessor.java Request.java Response.java

2003-01-16 Thread costin
costin  2003/01/16 13:56:02

  Modified:coyote/src/java/org/apache/coyote Request.java Response.java
  Added:   coyote/src/java/org/apache/coyote RequestProcessor.java
  Log:
  Collect data about incoming/outgoing traffic, other per/request statistics.
  
  To avoid sync and keep things simple - we collect them in RequestProcessor,
  a per/thread structure.
  
  Revision  ChangesPath
  1.16  +24 -4 
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Request.java
  
  Index: Request.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Request.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- Request.java  19 Sep 2002 06:39:43 -  1.15
  +++ Request.java  16 Jan 2003 21:56:02 -  1.16
  @@ -61,7 +61,6 @@
   package org.apache.coyote;
   
   import java.io.IOException;
  -import java.util.Enumeration;
   import java.util.Hashtable;
   
   import org.apache.tomcat.util.buf.ByteChunk;
  @@ -172,7 +171,8 @@
*/
   private int contentLength = -1;
   // how much body we still have to read.
  -private int available = -1; 
  +// Apparently nobody uses this field...
  +private int available = -1;
   private MessageBytes contentTypeMB = null;
   private String charEncoding = null;
   private Cookies cookies = new Cookies(headers);
  @@ -184,6 +184,10 @@
   
   private Response response;
   private ActionHook hook;
  +
  +private int bytesRead=0;
  +
  +private RequestProcessor reqProcessorMX=new RequestProcessor(this);
   // - Properties
   
   
  @@ -429,8 +433,10 @@
   public int doRead(ByteChunk chunk) 
   throws IOException {
   int n = inputBuffer.doRead(chunk, this);
  -if (n > 0)
  +if (n > 0) {
   available -= n;
  +bytesRead+=n;
  +}
   return n;
   }
   
  @@ -460,6 +466,9 @@
   
   
   public void recycle() {
  +// Call RequestProcessorMX
  +reqProcessorMX.updateCounters();
  +bytesRead=0;
   
contentLength = -1;
   contentTypeMB = null;
  @@ -495,5 +504,16 @@
   attributes.clear();
   }
   
  +//  Info  
  +public RequestProcessor getRequestProcessor() {
  +return reqProcessorMX;
  +}
   
  -}
  +public int getBytesRead() {
  +return bytesRead;
  +}
  +
  +public void setBytesRead(int bytesRead) {
  +this.bytesRead = bytesRead;
  +}
  +}
  \ No newline at end of file
  
  
  
  1.20  +16 -3 
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Response.java
  
  Index: Response.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Response.java,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- Response.java 3 Dec 2002 16:37:59 -   1.19
  +++ Response.java 16 Jan 2003 21:56:02 -  1.20
  @@ -150,6 +150,9 @@
   protected int contentLength = -1;
   private Locale locale = DEFAULT_LOCALE;
   
  +// General informations
  +private long bytesWritten=0;
  +
   /**
* Holds request error exception.
*/
  @@ -520,11 +523,12 @@
* Write a chunk of bytes.
*/
   public void doWrite(ByteChunk chunk/*byte buffer[], int pos, int count*/)
  -throws IOException {
  +throws IOException
  +{
   outputBuffer.doWrite(chunk, this);
  +bytesWritten+=chunk.getLength();
   }
   
  -
   // 
   
   public void recycle() {
  @@ -540,7 +544,16 @@
   errorException = null;
   errorURI = null;
   headers.clear();
  -
  +
  +// update counters
  +bytesWritten=0;
   }
   
  +public long getBytesWritten() {
  +return bytesWritten;
  +}
  +
  +public void setBytesWritten(long bytesWritten) {
  +this.bytesWritten = bytesWritten;
  +}
   }
  
  
  
  1.1  
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/RequestProcessor.java
  
  Index: RequestProcessor.java
  ===
  /*
   * 
   *
   * The Apache Software License, Version 1.1
   *
   * Copyright (c) 1999 The Apache Software Foundation.  All rights
   * reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *notice, this li

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5 CoyoteAdapter.java CoyoteConnector.java

2003-01-16 Thread costin
costin  2003/01/16 13:58:15

  Modified:coyote/src/java/org/apache/coyote/tomcat5 CoyoteAdapter.java
CoyoteConnector.java
  Log:
  Removed unused imports.
  
  Let the coyote connector know its name.
  
  Register the protocol adapter with JMX, so it can know its name too.
  
  Revision  ChangesPath
  1.7   +4 -35 
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteAdapter.java
  
  Index: CoyoteAdapter.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteAdapter.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- CoyoteAdapter.java10 Dec 2002 08:44:05 -  1.6
  +++ CoyoteAdapter.java16 Jan 2003 21:58:14 -  1.7
  @@ -63,54 +63,23 @@
   
   package org.apache.coyote.tomcat5;
   
  -
  -import java.io.BufferedInputStream;
  -import java.io.EOFException;
  -import java.io.InterruptedIOException;
  -import java.io.InputStream;
   import java.io.IOException;
  -import java.io.OutputStream;
  -import java.net.InetAddress;
  -import java.net.Socket;
  -import java.util.ArrayList;
  -import java.util.Enumeration;
  -import java.util.Iterator;
  -import java.util.Locale;
  -import java.util.StringTokenizer;
  -import java.util.TreeMap;
  -import javax.servlet.ServletException;
   import javax.servlet.http.Cookie;
   import javax.servlet.http.HttpServletRequest;
  -import javax.servlet.http.HttpServletResponse;
   
   import org.apache.tomcat.util.buf.ByteChunk;
  -import org.apache.tomcat.util.buf.HexUtils;
   import org.apache.tomcat.util.buf.MessageBytes;
   import org.apache.tomcat.util.http.Cookies;
   import org.apache.tomcat.util.http.ServerCookie;
   
   import org.apache.coyote.ActionCode;
  -import org.apache.coyote.ActionHook;
   import org.apache.coyote.Adapter;
  -import org.apache.coyote.InputBuffer;
  -import org.apache.coyote.OutputBuffer;
   import org.apache.coyote.Request;
   import org.apache.coyote.Response;
   
  -import org.apache.catalina.Connector;
  -import org.apache.catalina.Container;
   import org.apache.catalina.Globals;
  -import org.apache.catalina.HttpRequest;
  -import org.apache.catalina.HttpResponse;
  -import org.apache.catalina.Lifecycle;
  -import org.apache.catalina.LifecycleEvent;
  -import org.apache.catalina.LifecycleException;
  -import org.apache.catalina.LifecycleListener;
   import org.apache.catalina.Logger;
  -import org.apache.catalina.util.LifecycleSupport;
  -import org.apache.catalina.util.RequestUtil;
   import org.apache.catalina.util.StringManager;
  -import org.apache.catalina.util.StringParser;
   
   
   /**
  
  
  
  1.9   +120 -57   
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteConnector.java
  
  Index: CoyoteConnector.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteConnector.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- CoyoteConnector.java  14 Jan 2003 21:50:41 -  1.8
  +++ CoyoteConnector.java  16 Jan 2003 21:58:14 -  1.9
  @@ -1,8 +1,4 @@
   /*
  - * $Header$
  - * $Revision$
  - * $Date$
  - *
* 
*
* The Apache Software License, Version 1.1
  @@ -65,36 +61,16 @@
   package org.apache.coyote.tomcat5;
   
   
  -import java.io.IOException;
  -import java.net.InetAddress;
  -import java.net.ServerSocket;
  -import java.net.Socket;
  -import java.net.UnknownHostException;
  -import java.security.AccessControlException;
  -import java.util.Stack;
   import java.util.Vector;
  -import java.util.Enumeration;
  -import java.security.KeyStoreException;
  -import java.security.NoSuchAlgorithmException;
  -import java.security.cert.CertificateException;
  -import java.security.UnrecoverableKeyException;
  -import java.security.KeyManagementException;
   
   import org.apache.tomcat.util.IntrospectionUtils;
   
  -import org.apache.coyote.ActionCode;
  -import org.apache.coyote.ActionHook;
   import org.apache.coyote.Adapter;
  -import org.apache.coyote.InputBuffer;
  -import org.apache.coyote.OutputBuffer;
   import org.apache.coyote.ProtocolHandler;
   
   import org.apache.catalina.Connector;
   import org.apache.catalina.Container;
  -import org.apache.catalina.HttpRequest;
  -import org.apache.catalina.HttpResponse;
   import org.apache.catalina.Lifecycle;
  -import org.apache.catalina.LifecycleEvent;
   import org.apache.catalina.LifecycleException;
   import org.apache.catalina.LifecycleListener;
   import org.apache.catalina.Logger;
  @@ -105,6 +81,12 @@
   import org.apache.catalina.net.ServerSocketFactory;
   import org.apache.catalina.util.LifecycleSupport;
   import org.apache.catalina.util.StringManager;

cvs commit: jakarta-tomcat-5 build.properties.default build.xml

2003-01-16 Thread remm
remm2003/01/16 14:00:52

  Modified:.build.properties.default build.xml
  Log:
  - Add commons-fileupload to the download target.
  
  Revision  ChangesPath
  1.56  +4 -4  jakarta-tomcat-5/build.properties.default
  
  Index: build.properties.default
  ===
  RCS file: /home/cvs/jakarta-tomcat-5/build.properties.default,v
  retrieving revision 1.55
  retrieving revision 1.56
  diff -u -r1.55 -r1.56
  --- build.properties.default  15 Jan 2003 03:38:00 -  1.55
  +++ build.properties.default  16 Jan 2003 22:00:52 -  1.56
  @@ -152,9 +152,9 @@
   
   # - Commons FileUpload, nightly build -
   commons-fileupload.home=${base.path}/commons-fileupload
  -commons-fileupload.lib=${commons-fileupload.home}
  -commons-fileupload.jar=${commons-fileupload.lib}/commons-fileupload-1.0-dev.jar
  
-#commons-fileupload.loc=http://jakarta.apache.org/builds/jakarta-commons/nightly/commons-fileupload/commons-fileupload-20030106.zip
  +commons-fileupload.lib=${commons-fileupload.home}/dist
  +commons-fileupload.jar=${commons-fileupload.lib}/commons-fileupload.jar
  +commons-fileupload.loc=jakarta-commons/fileupload
   
   
   # - JavaGroups, version 2.0.3 or later -
  
  
  
  1.62  +7 -0  jakarta-tomcat-5/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
  retrieving revision 1.61
  retrieving revision 1.62
  diff -u -r1.61 -r1.62
  --- build.xml 27 Dec 2002 09:25:29 -  1.61
  +++ build.xml 16 Jan 2003 22:00:52 -  1.62
  @@ -818,6 +818,13 @@
 
   
   
  +
  +  
  +  
  +  
  +  
  +
  +
   
 
 
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/coyote build.xml

2003-01-16 Thread remm
remm2003/01/16 14:05:04

  Modified:coyote   build.xml
  Log:
  - Include memory adapter.
  
  Revision  ChangesPath
  1.17  +2 -1  jakarta-tomcat-connectors/coyote/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/coyote/build.xml,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- build.xml 11 Jan 2003 00:03:01 -  1.16
  +++ build.xml 16 Jan 2003 22:05:04 -  1.17
  @@ -220,6 +220,7 @@
manifest="${conf.home}/MANIFEST.MF"
excludes="**/tomcat3/*" >
 
  +  
 
   
 
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/coyote build.xml

2003-01-16 Thread remm
remm2003/01/16 14:11:48

  Modified:coyote   build.xml
  Log:
  - Add needed JARs.
  
  Revision  ChangesPath
  1.18  +3 -1  jakarta-tomcat-connectors/coyote/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/coyote/build.xml,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- build.xml 16 Jan 2003 22:05:04 -  1.17
  +++ build.xml 16 Jan 2003 22:11:48 -  1.18
  @@ -78,6 +78,8 @@
 
   
   
  +
  +
   
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-catalina/catalina build.xml

2003-01-16 Thread remm
remm2003/01/16 14:12:00

  Modified:catalina build.xml
  Log:
  - Add needed JARs.
  
  Revision  ChangesPath
  1.37  +3 -0  jakarta-tomcat-catalina/catalina/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/build.xml,v
  retrieving revision 1.36
  retrieving revision 1.37
  diff -u -r1.36 -r1.37
  --- build.xml 16 Jan 2003 20:58:24 -  1.36
  +++ build.xml 16 Jan 2003 22:12:00 -  1.37
  @@ -695,6 +695,9 @@
   
 
 
  +  
  +  
  +  
   
   
   mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/common HandlerRequest.java ChannelSocket.java

2003-01-16 Thread costin
costin  2003/01/16 14:13:37

  Modified:jk/java/org/apache/jk/common HandlerRequest.java
ChannelSocket.java
  Log:
  Add JMX info.
  
  The thread pool will be registered, as well as RequestProcessor.
  For each request we'll save in the thread pool attributes the stage
  and URI.
  
  If the JkHandlers are not registered - the domain is not set and nothing
  will happen.
  
  Revision  ChangesPath
  1.21  +23 -2 
jakarta-tomcat-connectors/jk/java/org/apache/jk/common/HandlerRequest.java
  
  Index: HandlerRequest.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/common/HandlerRequest.java,v
  retrieving revision 1.20
  retrieving revision 1.21
  diff -u -r1.20 -r1.21
  --- HandlerRequest.java   18 Dec 2002 09:26:48 -  1.20
  +++ HandlerRequest.java   16 Jan 2003 22:13:37 -  1.21
  @@ -68,9 +68,11 @@
   import org.apache.tomcat.util.http.*;
   import org.apache.tomcat.util.buf.*;
   import org.apache.tomcat.util.net.SSLSupport;
  +import org.apache.tomcat.util.threads.ThreadWithAttributes;
   
   import org.apache.coyote.Request;
   import org.apache.coyote.*;
  +import org.apache.commons.modeler.Registry;
   
   /**
* Handle messages related with basic request information.
  @@ -328,6 +330,8 @@
   throws IOException
   {
   int type=msg.getByte();
  +ThreadWithAttributes twa=(ThreadWithAttributes)Thread.currentThread();
  +Object control=ep.getControl();
   
   MessageBytes tmpMB=(MessageBytes)ep.getNote( tmpBufNote );
   if( tmpMB==null ) {
  @@ -339,8 +343,12 @@
   
   switch( type ) {
   case JK_AJP13_FORWARD_REQUEST:
  -try { 
  +try {
  +twa.setCurrentStage(control, "JkDecode");
   decodeRequest( msg, ep, tmpMB );
  +twa.setCurrentStage(control, "JkService");
  +twa.setParam(control,
  +((Request)ep.getRequest()).unparsedURI().toString());
   } catch( Exception ex ) {
   log.error( "Error decoding request ", ex );
   msg.dump( "Incomming message");
  @@ -356,8 +364,10 @@
   if(log.isDebugEnabled() )
   log.debug("Calling next " + next.getName() + " " +
 next.getClass().getName());
  -
  +
   int err= next.invoke( msg, ep );
  +twa.setCurrentStage(control, "JkDone");
  +
   if( log.isDebugEnabled() )
   log.debug( "Invoke returned " + err );
   return err;
  @@ -400,6 +410,8 @@
   return OK;
   }
   
  +static int count=0;
  +
   private int decodeRequest( Msg msg, MsgContext ep, MessageBytes tmpMB )
   throws IOException
   {
  @@ -410,6 +422,15 @@
   Response res=new Response();
   req.setResponse(res);
   ep.setRequest( req );
  +RequestProcessor rp=new RequestProcessor(req);
  +if( this.getDomain() != null ) {
  +try {
  +Registry.getRegistry().registerComponent( rp,
  +getDomain(), "RequestProcessor", "name=Request" + 
count++ );
  +} catch( Exception ex ) {
  +log.warn("Error registering request");
  +}
  +}
   }
   
   JkInputStream jkBody=(JkInputStream)ep.getNote( bodyNote );
  
  
  
  1.31  +24 -6 
jakarta-tomcat-connectors/jk/java/org/apache/jk/common/ChannelSocket.java
  
  Index: ChannelSocket.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/common/ChannelSocket.java,v
  retrieving revision 1.30
  retrieving revision 1.31
  diff -u -r1.30 -r1.31
  --- ChannelSocket.java19 Dec 2002 15:36:32 -  1.30
  +++ ChannelSocket.java16 Jan 2003 22:13:37 -  1.31
  @@ -70,6 +70,8 @@
   import org.apache.tomcat.util.threads.*;
   
   import org.apache.jk.core.*;
  +import org.apache.jk.server.JkMain;
  +import org.apache.commons.modeler.Registry;
   
   
   /* XXX Make the 'message type' pluggable
  @@ -95,6 +97,10 @@
* @author Costin Manolache
* @jmx:mbean name="jk2:service=ChannelSocket"
*description="Accept socket connections"
  + * @jmx:notification name="org.apache.coyote.INVOKE
  + * @jmx:notification-handler name="org.apache.jk.JK_SEND_PACKET
  + * @jmx:notification-handler name="org.apache.jk.JK_RECEIVE_PACKET
  + * @jmx:notification-handler name="org.apache.jk.JK_FLUSH
*/
   public class ChannelSocket extends JkHandler {
   private static org.apache.commons.logging.Log log=
  @@ -118,7 +124,7 @@
   */
   static final boolean BUFFER_WRITE=false;
   
  -ThreadPool tp=n

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/core JkHandler.java

2003-01-16 Thread costin
costin  2003/01/16 14:15:05

  Modified:jk/java/org/apache/jk/core JkHandler.java
  Log:
  Let the handlers know their names.
  
  A handler is a notification listener - right now the method is not
  implemented, but will eventually call ( or replace ) invoke.
  
  Revision  ChangesPath
  1.10  +45 -3 
jakarta-tomcat-connectors/jk/java/org/apache/jk/core/JkHandler.java
  
  Index: JkHandler.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/core/JkHandler.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- JkHandler.java9 Aug 2002 20:54:24 -   1.9
  +++ JkHandler.java16 Jan 2003 22:15:05 -  1.10
  @@ -60,15 +60,18 @@
   
   import java.io.*;
   import java.util.*;
  -import java.security.*;
   
  -import org.apache.tomcat.util.handler.*;
  +import javax.management.Notification;
  +import javax.management.MBeanRegistration;
  +import javax.management.ObjectName;
  +import javax.management.MBeanServer;
  +import javax.management.NotificationListener;
   
   /**
*
* @author Costin Manolache
*/
  -public class JkHandler {
  +public class JkHandler implements MBeanRegistration, NotificationListener {
   public static final int OK=0;
   public static final int LAST=1;
   public static final int ERROR=2;
  @@ -166,6 +169,45 @@
*/
   public void addHandlerCallback( JkHandler w ) {
   
  +}
  +
  +public void handleNotification(Notification notification, Object handback)
  +{
  +//BaseNotification bNot=(BaseNotification)notification;
  +//int code=bNot.getCode();
  +//
  +//MsgContext ctx=(MsgContext)bNot.getSource();
  +
  +
  +}
  +
  +protected String domain;
  +protected ObjectName oname;
  +protected MBeanServer mserver;
  +
  +public ObjectName getObjectName() {
  +return oname;
  +}
  +
  +public String getDomain() {
  +return domain;
  +}
  +
  +public ObjectName preRegister(MBeanServer server,
  +  ObjectName name) throws Exception {
  +oname=name;
  +mserver=server;
  +domain=name.getDomain();
  +return name;
  +}
  +
  +public void postRegister(Boolean registrationDone) {
  +}
  +
  +public void preDeregister() throws Exception {
  +}
  +
  +public void postDeregister() {
   }
   
   }
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java JkMain.java

2003-01-16 Thread costin
costin  2003/01/16 14:17:37

  Modified:jk/java/org/apache/jk/server JkCoyoteHandler.java
JkMain.java
  Log:
  When the coyote handler is registered ( by the Connector or other method ),
  it'll also register JkMain.
  
  JkMain will register all handlers as mbeans.
  
  If the coyote handler is not registered - nothing happens.
  
  Revision  ChangesPath
  1.33  +16 -2 
jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkCoyoteHandler.java
  
  Index: JkCoyoteHandler.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkCoyoteHandler.java,v
  retrieving revision 1.32
  retrieving revision 1.33
  diff -u -r1.32 -r1.33
  --- JkCoyoteHandler.java  18 Dec 2002 09:15:06 -  1.32
  +++ JkCoyoteHandler.java  16 Jan 2003 22:17:37 -  1.33
  @@ -74,8 +74,14 @@
   import org.apache.tomcat.util.net.SSLSupport;
   
   import org.apache.coyote.*;
  +import org.apache.commons.modeler.Registry;
  +import javax.management.ObjectName;
  +import javax.management.MBeanServer;
   
   /** Plugs Jk2 into Coyote
  + *
  + * @jmx:notification-handler name="org.apache.jk.SEND_PACKET
  + * @jmx:notification-handler name="org.apache.coyote.ACTION_COMMIT
*/
   public class JkCoyoteHandler extends JkHandler implements
   ProtocolHandler,
  @@ -302,8 +308,7 @@
   if( contentLanguage != null ) {
   headers.setValue("Content-Language").setString(contentLanguage);
   }
  -
  -int contentLength = res.getContentLength();
  + int contentLength = res.getContentLength();
   if( contentLength >= 0 ) {
   headers.setValue("Content-Length").setInt(contentLength);
   }
  @@ -441,5 +446,14 @@
   logTime.debug("Time pre=" + t1 + "/ service=" + t2 + " " +
 res.getContentLength() + " " + 
 uri );
  +}
  +
  +public ObjectName preRegister(MBeanServer server,
  +  ObjectName name) throws Exception
  +{
  +// XXX Can we have multiple JkMain ?
  +Registry.getRegistry().registerComponent(jkMain, name.getDomain(),
  +"JkMain", "name=JkMain");
  +return super.preRegister(server, name);
   }
   }
  
  
  
  1.33  +48 -8 
jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkMain.java
  
  Index: JkMain.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkMain.java,v
  retrieving revision 1.32
  retrieving revision 1.33
  diff -u -r1.32 -r1.33
  --- JkMain.java   13 Nov 2002 00:19:00 -  1.32
  +++ JkMain.java   16 Jan 2003 22:17:37 -  1.33
  @@ -60,15 +60,15 @@
   package org.apache.jk.server;
   
   import java.io.*;
  -import java.net.*;
   import java.util.*;
   
   import org.apache.jk.core.*;
  -import org.apache.jk.common.*;
   
  -import org.apache.tomcat.util.buf.*;
  -import org.apache.tomcat.util.http.*;
   import org.apache.tomcat.util.IntrospectionUtils;
  +import org.apache.commons.modeler.Registry;
  +import javax.management.ObjectName;
  +import javax.management.MBeanServer;
  +import javax.management.MBeanRegistration;
   
   /** Main class used to startup and configure jk. It manages the conf/jk2.properties 
file
*  and is the target of JMX proxy.
  @@ -102,8 +102,9 @@
*  to see configs based on registry, LDAP, db, etc. ( XML is not necesarily better 
)
* 
* @author Costin Manolache
  + * @deprecated Will be replaced with JMX operations
*/
  -public class JkMain
  +public class JkMain implements MBeanRegistration
   {
   WorkerEnv wEnv=new WorkerEnv();
   String propFile;
  @@ -113,7 +114,7 @@
   boolean modified=false;
   boolean started=false;
   boolean saveProperties=false;
  -
  +
   public JkMain()
   {
   JkMain.jkMain=this;
  @@ -122,6 +123,7 @@
   modules.put("channelJni", "org.apache.jk.common.ChannelJni");
   modules.put("apr", "org.apache.jk.apr.AprImpl");
   modules.put("mx", "org.apache.jk.common.JkMX");
  +modules.put("modeler", "org.apache.jk.common.JkModeler");
   modules.put("shm", "org.apache.jk.common.Shm");
   modules.put("request","org.apache.jk.common.HandlerRequest");
   modules.put("container","org.apache.jk.common.HandlerRequest");
  @@ -150,7 +152,7 @@
   ex.printStackTrace();
   }
   }
  -
  +
   //  Setting 
   
   /** Load a .properties file into and set the values
  @@ -223,7 +225,7 @@
   public String getJkHome() {
   return wEnv.getJkHome();
   }
  -
  +
   String out;
   String err;
   File propsF;
  @@ -560,7 +562,15 @@
   log.error( "Can't create " + fu

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/core MsgContext.java

2003-01-16 Thread costin
costin  2003/01/16 14:18:55

  Modified:jk/java/org/apache/jk/core MsgContext.java
  Log:
  Store a "control" object, for guard-based access control
  
  Revision  ChangesPath
  1.6   +12 -1 
jakarta-tomcat-connectors/jk/java/org/apache/jk/core/MsgContext.java
  
  Index: MsgContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/core/MsgContext.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- MsgContext.java   20 Jun 2002 18:49:23 -  1.5
  +++ MsgContext.java   16 Jan 2003 22:18:55 -  1.6
  @@ -70,6 +70,7 @@
   import org.apache.tomcat.util.buf.MessageBytes;
   import org.apache.tomcat.util.http.HttpMessages;
   import org.apache.tomcat.util.buf.HexUtils;
  +import org.apache.tomcat.util.threads.ThreadPool;
   
   
   /**
  @@ -89,8 +90,10 @@
   private WorkerEnv wEnv;
   private Msg msgs[]=new Msg[10];
   private int status=0;
  +// Control object
  +private Object control;
   
  -// Application managed, like notes 
  +// Application managed, like notes
   private long timers[]=new long[20];
   
   // The context can be used by JNI components as well
  @@ -228,5 +231,13 @@
   
   public long getJniContext() {
   return jkEndpointP;
  +}
  +
  +public Object getControl() {
  +return control;
  +}
  +
  +public void setControl(Object control) {
  +this.control = control;
   }
   }
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyoteRequestProcessor.java Request.java Response.java

2003-01-16 Thread Remy Maucherat
[EMAIL PROTECTED] wrote:

costin  2003/01/16 13:56:02

  Modified:coyote/src/java/org/apache/coyote Request.java Response.java
  Added:   coyote/src/java/org/apache/coyote RequestProcessor.java
  Log:
  Collect data about incoming/outgoing traffic, other per/request statistics.
  
  To avoid sync and keep things simple - we collect them in RequestProcessor,
  a per/thread structure.

That's neat. I was wondering how to do something like the APache server 
status (which I like). Of course, if it *also* can be accessed using 
JMX, it rocks ;-)

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Request.java

2003-01-16 Thread remm
remm2003/01/16 14:25:19

  Modified:coyote/src/java/org/apache/coyote Request.java
  Log:
  - It doesn't seem useful to do a recycle on init. Rather, initialize the fields 
needed.
  
  Revision  ChangesPath
  1.17  +7 -3  
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Request.java
  
  Index: Request.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Request.java,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- Request.java  16 Jan 2003 21:56:02 -  1.16
  +++ Request.java  16 Jan 2003 22:25:19 -  1.17
  @@ -114,12 +114,16 @@
   
   public Request() {
   
  - recycle();
  -
   parameters.setQuery(queryMB);
   parameters.setURLDecoder(urlDecoder);
   parameters.setHeaders(headers);
   
  +schemeMB.setString("http");
  +methodMB.setString("GET");
  +uriMB.setString("/");
  +queryMB.setString("");
  +protoMB.setString("HTTP/1.0");
  +
   }
   
   
  @@ -516,4 +520,4 @@
   public void setBytesRead(int bytesRead) {
   this.bytesRead = bytesRead;
   }
  -}
  \ No newline at end of file
  +}
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java

2003-01-16 Thread costin
costin  2003/01/16 14:29:52

  Modified:http11   build.xml
   http11/src/java/org/apache/coyote/http11
Http11Processor.java Http11Protocol.java
  Log:
  Same thing as in jk - threads and request processors are registered in
  JMX  (if coyote itself is registered and it registers the protocol adapter )
  
  Revision  ChangesPath
  1.10  +5 -1  jakarta-tomcat-connectors/http11/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/http11/build.xml,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- build.xml 13 Nov 2002 00:14:25 -  1.9
  +++ build.xml 16 Jan 2003 22:29:51 -  1.10
  @@ -31,6 +31,8 @@
 
 
  +  
  +  
 
   
   
  @@ -75,6 +77,8 @@
   
   
   
  +
  +
 
   
   
  
  
  
  1.56  +28 -8 
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java
  
  Index: Http11Processor.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java,v
  retrieving revision 1.55
  retrieving revision 1.56
  diff -u -r1.55 -r1.56
  --- Http11Processor.java  4 Jan 2003 10:34:19 -   1.55
  +++ Http11Processor.java  16 Jan 2003 22:29:51 -  1.56
  @@ -59,7 +59,6 @@
   
   package org.apache.coyote.http11;
   
  -import java.io.EOFException;
   import java.io.InterruptedIOException;
   import java.io.InputStream;
   import java.io.IOException;
  @@ -74,12 +73,12 @@
   import org.apache.tomcat.util.buf.Ascii;
   import org.apache.tomcat.util.buf.HexUtils;
   import org.apache.tomcat.util.net.SSLSupport;
  +import org.apache.tomcat.util.threads.ThreadPool;
  +import org.apache.tomcat.util.threads.ThreadWithAttributes;
   
   import org.apache.coyote.ActionHook;
   import org.apache.coyote.ActionCode;
   import org.apache.coyote.Adapter;
  -import org.apache.coyote.InputBuffer;
  -import org.apache.coyote.OutputBuffer;
   import org.apache.coyote.Processor;
   import org.apache.coyote.Request;
   import org.apache.coyote.Response;
  @@ -279,6 +278,7 @@
*/
   protected char[] hostNameC = new char[0];
   
  +protected ThreadPool threadPool;
   
   // - Properties
   
  @@ -321,6 +321,9 @@
   }
   }
   
  +public void setThreadPool(ThreadPool threadPool) {
  +this.threadPool = threadPool;
  +}
   
   /**
* Add user-agent for which gzip compression didn't works
  @@ -532,17 +535,28 @@
   return timeout;
   }
   
  +/** Get the request associated with this processor.
  + *
  + * @return
  + */
  +public Request getRequest() {
  +return request;
  +}
  +
   /**
* Process pipelined HTTP requests using the specified input and output
* streams.
* 
  - * @param inputStream stream from which the HTTP requests will be read
  - * @param outputStream stream which will be used to output the HTTP 
  + * @param input stream from which the HTTP requests will be read
  + * @param output stream which will be used to output the HTTP
* responses
* @throws IOException error during an I/O operation
*/
   public void process(InputStream input, OutputStream output)
   throws IOException {
  +ThreadWithAttributes thrA=
  +(ThreadWithAttributes)Thread.currentThread();
  +thrA.setCurrentStage(threadPool, "parsing http request");
   
   // Set the remote address
   remoteAddr = null;
  @@ -567,6 +581,7 @@
   socket.setSoTimeout(soTimeout);
   }
   inputBuffer.parseRequestLine();
  +thrA.setParam( threadPool, request.requestURI().toString());
   keptAlive = true;
   if (!disableUploadTimeout) {
   socket.setSoTimeout(timeout);
  @@ -583,6 +598,7 @@
   }
   
   // Setting up filters, and parse some request headers
  +thrA.setCurrentStage(threadPool, "prepareRequest");
   prepareRequest();
   
   if (maxKeepAliveRequests > 0 && --keepAliveLeft == 0)
  @@ -591,6 +607,7 @@
   // Process the request in the adapter
   if (!error) {
   try {
  +thrA.setCurrentStage(threadPool, "service");
   adapter.service(request, response);
   } catch (InterruptedIOException e) {
   error = true;
  @@ -604,6 +621,7 @@
   
   // Finish the handling of the request
   try {
  +thrA.setCurrentStage(threadPool, "endRequestIB");
   inpu

cvs commit: jakarta-tomcat-connectors/coyote build.xml

2003-01-16 Thread costin
costin  2003/01/16 14:31:01

  Modified:coyote   build.xml
  Log:
  Add commons-modeler.
  
  Revision  ChangesPath
  1.19  +5 -1  jakarta-tomcat-connectors/coyote/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/coyote/build.xml,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- build.xml 16 Jan 2003 22:11:48 -  1.18
  +++ build.xml 16 Jan 2003 22:31:00 -  1.19
  @@ -29,6 +29,10 @@
 
 
   
  +  
  +
  +  
  +
   
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/jk build.xml

2003-01-16 Thread remm
remm2003/01/16 14:41:37

  Modified:jk   build.xml
  Log:
  - Add missing commons-modeler.
  
  Revision  ChangesPath
  1.62  +1 -0  jakarta-tomcat-connectors/jk/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/build.xml,v
  retrieving revision 1.61
  retrieving revision 1.62
  diff -u -r1.61 -r1.62
  --- build.xml 15 Nov 2002 13:34:29 -  1.61
  +++ build.xml 16 Jan 2003 22:41:37 -  1.62
  @@ -125,6 +125,7 @@
   
   
   
  +
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-catalina/catalina build.xml

2003-01-16 Thread remm
remm2003/01/16 14:42:11

  Modified:catalina build.xml
  Log:
  - Add new HTTP/1.1 dependencies.
  
  Revision  ChangesPath
  1.38  +2 -0  jakarta-tomcat-catalina/catalina/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/build.xml,v
  retrieving revision 1.37
  retrieving revision 1.38
  diff -u -r1.37 -r1.38
  --- build.xml 16 Jan 2003 22:12:00 -  1.37
  +++ build.xml 16 Jan 2003 22:42:09 -  1.38
  @@ -731,6 +731,8 @@
   
   
 
  +  
  +  
   
   
   mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: 




DO NOT REPLY [Bug 16185] New: - UserDatabase is not bound in this context

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16185

UserDatabase is not bound in this context

   Summary: UserDatabase is not bound in this context
   Product: Tomcat 4
   Version: 4.1.18
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I can use a global UserDatabase with no problems. However if I add a
UserDatabase to a Context then I get the
UserDatabase is not bound in this context
error.

I've seen this posted previously on tomcat-users but have not seen any
resolution. A search here didn't show up any bug reports

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-5 build.xml

2003-01-16 Thread costin
costin  2003/01/16 15:14:02

  Modified:.build.xml
  Log:
  Few more improvments to the "fast" build:
  - more consistent names,
  - description so it is picked by -projecthelp and completion
  - don't detect tomcat5 and build stuff we don't need.
  
  Added the beginning of the admin jspc precompilation. I still need
  to get the precompiled jars into the web.xml and test it - if someone
  more familiar with admin could help...
  
  Also added a target to convert mbeans-description to .ser - not
  used right now, I'm just testing the speed.
  
  Revision  ChangesPath
  1.63  +112 -26   jakarta-tomcat-5/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
  retrieving revision 1.62
  retrieving revision 1.63
  diff -u -r1.62 -r1.63
  --- build.xml 16 Jan 2003 22:00:52 -  1.62
  +++ build.xml 16 Jan 2003 23:14:02 -  1.63
  @@ -5,6 +5,7 @@
   
 
 
  +  
 
 
 
  @@ -65,9 +66,10 @@
   
   
   
  -
  +
  +
 
   
   
  @@ -90,17 +92,17 @@
 
   
   
  -
 
   
   
  -
 
   
   
  -
 
   
  @@ -148,12 +150,14 @@
   
 
   
  -  
  +  
   == Building: tomcat-jk 
   
  -
  +
 
  +  
 
  +  
 
   
 
  @@ -167,39 +171,95 @@
   
 
   
  -  
   == Building: tomcat-coyote 
   
  -
  +
 
  +  
 
  +  
 
   
 
   
  -  
   == Building: tomcat-http11 
   
  -
  +
 
 
  +  
 
  +  
   
 
   
  -  
  -== Building: admin 
  +  
  +== Building: admin to  ${tomcat.build}/server/webapps 
   
  -  
  +  
 
   
   
  -
  +
  +
  +
  +
  +
  +
  +  
  +
  +
  +  
  +
  +
  +  
  +
  +
  +  
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +  
  +
  +
  +  
  +
  +
  +  
  +
  +
  +  
  +
  +
  +  
  +  
  +
  +
  +
 
   
 == Building: catalina 
   
  -
  -
  +
  +
  +
   
  +
   
  -
   
   
  -
  +
   
  -
  +
   
  -
  +
 
   == Building: jasper 
   
  @@ -251,7 +314,7 @@
 
   == Building: commons-modeler 
   
  -
  +
   
   
   
  @@ -279,7 +342,11 @@
   
   
   Target: Catalina - Deploy ...
  -
  +
  +
  +
  +
  +
   
 
   
  @@ -990,6 +1057,9 @@
   
  +
 
   
   
  @@ -1000,5 +1070,21 @@
 
   
 
  +
  +  
  +  
  +
  +  
  +  
  +
  +
  +
  +
  +  
  +
  +
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-5/resources mbeans.xml

2003-01-16 Thread costin
costin  2003/01/16 15:16:12

  Modified:resources mbeans.xml
  Log:
  Few changes.
  
  Starting and controlling tomcat5 from ant works pretty nice - but
  dynamic add/remove mbeans is not implemented.
  
  That's the main method I use to run tomcat5 - about 20sec startup
  time ( with /admin removed ).
  
  Revision  ChangesPath
  1.4   +26 -48jakarta-tomcat-5/resources/mbeans.xml
  
  Index: mbeans.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-5/resources/mbeans.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- mbeans.xml8 Jan 2003 20:09:08 -   1.3
  +++ mbeans.xml16 Jan 2003 23:16:12 -  1.4
  @@ -1,4 +1,4 @@
  -
  +
   
 
 
  @@ -28,6 +28,13 @@
   
   
 
  +  
  +  
  +  
  +  
  +  
 
 
 
  @@ -104,23 +111,22 @@
For example: The ajp connector will create it's own pool, while the http
connector is configured with a specific instance.
 -->
  +
   
  -
  +
   
  -
  -  org.apache.coyote.http11.Http11Protocol
  -
  +
   
   
  +   name="${domain}:type=Server" />
   
   
  +   name="${domain}:type=Host,host=default" />
   
   
  +   name="${domain}:type=Context,host=default,context=/" />
   
   
   
  @@ -128,60 +134,40 @@
( in the standalone version, not the ant file )
 -->
   
   
  -   
   
  -
  -
   
   
  -
   
  -
  -
  -
  -
 
   
   
 
  -   
  -
  -  
  -  
  -  
  -  
  -
  -  
   
  -  
   
   
  +  name="Catalina:type=server" />
   
  -
 
   
   
  -
   
   
  @@ -194,19 +180,11 @@
 
   
  -
   
 
   
  -  
  -
  -
  -  
  -  
  -
  -  
  +  
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 16189] New: - Tomcat Hangs in SSL Mode (Both 4.1.18 and 4.1.18LE for JDK 1.4)

2003-01-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16189

Tomcat Hangs in SSL Mode (Both 4.1.18 and 4.1.18LE for JDK 1.4)

   Summary: Tomcat Hangs in SSL Mode (Both 4.1.18 and 4.1.18LE for
JDK 1.4)
   Product: Tomcat 4
   Version: 4.1.18
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Major
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Spec.

Tomcat 4.1.18LE for JDK 1.4 (Problems also occurs with standard 4.1.18)
Struts 1.1-beta2
JDK 1.4.1
Win2k

Intermittent problem. After some use the following error occurs.

org.apache.commons.logging.LogConfigurationException: 
org.apache.commons.logging.LogConfigurationException: 
org.apache.commons.logging.LogConfigurationException: Class 
org.apache.commons.logging.impl.Jdk14Logger does not implement 

Caused by: org.apache.commons.logging.LogConfigurationException: 
org.apache.commons.logging.LogConfigurationException: Class 
org.apache.commons.logging.impl.Jdk14Logger does not implement Log

Caused by: org.apache.commons.logging.LogConfigurationException: Class 
org.apache.commons.logging.impl.Jdk14Logger does not implement Log

The Container hangs and needs to be restarted. This genereally happens within 
the first few actions that are called.

When SSL links/forms etc. are removed from my app, this problem does not occur.

Thinking it would help, have switched from Log4j to JDK 1.4 Logging

have also tried comment out  Tags in server.sml so that logging goes to 
the console. 

Problem still occurs

Regards

Steve Vanspall

--
To unsubscribe, e-mail:   
For additional commands, e-mail: