[sr-dev] Re: [kamailio/kamailio] Cmake: small bugfixes (lib/ims, dialplan, sctp) (PR #4155)
@drTr0jan pushed 2 commits. eb918897d7efcd5b5f1e0cdecff2ea3d77235802 sctp: cmake - search for libsctp on linux only e1577208ffcbf2591354f31fe26bbf3851d85781 dialplan: cmake - add pcre2 -- View it on GitHub: https://github.com/kamailio/kamailio/pull/4155/files/bd9e7dcf0be7d7525dad08a65e606cf2a5d37b30..e1577208ffcbf2591354f31fe26bbf3851d85781 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org To unsubscribe send an email to sr-dev-le...@lists.kamailio.org Important: keep the mailing list in the recipients, do not reply only to the sender!
[sr-dev] Re: [kamailio/kamailio] Cmake: small bugfixes (lib/ims, dialplan, sctp) (PR #4155)
@drTr0jan commented on this pull request.
> @@ -1,3 +1,9 @@
file(GLOB MODULE_SOURCES "*.c")
add_library(${module_name} SHARED ${MODULE_SOURCES})
+
+find_package(PkgConfig REQUIRED)
+pkg_check_modules(PCRE2 REQUIRED IMPORTED_TARGET libpcre2-8)
Yep, you're right! Fixed. Thx!
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4155#discussion_r1968282397
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
[sr-dev] [kamailio/kamailio] TOPOS removes via header when calling drop in event_route[topos:msg-outgoing] (Issue #4157)
CrazyTux created an issue (kamailio/kamailio#4157)
### TOPOS removes via header
```
event_route[topos:msg-outgoing] {
# Feature Flag is enabled ** problem occurs here **
if($sht(feature_flags=>kamailio-disable-internal-topos) == "true") {
if(ds_is_from_list(KAM_SET_ID, 3, "sip:$sndto(ip):5060")) {
drop;
}
}
}
```
### Troubleshooting
- verified via exists in original 200 OK REPLY from Freeswitch
- checked wire and verified via header is missing when forwarding 200 OK onward
to next kamailio (B) node from Kamailio (A)
Reproduction
Call drop in event route `topos:msg-outgoing`
- call flow: Freeswitch -> Kamailio A -> Kamailio B -> UAC
- place incoming call into kamailio
- put call on hold / reinvite
Debugging Data
```
Disabling topos entirely via header is correctly sent from A -> B.
```
Log Messages (Kamailio B)
```
2025-02-25T00:19:08.545447+00:00 /usr/sbin/kamailio[3959021]: ERROR: {2 1
INVITE 995df181-4eae-40ae-8225-427ce8252250} [core/receive.c:542]:
receive_msg(): no via found in reply
2025-02-25T00:19:09.045917+00:00 /usr/sbin/kamailio[3959037]: ERROR: {2 1
INVITE 995df181-4eae-40ae-8225-427ce8252250} [core/receive.c:542]:
receive_msg(): no via found in reply
2025-02-25T00:19:10.046936+00:00 /usr/sbin/kamailio[3958995]: ERROR: {2 1
INVITE 995df181-4eae-40ae-8225-427ce8252250} [core/receive.c:542]:
receive_msg(): no via found in reply
2025-02-25T00:19:12.048099+00:00 /usr/sbin/kamailio[3959003]: ERROR: {2 1
INVITE 995df181-4eae-40ae-8225-427ce8252250} [core/receive.c:542]:
receive_msg(): no via found in reply
```
SIP Traffic
`reinvite B -> A:`
```
INVITE sip:mod_so...@54.245.xx.xx:5060 SIP/2.0
Record-Route:
Record-Route:
Via: SIP/2.0/UDP
35.161.XX.XX:5060;branch=z9hG4bK16be.085d2f3d83e8d939f7f1d3fbc4a5ff09.0
Via: SIP/2.0/WSS
74jssm3ooc66.invalid;received=209.160.251.114;branch=z9hG4bK3968143
To: ;tag=9vX27Um099jZS
From:
;tag=q1vfbk6o6q
CSeq: 1 INVITE
Call-ID: 995df181-4eae-40ae-8225-427ce8252250
Max-Forwards: 69
Allow:
ACK,BYE,CANCEL,INFO,INVITE,MESSAGE,NOTIFY,OPTIONS,PRACK,REFER,REGISTER,SUBSCRIBE
Contact:
Supported: outbound
User-Agent: WebPhone/3.1740423483.87
Content-Type: application/sdp
Content-Length: 1538
Route:
,
P-SR-XUID: atpsh-7cde-67bcbccd-3c68ef-1
v=0
o=- 4757376688759011024 3 IN IP4 127.0.0.1
s=-
t=0 0
a=group:BUNDLE 0
a=extmap-allow-mixed
a=msid-semantic: WMS 35a33e17-dd80-46fa-afe9-72fdd03d4e41
m=audio 32999 UDP/TLS/RTP/SAVPF 0 102 101 103 63 9 8 13
c=IN IP4 209.160.251.114
a=rtcp:9 IN IP4 0.0.0.0
a=candidate:2845667355 1 udp 2122260223 10.82.226.218 54425 typ host generation
0 network-id 1 network-cost 10
a=candidate:1750280017 1 udp 1686052607 209.160.251.114 32999 typ srflx raddr
10.82.226.218 rport 54425 generation 0 network-id 1 network-cost 10
a=ice-ufrag:Eb9h
a=ice-pwd:nQdfpsILiUI+YKSQT3eZy52x
a=ice-options:trickle
a=fingerprint:sha-256
BA:68:25:D5:66:70:A9:17:38:18:74:0A:B3:C2:3E:F9:3A:A0:7C:5F:18:0F:EB:B7:93:28:86:56:62:23:DF:E5
a=setup:actpass
a=mid:0
a=extmap:1 urn:ietf:params:rtp-hdrext:ssrc-audio-level
a=extmap:2 http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time
a=extmap:3
http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01
a=extmap:4 urn:ietf:params:rtp-hdrext:sdes:mid
a=sendonly
a=msid:35a33e17-dd80-46fa-afe9-72fdd03d4e41 57910219-943b-4687-9511-b9a9d0a1ea6f
a=rtcp-mux
a=rtcp-rsize
a=rtpmap:0 PCMU/8000
a=rtpmap:102 opus/48000/2
a=fmtp:102 minptime=10;useinbandfec=1
a=rtpmap:101 telephone-event/8000
a=rtpmap:103 telephone-event/48000
a=rtpmap:63 red/48000/2
a=fmtp:63 102/102
a=rtpmap:9 G722/8000
a=rtpmap:8 PCMA/8000
a=rtpmap:13 CN/8000
a=ssrc:2604971680 cname:YEcJO5XrSKZor1jY
a=ssrc:2604971680 msid:35a33e17-dd80-46fa-afe9-72fdd03d4e41
57910219-943b-4687-9511-b9a9d0a1ea6f
```
`200 OK Freeswitch -> A`
```
SIP/2.0 200 OK
v:SIP/2.0/UDP
34.213.XX.XX:5060;branch=z9hG4bK16be.86ee5e1d4190783bd6a79bd21110d190.0
f:;tag=q1vfbk6o6q
t:;tag=9vX27Um099jZS
i:995df181-4eae-40ae-8225-427ce8252250
CSeq:1 INVITE
m:
Accept:application/sdp
Allow:INVITE,ACK,BYE,CANCEL,OPTIONS,MESSAGE,INFO,UPDATE,REGISTER,REFER,NOTIFY,PUBLISH,SUBSCRIBE
k:timer,path,replaces
x:90;refresher=uas
c:application/sdp
Content-Disposition:session
l:284
v=0
o=FreeSWITCH 1740424963 1740424965 IN IP4 54.245.XX.XX
s=FreeSWITCH
c=IN IP4 54.245.XX.XX
t=0 0
m=audio 17776 RTP/AVP 0 101
a=rtpmap:0 PCMU/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-15
a=recvonly
a=ptime:20
a=rtcp-mux
a=rtcp:17776 IN IP4 54.245.XX.XX
```
`200 OK A -> B`
```
SIP/2.0 200 OK
f:;tag=q1vfbk6o6q
t:;tag=9vX27Um099jZS
i:995df181-4eae-40ae-8225-427ce8252250
CSeq:1 INVITE
m:
Accept:application/sdp
Allow:INVITE,ACK,BYE,CANCEL,OPTIONS,MESSAGE,INFO,UPDATE,REGISTER,REFER,NOTIFY,PUBLISH,SUBSCRIBE
k:timer,path,replaces
x:90;refresher=uas
c:application/sdp
Content-Disposition:session
l:315
v=0
o=FreeSWITCH 1740424963 1740424965 IN IP4 34.211.XX.XX
s=FreeSWITCH
c=IN IP4 34.211.XX.XX
t=0 0
m=audio 20374 RTP/AVP 0 101
a=mid:0
a
[sr-dev] Re: [kamailio/kamailio] SEGV in dialog module (PR #4151)
miconda left a comment (kamailio/kamailio#4151) Yes, it will be backported. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4151#issuecomment-2677718717 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org To unsubscribe send an email to sr-dev-le...@lists.kamailio.org Important: keep the mailing list in the recipients, do not reply only to the sender!
[sr-dev] Re: [kamailio/kamailio] xmpp module causes crash in component mode with prosody (Issue #4154)
miconda left a comment (kamailio/kamailio#4154) The parameters look ok, the crash seems to be inside libexpat, maybe you can check that project and see if there are some known bugs for the version you have. The xmpp module was probably not used for very long time, it might be that it needs some updates for latest libexpat versions. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4154#issuecomment-2677748714 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org To unsubscribe send an email to sr-dev-le...@lists.kamailio.org Important: keep the mailing list in the recipients, do not reply only to the sender!
[sr-dev] Re: [kamailio/kamailio] Why can't set_body_multipart and append_body_part* functions be used from ONREPLY_ROUTE? (Issue #4149)
miconda left a comment (kamailio/kamailio#4149) It can be a matter of what the developer needed, so, if nobody else comments, you can do the changes locally, test and if all looks fine, then you can make a PR. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4149#issuecomment-2677753917 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org To unsubscribe send an email to sr-dev-le...@lists.kamailio.org Important: keep the mailing list in the recipients, do not reply only to the sender!
[sr-dev] git:master:f43c132d: sl: stats for 1xx replies
Module: kamailio
Branch: master
Commit: f43c132db9b1dc71f623d592fb46d487ba492c7d
URL:
https://github.com/kamailio/kamailio/commit/f43c132db9b1dc71f623d592fb46d487ba492c7d
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2025-02-24T09:57:38+01:00
sl: stats for 1xx replies
- GH #4144
---
Modified: src/modules/sl/sl_stats.c
---
Diff:
https://github.com/kamailio/kamailio/commit/f43c132db9b1dc71f623d592fb46d487ba492c7d.diff
Patch:
https://github.com/kamailio/kamailio/commit/f43c132db9b1dc71f623d592fb46d487ba492c7d.patch
---
diff --git a/src/modules/sl/sl_stats.c b/src/modules/sl/sl_stats.c
index 3394e0251f0..8e8c835c23b 100644
--- a/src/modules/sl/sl_stats.c
+++ b/src/modules/sl/sl_stats.c
@@ -148,7 +148,7 @@ void update_sl_stats(int code)
my_stats = &(*sl_stats)[process_no];
- if(code >= 700 || code < 200) {
+ if(code >= 700 || code < 100) {
my_stats->err[RT_xxx]++;
} else if(code >= 600) {
my_stats->err[RT_6xx]++;
@@ -203,7 +203,7 @@ void update_sl_stats(int code)
my_stats->err[RT_3xx]++;
break;
}
- } else { /* 2xx */
+ } else if(code >= 200) {
switch(code) {
case 200:
my_stats->err[RT_200]++;
@@ -215,6 +215,8 @@ void update_sl_stats(int code)
my_stats->err[RT_2xx]++;
break;
}
+ } else { /* 1xx */
+ my_stats->err[RT_1xx]++;
}
}
___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
[sr-dev] Re: [kamailio/kamailio] sl: doesn't handle 1xx_replies while metric exists (Issue #4144)
Closed #4144 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4144#event-16427481096 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org To unsubscribe send an email to sr-dev-le...@lists.kamailio.org Important: keep the mailing list in the recipients, do not reply only to the sender!
[sr-dev] Re: [kamailio/kamailio] sl: doesn't handle 1xx_replies while metric exists (Issue #4144)
miconda left a comment (kamailio/kamailio#4144) Thanks, I pushed a commit for it, to be backported. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4144#issuecomment-2677839331 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org To unsubscribe send an email to sr-dev-le...@lists.kamailio.org Important: keep the mailing list in the recipients, do not reply only to the sender!
[sr-dev] Re: [kamailio/kamailio] xmpp module causes crash in component mode with prosody (Issue #4154)
jrozhon left a comment (kamailio/kamailio#4154) thank you for your suggestion. will take a look -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4154#issuecomment-2677932972 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org To unsubscribe send an email to sr-dev-le...@lists.kamailio.org Important: keep the mailing list in the recipients, do not reply only to the sender!
[sr-dev] [kamailio/kamailio] fails to build from source(FTBFS) with GCC 15 (Issue #4156)
linuxmaniac created an issue (kamailio/kamailio#4156) Forwarded from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1096894 > The package fails to build in a test rebuild on at least amd64 with > gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The > severity of this report will be raised before the forky release. > The full build log can be found at: > http://qa-logs.debian.net/2025/02/16/amd64exp/kamailio_6.0.0-1_unstable_gccexp.log.gz > The last lines of the build log are at the end of this report. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4156 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org To unsubscribe send an email to sr-dev-le...@lists.kamailio.org Important: keep the mailing list in the recipients, do not reply only to the sender!
[sr-dev] Re: [kamailio/kamailio] fails to build from source(FTBFS) with GCC 15 (Issue #4156)
linuxmaniac left a comment (kamailio/kamailio#4156) ``` DUSE_FUTEX -DHAVE_SELECT -I/usr/include/libxml2 -DMOD_NAME='"pua"' -DMOD_NAMEID='pua' -c hash.c -o hash.o In file included from /usr/include/libbson-1.0/bson/bson-compat.h:35, from /usr/include/libbson-1.0/bson/bson.h:23, from /usr/include/libmongoc-1.0/mongoc/mongoc.h:22, from /usr/include/libmongoc-1.0/mongoc.h:18, from mongodb_connection.h:28, from mongodb_connection.c:26: /usr/include/libbson-1.0/bson/bson-macros.h:213:34: error: expected ‘;’ before ‘void’ 213 | static BSON_INLINE BSON_NORETURN void | ^~~~ /usr/include/libbson-1.0/bson/bson-macros.h:220:34: error: expected ‘;’ before ‘void’ 220 | static BSON_INLINE BSON_NORETURN void | ^~~~ gcc -fPIC -DPIC -pthread -funroll-loops -Wcast-align -DKSR_PTHREAD_MUTEX_SHARED -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/kamailio-6.0.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -DVERSION_NODATE -DNAME='"kamailio"' -DVERSION='"6.0.0"' -DARCH='"x86_64"' -DOS='linux_' -DOS_QUOTED='"linux"' -DCOMPILER='"gcc 15.0.1"' -D__CPU_x86_64 -D__OS_linux -DVERSIONVAL=600 -DCFG_DIR='"/etc/kamailio/"' -DSHARE_DIR='"/usr/share/kamailio/"' -DRUN_DIR='"/var/run/kamailio/"' -DPKG_MALLOC -DSHM_MMAP -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST -DUSE_NAPTR -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC -DDBG_SR_MEMORY -DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS -DMALLOC_STATS -DUSE_SCTP -DFAST_LOCK -DADAPTIVE_WAIT -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM -DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER -DHAVE_IP_MREQN -DUSE_RAW_SOCKS -DHAVE_EPOLL -DHAVE_SIGIO_RT -DSIGINFO64_WORKAROUND -DUSE_FUTEX -DHAVE_SELECT -DMOD_NAME='"ims_dialog"' -DMOD_NAMEID='ims_dialog' -c dlg_req_within.c -o dlg_req_within.o make[4]: *** [../../Makefile.rules:100: mongodb_connection.o] Error 1 make[3]: *** [Makefile:511: modules] Error 1 make[3]: Leaving directory '/build/reproducible-path/kamailio-6.0.0/src' make[2]: *** [Makefile:34: every-module] Error 2 make[2]: Leaving directory '/build/reproducible-path/kamailio-6.0.0' make[1]: *** [debian/rules:148: build_mongodb] Error 2 make[1]: *** Waiting for unfinished jobs ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4156#issuecomment-2678129776 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org To unsubscribe send an email to sr-dev-le...@lists.kamailio.org Important: keep the mailing list in the recipients, do not reply only to the sender!
[sr-dev] Re: [kamailio/kamailio] fails to build from source(FTBFS) with GCC 15 (Issue #4156)
linuxmaniac left a comment (kamailio/kamailio#4156)
```
ims_dialog.c: In function ‘mod_init’:
ims_dialog.c:573:27: error: passing argument 1 of ‘register_timer’ from
incompatible pointer type [-Wincompatible-pointer-types]
573 | if(register_timer(print_all_dlgs, 0, 10) < 0) {
| ^~
| |
| void (*)(void)
In file included from ../../core/pt.h:31,
from ../../core/counters.h:37,
from ../../core/sr_module.h:44,
from ims_dialog.c:7:
../../core/timer.h:191:35: note: expected ‘void (*)(unsigned int, void *)’ but
argument is of type ‘void (*)(void)’
191 | int register_timer(timer_function f, void *param, unsigned int
interval);
|~~~^
In file included from ims_dialog.c:27:
dlg_handlers.h:199:6: note: ‘print_all_dlgs’ declared here
199 | void print_all_dlgs();
| ^~
make[4]: *** [../../Makefile.rules:100: ims_dialog.o] Error 1
make[4]: *** Waiting for unfinished jobs
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4156#issuecomment-2678132456
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
[sr-dev] git:master:6cdbaa18: ims_dialog: right timer function prototype for print_all_dlgs()
Module: kamailio
Branch: master
Commit: 6cdbaa1815bdcadc467f36109c6e3a7d00c344f5
URL:
https://github.com/kamailio/kamailio/commit/6cdbaa1815bdcadc467f36109c6e3a7d00c344f5
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2025-02-24T12:30:26+01:00
ims_dialog: right timer function prototype for print_all_dlgs()
---
Modified: src/modules/ims_dialog/dlg_handlers.c
Modified: src/modules/ims_dialog/dlg_handlers.h
---
Diff:
https://github.com/kamailio/kamailio/commit/6cdbaa1815bdcadc467f36109c6e3a7d00c344f5.diff
Patch:
https://github.com/kamailio/kamailio/commit/6cdbaa1815bdcadc467f36109c6e3a7d00c344f5.patch
---
diff --git a/src/modules/ims_dialog/dlg_handlers.c
b/src/modules/ims_dialog/dlg_handlers.c
index 3487d7f4c2a..4acc5c3ad45 100644
--- a/src/modules/ims_dialog/dlg_handlers.c
+++ b/src/modules/ims_dialog/dlg_handlers.c
@@ -2048,7 +2048,7 @@ void internal_print_all_dlg(struct dlg_cell *dlg)
* \return void
*/
-void print_all_dlgs()
+void print_all_dlgs(unsigned int ticks, void *param)
{
//print all dialog information - this is just for testing and is set
to happen every 10 seconds
diff --git a/src/modules/ims_dialog/dlg_handlers.h
b/src/modules/ims_dialog/dlg_handlers.h
index fd8ef143352..5aafb054b18 100644
--- a/src/modules/ims_dialog/dlg_handlers.h
+++ b/src/modules/ims_dialog/dlg_handlers.h
@@ -196,7 +196,7 @@ void dlg_tmcb_dummy(struct cell *t, int type, struct
tmcb_params *param);
* \return void
*/
-void print_all_dlgs();
+void print_all_dlgs(unsigned int ticks, void *param);
/*!
* \brief Helper function that prints all the properties of a dialog including
all the dlg_out's
___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
[sr-dev] Re: [kamailio/kamailio] Cmake: small bugfixes (lib/ims, dialplan, sctp) (PR #4155)
@xkaraman commented on this pull request.
> @@ -1,3 +1,9 @@
file(GLOB MODULE_SOURCES "*.c")
add_library(${module_name} SHARED ${MODULE_SOURCES})
+
+find_package(PkgConfig REQUIRED)
+pkg_check_modules(PCRE2 REQUIRED IMPORTED_TARGET libpcre2-8)
Since we are using `IMPORTED_TARGET`, let's use it properly in the
`target_link_libraries` call. This will make sure all necessary includes, links
and other options are used!
See
https://github.com/xkaraman/kamailio/blob/cmake/src/modules/regex/CMakeLists.txt#L12
as a reference.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4155#pullrequestreview-2636687094
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
