@xkaraman commented on this pull request.
> @@ -1,3 +1,9 @@
file(GLOB MODULE_SOURCES "*.c")
add_library(${module_name} SHARED ${MODULE_SOURCES})
+
+find_package(PkgConfig REQUIRED)
+pkg_check_modules(PCRE2 REQUIRED IMPORTED_TARGET libpcre2-8)
Since we are using `IMPORTED_TARGET`, let's use it properly in the
`target_link_libraries` call. This will make sure all necessary includes, links
and other options are used!
See
https://github.com/xkaraman/kamailio/blob/cmake/src/modules/regex/CMakeLists.txt#L12
as a reference.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4155#pullrequestreview-2636687094
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4155/review/2636687...@github.com>_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
