[sr-dev] Re: [kamailio/kamailio] cmake: should we use >= 3.13, i.e., "more modern cmake" generation? (Issue #4078)

2025-01-21 Thread Henning Westerholt via sr-dev
Closed #4078 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4078#event-16016359786
You are receiving this because you commented.

Message ID: ___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!


[sr-dev] Re: [kamailio/kamailio] kamcmd tls.reload problem (Issue #4033)

2025-01-21 Thread Henning Westerholt via sr-dev
Closed #4033 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4033#event-16011238895
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!


[sr-dev] Re: [kamailio/kamailio] multiple Makefiles: evaluate LIBS variable imediately in Makefile (PR #4085)

2025-01-21 Thread Xenofon Karamanos via sr-dev
Hey @sergey-safarov,

This is due to a misssing package called `docbook-xsl`. Hopefully, it's 
available on your OS as well. 

> @miconda After 
> [2692148](https://github.com/kamailio/kamailio/commit/2692148d92bb8b17709eb4cbddd8e653bbf5c14a),
>  this should be the behavior.
> 
> `make install` we now install the README found in `src/modules/*/README` in 
> the `share` folder.

Do you have the need to build the readmes in the end? As we discussed above, 
install should copy the ones found in each module . 



-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4085#issuecomment-2604353718
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!


[sr-dev] Re: [kamailio/kamailio] multiple Makefiles: evaluate LIBS variable imediately in Makefile (PR #4085)

2025-01-21 Thread sergey-safarov via sr-dev
We have implemented `kamailio_docs_readme` target 
[link](https://github.com/kamailio/kamailio/pull/4085#issuecomment-2577661883). 
My expectation do not trigger xslt transformation and just rebuild the modules 
readme file.
I will try with `docbook-xsl`.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4085#issuecomment-2604496188
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!


[sr-dev] git:master:9045c8d5: core: add extra params to first via only for generated replies

2025-01-21 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio
Branch: master
Commit: 9045c8d537b8960a18451f870effe2255cb4861d
URL: 
https://github.com/kamailio/kamailio/commit/9045c8d537b8960a18451f870effe2255cb4861d

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2025-01-21T21:22:38+01:00

core: add extra params to first via only for generated replies

---

Modified: src/core/msg_translator.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/9045c8d537b8960a18451f870effe2255cb4861d.diff
Patch: 
https://github.com/kamailio/kamailio/commit/9045c8d537b8960a18451f870effe2255cb4861d.patch

---

diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c
index 50e867804be..7ad113aa955 100644
--- a/src/core/msg_translator.c
+++ b/src/core/msg_translator.c
@@ -2712,16 +2712,17 @@ char *build_res_buf_from_sip_req(unsigned int code, str 
*text, str *new_tag,
(hdr->body.s + 
hdr->body.len) - hdr->name.s,
msg);
}
-   if(received_buf)
+   if(received_buf) {
append_str(p, received_buf, 
received_len);
+   }
+   if(xparams.len > 0) {
+   append_str(p, xparams.s, 
xparams.len);
+   }
} else {
/* normal whole via copy */
append_str_trans(p, hdr->name.s,
(hdr->body.s + 
hdr->body.len) - hdr->name.s, msg);
}
-   if(xparams.len > 0) {
-   append_str(p, xparams.s, xparams.len);
-   }
append_str(p, CRLF, CRLF_LEN);
/* if is HTTP, replace Via with Sia
 * - HTTP Via format is different than SIP Via

___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!


[sr-dev] git:master:d613f302: core: reworked how rport, received and extra params are added to first via of generated replies

2025-01-21 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio
Branch: master
Commit: d613f30214782d47ed0aab8bf2fb55329d87862a
URL: 
https://github.com/kamailio/kamailio/commit/d613f30214782d47ed0aab8bf2fb55329d87862a

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2025-01-21T21:43:06+01:00

core: reworked how rport, received and extra params are added to first via of 
generated replies

---

Modified: src/core/msg_translator.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/d613f30214782d47ed0aab8bf2fb55329d87862a.diff
Patch: 
https://github.com/kamailio/kamailio/commit/d613f30214782d47ed0aab8bf2fb55329d87862a.patch

---

diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c
index 7ad113aa955..6cd65716625 100644
--- a/src/core/msg_translator.c
+++ b/src/core/msg_translator.c
@@ -2667,57 +2667,50 @@ char *build_res_buf_from_sip_req(unsigned int code, str 
*text, str *new_tag,
if(unlikely(httpreq))
pvia = p;
if(hdr == msg->h_via1) {
-   if(rport_buf) {
-   if(msg->via1->rport) { /* 
delete the old one */
-   /* copy until rport */
-   append_str_trans(p, 
hdr->name.s,
-   
msg->via1->rport->start - hdr->name.s - 1,
-   msg);
-   /* copy new rport */
-   append_str(p, 
rport_buf, rport_len);
-   /* copy the rest of the 
via */
-   append_str_trans(p,
-   
msg->via1->rport->start
-   
+ msg->via1->rport->size,
-   
hdr->body.s + hdr->body.len
-   
- msg->via1->rport->start
-   
- msg->via1->rport->size,
-   msg);
-   } else if(msg->via1->branch) { 
/* add after branch */
-   /* copy until after 
branch */
-   append_str_trans(p, 
hdr->name.s,
-   
msg->via1->branch->start - hdr->name.s
-   
+ msg->via1->branch->size,
-   msg);
-   /* copy new rport */
-   append_str(p, 
rport_buf, rport_len);
-   /* copy the rest of the 
via */
-   append_str_trans(p,
-   
msg->via1->branch->start
-   
+ msg->via1->branch->size,
-   
hdr->body.s + hdr->body.len
-   
- msg->via1->branch->start
-   
- msg->via1->branch->size,
-   msg);
-   } else { /* just append the new 
one */
-   /* normal whole via 
copy */
-   append_str_trans(p, 
hdr->name.s,
-   
(hdr->body.s + hdr->body.len) - hdr->name.s,
-   msg);
-   append_str(p, 
rport_buf, rport_len);
-   }
-   } else {
-   /* normal whole via copy */
+   if(rport_buf && msg->via1->rport) { /* 
replace old rport */
+   /* copy until rport */
+   

[sr-dev] git:master:cfc9d694: etc/kamailio.org: do record route for REFER

2025-01-21 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio
Branch: master
Commit: cfc9d69435b4bbc53dbe6748e0d22603760c48fd
URL: 
https://github.com/kamailio/kamailio/commit/cfc9d69435b4bbc53dbe6748e0d22603760c48fd

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2025-01-21T18:15:19+01:00

etc/kamailio.org: do record route for REFER

- it creates a subscription dialog
- https://datatracker.ietf.org/doc/html/rfc3515#section-2

---

Modified: etc/kamailio.cfg

---

Diff:  
https://github.com/kamailio/kamailio/commit/cfc9d69435b4bbc53dbe6748e0d22603760c48fd.diff
Patch: 
https://github.com/kamailio/kamailio/commit/cfc9d69435b4bbc53dbe6748e0d22603760c48fd.patch

---

diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg
index ea0aa10ca7e..a61227d4173 100644
--- a/etc/kamailio.cfg
+++ b/etc/kamailio.cfg
@@ -578,7 +578,7 @@ request_route {
# record routing for dialog forming requests (in case they are routed)
# - remove preloaded route headers
remove_hf("Route");
-   if (is_method("INVITE|SUBSCRIBE")) {
+   if (is_method("INVITE|SUBSCRIBE|REFER")) {
record_route();
}
 
@@ -700,8 +700,8 @@ route[WITHINDLG] {
} else if ( is_method("ACK") ) {
# ACK is forwarded statelessly
route(NATMANAGE);
-   } else if ( is_method("NOTIFY") ) {
-   # Add Record-Route for in-dialog NOTIFY as per RFC 6665.
+   } else if ( is_method("NOTIFY|REFER") ) {
+   # Add Record-Route for in-dialog NOTIFY and REFER 
(RFC6665, RFC3515)
record_route();
}
route(RELAY);

___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!


[sr-dev] git:master:09d1ba87: core: add rport to generated replies after first via branch when no incoming rport

2025-01-21 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio
Branch: master
Commit: 09d1ba87f4d37c3e13153229c63698f09ca195bc
URL: 
https://github.com/kamailio/kamailio/commit/09d1ba87f4d37c3e13153229c63698f09ca195bc

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2025-01-21T19:45:20+01:00

core: add rport to generated replies after first via branch when no incoming 
rport

---

Modified: src/core/msg_translator.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/09d1ba87f4d37c3e13153229c63698f09ca195bc.diff
Patch: 
https://github.com/kamailio/kamailio/commit/09d1ba87f4d37c3e13153229c63698f09ca195bc.patch

---

diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c
index 8924e8a2609..50e867804be 100644
--- a/src/core/msg_translator.c
+++ b/src/core/msg_translator.c
@@ -2683,6 +2683,22 @@ char *build_res_buf_from_sip_req(unsigned int code, str 
*text, str *new_tag,

- msg->via1->rport->start

- msg->via1->rport->size,
msg);
+   } else if(msg->via1->branch) { 
/* add after branch */
+   /* copy until after 
branch */
+   append_str_trans(p, 
hdr->name.s,
+   
msg->via1->branch->start - hdr->name.s
+   
+ msg->via1->branch->size,
+   msg);
+   /* copy new rport */
+   append_str(p, 
rport_buf, rport_len);
+   /* copy the rest of the 
via */
+   append_str_trans(p,
+   
msg->via1->branch->start
+   
+ msg->via1->branch->size,
+   
hdr->body.s + hdr->body.len
+   
- msg->via1->branch->start
+   
- msg->via1->branch->size,
+   msg);
} else { /* just append the new 
one */
/* normal whole via 
copy */
append_str_trans(p, 
hdr->name.s,

___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!


[sr-dev] Re: [kamailio/kamailio] cmake: switching deb rules (Issue #4053)

2025-01-21 Thread Victor Seva via sr-dev
```
Setting up libphonenumber8:amd64 (8.13.51+ds-4) ...  
```

```
CMake Error at 
/usr/lib/x86_64-linux-gnu/cmake/libphonenumber/libphonenumber-targets.cmake:118 
(message):
  The imported target "libphonenumber::phonenumber" references the file

 "/usr/lib/x86_64-linux-gnu/libphonenumber.a"

  but this file does not exist.  Possible reasons include:

  * The file was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and contained

 
"/usr/lib/x86_64-linux-gnu/cmake/libphonenumber/libphonenumber-targets.cmake"

  but not all the files it references.

Call Stack (most recent call first):
  /usr/lib/x86_64-linux-gnu/cmake/libphonenumber/libphonenumber-config.cmake:42 
(include)
  src/modules/phonenum/CMakeLists.txt:6 (find_package)


-- Configuring incomplete, errors occurred!
```

```
unstable-amd64-sbuild)root@debrock:/build/kamailio-bufF3L# dpkg -L 
libphonenumber8
/.
/usr
/usr/lib
/usr/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu/libphonenumber.so.8.13
/usr/share
/usr/share/doc
/usr/share/doc/libphonenumber8
/usr/share/doc/libphonenumber8/changelog.Debian.gz
/usr/share/doc/libphonenumber8/copyright
/usr/lib/x86_64-linux-gnu/libphonenumber.so.8
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4053#issuecomment-2605493678
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!


[sr-dev] Re: [kamailio/kamailio] multiple Makefiles: evaluate LIBS variable imediately in Makefile (PR #4085)

2025-01-21 Thread Xenofon Karamanos via sr-dev
> We have implemented kamailio_docs_readme target 
> https://github.com/kamailio/kamailio/pull/4085#issuecomment-2577661883. My 
> expectation do not trigger xslt transformation and just rebuild the modules 
> readme file.

This target will build the readmes from scratch and replace all readme files 
found in the source trees. If you want only to install them, `install` target 
will pick the READMEs found in the source tree, or build the target 
`install_kamailio_docs`.


> gmake[3]: *** No rule to make target 
> '/root/rpmbuild/BUILD/kamailio-6.0.0-build/kamailio-6.0.0-pre0/src/modules/ims_qos_npn/doc/ims_qos_npn.xml',
>  needed by 'src/modules/ims_qos_npn/ims_qos_npn.txt'.  Stop.

The error is here. It seems that the `xml` file in `ims_qos_npn` modules is 
named `ims_qos.xml` instead of `ims_qos_npn.xml`. Try changing it to the module 
name and try again!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4085#issuecomment-2604553784
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!


[sr-dev] Re: [kamailio/kamailio] multiple Makefiles: evaluate LIBS variable imediately in Makefile (PR #4085)

2025-01-21 Thread Henning Westerholt via sr-dev
@sergey-safarov ims_qos_npn doc building should be fixed after c994fb8d39

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4085#issuecomment-2604595024
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!


[sr-dev] git:master:c994fb8d: ims_qos_npn: fix documentation XML names, it was not adapted after the copy from ims_qos

2025-01-21 Thread Henning Westerholt via sr-dev
Module: kamailio
Branch: master
Commit: c994fb8d3906f2199d61302882f3836aa83dd6bb
URL: 
https://github.com/kamailio/kamailio/commit/c994fb8d3906f2199d61302882f3836aa83dd6bb

Author: Henning Westerholt 
Committer: Henning Westerholt 
Date: 2025-01-21T12:23:49Z

ims_qos_npn: fix documentation XML names, it was not adapted after the copy 
from ims_qos

---

Added: src/modules/ims_qos_npn/doc/ims_qos_npn.xml
Added: src/modules/ims_qos_npn/doc/ims_qos_npn_admin.xml
Removed: src/modules/ims_qos_npn/doc/ims_qos.xml
Removed: src/modules/ims_qos_npn/doc/ims_qos_admin.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/c994fb8d3906f2199d61302882f3836aa83dd6bb.diff
Patch: 
https://github.com/kamailio/kamailio/commit/c994fb8d3906f2199d61302882f3836aa83dd6bb.patch

---

diff --git a/src/modules/ims_qos_npn/doc/ims_qos.xml 
b/src/modules/ims_qos_npn/doc/ims_qos_npn.xml
similarity index 98%
rename from src/modules/ims_qos_npn/doc/ims_qos.xml
rename to src/modules/ims_qos_npn/doc/ims_qos_npn.xml
index c1a88ad94fe..0cd99dcd0c7 100644
--- a/src/modules/ims_qos_npn/doc/ims_qos.xml
+++ b/src/modules/ims_qos_npn/doc/ims_qos_npn.xml
@@ -108,6 +108,6 @@
 
   
 
-  http://www.w3.org/2001/XInclude"/>
 
diff --git a/src/modules/ims_qos_npn/doc/ims_qos_admin.xml 
b/src/modules/ims_qos_npn/doc/ims_qos_npn_admin.xml
similarity index 100%
rename from src/modules/ims_qos_npn/doc/ims_qos_admin.xml
rename to src/modules/ims_qos_npn/doc/ims_qos_npn_admin.xml

___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!


[sr-dev] git:master:13d306dd: cmake: Fix FindBerkeleyDB to correct lib name.

2025-01-21 Thread Xenofon Karamanos via sr-dev
Module: kamailio
Branch: master
Commit: 13d306dd97989162bf716fa23342608bce037b9b
URL: 
https://github.com/kamailio/kamailio/commit/13d306dd97989162bf716fa23342608bce037b9b

Author: Xenofon Karamanos 
Committer: Xenofon Karamanos 
Date: 2025-01-21T10:29:55Z

cmake: Fix FindBerkeleyDB to correct lib name.

- CMake lint
- Search only C version

---

Modified: cmake/modules/FindBerkeleyDB.cmake

---

Diff:  
https://github.com/kamailio/kamailio/commit/13d306dd97989162bf716fa23342608bce037b9b.diff
Patch: 
https://github.com/kamailio/kamailio/commit/13d306dd97989162bf716fa23342608bce037b9b.patch

___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!


[sr-dev] Re: [kamailio/kamailio] cmake: switching deb rules (Issue #4053)

2025-01-21 Thread Xenofon Karamanos via sr-dev
After 13d306dd97989162bf716fa23342608bce037b9b, `BerkeleyDB` should be found 
correctly!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4053#issuecomment-2604331139
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!


[sr-dev] Re: [kamailio/kamailio] Memory usage increases everytime tls.reload is executed (Issue #3823)

2025-01-21 Thread github-actions[bot] via sr-dev
This issue is stale because it has been open 6 weeks with no activity. Remove 
stale label or comment or this will be closed in 2 weeks.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3823#issuecomment-2606177532
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!