Re: [openstreetmap/openstreetmap-website] Login screen for OAuth 2 authorization shows "sign up" tab that triggers googles android policy violation bot (Issue #5118)
> But what's the solution? I'm certainly not interested in removing the account > creation option because we want people to be able to signup! I was assuming a solution along Antons suggestion, aka adding an option to the app configuration that gets passed to the signup page, and if it is set not displaying the signup bits and pieces. > > Is the answer that clients shouldn't be trying to embed the oauth flow in the > app and should be letting it go through a web browser? or would that still be > a problem for google's rules? I would be very surprised if that was considered anything else than "in app" (there's no way to ask google outside of submitting an update that implements that, so kind of a no from my pov to investigate that). > Surely we can't be the only people to have this problem... Like every app > that authenticates to a web service must encounter this? Well, you need a combination of - having a signup flow reachable from the same screen as the authorisation flow login - the app not being provided by the operator of the target service and therefore assuming liability for the deletion process being iffy, - updating the app often enough that by chance a reviewer notices the "issue" (as I pointed out, there was always a link so this should have already raised a flag last year when google introduced the policy). -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5118#issuecomment-2372027262 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Login screen for OAuth 2 authorization shows "sign up" tab that triggers googles android policy violation bot (Issue #5118)
> I haven't seen other projects with similar requirements. The reason for that is likely that a lot of them don't actually render the HTML of the login/permissions screens and fake things. Highly problematic from a legal pov, but that is something that I've long given up on being concerned about, if the OSMF doesn't care, why should I? But from a purely software dev position a less brittle solution would be preferable (and that should be in the interest of the devs here too), so I would leave this open for now, I'll probably have time in Q4 to get something working. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5118#issuecomment-2371942874 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] "Edit" menu shown on (small format) mobile devices largely non-functional (Issue #5326)
> edit on mobile version is a great idea, but it does not really make sense > without links to mobile editors It doesn't really need links, the JOSM RC interface is trivial to implement for any Android app, it is just an issue with the way the rails-ports generates the URL. See https://github.com/openstreetmap/openstreetmap-website/pull/1478 PS: I'm not naive enough to assume that this will happen in any form, naturally everybody will want their own link for marketing purposes. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5326#issuecomment-2488576852 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] "Edit" menu shown on (small format) mobile devices largely non-functional (Issue #5326)
> Would #1478 work also when user has no got any relevant app installed yet? As is no, but you could show a popup or similar if nothing was installed (just as it now asks you to start JOSM on desktop), potentially you could offer to directly install an app, but that all gets kind of complicated in more than one way. The good thing is that you wouldn't have to explicitly start the app once installed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5326#issuecomment-2488683825 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] "Edit" menu shown on (small format) mobile devices largely non-functional (Issue #5326)
### URL _No response_ ### How to reproduce the issue? Use phone to connect to openstreetmap.org ### Screenshot(s) or anything else? On phone the edit button is now displayed, while it works for iD (if it is useful is a matter of debate), JOSM RC will not work as is. See https://github.com/openstreetmap/openstreetmap-website/pull/1478 I suspect this is a regression or at least an unintentional change. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5326 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] "Edit" menu shown on (small format) mobile devices largely non-functional (Issue #5326)
>From the button not being displayed... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5326#issuecomment-2478751692 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Proposal for adding support for map notes tags (Issue #5294)
No, I don't think that would be an appropriate model. Just as comments extend the conversation around the original note and do not replace it, tags associated with comments should not replace the original ones. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5294#issuecomment-2479130554 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Proposal for adding support for map notes tags (Issue #5294)
It isn't clear from the description, but to be really useful (for example to document with which client an operation is being performed) they need to be "per interaction" so not just for the original note creation but at least for every comment, and maybe for opening and closing too. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5294#issuecomment-2478785788 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] add "edit" button to mobile version (#2233)
I would end on noting that the button does nothing or after while causes an error for everybody that doesn't have iD selected as default. At least remove the drop down and only start iD as long as the other issues are not resolved. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2233#issuecomment-2510787078 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)
> @simonpoole This is not something you should worry about because it will take > one `if` statement to remove the entire thing unlike let's say feeds. Oh, I'm not concerned at all. I was just pointing this out for good form, aka I saw something that I know is wrong, and I'm giving the people here a fighting chance to do the right thing. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2603905668 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)
Nice ... but, sorry to be a spoil sport here, this changes the information available on the user page significantly, the likely solution would be to make it available only to logged in users. Both the LWG and EWG should be informed and https://wiki.openstreetmap.org/wiki/GDPR/Affected_Services#User_page_(done) updated to reflect the additional feature. PS: I'm not quite sure why the user page item is marked as done, when it obviously isn't, but that is OT. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2602166082 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Remove public domain checkbox from signup and terms pages (PR #5514)
You shouldn't be expending any effort on retaining the PD checkbox imho. It has no practical meaning and should have been removed years ago. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5514#issuecomment-2619926364 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] dead link in /copyright (Issue #3998)
simonpoole left a comment (openstreetmap/openstreetmap-website#3998) Just so that it doesn't get lost: The complication is that AND allowed us to import their data on the terms of a licence that is incompatible with the ODbL. So back in ~2012, that is pre-licence change, the LWG reached out to AND and got permission to retain the data. The terms agreed on then is what is relevant, and I suspect Michael Collinson or the LWG minutes from 2011-12 to be the best source on what they actually were. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/3998#issuecomment-2757070025 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)
simonpoole left a comment (openstreetmap/openstreetmap-website#5804) > I would argue that by signing up to the project it's your intent to make your > edits public - building a public data set is the entire point of the project > after all but what do I know. It is rather pointless to try to re-litigate something that was discussed to death 7 years ago. But that is exactly the point, users expect that the geodata that they created or edited to be public, not for example their sleeping habits. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5804#issuecomment-2726472629 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)
simonpoole left a comment (openstreetmap/openstreetmap-website#5804) As this issue is likely to attract a lot of traffic, here's the link to the wiki page with a number of resources on the topic https://wiki.openstreetmap.org/wiki/GDPR , the paper linked there goes over the arguments for the solution that was chosen. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5804#issuecomment-2726478529 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)
simonpoole left a comment (openstreetmap/openstreetmap-website#5804) The OSMF privacy policy guarantees that contribution meta data will only be shown to logged in users https://osmfoundation.org/wiki/Privacy_Policy#Who_has_access_to_the_data (yes, the OSMF violates this all over the place, but that doesn't give anybody a free get out of jail card to add to those violations). So either the privacy policy needs to be changed, iffy because this changes the basic tenants it is built on and not a question that is of a technical nature, or the feature needs to only available to logged in users as I pointed out in the relevant PR back in January. Making the feature configurable is a good idea in any case, heck even Microsoft (github) does that. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5804#issuecomment-2726403892 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)
simonpoole left a comment (openstreetmap/openstreetmap-website#5804) See https://wiki.openstreetmap.org/wiki/GDPR/Affected_Services iirc at the time it was assumed that the the the user page would only contain content that the user had added with the intent of making it public, see https://osmfoundation.org/wiki/Privacy_Policy#Data_you_may_voluntarily_add_to_your_profile_or_diary_posts -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5804#issuecomment-2726466030 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)
simonpoole left a comment (openstreetmap/openstreetmap-website#5804) > And this page says that metadata should be shown only to those who accepted > the terms of use: The discrepancy is due to you still being able to login even though you haven't agreed to the ToS if you have an account pre-dating the introduction of the terms. The OSMF board simply never did its job to communicate that this would have to change and set a date for the change (for a while I sent the board regular reminders that this was still pending, now days I can't be bothered). It was always envisioned that this would be fixed before the API and data access changes going active. With other words while the language in the privacy policy is technically not quite correct, at the time the assumption was this would just be a short blip. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5804#issuecomment-2726718912 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] What is the license of the images on the OSM website? (Issue #5966)
simonpoole left a comment (openstreetmap/openstreetmap-website#5966) > It happens with some map style repositories, such as .. But not if they are GPL 2.0 licensed (which is the reason for this discussion). -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5966#issuecomment-2845178953 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Adds note versions and variable note tags (PR #5904)
simonpoole left a comment (openstreetmap/openstreetmap-website#5904) > 1. for keeping note versions like it is done for other elements (nodes, ways > and relations) I continue to think that this is not a good idea, for starters notes are _not_ like or even the same class of entity as OSM elements. Then in the current model, if you so want, notes are ledger-like (think block-chain), you are adding entries to a sequential list with immutable entries, versions literally don't fit in to such a model, nor is there even any kind of indication why we would need versions and what they would be useful for. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5904#issuecomment-2854620250 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenLocationCode to OSM website (#1807)
simonpoole left a comment (openstreetmap/openstreetmap-website#1807) May I point out that modifying geo URIs to support anything else that WGS84 coordinates is not, lets say, a great idea. It would change a single, easy to support, universally the same URI format, in to something for which you have no idea of if the consuming application will actually support it or not. The case of using OLCs adds a notch of silliness to that as the decoded OLC data would _just _work_ in a regular geo: URI. I would note that the geo URI specification does actually provide for a different CRS, but it doesn't make any sense to exercise that. It's a not totally unreasonable _make things easy_ change to support geo: URI as input to the search box simply as an alternative way to input coordinates without having to copy them out of the URI, however that is a bit off topic here (I added support for that in Vespucci a while back https://github.com/MarcusWolschon/osmeditor4android/pull/2758). -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1807#issuecomment-2868673481 You are receiving this because you commented. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Intermittent CORS issues with editing API (Issue #6028)
simonpoole left a comment (openstreetmap/openstreetmap-website#6028) > is routed through njy-newark That explains everything: they are taking a leaf out of the book of the FAA. Sorry sometimes some comic relief is necessary :-) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6028#issuecomment-2918389507 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
