Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2025-01-03 Thread David Tsiklauri via rails-dev 
@nertc pushed 1 commit.

777eb643422fcd5267c647b388e14144e8f5fe09  Add profile location

-- 
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/aac929d79e91cb554655a60b1a2cc81a364d6d7f..777eb643422fcd5267c647b388e14144e8f5fe09
You are receiving this because you are subscribed to this thread.

Message ID: 

___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2025-01-03 Thread David Tsiklauri via rails-dev 
@nertc pushed 1 commit.

defb24f00bf08f00b778c0270b9887502b48a340  Add profile location

-- 
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/77e3f39bdf29c9a41475e1ea1347560add9c65d3..defb24f00bf08f00b778c0270b9887502b48a340
You are receiving this because you are subscribed to this thread.

Message ID: 

___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Use resourceful route for message reply (PR #5458)

2025-01-03 Thread Tom Hughes via rails-dev 
Merged #5458 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5458#event-15810360896
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Remove "expired unread" short block status (PR #5454)

2025-01-03 Thread Tom Hughes via rails-dev 
Merged #5454 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5454#event-15810360868
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Use resourceful route for message reply (PR #5458)

2025-01-03 Thread Tom Hughes via rails-dev 
@tomhughes approved this pull request.

Looks good now, thanks.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5458#pullrequestreview-2529603446
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Remove "expired unread" short block status (PR #5454)

2025-01-03 Thread Tom Hughes via rails-dev 
@tomhughes approved this pull request.

Looks good now, thanks.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5454#pullrequestreview-2529595329
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Use resourceful route for message reply (PR #5458)

2025-01-03 Thread Anton Khorev via rails-dev 
Updated for compatibility with #5457.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5458#issuecomment-2568838728
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Remove "expired unread" short block status (PR #5454)

2025-01-03 Thread Anton Khorev via rails-dev 
@AntonKhorev pushed 1 commit.

f7b0e879739770ae4a9d9de4f012ef90d49d4d20  Remove "expired unread" short block 
status

-- 
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5454/files/4df7f2c8e546b346e3a2cf0b213b478e107e2ebc..f7b0e879739770ae4a9d9de4f012ef90d49d4d20
You are receiving this because you are subscribed to this thread.

Message ID: 

___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Convert Auth.providers into array (PR #5460)

2025-01-03 Thread Tom Hughes via rails-dev 
Merged #5460 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5460#event-15810423658
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Rename Account module to Accounts (PR #5461)

2025-01-03 Thread Tom Hughes via rails-dev 
Merged #5461 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5461#event-15810423656
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Rename Account module to Accounts (PR #5461)

2025-01-03 Thread Tom Hughes via rails-dev 
@tomhughes approved this pull request.

Looks good to me, thanks.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5461#pullrequestreview-2529613914
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Convert Auth.providers into array (PR #5460)

2025-01-03 Thread Tom Hughes via rails-dev 
@tomhughes approved this pull request.

Looks good to me, thanks.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5460#pullrequestreview-2529609182
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Use resourceful route for message reply (PR #5458)

2025-01-03 Thread Anton Khorev via rails-dev 
@AntonKhorev pushed 1 commit.

0016c6f4b12356fd6174906dac3c240cdf572650  Use resourceful route for message 
reply

-- 
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5458/files/4bd95493b169dadfcebe45364ecbf156a76f9a9e..0016c6f4b12356fd6174906dac3c240cdf572650
You are receiving this because you are subscribed to this thread.

Message ID: 

___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Remove "expired unread" short block status (PR #5454)

2025-01-03 Thread Anton Khorev via rails-dev 
@AntonKhorev commented on this pull request.



> @@ -27,14 +27,10 @@ def block_status(block)
 
   def block_short_status(block)
 if block.active?
-  if block.needs_view?
-if block.ends_at > Time.now.utc
-  t("user_blocks.helper.short.active_unread")
-else
-  t("user_blocks.helper.short.expired_unread")
-end
-  else
+  if block.ends_at > Time.now.utc || block.deactivates_at

I was thinking what to output in case we're between `ends_at` and 
`deactivates_at` because it's allowed by validations. But since it's currently 
impossible to get such `deactivates_at`, let's remove it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5454#discussion_r1901572410
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

[openstreetmap/openstreetmap-website] Use resourceful routes for user new/create actions (PR #5459)

2025-01-03 Thread Anton Khorev via rails-dev 
User create action is moved from `POST /user/new` to `POST /user`.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5459

-- Commit Summary --

  * Use resourceful routes for user new/create actions

-- File Changes --

M app/views/layouts/_header.html.erb (2)
M app/views/layouts/map.html.erb (2)
M app/views/notes/new.html.erb (2)
M app/views/site/fixthemap.html.erb (2)
M config/routes.rb (4)
M test/controllers/confirmations_controller_test.rb (26)
M test/controllers/users_controller_test.rb (46)
M test/integration/user_creation_test.rb (38)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5459.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5459.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5459
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

[openstreetmap/openstreetmap-website] Convert Auth.providers into array (PR #5460)

2025-01-03 Thread Anton Khorev via rails-dev 
There's `Auth` module that lists currently enabled auth providers. It's 
used in two different places: auth providers template for login/signup pages 
and account edit page.

What the module actually does is it prepares options for `