@AntonKhorev commented on this pull request.
> @@ -27,14 +27,10 @@ def block_status(block)
def block_short_status(block)
if block.active?
- if block.needs_view?
- if block.ends_at > Time.now.utc
- t("user_blocks.helper.short.active_unread")
- else
- t("user_blocks.helper.short.expired_unread")
- end
- else
+ if block.ends_at > Time.now.utc || block.deactivates_at
I was thinking what to output in case we're between `ends_at` and
`deactivates_at` because it's allowed by validations. But since it's currently
impossible to get such `deactivates_at`, let's remove it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5454#discussion_r1901572410
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5454/review/2528722...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
