date:20180128

[issue32690] Return function locals() in order of creation?

2018-01-28 Thread Raymond Hettinger


Change by Raymond Hettinger :


--
keywords: +patch
pull_requests: +5220
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32687] wrong meaning of arg in Py_tracefunc doc

2018-01-28 Thread Xiang Zhang


Xiang Zhang  added the comment:


New changeset 854f0424de389f023b375dfd0b50c34dea29e8f8 by Xiang Zhang (Miss 
Islington (bot)) in branch '3.6':
bpo-32687: Fix wrong meaning of args for PyTrace_LINE/CALL in documentation 
(GH-5361) (GH-5377)
https://github.com/python/cpython/commit/854f0424de389f023b375dfd0b50c34dea29e8f8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32687] wrong meaning of arg in Py_tracefunc doc

2018-01-28 Thread Xiang Zhang


Xiang Zhang  added the comment:


New changeset 745e9de7dd9d237d54e92d6e4b469e916fb0352b by Xiang Zhang (Miss 
Islington (bot)) in branch '2.7':
bpo-32687: Fix wrong meaning of args for PyTrace_LINE/CALL in documentation 
(GH-5361) (GH-5378)
https://github.com/python/cpython/commit/745e9de7dd9d237d54e92d6e4b469e916fb0352b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32687] wrong meaning of arg in Py_tracefunc doc

2018-01-28 Thread Xiang Zhang


Change by Xiang Zhang :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32692] test_threading.test_set_and_clear fails in AppVeyor CI

2018-01-28 Thread Xiang Zhang


New submission from Xiang Zhang :

test_threading.test_set_and_clear fails in AppVeyor CI. But seems it not stable 
since rerun succeeds. See 
https://ci.appveyor.com/project/python/cpython/build/3.6build11314/job/ussor83yaglx5whb.

FAIL: test_set_and_clear (test.test_threading.EventTests)
--
Traceback (most recent call last):
  File "C:\projects\cpython\lib\test\lock_tests.py", line 407, in 
test_set_and_clear
self.assertEqual(results, [True] * N)
AssertionError: Lists differ: [False, False, False, True, True] != [True, True, 
True, True, True]
First differing element 0:
False
True
- [False, False, False, True, True]
+ [True, True, True, True, True]

--
components: Tests
messages: 310930
nosy: xiang.zhang
priority: normal
severity: normal
status: open
title: test_threading.test_set_and_clear fails in AppVeyor CI
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32649] complete C API doc debug and profile part with new PyTrace_OPCODE

2018-01-28 Thread Nick Coghlan


Nick Coghlan  added the comment:


New changeset 255f7a26da47ca6b7bd1d375b8a04920f68c119c by Nick Coghlan (Xiang 
Zhang) in branch 'master':
bpo-32649: Add C API docs for per-opcode tracing & profiling (GH-5360)
https://github.com/python/cpython/commit/255f7a26da47ca6b7bd1d375b8a04920f68c119c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32649] complete C API doc debug and profile part with new PyTrace_OPCODE

2018-01-28 Thread Nick Coghlan


Nick Coghlan  added the comment:

Merged, thanks!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32690] Return function locals() in order of creation?

2018-01-28 Thread David Beazley


David Beazley  added the comment:

Some context:  I noticed this while discussing (in a course) a programming 
trick involving instance initialization and locals() that I'd encountered in 
the past:

def _init(locs):
self = locs.pop('self')
for name, val in locs.items():
setattr(self, name, val)

class Spam:
def __init__(self, a, b, c, d):
_init(locals())

In looking at locals(), it was coming back in reverse order of method arguments 
(d, c, b, a, self).   To be honest, it wasn't a critical matter, but more of an 
odd curiosity in light of recent dictionary ordering.

I could imagine writing a slightly more general version of _init() that didn't 
depend on a named 'self' argument if order was preserved:

def _init(locs):
   items = list(locs.items())
   _, self = items[0]
   for name, val in items[1:]:
   setattr(self, name, val)

Personally, I don't think the issue Nathaniel brings up is worth worrying about 
because it would be such a weird edge case on something that is already an edge 
case.  Returning variables in "lexical order"--meaning the order in which first 
encountered in the source seems pretty sensible to me.

--
nosy: +dabeaz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32685] Erroneous suggestion in print statement

2018-01-28 Thread Nick Coghlan


Nick Coghlan  added the comment:


New changeset 43c0f1ac5ed8bc9c3bd048d2ce4de4c98a83de99 by Nick Coghlan (Nitish 
Chandra) in branch 'master':
bpo-32685: Improve suggestion for print statement (GH-5375)
https://github.com/python/cpython/commit/43c0f1ac5ed8bc9c3bd048d2ce4de4c98a83de99


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32685] Erroneous suggestion in print statement

2018-01-28 Thread Nick Coghlan


Change by Nick Coghlan :


--
stage: patch review -> backport needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32685] Erroneous suggestion in print statement

2018-01-28 Thread miss-islington


Change by miss-islington :


--
pull_requests: +5221
stage: backport needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29120] Move hash randomisation initialisation out of Python/random.c

2018-01-28 Thread Nick Coghlan


Nick Coghlan  added the comment:

Aye, but the reason they're here rather than in the os module where you might 
otherwise expect to find them is because the hash randomization bootstrapping 
needs them.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32693] os.path.ismount does not accept bytes objects

2018-01-28 Thread Nikolay Aleksandrovich Pavlov

New submission from Nikolay Aleksandrovich Pavlov :

According to the documentation it ought to accept any path-like object, but
actually throws for bytes ones. The trace of logic is the following:

1. ismount() from Lib/ntpath.py is using `os.fpath` which may return either
bytes or str:
https://github.com/python/cpython/blob/255f7a26da47ca6b7bd1d375b8a04920f68c119c/Lib/ntpath.py#L263.
2. The output is passed to _getvolumepathname unchanged.
3. The clinic defines that function’s only argument as
[unicode](https://github.com/python/cpython/blob/255f7a26da47ca6b7bd1d375b8a04920f68c119c/Modules/posixmodule.c#L3793).
4. If clinic was not there it would still require to change how path_wchar is
defined below, PyUnicode… functions will not accept bytes object:
https://github.com/python/cpython/blob/255f7a26da47ca6b7bd1d375b8a04920f68c119c/Modules/posixmodule.c#L3808.

Suggestion: change `Lib/ntpath.py` to use `os.fsdecode` in place of `os.fspath`.

This is a relay of issue https://github.com/powerline/powerline/issues/1876.
Initial reporter observed bug on Python 3.6 (patch unknown), I could see an
issue in current master (all links above point to that).

--
components: Windows
messages: 310936
nosy: Nikolay Aleksandrovich Pavlov, paul.moore, steve.dower, tim.golden,
zach.ware
priority: normal
severity: normal
status: open
title: os.path.ismount does not accept bytes objects
type: behavior
versions: Python 3.6, Python 3.7

___
Python tracker

___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32685] Erroneous suggestion in print statement

2018-01-28 Thread Nick Coghlan


Nick Coghlan  added the comment:


New changeset b3b4b81d0147534151941105eba4af984acdc763 by Nick Coghlan (Miss 
Islington (bot)) in branch '3.6':
bpo-32685: Improve suggestion for print statement (GH-5380)
https://github.com/python/cpython/commit/b3b4b81d0147534151941105eba4af984acdc763


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32685] Erroneous suggestion in print statement

2018-01-28 Thread Nick Coghlan


Nick Coghlan  added the comment:

Thanks for the patches, Sanyam & Nitish, and for the original bug report Mayank.

Thanks also to Cheryl for nudging us to get it resolved :)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1692335] Fix exception pickling: Move initial args assignment to BaseException.new

2018-01-28 Thread Ofer


Ofer  added the comment:

Perhaps this is a problem for a different issue, but pickling custom exceptions 
fails when the exception gets more than one argument:

import pickle
class MultipleArgumentsError(Exception):
def __init__(self, a, b):
self.a = a
self.b = b
Exception.__init__(self, a)

pickle.loads(pickle.dumps(MultipleArgumentsError('a', 'b')))


this code produces the following error:

Traceback (most recent call last):
  File "/tmp/multiple_arguments_exception.py", line 8, in 
pickle.loads(pickle.dumps(MultipleArgumentsError('a', 'b')))
  File 
"/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/pickle.py",
 line 1388, in loads
return Unpickler(file).load()
  File 
"/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/pickle.py",
 line 864, in load
dispatch[key](self)
  File 
"/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/pickle.py",
 line 1139, in load_reduce
value = func(*args)
TypeError: __init__() takes exactly 3 arguments (2 given)

--
nosy: +slallum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31900] localeconv() should decode numeric fields from LC_NUMERIC encoding, not from LC_CTYPE encoding

2018-01-28 Thread Andreas Schwab


Andreas Schwab  added the comment:

> The technical issue here is that the libc has no "stateless" function to 
> process bytes and text with one specific locale.

That's not true.  There is a rich set of *_l functions that take a locale_t 
object and operate on that locale.

--
nosy: +schwab

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32545] Unable to install Python 3.7.0a4 on Windows 10 - Error 0x80070643: Failed to install MSI package.

2018-01-28 Thread Steve Dower


Steve Dower  added the comment:

>From the log file, all I can tell is that it failed to open the file 
>containing information about ongoing installs. At a guess, another install was 
>running (maybe failed?) and didn't clean up properly.

Rebooting should generally resolve that. If it doesn't, you're either looking 
at serious OS corruption (worth testing if any other MSI installers work - 
Anaconda does not use MSI) or disk corruption.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32611] Tkinter taskbar icon (Windows)

2018-01-28 Thread Steve Dower


Steve Dower  added the comment:

To fix this, we need to make Idle its own .exe file with an AppId and properly 
registered icon. Right now, it's just a .pyw file running in Python, and so 
things like pinning icons or file associations won't work cleanly.

--
type: behavior -> enhancement
versions: +Python 3.8 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17305] IDNA2008 encoding missing

2018-01-28 Thread Christian Heimes


Christian Heimes  added the comment:

A fix will land in 3.7 and maybe get backported to 3.6. Stay tuned!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32686] python3.6.4 build with --enable-optimzations hangs on macOS 10.13

2018-01-28 Thread 7stud


7stud <7s...@excite.com> added the comment:

Hi Ned Deily,

Thanks for the suggestion.  I ran ./configure again, but this time make errored 
out:


...
...
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [python.exe] Error 1

So I deleted the Python3.6.4 directory:

$ rm -rf Python-3.6.4

and I started over:

~/Downloads$ tar xfvz Python-3.6.4.tgz 

Then I ran ./configure, then make, and this time make completed successfully.

Howevernext up was make test, and after letting make test run for two 
hours, I killed it:

...
...
running: test_asyncio (56 sec)
running: test_asyncio (86 sec)
running: test_asyncio (116 sec)
running: test_asyncio (146 sec)
running: test_asyncio (176 sec)
running: test_asyncio (206 sec)
running: test_asyncio (236 sec)
running: test_asyncio (266 sec)
running: test_asyncio (296 sec)
running: test_asyncio (326 sec)
running: test_asyncio (356 sec)
running: test_asyncio (386 sec)
running: test_asyncio (416 sec)
running: test_asyncio (446 sec)
running: test_asyncio (476 sec)
running: test_asyncio (506 sec)
running: test_asyncio (536 sec)
running: test_asyncio (566 sec)
running: test_asyncio (596 sec)
running: test_asyncio (626 sec)
running: test_asyncio (656 sec)
running: test_asyncio (686 sec)
running: test_asyncio (716 sec)
running: test_asyncio (746 sec)
running: test_asyncio (776 sec)
running: test_asyncio (806 sec)
running: test_asyncio (836 sec)
running: test_asyncio (866 sec)
running: test_asyncio (896 sec)
running: test_asyncio (926 sec)
running: test_asyncio (956 sec)
running: test_asyncio (986 sec)
running: test_asyncio (1016 sec)
running: test_asyncio (1046 sec)
running: test_asyncio (1076 sec)
running: test_asyncio (1106 sec)
running: test_asyncio (1136 sec)
running: test_asyncio (1166 sec)
running: test_asyncio (1196 sec)
running: test_asyncio (1226 sec)
running: test_asyncio (1256 sec)
running: test_asyncio (1286 sec)
running: test_asyncio (1316 sec)
running: test_asyncio (1346 sec)
running: test_asyncio (1376 sec)
running: test_asyncio (1406 sec)
running: test_asyncio (1436 sec)
running: test_asyncio (1466 sec)
running: test_asyncio (1496 sec)
running: test_asyncio (1526 sec)
running: test_asyncio (1556 sec)
running: test_asyncio (1586 sec)
running: test_asyncio (1616 sec)
running: test_asyncio (1646 sec)
running: test_asyncio (1676 sec)
running: test_asyncio (1706 sec)
running: test_asyncio (1736 sec)
running: test_asyncio (1766 sec)
running: test_asyncio (1796 sec)
running: test_asyncio (1826 sec)
running: test_asyncio (1856 sec)
running: test_asyncio (1886 sec)
running: test_asyncio (1916 sec)
running: test_asyncio (1946 sec)
running: test_asyncio (1976 sec)
running: test_asyncio (2006 sec)
running: test_asyncio (2036 sec)
running: test_asyncio (2066 sec)
running: test_asyncio (2096 sec)
running: test_asyncio (2126 sec)
running: test_asyncio (2156 sec)
running: test_asyncio (2186 sec)
running: test_asyncio (2216 sec)
running: test_asyncio (2246 sec)
running: test_asyncio (2276 sec)
running: test_asyncio (2306 sec)
running: test_asyncio (2336 sec)
running: test_asyncio (2366 sec)
running: test_asyncio (2396 sec)
running: test_asyncio (2426 sec)
running: test_asyncio (2456 sec)
running: test_asyncio (2486 sec)
running: test_asyncio (2516 sec)
running: test_asyncio (2546 sec)
running: test_asyncio (2576 sec)
running: test_asyncio (2606 sec)
running: test_asyncio (2636 sec)
running: test_asyncio (2666 sec)
running: test_asyncio (2696 sec)
running: test_asyncio (2726 sec)
running: test_asyncio (2756 sec)
running: test_asyncio (2786 sec)
running: test_asyncio (2816 sec)
running: test_asyncio (2846 sec)
running: test_asyncio (2876 sec)
running: test_asyncio (2906 sec)
running: test_asyncio (2936 sec)
running: test_asyncio (2966 sec)
running: test_asyncio (2996 sec)
running: test_asyncio (3026 sec)
running: test_asyncio (3056 sec)
running: test_asyncio (3086 sec)
running: test_asyncio (3116 sec)
running: test_asyncio (3146 sec)
running: test_asyncio (3176 sec)
running: test_asyncio (3206 sec)
running: test_asyncio (3236 sec)
running: test_asyncio (3266 sec)
running: test_asyncio (3296 sec)
running: test_asyncio (3326 sec)
running: test_asyncio (3356 sec)
running: test_asyncio (3386 sec)
running: test_asyncio (3416 sec)
running: test_asyncio (3446 sec)
running: test_asyncio (3476 sec)
running: test_asyncio (3506 sec)
running: test_asyncio (3536 sec)
running: test_asyncio (3566 sec)
running: test_asyncio (3596 sec)
running: test_asyncio (3626 sec)
running: test_asyncio (3656 sec)
running: test_asyncio (3686 sec)
running: test_asyncio (3716 sec)
running: test_asyncio (3746 sec)
running: test_asyncio (3776 sec)
running: test_asyncio (3806 sec)
running: test_asyncio (3836 sec)
running: test_asyncio (3866 sec)
running: test_asyncio (3896 sec)
running: test_asyncio (3926 sec)
running: test_asyncio (3956 sec)
running: test_asyncio (3986 sec)
running: test_asyncio (4016 sec)
running: test_asyn

[issue32659] Solaris "stat" should support "st_fstype"

2018-01-28 Thread Jesús Cea Avión


Jesús Cea Avión  added the comment:


New changeset 6c51d518800cdda7ba16ae163be0d211d2c4fa12 by jcea in branch 
'master':
bpo-32659: Solaris "stat" should support "st_fstype" (#5307)
https://github.com/python/cpython/commit/6c51d518800cdda7ba16ae163be0d211d2c4fa12


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32660] Solaris should support constants like termios' FIONREAD

2018-01-28 Thread Jesús Cea Avión


Jesús Cea Avión  added the comment:


New changeset f0a95f27c043e847a23940534fdfc53e1b3e31a1 by jcea in branch 
'master':
bpo-32660: Solaris should support constants like termios' FIONREAD (#5328)
https://github.com/python/cpython/commit/f0a95f27c043e847a23940534fdfc53e1b3e31a1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29571] test_re is failing when local is set for `en_IN`

2018-01-28 Thread Nick Coghlan


Nick Coghlan  added the comment:

Hmm, even though we reverted the original test_re based change, and the initial 
attempted fix for bpo-20087 was also reverted, I'm still not currently seeing 
the failure for:

LANG=en_IN.utf8 ./python -m test -v test_re

I do have the locale installed, so it's not a result of falling back to the C 
locale and that getting coerced to C.UTF-8:

$ LANG=en_IN.utf8 locale -k currency_symbol
currency_symbol="₹"

Jaysinh, are you still seeing this test failure on a fresh checkout?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29571] test_re is failing when local is set for `en_IN`

2018-01-28 Thread Nick Coghlan


Nick Coghlan  added the comment:

Hmm, this actually works for me on Fedora 27 even if I go back to 
1b3d88eb33085e90af729c4c2f78b5ba1b942b1e, the commit just before the initially 
merged (and subsequently reverted) test change above.

Unassigning, since I can't readily reproduce it myself.

--
assignee: ncoghlan -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31687] test_semaphore_tracker() of test_multiprocessing_spawn fails randomly (race condition?)

2018-01-28 Thread Nick Coghlan


Nick Coghlan  added the comment:

A warning I'm sometimes seeing currently on successful test runs is as follows:

--
/home/ncoghlan/devel/cpython/Lib/multiprocessing/semaphore_tracker.py:55: 
UserWarning: semaphore_tracker: process died unexpectedly, relaunching.  Some 
semaphores might leak.
  warnings.warn('semaphore_tracker: process died unexpectedly, '
--

So it may be that the system has to be under load for the test suite to notice 
that failure.

--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32688] weird comment out line of code

2018-01-28 Thread Xiang Zhang


Xiang Zhang  added the comment:

Ahh, I figure out that the line is useless and can't affect any logic then. So 
the analyzer is right! Sorry for the bother Brett.

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21417] Compression level for zipfile

2018-01-28 Thread bbayles


Change by bbayles :


--
nosy: +bbayles

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21417] Compression level for zipfile

2018-01-28 Thread bbayles


Change by bbayles :


--
keywords: +patch
pull_requests: +5222
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1692335] Fix exception pickling: Move initial args assignment to BaseException.new

2018-01-28 Thread Jason R. Coombs


Jason R. Coombs  added the comment:

@slallum, That does seem to be a problem, though I do observe that the issue 
reported by bdb with CalledProcessError is no longer an issue:

>>> import subprocess, pickle
>>> try:
...   subprocess.check_call(['python', '-c', 'raise SystemExit(1)'])
... except Exception as e:
...   pickle.loads(pickle.dumps(e))
... 
CalledProcessError(1, ['python', '-c', 'raise SystemExit(1)'])

Looking into how CalledProcessError is defined 
(https://github.com/python/cpython/blob/79db11ce99332d62917be9d03b31494b1ff2f96a/Lib/subprocess.py#L60)
 may shed some light on the recommended way to make a pickleable Exception 
class that takes more than one argument.

Hmm. It seems it does it by not calling the superclass __init__. Indeed, 
following that model it seems to work:

import pickle
class MultipleArgumentsError(Exception):
def __init__(self, a, b):
self.a = a
self.b = b

err = pickle.loads(pickle.dumps(MultipleArgumentsError('a', 'b')))
assert err.a == 'a'
assert err.b == 'b'

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32654] Fixes Python for Android API 19

2018-01-28 Thread Chih-Hsuan Yen


Chih-Hsuan Yen  added the comment:

Here are some ideas after testing:

* Testing environment:
 - My building scripts at https://github.com/yan12125/python3-android/
 - Android NDK r16b
 - Google's emulator image 'system-images;android-19;default;x86'

* Ideas/findings:
 - Locale emulation for setlocale() no longer works as _locale builds fine.

>>> locale.setlocale(locale.LC_ALL, None)
Traceback (most recent call last):
  File "", line 1, in 
  File "/data/local/tmp/python3/usr/lib/python3.7/locale.py", line 608, in 
setlocale
return _setlocale(category, locale)
locale.Error: locale query failed

 - Declarations for mmap/sendfile shouldn't be necessary. In Android NDK r16b, 
sendfile() is defined if __USE_FILE_OFFSET64 is not defined: (from 
$ANDROID_NDK/sysroot/usr/include/sys/sendfile.h)

#if defined(__USE_FILE_OFFSET64)

#if __ANDROID_API__ >= 21
ssize_t sendfile(int __out_fd, int __in_fd, off_t* __offset, size_t __count) 
__RENAME(sendfile64) __INTRODUCED_IN(21);
#endif /* __ANDROID_API__ >= 21 */

#else
ssize_t sendfile(int __out_fd, int __in_fd, off_t* __offset, size_t __count);
#endif

#if __ANDROID_API__ >= 21
ssize_t sendfile64(int __out_fd, int __in_fd, off64_t* __offset, size_t 
__count) __INTRODUCED_IN(21);
#endif /* __ANDROID_API__ >= 21 */

__USE_FILE_OFFSET64 is defined as _FILE_OFFSET_BITS is defined to 64 in 
pyconfig.h. An NDK developer suggest "stop defining _FILE_OFFSET_BITS=64 on 
32-bit Android." 
(https://github.com/android-ndk/ndk/issues/536#issuecomment-333197557) Either 
disabling large file support on Android or simply don't define 
_FILE_OFFSET_BITS on Android should work.   (Android does not use 
_LARGEFILE_SOURCE)

 - SIGRTMIN/SIGRTMAX: This is a bug on older NDK. r15 has fixed it 
(https://github.com/android-ndk/ndk/issues/352). I propose to wait until 
CPython builds with NDK r15+. I don't like adding patches for a known bug in 
older toolchains and revert them later.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

1 2 3 >

1 - 100 of 202 matches

Mail list logo